@bongos/core 1.21.104 → 1.21.106

package/modules/lifecycle/check-rollup.js

@@ -39,4 +39,14 @@ function readCheckRollup(rollup) {
   };
 }
 
-module.exports = { readCheckRollup, UNIT_REPORT_CONTEXT };
+// The conclusions that mean a check really FAILED (task 1004666). One set for both
+// readers: the laptop's ship-land.js (task 1003764) and the server's mergeBlockReason.
+// readCheckRollup maps a status context's state into `conclusion`, so PENDING and
+// EXPECTED (posted but unfinished, or required but not yet reported) land there too —
+// those are waiting, not red. The server reader used to count anything outside
+// SUCCESS/NEUTRAL/SKIPPED as failing, which named a still-running check as the reason
+// a PR was red and sent the publish reconciler after a regen-heal it did not need.
+const RED_CONCLUSIONS = new Set(['FAILURE', 'ERROR', 'TIMED_OUT', 'CANCELLED', 'ACTION_REQUIRED', 'STARTUP_FAILURE']);
+const isRedCheck = (c) => !!c && RED_CONCLUSIONS.has(String(c.conclusion || '').toUpperCase());
+
+module.exports = { readCheckRollup, UNIT_REPORT_CONTEXT, RED_CONCLUSIONS, isRedCheck };

package/modules/lifecycle/github-push.js

@@ -40,7 +40,7 @@ const os = require('node:os');
 const path = require('node:path');
 const { promisify } = require('node:util');
 const { repoInfo, userAgent } = require('../../src/module-api');
-const { readCheckRollup, UNIT_REPORT_CONTEXT } = require('./check-rollup');
+const { readCheckRollup, UNIT_REPORT_CONTEXT, isRedCheck } = require('./check-rollup'); // isRedCheck: only a FAILED check is red, never a pending one (task 1004666)
 const { loadRepoInfo } = repoInfo;
 
 const execFileP = promisify(execFile);
@@ -951,10 +951,6 @@ async function getMergeState({ branch }, deps = {}) {
   };
 }
 
-// A non-passing check conclusion (everything that isn't a clean success/skip).
-const _BAD_CHECK = (c) =>
-  c.conclusion && !['SUCCESS', 'NEUTRAL', 'SKIPPED'].includes(String(c.conclusion).toUpperCase());
-
 // Human-readable reason a not-yet-merged PR isn't mergeable, surfaced to a
 // credential-less session so it reports the truth instead of guessing.
 function mergeBlockReason(s) {
@@ -967,7 +963,7 @@ function mergeBlockReason(s) {
   if (s.review_decision === 'CHANGES_REQUESTED') return 'changes_requested';
   if (s.review_decision === 'REVIEW_REQUIRED') return 'review_required';
   if (s.merge_state === 'BLOCKED') {
-    const bad = s.checks.filter(_BAD_CHECK);
+    const bad = s.checks.filter(isRedCheck);
     if (bad.length) return `failing_check:${bad[0].name}`;
     // Red, and the failing check is one of the nulled nodes: say the list is blind
     // rather than guess "review or pending", which sent a ship retrying (task 1003988).
@@ -975,7 +971,7 @@ function mergeBlockReason(s) {
     return 'blocked_required_review_or_pending_check';
   }
   if (s.merge_state === 'UNSTABLE') {
-    const bad = s.checks.filter(_BAD_CHECK);
+    const bad = s.checks.filter(isRedCheck);
     return bad.length ? `non_required_check_failing:${bad[0].name}` : 'non_required_check_pending';
   }
   if (s.mergeable === 'UNKNOWN' || s.merge_state === 'UNKNOWN' || s.merge_state == null) {

package/modules/public-landing/public/projects-hall-live.states.json

@@ -1,5 +1,5 @@
 {
-  "_": "The create wizard done panel once the hall answers (task 1004503): the same walk as projects.states.json in-new-done, with the instance list aliased so the project just filed (id 102) is live and verified up. The invite box opens only now; in-new-done in the main file pictures it shut while the project is set up. Rendered by name: node modules/ui-design/kit/render.js --states modules/public-landing/public/projects-hall-live.states.json",
+  "_": "The create wizard done panel once the hall answers (task 1004503): the same walk as projects.states.json in-new-done, with the instance list aliased so the project just filed (id 102) is live and verified up, with its GitHub app approved, installed and signed in (since task 1004683 part 03 says it is alive only once every required fact is done). The invite box and the Enter Genesis door open only now; in-new-done in the main file pictures it shut while the project is set up. Rendered by name: node modules/ui-design/kit/render.js --states modules/public-landing/public/projects-hall-live.states.json",
   "page": "/projects",
   "surface": "public-landing",
   "modes": [
@@ -131,7 +131,8 @@
           "#panel-done",
           "#wizInvite",
           "#wizInviteWho",
-          "#humanSteps"
+          "#doneAlive",
+          "#enterGenesis"
         ],
         "hidden": [
           "#hop",

package/modules/public-landing/public/projects-setup.states.json

@@ -0,0 +1,91 @@
+{
+  "_": "Part 03 after Create, the five scenarios of the design of record docs/design/mocks/day-night-rooms/setup-status.html (task 1004683): the same page and stub, the instance list aliased to one project per scenario, each opened by URL the way the GitHub return route lands a founder (?view=new&id=<project>). The GitHub halves of each owner read come from the REAL projections (see the fixture's note). The room follows the viewer's clock, so these renders picture whichever room the machine's clock gives, and the stub serves a local address with no apex base, so the Approve fact pictures its local-platform branch (GitHub cannot reach a local platform) rather than Connect GitHub. The day and night shots attached to the task were taken with the browser's timezone moved and the apex stamped. Rendered by name: node modules/ui-design/kit/render.js --states modules/public-landing/public/projects-setup.states.json",
+  "page": "/projects",
+  "surface": "public-landing",
+  "modes": [
+    "dark"
+  ],
+  "modeQuery": false,
+  "stub": {
+    "fixtures": {
+      "provisioning-instances": "provisioning-instances-setup"
+    }
+  },
+  "ignoreRequests": [
+    "/api/(gds|bongos)/me$",
+    "/my-projects",
+    "/github/orgs",
+    "/env-manifest$"
+  ],
+  "ignoreConsole": [
+    "/api/(gds|bongos)/me",
+    "\\b401\\b",
+    "\\b404\\b",
+    "Unauthorized"
+  ],
+  "ignoreControls": [
+    ".skip",
+    ".vh"
+  ],
+  "states": {
+    "setup-just-created": {
+      "auth": true,
+      "url": "/projects?view=new&id=201",
+      "actions": [["wait", 1500]],
+      "expect": {
+        "visible": ["#panel-done", "#setupNow", "#homeFacts", "#ghFacts", "#hopLink", "#homeFacts [data-fact=\"server\"].now"],
+        "hidden": ["#wizParts", "#hop", "#doneAlive", "#aaPick"],
+        "text": [["#donePartT", "Getting kestrel ready"], ["#ghState", "1 of 6 done"]]
+      }
+    },
+    "setup-waiting-on-github": {
+      "auth": true,
+      "url": "/projects?view=new&id=202",
+      "actions": [["wait", 1500]],
+      "expect": {
+        "visible": ["#panel-done", "#homeFacts [data-fact=\"answers\"].now"],
+        "hidden": ["#hop", "#doneAlive", "#aaPick"],
+        "text": [["#ghState", "2 of 6 done"]]
+      }
+    },
+    "setup-installing": {
+      "auth": true,
+      "url": "/projects?view=new&id=203",
+      "actions": [["wait", 1500]],
+      "expect": {
+        "visible": ["#panel-done", "#ghFacts [data-fact=\"install\"].you"],
+        "hidden": ["#hop", "#doneAlive"],
+        "text": [["#ghState", "4 of 6 done"]]
+      }
+    },
+    "setup-stopped": {
+      "auth": true,
+      "url": "/projects?view=new&id=204",
+      "actions": [["wait", 1500]],
+      "expect": {
+        "visible": ["#panel-done", "#ghFacts [data-fact=\"install\"].bad [data-action=\"pick-up\"]"],
+        "hidden": ["#hop", "#doneAlive"],
+        "text": [["#ghState", "5 of 6 done"]]
+      }
+    },
+    "setup-all-done": {
+      "auth": true,
+      "url": "/projects?view=new&id=205",
+      "actions": [["wait", 1500]],
+      "expect": {
+        "visible": ["#panel-done", "#doneAlive", "#enterGenesis"],
+        "hidden": ["#hop", "#hopLink"],
+        "text": [["#ghState", "ready ✓"], ["#done-h", "wren is alive."], ["#enterGenesis", "Enter Genesis"]]
+      }
+    },
+    "setup-cloud-hop-open": {
+      "auth": true,
+      "url": "/projects?view=new&id=201",
+      "actions": [["wait", 1200], ["click", "#hopLink"], ["wait", 600]],
+      "expect": {
+        "visible": ["#hop", "#hopCanvas"],
+        "attr": [["#hopLink", "aria-expanded", "true"]]
+      }
+    }
+  }
+}