@bongos/core 1.21.1 → 1.21.2

package/docs/page-readings.json

@@ -5,7 +5,7 @@
   "adr": "0341 D3",
   "reread": "node scripts/gds/page-reader.js --stale",
   "how": ["Generated by node scripts/gds/page-reader.js (BV2.TW04, task 1004315; ADR 0341 D3). Do not hand-edit.","One entry per page of docs/page-inventory.json. Lines are in page order: the default state first, and a line only another state shows sits where that state shows it, with its state named.","placement: placed = a docs/copy-registry.json row renders it (file, line, string_id); shared = shell text every page of the surface carries (top bar, sidebar, footer), with its row when the registry has one; unplaced = the registry cannot place it (a rewrite becomes an engineer task, ADR 0341 D4).","text keeps {…} where the registry row has a hole, or where a value the page read from its API was filled in. A string that is only such data is counted under omitted.data, not listed.","reading_hash is over the non-shared lines (key, section, text); files_hash is over the page's inventory files. --check compares files_hash only and never opens a browser.","Rendered through the hall-preview harness (hall) and the ui-design kit stub (landing, status), at 1280x800 with the clock pinned, so a reading is the fixture world's page."],
-  "counts": {"pages":40,"lines":4595,"placed":1619,"shared":245,"unplaced":2731,"omitted_data":2272},
+  "counts": {"pages":40,"lines":4603,"placed":1619,"shared":245,"unplaced":2739,"omitted_data":2290},
   "pages": [
     {
       "id": "builders:atlas",
@@ -1364,7 +1364,7 @@
       "surface": "builders",
       "title": "Builders' Hall",
       "states_read": ["home","standing","standing-karma","out","founding","genesis","decide","demo"],
-      "files_hash": "e1f443b10a615ee9",
+      "files_hash": "8aae91616add6938",
       "reading_hash": "baed6b11d9ad5db4",
       "counts": {"lines":204,"placed":68,"shared":7,"unplaced":129},
       "omitted": {"data":182},
@@ -1373,7 +1373,7 @@
         {"key":"L0001","section":"skip link","text":"Skip to content","placement":"shared","file":"modules/hall-ui/public/shell.js","line":884,"string_id":"87cee78ca134"},
         {"key":"L0002","section":"top bar","text":"Standing","placement":"shared","state":"standing"},
         {"key":"L0003","section":"top bar","text":"Home","placement":"shared"},
-        {"key":"L0004","section":"top bar","text":"Welcome back, {…}.","placement":"shared","file":"modules/hall-ui/public/hall-render.js","line":599,"string_id":"0658f0358ffd"},
+        {"key":"L0004","section":"top bar","text":"Welcome back, {…}.","placement":"shared","file":"modules/hall-ui/public/hall-render.js","line":600,"string_id":"0658f0358ffd"},
         {"key":"L0005","section":"top bar","text":"Jump to…","placement":"shared","file":"modules/hall-ui/public/shell.js","line":495,"string_id":"eba610d25523"},
         {"key":"L0006","section":"top bar","text":"Ctrl K","placement":"shared"},
         {"key":"L0007","section":"Good morning, {…}","text":"Good morning, {…}","placement":"unplaced"},
@@ -1390,14 +1390,14 @@
         {"key":"L0018","section":"Good morning, {…}","text":"Member since {…}","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":566,"string_id":"df335a1224ae","state":"standing"},
         {"key":"L0019","section":"Good morning, {…}","text":"+1 karma in 30d","placement":"unplaced","state":"standing"},
         {"key":"L0020","section":"Good morning, {…}","text":"#2 on the leaderboard","placement":"unplaced"},
-        {"key":"L0021","section":"Good morning, {…}","text":"Preferred work:","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":580,"string_id":"ed8edd684547","state":"standing"},
-        {"key":"L0022","section":"Good morning, {…}","text":"Change in Settings →","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":580,"string_id":"0279db21e29a","state":"standing"},
+        {"key":"L0021","section":"Good morning, {…}","text":"Preferred work:","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":581,"string_id":"ed8edd684547","state":"standing"},
+        {"key":"L0022","section":"Good morning, {…}","text":"Change in Settings →","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":581,"string_id":"0279db21e29a","state":"standing"},
         {"key":"L0023","section":"Good morning, {…}","text":"karma","placement":"unplaced","state":"standing"},
         {"key":"L0024","section":"Standing","text":"Standing","placement":"unplaced"},
         {"key":"L0025","section":"Standing","text":"Credits","placement":"unplaced"},
-        {"key":"L0026","section":"Standing","text":"On the board","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":629,"string_id":"11a1905c76b2"},
+        {"key":"L0026","section":"Standing","text":"On the board","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":630,"string_id":"11a1905c76b2"},
         {"key":"L0027","section":"Standing","text":"{…} of {…}","placement":"placed","file":"modules/hall-ui/public/sky-panel.js","line":120,"string_id":"73c1372b43d9"},
-        {"key":"L0028","section":"Standing","text":"Preferred work","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":629,"string_id":"f03d68e60416"},
+        {"key":"L0028","section":"Standing","text":"Preferred work","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":630,"string_id":"f03d68e60416"},
         {"key":"L0029","section":"Standing","text":"View full standing →","placement":"placed","file":"modules/hall-ui/public/hall-widgets.js","line":86,"string_id":"4babdfeaf27f"},
         {"key":"L0030","section":"Goals","text":"Goals","placement":"unplaced"},
         {"key":"L0031","section":"Goals","text":"The shared goals you’ve joined. Browse, join, and leave goals — and read their criteria — on the","placement":"placed","file":"modules/hall-ui/public/goals.js","line":94,"string_id":"fc422cced9e3"},
@@ -1406,9 +1406,9 @@
         {"key":"L0034","section":"Goals","text":"open","placement":"placed","file":"modules/hall-ui/public/approval-queue.js","line":163,"string_id":"9a803563c948","occurrences":5},
         {"key":"L0035","section":"Goals","text":"All 26 goals →","placement":"unplaced"},
         {"key":"L0036","section":"Needs your attention13","text":"Needs your attention","placement":"placed","file":"modules/hall-ui/public/goal-inbox.js","line":597,"string_id":"7def635421ea"},
-        {"key":"L0037","section":"From the system","text":"From the system","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":707,"string_id":"d32c5e058d1e"},
+        {"key":"L0037","section":"From the system","text":"From the system","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":708,"string_id":"d32c5e058d1e"},
         {"key":"L0038","section":"From the system","text":"{…} and {…}","placement":"placed","file":"modules/hall-ui/public/profile-nudge.js","line":77,"string_id":"56b00d773232","occurrences":2},
-        {"key":"L0039","section":"From the system","text":"Open the Board Room","placement":"placed","file":"modules/hall-ui/public/genesis-home.js","line":201,"string_id":"fe9986a9d821"},
+        {"key":"L0039","section":"From the system","text":"Open the Board Room","placement":"placed","file":"modules/hall-ui/public/genesis-home.js","line":198,"string_id":"fe9986a9d821"},
         {"key":"L0040","section":"Ideas awaiting triage 151","text":"Ideas awaiting triage","placement":"placed","file":"modules/hall-ui/public/builders.js","line":897,"string_id":"e181637c5a5e"},
         {"key":"L0041","section":"Ideas awaiting triage 151","text":"Triage","placement":"unplaced","occurrences":5},
         {"key":"L0042","section":"Ideas awaiting triage 151","text":"…{…} more open ideas — triage clears them one at a time.","placement":"placed","file":"modules/hall-ui/public/builders.js","line":895,"string_id":"e35f11bdc5d7"},
@@ -1474,8 +1474,8 @@
         {"key":"L0102","section":"Progress","text":"Progress","placement":"unplaced","state":"standing"},
         {"key":"L0103","section":"Progress","text":"How your output has changed over time — work shipped, cost and time per work, and how reviews held up.","placement":"placed","file":"modules/hall-ui/public/hall-widgets.js","line":213,"string_id":"298ff22576ee","state":"standing"},
         {"key":"L0104","section":"Progress","text":"You","placement":"placed","file":"modules/hall-ui/public/board-room.js","line":440,"string_id":"8e527ab12334","state":"standing","occurrences":3},
-        {"key":"L0105","section":"Progress","text":"All builders","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":1180,"string_id":"8b736e365191","state":"standing","occurrences":3},
-        {"key":"L0106","section":"Progress","text":"Kind of work","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":1145,"string_id":"e3b473af2f69","state":"standing"},
+        {"key":"L0105","section":"Progress","text":"All builders","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":1181,"string_id":"8b736e365191","state":"standing","occurrences":3},
+        {"key":"L0106","section":"Progress","text":"Kind of work","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":1146,"string_id":"e3b473af2f69","state":"standing"},
         {"key":"L0107","section":"Progress","text":"All work","placement":"unplaced","state":"standing"},
         {"key":"L0108","section":"Progress","text":"bug (11)","placement":"unplaced","state":"standing"},
         {"key":"L0109","section":"Progress","text":"Works {…}","placement":"unplaced","state":"standing"},
@@ -1495,7 +1495,7 @@
         {"key":"L0123","section":"Progress","text":"total $1241.96","placement":"unplaced","state":"standing"},
         {"key":"L0124","section":"Progress","text":"no data in window","placement":"unplaced","state":"standing"},
         {"key":"L0125","section":"Progress","text":"{…} of {…}","placement":"placed","file":"modules/hall-ui/public/sky-panel.js","line":120,"string_id":"73c1372b43d9","state":"standing"},
-        {"key":"L0126","section":"Progress","text":"Kinds of work shipped","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":1258,"string_id":"7d6eaa8d4514","state":"standing"},
+        {"key":"L0126","section":"Progress","text":"Kinds of work shipped","placement":"placed","file":"modules/hall-ui/public/hall-render.js","line":1259,"string_id":"7d6eaa8d4514","state":"standing"},
         {"key":"L0127","section":"Achievements","text":"Achievements","placement":"unplaced","state":"standing"},
         {"key":"L0128","section":"Achievements","text":"Eight achievements recognize sustained contribution. Earned ones are highlighted; the rest show what’s left to do.","placement":"placed","file":"modules/hall-ui/public/hall-widgets.js","line":228,"string_id":"854a21d2eb39","state":"standing"},
         {"key":"L0129","section":"Achievements","text":"Won {…}","placement":"placed","file":"modules/hall-ui/public/builders.js","line":477,"string_id":"c5fd76a9e03d","state":"standing","occurrences":6},
@@ -2490,11 +2490,11 @@
       "id": "builders:roster",
       "surface": "builders",
       "title": "Builders",
-      "states_read": ["roster","search","out"],
-      "files_hash": "df9d73fa272f78f0",
-      "reading_hash": "e96fecce27a9bed3",
-      "counts": {"lines":28,"placed":8,"shared":5,"unplaced":15},
-      "omitted": {"data":40},
+      "states_read": ["roster","artists","search","out"],
+      "files_hash": "a9ce996d0130159f",
+      "reading_hash": "1cf32981ae9e428e",
+      "counts": {"lines":36,"placed":8,"shared":5,"unplaced":23},
+      "omitted": {"data":58},
       "notes": [],
       "lines": [
         {"key":"L0001","section":"skip link","text":"Skip to content","placement":"shared","file":"modules/hall-ui/public/shell.js","line":884,"string_id":"87cee78ca134"},
@@ -2503,28 +2503,36 @@
         {"key":"L0004","section":"top bar","text":"Ctrl K","placement":"shared"},
         {"key":"L0005","section":"Builders","text":"Builders","placement":"unplaced"},
         {"key":"L0006","section":"Builders","text":"{…} project{…}","placement":"placed","file":"modules/hall-ui/public/fleet.js","line":39,"string_id":"771bef3d31b5"},
-        {"key":"L0007","section":"The roster13","text":"The roster","placement":"placed","file":"modules/hall-ui/public/roster.html","line":36,"string_id":"38ce5d68c182"},
-        {"key":"L0008","section":"The roster13","text":"Search","placement":"unplaced"},
-        {"key":"L0009","section":"The roster13","text":"name or login","placement":"unplaced","attr":"placeholder"},
-        {"key":"L0010","section":"The roster13","text":"Sort","placement":"unplaced"},
-        {"key":"L0011","section":"The roster13","text":"place","placement":"unplaced"},
-        {"key":"L0012","section":"The roster13","text":"rank","placement":"unplaced"},
-        {"key":"L0013","section":"The roster13","text":"most karma","placement":"unplaced"},
-        {"key":"L0014","section":"The roster13","text":"{…} tokens","placement":"placed","file":"modules/hall-ui/public/sessions.js","line":170,"string_id":"955499559f0a"},
-        {"key":"L0015","section":"The roster13","text":"Place","placement":"unplaced"},
-        {"key":"L0016","section":"The roster13","text":"Builder","placement":"unplaced"},
-        {"key":"L0017","section":"The roster13","text":"Rank","placement":"unplaced"},
-        {"key":"L0018","section":"The roster13","text":"Credits","placement":"unplaced"},
-        {"key":"L0019","section":"The roster13","text":"Karma","placement":"unplaced"},
-        {"key":"L0020","section":"The roster13","text":"Tokens","placement":"unplaced"},
-        {"key":"L0021","section":"The roster13","text":"No builder on the roster matches that search.","placement":"unplaced","state":"search"},
-        {"key":"L0022","section":"The roster13","text":"B","placement":"unplaced","occurrences":2},
-        {"key":"L0023","section":"The roster13","text":"{…} of {…}","placement":"placed","file":"modules/hall-ui/public/sky-panel.js","line":120,"string_id":"73c1372b43d9"},
-        {"key":"L0024","section":"The roster13","text":"Per page","placement":"placed","file":"modules/hall-ui/public/hall-kit.js","line":74,"string_id":"4a46b478edaf"},
-        {"key":"L0025","section":"The roster13","text":"‹ Prev","placement":"placed","file":"modules/hall-ui/public/hall-kit.js","line":74,"string_id":"de8fa5223aee"},
-        {"key":"L0026","section":"The roster13","text":"Page {…} of {…}","placement":"placed","file":"modules/hall-ui/public/hall-kit.js","line":112,"string_id":"15a49bf15007"},
-        {"key":"L0027","section":"The roster13","text":"Next ›","placement":"placed","file":"modules/hall-ui/public/hall-kit.js","line":74,"string_id":"f52ba261d930"},
-        {"key":"L0028","section":"footer","text":"Sign out","placement":"shared","file":"modules/hall-ui/public/shell.js","line":471,"string_id":"1883ad7f07fc"}
+        {"key":"L0007","section":"The roster15","text":"The roster","placement":"placed","file":"modules/hall-ui/public/roster.html","line":36,"string_id":"38ce5d68c182"},
+        {"key":"L0008","section":"The roster15","text":"Everyone","placement":"unplaced"},
+        {"key":"L0009","section":"The roster15","text":"Engineers","placement":"unplaced"},
+        {"key":"L0010","section":"The roster15","text":"Artists","placement":"unplaced"},
+        {"key":"L0011","section":"The roster15","text":"Ideators","placement":"unplaced"},
+        {"key":"L0012","section":"The roster15","text":"Search","placement":"unplaced"},
+        {"key":"L0013","section":"The roster15","text":"name or login","placement":"unplaced","attr":"placeholder"},
+        {"key":"L0014","section":"The roster15","text":"Sort","placement":"unplaced"},
+        {"key":"L0015","section":"The roster15","text":"place","placement":"unplaced"},
+        {"key":"L0016","section":"The roster15","text":"rank","placement":"unplaced"},
+        {"key":"L0017","section":"The roster15","text":"most karma","placement":"unplaced"},
+        {"key":"L0018","section":"The roster15","text":"{…} tokens","placement":"placed","file":"modules/hall-ui/public/sessions.js","line":170,"string_id":"955499559f0a"},
+        {"key":"L0019","section":"The roster15","text":"Place","placement":"unplaced"},
+        {"key":"L0020","section":"The roster15","text":"Builder","placement":"unplaced"},
+        {"key":"L0021","section":"The roster15","text":"Roles","placement":"unplaced"},
+        {"key":"L0022","section":"The roster15","text":"Rank","placement":"unplaced"},
+        {"key":"L0023","section":"The roster15","text":"Credits as {…}","placement":"unplaced","state":"artists"},
+        {"key":"L0024","section":"The roster15","text":"Credits","placement":"unplaced"},
+        {"key":"L0025","section":"The roster15","text":"Karma","placement":"unplaced"},
+        {"key":"L0026","section":"The roster15","text":"Tokens","placement":"unplaced"},
+        {"key":"L0027","section":"The roster15","text":"No builder on the roster matches that search.","placement":"unplaced","state":"search"},
+        {"key":"L0028","section":"The roster15","text":"Ideator","placement":"unplaced","occurrences":5},
+        {"key":"L0029","section":"The roster15","text":"Artist","placement":"unplaced","occurrences":3},
+        {"key":"L0030","section":"The roster15","text":"B","placement":"unplaced","occurrences":4},
+        {"key":"L0031","section":"The roster15","text":"{…} of {…}","placement":"placed","file":"modules/hall-ui/public/sky-panel.js","line":120,"string_id":"73c1372b43d9"},
+        {"key":"L0032","section":"The roster15","text":"Per page","placement":"placed","file":"modules/hall-ui/public/hall-kit.js","line":74,"string_id":"4a46b478edaf"},
+        {"key":"L0033","section":"The roster15","text":"‹ Prev","placement":"placed","file":"modules/hall-ui/public/hall-kit.js","line":74,"string_id":"de8fa5223aee"},
+        {"key":"L0034","section":"The roster15","text":"Page {…} of {…}","placement":"placed","file":"modules/hall-ui/public/hall-kit.js","line":112,"string_id":"15a49bf15007"},
+        {"key":"L0035","section":"The roster15","text":"Next ›","placement":"placed","file":"modules/hall-ui/public/hall-kit.js","line":74,"string_id":"f52ba261d930"},
+        {"key":"L0036","section":"footer","text":"Sign out","placement":"shared","file":"modules/hall-ui/public/shell.js","line":471,"string_id":"1883ad7f07fc"}
       ]
     },
     {
@@ -5027,7 +5035,7 @@
       "surface": "status",
       "title": "{{worldName}} — the public ledger",
       "states_read": ["default"],
-      "files_hash": "35acac6a3253f014",
+      "files_hash": "c63f0262868bc3e4",
       "reading_hash": "2853e52b66ba076c",
       "counts": {"lines":87,"placed":49,"shared":14,"unplaced":24},
       "omitted": {"data":89},
@@ -5036,7 +5044,7 @@
         {"key":"L0001","section":"top bar","text":"The Public Ledger of the City's Making","placement":"shared","file":"modules/status-ui/public/index.html","line":125,"string_id":"acdf97805931"},
         {"key":"L0002","section":"top bar","text":"A shipping container has washed ashore upon the coast south of Athens. About it a new civilization rises. Set out below: the city's affairs, openly recorded.","placement":"shared","file":"modules/status-ui/public/index.html","line":126,"string_id":"f4a664041da5"},
         {"key":"L0003","section":"top bar","text":"Cross into the city →","placement":"shared","file":"modules/status-ui/public/index.html","line":128,"string_id":"3aa071ef1142"},
-        {"key":"L0004","section":"top bar","text":"tablet last consulted at {…}","placement":"shared","file":"modules/status-ui/public/status.js","line":1169,"string_id":"c1e3c2212207"},
+        {"key":"L0004","section":"top bar","text":"tablet last consulted at {…}","placement":"shared","file":"modules/status-ui/public/status.js","line":1201,"string_id":"c1e3c2212207"},
         {"key":"L0005","section":"navigation","text":"Pulse","placement":"shared"},
         {"key":"L0006","section":"navigation","text":"Watch","placement":"shared"},
         {"key":"L0007","section":"navigation","text":"Architects","placement":"shared"},

package/migrations/core_270_craft_achievements.sql

@@ -0,0 +1,128 @@
+-- core_270_craft_achievements.sql — achievements for artist and ideator moments
+-- (task 1004438 / WA6.RP08, goal 1000095, criterion wa6-roles-read-true-in-public).
+--
+-- WHY. Every achievement was a claim or ship event, and the one art badge
+-- ("art-pipeline-shipper") fires when CODE touches art/ — it rewards engineering,
+-- not art. An artist who rewrites pages in the studio and an ideator whose thoughts
+-- become work earned nothing on the shelf. These seven are each keyed to a LEDGER
+-- fact the economy already books (credit_log), so they are awarded once, by the
+-- same reconcile every other achievement uses (modules/economy/achievements.js
+-- STATE_EVALUATORS), and backfilled below for work that already happened.
+--
+-- credit_bonus is 0 on all seven: they recognise work the ledger has already
+-- paid for, and a backfill that minted bonus credits for past work is a money
+-- decision this migration does not make.
+--
+-- A core migration, not an economy_* one: `achievements` and
+-- `builder_achievements` are core tables (modules/economy/CLAUDE.md, Tables).
+
+INSERT INTO achievements (id, name, description, icon, credit_bonus, sort_order) VALUES
+  ('first-thought-ignited', 'First Thought Ignited',
+   'A thought of yours became shipped work.',
+   '💡', 0, 90),
+  ('first-full-idea', 'First Full Idea',
+   'A Full Idea of yours passed the completeness bar.',
+   '📜', 0, 100),
+  ('first-board-ratification', 'Ratified by the Board',
+   'The board ratified an idea of yours.',
+   '🏛️', 0, 110),
+  ('thought-built-ten', 'A Thought That Built Ten',
+   'One thought of yours led to ten or more shipped tasks.',
+   '🌟', 0, 120),
+  ('first-page-approved', 'First Page Approved',
+   'A page you rewrote in Tweak Mode was approved and shipped.',
+   '🎨', 0, 130),
+  ('ten-pages-approved', 'Ten Pages Approved',
+   'Ten pages you rewrote in Tweak Mode were approved and shipped.',
+   '🖼️', 0, 140),
+  ('whole-surface-tweaked', 'A Whole Surface',
+   'Every page of one surface was rewritten by you and approved.',
+   '🗺️', 0, 150)
+ON CONFLICT (id) DO UPDATE
+  SET name         = EXCLUDED.name,
+      description  = EXCLUDED.description,
+      icon         = EXCLUDED.icon,
+      credit_bonus = EXCLUDED.credit_bonus,
+      sort_order   = EXCLUDED.sort_order;
+
+-- The misleading one, renamed rather than retired: builders who earned it keep it,
+-- and it now says what it is — engineering work on the art pipeline. The palette
+-- icon moves to First Page Approved, the artist's own badge.
+UPDATE achievements
+   SET name = 'Art Pipeline Engineer',
+       description = 'Ship engineering work on the art/ pipeline (code, not art; an artist earns First Page Approved).',
+       icon = '🛠️'
+ WHERE id = 'art-pipeline-shipper';
+
+-- ---- Backfill: everyone who already earned one, from the ledger ---------------
+-- Each unlock is stamped with the FIRST qualifying credit's time and task, so the
+-- shelf dates the moment, not this migration. ON CONFLICT DO NOTHING: re-running
+-- converges, and an unlock the live reconcile already wrote is left alone.
+-- "A Whole Surface" needs the page inventory, which is a file, not a table, so
+-- SQL cannot award it. It is backfilled by the lifecycle's periodic sweep, which
+-- runs economy's backfillCraftAchievements ONCE at every server start (so the
+-- deploy that applies this migration awards it within the first sweep), and by
+-- the reconcile on the artist's next approved page; by hand,
+-- `node scripts/gds/diagnose-achievements.js --apply`.
+
+-- the idea-stream and artist-lane prefixes, spelled as LIKE literals with the
+-- underscore escaped (modules/economy/credits.js IDEA_STREAM_REASON_PREFIXES,
+-- ARTIST_PAGE_REASON_PREFIX; tests/craft_achievements.mjs holds them together)
+INSERT INTO builder_achievements (builder_id, achievement_id, unlocked_at, unlocked_by_task_id)
+SELECT DISTINCT ON (builder_id) builder_id, 'first-thought-ignited', recorded_at, task_id
+  FROM credit_log
+ WHERE reason LIKE 'idea.credit.task\_ship:%' AND delta > 0
+ ORDER BY builder_id, recorded_at, id
+ON CONFLICT DO NOTHING;
+
+INSERT INTO builder_achievements (builder_id, achievement_id, unlocked_at, unlocked_by_task_id)
+SELECT DISTINCT ON (builder_id) builder_id, 'first-full-idea', recorded_at, task_id
+  FROM credit_log
+ WHERE reason LIKE 'idea.credit.full\_pass:%' AND delta > 0
+ ORDER BY builder_id, recorded_at, id
+ON CONFLICT DO NOTHING;
+
+INSERT INTO builder_achievements (builder_id, achievement_id, unlocked_at, unlocked_by_task_id)
+SELECT DISTINCT ON (builder_id) builder_id, 'first-board-ratification', recorded_at, task_id
+  FROM credit_log
+ WHERE reason LIKE 'idea.credit.governance\_pass:%' AND delta > 0
+ ORDER BY builder_id, recorded_at, id
+ON CONFLICT DO NOTHING;
+
+-- ten distinct shipped tasks paid under ONE idea (reason idea.credit.task_ship:<idea>:<task>);
+-- stamped at the tenth task's payment
+INSERT INTO builder_achievements (builder_id, achievement_id, unlocked_at, unlocked_by_task_id)
+SELECT DISTINCT ON (builder_id) builder_id, 'thought-built-ten', recorded_at, task_id
+  FROM (
+    SELECT builder_id, recorded_at, task_id, id,
+           DENSE_RANK() OVER (PARTITION BY builder_id, split_part(reason, ':', 2)
+                              ORDER BY first_paid) AS nth
+      FROM (
+        SELECT builder_id, recorded_at, task_id, id, reason,
+               MIN(recorded_at) OVER (PARTITION BY builder_id, split_part(reason, ':', 2), split_part(reason, ':', 3)) AS first_paid
+          FROM credit_log
+         WHERE reason LIKE 'idea.credit.task\_ship:%' AND delta > 0
+      ) per_task
+  ) ranked
+ WHERE nth >= 10
+ ORDER BY builder_id, recorded_at, id
+ON CONFLICT DO NOTHING;
+
+INSERT INTO builder_achievements (builder_id, achievement_id, unlocked_at, unlocked_by_task_id)
+SELECT DISTINCT ON (builder_id) builder_id, 'first-page-approved', recorded_at, task_id
+  FROM credit_log
+ WHERE reason LIKE 'tweak.page\_approved:%' AND delta > 0
+ ORDER BY builder_id, recorded_at, id
+ON CONFLICT DO NOTHING;
+
+-- the tenth approved page (one row per round, keyed on its task)
+INSERT INTO builder_achievements (builder_id, achievement_id, unlocked_at, unlocked_by_task_id)
+SELECT builder_id, 'ten-pages-approved', recorded_at, task_id
+  FROM (
+    SELECT builder_id, recorded_at, task_id,
+           ROW_NUMBER() OVER (PARTITION BY builder_id ORDER BY recorded_at, id) AS nth
+      FROM credit_log
+     WHERE reason LIKE 'tweak.page\_approved:%' AND delta > 0
+  ) pages
+ WHERE nth = 10
+ON CONFLICT DO NOTHING;

package/modules/economy/achievements.js

@@ -41,7 +41,7 @@ const streak = require('./streak');
 // getLockedAchievementsProgress/renderProgressText), moved from src/bongos/db.js,
 // reads the shared pool through the published doorway — a module never requires a
 // core internal. The evaluators above take a tx `client` from the caller.
-const { pool } = require('../../src/module-api');
+const { pool, resolveOptional } = require('../../src/module-api');
 
 async function alreadyUnlocked(client, builderId, achievementId) {
   const r = await client.query(
@@ -367,6 +367,88 @@ async function eligible_streak7(client, builderId) {
   return s.longest_streak >= 7;
 }
 
+// ---- the craft achievements (task 1004438 / WA6.RP08) --------------------------
+// An artist and an ideator earn on the LEDGER, not on a claim: each predicate
+// below is a fact credit_log already holds (the reason prefixes are economy's own,
+// the same strings the writers book and migrations/core_270 backfills from). None
+// needs a ship of the builder's own; reconcileAfterCraftCredit (below) runs them
+// the moment such a credit is booked.
+const IDEA_SHIP_LIKE = 'idea.credit.task\\_ship:%';
+const IDEA_FULL_LIKE = 'idea.credit.full\\_pass:%';
+const IDEA_BOARD_LIKE = 'idea.credit.governance\\_pass:%';
+const PAGE_LIKE = 'tweak.page\\_approved:%';
+const THOUGHT_TASKS = 10;
+const PAGES_MANY = 10;
+
+//
+// ONE READ FOR ALL SEVEN. craftFacts asks the builder's craft ledger once —
+// served by idx_credit_log_builder (builder_id, recorded_at), so it is that
+// person's rows, never the whole ledger — and every craft rule is a pure test of
+// its answer. The full reconcile and the craft-only one read the SAME facts
+// through the SAME rules (CRAFT_RULES), so the two paths cannot disagree about
+// who earned what. Within one reconcile the facts are read once and shared.
+const CRAFT_FACTS_SQL = `
+  SELECT bool_or(reason LIKE $2) AS ignited,
+         bool_or(reason LIKE $3) AS full_idea,
+         bool_or(reason LIKE $4) AS ratified,
+         COUNT(*) FILTER (WHERE reason LIKE $5)::int AS pages,
+         (SELECT COALESCE(MAX(n), 0)::int FROM (
+            SELECT COUNT(DISTINCT split_part(reason, ':', 3)) AS n
+              FROM credit_log
+             WHERE builder_id = $1 AND reason LIKE $2 AND delta > 0
+             GROUP BY split_part(reason, ':', 2)) per_thought) AS best_thought_tasks
+    FROM credit_log
+   WHERE builder_id = $1 AND delta > 0`;
+
+async function craftFacts(client, builderId) {
+  const r = await client.query(CRAFT_FACTS_SQL, [builderId, IDEA_SHIP_LIKE, IDEA_FULL_LIKE, IDEA_BOARD_LIKE, PAGE_LIKE]);
+  const row = r.rows[0] || {};
+  return {
+    ignited: row.ignited === true,
+    fullIdea: row.full_idea === true,
+    ratified: row.ratified === true,
+    pages: Number(row.pages) || 0,
+    bestThoughtTasks: Number(row.best_thought_tasks) || 0,
+  };
+}
+
+// Every page of one surface rewritten by this artist and approved: the studio's
+// own "N of M tweaked" per surface (copy-desk's `copy-desk.artistStats` port, the
+// one the profile header reads), so the inventory has one reader. Asked ONLY of a
+// builder with an approved page — anyone else structurally cannot earn it, and
+// the port is not free. A port that is absent or fails is "could not tell", never
+// a badge.
+async function wholeSurfaceTweaked(builderId, facts) {
+  if (!(facts.pages > 0)) return false;
+  const port = resolveOptional('copy-desk.artistStats');
+  if (typeof port !== 'function') return false;
+  const stats = await port(builderId);
+  const surfaces = (stats && Array.isArray(stats.surfaces)) ? stats.surfaces : [];
+  return surfaces.some((s) => Number(s.total) > 0 && Number(s.tweaked) >= Number(s.total));
+}
+
+// id → (facts, builderId) → boolean | Promise<boolean>, in sort order.
+const CRAFT_RULES = [
+  ['first-thought-ignited', (f) => f.ignited],
+  ['first-full-idea', (f) => f.fullIdea],
+  ['first-board-ratification', (f) => f.ratified],
+  // one thought, ten shipped tasks: stream 1's reason is idea.credit.task_ship:<idea>:<task>
+  ['thought-built-ten', (f) => f.bestThoughtTasks >= THOUGHT_TASKS],
+  ['first-page-approved', (f) => f.pages > 0],
+  ['ten-pages-approved', (f) => f.pages >= PAGES_MANY],
+  ['whole-surface-tweaked', (f, builderId) => wholeSurfaceTweaked(builderId, f)],
+];
+const CRAFT_IDS = CRAFT_RULES.map(([id]) => id);
+
+// The STATE_EVALUATORS form of a rule: read the facts once per reconcile (the
+// shared `ctx`), then test. diagnose-achievements.js reaches the rules this way.
+function craftEvaluator(rule) {
+  return async (client, builderId, ctx = {}) => {
+    if (!ctx.craftFacts) ctx.craftFacts = craftFacts(client, builderId);
+    return rule(await ctx.craftFacts, builderId);
+  };
+}
+
 // Ordered by achievements.sort_order so banners/backfill output read naturally.
 const STATE_EVALUATORS = [
   { id: 'first-ship',            fn: eligible_firstShip },
@@ -378,6 +460,7 @@ const STATE_EVALUATORS = [
   { id: 'subtractor',            fn: eligible_subtractor },
   { id: 'gds-shipper',           fn: eligible_gdsShipper },
   { id: 'breaking-the-100c-bar', fn: eligible_breaking100c },
+  ...CRAFT_RULES.map(([id, rule]) => ({ id, fn: craftEvaluator(rule) })),
 ];
 
 // Unlock every achievement the builder currently qualifies for but hasn't yet.
@@ -387,9 +470,10 @@ const STATE_EVALUATORS = [
 async function reconcileBuilderAchievements(client, builderId, opts = {}) {
   const { taskId = null } = opts;
   const results = [];
+  const ctx = {}; // shared by the craft rules: their facts are read once per reconcile
   for (const ev of STATE_EVALUATORS) {
     if (await alreadyUnlocked(client, builderId, ev.id)) continue;
-    if (await ev.fn(client, builderId)) {
+    if (await ev.fn(client, builderId, ctx)) {
       const unlocked = await unlockAchievement(client, builderId, ev.id, taskId);
       if (unlocked) results.push(unlocked);
     }
@@ -397,6 +481,83 @@ async function reconcileBuilderAchievements(client, builderId, opts = {}) {
   return results;
 }
 
+// reconcileCraftAchievements — ONLY the seven craft rules, in two reads: what the
+// builder already holds of them, then (only if anything is left) their craft
+// facts. The payout hook below runs this, not the full sixteen-evaluator
+// reconcile: an idea credit or an approved page cannot change a streak, a claim
+// count or a shipped diff, so asking about those on every payment is waste.
+async function reconcileCraftAchievements(client, builderId, opts = {}) {
+  const { taskId = null } = opts;
+  const held = await client.query(
+    'SELECT achievement_id FROM builder_achievements WHERE builder_id = $1 AND achievement_id = ANY($2::text[])',
+    [builderId, CRAFT_IDS]
+  );
+  const have = new Set((held.rows || []).map((r) => r.achievement_id));
+  const open = CRAFT_RULES.filter(([id]) => !have.has(id));
+  if (!open.length) return [];
+  const facts = await craftFacts(client, builderId);
+  const results = [];
+  for (const [id, rule] of open) {
+    if (await rule(facts, builderId)) {
+      const unlocked = await unlockAchievement(client, builderId, id, taskId);
+      if (unlocked) results.push(unlocked);
+    }
+  }
+  return results;
+}
+
+// backfillCraftAchievements — the part of the backfill a migration cannot do.
+// migrations/core_270 backfills six badges from the ledger in SQL, but "A Whole
+// Surface" needs the page inventory, which is a file the database never sees. So
+// the lifecycle's periodic sweep (publish-reconciler.js) runs this ONCE per
+// process start: every builder the craft ledger has paid, through the craft-only
+// reconcile, in id order, bounded. Idempotent, so a restart that runs it again
+// unlocks nothing twice. Returns { checked, unlocked }.
+async function backfillCraftAchievements({ client = null, limit = 500 } = {}) {
+  const q = client || pool;
+  const { rows } = await q.query(
+    `SELECT DISTINCT builder_id FROM credit_log
+      WHERE delta > 0 AND (reason LIKE $1 OR reason LIKE $2 OR reason LIKE $3 OR reason LIKE $4)
+      ORDER BY builder_id
+      LIMIT $5`,
+    [IDEA_SHIP_LIKE, IDEA_FULL_LIKE, IDEA_BOARD_LIKE, PAGE_LIKE, limit]
+  );
+  let unlocked = 0;
+  for (const r of rows) {
+    const got = await reconcileAfterCraftCredit(q, r.builder_id);
+    unlocked += got.length;
+  }
+  return { checked: rows.length, unlocked };
+}
+
+// reconcileAfterCraftCredit — the craft writers' hook (task 1004438). An idea
+// stream or an approved page pays a builder inside SOMEONE ELSE'S ship (or an
+// idea route's own read), so the ship-time reconcile — which runs for the shipper
+// — never reaches the ideator or the artist. credits.js calls this for each payee
+// it just booked. It can never fail the payment: on a transaction client it runs
+// under a SAVEPOINT and rolls back to it on any error; on a pool (an idea route
+// pays through the pool, one idempotent statement) SAVEPOINT itself fails, nothing
+// is open to poison, and the reconcile runs plainly inside a try. Returns the
+// just-unlocked list, or [] on any failure.
+async function reconcileAfterCraftCredit(client, builderId, opts = {}) {
+  if (builderId == null || !client || typeof client.query !== 'function') return [];
+  let saved = false;
+  try {
+    await client.query('SAVEPOINT ach_craft_credit');
+    saved = true;
+  } catch (_) { /* not in a transaction: a pool */ }
+  try {
+    const out = await reconcileCraftAchievements(client, builderId, opts);
+    if (saved) await client.query('RELEASE SAVEPOINT ach_craft_credit');
+    return out;
+  } catch (_) {
+    if (saved) {
+      try { await client.query('ROLLBACK TO SAVEPOINT ach_craft_credit'); } catch (_e) { /* the caller's tx decides */ }
+    }
+    return [];
+  }
+}
+
 // -------------------------------------------------------------------------
 // Achievements — minimal getters added by migration 006_pms_v2.
 // Full evaluator + unlock writes live in src/bongos/achievements.js (task K1).
@@ -436,6 +597,10 @@ async function getLeaderboardWithAchievements(limit = 10, perBuilderCap = 5) {
             b.avatar_url,
             b.total_credits,
             b.rank,
+            -- task 1004437: karma too, as credits.leaderboard carries it, so the
+            -- hall's roster can read this one public list (with its roles) and
+            -- keep its karma column and lens. The profile already publishes it.
+            b.karma,
             COALESCE((
               SELECT array_agg(t.achievement_id ORDER BY t.sort_order)
                 FROM (
@@ -504,7 +669,14 @@ async function getLockedAchievementsProgress(builderId) {
              AND a.outcome = 'shipped' AND a.released_at IS NOT NULL
              AND b2.outcome = 'shipped' AND b2.released_at IS NOT NULL
              AND tstzrange(a.claimed_at, a.released_at)
-              && tstzrange(b2.claimed_at, b2.released_at))                     AS overlap_pairs
+              && tstzrange(b2.claimed_at, b2.released_at))                     AS overlap_pairs,
+         -- task 1004438: the craft counters, from the ledger
+         (SELECT COUNT(*) FROM credit_log
+           WHERE builder_id = $1 AND reason LIKE 'tweak.page\\_approved:%' AND delta > 0) AS pages_approved,
+         (SELECT COALESCE(MAX(n), 0) FROM (
+            SELECT COUNT(DISTINCT split_part(reason, ':', 3)) AS n FROM credit_log
+             WHERE builder_id = $1 AND reason LIKE 'idea.credit.task\\_ship:%' AND delta > 0
+             GROUP BY split_part(reason, ':', 2)) t)                           AS best_thought_tasks
      )
      SELECT a.id            AS achievement_id,
             a.name,
@@ -516,7 +688,9 @@ async function getLockedAchievementsProgress(builderId) {
             c.art_ships,
             c.pms_ships,
             c.total_credits,
-            c.overlap_pairs
+            c.overlap_pairs,
+            c.pages_approved,
+            c.best_thought_tasks
        FROM achievements a
        CROSS JOIN counters c
       WHERE NOT EXISTS (
@@ -594,6 +768,25 @@ function renderProgressText(row) {
       return artShips === 0
         ? 'needs one shipped task touching art/'
         : 'keep building';
+    // task 1004438: the craft achievements
+    case 'first-thought-ignited':
+      return 'needs one thought of yours to become shipped work';
+    case 'first-full-idea':
+      return 'needs one Full Idea to pass the completeness bar';
+    case 'first-board-ratification':
+      return 'needs the board to ratify one idea of yours';
+    case 'thought-built-ten': {
+      const best = Math.max(0, Math.min(Number(row.best_thought_tasks || 0), 10));
+      return `${best} of 10 shipped tasks from one thought`;
+    }
+    case 'first-page-approved':
+      return 'needs one page you rewrote to be approved';
+    case 'ten-pages-approved': {
+      const pages = Math.max(0, Math.min(Number(row.pages_approved || 0), 10));
+      return `${pages} of 10 pages approved`;
+    }
+    case 'whole-surface-tweaked':
+      return 'needs every page of one surface rewritten by you and approved';
     case 'gds-shipper':
       return pmsShips === 0
         ? 'needs one shipped task touching src/bongos/ or scripts/gds/'
@@ -612,6 +805,8 @@ module.exports = {
   evaluateAfterShip,
   evaluateAfterCreditAward,
   reconcileBuilderAchievements,
+  reconcileAfterCraftCredit,
+  backfillCraftAchievements,
   STATE_EVALUATORS,
   alreadyUnlocked,
   unlockAchievement,