@bongos/core 1.20.78 → 1.20.80

package/tests/release_core.mjs

@@ -0,0 +1,110 @@
+// tests/release_core.mjs — may this version be released? (task 1004298, ADR 0361)
+//
+// release-core.js is what publish.yml's release job asks before it moves the registry's `latest`
+// label — the label every project other than the platform hall is offered. These pin each way it
+// says no, and that a refusal never reaches the label.
+
+import { test } from 'node:test';
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const { releaseDecision, main } = require('../scripts/gds/release-core.js');
+
+const VERSIONS = ['1.20.70', '1.20.75', '1.20.80', '1.20.81-rc.1'];
+
+test('a published version newer than the release goes', () => {
+  const d = releaseDecision({ version: '1.20.80', versions: VERSIONS, latest: '1.20.70' });
+  assert.equal(d.go, true);
+  assert.match(d.reason, /was 1\.20\.70/);
+});
+
+test('with no release yet, any published stable version goes', () => {
+  assert.equal(releaseDecision({ version: '1.20.75', versions: VERSIONS, latest: null }).go, true);
+});
+
+test('the version already released is a harmless no-op, not a refusal', () => {
+  const d = releaseDecision({ version: '1.20.75', versions: VERSIONS, latest: '1.20.75' });
+  assert.equal(d.go, false);
+  assert.equal(d.noop, true);
+});
+
+test('an OLDER version is refused: it would move every project backwards', () => {
+  const d = releaseDecision({ version: '1.20.70', versions: VERSIONS, latest: '1.20.75' });
+  assert.equal(d.go, false);
+  assert.equal(d.noop, false);
+  assert.match(d.reason, /backwards/);
+});
+
+test('a version that was never published is refused', () => {
+  const d = releaseDecision({ version: '1.20.99', versions: VERSIONS, latest: '1.20.70' });
+  assert.equal(d.go, false);
+  assert.match(d.reason, /not published/);
+});
+
+test('anything that is not a plain x.y.z is refused before it reaches a command line', () => {
+  for (const v of ['', '1.20', 'latest', '1.20.80; rm -rf /', '1.20.81-rc.1', null, undefined]) {
+    assert.equal(releaseDecision({ version: v, versions: VERSIONS, latest: '1.20.70' }).go, false, String(v));
+  }
+});
+
+const run = (argv, registry) => {
+  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'release-core-'));
+  const out = path.join(dir, 'out');
+  const lines = [];
+  const code = main(argv, { env: { GITHUB_OUTPUT: out }, read: () => registry, log: (s) => lines.push(s), err: (s) => lines.push(s) });
+  return { code, output: fs.existsSync(out) ? fs.readFileSync(out, 'utf8') : '', lines };
+};
+
+test('the CLI writes go=true and exits 0 for a release', () => {
+  const r = run(['--version', '1.20.80'], { ok: true, versions: VERSIONS, latest: '1.20.75' });
+  assert.equal(r.code, 0);
+  assert.equal(r.output, 'go=true\n');
+});
+
+test('the CLI writes go=false and exits 1 for a refusal, so the label never moves', () => {
+  const r = run(['--version', '1.20.70'], { ok: true, versions: VERSIONS, latest: '1.20.75' });
+  assert.equal(r.code, 1);
+  assert.equal(r.output, 'go=false\n');
+});
+
+test('the CLI writes go=false and exits 0 for a double press', () => {
+  const r = run(['--version', '1.20.75'], { ok: true, versions: VERSIONS, latest: '1.20.75' });
+  assert.equal(r.code, 0);
+  assert.equal(r.output, 'go=false\n');
+});
+
+test('an unreadable registry is a refusal, never a guess', () => {
+  const r = run(['--version', '1.20.80'], { ok: false, error: 'E503' });
+  assert.equal(r.code, 1);
+  assert.equal(r.output, 'go=false\n');
+});
+
+// ── the workflow wires it as described ─────────────────────────────────────────
+
+const YML = fs.readFileSync(fileURLToPath(new URL('../.github/workflows/publish.yml', import.meta.url)), 'utf8');
+
+test('publish.yml: the release job asks release-core.js and moves `latest` only on go', () => {
+  assert.match(YML, /release_version:/, 'the dispatch input exists');
+  assert.match(YML, /node scripts\/gds\/release-core\.js --version "\$RELEASE_VERSION"/);
+  assert.match(YML, /if: steps\.decide\.outputs\.go == 'true'\s+run: npm dist-tag add "@bongos\/core@\$RELEASE_VERSION" latest/);
+});
+
+test('publish.yml: the version reaches the shell through env, never inline ${{ }} interpolation', () => {
+  assert.doesNotMatch(YML, /release-core\.js --version "\$\{\{/);
+  assert.doesNotMatch(YML, /dist-tag add "@bongos\/core@\$\{\{/);
+});
+
+test('publish.yml: a release dispatch never also runs the publish job', () => {
+  assert.match(YML, /github\.event_name == 'workflow_dispatch' && inputs\.release_version == ''/);
+});
+
+test('publish.yml: candidates publish under `next` only when the owner has armed it', () => {
+  assert.match(YML, /CANDIDATES: \$\{\{ vars\.PUBLISH_AS_CANDIDATE \}\}/);
+  assert.match(YML, /if \[ "\$CANDIDATES" = "1" \]; then TAG_ARGS="--tag next"; fi/);
+  assert.match(YML, /npm publish "\$TGZ" --access public \$TAG_ARGS/);
+});

package/tests/update_channel.mjs

@@ -348,6 +348,13 @@ t('normalizeFollow: released and candidates are the words; anything else reads a
   for (const v of [undefined, null, '', 'every', 'latest', 'next', 42]) assert.equal(uc.normalizeFollow(v), 'released', String(v));
 });
 
+t('followForShape: only the platform hall (control-plane) follows candidates (task 1004298)', () => {
+  assert.equal(uc.followForShape('control-plane'), 'candidates');
+  for (const shape of ['co-tenant', 'cloud-host', 'byo-host', undefined, null, 'bogus']) {
+    assert.equal(uc.followForShape(shape), 'released', `${shape} follows releases`);
+  }
+});
+
 t('versionsForFollow: candidates takes every version; released stops at the released label', () => {
   const available = ['1.19.1038', '1.19.1039', '1.19.1040', '1.19.1041'];
   assert.deepEqual(uc.versionsForFollow({ follow: 'candidates', available, released: '1.19.1039' }), available);

package/tests/upgrade_migrate.mjs

@@ -47,7 +47,7 @@ function adoptedProject({ installed = '1.19.312' } = {}) {
   return dir;
 }
 
-function scaffoldedProject(scripts = { migrate: init.INSTANCE_MIGRATE_SCRIPT, start: init.INSTANCE_START_SCRIPT }) {
+function scaffoldedProject(scripts = { migrate: init.INSTANCE_MIGRATE_SCRIPT, hall: init.INSTANCE_HALL_SCRIPT }) {
   const dir = fixture('upgrade-migrate-scaffold-');
   writeFileSync(path.join(dir, 'package.json'), `${JSON.stringify({ name: 'charter', private: true, scripts, dependencies: { '@bongos/core': '1.19.871' } }, null, 2)}\n`);
   return dir;