@bongos/core 1.20.48 → 1.20.50

package/tests/wizard_intent_resume.mjs

@@ -15,12 +15,13 @@
 // ruled out the task's other option (drop the record at a terminal state).
 //
 // The reset fires only when there is a SECOND DRAFT to lose, and the draft's own step is
-// what says so. A landed create clears DRAFT_KEY — but show(9) then persists the done
+// what says so. A landed create clears DRAFT_KEY — but show(11) then persists the done
 // panel's position straight back into it, so a plain "is there a draft?" test is always
 // yes and would skip the reset forever, leaving the finished project's name sitting in
 // the fresh form. (That is exactly what the first cut of this change shipped into a
 // render: "still watching Mercury" above a name field still reading "Mercury".) Only
-// steps 1-8 are wizard steps; anything else is the done panel's own bookkeeping.
+// steps 1-10 are wizard steps (1-8 before task 1004417's front door took 1 and 2);
+// anything else is the done panel's own bookkeeping.
 //
 // Harness: there is no jsdom in this repo, so this follows tests/wizard_draft_resume.mjs
 // and tests/project_door_ui.mjs — slice the real region out of the page's INLINE script
@@ -57,8 +58,8 @@ test('both slices are still findable (a rename must fail loudly, not silently pa
   assert.ok(offerSlice, 'paintResumeOffer() was not found in projects.html');
   assert.match(enterSlice, /if \(focus && !resumeIntent\) \{/, 'the intent branch is part of the slice');
   assert.match(enterSlice, /startProgress\(created\.id\);/, 'so is the resume branch it guards');
-  assert.match(enterSlice, /draft\.step >= 1 && draft\.step <= 8/,
-    'the STORED draft\'s step decides, not state.step — state.step is 9 for the whole life of a finished standup');
+  assert.match(enterSlice, /draft\.step >= 1 && draft\.step <= 10/,
+    'the STORED draft\'s step decides, not state.step — state.step is 11 for the whole life of a finished standup');
   assert.match(SCRIPT, /if \(created && created\.id\) \{ enterCreated\(created, !!focus\); return; \}/,
     'enter() still hands the created record straight to it');
 });
@@ -72,7 +73,7 @@ function runEnter({ focus, resumeIntent = false, draft = null, record }) {
   const calls = { show: [], resets: 0, offer: [], done: 0, progress: [], polls: 0, focused: 0 };
   // state.step is the DONE step for the whole life of a finished standup — the value
   // a draft-blind reading would have trusted
-  const state = { step: draft ? draft.step : 9, name: 'Mercury', slug: 'mercury', domain: '', mode: 'greenfield', noAddress: false, modules: null };
+  const state = { step: draft ? draft.step : 11, name: 'Mercury', slug: 'mercury', domain: '', mode: 'greenfield', noAddress: false, modules: null };
   const sandbox = {
     record, focus, resumeIntent, state,
     DRAFT_KEY: 'draft',
@@ -98,7 +99,7 @@ const REC = { id: 'inst-1', name: 'Acme', slug: 'acme', domain: 'acme.example',
 
 test('a reload / Back / identity settle (focus false) still resumes the done panel, watch and all', () => {
   const { calls, state } = runEnter({ focus: false, record: REC });
-  assert.deepEqual(calls.show, [[9, false]], 'the done panel, and no focus steal on a non-deliberate arrival');
+  assert.deepEqual(calls.show, [[11, false]], 'the done panel, and no focus steal on a non-deliberate arrival');
   assert.equal(calls.resets, 0, 'nothing is reset — this is the same standup continuing');
   assert.equal(calls.done, 1, 'the checklist is re-rendered');
   assert.deepEqual(calls.progress, ['inst-1'], 'the progress watch is restarted from the record');
@@ -113,7 +114,7 @@ test('a deliberate "New project" click after a finished standup opens a FRESH st
   assert.equal(calls.progress.length, 0, 'and its watch is not restarted');
   assert.equal(calls.resets, 1, 'with no second draft to lose, the wizard forgets the finished project');
   assert.deepEqual(calls.show, [[1, false]], 'step 1, and step 1 does not take the heading focus');
-  assert.equal(calls.focused, 1, 'the name field does — the deliberate-nav rule enter() already applies');
+  assert.equal(calls.focused, 1, 'its one control, the terms tick, does — the deliberate-nav rule enter() already applies');
   assert.equal(state.name, '', 'the old name is gone from the form');
 });
 
@@ -126,7 +127,7 @@ test('…and the standup stays one click away, named, on the resume link', () =>
 
 test('the resume link gets the done panel back — the record was never cleared', () => {
   const { calls, sandbox } = runEnter({ focus: true, resumeIntent: true, record: REC });
-  assert.deepEqual(calls.show, [[9, true]], 'a deliberate resume moves focus to the done panel');
+  assert.deepEqual(calls.show, [[11, true]], 'a deliberate resume moves focus to the done panel');
   assert.deepEqual(calls.progress, ['inst-1'], 'the watch comes back with it');
   assert.equal(sandbox.resumeIntent, false, 'the flag is ONE-SHOT — the next plain nav click must mean "new" again');
   assert.deepEqual(calls.offer, [null], 'and the offer comes down behind it');
@@ -144,20 +145,20 @@ test('a second draft already under way is NOT wiped by navigating back to the wi
 });
 
 test('the done panel\'s own saved step is NOT a second draft — it must not block the reset', () => {
-  // Caught in a render, not in a unit test: show(9) calls saveDraft(), so DRAFT_KEY is
+  // Caught in a render, not in a unit test: show(11) calls saveDraft(), so DRAFT_KEY is
   // non-empty again the moment a create lands. Reading "is there a draft?" left the
   // finished project's name in the fresh form, under a line offering to resume it.
-  const { calls, state } = runEnter({ focus: true, record: REC, draft: { step: 9, name: 'Mercury' } });
+  const { calls, state } = runEnter({ focus: true, record: REC, draft: { step: 11, name: 'Mercury' } });
   assert.equal(calls.resets, 1, 'the done step is bookkeeping, not a project being typed');
-  assert.deepEqual(calls.show, [[1, false]], 'out-of-range steps land on the name step');
+  assert.deepEqual(calls.show, [[1, false]], 'out-of-range steps land on step 1, the front door');
   assert.equal(state.name, '', 'and the finished project\'s name does not survive into it');
   assert.equal(calls.done, 0, 'never back onto the done panel');
 });
 
 test('a draft on the app step or the review is live too — the last two numbered steps (task 1004351)', () => {
-  // The app step moved the review from 7 to 8. A guard left at 7 would reset a second
-  // project sitting on its review, silently wiping it.
-  for (const step of [7, 8]) {
+  // The app step moved the review from 7 to 8, and the front door (task 1004417) to 10. A
+  // guard left behind would reset a second project sitting on its review, silently wiping it.
+  for (const step of [9, 10]) {
     const { calls, state } = runEnter({ focus: true, record: REC, draft: { step } });
     assert.equal(calls.resets, 0, `step ${step} is a live draft`);
     assert.deepEqual(calls.show, [[step, true]]);
@@ -165,8 +166,16 @@ test('a draft on the app step or the review is live too — the last two numbere
   }
 });
 
-test('a draft whose step is missing or junk resets too — only 1-8 preserves anything', () => {
-  for (const draft of [{ step: 0 }, { step: 9 }, { name: 'half-typed' }]) {
+test('a draft on the front door is live too — a founder part-way through it keeps their place (task 1004417)', () => {
+  for (const step of [1, 2]) {
+    const { calls, state } = runEnter({ focus: true, record: REC, draft: { step } });
+    assert.equal(calls.resets, 0, `step ${step} is a live draft`);
+    assert.equal(state.step, step);
+  }
+});
+
+test('a draft whose step is missing or junk resets too — only 1-10 preserves anything', () => {
+  for (const draft of [{ step: 0 }, { step: 11 }, { name: 'half-typed' }]) {
     const { calls } = runEnter({ focus: true, record: REC, draft });
     assert.equal(calls.resets, 1, `step ${JSON.stringify(draft.step)} is not a wizard step`);
     assert.deepEqual(calls.show, [[1, false]]);
@@ -191,11 +200,14 @@ test('paintResumeOffer names the project by textContent and hides on null (no li
 });
 
 test('the offer ships as real markup inside step 1, hidden until there is something to resume', () => {
-  const panel = HUB.slice(HUB.indexOf('id="panel-name"'), HUB.indexOf('id="panel-type"'));
+  // step 1 is the front door's terms screen since task 1004417 — the offer moved with it
+  const panel = HUB.slice(HUB.indexOf('id="panel-terms"'), HUB.indexOf('id="panel-fork"'));
   assert.match(panel, /<p class="resumeOffer" id="wizResume" hidden>still watching <strong id="wizResumeName">your project<\/strong> — <a href="#" id="wizResumeGo">resume it<\/a><\/p>/,
     'baked into the panel (C7), carrying its own hidden state');
-  assert.ok(panel.indexOf('id="wizResume"') < panel.indexOf('<form id="newForm"'),
-    'it sits above the name form, where a visitor reads it before typing');
+  assert.ok(panel.indexOf('id="wizResume"') < panel.indexOf('<form data-next="2">'),
+    'it sits above the terms form, where a visitor reads it before anything else');
+  assert.doesNotMatch(HUB.slice(HUB.indexOf('id="panel-name"'), HUB.indexOf('id="panel-type"')), /id="wizResume"/,
+    'and only once — a second copy would be a duplicate id');
   assert.match(SCRIPT, /\$\('wizResumeGo'\)\.addEventListener\('click', function \(ev\) \{\n\s*ev\.preventDefault\(\);\n\s*resumeIntent = true;\n\s*enter\(true\);/,
     'the link raises the one-shot intent and re-enters, rather than href-navigating');
 });