@bongos/core 1.20.48 → 1.20.49

package/modules/hall-ui/public/sky-panel.js

@@ -78,7 +78,7 @@
         ${waiting.length ? fact('waits on', waiting.map(name).join(', ')) : ''}
         ${waitedOn.length ? fact('waited on by', waitedOn.map(name).join(', ')) : ''}
       </div>
-      ${g.crit.length ? `<ul class="crit">${g.crit.slice(0, 10).map((c) => `<li><span class="ring${c.satisfied ? ' on' : ''}"></span><span>${esc(plain(c.text).slice(0, 120))}${plain(c.text).length > 120 ? '…' : ''}${c.bornOf ? ` <span class="born">· born of a thought</span>` : ''}${c.credits ? ` <span class="lbl">${c.credits} cr</span>` : ''}</span></li>`).join('')}</ul>` : ''}
+      ${g.crit.length ? `<ul class="crit">${g.crit.slice(0, 10).map((c) => `<li><span class="ring${c.satisfied ? ' on' : ''}"></span><span>${esc(plain(c.text).slice(0, 120))}${plain(c.text).length > 120 ? '…' : ''}${c.bornOf ? ` <span class="born">· born of a thought</span>` : ''}${c.credits ? ` <span class="lbl">${c.credits} cr</span>` : ''}${c.uatLabel ? ` <span class="lbl">${esc(c.uatLabel)}</span>` : ''}${c.backendOnly ? ' <span class="lbl">backend-only</span>' : ''}</span></li>`).join('')}</ul>` : ''}
       <div class="doors">
         <button type="button" class="door primary" id="descendBtn">${g.status === 'open' ? 'descend into the well' : 'look closer'}</button>
         ${edgesOf(g).length ? `<button type="button" class="door" id="chartBtn">chart its routes</button>` : ''}

package/modules/hall-ui/public/thinking.html

@@ -142,11 +142,13 @@
 <script src="/builders/palette.js" defer></script>
 
 <script src="/builders/idea-objects.js?v=2026-09-27-split"></script>
-<script src="/builders/sky-data.js?v=2026-09-27-split"></script>
+<!-- task 1004402: the UAT state words the rings share with the goal page. -->
+<script src="/builders/criterion-uat-ui.js?v=2026-09-30-uat1"></script>
+<script src="/builders/sky-data.js?v=2026-09-30-uat1"></script>
 <script src="/builders/sky-layout.js?v=2026-09-27-split"></script>
 <script src="/builders/sky-draw.js?v=2026-09-27-split"></script>
-<script src="/builders/sky-interaction.js?v=2026-09-27-split"></script>
-<script src="/builders/sky-panel.js?v=2026-09-27-split"></script>
+<script src="/builders/sky-interaction.js?v=2026-09-30-uat1"></script>
+<script src="/builders/sky-panel.js?v=2026-09-30-uat1"></script>
 <script src="/builders/sky-composer.js?v=2026-09-27-split"></script>
 <script src="/builders/sky-tour.js?v=2026-09-27-split"></script>
 </body>

package/modules/lifecycle/done-when.js

@@ -221,7 +221,9 @@ async function criterionProgress(versionId) {
   // about coverage. It uses idx_tasks_version_status (version_id leading).
   const [{ rows }, { rows: unattr }, goalRows] = await Promise.all([
     pool.query(
-      `WITH ranked AS (
+      // MATERIALIZED (task 1004402): the per-criterion UAT subqueries run once per
+      // criterion here, never once per (criterion, task) row after the join.
+      `WITH ranked AS MATERIALIZED (
          SELECT d.id, d.version_id, d.criterion_id, d.criterion_md, d.satisfied, d.goal_id,
                 ROW_NUMBER() OVER (ORDER BY d.sort_order, d.criterion_id) AS cnum,
                 ${uatReadColumnsSql('d')}

package/modules/lifecycle/sky.js

@@ -42,7 +42,7 @@ const api = require('../../src/module-api');
 const { pool } = api;
 const goalGraph = require('./goal-graph');
 const goalCategory = require('./goal-category');
-const { isPendingReview } = require('./done-when');
+const { isPendingReview, uatState, uatReadColumnsSql } = require('./done-when');
 const { TERMINAL_STATUSES } = require('./task-status');
 
 const SKY_CACHE_TTL_MS = 60 * 1000;
@@ -67,15 +67,24 @@ async function skyRows({ versionId = null, viewerId = null, viewerIsArchon = fal
     activePool.query(
       // The criterion→task join, read once. Flat rows on purpose (see the header):
       // the fold happens in shapeSky so a test can compare it with the rollup's.
-      `SELECT c.id::text AS id, c.goal_id::text AS goal_id, c.criterion_id, c.criterion_md,
-              c.satisfied, c.sort_order,
+      // task 1004402: each criterion's UAT columns (ADR 0351) are read ONCE per
+      // criterion, in a MATERIALIZED step before the task join fans the rows out;
+      // spliced into the flat join they re-ran once per linked task, on the one
+      // read that is the whole project's sky.
+      `WITH crit AS MATERIALIZED (
+         SELECT c.id, c.goal_id, c.criterion_id, c.criterion_md, c.satisfied, c.sort_order,
+                ${uatReadColumnsSql('c')}
+           FROM done_when_criteria c
+           JOIN goals g ON g.id = c.goal_id
+          WHERE c.goal_id IS NOT NULL
+            AND ($1::text IS NULL OR g.version_id = $1)
+       )
+       SELECT c.id::text AS id, c.goal_id::text AS goal_id, c.criterion_id, c.criterion_md,
+              c.satisfied, c.sort_order, c.uat_kind, c.backend_only,
               t.id::text AS task_id, t.status AS task_status
-         FROM done_when_criteria c
-         JOIN goals g ON g.id = c.goal_id
+         FROM crit c
          LEFT JOIN task_criteria tc ON tc.criterion_id = c.id
          LEFT JOIN tasks t          ON t.id = tc.task_id
-        WHERE c.goal_id IS NOT NULL
-          AND ($1::text IS NULL OR g.version_id = $1)
         ORDER BY c.goal_id, c.sort_order, c.criterion_id, t.id`,
       [version]
     ),
@@ -111,21 +120,27 @@ function foldCriteria(rows = []) {
         criterion_id: row.criterion_id,
         criterion_md: row.criterion_md,
         satisfied: row.satisfied === true,
+        backend_only: row.backend_only === true,
         task_ids: [],
         _unshipped: 0,
+        _shipped: 0,
+        _uatKind: row.uat_kind ?? null,
       };
       byId.set(c.id, c);
     }
     if (row.task_id != null) {
       c.task_ids.push(String(row.task_id));
       if (!TERMINAL_STATUSES.includes(row.task_status)) c._unshipped += 1;
+      if (row.task_status === 'shipped') c._shipped += 1;
     }
   }
   return [...byId.values()].map((c) => {
-    const { _unshipped, ...rest } = c;
+    const { _unshipped, _shipped, _uatKind, ...rest } = c;
     return {
       ...rest,
       pending_review: isPendingReview({ satisfied: c.satisfied, linked: c.task_ids.length, unshipped: _unshipped }),
+      // task 1004402: the same derivation the goal page and /status use.
+      uat_state: uatState({ satisfied: c.satisfied, linked: c.task_ids.length, unshipped: _unshipped, shipped: _shipped, latestKind: _uatKind }),
     };
   });
 }

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.20.48",
+  "version": "1.20.49",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.20.48",
+      "version": "1.20.49",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.20.48",
+  "version": "1.20.49",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -8401,5 +8401,11 @@
       "id": "1004422",
       "text": "While a new project is being founded, its builders hall now shows a clear \"project founding mode\" band at the top and dims the rooms that open later. A hall that isn't being founded stays exactly as it was."
     }
+  ],
+  "1.20.49": [
+    {
+      "id": "1004402",
+      "text": "A goal's page now shows where each checklist item really stands: Awaiting UAT, Satisfied, or Closed before UAT, with a Backend-only tag where there is nothing to record. The old Confirm button is gone. Instead, an item whose w"
+    }
   ]
 }

package/scripts/hall-preview/server.js

@@ -105,6 +105,8 @@ const FIXTURE_FALLBACKS = [
   [/^goals\/\d+\/dependency-forest$/, 'goals__dependency-forest'],
   [/^goals\/\d+\/requests$/, 'goals__requests'],
   [/^goals\/\d+$/, 'goals__detail'],
+  // a criterion's UAT panel (task 1004402): one Awaiting UAT reading serves any id.
+  [/^done-when\/\d+\/uat$/, 'done-when__uat'],
   [/^tasks\/\d+$/, 'tasks__detail'],
   // the #/idea/N + #/blocker/N deep-link overlay (task-detail.js) — one record
   // fixture serves any id so the overlay seam assertion renders real content.

package/src/module-api.js

@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.20.48'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.20.49'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/tests/claim_action.mjs

@@ -401,8 +401,13 @@ await test('the cache-bust moved on every page whose script changed', () => {
     ['goals.html', ['goals-render.js', 'goals-page.js']],
   ]) {
     const html = read('modules', 'hall-ui', 'public', page);
+    // The invariant is "busted AT OR AFTER the claim-action change", not the
+    // literal stamp: a later change to the same script bumps it again (task
+    // 1004402 did), and a pin on the string would fail that correct bump.
     for (const s of scripts) {
-      assert.match(html, new RegExp(s.replace('.', '\\.') + '\\?v=2026-09-30-bulktoolbar'), `${page}: ${s} not busted`);
+      const m = new RegExp(s.replace('.', '\\.') + '\\?v=(\\d{4}-\\d{2}-\\d{2})').exec(html);
+      assert.ok(m, `${page}: ${s} carries no dated cache-bust`);
+      assert.ok(m[1] >= '2026-09-26', `${page}: ${s} not busted since the claim-action change (${m[1]})`);
     }
   }
 });

package/tests/criterion_uat_ui.mjs

@@ -0,0 +1,113 @@
+// tests/criterion_uat_ui.mjs — the hall's criterion UAT helpers (task 1004402,
+// ADR 0351), DB-free and DOM-free. The page-level wiring is driven for real in
+// tests/goal_criterion_confirm_ui.mjs; this file pins the vocabulary and the
+// panel's variations.
+//
+//   1. The labels equal the server's (modules/lifecycle/criterion-uat.js
+//      stateLabel), so the hall, /status and /goal-uat say the same thing. The
+//      browser cannot require server code, so this is the lockstep.
+//   2. The backend-only switch appears only where it can work: an OPEN criterion,
+//      in the full view, for a reviewer, on a server that knows the rule.
+//   3. The panel asks for what the server will require and nothing else: the
+//      attestation only where the site cannot read its own deploy; no file field
+//      on a backend-only criterion; no form for a viewer who cannot sign.
+//   4. A stale sign-off is said to no longer count, never shown as the UAT.
+//
+// Run:  node tests/criterion_uat_ui.mjs
+
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+import { makeRunner } from './helpers.mjs';
+
+const require = createRequire(import.meta.url);
+const ui = require('../modules/hall-ui/public/criterion-uat-ui.js');
+const server = require('../modules/lifecycle/criterion-uat.js');
+const { test, summary } = makeRunner();
+
+await test('LABELS: every server state has the same words in the hall', () => {
+  for (const state of Object.values(server.UAT_STATES)) {
+    assert.equal(ui.STATE_LABELS[state], server.stateLabel(state), state);
+  }
+  assert.equal(Object.keys(ui.STATE_LABELS).length, Object.values(server.UAT_STATES).length, 'no hall-only state');
+});
+
+await test('STATE: an older server with no uat_state reads plainly and never as a UAT state', () => {
+  assert.equal(ui.stateOf({ satisfied: true }), 'legacy_satisfied');
+  assert.equal(ui.stateOf({ satisfied: false }), 'open');
+  assert.equal(ui.badgesHtml({ satisfied: true }), '');
+  assert.equal(ui.actionHtml({ id: 1, satisfied: true }, { canReview: true, full: true }), '');
+});
+
+await test('BACKEND-ONLY SWITCH: only on an OPEN criterion, in the full view, for a reviewer', () => {
+  const open = { id: 9, uat_state: 'open', satisfied: false };
+  assert.match(ui.actionHtml(open, { canReview: true, full: true }), /data-uat-backend="9" data-on="1"/);
+  assert.match(ui.actionHtml({ ...open, backend_only: true }, { canReview: true, full: true }), /data-on="0"[^>]*>Not backend-only/);
+  assert.equal(ui.actionHtml(open, { canReview: true, full: false }), '', 'not in the capped band: it is an authoring act');
+  assert.equal(ui.actionHtml(open, { canReview: false, full: true }), '');
+  assert.doesNotMatch(ui.actionHtml({ id: 9, uat_state: 'awaiting_uat' }, { canReview: true, full: true }), /data-uat-backend/,
+    'once awaiting, the server refuses it, so the page does not offer it');
+});
+
+const VIEW = (over = {}) => ({
+  criterion: { id: 42 },
+  uat_state: 'awaiting_uat',
+  backend_only: false,
+  checks: { code: true, live: { available: false }, uat: null, stale_uat: null },
+  ...over,
+});
+
+await test('PANEL: a site that cannot read its deploy asks for the attestation; one that can, does not', () => {
+  const blind = ui.panelHtml(VIEW(), { apiBase: '/api/bongos', canReview: true });
+  assert.match(blind, /data-uat-attest="42"/);
+  assert.match(blind, /data-uat-file="42"/);
+  const seeing = ui.panelHtml(VIEW({ checks: { code: true, live: { available: true, live: true }, uat: null } }), { apiBase: '/api/bongos', canReview: true });
+  assert.doesNotMatch(seeing, /data-uat-attest/);
+  assert.match(seeing, /Running on the live site\./);
+});
+
+await test('PANEL: not live yet names the tasks, in plain words', () => {
+  const html = ui.panelHtml(VIEW({ checks: { code: true, live: { available: true, live: false, not_live: [{ task_id: '12' }] }, uat: null } }), { apiBase: '', canReview: true });
+  assert.match(html, /not on the live site yet \(#12\)/);
+});
+
+await test('PANEL: a backend-only criterion has no file field and asks how it was checked', () => {
+  const html = ui.panelHtml(VIEW({ backend_only: true }), { apiBase: '', canReview: true });
+  assert.doesNotMatch(html, /data-uat-file/);
+  assert.match(html, /How you checked it/);
+  assert.match(html, />Sign off</);
+});
+
+await test('PANEL: a viewer who cannot sign sees the checks and no form', () => {
+  const html = ui.panelHtml(VIEW(), { apiBase: '', canReview: false });
+  assert.match(html, /uat-checks/);
+  assert.doesNotMatch(html, /data-uat-form/);
+});
+
+await test('PANEL: a stale sign-off is said to no longer count, and its recording still plays', () => {
+  const stale = { kind: 'uat', signed_off_by_login: 'ana', created_at: '2026-09-20T10:00:00Z', recording_file: 'uat-42-0123456789abcdef.mp4' };
+  const html = ui.panelHtml(VIEW({ checks: { code: true, live: { available: false }, uat: null, stale_uat: stale } }), { apiBase: '/api/bongos', canReview: true });
+  assert.match(html, /no longer counts: more work shipped after it/);
+  assert.match(html, /<video class="uat-video" controls preload="metadata" src="\/api\/bongos\/criterion-uats\/recordings\/uat-42-0123456789abcdef\.mp4">/);
+});
+
+await test('PANEL: a closed criterion shows who signed it and when, and offers no form', () => {
+  const html = ui.panelHtml(VIEW({ uat_state: 'satisfied_uat', checks: { code: true, live: null, uat: { kind: 'uat', signed_off_by_login: 'ana', created_at: '2026-09-28T10:00:00Z', note: 'made a rank' } } }), { apiBase: '', canReview: true });
+  assert.match(html, /Tried on the live site by ana/);
+  assert.match(html, /made a rank/);
+  assert.doesNotMatch(html, /data-uat-form/);
+});
+
+await test('ESCAPING: a note or a login can never become markup', () => {
+  const html = ui.panelHtml(VIEW({ uat_state: 'satisfied_uat', checks: { code: true, uat: { kind: 'uat', signed_off_by_login: '<b>x</b>', created_at: '2026-09-28', note: '"><script>alert(1)</script>' } } }), { apiBase: '', canReview: false });
+  assert.doesNotMatch(html, /<script>|<b>x<\/b>/);
+});
+
+await test('REFUSALS: the server\'s sentence wins; the fallbacks are plain words', () => {
+  assert.equal(ui.refusalText({ error: { code: 'work_not_live', message: 'Some of this work is not deployed yet.' } }, 409), 'Some of this work is not deployed yet.');
+  assert.match(ui.refusalText({}, 413), /100 MB cap/);
+  assert.match(ui.refusalText(null, 500), /did not go through \(500\)/);
+  assert.equal(ui.checkFile({ type: 'video/webm', size: 5 }), null);
+  assert.equal(ui.checkFile(null), 'Choose the recording first.');
+});
+
+summary();