@bongos/core 1.20.46 → 1.20.47

package/tests/claim_action.mjs

@@ -264,8 +264,8 @@ await test('both boards CONSTRUCT the shared action, not just its error text', (
 
 await test('every claim/release entry point routes through it', () => {
   const sites = {
-    'work.js': ['doClaim', 'doRelease', 'doBulkClaim', 'doBulkRelease'],
-    'goals-page.js': ['doGoalClaim', 'doGoalRelease', 'doGoalBulkClaim'],
+    'work.js': ['doClaim', 'doRelease'],
+    'goals-page.js': ['doGoalClaim', 'doGoalRelease'],
   };
   for (const [f, fns] of Object.entries(sites)) {
     const src = read('modules', 'hall-ui', 'public', f);
@@ -278,6 +278,15 @@ await test('every claim/release entry point routes through it', () => {
         `${f}: ${fn} still maps its own refusal`);
     }
   }
+  // Both boards' BULK claim/release live in the shared toolbar now (task 1003141),
+  // built over the same action — so the same rule is checked there, once.
+  const bulk = read('modules', 'hall-ui', 'public', 'bulk-toolbar.js');
+  for (const fn of ['doBulkClaim', 'doBulkRelease']) {
+    const m = bulk.match(new RegExp(`async function ${fn}\\([^)]*\\) \\{[\\s\\S]*?\\n    \\}`));
+    assert.ok(m, `bulk-toolbar.js: ${fn} not found`);
+    assert.match(m[0], /claimAction\.(claimMany|releaseMany)\(/, `bulk-toolbar.js: ${fn} does not go through the shared action`);
+    assert.doesNotMatch(m[0], /friendlyClaimError\(/, `bulk-toolbar.js: ${fn} maps its own refusal`);
+  }
 });
 
 await test('no call site reloads on top of the action\'s own refresh', async () => {
@@ -287,7 +296,7 @@ await test('no call site reloads on top of the action\'s own refresh', async ()
   // twice. work.js's doBulkClaim is the correct shape: redraw the toolbar,
   // never re-fetch. A finally that awaits a loader is the tell.
   const src = read('modules', 'hall-ui', 'public', 'goals-page.js');
-  for (const fn of ['doGoalClaim', 'doGoalRelease', 'doGoalBulkClaim']) {
+  for (const fn of ['doGoalClaim', 'doGoalRelease']) {
     const m = src.match(new RegExp(`async function ${fn}\\([^)]*\\) \\{[\\s\\S]*?\\n  \\}`));
     assert.ok(m, `${fn} not found`);
     assert.doesNotMatch(m[0], /finally \{[\s\S]*?await loadGoalTasks\(/,
@@ -393,7 +402,7 @@ await test('the cache-bust moved on every page whose script changed', () => {
   ]) {
     const html = read('modules', 'hall-ui', 'public', page);
     for (const s of scripts) {
-      assert.match(html, new RegExp(s.replace('.', '\\.') + '\\?v=2026-09-26-claimaction1'), `${page}: ${s} not busted`);
+      assert.match(html, new RegExp(s.replace('.', '\\.') + '\\?v=2026-09-30-bulktoolbar'), `${page}: ${s} not busted`);
     }
   }
 });

package/tests/goal_category_ui.mjs

@@ -126,6 +126,7 @@ async function renderList() {
   // task 1003458: the page loads claim-action.js before this script; the stub
   // must mirror that, or the destructure of window.OTBClaimAction throws.
   vm.runInContext(read('modules/hall-ui/public/claim-action.js'), sandbox, { filename: 'claim-action.js' });
+  vm.runInContext(read('modules/hall-ui/public/bulk-toolbar.js'), sandbox, { filename: 'bulk-toolbar.js' }); // task 1003141
   vm.runInContext(TASK_LIB_SRC, sandbox, { filename: 'task-lib.js' });
   vm.runInContext(GOALS_LIB_SRC, sandbox, { filename: 'goals-lib.js' });
   vm.runInContext(GOAL_FOREST_RENDER_SRC, sandbox, { filename: 'goal-forest-render.js' });

package/tests/goal_criterion_confirm_ui.mjs

@@ -157,6 +157,8 @@ async function render({ rank = 'metic', goalStatus = 'open', criteria = Object.v
   // must mirror that, or the destructure of window.OTBClaimAction throws.
   vm.runInContext(fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/claim-action.js'), 'utf8'), sandbox, { filename: 'claim-action.js' });
   vm.runInContext(TASK_LIB_SRC, sandbox, { filename: 'task-lib.js' });
+  // task 1003141: goals-render.js builds the shared bulk toolbar at boot.
+  vm.runInContext(fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/bulk-toolbar.js'), 'utf8'), sandbox, { filename: 'bulk-toolbar.js' });
   vm.runInContext(GOALS_LIB_SRC, sandbox, { filename: 'goals-lib.js' });
   vm.runInContext(GOAL_FOREST_RENDER_SRC, sandbox, { filename: 'goal-forest-render.js' });
   vm.runInContext(GOALS_RENDER_SRC, sandbox, { filename: 'goals-render.js' });

package/tests/goal_forest_page.mjs

@@ -80,6 +80,7 @@ async function boot({ status = 200, fail = false, payload = { nodes: [], edges:
   // task 1003458: the page loads claim-action.js before this script; the stub
   // must mirror that, or the destructure of window.OTBClaimAction throws.
   vm.runInContext(read('claim-action.js'), sandbox, { filename: 'claim-action.js' });
+  vm.runInContext(read('bulk-toolbar.js'), sandbox, { filename: 'bulk-toolbar.js' }); // task 1003141
   vm.runInContext(RENDER_JS, sandbox, { filename: 'goals-render.js' });
 
   const state = { current: 7, forest: null, forestError: false };

package/tests/goal_invite_consent.mjs

@@ -171,7 +171,7 @@ function harness({ pendingRequests = [] } = {}) {
   vm.createContext(sandbox);
   // task 1003458: claim-action.js sits between task-lib and goals-render on the
   // real page (goals.html); the stub mirrors that order.
-  for (const f of ['hall-kit.js', 'task-lib.js', 'claim-action.js', 'goals-lib.js', 'goal-forest-render.js', 'goals-render.js']) {
+  for (const f of ['hall-kit.js', 'task-lib.js', 'claim-action.js', 'bulk-toolbar.js', 'goals-lib.js', 'goal-forest-render.js', 'goals-render.js']) {
     vm.runInContext(read(P + f), sandbox, { filename: f });
   }
 

package/tests/goal_mine_lens.mjs

@@ -150,6 +150,7 @@ async function boot({
   // task 1003458: the page loads claim-action.js before this script; the stub
   // must mirror that, or the destructure of window.OTBClaimAction throws.
   vm.runInContext(hall('claim-action.js'), sandbox, { filename: 'claim-action.js' });
+  vm.runInContext(hall('bulk-toolbar.js'), sandbox, { filename: 'bulk-toolbar.js' }); // task 1003141
   vm.runInContext(GOALS_RENDER_SRC, sandbox, { filename: 'goals-render.js' });
   vm.runInContext(GOALS_PAGE_SRC, sandbox, { filename: 'goals-page.js' });
   for (let i = 0; i < 30; i += 1) await new Promise((r) => setTimeout(r, 0));

package/tests/hall_board_world.mjs

@@ -80,7 +80,7 @@ test('.task IS the panel — --bg-card at the full radius, with no drawn edge at
 // gets missed: "Git" came back 17x24 after a height-only fix.
 for (const sel of ['.task__select', '.wip__select']) {
   test(`${sel} is a 24px target with a 14px drawn box`, () => {
-    const css = sel.includes('wip') ? workCss : styleCss;
+    const css = styleCss; // .wip__select joined .task__select here when the goal board borrowed it (task 1003141)
     const box = rule(css, sel);
     assert.ok(box, `${sel} has a rule`);
     assert.match(box, /width:\s*24px/, 'the HIT AREA is 24px — this is what the floor measures');

package/tests/hall_mine_lens.mjs

@@ -204,6 +204,7 @@ function bootWorkBoard({ signedIn = true, goalsFail = false } = {}) {
   // task 1003458: the page loads claim-action.js before this script; the stub
   // must mirror that, or the destructure of window.OTBClaimAction throws.
   vm.runInContext(fs.readFileSync(path.join(HALL, 'claim-action.js'), 'utf8'), sandbox, { filename: 'claim-action.js' });
+  vm.runInContext(fs.readFileSync(path.join(HALL, 'bulk-toolbar.js'), 'utf8'), sandbox, { filename: 'bulk-toolbar.js' }); // task 1003141
   vm.runInContext(WORK_JS, sandbox, { filename: 'work.js' });
   (documentObj.listeners.DOMContentLoaded || []).forEach((fn) => fn());