@bongos/core 1.20.38 → 1.20.39

package/tests/projects_hub_app_step.mjs

@@ -23,6 +23,8 @@ import fs from 'node:fs';
 import path from 'node:path';
 import vm from 'node:vm';
 import { fileURLToPath } from 'node:url';
+import { createRequire } from 'node:module';
+const require = createRequire(import.meta.url);
 
 const ROOT = path.join(path.dirname(fileURLToPath(import.meta.url)), '..');
 const HUB = fs.readFileSync(path.join(ROOT, 'modules', 'public-landing', 'public', 'projects.html'), 'utf8').replace(/\r\n/g, '\n');
@@ -301,6 +303,53 @@ test('typing a start command clears the "how your app starts" ask at once', asyn
   assert.doesNotMatch(w.$('h-render').textContent, /how your app starts/);
 });
 
+// task 1004464 — Render refused a native app with no build command, live, on project 43.
+test('the build command starts as the runtime\'s usual one, follows the runtime, and yields to the owner\'s own', async () => {
+  const w = load({ answers: ANSWERS, draft: { appPlatform: 'render' } });
+  w.typeKey(KEY);
+  await w.check();
+  await w.pickWorkspace(0);
+  w.pickService({ value: 'new' });
+  assert.equal(w.$('f-renderBuild').value, 'npm install', 'Node.js starts with npm install');
+  w.$('f-renderRuntime').value = 'python';
+  w.$('renderNew').fire('change', { target: w.$('f-renderRuntime') });
+  assert.equal(w.$('f-renderBuild').value, 'pip install -r requirements.txt', 'it follows the runtime');
+  w.$('f-renderBuild').value = 'make build';
+  w.$('renderNew').fire('input', { target: w.$('f-renderBuild') });
+  w.$('f-renderRuntime').value = 'ruby';
+  w.$('renderNew').fire('change', { target: w.$('f-renderRuntime') });
+  assert.equal(w.$('f-renderBuild').value, 'make build', 'the owner\'s own command is never overwritten');
+  w.state.renderStart = 'bundle exec puma';
+  assert.equal(w.renderRequestBody().build_command, 'make build');
+});
+
+test('an emptied build command is refused before Render ever sees it, and the ask clears on typing', async () => {
+  const w = load({ answers: ANSWERS, draft: { appPlatform: 'render' } });
+  w.typeKey(KEY);
+  await w.check();
+  await w.pickWorkspace(0);
+  w.pickService({ value: 'new' });
+  w.state.renderStart = 'npm start';
+  w.$('f-renderBuild').value = '';
+  w.$('renderNew').fire('input', { target: w.$('f-renderBuild') });
+  assert.equal(w.validateRender(), false);
+  assert.match(w.$('h-render').textContent, /how your app is built/);
+  w.$('f-renderBuild').value = 'npm ci';
+  w.$('renderNew').fire('input', { target: w.$('f-renderBuild') });
+  assert.doesNotMatch(w.$('h-render').className, /err/);
+  assert.equal(w.validateRender(), true);
+});
+
+test('the page\'s build defaults are the runner\'s, key for key', () => {
+  const { BUILD_DEFAULTS, RUNTIMES } = require('../modules/provisioning/render-standup.js');
+  const src = HUB.replace(/\r\n/g, '\n').match(/var RENDER_BUILD_DEFAULTS = (\{[\s\S]*?\});/);
+  assert.ok(src, 'the page carries RENDER_BUILD_DEFAULTS');
+  const page = vm.runInNewContext('(' + src[1] + ')');
+  assert.deepEqual({ ...page }, { ...BUILD_DEFAULTS });
+  assert.deepEqual(Object.keys(page).sort(), RUNTIMES.filter((r) => r !== 'docker').sort());
+  assert.doesNotMatch(HUB, /leave empty if there is none/);
+});
+
 test('the empty command boxes read as examples, not as filled-in values', () => {
   assert.match(HUB, /id="f-renderBuild"[^>]*placeholder="for example: npm ci"/);
   assert.match(HUB, /id="f-renderStart"[^>]*placeholder="for example: npm start"/);

package/tests/projects_hub_render_connect.mjs

@@ -250,7 +250,8 @@ test('Connect sends the key once, to this project, forgets it, and the card show
   const sent = w.calls.filter((c) => c.url === RENDER);
   assert.equal(sent.length, 1);
   assert.equal(sent[0].method, 'POST');
-  assert.deepEqual(sent[0].body, { key: KEY, owner_id: TEA_A, mode: 'greenfield', runtime: 'node', start_command: 'npm start', web_plan: 'starter', database: false });
+  // build_command: the runtime's usual one, prefilled — Render refuses a native app without one (task 1004464)
+  assert.deepEqual(sent[0].body, { key: KEY, owner_id: TEA_A, mode: 'greenfield', runtime: 'node', start_command: 'npm start', build_command: 'npm install', web_plan: 'starter', database: false });
   for (const c of w.calls) assert.ok(!c.url.includes(KEY), 'no URL carries the key');
   assert.equal(w.q('f-renderKey').value, '', 'the field is emptied');
   assert.equal(w.byId('mAppConnectForm').hidden, true, 'the form closes');

package/tests/provision_render.mjs

@@ -335,11 +335,32 @@ await ta('a link needs a repository to check the service against (1004350 review
   assert.equal(out.ok, false);
   assert.equal(h.cleared(), 1);
 });
-await ta('an app with no build step sends no build command at all (1004350 review)', async () => {
+// The 1004350 review asked for NO build command here; Render refused exactly that live
+// ("buildCommand is required for non-static, non-docker services", task 1004464), so a
+// row saved without one — every row from before the fix included — gets the runtime's
+// default, and a Retry of such a row now works.
+await ta('an app saved with no build command gets its runtime\'s default, as Render requires (task 1004464)', async () => {
   const h = harness({ host: { buildCommand: undefined } });
   await h.run();
   const svc = h.r.calls.find((c) => c.method === 'POST' && c.path === '/services').body;
-  assert.deepEqual(svc.serviceDetails.envSpecificDetails, { startCommand: 'npm start' });
+  assert.deepEqual(svc.serviceDetails.envSpecificDetails, { buildCommand: 'npm install', startCommand: 'npm start' });
+});
+await ta('every native runtime has a default build command; docker still sends none (task 1004464)', () => {
+  const { RUNTIMES, BUILD_DEFAULTS } = require('../modules/provisioning/render-standup.js');
+  const { buildFor } = require('../scripts/gds/render-payload.js');
+  for (const rt of RUNTIMES.filter((r) => r !== 'docker')) {
+    assert.ok(BUILD_DEFAULTS[rt], `${rt} has a default`);
+    assert.equal(buildFor({ runtime: rt, startCommand: 'x' }).buildCommand, BUILD_DEFAULTS[rt]);
+    assert.equal(buildFor({ runtime: rt, startCommand: 'x', buildCommand: 'make' }).buildCommand, 'make', 'the owner\'s own wins');
+  }
+  assert.deepEqual(buildFor({ runtime: 'docker' }), { runtime: 'docker' });
+});
+await ta('a refusal from Render reads as a sentence, with Render\'s own reason kept (task 1004464)', async () => {
+  const h = harness({ host: { database: false }, render: { 'POST /services': new Error('buildCommand is required for non-static, non-docker services.') } });
+  const out = await h.run();
+  assert.equal(out.ok, false);
+  assert.equal(h.lastHost().error, 'Render would not set up the app: buildCommand is required for non-static, non-docker services.');
+  assert.doesNotMatch(h.lastHost().error, /POST \/services/, 'no raw HTTP line reaches the owner');
 });
 
 console.log('\nteardown forgets, never deletes:');