@bongos/core 1.20.19 → 1.20.21

package/tests/guilds_api.mjs

@@ -10,6 +10,10 @@
 //   3. THE PUBLIC READ — 404 for an unlisted guild is byte-identical to an
 //      unknown slug, needs no session, is no-store, and its roster statement
 //      carries shown_publicly AND the shared existence predicate.
+//   3b. THE GUILD MAP (task 1002306) — public guilds with a non-empty public
+//      roster, sized by the guild page's own predicate and cap, ranked only by
+//      published fields (size, or the STORED shipped band floor), paging
+//      clamped, and an unknown order refused before any SQL.
 //   4. SILENCE — a request written and one swallowed by a decline cooldown
 //      answer identically; a decline is an empty 204.
 //   5. THE CARD — an invite accept must echo the visibility its card showed,
@@ -90,6 +94,7 @@ require.cache[moduleApiPath] = {
   },
 };
 const guilds = require('../modules/platform-identity/guilds.js');
+const guildMap = require('../modules/platform-identity/guild-map.js');
 const buildGuildRoutes = require('../modules/platform-identity/routes/guilds.js');
 const buildPublicRoutes = require('../modules/platform-identity/routes/guilds-public.js');
 const { attachFail } = require('../src/bongos/middleware/error-envelope.js');
@@ -263,8 +268,13 @@ test('public read: the roster is shown_publicly AND the shared existence predica
   });
   const res = await call('GET', '/api/bongos/guilds/Guild-A');
   assert.equal(res.status, 200);
-  assert.deepEqual(Object.keys(res.json).sort(), ['guild', 'members', 'size']);
+  assert.deepEqual(Object.keys(res.json).sort(), ['guild', 'members', 'size', 'totals']);
   assert.equal(res.json.size, 2);
+  assert.equal(res.json.totals, null, 'no stored record yet → no totals, never a computed stand-in');
+  assert.ok(calls.some((c) => /FROM platform_identity_guild_totals\s+WHERE guild_id = \$1/.test(c.text)),
+    'the totals are READ from the weekly snapshot');
+  assert.ok(calls.every((c) => !/INSERT|UPDATE|platform_identity_builder_project_activity/.test(c.text)),
+    'the public read never computes or writes the totals (ADR 0337 D4.4: never on a read)');
   assert.equal(res.json.members.length, 2);
   assert.ok(!('id' in res.json.guild), 'the row id stays internal');
   assert.ok(!/github_id|github_login/.test(res.text), 'no account id or login crosses');
@@ -276,6 +286,75 @@ test('public read: the roster is shown_publicly AND the shared existence predica
   assert.equal(calls[0].params[0], 'guild-a', 'the slug is looked up in canonical form');
 });
 
+// ===========================================================================
+// 3b. The guild map (R30, task 1002306; ADR 0336 D8 + ADR 0337 D4.4)
+// ===========================================================================
+
+const IS_MAP = (t) => /WITH roster AS/.test(t) && /FROM platform_identity_guilds g/.test(t);
+
+test('guild map: public guilds with a public roster, sized like the guild page, ranked by size then slug', async () => {
+  on((t) => (IS_MAP(t) ? result([
+    { slug: 'big', name: 'Big', size: 9, shipped: 50 },
+    { slug: 'new', name: 'New', size: 2, shipped: null },
+  ]) : result()));
+  session = null; // the map must not need one
+  try {
+    const res = await call('GET', '/api/bongos/guilds');
+    assert.equal(res.status, 200);
+    assert.equal(res.headers['cache-control'], 'no-store');
+    assert.deepEqual(Object.keys(res.json).sort(), ['count', 'order', 'page', 'results']);
+    assert.equal(res.json.order, 'size', 'size is the default ordering');
+    assert.equal(res.json.count, res.json.results.length);
+    assert.deepEqual(res.json.page, { limit: guildMap.DEFAULT_LIMIT, offset: 0 });
+    assert.equal(calls.length, 1, 'one statement, and no read of the viewer');
+    const { text, params } = calls[0];
+    assert.match(text, /AND m\.shown_publicly AND \(\(pa\.profile_state = 'active' AND pa\.terms_accepted_at IS NOT NULL\) AND pa\.account_visibility = 'public'\)/,
+      'size is the public roster: shown_publicly AND accountVisibleSql — the getPublicGuild predicate');
+    assert.match(text, /JOIN roster r ON r\.guild_id = g\.id/, 'an INNER join: a guild with an empty public roster is not on the map');
+    assert.match(text, /WHERE g\.visibility = 'public'/, 'an unlisted guild is never listed');
+    assert.match(text, /LEAST\(count\(\*\), \$3\)/, 'size is capped like the guild page\'s roster');
+    assert.match(text.split('SELECT g.slug')[0], /WHERE pg\.visibility = 'public' AND m\.shown_publicly/,
+      'the aggregate groups PUBLIC guilds\' memberships only — an unlisted guild is never scanned for the map');
+    assert.deepEqual(params, [guildMap.DEFAULT_LIMIT, 0, guilds.LIST_MAX]);
+    assert.match(text, /ORDER BY size DESC, g\.slug\s+LIMIT/, 'ties break on slug');
+  } finally { session = { github_id: ME, github_login: 'octo' }; }
+});
+
+test('guild map: shipped ranks by the STORED band floor, never an exact sum; a guild not yet refreshed sorts last', async () => {
+  on((t) => (IS_MAP(t) ? result([]) : result()));
+  const res = await call('GET', '/api/bongos/guilds?order=shipped');
+  assert.equal(res.status, 200);
+  assert.equal(res.json.order, 'shipped');
+  const { text } = calls[0];
+  assert.match(text, /LEFT JOIN platform_identity_guild_totals t ON t\.guild_id = g\.id/);
+  assert.match(text, /t\.works_shipped AS shipped/, 'the published key IS the sort key (ADR 0255)');
+  assert.match(text, /ORDER BY shipped DESC NULLS LAST, g\.slug/);
+  assert.doesNotMatch(text, /platform_identity_builder_project_activity/, 'no exact sum is ever read here (ADR 0337 D4.4)');
+});
+
+test('guild map: a row carries slug, name, size and shipped — nothing that names an account', async () => {
+  on((t) => (IS_MAP(t) ? result([]) : result()));
+  await call('GET', '/api/bongos/guilds');
+  const select = calls[0].text.split(/SELECT g\.slug/)[1].split('FROM')[0];
+  assert.equal(`g.slug${select}`.replace(/\s+/g, ' ').trim(), 'g.slug, g.name, r.size, t.works_shipped AS shipped');
+});
+
+test('guild map: an unknown order is a 400 that reaches no SQL; paging is clamped and echoed', async () => {
+  on(() => result());
+  const bad = await call('GET', '/api/bongos/guilds?order=credits');
+  assert.equal(bad.status, 400);
+  assert.equal(bad.json.error.code, 'guild_map_bad_order');
+  assert.equal(calls.length, 0);
+
+  on((t) => (IS_MAP(t) ? result([]) : result()));
+  const big = await call('GET', '/api/bongos/guilds?limit=1000&offset=99999');
+  assert.deepEqual(big.json.page, { limit: guildMap.MAX_LIMIT, offset: guildMap.MAX_OFFSET });
+  assert.deepEqual(calls[0].params.slice(0, 2), [guildMap.MAX_LIMIT, guildMap.MAX_OFFSET]);
+  on((t) => (IS_MAP(t) ? result([]) : result()));
+  const junk = await call('GET', '/api/bongos/guilds?limit=-3&offset=abc');
+  assert.deepEqual(junk.json.page, { limit: guildMap.DEFAULT_LIMIT, offset: 0 });
+});
+
 // ===========================================================================
 // 4. Join requests and silence (D3)
 // ===========================================================================