@bongos/core 1.20.16 → 1.20.18
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.bongos-core.json +21 -21
- package/docs/adr/0213-platform-terms-acceptance-is-the-hubs-own-witness.md +2 -0
- package/docs/adr/0215-the-recruiter-sliver-is-a-ceiling-not-a-step.md +2 -2
- package/docs/api/openapi.json +1 -1
- package/docs/copy-inventory.md +5 -6
- package/docs/copy-registry.json +8 -17
- package/docs/module-api-changelog.md +4 -0
- package/docs/page-readings.json +7 -7
- package/modules/platform-identity/read-rate-limit.js +6 -4
- package/modules/platform-identity/routes/scouting.js +27 -0
- package/modules/public-landing/public/terms.html +3 -3
- package/package-lock.json +2 -2
- package/package.json +1 -1
- package/release-notes.json +12 -0
- package/src/module-api.js +1 -1
- package/tests/recruiter_sliver_boundary.mjs +69 -0
- package/tests/terms_acceptance.mjs +114 -8
package/.bongos-core.json
CHANGED
|
@@ -2,11 +2,11 @@
|
|
|
2
2
|
"artifact": "bongos-core",
|
|
3
3
|
"manifest_schema": 1,
|
|
4
4
|
"generator": "scripts/gds/package-core.js",
|
|
5
|
-
"core_version": "1.20.
|
|
6
|
-
"core_contract": "1.20.
|
|
7
|
-
"source_commit": "
|
|
5
|
+
"core_version": "1.20.18",
|
|
6
|
+
"core_contract": "1.20.18",
|
|
7
|
+
"source_commit": "e1841ec9f7044de186bb75988136b6dfb0835ef7",
|
|
8
8
|
"source_ref": "HEAD",
|
|
9
|
-
"built_at": "2026-09-
|
|
9
|
+
"built_at": "2026-09-30T13:46:50.940Z",
|
|
10
10
|
"redaction": {
|
|
11
11
|
"model": "docs-redacted+functional-verbatim",
|
|
12
12
|
"docs_redacted": 556,
|
|
@@ -17,7 +17,7 @@
|
|
|
17
17
|
"gate": "passed"
|
|
18
18
|
},
|
|
19
19
|
"file_count": 3210,
|
|
20
|
-
"tree_sha256": "
|
|
20
|
+
"tree_sha256": "34fda46e51438cef84700eb352c0f4dc3a8552cd8e8fc962864f4f500e09047d",
|
|
21
21
|
"files": [
|
|
22
22
|
{
|
|
23
23
|
"path": ".claude/skills/ask-for-help/SKILL.md",
|
|
@@ -1537,7 +1537,7 @@
|
|
|
1537
1537
|
{
|
|
1538
1538
|
"path": "docs/adr/0213-platform-terms-acceptance-is-the-hubs-own-witness.md",
|
|
1539
1539
|
"mode": "0000644",
|
|
1540
|
-
"sha256": "
|
|
1540
|
+
"sha256": "2e00d10ae548548bc8708058b0beb08fc0631aa29f27f6905ef630fdf4c6099b"
|
|
1541
1541
|
},
|
|
1542
1542
|
{
|
|
1543
1543
|
"path": "docs/adr/0214-canonical-profile-url-one-resolver-dark-until-the-page-exists.md",
|
|
@@ -1547,7 +1547,7 @@
|
|
|
1547
1547
|
{
|
|
1548
1548
|
"path": "docs/adr/0215-the-recruiter-sliver-is-a-ceiling-not-a-step.md",
|
|
1549
1549
|
"mode": "0000644",
|
|
1550
|
-
"sha256": "
|
|
1550
|
+
"sha256": "15d0455b7a29968c01ea01fb64d9c01fb63d7d2db0ef351df5f0fb9dfa677a94"
|
|
1551
1551
|
},
|
|
1552
1552
|
{
|
|
1553
1553
|
"path": "docs/adr/0216-a-fake-pool-interpreter-must-fail-loudly-not-silently-ignore.md",
|
|
@@ -2242,7 +2242,7 @@
|
|
|
2242
2242
|
{
|
|
2243
2243
|
"path": "docs/api/openapi.json",
|
|
2244
2244
|
"mode": "0000644",
|
|
2245
|
-
"sha256": "
|
|
2245
|
+
"sha256": "829ba538e06cca081f0540bf819f280ba36e738a553e5fa3634af5f5af5bc5b0"
|
|
2246
2246
|
},
|
|
2247
2247
|
{
|
|
2248
2248
|
"path": "docs/architecture.md",
|
|
@@ -2267,12 +2267,12 @@
|
|
|
2267
2267
|
{
|
|
2268
2268
|
"path": "docs/copy-inventory.md",
|
|
2269
2269
|
"mode": "0000644",
|
|
2270
|
-
"sha256": "
|
|
2270
|
+
"sha256": "08ef6d32a1c5cfea14e7ddd54a4e7ab2e34818199a45e0422a4fce31b72567a7"
|
|
2271
2271
|
},
|
|
2272
2272
|
{
|
|
2273
2273
|
"path": "docs/copy-registry.json",
|
|
2274
2274
|
"mode": "0000644",
|
|
2275
|
-
"sha256": "
|
|
2275
|
+
"sha256": "a405d02a6308a53e9322437f21daf86cb7e7f0d6d8b15a25639b7fdbcb7c2fd1"
|
|
2276
2276
|
},
|
|
2277
2277
|
{
|
|
2278
2278
|
"path": "docs/design/apex-pass-2-direction.md",
|
|
@@ -2772,7 +2772,7 @@
|
|
|
2772
2772
|
{
|
|
2773
2773
|
"path": "docs/module-api-changelog.md",
|
|
2774
2774
|
"mode": "0000644",
|
|
2775
|
-
"sha256": "
|
|
2775
|
+
"sha256": "99307d7bab261c46f7e80d768b014352d9f3c47ec2c72088acfac7bc700dd06f"
|
|
2776
2776
|
},
|
|
2777
2777
|
{
|
|
2778
2778
|
"path": "docs/modules-contract.md",
|
|
@@ -2862,7 +2862,7 @@
|
|
|
2862
2862
|
{
|
|
2863
2863
|
"path": "docs/page-readings.json",
|
|
2864
2864
|
"mode": "0000644",
|
|
2865
|
-
"sha256": "
|
|
2865
|
+
"sha256": "6ba44419e75dcb245e386e077eba647e744c56861b8b81c9002bbe7528369f0c"
|
|
2866
2866
|
},
|
|
2867
2867
|
{
|
|
2868
2868
|
"path": "docs/project-context.template.md",
|
|
@@ -7057,7 +7057,7 @@
|
|
|
7057
7057
|
{
|
|
7058
7058
|
"path": "modules/platform-identity/read-rate-limit.js",
|
|
7059
7059
|
"mode": "0000644",
|
|
7060
|
-
"sha256": "
|
|
7060
|
+
"sha256": "fb22fef7442c1488499dce4ec8aafce30400166df51f5c7bd88577c83fb8873e"
|
|
7061
7061
|
},
|
|
7062
7062
|
{
|
|
7063
7063
|
"path": "modules/platform-identity/recruiter-sliver.js",
|
|
@@ -7112,7 +7112,7 @@
|
|
|
7112
7112
|
{
|
|
7113
7113
|
"path": "modules/platform-identity/routes/scouting.js",
|
|
7114
7114
|
"mode": "0000644",
|
|
7115
|
-
"sha256": "
|
|
7115
|
+
"sha256": "3fbaaafe605fd891c449499ca85a716f9b8780bb1869f25b32162593ada8fedd"
|
|
7116
7116
|
},
|
|
7117
7117
|
{
|
|
7118
7118
|
"path": "modules/platform-identity/routes/sso.js",
|
|
@@ -8032,7 +8032,7 @@
|
|
|
8032
8032
|
{
|
|
8033
8033
|
"path": "modules/public-landing/public/terms.html",
|
|
8034
8034
|
"mode": "0000644",
|
|
8035
|
-
"sha256": "
|
|
8035
|
+
"sha256": "39aae17cd14c496533f9a212f37378571d9d621c078353e41900a02c5355df5f"
|
|
8036
8036
|
},
|
|
8037
8037
|
{
|
|
8038
8038
|
"path": "modules/render-deploy/deploys.js",
|
|
@@ -8862,12 +8862,12 @@
|
|
|
8862
8862
|
{
|
|
8863
8863
|
"path": "package-lock.json",
|
|
8864
8864
|
"mode": "0000644",
|
|
8865
|
-
"sha256": "
|
|
8865
|
+
"sha256": "35d3b7a5f69caee9c6a98b7c34c02daec4289cd0548637d05ff41fd23d1926c4"
|
|
8866
8866
|
},
|
|
8867
8867
|
{
|
|
8868
8868
|
"path": "package.json",
|
|
8869
8869
|
"mode": "0000644",
|
|
8870
|
-
"sha256": "
|
|
8870
|
+
"sha256": "9807202c95ba59b5f8104eb0c6701241d989800e67fdddf8252bc569b9a74c96"
|
|
8871
8871
|
},
|
|
8872
8872
|
{
|
|
8873
8873
|
"path": "public-docs/index.html",
|
|
@@ -8887,7 +8887,7 @@
|
|
|
8887
8887
|
{
|
|
8888
8888
|
"path": "release-notes.json",
|
|
8889
8889
|
"mode": "0000644",
|
|
8890
|
-
"sha256": "
|
|
8890
|
+
"sha256": "19b0f5588a02e7517cc25668a59df836f8ee1a183e1f1ec4a2b63d79214b3808"
|
|
8891
8891
|
},
|
|
8892
8892
|
{
|
|
8893
8893
|
"path": "scripts/bongos-mcp.js",
|
|
@@ -11002,7 +11002,7 @@
|
|
|
11002
11002
|
{
|
|
11003
11003
|
"path": "src/module-api.js",
|
|
11004
11004
|
"mode": "0000644",
|
|
11005
|
-
"sha256": "
|
|
11005
|
+
"sha256": "3f49c56de113748d04529b5028e1ac2fca037cf00c1d6be6e531346dcfbea552"
|
|
11006
11006
|
},
|
|
11007
11007
|
{
|
|
11008
11008
|
"path": "src/module-loader/catalog.js",
|
|
@@ -14842,7 +14842,7 @@
|
|
|
14842
14842
|
{
|
|
14843
14843
|
"path": "tests/recruiter_sliver_boundary.mjs",
|
|
14844
14844
|
"mode": "0000644",
|
|
14845
|
-
"sha256": "
|
|
14845
|
+
"sha256": "34c56222c40ab58be128f380a2881a2d17bd6c483560d878f6de01a00bcef297"
|
|
14846
14846
|
},
|
|
14847
14847
|
{
|
|
14848
14848
|
"path": "tests/redteam_followup_kind.mjs",
|
|
@@ -15757,7 +15757,7 @@
|
|
|
15757
15757
|
{
|
|
15758
15758
|
"path": "tests/terms_acceptance.mjs",
|
|
15759
15759
|
"mode": "0000644",
|
|
15760
|
-
"sha256": "
|
|
15760
|
+
"sha256": "80ea17a764ba05a05af0967e9951370b814c20c3518a37f1c3ca1a9ca0d044cf"
|
|
15761
15761
|
},
|
|
15762
15762
|
{
|
|
15763
15763
|
"path": "tests/terms_grandfather_db.mjs",
|
|
@@ -29,6 +29,8 @@ This is deliberately the ADR 0205 D3 property, reused. An acceptance record a ca
|
|
|
29
29
|
|
|
30
30
|
> **Amended 2026-09-25 ([task 1003353](https://cloudbongos.com/builders#/task/1003353); [blocker 1000124](https://cloudbongos.com/builders#/blocker/1000124)) — what "the hub's own sign-in" means.** `GET /sso/authorize` is reached when a builder uses their platform account to sign in to a **project**; the only builder of that URL is a child instance's `idpAuthorizeUrl`. Signing in to the hub itself creates a hub session and never touches `platform_identity_accounts`, so it records no acceptance. `/terms` said "signed in here"; it now names a project sign-in. The owner chose to also capture the hub's own sign-in ([task 1003361](https://cloudbongos.com/builders#/task/1003361)), which will make this a second capture point rather than a wording fix. Two smaller corrections to the text above: the device poll does not go through `ensureAccount`, it is a non-activating `upsertAccount`, and so is `PATCH /me/handle`; `ensureAccount` is the federated membership check-in alone. The outcome was always the same (neither writes an acceptance), and both paths are now executed in `tests/terms_acceptance.mjs` rather than asserted as text.
|
|
31
31
|
|
|
32
|
+
> **Amended 2026-09-30 ([task 1004265](https://cloudbongos.com/builders#/task/1004265)) — a project sign-in *in the browser*.** The CLI's project sign-in (`POST /sso/device/poll`) also uses the platform account, and it stays **non-activating on purpose**. The person approves it on GitHub's device page, never on a hub page, so these terms are never in front of them — and the same branch that stamps the acceptance also flips `profile_state` to active, which ADR 0171 D3 reserves for the one path "where a human is demonstrably at the hub" — and D3 names the device poll as `provisional` in so many words. Stamping it would record consent nobody was shown and re-decide D3 by implementation convenience. `/terms` therefore names a project sign-in **in your browser**, and says that a command-line sign-in records nothing and why, so a CLI-only builder is not left guessing why they are unpublished. `tests/terms_acceptance.mjs` §3 drives the real device-poll route (no acceptance, still provisional, the non-activating literal, a forged body refused before any write) and a later browser sign-in stamping that same account. The "next hub sign-in" wording under D4 is left for task 1003361, which makes it true.
|
|
33
|
+
|
|
32
34
|
### D2 — Written once. The first acceptance is the one that stands
|
|
33
35
|
|
|
34
36
|
The conflict branch writes `COALESCE(platform_identity_accounts.terms_accepted_at, now())`. Signing in again re-reads the terms but does not restamp them, so the column keeps meaning *when consent was given* rather than *when this account was last seen*. `terms_version` is COALESCE'd the same way and always written in the same statement, so the pair cannot diverge.
|
|
@@ -61,7 +61,7 @@ A **previous** handle resolves to nothing here either, deliberately unlike `reso
|
|
|
61
61
|
|
|
62
62
|
### D4 — The sliver holds spec D3's **archon floor**; the directory's wider door is not reused, and the audience goes to the owner
|
|
63
63
|
|
|
64
|
-
`GET /scouting/:handle` sits in `modules/platform-identity/routes/scouting.js` beside `GET /scouting`, and the two do **not** share a gate. The sliver is `requireBuilder` → `api.requireRank('archon')
|
|
64
|
+
`GET /scouting/:handle` sits in `modules/platform-identity/routes/scouting.js` beside `GET /scouting`, and the two do **not** share a gate. The sliver is `requireBuilder` → `api.requireRank('archon')` (behind its own read budget since [task 1003540](https://cloudbongos.com/builders#/task/1003540) — see the last honest limit); the directory keeps `requireScoutingReader({ curateGate: requirePermission('project.curate') })`. Each gate is spelled in its own route's middleware list, so `route-rank-check.js` and `gen-api-docs.js` classify each from its real floor rather than recording a privileged route as `any-builder`.
|
|
65
65
|
|
|
66
66
|
Spec D3 says the sliver is "gated at the route by `project.recruit`" — and that atom **does not exist**. ADR 0201 D3 and ADR 0210 both refuse to mint it, on the same grounds: it belongs to the project-admin-console wave ([spike 1002786](https://cloudbongos.com/builders#/task/1002786) R3), which defines it, and minting it in a third place would fork its definition across three waves before any had shipped. **So which door does it use meanwhile?** The first draft reused the directory's, and that was wrong in the dangerous direction. Spec D1 declares the missing atom's shape — **floor archon**, widenable per instance through the governance tab — while the directory admits `project.curate` at the **metic** floor (ADR 0157) **OR any project owner**, who is typically a bare `xenos` on the hub (ADR 0210 D2). That door is *wider* than the signed floor on both halves. Reusing it would have widened an owner-signed privacy decision by implementation convenience, on the first surface that discloses a private account — and narrowing after people have been disclosed is not a recoverable move, while widening later is. So the sliver holds D3's declared floor, by rank, until the atom exists.
|
|
67
67
|
|
|
@@ -102,7 +102,7 @@ Both columns exist (migration `platform_identity_012_account_privacy.sql`); the
|
|
|
102
102
|
- **A recruiting read added in another FILE would not trip the two-route guard.** D6's count is over `routes/scouting.js` alone, so the "both recruiting surfaces" copy could become false without reddening. Sweeping every route file for reach-joining reads is a structural guard of its own and belongs with the shared-predicate work, not here.
|
|
103
103
|
- **`getRecruiterSliver` (the by-id port spec D3 names) has no production caller yet** — [task 1002972](https://cloudbongos.com/builders#/task/1002972) is its consumer. The route uses the by-handle sibling; the proof exercises both.
|
|
104
104
|
- **`active_recently` is coarse by design and coarse in practice.** It is derived from `max(last_active)` across the rollup, which is refreshed on federated sign-in and on ship — so a builder active only on a project that never reports will read as inactive. That understates rather than overstates, which is the safe direction for a privacy surface.
|
|
105
|
-
-
|
|
105
|
+
- **~~This route is not rate-limited~~ — closed by [task 1003540](https://cloudbongos.com/builders#/task/1003540); what was open, and why the fix took the shape it did.** `GET /profiles/:handle` carries a per-IP read limiter so the handle→identity mapping cannot be scripted at line rate (task 1002798), and `GET /scouting/:handle` shipped with none: a reader could probe guessed handles and learn *which private accounts opted into recruiting*, a set no other surface publishes — bounded by needing to guess a private handle, so a widening of degree, not of kind. It now spends its **own** per-IP budget, `recruiter-sliver-read`, at the `/public/*` posture (120 reads / 60s), mounted **ahead of** `requireBuilder`: the tag takes the route off core's default read ceiling (`rate-limit.js` #6), so a limiter behind the gate would have left every refused probe unmetered. It is **not** `accountExistenceReadRateLimit` — ADR 0209 is one budget per oracle, and sharing would hand an enumerator the sum of two. This note used to name a **doorway-exported factory** as the fix. That was wrong on ADR 0209's own terms, which rejects a limiter factory on the doorway as *"more general and more wrong"* (two call sites with matching config get two budgets), and it was overtaken: the module has had its own single limiter factory since task 1002978 (`modules/platform-identity/read-rate-limit.js`, mounted by the community and guild reads). The sliver's budget is one instance from that factory, built at module scope so every router the file builds spends from the same bucket — no new copy, and no change to the doorway. `tests/recruiter_sliver_boundary.mjs` §6b pins the budget, its position ahead of the gate, and that it is none of core's shared instances.
|
|
106
106
|
|
|
107
107
|
**Rejected:**
|
|
108
108
|
|
package/docs/api/openapi.json
CHANGED
|
@@ -16630,7 +16630,7 @@
|
|
|
16630
16630
|
"scouting"
|
|
16631
16631
|
],
|
|
16632
16632
|
"summary": "GET /scouting/:handle",
|
|
16633
|
-
"description": "the PRE-ACCEPT SLIVER for ONE builder (privacy spec D3, ADR 0215 D4, task 1002968). This is the FIRST surface on the platform that discloses a PRIVATE account, and its audience is deliberately NOT the directory's. WHY A RANK GATE AND NOT THE RECRUITING DOOR ABOVE. Spec D3 gates this read on `project.recruit`, an atom whose declared shape is FLOOR ARCHON, widenable per instance (spec D1). That atom does not exist — ADR 0201 D3 and ADR 0210 both refuse to mint it outside the project-admin-console wave that defines it (spike 1002786 R3), and this task does not either. The directory's door (`project.curate` at metic, OR any project owner — ADR 0210 D2) is WIDER than the signed floor on both halves, so adopting it here would widen an owner-signed privacy decision by implementation convenience. Until the atom lands, the honest reading of D3 is its floor, held by rank. Whether the wider recruiting audience is authorized for this surface is the owner's call and is filed as a blocker, NOT resolved here; when it is answered, this one line moves and nothing else does. 404, never 403, for a builder who is not recruiter-reachable: a 403 would confirm the handle exists, which is the disclosure the opt-out removes. The sliver's own predicate does the deciding, inside the module.\n\n**Rank:** `archon` — Archon only (rank and identity management + the escalation keys — the trust boundary).",
|
|
16633
|
+
"description": "the PRE-ACCEPT SLIVER for ONE builder (privacy spec D3, ADR 0215 D4, task 1002968). This is the FIRST surface on the platform that discloses a PRIVATE account, and its audience is deliberately NOT the directory's. WHY A RANK GATE AND NOT THE RECRUITING DOOR ABOVE. Spec D3 gates this read on `project.recruit`, an atom whose declared shape is FLOOR ARCHON, widenable per instance (spec D1). That atom does not exist — ADR 0201 D3 and ADR 0210 both refuse to mint it outside the project-admin-console wave that defines it (spike 1002786 R3), and this task does not either. The directory's door (`project.curate` at metic, OR any project owner — ADR 0210 D2) is WIDER than the signed floor on both halves, so adopting it here would widen an owner-signed privacy decision by implementation convenience. Until the atom lands, the honest reading of D3 is its floor, held by rank. Whether the wider recruiting audience is authorized for this surface is the owner's call and is filed as a blocker, NOT resolved here; when it is answered, this one line moves and nothing else does. 404, never 403, for a builder who is not recruiter-reachable: a 403 would confirm the handle exists, which is the disclosure the opt-out removes. The sliver's own predicate does the deciding, inside the module. Rate-limited per IP (120 reads / 60s, 429 scope `recruiter-sliver-read`), and the budget is spent FIRST, ahead of the gate: its tag takes this route off core's default read ceiling, so a limiter behind requireBuilder would leave every refused probe unmetered.\n\n**Rank:** `archon` — Archon only (rank and identity management + the escalation keys — the trust boundary).",
|
|
16634
16634
|
"x-rank": "archon",
|
|
16635
16635
|
"x-source": "modules/platform-identity/routes/scouting.js",
|
|
16636
16636
|
"parameters": [
|
package/docs/copy-inventory.md
CHANGED
|
@@ -4,7 +4,7 @@
|
|
|
4
4
|
> Deterministic on a given tree — regenerate and commit rather than hand-editing.
|
|
5
5
|
> Machine-readable twin: [`copy-registry.json`](copy-registry.json).
|
|
6
6
|
|
|
7
|
-
**
|
|
7
|
+
**2188 strings** across 3 surfaces · 1888 distinct pieces of copy · 2188 certain, 0 heuristic · 207 shown in more than one place.
|
|
8
8
|
|
|
9
9
|
## Surfaces
|
|
10
10
|
|
|
@@ -12,7 +12,7 @@
|
|
|
12
12
|
|---|---|---|---|
|
|
13
13
|
| `builders-hall` | `modules/hall-ui/public` | 109 | 1617 |
|
|
14
14
|
| `status-dashboard` | `modules/status-ui/public` | 4 | 100 |
|
|
15
|
-
| `landing` | `modules/public-landing/public` | 6 |
|
|
15
|
+
| `landing` | `modules/public-landing/public` | 6 | 471 |
|
|
16
16
|
|
|
17
17
|
## Confidence, and why it is on every row
|
|
18
18
|
|
|
@@ -1805,7 +1805,7 @@ Identical copy within one surface. Sometimes right (a repeated button), sometime
|
|
|
1805
1805
|
| `7667eb552781` | certain | {…}: {…}% ({…}/{…} checks) | `modules/status-ui/public/status.js:468` |
|
|
1806
1806
|
| `6d0d64f10bd9` | certain | ‹ earlier page | `modules/status-ui/public/index.html:321` |
|
|
1807
1807
|
|
|
1808
|
-
## `landing` —
|
|
1808
|
+
## `landing` — 471 strings
|
|
1809
1809
|
|
|
1810
1810
|
| id | conf | text | where |
|
|
1811
1811
|
|---|---|---|---|
|
|
@@ -1940,7 +1940,7 @@ Identical copy within one surface. Sometimes right (a repeated button), sometime
|
|
|
1940
1940
|
| `485c565b5745` | certain | How people join | `modules/public-landing/public/projects.html:910` |
|
|
1941
1941
|
| `4b542b000afa` | certain | How this project is drawn: on the sky, in your list, at the top of this page and on its card. A planet is a | `modules/public-landing/public/projects.html:1030` |
|
|
1942
1942
|
| `9f31eaed8252` | certain | If you grant repository access while creating a project, that permission is used to create or adopt your repos | `modules/public-landing/public/privacy.html:55` |
|
|
1943
|
-
| `
|
|
1943
|
+
| `d37e2fbde8c6` | certain | If your account already existed when this version took effect, the platform accepted it on your behalf, rather | `modules/public-landing/public/terms.html:71` |
|
|
1944
1944
|
| `607551ae732b` | certain | Invite a builder | `modules/public-landing/public/projects.html:1003` |
|
|
1945
1945
|
| `20786b02f47a` | certain | Invite builders | `modules/public-landing/public/projects.html:1492` |
|
|
1946
1946
|
| `a1256030d879` | certain | Invite only | `modules/public-landing/public/projects.html:914` |
|
|
@@ -1979,7 +1979,7 @@ Identical copy within one surface. Sometimes right (a repeated button), sometime
|
|
|
1979
1979
|
| `837fdaa0936a` | certain | Nothing matches that. | `modules/public-landing/public/projects.html:707` |
|
|
1980
1980
|
| `1bc11853e893` | certain | On the map | `modules/public-landing/public/projects.html:929` |
|
|
1981
1981
|
| `b4ac8f44710c` | certain | On the public map | `modules/public-landing/public/projects.html:851` |
|
|
1982
|
-
| `
|
|
1982
|
+
| `1fdda2903cf9` | certain | Once you have signed in to a project in your browser with your platform account and accepted these terms, your | `modules/public-landing/public/terms.html:68` |
|
|
1983
1983
|
| `8329bb1a3693` | certain | One tap files the request and the platform starts standing your project up — server, database, address. Here's | `modules/public-landing/public/projects.html:1462` |
|
|
1984
1984
|
| `86cde1930d84` | certain | Only mine | `modules/public-landing/public/projects.html:477` |
|
|
1985
1985
|
| `f82fe1982ab3` | certain | Open an issue on the repository | `modules/public-landing/public/contact.html:52` |
|
|
@@ -2092,7 +2092,6 @@ Identical copy within one surface. Sometimes right (a repeated button), sometime
|
|
|
2092
2092
|
| `fb416bf1a26b` | certain | The handle names your project on the platform — and its address comes with it. Once it stands up, a few GitHub | `modules/public-landing/public/projects.html:1355` |
|
|
2093
2093
|
| `a954f0dce9a3` | certain | The platform | `modules/public-landing/public/contact.html:65` |
|
|
2094
2094
|
| `4fd8f5746cc5` | certain | The platform is run as a non-profit, capture-resistant commons. | `modules/public-landing/public/terms.html:50` |
|
|
2095
|
-
| `dede132846fe` | certain | The platform stores the date you accepted these terms, and which version, on your account. It is written when | `modules/public-landing/public/terms.html:70` |
|
|
2096
2095
|
| `20fcebaa85c4` | certain | The project hub needs JavaScript — the map, your projects, and starting a new one all live here. You can read | `modules/public-landing/public/projects.html:530` |
|
|
2097
2096
|
| `4a740b5afe73` | certain | The project map | `modules/public-landing/public/projects.html:540` |
|
|
2098
2097
|
| `345fec12e5d8` | certain | The repository | `modules/public-landing/public/contact.html:50` |
|
package/docs/copy-registry.json
CHANGED
|
@@ -3,9 +3,9 @@
|
|
|
3
3
|
"generator": "scripts/gds/copy-inventory.js",
|
|
4
4
|
"goal": 1000074,
|
|
5
5
|
"counts": {
|
|
6
|
-
"strings":
|
|
7
|
-
"unique_ids":
|
|
8
|
-
"certain":
|
|
6
|
+
"strings": 2188,
|
|
7
|
+
"unique_ids": 1888,
|
|
8
|
+
"certain": 2188,
|
|
9
9
|
"heuristic": 0,
|
|
10
10
|
"duplicate_ids": 207
|
|
11
11
|
},
|
|
@@ -23,7 +23,7 @@
|
|
|
23
23
|
"landing": {
|
|
24
24
|
"at": "modules/public-landing/public",
|
|
25
25
|
"files": 6,
|
|
26
|
-
"strings":
|
|
26
|
+
"strings": 471
|
|
27
27
|
}
|
|
28
28
|
},
|
|
29
29
|
"blind_spots": [
|
|
@@ -17936,9 +17936,9 @@
|
|
|
17936
17936
|
"confidence": "certain"
|
|
17937
17937
|
},
|
|
17938
17938
|
{
|
|
17939
|
-
"id": "
|
|
17939
|
+
"id": "d37e2fbde8c6",
|
|
17940
17940
|
"surface": "landing",
|
|
17941
|
-
"text": "If your account already existed when this version took effect, the platform accepted it on your behalf, rather than waiting for you to sign in, and dated it the day that was done. The record marks that acceptance as grandfathered, so it is never mistaken for one you gave, and your own acceptance replaces it the next time you sign in to a project.",
|
|
17941
|
+
"text": "If your account already existed when this version took effect, the platform accepted it on your behalf, rather than waiting for you to sign in, and dated it the day that was done. The record marks that acceptance as grandfathered, so it is never mistaken for one you gave, and your own acceptance replaces it the next time you sign in to a project in your browser.",
|
|
17942
17942
|
"file": "modules/public-landing/public/terms.html",
|
|
17943
17943
|
"line": 71,
|
|
17944
17944
|
"origin": "html-text",
|
|
@@ -18287,9 +18287,9 @@
|
|
|
18287
18287
|
"confidence": "certain"
|
|
18288
18288
|
},
|
|
18289
18289
|
{
|
|
18290
|
-
"id": "
|
|
18290
|
+
"id": "1fdda2903cf9",
|
|
18291
18291
|
"surface": "landing",
|
|
18292
|
-
"text": "Once you have signed in to a project with your platform account and accepted these terms, your profile and that record are public by default: at your handle’s page, in the people directory, to project owners looking for people to work with, and to search engines. An account that has never signed in to a project that way stays provisional and is published nowhere.",
|
|
18292
|
+
"text": "Once you have signed in to a project in your browser with your platform account and accepted these terms, your profile and that record are public by default: at your handle’s page, in the people directory, to project owners looking for people to work with, and to search engines. An account that has never signed in to a project that way stays provisional and is published nowhere.",
|
|
18293
18293
|
"file": "modules/public-landing/public/terms.html",
|
|
18294
18294
|
"line": 68,
|
|
18295
18295
|
"origin": "html-text",
|
|
@@ -19303,15 +19303,6 @@
|
|
|
19303
19303
|
"origin": "html-text",
|
|
19304
19304
|
"confidence": "certain"
|
|
19305
19305
|
},
|
|
19306
|
-
{
|
|
19307
|
-
"id": "dede132846fe",
|
|
19308
|
-
"surface": "landing",
|
|
19309
|
-
"text": "The platform stores the date you accepted these terms, and which version, on your account. It is written when you sign in to a project with your platform account, and only once — signing in again does not change the date you accepted. This is version",
|
|
19310
|
-
"file": "modules/public-landing/public/terms.html",
|
|
19311
|
-
"line": 70,
|
|
19312
|
-
"origin": "html-text",
|
|
19313
|
-
"confidence": "certain"
|
|
19314
|
-
},
|
|
19315
19306
|
{
|
|
19316
19307
|
"id": "20fcebaa85c4",
|
|
19317
19308
|
"surface": "landing",
|
|
@@ -2689,5 +2689,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
|
|
|
2689
2689
|
landed since 1.20.14 with no explicit bump. run 36713710510. (task 1002620)
|
|
2690
2690
|
1.20.16 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
|
|
2691
2691
|
landed since 1.20.15 with no explicit bump. run 36717488992. (task 1002620)
|
|
2692
|
+
1.20.17 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
|
|
2693
|
+
landed since 1.20.16 with no explicit bump. run 36722139698. (task 1002620)
|
|
2694
|
+
1.20.18 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
|
|
2695
|
+
landed since 1.20.17 with no explicit bump. run 36724081934. (task 1002620)
|
|
2692
2696
|
---------------------------------------------------------------------------
|
|
2693
2697
|
```
|
package/docs/page-readings.json
CHANGED
|
@@ -5,7 +5,7 @@
|
|
|
5
5
|
"adr": "0341 D3",
|
|
6
6
|
"reread": "node scripts/gds/page-reader.js --stale",
|
|
7
7
|
"how": ["Generated by node scripts/gds/page-reader.js (BV2.TW04, task 1004315; ADR 0341 D3). Do not hand-edit.","One entry per page of docs/page-inventory.json. Lines are in page order: the default state first, and a line only another state shows sits where that state shows it, with its state named.","placement: placed = a docs/copy-registry.json row renders it (file, line, string_id); shared = shell text every page of the surface carries (top bar, sidebar, footer), with its row when the registry has one; unplaced = the registry cannot place it (a rewrite becomes an engineer task, ADR 0341 D4).","text keeps {…} where the registry row has a hole, or where a value the page read from its API was filled in. A string that is only such data is counted under omitted.data, not listed.","reading_hash is over the non-shared lines (key, section, text); files_hash is over the page's inventory files. --check compares files_hash only and never opens a browser.","Rendered through the hall-preview harness (hall) and the ui-design kit stub (landing, status), at 1280x800 with the clock pinned, so a reading is the fixture world's page."],
|
|
8
|
-
"counts": {"pages":39,"lines":3791,"placed":
|
|
8
|
+
"counts": {"pages":39,"lines":3791,"placed":1277,"shared":254,"unplaced":2260,"omitted_data":2054},
|
|
9
9
|
"pages": [
|
|
10
10
|
{
|
|
11
11
|
"id": "builders:atlas",
|
|
@@ -4132,9 +4132,9 @@
|
|
|
4132
4132
|
"surface": "landing",
|
|
4133
4133
|
"title": "{{productName}} — Terms",
|
|
4134
4134
|
"states_read": ["default"],
|
|
4135
|
-
"files_hash": "
|
|
4136
|
-
"reading_hash": "
|
|
4137
|
-
"counts": {"lines":45,"placed":
|
|
4135
|
+
"files_hash": "5f1171d0ce6fb7d3",
|
|
4136
|
+
"reading_hash": "007bea800099720b",
|
|
4137
|
+
"counts": {"lines":45,"placed":28,"shared":9,"unplaced":8},
|
|
4138
4138
|
"omitted": {"data":1},
|
|
4139
4139
|
"notes": [],
|
|
4140
4140
|
"lines": [
|
|
@@ -4158,13 +4158,13 @@
|
|
|
4158
4158
|
{"key":"L0018","section":"Your work across projects","text":"These numbers describe; they do not govern.","placement":"placed","file":"modules/public-landing/public/terms.html","line":67,"string_id":"02e596cc4569"},
|
|
4159
4159
|
{"key":"L0019","section":"Your work across projects","text":"Your cross-project record is descriptive analytics and never authority. What you may do inside any project is decided by that project alone, from its own records, at the moment you ask. A large record grants nothing and a hidden one takes nothing away; no project is required to read it, and {…} may treat it as permission. A rank shown here is that project’s own standing for you, as that project reported it — the platform holds no rank of its own.","placement":"unplaced"},
|
|
4160
4160
|
{"key":"L0020","section":"Your work across projects","text":"What is public.","placement":"placed","file":"modules/public-landing/public/terms.html","line":68,"string_id":"9b3312899fb1"},
|
|
4161
|
-
{"key":"L0021","section":"Your work across projects","text":"Once you have signed in to a project with your platform account and accepted these terms, your profile and that record are public by default: at your handle’s page, in the people directory, to project owners looking for people to work with, and to search engines. An account that has never signed in to a project that way stays provisional and is published nowhere.","placement":"placed","file":"modules/public-landing/public/terms.html","line":68,"string_id":"
|
|
4161
|
+
{"key":"L0021","section":"Your work across projects","text":"Once you have signed in to a project in your browser with your platform account and accepted these terms, your profile and that record are public by default: at your handle’s page, in the people directory, to project owners looking for people to work with, and to search engines. An account that has never signed in to a project that way stays provisional and is published nowhere.","placement":"placed","file":"modules/public-landing/public/terms.html","line":68,"string_id":"1fdda2903cf9"},
|
|
4162
4162
|
{"key":"L0022","section":"Your work across projects","text":"What you control.","placement":"placed","file":"modules/public-landing/public/terms.html","line":69,"string_id":"6130dcb60532"},
|
|
4163
4163
|
{"key":"L0023","section":"Your work across projects","text":"From your settings you can hide your statistics, drop out of the recruiting directory, or make your account private. Each takes effect immediately, everywhere, including on a page someone already has open. Hiding removes the platform’s combined view; it does not retract the per-project numbers each project publishes itself, so a determined reader could still add them up the hard way.","placement":"placed","file":"modules/public-landing/public/terms.html","line":69,"string_id":"0808df6e434c"},
|
|
4164
4164
|
{"key":"L0024","section":"Your work across projects","text":"Your acceptance is recorded.","placement":"placed","file":"modules/public-landing/public/terms.html","line":70,"string_id":"0f06f7e72ea7"},
|
|
4165
|
-
{"key":"L0025","section":"Your work across projects","text":"The platform stores the date you accepted these terms, and which version, on your account. It is written when you sign in to a project with your platform account, and only once — signing in again does not change the date you accepted. This is version","placement":"
|
|
4165
|
+
{"key":"L0025","section":"Your work across projects","text":"The platform stores the date you accepted these terms, and which version, on your account. It is written when you sign in to a project in your browser with your platform account, and only once — signing in again does not change the date you accepted. Signing in from the command line does not record it: you approve that sign-in on GitHub’s page, where these terms are not shown, so an account that has only signed in that way stays unpublished until you sign in to a project in your browser once. This is version","placement":"unplaced"},
|
|
4166
4166
|
{"key":"L0026","section":"Your work across projects","text":"Accounts from before these terms.","placement":"placed","file":"modules/public-landing/public/terms.html","line":71,"string_id":"9b02ec8a2e21"},
|
|
4167
|
-
{"key":"L0027","section":"Your work across projects","text":"If your account already existed when this version took effect, the platform accepted it on your behalf, rather than waiting for you to sign in, and dated it the day that was done. The record marks that acceptance as grandfathered, so it is never mistaken for one you gave, and your own acceptance replaces it the next time you sign in to a project.","placement":"placed","file":"modules/public-landing/public/terms.html","line":71,"string_id":"
|
|
4167
|
+
{"key":"L0027","section":"Your work across projects","text":"If your account already existed when this version took effect, the platform accepted it on your behalf, rather than waiting for you to sign in, and dated it the day that was done. The record marks that acceptance as grandfathered, so it is never mistaken for one you gave, and your own acceptance replaces it the next time you sign in to a project in your browser.","placement":"placed","file":"modules/public-landing/public/terms.html","line":71,"string_id":"d37e2fbde8c6"},
|
|
4168
4168
|
{"key":"L0028","section":"Fair use","text":"Fair use","placement":"placed","file":"modules/public-landing/public/terms.html","line":73,"string_id":"2585087f4873"},
|
|
4169
4169
|
{"key":"L0029","section":"Fair use","text":"Don't use {{productName}} to break the law, to attack this site or other people's projects, to mine, spam or otherwise abuse hosted resources, or to harass other builders. The owner may deactivate a builder or take a project offline for breaking these, and may set further house rules inside the hall.","placement":"placed","file":"modules/public-landing/public/terms.html","line":74,"string_id":"8d812912c392"},
|
|
4170
4170
|
{"key":"L0030","section":"Liability","text":"Liability","placement":"unplaced"},
|
|
@@ -1,12 +1,14 @@
|
|
|
1
|
-
// modules/platform-identity/read-rate-limit.js — a per-IP read cap for
|
|
2
|
-
//
|
|
1
|
+
// modules/platform-identity/read-rate-limit.js — a per-IP read cap for a GET
|
|
2
|
+
// in this module that must not be scripted at line rate. The global limiter meters writes
|
|
3
3
|
// only, and core's per-IP sliding window (src/bongos/middleware/rate-limit.js
|
|
4
4
|
// perIpSlidingWindow) reaches modules only as ready-built instances on the
|
|
5
5
|
// doorway (ADR 0209: an instance per budget), none of which is this module's.
|
|
6
6
|
// This is the module-side twin of that function — same 429 envelope and
|
|
7
7
|
// headers — written once (task 1002978) and mounted by the community reads
|
|
8
|
-
// (routes/community-leaderboard.js, routes/community-search.js)
|
|
9
|
-
// guild read (routes/guilds-public.js)
|
|
8
|
+
// (routes/community-leaderboard.js, routes/community-search.js), the public
|
|
9
|
+
// guild read (routes/guilds-public.js) and the recruiter sliver
|
|
10
|
+
// (routes/scouting.js GET /scouting/:handle, task 1003540 — authenticated, but a
|
|
11
|
+
// handle probe there reveals who opted into recruiting).
|
|
10
12
|
// routes/public-profile.js and routes/sso.js still carry older vendored copies.
|
|
11
13
|
'use strict';
|
|
12
14
|
|
|
@@ -41,9 +41,26 @@ const pi = require('../platform-identity');
|
|
|
41
41
|
const scoutingAuthz = require('../scouting-authz');
|
|
42
42
|
const recruiterSliver = require('../recruiter-sliver');
|
|
43
43
|
const scoutingNameOnly = require('../scouting-name-only');
|
|
44
|
+
const { createReadRateLimit } = require('../read-rate-limit');
|
|
44
45
|
|
|
45
46
|
const { pool, requireBuilder, parsePagination } = api;
|
|
46
47
|
|
|
48
|
+
// The sliver's per-IP read budget (task 1003540, ADR 0215). Probing guessed
|
|
49
|
+
// handles tells a reader WHICH private accounts opted into recruiting — a set no
|
|
50
|
+
// other surface publishes — so the probe is metered at the /public/* posture.
|
|
51
|
+
// Its OWN budget, never accountExistenceReadRateLimit: ADR 0209 is one budget per
|
|
52
|
+
// oracle, and sharing hands an enumerator the sum of two. Built ONCE at module
|
|
53
|
+
// scope, so every router this file builds spends from the same bucket, by the
|
|
54
|
+
// module's one limiter factory rather than a vendored copy. Not a doorway
|
|
55
|
+
// factory: ADR 0209 rejected that shape because two call sites get two budgets.
|
|
56
|
+
const SLIVER_READ_WINDOW_MS = 60 * 1000;
|
|
57
|
+
const SLIVER_READ_LIMIT = 120;
|
|
58
|
+
const sliverReadRateLimit = createReadRateLimit({
|
|
59
|
+
scope: 'recruiter-sliver-read',
|
|
60
|
+
limit: SLIVER_READ_LIMIT,
|
|
61
|
+
windowMs: SLIVER_READ_WINDOW_MS,
|
|
62
|
+
});
|
|
63
|
+
|
|
47
64
|
// Resolved at CALL time, never at load. Proofs that exercise this route pin a
|
|
48
65
|
// PARTIAL doorway (tests/profile_route.mjs stubs pool + the two gates and
|
|
49
66
|
// nothing else), and a module-scope api.logger() would make this file
|
|
@@ -118,8 +135,14 @@ module.exports = function scoutingRoutes() {
|
|
|
118
135
|
// 404, never 403, for a builder who is not recruiter-reachable: a 403 would
|
|
119
136
|
// confirm the handle exists, which is the disclosure the opt-out removes. The
|
|
120
137
|
// sliver's own predicate does the deciding, inside the module.
|
|
138
|
+
//
|
|
139
|
+
// Rate-limited per IP (120 reads / 60s, 429 scope `recruiter-sliver-read`),
|
|
140
|
+
// and the budget is spent FIRST, ahead of the gate: its tag takes this route
|
|
141
|
+
// off core's default read ceiling, so a limiter behind requireBuilder would
|
|
142
|
+
// leave every refused probe unmetered.
|
|
121
143
|
router.get(
|
|
122
144
|
'/scouting/:handle',
|
|
145
|
+
sliverReadRateLimit,
|
|
123
146
|
requireBuilder,
|
|
124
147
|
api.requireRank('archon'),
|
|
125
148
|
async (req, res) => {
|
|
@@ -139,3 +162,7 @@ module.exports = function scoutingRoutes() {
|
|
|
139
162
|
|
|
140
163
|
return router;
|
|
141
164
|
};
|
|
165
|
+
|
|
166
|
+
// Exported for tests — the sliver's budget instance and its limits (the
|
|
167
|
+
// routes/community-search.js precedent).
|
|
168
|
+
module.exports._internals = { sliverReadRateLimit, SLIVER_READ_LIMIT, SLIVER_READ_WINDOW_MS };
|
|
@@ -65,10 +65,10 @@
|
|
|
65
65
|
<h2>Your work across projects</h2>
|
|
66
66
|
<p>Each {{productName}} project you build in reports a summary of your work there to the platform: the {{currency}} you earned, the works you shipped, your karma, the rank that project gave you, the roles you worked in, and when you were last active. The platform adds these up across every project into one cross-project record. Projects report this themselves — the platform does not read their databases.</p>
|
|
67
67
|
<p><b>These numbers describe; they do not govern.</b> Your cross-project record is descriptive analytics and never authority. What you may do inside any project is decided by that project alone, from its own records, at the moment you ask. A large record grants nothing and a hidden one takes nothing away; no project is required to read it, and none may treat it as permission. A rank shown here is that project’s own standing for you, as that project reported it — the platform holds no rank of its own.</p>
|
|
68
|
-
<p><b>What is public.</b> Once you have signed in to a project with your platform account and accepted these terms, your profile and that record are public by default: at your handle’s page, in the people directory, to project owners looking for people to work with, and to search engines. An account that has never signed in to a project that way stays provisional and is published nowhere.</p>
|
|
68
|
+
<p><b>What is public.</b> Once you have signed in to a project in your browser with your platform account and accepted these terms, your profile and that record are public by default: at your handle’s page, in the people directory, to project owners looking for people to work with, and to search engines. An account that has never signed in to a project that way stays provisional and is published nowhere.</p>
|
|
69
69
|
<p><b>What you control.</b> From your settings you can hide your statistics, drop out of the recruiting directory, or make your account private. Each takes effect immediately, everywhere, including on a page someone already has open. Hiding removes the platform’s combined view; it does not retract the per-project numbers each project publishes itself, so a determined reader could still add them up the hard way.</p>
|
|
70
|
-
<p><b>Your acceptance is recorded.</b> The platform stores the date you accepted these terms, and which version, on your account. It is written when you sign in to a project with your platform account, and only once — signing in again does not change the date you accepted. This is version <b>2026-08-29</b>.</p>
|
|
71
|
-
<p><b>Accounts from before these terms.</b> If your account already existed when this version took effect, the platform accepted it on your behalf, rather than waiting for you to sign in, and dated it the day that was done. The record marks that acceptance as grandfathered, so it is never mistaken for one you gave, and your own acceptance replaces it the next time you sign in to a project.</p>
|
|
70
|
+
<p><b>Your acceptance is recorded.</b> The platform stores the date you accepted these terms, and which version, on your account. It is written when you sign in to a project in your browser with your platform account, and only once — signing in again does not change the date you accepted. Signing in from the command line does not record it: you approve that sign-in on GitHub’s page, where these terms are not shown, so an account that has only signed in that way stays unpublished until you sign in to a project in your browser once. This is version <b>2026-08-29</b>.</p>
|
|
71
|
+
<p><b>Accounts from before these terms.</b> If your account already existed when this version took effect, the platform accepted it on your behalf, rather than waiting for you to sign in, and dated it the day that was done. The record marks that acceptance as grandfathered, so it is never mistaken for one you gave, and your own acceptance replaces it the next time you sign in to a project in your browser.</p>
|
|
72
72
|
<!--apex-only:end-->
|
|
73
73
|
<h2>Fair use</h2>
|
|
74
74
|
<p>Don't use {{productName}} to break the law, to attack this site or other people's projects, to mine, spam or otherwise abuse hosted resources, or to harass other builders. The owner may deactivate a builder or take a project offline for breaking these, and may set further house rules inside the hall.</p>
|
package/package-lock.json
CHANGED
|
@@ -1,12 +1,12 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@bongos/core",
|
|
3
|
-
"version": "1.20.
|
|
3
|
+
"version": "1.20.18",
|
|
4
4
|
"lockfileVersion": 3,
|
|
5
5
|
"requires": true,
|
|
6
6
|
"packages": {
|
|
7
7
|
"": {
|
|
8
8
|
"name": "@bongos/core",
|
|
9
|
-
"version": "1.20.
|
|
9
|
+
"version": "1.20.18",
|
|
10
10
|
"license": "AGPL-3.0-or-later",
|
|
11
11
|
"dependencies": {
|
|
12
12
|
"express": "^4.21.2",
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@bongos/core",
|
|
3
|
-
"version": "1.20.
|
|
3
|
+
"version": "1.20.18",
|
|
4
4
|
"description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
|
|
5
5
|
"license": "AGPL-3.0-or-later",
|
|
6
6
|
"main": "src/platform-server.js",
|
package/release-notes.json
CHANGED
|
@@ -8152,5 +8152,17 @@
|
|
|
8152
8152
|
"id": "1004185",
|
|
8153
8153
|
"text": "Cleaned out leftover code for a hosting option we retired, with proof that every live project's setup is unchanged — no project sees any difference."
|
|
8154
8154
|
}
|
|
8155
|
+
],
|
|
8156
|
+
"1.20.17": [
|
|
8157
|
+
{
|
|
8158
|
+
"id": "1003540",
|
|
8159
|
+
"text": "Guessing someone's private profile name on the recruiting page is now speed-limited, so it can't be used to discover who is open to recruiting."
|
|
8160
|
+
}
|
|
8161
|
+
],
|
|
8162
|
+
"1.20.18": [
|
|
8163
|
+
{
|
|
8164
|
+
"id": "1004265",
|
|
8165
|
+
"text": "The terms page now says your agreement is recorded when you sign in to a project in your browser, and explains why a command-line-only sign-in doesn't publish your profile."
|
|
8166
|
+
}
|
|
8155
8167
|
]
|
|
8156
8168
|
}
|
package/src/module-api.js
CHANGED
|
@@ -75,7 +75,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
|
|
|
75
75
|
// MAJOR (see allowBoxScope below): passes the request through untouched.
|
|
76
76
|
function deprecatedNoopMiddleware(_req, _res, next) { next(); }
|
|
77
77
|
|
|
78
|
-
const CORE_VERSION = '1.20.
|
|
78
|
+
const CORE_VERSION = '1.20.18'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
|
|
79
79
|
|
|
80
80
|
// A namespaced logger so a module's log lines are attributable + consistent.
|
|
81
81
|
// Usage: const log = api.logger('discord'); log.info('mounted');
|
|
@@ -57,6 +57,8 @@
|
|
|
57
57
|
// project owner — is wider on both halves. A metic operator and a project owner
|
|
58
58
|
// both read the directory and are both refused here, which is asserted in both
|
|
59
59
|
// directions so a later "tidy-up" onto one shared gate cannot pass quietly.
|
|
60
|
+
// And the read BUDGET ahead of that gate (§6b, task 1003540): the sliver's own
|
|
61
|
+
// per-IP bucket, never a shared one (ADR 0209), so a handle probe is metered.
|
|
60
62
|
//
|
|
61
63
|
// MECHANISM (tests/profile_privacy_owner_view.mjs + tests/connections_ownership.mjs):
|
|
62
64
|
// in-memory tables whose row filter is built FROM EACH STATEMENT'S OWN WHERE
|
|
@@ -802,6 +804,73 @@ test('each route spells its OWN gate in its OWN middleware list', () => {
|
|
|
802
804
|
'and the sliver must never pick up the directory wider door by accident');
|
|
803
805
|
});
|
|
804
806
|
|
|
807
|
+
// ===========================================================================
|
|
808
|
+
// 6b. THE READ BUDGET — its own, and ahead of the gate (task 1003540)
|
|
809
|
+
// ===========================================================================
|
|
810
|
+
|
|
811
|
+
// The middleware list of one route, as the router a fresh scoutingRoutes() builds.
|
|
812
|
+
const handlersOf = (routePath) => buildScoutingRoutes().stack
|
|
813
|
+
.find((l) => l.route && l.route.path === routePath).route.stack.map((l) => l.handle);
|
|
814
|
+
|
|
815
|
+
test('the sliver spends its OWN per-IP read budget, and one budget however many routers mount it', () => {
|
|
816
|
+
// Probing guessed handles tells a reader WHICH private accounts opted into
|
|
817
|
+
// recruiting — a set no other surface publishes — so the probe is metered
|
|
818
|
+
// (ADR 0215's honest limit, closed). ADR 0209: one budget per oracle. Sharing
|
|
819
|
+
// an existing budget would hand an enumerator the sum of two, and a limiter
|
|
820
|
+
// built per router would hand a second mount a second budget.
|
|
821
|
+
const { sliverReadRateLimit } = buildScoutingRoutes._internals;
|
|
822
|
+
assert.equal(sliverReadRateLimit.meteredScope, 'recruiter-sliver-read');
|
|
823
|
+
assert.equal(handlersOf('/scouting/:handle')[0], sliverReadRateLimit);
|
|
824
|
+
assert.equal(handlersOf('/scouting/:handle')[0], handlersOf('/scouting/:handle')[0],
|
|
825
|
+
'two routers built from this file spend from ONE budget, not one each');
|
|
826
|
+
const core = require('../src/bongos/middleware/rate-limit.js');
|
|
827
|
+
for (const other of [core.accountExistenceReadRateLimit, core.publicProjectFeedRateLimit, core.publicReadRateLimitMiddleware]) {
|
|
828
|
+
assert.notEqual(sliverReadRateLimit, other, `the sliver must not spend the ${other.meteredScope} budget`);
|
|
829
|
+
}
|
|
830
|
+
assert.ok(!handlersOf('/scouting').includes(sliverReadRateLimit),
|
|
831
|
+
'the directory is a different read and does not spend the sliver budget');
|
|
832
|
+
});
|
|
833
|
+
|
|
834
|
+
test('the budget runs AHEAD of the gate, so an unauthenticated probe is metered too', () => {
|
|
835
|
+
// A tagged route is skipped by core's default read ceiling (rate-limit.js #6).
|
|
836
|
+
// Behind requireBuilder, this limiter would leave every refused probe unmetered
|
|
837
|
+
// — looser than the ceiling it replaces.
|
|
838
|
+
const handlers = handlersOf('/scouting/:handle');
|
|
839
|
+
const { sliverReadRateLimit } = buildScoutingRoutes._internals;
|
|
840
|
+
assert.equal(handlers.indexOf(sliverReadRateLimit), 0, 'the limiter is the first handler on the route');
|
|
841
|
+
});
|
|
842
|
+
|
|
843
|
+
test('120 reads a minute per IP, then a 429 that names the sliver budget', () => {
|
|
844
|
+
const { sliverReadRateLimit, SLIVER_READ_LIMIT, SLIVER_READ_WINDOW_MS } = buildScoutingRoutes._internals;
|
|
845
|
+
assert.equal(SLIVER_READ_LIMIT, 120, 'the /public/* posture');
|
|
846
|
+
assert.equal(SLIVER_READ_WINDOW_MS, 60 * 1000);
|
|
847
|
+
const mkRes = () => {
|
|
848
|
+
const r = { _status: 200, _json: null, _headers: {} };
|
|
849
|
+
r.set = (k, v) => { r._headers[k] = v; return r; };
|
|
850
|
+
r.status = (s) => { r._status = s; return r; };
|
|
851
|
+
r.json = (j) => { r._json = j; return r; };
|
|
852
|
+
attachFail({}, r, () => {});
|
|
853
|
+
return r;
|
|
854
|
+
};
|
|
855
|
+
// A documentation-range IP of its own, so the HTTP tests above keep their bucket.
|
|
856
|
+
const req = { ip: '203.0.113.140' };
|
|
857
|
+
let allowed = 0;
|
|
858
|
+
for (let i = 0; i < SLIVER_READ_LIMIT; i++) sliverReadRateLimit(req, mkRes(), () => { allowed++; });
|
|
859
|
+
assert.equal(allowed, SLIVER_READ_LIMIT, 'every read up to the cap passes');
|
|
860
|
+
const res = mkRes();
|
|
861
|
+
let nexted = false;
|
|
862
|
+
sliverReadRateLimit(req, res, () => { nexted = true; });
|
|
863
|
+
assert.equal(nexted, false, 'the read past the cap never reaches the gate or the query');
|
|
864
|
+
assert.equal(res._status, 429);
|
|
865
|
+
assert.equal(res._json.error.code, 'rate_limited');
|
|
866
|
+
assert.equal(res._headers['X-RateLimit-Scope'], 'recruiter-sliver-read');
|
|
867
|
+
assert.equal(res._headers['X-RateLimit-Limit'], '120');
|
|
868
|
+
assert.ok(Number(res._headers['Retry-After']) >= 1, 'a Retry-After header is set');
|
|
869
|
+
let otherPassed = false;
|
|
870
|
+
sliverReadRateLimit({ ip: '203.0.113.141' }, mkRes(), () => { otherPassed = true; });
|
|
871
|
+
assert.equal(otherPassed, true, 'one address hitting the cap does not throttle another');
|
|
872
|
+
});
|
|
873
|
+
|
|
805
874
|
// ===========================================================================
|
|
806
875
|
// 7. IT GRANTS NOTHING (ADR 0016)
|
|
807
876
|
// ===========================================================================
|
|
@@ -118,20 +118,32 @@ t('the acceptance the page promises is the one the code actually keeps', () => {
|
|
|
118
118
|
});
|
|
119
119
|
|
|
120
120
|
// The capture point is GET /sso/authorize — reached when a builder uses their
|
|
121
|
-
// platform account to sign in to a PROJECT. Signing in to the hub
|
|
122
|
-
// nothing (blocker 1000124, task 1003353), so the page must not say
|
|
123
|
-
//
|
|
124
|
-
//
|
|
125
|
-
|
|
121
|
+
// platform account to sign in to a PROJECT, IN A BROWSER. Signing in to the hub
|
|
122
|
+
// itself stamps nothing (blocker 1000124, task 1003353), so the page must not say
|
|
123
|
+
// "here"; and the CLI's project sign-in (the device poll) stamps nothing either
|
|
124
|
+
// (task 1004265, executed in §3), so the page must say "in your browser" and tell a
|
|
125
|
+
// command-line builder why. Task 1003361 adds the hub's own sign-in as a second
|
|
126
|
+
// capture point; when it lands, this wording and §3 below change together.
|
|
127
|
+
t('the page names the sign-in the code actually watches — a project sign-in in the browser, not "here" (blocker 1000124)', () => {
|
|
126
128
|
const section = termsHtml.slice(termsHtml.indexOf('Your work across projects'), termsHtml.indexOf('Fair use'));
|
|
127
129
|
assert.doesNotMatch(section, /sign(?:ed|ing)? in here/i,
|
|
128
130
|
'the page promises that signing in to this site records acceptance — the code never stamps that sign-in');
|
|
129
|
-
assert.match(section, /Once you have signed in to a project with your platform account and accepted these terms/,
|
|
131
|
+
assert.match(section, /Once you have signed in to a project in your browser with your platform account and accepted these terms/,
|
|
130
132
|
'what makes a profile public must name the moment the code captures');
|
|
131
133
|
assert.match(section, /never signed in to a project that way stays provisional/,
|
|
132
134
|
'and the provisional case must be the same moment, negated');
|
|
133
|
-
assert.match(section, /written when you sign in to a project with your platform account, and only once/,
|
|
135
|
+
assert.match(section, /written when you sign in to a project in your browser with your platform account, and only once/,
|
|
134
136
|
'the acceptance paragraph must name the same capture point');
|
|
137
|
+
assert.doesNotMatch(section, /sign(?:ed)? in to a project with your platform account/,
|
|
138
|
+
'an unqualified "project sign-in" also covers the command line, which records nothing (task 1004265)');
|
|
139
|
+
});
|
|
140
|
+
|
|
141
|
+
t('the page tells a command-line-only builder that their sign-in records nothing, and why (task 1004265)', () => {
|
|
142
|
+
const section = termsHtml.slice(termsHtml.indexOf('Your work across projects'), termsHtml.indexOf('Fair use'));
|
|
143
|
+
assert.match(section, /Signing in from the command line does not record it/,
|
|
144
|
+
'a CLI-only builder stays unpublished, and the page must say so rather than leave them to guess');
|
|
145
|
+
assert.match(section, /on GitHub’s page, where these terms are not shown/,
|
|
146
|
+
'and why: the device approval never puts these terms in front of them');
|
|
135
147
|
});
|
|
136
148
|
|
|
137
149
|
t('the page says which acceptances were given on a builder’s behalf, and that the record marks them (task 1003360)', () => {
|
|
@@ -139,7 +151,7 @@ t('the page says which acceptances were given on a builder’s behalf, and that
|
|
|
139
151
|
'the owner chose to grandfather AND to say so on the page — the page must tell a pre-existing builder what was recorded for them');
|
|
140
152
|
assert.match(termsHtml, /marks that acceptance as grandfathered/i,
|
|
141
153
|
'and that the record keeps it distinguishable from one they gave');
|
|
142
|
-
assert.match(termsHtml, /your own acceptance replaces it the next time you sign in to a project/i,
|
|
154
|
+
assert.match(termsHtml, /your own acceptance replaces it the next time you sign in to a project in your browser/i,
|
|
143
155
|
'and what happens when they do sign in — the conflict branch below really does replace it');
|
|
144
156
|
assert.doesNotMatch(termsHtml, /written only by signing in/i,
|
|
145
157
|
'the page still says acceptance is written ONLY by signing in, which is false for every grandfathered account');
|
|
@@ -503,6 +515,100 @@ await ta('a session of an undeclared source (a leftover dev-box token) cannot mi
|
|
|
503
515
|
assert.equal(pool.accounts.size, 0, 'a session of an undeclared source recorded a platform T&C acceptance');
|
|
504
516
|
});
|
|
505
517
|
|
|
518
|
+
// The CLI's project sign-in (POST /sso/device/poll) also uses the platform account,
|
|
519
|
+
// and it deliberately records NOTHING (task 1004265). The approval happens on
|
|
520
|
+
// GitHub's device page, never on a hub page, so these terms are never in front of
|
|
521
|
+
// the person — and activation is ADR 0171 D3's "a human is demonstrably at the hub",
|
|
522
|
+
// which the same branch stamps. So the page names a BROWSER sign-in and says why a
|
|
523
|
+
// command-line one does not count; this drives the real route to hold that claim.
|
|
524
|
+
function post(path_, body) {
|
|
525
|
+
const payload = JSON.stringify(body);
|
|
526
|
+
return new Promise((resolve, reject) => {
|
|
527
|
+
const req = http.request({
|
|
528
|
+
host: '127.0.0.1', port, method: 'POST', path: path_,
|
|
529
|
+
headers: { 'content-type': 'application/json', 'content-length': Buffer.byteLength(payload) },
|
|
530
|
+
}, (res) => {
|
|
531
|
+
const chunks = [];
|
|
532
|
+
res.on('data', (c) => chunks.push(c));
|
|
533
|
+
res.on('end', () => {
|
|
534
|
+
const text = Buffer.concat(chunks).toString('utf8');
|
|
535
|
+
let json = null; try { json = JSON.parse(text); } catch { /* not JSON */ }
|
|
536
|
+
resolve({ status: res.statusCode, json });
|
|
537
|
+
});
|
|
538
|
+
});
|
|
539
|
+
req.on('error', reject);
|
|
540
|
+
req.end(payload);
|
|
541
|
+
});
|
|
542
|
+
}
|
|
543
|
+
|
|
544
|
+
// GitHub's side of the device flow, answered as approved for `identity`. The route
|
|
545
|
+
// reaches both modules through their exports objects, so this swaps the network leg
|
|
546
|
+
// and the signing key only — the route, its upsert and the fake pool stay real.
|
|
547
|
+
async function withApprovedDevice(identity, fn) {
|
|
548
|
+
const hubDevice = require('../modules/platform-identity/hub-device.js');
|
|
549
|
+
const hubKeys = require('../modules/platform-identity/hub-keys.js');
|
|
550
|
+
const saved = {
|
|
551
|
+
hubDeviceConfigured: hubDevice.hubDeviceConfigured,
|
|
552
|
+
pollHubGithubDevice: hubDevice.pollHubGithubDevice,
|
|
553
|
+
hubSigningConfigured: hubKeys.hubSigningConfigured,
|
|
554
|
+
mintHubAssertion: hubKeys.mintHubAssertion,
|
|
555
|
+
};
|
|
556
|
+
hubDevice.hubDeviceConfigured = () => true;
|
|
557
|
+
hubDevice.pollHubGithubDevice = async () => ({ state: 'ok', client_id: 'proj-a', identity });
|
|
558
|
+
hubKeys.hubSigningConfigured = () => true;
|
|
559
|
+
hubKeys.mintHubAssertion = () => 'ASSERTION';
|
|
560
|
+
try { return await fn(); } finally {
|
|
561
|
+
hubDevice.hubDeviceConfigured = saved.hubDeviceConfigured;
|
|
562
|
+
hubDevice.pollHubGithubDevice = saved.pollHubGithubDevice;
|
|
563
|
+
hubKeys.hubSigningConfigured = saved.hubSigningConfigured;
|
|
564
|
+
hubKeys.mintHubAssertion = saved.mintHubAssertion;
|
|
565
|
+
}
|
|
566
|
+
}
|
|
567
|
+
|
|
568
|
+
const CLI_IDENTITY = { github_id: '5151', github_login: 'cli-only', display_name: 'Cli Only', avatar_url: null };
|
|
569
|
+
|
|
570
|
+
await ta('a CLI-only project sign-in (the device poll) signs the builder in and records NO acceptance (task 1004265)', async () => {
|
|
571
|
+
SESSION = null;
|
|
572
|
+
pool.accounts.clear();
|
|
573
|
+
pool.calls.length = 0;
|
|
574
|
+
pool.setClock(NOW);
|
|
575
|
+
const res = await withApprovedDevice(CLI_IDENTITY, () => post('/sso/device/poll', { device_code: 'dc-1' }));
|
|
576
|
+
assert.equal(res.status, 200, 'CONTROL: the device poll must succeed, or the absence below proves nothing');
|
|
577
|
+
assert.equal(res.json && res.json.assertion, 'ASSERTION', 'CONTROL: the CLI got its sign-in assertion');
|
|
578
|
+
const row = pool.accounts.get('5151');
|
|
579
|
+
assert.ok(row, 'CONTROL: the device poll writes the platform account — the absence below is of the stamp, not the row');
|
|
580
|
+
assert.equal(row.terms_accepted_at, null,
|
|
581
|
+
'a command-line sign-in stamped an acceptance — nobody was shown the terms on that path; if this is now intended, /terms and ADR 0213 change with it');
|
|
582
|
+
assert.equal(row.terms_version, null);
|
|
583
|
+
assert.equal(row.profile_state, 'provisional', 'and it activates nothing (ADR 0171 D3: activation is a human at the hub)');
|
|
584
|
+
const upserts = pool.calls.filter((c) => /INSERT INTO platform_identity_accounts/i.test(c.sql) && /DO UPDATE/i.test(c.sql));
|
|
585
|
+
assert.equal(upserts.length, 1);
|
|
586
|
+
assert.equal(upserts[0].params[4], false, 'the device poll must pass the non-activating literal');
|
|
587
|
+
});
|
|
588
|
+
|
|
589
|
+
await ta('the device poll takes no acceptance from its body either — an extra field is refused before any write', async () => {
|
|
590
|
+
pool.accounts.clear();
|
|
591
|
+
const res = await withApprovedDevice(CLI_IDENTITY, () => post('/sso/device/poll', {
|
|
592
|
+
device_code: 'dc-2', activate: true, terms_accepted_at: '1999-01-01T00:00:00.000Z', terms_version: 'FORGED',
|
|
593
|
+
}));
|
|
594
|
+
assert.equal(res.status, 400, 'the strict validator must refuse fields the route does not declare');
|
|
595
|
+
assert.equal(pool.accounts.size, 0, 'a refused poll still wrote an account');
|
|
596
|
+
});
|
|
597
|
+
|
|
598
|
+
await ta('a CLI-only builder who later signs in to a project in the browser IS stamped then', async () => {
|
|
599
|
+
pool.accounts.clear();
|
|
600
|
+
pool.setClock(NOW);
|
|
601
|
+
await withApprovedDevice({ ...CLI_IDENTITY, github_id: '4242', github_login: 'octo' },
|
|
602
|
+
() => post('/sso/device/poll', { device_code: 'dc-3' }));
|
|
603
|
+
assert.equal(pool.accounts.get('4242').terms_accepted_at, null);
|
|
604
|
+
SESSION = HUB_SESSION;
|
|
605
|
+
pool.setClock(LATER);
|
|
606
|
+
assert.equal((await authorize()).status, 302);
|
|
607
|
+
const row = pool.accounts.get('4242');
|
|
608
|
+
assert.equal(row.terms_accepted_at, LATER, 'the browser sign-in the page names must stamp the account the CLI created');
|
|
609
|
+
assert.equal(row.profile_state, 'active');
|
|
610
|
+
});
|
|
611
|
+
|
|
506
612
|
// ===========================================================================
|
|
507
613
|
// 4. Idempotence — executed, not asserted against a string
|
|
508
614
|
// ===========================================================================
|