@bongos/core 1.19.999 → 1.19.1000

package/tests/provisioning_restart.mjs

@@ -89,10 +89,17 @@ t('RESTART_FROM is exactly {active} — every other state is already served by t
   }
 });
 
-t('RESTART_SHAPES is the runner-reachable pair — dedicated is out, and the set is a subset of HOSTING_SHAPES', () => {
-  assert.deepEqual([...provisioning.RESTART_SHAPES].sort(), ['co-tenant', 'standalone']);
-  assert.ok(!provisioning.RESTART_SHAPES.has('dedicated'));
+t('RESTART_SHAPES is the runner-reachable pair, and the set is a subset of HOSTING_SHAPES', () => {
+  assert.deepEqual([...provisioning.RESTART_SHAPES].sort(), ['cloud-host', 'co-tenant']);
   for (const s of provisioning.RESTART_SHAPES) assert.ok(provisioning.HOSTING_SHAPES.includes(s), `${s} is a real shape`);
+  // Was `!has('dedicated')`. Task 1004182 removed that value from HOSTING_SHAPES, which made
+  // the assertion vacuously true — it would now pass against any set at all. Name the shapes
+  // that still EXIST and are still unreachable, and assert they are real first, so this
+  // cannot rot the same way twice.
+  for (const unreachable of ['byo-host', 'control-plane']) {
+    assert.ok(provisioning.HOSTING_SHAPES.includes(unreachable), `${unreachable} must be a real shape or this assertion is vacuous`);
+    assert.ok(!provisioning.RESTART_SHAPES.has(unreachable), unreachable);
+  }
 });
 
 await ta('enqueueRestart: a free slot creates the intent', async () => {
@@ -190,7 +197,7 @@ function post(path) {
   });
 }
 
-const ACTIVE = { owner_builder_id: 7, slug: 'spike', status: 'active', hosting_shape: 'standalone', domain: 'spike.cloudbongos.com', settings: {} };
+const ACTIVE = { owner_builder_id: 7, slug: 'spike', status: 'active', hosting_shape: 'cloud-host', domain: 'spike.cloudbongos.com', settings: {} };
 function reset(patch = {}) {
   instance = { ...ACTIVE, ...patch };
   enqueueCalls = []; enqueueResult = null; events = [];

package/tests/provisioning_settings_apply.mjs

@@ -72,10 +72,17 @@ t('SETTINGS_APPLY_FROM is exactly {active} — the provision intent cannot stand
   assert.ok(!provisioning.PROVISION_ENQUEUE_FROM.has('active'), 'the premise the gate rests on');
 });
 
-t('SETTINGS_APPLY_SHAPES is the reachable pair — dedicated is out, and the set is a subset of HOSTING_SHAPES', () => {
-  assert.deepEqual([...provisioning.SETTINGS_APPLY_SHAPES].sort(), ['co-tenant', 'standalone']);
+t('SETTINGS_APPLY_SHAPES is the reachable pair, and the set is a subset of HOSTING_SHAPES', () => {
+  assert.deepEqual([...provisioning.SETTINGS_APPLY_SHAPES].sort(), ['cloud-host', 'co-tenant']);
   for (const s of provisioning.SETTINGS_APPLY_SHAPES) assert.ok(provisioning.HOSTING_SHAPES.includes(s), s);
-  assert.ok(!provisioning.SETTINGS_APPLY_SHAPES.has('dedicated'));
+  // The exclusion this used to assert was 'dedicated', which task 1004182 removed from
+  // HOSTING_SHAPES entirely — so that assertion became vacuously true and stopped testing
+  // anything. Name the shapes that DO exist and are still deliberately unreachable: nothing
+  // of ours runs a byo-host, and the control plane is not pushed settings by this path.
+  for (const unreachable of ['byo-host', 'control-plane']) {
+    assert.ok(provisioning.HOSTING_SHAPES.includes(unreachable), `${unreachable} must be a real shape or this assertion is vacuous`);
+    assert.ok(!provisioning.SETTINGS_APPLY_SHAPES.has(unreachable), unreachable);
+  }
 });
 
 await ta('enqueueSettingsApply: a fresh intent → created:true; the INSERT carries the settings-apply action', async () => {
@@ -208,7 +215,7 @@ function patch(path, body) {
   });
 }
 
-const ACTIVE = { owner_builder_id: 7, slug: 'spike', status: 'active', hosting_shape: 'standalone', domain: 'spike.cloudbongos.com', settings: {} };
+const ACTIVE = { owner_builder_id: 7, slug: 'spike', status: 'active', hosting_shape: 'cloud-host', domain: 'spike.cloudbongos.com', settings: {} };
 function reset({ inst, as } = {}) {
   instance = inst !== undefined ? inst : { ...ACTIVE };
   builder = as || { id: 7, github_login: 'owner', rank: 'thetes' };
@@ -230,7 +237,7 @@ function receiptShape(push, { queued, restart, reachable }) {
 
 console.log('\nPATCH /provisioning/instances/:id/settings — the enqueue:');
 
-await ta('ACTIVE standalone: the row is written FIRST, then a settings-apply intent queues; the receipt says a restart is coming', async () => {
+await ta('ACTIVE cloud-host: the row is written FIRST, then a settings-apply intent queues; the receipt says a restart is coming', async () => {
   reset();
   const r = await patch('/provisioning/instances/18/settings', { platform_visibility: 'gated' });
   assert.equal(r.status, 200, r.raw);

package/tests/provisioning_settings_env.mjs

@@ -168,7 +168,7 @@ t('the runner writes them into web.env alongside PORT and PGDATABASE', () => {
   const provision = require('../scripts/gds/provision.js');
   const body = provision.webEnvBody(
     { slug: 'spike-harbor', port: 3010, db_name: 'spike-harbor', target_ref: 'jaxri/spike-harbor',
-      hosting_shape: 'standalone', settings: { platform_visibility: 'gated' } }, {});
+      hosting_shape: 'cloud-host', settings: { platform_visibility: 'gated' } }, {});
   assert.match(body, /_PLATFORM_VISIBILITY=gated/);
   assert.match(body, /_JOINABILITY=apply/);
   assert.match(body, /PORT=3010/, 'the rest of the file is untouched');

package/tests/provisioning_teardown_intent.mjs

@@ -250,7 +250,7 @@ console.log('\nPOST /provisioning/instances — no provision intent for an insta
 await ta('re-requesting an ACTIVE instance does NOT enqueue a provision intent (the enabling misstep, fixed)', async () => {
   createResult = { instance: { id: 42, owner_builder_id: 7, slug: 'spike', status: 'active' }, created: false };
   enqueueIntentCalls = [];
-  const res = await post('/provisioning/instances', { slug: 'spike', hosting_shape: 'standalone' });
+  const res = await post('/provisioning/instances', { slug: 'spike', hosting_shape: 'cloud-host' });
   assert.equal(res.status, 200, res.raw);
   assert.equal(enqueueIntentCalls.length, 0, 'no provision intent was enqueued');
   assert.equal(res.body.queued, false);
@@ -260,7 +260,7 @@ await ta('re-requesting an ACTIVE instance does NOT enqueue a provision intent (
 await ta('re-requesting an ERRORED instance still enqueues (the retry path is preserved)', async () => {
   createResult = { instance: { id: 42, owner_builder_id: 7, slug: 'spike', status: 'error' }, created: false };
   enqueueIntentCalls = [];
-  const res = await post('/provisioning/instances', { slug: 'spike', hosting_shape: 'standalone' });
+  const res = await post('/provisioning/instances', { slug: 'spike', hosting_shape: 'cloud-host' });
   assert.equal(res.status, 200, res.raw);
   assert.equal(enqueueIntentCalls.length, 1, 'the provision retry was enqueued');
   assert.equal(enqueueIntentCalls[0].action, 'provision');
@@ -269,7 +269,7 @@ await ta('re-requesting an ERRORED instance still enqueues (the retry path is pr
 await ta('a FRESH instance always enqueues its provision intent (unchanged happy path)', async () => {
   createResult = { instance: { id: 43, owner_builder_id: 7, slug: 'fresh', status: 'requested' }, created: true };
   enqueueIntentCalls = [];
-  const res = await post('/provisioning/instances', { slug: 'fresh', hosting_shape: 'standalone' });
+  const res = await post('/provisioning/instances', { slug: 'fresh', hosting_shape: 'cloud-host' });
   assert.equal(res.status, 201, res.raw);
   assert.equal(enqueueIntentCalls.length, 1);
   assert.equal(enqueueIntentCalls[0].action, 'provision');

package/tests/public_landing_projects.mjs

@@ -193,14 +193,21 @@ test('the manual-repo step states placement and visibility — the owner never h
   assert.match(body, /public or private/i, 'visibility must be stated in our copy, not first seen on GitHub');
 });
 
-test('teardown copy states what the runner actually does, per hosting shape (F17)', async () => {
+test('teardown copy states what the runner actually does (F17)', async () => {
   const { body } = await request('/projects', 'game.test.local');
-  // the DECIDED policy: shared shapes keep the database; a dedicated machine
-  // takes its database with it — the copy branches on the shape field
-  assert.match(body, /The database is kept/, 'the kept-shape promise is present');
-  assert.match(body, /database goes with (it|the machine)/, 'the dedicated branch exists');
-  assert.match(body, /hosting_shape === 'dedicated'/, 'shape-driven, not flat prose');
+  // The DECIDED policy is unchanged — teardown keeps the database — but it is no longer a
+  // PER-SHAPE claim. This used to branch: every shared shape kept the database while a
+  // 'dedicated' machine took its database with it. ADR 0327 decision 4 removed that shape
+  // and task 1004182 folded its rows into 'cloud-host', so the branch could never be taken
+  // again and the page now states the surviving outcome flatly.
+  //
+  // The important part is the NEGATIVE: the copy must no longer offer the other outcome at
+  // all. A conditional that can't fire is not merely dead here — it is a promise to owners
+  // about a machine none of them have.
+  assert.match(body, /The database is kept/, 'the kept promise is present');
   assert.match(body, /repository is untouched|repository stays yours|repository is still yours/i);
+  assert.doesNotMatch(body, /database goes with (it|the machine)/, 'the removed shape\'s copy is gone with it');
+  assert.doesNotMatch(body, /hosting_shape === 'dedicated'/, 'and so is the branch that selected it');
   // the pre-walk over-claim can never come back
   assert.doesNotMatch(body, /server and database go away/i);
   assert.doesNotMatch(body, /database (is|will be) (deleted|dropped|destroyed|removed)/i);

package/tests/upgrade.mjs

@@ -1621,7 +1621,7 @@ t('pinnedDeployKey / remoteGithubRepo: read the ADR 0176 wiring off the checkout
 });
 
 t('resolvePinPushAuth: the owner token is spent only when one is stored AND the provisioning row names the remote repo', async () => {
-  const inst = { slug: 'acme', owner_builder_id: 7, target_ref: 'acme/widgets', hosting_shape: 'standalone' };
+  const inst = { slug: 'acme', owner_builder_id: 7, target_ref: 'acme/widgets', hosting_shape: 'cloud-host' };
   const at = (url) => pinRun({ remote: { status: 0, stdout: `${url}\n` } });
   const dir = { instanceDir: '/srv/bongos/acme' };
 
@@ -1683,7 +1683,7 @@ t('runUpgrade --commit-pin: on a wired private instance the pin lands via the ow
       materialize: () => ({ skills: 35, settings: true, hooks: 3 }),
       regenerateApiArtifacts: () => ({ ok: true, ran: ['gen-api-docs.js', 'gen-api-client.js'] }),
       databaseUrl: '', pgDatabase: '',
-      instance: { slug: 'acme', owner_builder_id: 7, target_ref: 'acme/widgets', hosting_shape: 'standalone' },
+      instance: { slug: 'acme', owner_builder_id: 7, target_ref: 'acme/widgets', hosting_shape: 'cloud-host' },
       getGithubToken: async () => ({ token, scope: 'read:user,repo' }),
     },
   );