@bongos/core 1.19.970 → 1.19.971

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.970",
-  "core_contract": "1.19.970",
-  "source_commit": "6fcd89630051b6a8a27ab995131716370ed9082e",
+  "core_version": "1.19.971",
+  "core_contract": "1.19.971",
+  "source_commit": "64be47e290d62d4a4397189fe7c91e056e557c92",
   "source_ref": "HEAD",
-  "built_at": "2026-09-23T01:02:05.515Z",
+  "built_at": "2026-09-23T01:18:55.107Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 515,
     "agent_docs_stubbed": 26,
-    "functional_verbatim": 2370,
+    "functional_verbatim": 2371,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2911,
-  "tree_sha256": "60a4632de03ed24bd98cbfe694a93acfed70e02c72838da91213a9c68ad14813",
+  "file_count": 2912,
+  "tree_sha256": "eb2fb77b0138a60460479f83e4a369b7f2c8101b489e124e33596a81711ddffd",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2697,7 +2697,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "e842c06ae274c61f5f38063af7b5eb5da4798954df2b9e3e42c1929352dd9a3f"
+      "sha256": "f4d8da00ac6a0416fc0b38be5186cfa841ba18d8afccfd53b8c6055d56ad0f88"
     },
     {
       "path": "docs/modules-contract.md",
@@ -4047,7 +4047,7 @@
     {
       "path": "modules/copy-desk/proposals.js",
       "mode": "0000644",
-      "sha256": "de674674cf2f80fb36569cad67be4f1ba3a94e938b690b8f1d0c96446df346bf"
+      "sha256": "c9a99cbda84386baa0da149a72ac0763b335bda34f1d08f52ba9656e25cb319b"
     },
     {
       "path": "modules/copy-desk/registry.js",
@@ -8107,12 +8107,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "b398350d28d5e528b46daafbadd4b19ddd9e9423a0c234aaabd27dc1718d6864"
+      "sha256": "7b458e15cda96ebf05079d2bb4fe7af847fc64e401a2d8f9584831cfb591cd64"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "03e808eb0d1d2cb9be5d0ee13830a79fd5b0752ee5ff7f0a17993df3dc147903"
+      "sha256": "211d62a555349042e0d897f9f6a795a7fb45abac88dd2584231ecf042d6b0051"
     },
     {
       "path": "public-docs/index.html",
@@ -8447,7 +8447,7 @@
     {
       "path": "scripts/gds/claim.js",
       "mode": "0000644",
-      "sha256": "a02e76a5f817501745c843c1df25fdd9584e91eb3d97fe76976fd508b70f72d9"
+      "sha256": "942581a081da9134cb7038c61b646ddba6e25f2de15411fe59378a477ac05637"
     },
     {
       "path": "scripts/gds/classify-discipline.js",
@@ -8697,7 +8697,7 @@
     {
       "path": "scripts/gds/fitness.js",
       "mode": "0000644",
-      "sha256": "35e377253453c975ce7a8e420d72af718a4f8ab6d3837d39fd38c1ebd5658ddc"
+      "sha256": "c84fbcc5d9c2676c90756a9cce02987c9dd30b68d17bee01698d6a7bc5cf9c7c"
     },
     {
       "path": "scripts/gds/gate-review.js",
@@ -9037,7 +9037,7 @@
     {
       "path": "scripts/gds/probe-cache.js",
       "mode": "0000644",
-      "sha256": "34d891e8ff58f0da957d300021210dbc34448fe676873b6b77e13ad3b7179d2e"
+      "sha256": "6860b900c3b60e4e15108d3033a808312b090f0b21b2dcf4021d39cff1af3f50"
     },
     {
       "path": "scripts/gds/prove-strict-versioning.js",
@@ -10122,7 +10122,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "a16e899a5c50b65af3e0976a27e72e2f1e50b7cfc8a8acafc64b19cebae1eb93"
+      "sha256": "ef138765707d6d54a7992d02ad0b3e21673b90c47e2ea6a3384f95ee6e90a00a"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -11022,7 +11022,7 @@
     {
       "path": "tests/copy_inventory.mjs",
       "mode": "0000644",
-      "sha256": "e621021bdab92a17c9f0f0760ced4c2f2c955ef3df91fb584a7a398c46a717aa"
+      "sha256": "bdfb3c305a60f3767484e86b1ec41295abad9142db1b51ff6bf49855c882f286"
     },
     {
       "path": "tests/core_update_banner.mjs",
@@ -11419,6 +11419,11 @@
       "mode": "0000644",
       "sha256": "230e532b54a69a3ee2c009b3a018a6cb920c92fb402364427cbdc244434d4c1b"
     },
+    {
+      "path": "tests/fitness_no_raw_nul.mjs",
+      "mode": "0000644",
+      "sha256": "30ad1bacf0f695bfcf50c65f86780581a9215e70183792e3130860bb1bef73dd"
+    },
     {
       "path": "tests/fitness_ratchets.mjs",
       "mode": "0000644",

package/docs/module-api-changelog.md

@@ -2414,5 +2414,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.968 with no explicit bump. run 35798488315. (task 1002620)
   1.19.970 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.969 with no explicit bump. run 35804568036. (task 1002620)
+  1.19.971 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.970 with no explicit bump. run 35805746484. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/copy-desk/proposals.js

@@ -255,7 +255,7 @@ function proposalTaskBody(patch) {
 // right: two people can disagree about the fix, and the board should hold both.
 function proposalSourceRef(patch) {
   let hash = 5381;
-  const material = `${patch.string_id}${patch.file}${patch.line}${patch.proposed}`;
+  const material = `${patch.string_id}\u0000${patch.file}\u0000${patch.line}\u0000${patch.proposed}`;
   for (let i = 0; i < material.length; i += 1) hash = (((hash << 5) + hash) ^ material.charCodeAt(i)) >>> 0;
   return `copy-proposal-${patch.string_id}-${hash.toString(36)}`;
 }

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.970",
+  "version": "1.19.971",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.970",
+      "version": "1.19.971",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.970",
+  "version": "1.19.971",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/claim.js

@@ -310,7 +310,7 @@ const MAX_LISTED_TASKS = 20;
 function clip(s, max = 160) {
   if (s == null) return '';
   // eslint-disable-next-line no-control-regex
-  const flat = String(s).replace(/[--Ÿ]+/g, ' ').trim();
+  const flat = String(s).replace(/[\u0000--Ÿ]+/g, ' ').trim();
   return flat.length > max ? `${flat.slice(0, max - 1)}…` : flat;
 }
 

package/scripts/gds/fitness.js

@@ -1204,8 +1204,94 @@ function checkSkillFrontmatter() {
   };
 }
 
+// ============================================================================
+// Check 35 — no raw NUL byte in tracked publishable text (task 1002854)
+// ============================================================================
+//
+// scripts/public-mirror-export.js decides binary-vs-text by sniffing for a NUL byte in
+// the first 8 KiB (`isBinary`, ~line 86), and `redactBlob` skips `redactText` entirely
+// for anything it classifies binary. So a TEXT source containing a raw NUL is published
+// to the public AGPL mirror WITHOUT REDACTION.
+//
+// WHAT THIS IS AND IS NOT. The binary branch is not unguarded: it still leak-scans the
+// blob's latin1 view, so an embedded instance literal trips the gate. But the gate uses
+// `sensitiveLiterals` — raw substrings — while `redactText` applies the full `rules` set.
+// The exposure is therefore the DELTA between them: anything redaction would have
+// rewritten but the literal gate does not recognise ships verbatim. That is a latent
+// unredacted-publish, not a live one, which is why this is a lint rather than a fix.
+//
+// THE CLASS RECURS, WHICH IS THE ARGUMENT FOR A LINT RATHER THAN ANOTHER FIX.
+// Task 1703 found and fixed three instances, all the same mistake: a raw NUL used as a
+// join delimiter instead of the `\u0000` escape. Task 1002507 fixed a fourth in session
+// digests. Open idea 1000523 covers a fifth (search-ingest rollback). This check found
+// four more — modules/copy-desk/proposals.js, scripts/gds/claim.js,
+// scripts/gds/probe-cache.js and tests/copy_inventory.mjs — fixed in the same commit so
+// the check lands green. Nothing prevented any of them; nothing would prevent the next.
+//
+// The fix is always the same and never changes behaviour: `\u0000` compiles to exactly
+// the same string, so hashes, joins and regex ranges are byte-identical at runtime. Only
+// the SOURCE stops carrying the byte.
+//
+// SCOPE. Tracked files only (git ls-files — an untracked scratch file is not published),
+// with publishable text extensions. Binary formats are out of scope by definition: a PNG
+// is *supposed* to contain NULs and the mirror is right to pass it through.
+const NUL_TEXT_EXTS = ['.js', '.mjs', '.cjs', '.mts', '.md', '.sql', '.json'];
+
+// Exemptions must be justified, not just listed. There are none today, and that is the
+// preferred state: the fix is a one-character escape with no behavioural cost, so
+// "exempt it" should always lose to "escape it". Kept as a named, empty constant so a
+// future addition is a visible, reviewable edit rather than a quiet change to a regex.
+const NUL_EXEMPT_PATHS = [];
+
+function scanForRawNul(root, { listFiles, readFile } = {}) {
+  const list = listFiles || (() => execFileSync('git', ['ls-files', '-z'], {
+    cwd: root, encoding: 'latin1', maxBuffer: 1 << 26,
+  }).split('\u0000').filter(Boolean));
+  const read = readFile || ((f) => fs.readFileSync(path.join(root, f)));
+
+  const hits = [];
+  for (const f of list()) {
+    if (!NUL_TEXT_EXTS.includes(path.extname(f))) continue;
+    if (NUL_EXEMPT_PATHS.some((e) => f === e || f.startsWith(e))) continue;
+    let buf;
+    try { buf = read(f); } catch (_) { continue; }   // deleted-but-tracked, or unreadable
+    const at = buf.indexOf(0);
+    if (at === -1) continue;
+    // Report the LINE, not the byte offset — a byte offset is not actionable.
+    const line = buf.slice(0, at).toString('latin1').split('\n').length;
+    hits.push(`${f}:${line} — raw NUL byte; use the \\u0000 escape (same string at runtime, no NUL in source)`);
+  }
+  return hits;
+}
+
+function checkNoRawNulInText() {
+  let violations = [];
+  let note = '';
+  try {
+    violations = scanForRawNul(REPO_ROOT);
+    note = `tracked ${NUL_TEXT_EXTS.join('/')} sources carry no raw NUL byte, so none can be misclassified `
+      + 'as binary and skip public-mirror redaction (task 1002854).';
+  } catch (e) {
+    // Never let the scan itself fail the build — a git failure is not a boundary breach.
+    return {
+      name: 'no raw NUL byte in tracked publishable text (task 1002854)',
+      ok: true, hardFail: false, violations: [], warnings: [`skipped: ${e.message}`],
+      note: 'could not list tracked files — check skipped.',
+    };
+  }
+  return {
+    name: 'no raw NUL byte in tracked publishable text (task 1002854)',
+    ok: violations.length === 0,
+    hardFail: violations.length > 0,
+    violations,
+    warnings: [],
+    note,
+  };
+}
+
 const CHECKS = [
   checkCoreHostBoundary,
+  checkNoRawNulInText, // Check 35 — task 1002854: a raw NUL makes the mirror skip redaction
   checkClaudeMdBudget,
   // Check 32 — task 1002990 / criterion wa6-kernel-and-packs: the root CLAUDE.md is
   // now a role-neutral KERNEL and each craft's playbook lives in a pack under
@@ -1307,6 +1393,7 @@ function main() {
 if (require.main === module) main();
 
 module.exports = {
+  scanForRawNul,
   checkVocabularyWall, VOCAB_ALLOW, VOCAB_CITATION, VOCAB_EXTS, vocabFilesToScan,
   checkGoalMembershipVocabulary, GOAL_VOCAB_SURFACE, checkGovernmentRenameIdentity, RENAME_IDENTITY_RE, checkPrelaunchVocabulary, PRELAUNCH_SURFACE, // 19c task 1003120, 19d task 1003152
   runAll,

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.970'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.971'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/fitness_no_raw_nul.mjs

@@ -0,0 +1,113 @@
+// tests/fitness_no_raw_nul.mjs
+//
+// Task 1002854 — scripts/public-mirror-export.js sniffs for a NUL byte in the first
+// 8 KiB to decide binary-vs-text (`isBinary`), and `redactBlob` skips `redactText`
+// entirely for anything it classifies binary. So a TEXT source containing a raw NUL is
+// published to the public AGPL mirror WITHOUT redaction.
+//
+// The binary branch is not unguarded — it still leak-scans the latin1 view — but that
+// gate uses `sensitiveLiterals` (raw substrings) while redaction applies the full
+// `rules` set. The exposure is the DELTA: anything redaction would rewrite that the
+// literal gate does not recognise ships verbatim. Latent, not live — hence a lint.
+//
+// THE CLASS RECURS, which is why this is a lint and not a fifth point fix. Task 1703
+// fixed three instances, task 1002507 a fourth, idea 1000523 covers a fifth, and this
+// task found four more. Every one was the same mistake: a raw NUL used as a join
+// delimiter instead of the \u0000 escape.
+//
+// These tests drive the PURE scanner over INJECTED FIXTURES rather than over the real
+// tree. A test that only asserts "the repo is clean today" passes vacuously the moment
+// the scanner breaks — it would report success on a scanner that always returns [].
+//
+// Run:  node --test tests/fitness_no_raw_nul.mjs
+
+import { strict as assert } from 'node:assert';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const REPO_ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const { scanForRawNul } = require(path.join(REPO_ROOT, 'scripts/gds/fitness.js'));
+
+// Built at runtime so THIS file never carries the byte it is about — otherwise the
+// check's own test would be its first violation.
+const NUL = String.fromCharCode(0);
+
+// A fake tree: { 'path' => 'contents' }, injected through the scanner's seams so no
+// temp files are needed and every fixture is visible in the test.
+function fakeTree(files) {
+  return {
+    listFiles: () => Object.keys(files),
+    readFile: (f) => Buffer.from(files[f], 'utf8'),
+  };
+}
+
+test('THE BUG: a raw NUL in a .js source is caught', () => {
+  const hits = scanForRawNul('/fake', fakeTree({
+    'src/join.js': `const k = a + '${NUL}' + b;\n`,
+  }));
+  assert.equal(hits.length, 1, 'a raw NUL in tracked JS must be a violation');
+  assert.match(hits[0], /src\/join\.js:1/, 'must name the file and LINE — a byte offset is not actionable');
+  assert.match(hits[0], /u0000/, 'and must name the fix');
+});
+
+test('THE FIX: the escape form is NOT caught — it leaves no NUL in the source', () => {
+  // The whole premise of the remedy: the escape compiles to the same string at runtime,
+  // and only the source stops carrying the byte. If the check flagged the escape too,
+  // the violation would be unfixable.
+  const hits = scanForRawNul('/fake', fakeTree({
+    'src/join.js': "const k = a + '\\u0000' + b;",
+  }));
+  assert.deepEqual(hits, [], 'the escape is the prescribed fix and must pass');
+});
+
+test('the reported line is the line the NUL is on, not the first line', () => {
+  const hits = scanForRawNul('/fake', fakeTree({
+    'a.js': `line one\nline two\nconst k = '${NUL}';\n`,
+  }));
+  assert.match(hits[0], /a\.js:3/);
+});
+
+test('binary extensions are out of scope — a PNG is SUPPOSED to contain NULs', () => {
+  const hits = scanForRawNul('/fake', fakeTree({
+    'public/logo.png': `PNG${NUL}${NUL}`,
+    'docs/diagram.svg': `<svg>${NUL}</svg>`,
+  }));
+  assert.deepEqual(hits, [],
+    'the mirror is right to pass binaries through verbatim; only TEXT sources are the hole');
+});
+
+test('every publishable text extension is scanned', () => {
+  const files = {};
+  for (const ext of ['.js', '.mjs', '.cjs', '.mts', '.md', '.sql', '.json']) files[`f${ext}`] = `x${NUL}y`;
+  assert.equal(scanForRawNul('/fake', fakeTree(files)).length, 7,
+    'a gap in the extension list is a gap in the guard');
+});
+
+test('an unreadable or deleted-but-tracked file is skipped, not a crash', () => {
+  const hits = scanForRawNul('/fake', {
+    listFiles: () => ['gone.js', 'here.js'],
+    readFile: (f) => {
+      if (f === 'gone.js') throw Object.assign(new Error('ENOENT'), { code: 'ENOENT' });
+      return Buffer.from(`ok${NUL}`, 'utf8');
+    },
+  });
+  assert.equal(hits.length, 1, 'the readable file is still checked');
+  assert.match(hits[0], /here\.js/);
+});
+
+test('a clean tree reports nothing', () => {
+  assert.deepEqual(scanForRawNul('/fake', fakeTree({
+    'a.js': 'const k = a + b;',
+    'b.md': '# heading',
+  })), []);
+});
+
+test('the REAL tree is clean (the check must land green)', () => {
+  // Deliberately last, and deliberately paired with the fixtures above: on its own this
+  // assertion would pass against a scanner that always returns [].
+  assert.deepEqual(scanForRawNul(REPO_ROOT), [],
+    'a raw NUL landed in a tracked text source — escape it (identical string at runtime)');
+});