@bongos/core 1.19.943 → 1.19.944

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.943",
-  "core_contract": "1.19.943",
-  "source_commit": "d2864572d1b1f1112a574071d4fe288920a71216",
+  "core_version": "1.19.944",
+  "core_contract": "1.19.944",
+  "source_commit": "9bb024296de8bc08497922c176fac32f1cbd4072",
   "source_ref": "HEAD",
-  "built_at": "2026-09-21T22:14:04.050Z",
+  "built_at": "2026-09-21T22:56:15.068Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 511,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 2877,
-  "tree_sha256": "475596e7ac9620819058973e021b0c26d5122429253e9206320f31130a67c709",
+  "tree_sha256": "0ba58d1da09b858f4ba434ece27993e6d514cbb7622e15d3987343c832c6710e",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2677,7 +2677,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "441e7d11f2b340623b122c51c788d0ff1d0610ff1c4296db3344c8702c8fb541"
+      "sha256": "fd85af374ab5c378414a246c9575a5254fb720e1c9ba0792093c96ebdd07b1f7"
     },
     {
       "path": "docs/modules-contract.md",
@@ -8002,12 +8002,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "2ff2f30a70ad8facea46291fa01e89889194edb8fa02e904bda7b8343754bbfd"
+      "sha256": "915c0d9eda15ebe2198dff6cbc476e11b5ef5c286b3bcd5cb47aed9f7eba3599"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "35b084d56b257e0df6c6a738d94c305a6aa8419471c7b9fe32f41afef640f5fd"
+      "sha256": "9174d7da67f1bce8d88d2e2ef0da7c656910d53c955040d3a9f74e8b0dede5f6"
     },
     {
       "path": "public-docs/index.html",
@@ -8097,7 +8097,7 @@
     {
       "path": "scripts/gds/agents-sync.js",
       "mode": "0000644",
-      "sha256": "7a639c73f8d2f4f523899ab737641174ca7b5ed5409427238d7fc397cdba65ed"
+      "sha256": "29f3d1521c04165a891a8055f005cb51ca019c51c556063e55167675051a43af"
     },
     {
       "path": "scripts/gds/api-alias-caller-scan.js",
@@ -9617,7 +9617,7 @@
     {
       "path": "scripts/migrate.sh",
       "mode": "0000644",
-      "sha256": "3a35826ec753908fb9aec9c5a4b5c37e71e38ba0d00c1d1f30387087be509d97"
+      "sha256": "1ba289b008ef4118cfd464ab5eb24ad4b694981942680220f115913691645e08"
     },
     {
       "path": "scripts/migrate_cost_ledger.sh",
@@ -10012,7 +10012,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "cd5bcc86c8d6ecb21b11c6dd9df73de2b63e0759edf781eeee2e6d36f6452aad"
+      "sha256": "ff95cfa479f2e1c5d4b9598d832a43743122b621338de3f5e902289d00e379d8"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -10187,7 +10187,7 @@
     {
       "path": "tests/agents_sync.mjs",
       "mode": "0000644",
-      "sha256": "1184d82ba51d3dd3f2bf952292b71defd4b6ea51fba5e3800429cfed1450fe31"
+      "sha256": "daa2d58b9a248222a54305c3fa41d30e73c8ea8cd65db8a14e31d30dfe0ca555"
     },
     {
       "path": "tests/agents_validate.mjs",

package/docs/module-api-changelog.md

@@ -2360,5 +2360,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.941 with no explicit bump. run 35659043986. (task 1002620)
   1.19.943 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.942 with no explicit bump. run 35661533404. (task 1002620)
+  1.19.944 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.943 with no explicit bump. run 35665131778. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.943",
+  "version": "1.19.944",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.943",
+      "version": "1.19.944",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.943",
+  "version": "1.19.944",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/agents-sync.js

@@ -317,6 +317,14 @@ function planSync(files, { existingByName = new Map(), authorRankFor = () => nul
 
 // ---- disk + git ------------------------------------------------------------
 
+// The repo a definitions dir belongs to, by the `<root>/.claude/agents` layout.
+// Not REPO_ROOT: a split-root instance runs this script from the core package
+// while its definitions live in the instance repo (task 1004139), so paths and
+// git history must be read against the definitions' repo, not the core's.
+function definitionsRoot(dir) {
+  return path.resolve(dir, '..', '..');
+}
+
 // An ABSENT directory is a legitimate state, not an error: `.claude/agents/`
 // does not exist in the core tree at all today, and an instance that ships no
 // agents must deploy cleanly. Zero files, exit 0, nothing written.
@@ -328,10 +336,11 @@ function readAgentFiles(dir = DEFAULT_DIR) {
     if (err.code === 'ENOENT') return [];
     throw err;
   }
+  const root = definitionsRoot(dir);
   return names.sort().map((f) => {
     const full = path.join(dir, f);
     return {
-      file: path.relative(REPO_ROOT, full).split(path.sep).join('/'),
+      file: path.relative(root, full).split(path.sep).join('/'),
       candidate: parseAgentFile(fs.readFileSync(full, 'utf8'), { name: f.replace(/\.md$/, '') }),
     };
   });
@@ -350,9 +359,9 @@ function readAgentFiles(dir = DEFAULT_DIR) {
 //
 // It is kept because provenance is genuinely useful where nothing is riding on
 // it. The wall is that it is never consulted where it could grant anything.
-function lastCommitterLogin(file, { runGit = defaultRunGit } = {}) {
+function lastCommitterLogin(file, { runGit = defaultRunGit, cwd = REPO_ROOT } = {}) {
   let out;
-  try { out = runGit(['log', '-1', '--format=%ae%n%an', '--', file]); }
+  try { out = runGit(['log', '-1', '--format=%ae%n%an', '--', file], cwd); }
   catch { return null; }
   const [email = '', authorName = ''] = String(out || '').split(/\r?\n/);
   const noreply = /^(?:\d+\+)?([A-Za-z0-9-]+)@users\.noreply\.github\.com$/.exec(email.trim());
@@ -360,8 +369,8 @@ function lastCommitterLogin(file, { runGit = defaultRunGit } = {}) {
   return authorName.trim() || null;
 }
 
-function defaultRunGit(args) {
-  return execFileSync('git', args, { cwd: REPO_ROOT, encoding: 'utf8' });
+function defaultRunGit(args, cwd = REPO_ROOT) {
+  return execFileSync('git', args, { cwd, encoding: 'utf8' });
 }
 
 module.exports = {
@@ -386,11 +395,12 @@ async function main() {
   const asJson = argv.includes('--json');
   const dirIdx = argv.indexOf('--dir');
   const dir = dirIdx >= 0 ? argv[dirIdx + 1] : DEFAULT_DIR;
+  const root = definitionsRoot(dir);
 
   const files = readAgentFiles(dir);
   if (files.length === 0) {
     if (asJson) console.log(JSON.stringify({ ok: true, scanned: 0, plan: [] }));
-    else console.log(`agents-sync: no definitions under ${path.relative(REPO_ROOT, dir) || dir} — nothing to reconcile.`);
+    else console.log(`agents-sync: no definitions under ${path.relative(root, dir) || dir} — nothing to reconcile.`);
     return 0;
   }
 
@@ -413,7 +423,7 @@ async function main() {
   // ONE git subprocess per file, memoised — `authorRankFor` is called again from
   // planSync, and re-shelling out there doubled the blocking spawns for an answer
   // that cannot have changed mid-run.
-  const loginByFile = new Map(files.map((f) => [f.file, lastCommitterLogin(f.file)]));
+  const loginByFile = new Map(files.map((f) => [f.file, lastCommitterLogin(f.file, { cwd: root })]));
   // One query for every distinct committer, not one per file.
   const logins = [...new Set([...loginByFile.values()].filter(Boolean))];
   const rankByLogin = new Map();

package/scripts/migrate.sh

@@ -411,14 +411,16 @@ fi
 # Gated on the module set the module loop just migrated (DB overrides included,
 # task 1004138). A fresh isModuleEnabled() read never loaded the overrides, so an
 # `agents` switched on in the hall got its tables but never its registry. Pinned to
-# $DB like that read, so the reconcile writes into the schema this run applied. The
-# file check keeps an instance without the script as silent as the old cwd-relative
-# require left it: a split-root instance (core in node_modules) still does not
-# reconcile, because which .claude/agents it should read is an open design question.
-if [[ " $NODE_ENABLED_MODULES " == *" agents "* ]] && [ -f scripts/gds/agents-sync.js ]; then
+# $DB like that read, so the reconcile writes into the schema this run applied.
+#
+# The script is the core's, the definitions are the instance's own (task 1004139, an
+# owner decision): a split-root instance (core in node_modules) reconciles ITS
+# .claude/agents, never the core package's shipped set and no merge of the two.
+# Single-root, CORE_ROOT == INSTANCE_ROOT and this is the same call as before.
+if [[ " $NODE_ENABLED_MODULES " == *" agents "* ]]; then
   echo
   echo "post-deploy: reconciling .claude/agents/ into the agent registry"
-  if ! DATABASE_URL='' PGDATABASE="$DB" node scripts/gds/agents-sync.js; then
+  if ! DATABASE_URL='' PGDATABASE="$DB" node "$CORE_ROOT/scripts/gds/agents-sync.js" --dir "$INSTANCE_ROOT/.claude/agents"; then
     echo "post-deploy: agents-sync failed — the registry is stale by one deploy, not broken" >&2
   fi
 fi

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.943'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.944'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/agents_sync.mjs

@@ -24,6 +24,7 @@
 // Run:  node tests/agents_sync.mjs
 
 import { strict as assert } from 'node:assert';
+import { execFileSync } from 'node:child_process';
 import { createRequire } from 'node:module';
 import fs from 'node:fs';
 import os from 'node:os';
@@ -279,6 +280,32 @@ t('a real directory is read, .md only, sorted', () => {
   assert.deepEqual(files.map((f) => f.candidate.name), ['alpha', 'historian'], 'sorted, so a run is reproducible');
 });
 
+console.log('\na split-root instance reconciles its OWN definitions (task 1004139):');
+
+t('definitions outside the core read against their own repo, not the core', () => {
+  // The core runs from node_modules while .claude/agents lives in the instance repo.
+  // Read against the core, source_path came out as ../../../.claude/agents/x.md and the
+  // git author lookup ran in the wrong repo.
+  const root = fs.mkdtempSync(path.join(os.tmpdir(), 'agents-sync-instance-'));
+  const dir = path.join(root, '.claude', 'agents');
+  fs.mkdirSync(dir, { recursive: true });
+  fs.writeFileSync(path.join(dir, 'scout.md'), FILE.replace('name: historian', 'name: scout'));
+  const git = (...args) => execFileSync('git', args, { cwd: root, stdio: 'ignore' });
+  try {
+    git('init', '-q');
+    git('add', '.');
+    git('-c', 'user.email=12345+octocat@users.noreply.github.com', '-c', 'user.name=Someone',
+      '-c', 'commit.gpgsign=false', 'commit', '-q', '--no-verify', '-m', 'add scout');
+
+    const [f] = sync.readAgentFiles(dir);
+    assert.equal(f.file, '.claude/agents/scout.md', 'source_path is relative to the instance root');
+    assert.equal(sync.lastCommitterLogin(f.file, { cwd: root }), 'octocat', 'history is read from the instance repo');
+    assert.equal(sync.lastCommitterLogin(f.file), null, 'the core repo has no history for an instance file');
+  } finally {
+    fs.rmSync(root, { recursive: true, force: true });
+  }
+});
+
 console.log('\nplanSync — the whole reconcile, still pure:');
 
 t('one plan entry per file, each carrying its own author rank', () => {
@@ -407,6 +434,11 @@ t('migrate.sh invokes agents-sync, module-gated and fail-open', () => {
   // a fresh isModuleEnabled() read never saw a hall toggle.
   assert.match(sh, /\$NODE_ENABLED_MODULES " == \*" agents "\*/, "gated on the module — it is default:false");
   assert.doesNotMatch(sh, /isModuleEnabled\('agents'\)/, 'no override-blind re-read of the module flag');
+  // Split-root (task 1004139): the core's script, the instance's own definitions, pinned to
+  // $DB — and no instance-relative file check, which silenced every split-root instance.
+  assert.match(sh, /DATABASE_URL='' PGDATABASE="\$DB" node "\$CORE_ROOT\/scripts\/gds\/agents-sync\.js" --dir "\$INSTANCE_ROOT\/\.claude\/agents"/,
+    'reconcile the instance .claude/agents with the core script, against $DB');
+  assert.doesNotMatch(sh, /-f scripts\/gds\/agents-sync\.js/, 'no instance-relative existence check');
   // Fail-OPEN: a stale registry is a nuisance, an aborted deploy is an outage,
   // and the script is already fail-closed about what it imports.
   assert.match(sh, /agents-sync failed — the registry is stale by one deploy/,