@bongos/core 1.19.942 → 1.19.943

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.942",
-  "core_contract": "1.19.942",
-  "source_commit": "1e45821468069b9d8f26ed2f7dbf1bbf647ea4b8",
+  "core_version": "1.19.943",
+  "core_contract": "1.19.943",
+  "source_commit": "d2864572d1b1f1112a574071d4fe288920a71216",
   "source_ref": "HEAD",
-  "built_at": "2026-09-21T21:46:27.727Z",
+  "built_at": "2026-09-21T22:14:04.050Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 511,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 2877,
-  "tree_sha256": "5e3c476a60b0631f79c68b199ba47f437ab6295e2518dfc86e7104e8fe0e9bfe",
+  "tree_sha256": "475596e7ac9620819058973e021b0c26d5122429253e9206320f31130a67c709",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2677,7 +2677,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "cf5f371ef80387f8344682a639e736c8cc3240debb4ee97106dfc2525e402e97"
+      "sha256": "441e7d11f2b340623b122c51c788d0ff1d0610ff1c4296db3344c8702c8fb541"
     },
     {
       "path": "docs/modules-contract.md",
@@ -8002,12 +8002,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "04da7afdf07b5eacb7b5d8e18f034a45e62c318eed546facfa4e65480f5a6292"
+      "sha256": "2ff2f30a70ad8facea46291fa01e89889194edb8fa02e904bda7b8343754bbfd"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "79d643dab7e8bf794763c95cfa6f05200054d4aa2be271b61805954b1b82eb83"
+      "sha256": "35b084d56b257e0df6c6a738d94c305a6aa8419471c7b9fe32f41afef640f5fd"
     },
     {
       "path": "public-docs/index.html",
@@ -9617,7 +9617,7 @@
     {
       "path": "scripts/migrate.sh",
       "mode": "0000644",
-      "sha256": "6f927d08ea67e4a7081972fb78fd6131c9eee569730932621d1e1ee6334ddd3a"
+      "sha256": "3a35826ec753908fb9aec9c5a4b5c37e71e38ba0d00c1d1f30387087be509d97"
     },
     {
       "path": "scripts/migrate_cost_ledger.sh",
@@ -10012,7 +10012,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "ea1889449a3dab8921a6d4ce4fc539c8c550aef3eedc14d22493a26cd6af1bcc"
+      "sha256": "cd5bcc86c8d6ecb21b11c6dd9df73de2b63e0759edf781eeee2e6d36f6452aad"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -10187,7 +10187,7 @@
     {
       "path": "tests/agents_sync.mjs",
       "mode": "0000644",
-      "sha256": "2e161bf9ef98425974d8295c8227688cd6fde55314fb3b9413df55542d5a109a"
+      "sha256": "1184d82ba51d3dd3f2bf952292b71defd4b6ea51fba5e3800429cfed1450fe31"
     },
     {
       "path": "tests/agents_validate.mjs",
@@ -12512,7 +12512,7 @@
     {
       "path": "tests/migrate_module_overrides_db.mjs",
       "mode": "0000644",
-      "sha256": "a998b59c0a6d28a0c0d1fe617059631cff052c68afe954265e92a0cca8ce04e4"
+      "sha256": "9d96fe899e8f3f25030ae13b471d2ec9b2f8edb1f9242d221c927e7eac5d7329"
     },
     {
       "path": "tests/migrate_root_resolution.mjs",

package/docs/module-api-changelog.md

@@ -2358,5 +2358,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.940 with no explicit bump. run 35652433730. (task 1002620)
   1.19.942 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.941 with no explicit bump. run 35659043986. (task 1002620)
+  1.19.943 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.942 with no explicit bump. run 35661533404. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.942",
+  "version": "1.19.943",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.942",
+      "version": "1.19.943",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.942",
+  "version": "1.19.943",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/migrate.sh

@@ -407,10 +407,18 @@ fi
 #
 # Silent when the module is off: `agents` is default:false, so on most instances
 # there is no table to reconcile into and nothing to say about it.
-if node -e "process.exit(require('./src/modules').isModuleEnabled('agents') ? 0 : 1)" 2>/dev/null; then
+#
+# Gated on the module set the module loop just migrated (DB overrides included,
+# task 1004138). A fresh isModuleEnabled() read never loaded the overrides, so an
+# `agents` switched on in the hall got its tables but never its registry. Pinned to
+# $DB like that read, so the reconcile writes into the schema this run applied. The
+# file check keeps an instance without the script as silent as the old cwd-relative
+# require left it: a split-root instance (core in node_modules) still does not
+# reconcile, because which .claude/agents it should read is an open design question.
+if [[ " $NODE_ENABLED_MODULES " == *" agents "* ]] && [ -f scripts/gds/agents-sync.js ]; then
   echo
   echo "post-deploy: reconciling .claude/agents/ into the agent registry"
-  if ! node scripts/gds/agents-sync.js; then
+  if ! DATABASE_URL='' PGDATABASE="$DB" node scripts/gds/agents-sync.js; then
     echo "post-deploy: agents-sync failed — the registry is stale by one deploy, not broken" >&2
   fi
 fi

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.942'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.943'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/agents_sync.mjs

@@ -403,7 +403,10 @@ t('migrate.sh invokes agents-sync, module-gated and fail-open', () => {
   // writes into a few lines above, so the table exists by the time it runs.
   const sh = fs.readFileSync(new URL('../scripts/migrate.sh', import.meta.url), 'utf8');
   assert.match(sh, /scripts\/gds\/agents-sync\.js/, 'the deploy path must call it');
-  assert.match(sh, /isModuleEnabled\('agents'\)/, "gated on the module — it is default:false");
+  // Gated on the set the module loop migrated, DB overrides included (task 1004138);
+  // a fresh isModuleEnabled() read never saw a hall toggle.
+  assert.match(sh, /\$NODE_ENABLED_MODULES " == \*" agents "\*/, "gated on the module — it is default:false");
+  assert.doesNotMatch(sh, /isModuleEnabled\('agents'\)/, 'no override-blind re-read of the module flag');
   // Fail-OPEN: a stale registry is a nuisance, an aborted deploy is an outage,
   // and the script is already fail-closed about what it imports.
   assert.match(sh, /agents-sync failed — the registry is stale by one deploy/,

package/tests/migrate_module_overrides_db.mjs

@@ -1,19 +1,24 @@
-// tests/migrate_module_overrides_db.mjs — migrate.sh migrates a module the hall switched on (task 1004137).
+// tests/migrate_module_overrides_db.mjs — migrate.sh follows the hall's module toggles (tasks 1004137, 1004138).
 //
 // The hall's Modules toggle writes module_enablement_overrides, and the server reads that table
 // before it mounts any routes. migrate.sh used to pick its module set in a fresh process that never
 // read it, so a module on ONLY by override was skipped on every deploy while the next restart
-// mounted its routes against tables that did not exist. This drives the real migrate.sh through its
-// --print-modules seam (the same function its module loop calls) against a real database.
+// mounted its routes against tables that did not exist. This drives the real migrate.sh against a
+// real database: its --print-modules seam (the same function its module loop calls), and a full run
+// with psql stubbed out to show the post-deploy agents reconcile gates on that same set.
 //
-// Integration lane: needs Postgres plus the PG* env migrate.sh connects with (the lane sets both);
-// self-skips when no Postgres is reachable. Leaves the override table as it found it.
+// Integration lane: needs Postgres, reached BOTH through DATABASE_URL (this process) and the PG*
+// env (migrate.sh blanks DATABASE_URL so its reads hit the database psql migrates) — the lane sets
+// both. Self-skips when no Postgres is reachable. Leaves the override table as it found it.
 //
-// Run:  DATABASE_URL=postgres://... node tests/migrate_module_overrides_db.mjs
+// Run:  PGHOST=… PGPORT=… PGUSER=… PGPASSWORD=… PGDATABASE=… DATABASE_URL=postgres://… \
+//         node tests/migrate_module_overrides_db.mjs
 
 import { strict as assert } from 'node:assert';
 import { execFileSync } from 'node:child_process';
 import { createRequire } from 'node:module';
+import { chmodSync, mkdtempSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
 import { fileURLToPath } from 'node:url';
 import path from 'node:path';
 
@@ -23,13 +28,15 @@ const { moduleScopeKey } = require('../src/modules.js');
 
 const REPO_ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
 const MIGRATE = path.join(REPO_ROOT, 'scripts', 'migrate.sh');
-// Ships a migration, meters no spend and is off in the packs, so the override alone decides it.
+// Both ship migrations and are off in the packs, so the override alone decides them.
 const MODULE = 'discord';
+const AGENTS = 'agents';
+const RECONCILE_LINE = 'post-deploy: reconciling .claude/agents/ into the agent registry';
 
 try {
   await pool.query('SELECT 1');
 } catch (e) {
-  console.log(`migrate_module_overrides_db.mjs SKIPPED — no reachable Postgres (${e.code || e.message}). Set DATABASE_URL to run.`);
+  console.log(`migrate_module_overrides_db.mjs SKIPPED — no reachable Postgres (${e.code || e.message}). Set DATABASE_URL and the PG* env to run.`);
   await pool.end().catch(() => {});
   process.exit(0);
 }
@@ -37,34 +44,47 @@ try {
 const { rows: [{ db }] } = await pool.query('SELECT current_database() AS db');
 const scope = moduleScopeKey();
 
-function printModules(overrides = {}) {
+// A psql that records nothing and applies nothing: the full run below walks every loop without
+// touching the schema, so only the module-set read (node, real DB) decides what it reaches.
+const stubDir = mkdtempSync(path.join(tmpdir(), 'migrate-stub-psql-'));
+writeFileSync(path.join(stubDir, 'psql'), '#!/usr/bin/env bash\nexit 0\n');
+chmodSync(path.join(stubDir, 'psql'), 0o755);
+
+function migrate(args, overrides = {}) {
   const env = { ...process.env, PGDATABASE: db, ...overrides };
   delete env.INIT_CWD;
-  const out = execFileSync('bash', [MIGRATE, '--print-modules'], {
+  return execFileSync('bash', [MIGRATE, ...args], {
     cwd: REPO_ROOT, env, encoding: 'utf8', stdio: ['ignore', 'pipe', 'pipe'],
   });
-  return out.trim().split(/\s+/).filter(Boolean);
 }
+const printModules = (overrides) => migrate(['--print-modules'], overrides).trim().split(/\s+/).filter(Boolean);
+const fullRunWithStubPsql = () => migrate([], { PATH: `${stubDir}${path.delimiter}${process.env.PATH}` });
 
-const setOverride = (enabled) => pool.query(
+const setOverride = (key, enabled) => pool.query(
   `INSERT INTO module_enablement_overrides (scope, module_key, enabled) VALUES ($1, $2, $3)
    ON CONFLICT (scope, module_key) DO UPDATE SET enabled = EXCLUDED.enabled`,
-  [scope, MODULE, enabled],
+  [scope, key, enabled],
+);
+const clearOverride = (key) => pool.query(
+  'DELETE FROM module_enablement_overrides WHERE scope = $1 AND module_key = $2', [scope, key],
 );
 
 const { rows: prior } = await pool.query(
-  'SELECT enabled, set_by, set_at FROM module_enablement_overrides WHERE scope = $1 AND module_key = $2',
-  [scope, MODULE],
+  'SELECT module_key, enabled, set_by, set_at FROM module_enablement_overrides WHERE scope = $1 AND module_key = ANY($2)',
+  [scope, [MODULE, AGENTS]],
 );
 
 try {
-  await pool.query('DELETE FROM module_enablement_overrides WHERE scope = $1 AND module_key = $2', [scope, MODULE]);
+  await clearOverride(MODULE);
+  await clearOverride(AGENTS);
   const packs = printModules();
   assert.ok(packs.length > 0, 'with no override the pack set still resolves (not an empty read)');
-  assert.ok(!packs.includes(MODULE), `precondition: ${MODULE} is off in the packs, so only an override can turn it on`);
+  for (const key of [MODULE, AGENTS]) {
+    assert.ok(!packs.includes(key), `precondition: ${key} is off in the packs, so only an override can turn it on`);
+  }
   console.log(`  ok  no override: ${MODULE} is not migrated`);
 
-  await setOverride(true);
+  await setOverride(MODULE, true);
   const toggled = printModules();
   assert.ok(toggled.includes(MODULE), `a hall toggle ON must reach migrate's module set, got: ${toggled.join(' ')}`);
   assert.deepEqual(toggled.filter((m) => m !== MODULE), packs, 'and changes nothing else');
@@ -75,17 +95,32 @@ try {
   const unreadable = printModules({ PGHOST: '127.0.0.1', PGPORT: '1' });
   assert.deepEqual(unreadable, packs, 'an unreachable override database resolves exactly the pack set');
   console.log('  ok  unreadable overrides fall back to the packs');
-} finally {
-  if (prior.length) {
-    await pool.query(
-      `INSERT INTO module_enablement_overrides (scope, module_key, enabled, set_by, set_at)
-            VALUES ($1, $2, $3, $4, $5)
-       ON CONFLICT (scope, module_key)
-         DO UPDATE SET enabled = EXCLUDED.enabled, set_by = EXCLUDED.set_by, set_at = EXCLUDED.set_at`,
-      [scope, MODULE, prior[0].enabled, prior[0].set_by, prior[0].set_at],
-    );
+
+  // The reconcile itself is real: where its table exists it would write registry rows this test
+  // cannot cleanly undo, so it only runs where the sync fails harmlessly (the lane: agents is off).
+  const { rows: [{ reg }] } = await pool.query("SELECT to_regclass('agents_definitions') AS reg");
+  if (reg) {
+    console.log(`  SKIP  ${AGENTS} reconcile case — agents_definitions exists here, and a full run would write into it`);
   } else {
-    await pool.query('DELETE FROM module_enablement_overrides WHERE scope = $1 AND module_key = $2', [scope, MODULE]);
+    assert.ok(!fullRunWithStubPsql().includes(RECONCILE_LINE), `${AGENTS} off: the post-deploy reconcile stays silent`);
+    await setOverride(AGENTS, true);
+    assert.ok(fullRunWithStubPsql().includes(RECONCILE_LINE), `a hall toggle ON for ${AGENTS} must reach the post-deploy reconcile`);
+    console.log(`  ok  override on: the ${AGENTS} registry reconcile runs`);
+  }
+} finally {
+  for (const key of [MODULE, AGENTS]) {
+    const row = prior.find((r) => r.module_key === key);
+    if (row) {
+      await pool.query(
+        `INSERT INTO module_enablement_overrides (scope, module_key, enabled, set_by, set_at)
+              VALUES ($1, $2, $3, $4, $5)
+         ON CONFLICT (scope, module_key)
+           DO UPDATE SET enabled = EXCLUDED.enabled, set_by = EXCLUDED.set_by, set_at = EXCLUDED.set_at`,
+        [scope, key, row.enabled, row.set_by, row.set_at],
+      );
+    } else {
+      await clearOverride(key);
+    }
   }
   await pool.end().catch(() => {});
 }