@bongos/core 1.19.905 → 1.19.906

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.905",
-  "core_contract": "1.19.905",
-  "source_commit": "dc5ca8cc91d1d88f957f722664f60778d2bdc4f1",
+  "core_version": "1.19.906",
+  "core_contract": "1.19.906",
+  "source_commit": "292f91e86ee9b852efe6c0e93158f5815ccdfa42",
   "source_ref": "HEAD",
-  "built_at": "2026-09-20T13:17:59.483Z",
+  "built_at": "2026-09-20T13:41:10.148Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 502,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 2811,
-  "tree_sha256": "85790109607eeddc8439f8473f642747ed158cfb88a269f55222c30bc45016e5",
+  "tree_sha256": "160619c1eb4a21d556e0ed9151463e10b29b88a5aeb1249d213d371aaae5402a",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2632,7 +2632,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "ade94268540de319c8d071b7b70654fca4cb4bdd7bcfbbfe8ddca5710329545b"
+      "sha256": "d329f2a3999d8bc88ce4715be5ee51d9e7a60ba0e0f0a9e06163c12ff94d87ba"
     },
     {
       "path": "docs/modules-contract.md",
@@ -4992,7 +4992,7 @@
     {
       "path": "modules/hall-ui/public/people.js",
       "mode": "0000644",
-      "sha256": "4740be7b7d28c8c3e4098054c63de85086265149f7024b15cff443d59283c087"
+      "sha256": "37d7c9b14bb42a473ef7caf45f138cd87b01b976bb593d1fd2a0c82c94208539"
     },
     {
       "path": "modules/hall-ui/public/people.states.json",
@@ -7782,12 +7782,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "3b60452f407da16a6c09df92482e570ca061e920dd7537a6f2f84569a13e0545"
+      "sha256": "6a2f94c668864dc88fdc003473496102838182e8d18636930537c32bd67c7e47"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "3af5e528e00f1047c76f56189ef168ea8c879f09762b735160b5c6d2e81f9d24"
+      "sha256": "1ddcd43de722cb5eff00c36a440b0df181f1c8168a8c8b3193fc3d9a586afdbd"
     },
     {
       "path": "public-docs/index.html",
@@ -9782,7 +9782,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "2489905dea4c9defd22089221f6dce7c522f9860e6b684c9e6cea03a2600a17d"
+      "sha256": "4593c8749b7b52a5bb6116e0d3dbe6004dc24346bb79ca0a5757359e98dc259e"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -11672,7 +11672,7 @@
     {
       "path": "tests/hall_roster_world.mjs",
       "mode": "0000644",
-      "sha256": "191184eeaf40d8e10704ae57bfe1d58574f7b6053634d69844d47212bf05f18a"
+      "sha256": "477ec31839036884ac0923a078e7cb1e60d37548c758e24701b338c1e8179c6a"
     },
     {
       "path": "tests/hall_sessions_ledger.mjs",
@@ -12512,7 +12512,7 @@
     {
       "path": "tests/people_directory_clip.mjs",
       "mode": "0000644",
-      "sha256": "b412cf076656c3400d76f46a2df18adb5a2ec376ed7e3da6beefcf344446993b"
+      "sha256": "e3b2f36780b35fd66690b1c426832322b2781c5386cf7fd50e995a7c2cc089bb"
     },
     {
       "path": "tests/permission_path.mjs",

package/docs/module-api-changelog.md

@@ -2284,5 +2284,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.903 with no explicit bump. run 35511494246. (task 1002620)
   1.19.905 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.904 with no explicit bump. run 35513060618. (task 1002620)
+  1.19.906 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.905 with no explicit bump. run 35514202453. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/hall-ui/public/people.js

@@ -39,6 +39,11 @@
   }
   var fmtInt = function (n) { return OTB && OTB.fmtInt ? OTB.fmtInt(n) : String(n == null ? 0 : n); };
   var rankLabel = function (r) { return OTB && OTB.rankLabel ? OTB.rankLabel(r) : r; };
+  // A ROW TAG TAKES roleLabel() (dom-utils.js, task 1004041). Without it the Directory
+  // printed the column: lowercase 'engineer', 'ui' instead of 'UI', and — for a builder
+  // who has set no role — 'unclassified', which is the example V2 names, in the exact
+  // place it names it. Same defensive shape as rankLabel above: the pack may be absent.
+  var roleLabel = function (d) { return OTB && OTB.roleLabel ? OTB.roleLabel(d) : String(d); };
   var currencyLabel = function () {
     var b = window.OTBBranding;
     return (b && b.currencyLabel && b.currencyLabel({ caps: true })) || 'Credits';
@@ -70,7 +75,7 @@
     var list = Array.isArray(b.disciplines) ? b.disciplines : [];
     if (!list.length) return '<span class="dir-none">—</span>';
     return '<span class="dir-crafts">' + list.map(function (d) {
-      return '<span class="fact-chip">' + esc(String(d)) + '</span>';
+      return '<span class="fact-chip">' + esc(roleLabel(d)) + '</span>';
     }).join('') + '</span>';
   }
 

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.905",
+  "version": "1.19.906",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.905",
+      "version": "1.19.906",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.905",
+  "version": "1.19.906",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.905'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.906'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/hall_roster_world.mjs

@@ -221,7 +221,12 @@ test('the directory row shows the avatar, the name and the login the API returns
   assert.match(src, /class="lb-name dir-name" href="https:\/\/github\.com\/' \+ encodeURIComponent\(b\.github_login\)/,
     'the shell\'s .lb-name, to the one page every listed builder has');
   assert.match(src, /'<span class="dir-login">@' \+ esc\(b\.github_login\)/, 'the login under the name says where the door goes');
-  assert.match(src, /<span class="fact-chip">' \+ esc\(String\(d\)\)/, 'crafts are chips');
+  // The chip is the assertion; what goes IN it is the role vocabulary, not the column
+  // (task 1004040). This line used to pin `esc(String(d))` — the raw value — so it read as
+  // a guard on the chip while actually holding the Directory to rendering 'unclassified'
+  // and a lowercase 'ui'. Pinning the wrapper and the helper keeps the original intent
+  // without pinning the defect that happened to be inside it.
+  assert.match(src, /<span class="fact-chip">' \+ esc\(roleLabel\(d\)\)/, 'roles are chips, spoken not printed');
   assert.doesNotMatch(src, /class="num"/, 'the shell\'s ledger__num, not the bare .num scouting.js had corrected');
   assert.match(src, /class="ledger__num"/);
 });

package/tests/people_directory_clip.mjs

@@ -58,6 +58,17 @@ function makeEl(id) {
 }
 
 // `count` builders, each distinct enough that a filter lens has something to bite.
+// The REAL role vocabulary, for the same reason this file runs the real kit rather than a
+// stub: a stub of roleLabel() would agree with a roleLabel() that was wrong. dom-utils.js
+// is pure enough to run against two small objects (tests/collab_page.mjs does the same).
+function realRoleLabel() {
+  const src = read('modules/hall-ui/public/dom-utils.js');
+  const win = { location: { search: '', hash: '', pathname: '/' }, addEventListener() {}, localStorage: null };
+  const doc = { addEventListener() {}, querySelector: () => null, querySelectorAll: () => [], documentElement: { dataset: {} } };
+  new Function('window', 'document', src)(win, doc);
+  return win.OTB.roleLabel;
+}
+
 function buildersFor(count) {
   return Array.from({ length: count }, (_, i) => ({
     github_id: 1000 + i,
@@ -105,7 +116,6 @@ function harness({ count }) {
       // task 1003936 — the role axis vocabulary (dom-utils OTB.role*). PRESENT for
       // the same reason categoryChip is: an undefined helper throws mid-render.
       roleAxisLabel: () => 'Role',
-      roleLabel: (d) => (!d ? '' : d === 'unclassified' ? 'No role yet' : d === 'ui' ? 'UI' : d.charAt(0).toUpperCase() + d.slice(1)),
       roleOptions: () => [{ value: '', label: '— any —' }, { value: 'engineer', label: 'Engineer' }, { value: 'artist', label: 'Artist' }],
       roleIsUnset: (d) => !d || d === 'unclassified',
       ROLE_UNSET: 'unclassified',
@@ -116,6 +126,13 @@ function harness({ count }) {
       fmtCompact: (n) => String(Number(n) || 0),
       fmtDate: (iso) => String(iso ?? '').slice(0, 10),
       rankLabel: (r) => String(r ?? ''),
+      // The REAL one, replacing a hand-written reimplementation that used to sit here.
+      // Two reasons it had to go, and the second is the point of this file: it was a
+      // duplicate object key once the real helper arrived (no-dupe-keys, the later
+      // definition silently winning), and a stub that restates roleLabel's own logic
+      // can drift from it and the test would never notice — which is the argument this
+      // file already makes for running the real kit.
+      roleLabel: realRoleLabel(),
       toast() {},
     },
   };
@@ -162,6 +179,32 @@ await test('the page asks for exactly the ceiling, and asks for it ONCE', async
   assert.equal(limit, CEILING, `the page must ask for the route ceiling (${CEILING})`);
 });
 
+// --- task 1004040 (artist review of 1003936): the Directory speaks the role --------
+
+await test('the role vocabulary a Directory chip renders through says the word, not the column', () => {
+  // The 1003936 grade named this as a nit — craftsHtml() rendering the raw discipline
+  // instead of routing it through roleLabel() — and a nit is advisory, so it survived two
+  // more rounds. What a reader saw: lowercase 'engineer', 'ui' where the house writes
+  // 'UI', and, for a builder who has set no role, the database's own 'unclassified' —
+  // the example V2 names, in the exact place it names it ("a filter option and a row tag").
+  //
+  // The BEHAVIOUR is executed: this is the shipped roleLabel, not a stub of it.
+  const roleLabel = realRoleLabel();
+  assert.equal(roleLabel('engineer'), 'Engineer');
+  assert.equal(roleLabel('ui'), 'UI', 'the acronym keeps its case');
+  assert.equal(roleLabel('unclassified'), 'No role yet', 'a sentence a person would say');
+
+  // The CALL SITE is read, because it cannot be executed here: the harness's document
+  // fake returns a fresh detached node from querySelector(), so the kit fills a <tbody>
+  // that never reaches the markup this file can see. Observing a rendered row would mean
+  // deepening that fake, which is a change to a shared harness and not an artist review's
+  // business. Named in the session log rather than left as a silent gap.
+  const src = read('modules/hall-ui/public/people.js');
+  assert.match(src, /esc\(roleLabel\(d\)\)/, 'the chip routes through the role vocabulary');
+  assert.doesNotMatch(src, /'<span class="fact-chip">' \+ esc\(String\(d\)\)/,
+    'the raw column must not be rendered as a chip');
+});
+
 await test('a SHORT directory is not hedged — the exact count is the honest one', async () => {
   const h = harness({ count: 3 });
   await tick(); await tick();