@bongos/core 1.19.904 → 1.19.906

package/tests/people_directory_clip.mjs

@@ -58,6 +58,17 @@ function makeEl(id) {
 }
 
 // `count` builders, each distinct enough that a filter lens has something to bite.
+// The REAL role vocabulary, for the same reason this file runs the real kit rather than a
+// stub: a stub of roleLabel() would agree with a roleLabel() that was wrong. dom-utils.js
+// is pure enough to run against two small objects (tests/collab_page.mjs does the same).
+function realRoleLabel() {
+  const src = read('modules/hall-ui/public/dom-utils.js');
+  const win = { location: { search: '', hash: '', pathname: '/' }, addEventListener() {}, localStorage: null };
+  const doc = { addEventListener() {}, querySelector: () => null, querySelectorAll: () => [], documentElement: { dataset: {} } };
+  new Function('window', 'document', src)(win, doc);
+  return win.OTB.roleLabel;
+}
+
 function buildersFor(count) {
   return Array.from({ length: count }, (_, i) => ({
     github_id: 1000 + i,
@@ -105,7 +116,6 @@ function harness({ count }) {
       // task 1003936 — the role axis vocabulary (dom-utils OTB.role*). PRESENT for
       // the same reason categoryChip is: an undefined helper throws mid-render.
       roleAxisLabel: () => 'Role',
-      roleLabel: (d) => (!d ? '' : d === 'unclassified' ? 'No role yet' : d === 'ui' ? 'UI' : d.charAt(0).toUpperCase() + d.slice(1)),
       roleOptions: () => [{ value: '', label: '— any —' }, { value: 'engineer', label: 'Engineer' }, { value: 'artist', label: 'Artist' }],
       roleIsUnset: (d) => !d || d === 'unclassified',
       ROLE_UNSET: 'unclassified',
@@ -116,6 +126,13 @@ function harness({ count }) {
       fmtCompact: (n) => String(Number(n) || 0),
       fmtDate: (iso) => String(iso ?? '').slice(0, 10),
       rankLabel: (r) => String(r ?? ''),
+      // The REAL one, replacing a hand-written reimplementation that used to sit here.
+      // Two reasons it had to go, and the second is the point of this file: it was a
+      // duplicate object key once the real helper arrived (no-dupe-keys, the later
+      // definition silently winning), and a stub that restates roleLabel's own logic
+      // can drift from it and the test would never notice — which is the argument this
+      // file already makes for running the real kit.
+      roleLabel: realRoleLabel(),
       toast() {},
     },
   };
@@ -162,6 +179,32 @@ await test('the page asks for exactly the ceiling, and asks for it ONCE', async
   assert.equal(limit, CEILING, `the page must ask for the route ceiling (${CEILING})`);
 });
 
+// --- task 1004040 (artist review of 1003936): the Directory speaks the role --------
+
+await test('the role vocabulary a Directory chip renders through says the word, not the column', () => {
+  // The 1003936 grade named this as a nit — craftsHtml() rendering the raw discipline
+  // instead of routing it through roleLabel() — and a nit is advisory, so it survived two
+  // more rounds. What a reader saw: lowercase 'engineer', 'ui' where the house writes
+  // 'UI', and, for a builder who has set no role, the database's own 'unclassified' —
+  // the example V2 names, in the exact place it names it ("a filter option and a row tag").
+  //
+  // The BEHAVIOUR is executed: this is the shipped roleLabel, not a stub of it.
+  const roleLabel = realRoleLabel();
+  assert.equal(roleLabel('engineer'), 'Engineer');
+  assert.equal(roleLabel('ui'), 'UI', 'the acronym keeps its case');
+  assert.equal(roleLabel('unclassified'), 'No role yet', 'a sentence a person would say');
+
+  // The CALL SITE is read, because it cannot be executed here: the harness's document
+  // fake returns a fresh detached node from querySelector(), so the kit fills a <tbody>
+  // that never reaches the markup this file can see. Observing a rendered row would mean
+  // deepening that fake, which is a change to a shared harness and not an artist review's
+  // business. Named in the session log rather than left as a silent gap.
+  const src = read('modules/hall-ui/public/people.js');
+  assert.match(src, /esc\(roleLabel\(d\)\)/, 'the chip routes through the role vocabulary');
+  assert.doesNotMatch(src, /'<span class="fact-chip">' \+ esc\(String\(d\)\)/,
+    'the raw column must not be rendered as a chip');
+});
+
 await test('a SHORT directory is not hedged — the exact count is the honest one', async () => {
   const h = harness({ count: 3 });
   await tick(); await tick();