@bongos/core 1.19.903 → 1.19.905

package/modules/ideas/trail-size.js

@@ -0,0 +1,88 @@
+// modules/ideas/trail-size.js — SIZE on the idea trail: what each thought's
+// work has actually earned (task 1004093, BV2.R12, goal 1000095; spec
+// docs/specs/bongos-v2-ideator-surface.md decisions 4 + 5).
+//
+// The trail already answers "what became of my idea" (listIdeaTrailForBuilder)
+// and, since BV2.R09, "and what did THAT go on to cause" (trail-descent.js).
+// Size is the third column of the same sentence and the only one denominated in
+// money: the sum of every stream-1 payout the descent has produced.
+//
+// WHY IT IS A SEPARATE FILE, like trail-descent.js beside it. inbox.js is AT the
+// 1500-line size ratchet (scripts/gds/fitness-ratchets.js), so a line added
+// there fails the build. And this is a different read again: the trail is
+// idea → task, the descent is a task → task walk, and size is a read of the
+// LEDGER keyed by idea. Three relations, three files.
+//
+// WHY IT GOES THROUGH THE `reward` PORT AND NOT A SQL READ OF ITS OWN.
+// credit_log is economy's table and modules may not require each other
+// (ADR 0083 rule 1). The read is small enough that a copy here would be
+// tempting — and that is exactly the trap: the reason key `idea.credit.
+// task_ship:<idea>:<task>` is economy's idempotency predicate, economy is free
+// to change it, and a second reader of it in this module would silently start
+// summing nothing the day it did. `ideas` already declares `reward` in its
+// module.json `consumes`, so this adds no new dependency edge.
+//
+// RESOLVED OPTIONALLY EVEN SO. `consumes` means the instance will not boot
+// without the port, so in production the resolve cannot fail — but tests rebuild
+// the GDS router with an arbitrary subset of modules, and a trail read that
+// throws because economy was not mounted is a worse failure than a trail read
+// with no money on it. When the port is absent every idea gets `size: null`,
+// NOT zero: zero is a real answer meaning "this thought has earned nothing yet",
+// and rendering it for "we could not ask" would tell an ideator their work paid
+// nothing. tests/idea_size.mjs drives both branches.
+
+const api = require('../../src/module-api');
+
+// attachSizeToTrail — mutates each idea in place with `size`, and returns the
+// list, mirroring attachDescentToTrail's shape so the route composes the two the
+// same way.
+//
+// `size` is `{ credits, payments, scale }` — the TRUE figure the panel prints,
+// how many payouts made it up, and the compressed magnitude a drawing uses. Both
+// are carried because the spec asks for both: compressed for drawing, true
+// figure available (decision 4). The compression is economy's, applied once at
+// the read, so nothing downstream invents a second curve.
+//
+// ONE query for the whole page, not one per idea — the same property
+// trail-descent.js pins, for the same reason: this rides a paged trail read and
+// a per-idea round trip would make a long trail quadratic in round trips.
+async function attachSizeToTrail(ideas, { client = null } = {}) {
+  const list = Array.isArray(ideas) ? ideas : [];
+  if (list.length === 0) return list;
+
+  const reward = api.resolveOptional && api.resolveOptional('reward');
+  if (!reward || typeof reward.ideaSizes !== 'function' || typeof reward.descentRowsFromTrail !== 'function') {
+    for (const idea of list) idea.size = null;
+    return list;
+  }
+
+  // The ids are asked for as the idea's OWN id, never the id it merged into.
+  // The descent a merged idea SHOWS is inherited (trail-descent.js followMerges,
+  // ADR 0311 — nothing is lost), but the money it EARNED is its own: stream 1
+  // books against the idea whose lineage row named the shipping task, and
+  // crediting A's star with B's payouts would count B's work twice on one page.
+  // That asymmetry is the same one the payout itself draws (spec decision 7):
+  // the descent displays more than the number counts.
+  // THE DESCENT IS ALREADY IN HAND, so the historical half costs nothing
+  // (task 1004097 / BV2.R18). attachDescentToTrail ran first — the route
+  // composes them in that order — so every idea on this page already carries its
+  // own tasks and everything below them, each with a status and a shortest
+  // depth. Handing that to economy is the difference between one extra walk per
+  // page and none at all; economy falls back to walking only for a caller that
+  // has no descent, which is a single-idea panel and never this one.
+  //
+  // The SHAPE is economy's, not this module's: `descentRowsFromTrail` lives with
+  // the pricing that consumes it, so a change to what the pricing needs cannot
+  // leave a hand-built projection here quietly dropping a field.
+  const descentByIdea = new Map();
+  for (const idea of list) {
+    descentByIdea.set(String(idea.id), reward.descentRowsFromTrail(idea));
+  }
+  const sizes = await reward.ideaSizes(list.map((i) => i.id), { client, descentByIdea });
+  for (const idea of list) {
+    idea.size = sizes.get(String(idea.id)) || { credits: 0, payments: 0, scale: 0 };
+  }
+  return list;
+}
+
+module.exports = { attachSizeToTrail };

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.903",
+  "version": "1.19.905",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.903",
+      "version": "1.19.905",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.903",
+  "version": "1.19.905",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.903'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.905'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/collab_page.mjs

@@ -421,6 +421,50 @@ test('the SIDEBAR badge: the Collab item declares the help_requests count', () =
   assert.match(fn, /href: '\/collab'/, 'pointing at the page, not the retired hash view');
 });
 
+// ---- THE MINGLE ROW SPEAKS THE ROLE ---------------------------------------
+// task 1003967 (artist review of 1003960). Run, not grepped: the first version of this
+// guard matched identifier names in the source, which would have agreed with a swapped
+// article just as happily as with a correct one. The sentence is pure, so execute it.
+
+test('the mingle sub-line reads as English for every pair, and never shows the column', () => {
+  const L = lib();
+  const OTB = domUtils();
+  const word = (d) => (OTB.roleIsUnset(d) ? '' : OTB.roleWord(d));
+  const line = (a, b) => L.pairSentence(word(a), word(b));
+
+  assert.equal(line('engineer', 'artist'), 'An engineer — you are an artist. Mingle pairs across roles.');
+  assert.equal(line('artist', 'ideator'), 'An artist — you are an ideator. Mingle pairs across roles.');
+
+  // 'ui' is the acronym exception roleWord() already makes, and it is why the article
+  // cannot be a plain vowel test — "an UI" is how that shortcut fails.
+  assert.equal(line('ui', 'engineer'), 'A UI — you are an engineer. Mingle pairs across roles.');
+  assert.equal(line('engineer', 'ui'), 'An engineer — you are a UI. Mingle pairs across roles.');
+});
+
+test('a pair with an unset role drops the comparison rather than naming the default', () => {
+  const L = lib();
+  const OTB = domUtils();
+  const word = (d) => (OTB.roleIsUnset(d) ? '' : OTB.roleWord(d));
+
+  // The defect this replaced rendered the database's own word — "A unclassified — you are
+  // a engineer" — which is the example V2 names. Nothing a person did not choose may reach
+  // the sentence, whichever side is missing.
+  for (const pair of [[OTB.ROLE_UNSET, 'engineer'], ['engineer', OTB.ROLE_UNSET], [null, 'artist'], ['', '']]) {
+    const out = L.pairSentence(word(pair[0]), word(pair[1]));
+    assert.equal(out, 'Mingle pairs across roles.', `pair ${JSON.stringify(pair)}`);
+    assert.doesNotMatch(out, /unclassified/);
+  }
+});
+
+test('aOrAn is the article rule, stated once', () => {
+  const L = lib();
+  assert.equal(L.aOrAn('engineer'), 'an');
+  assert.equal(L.aOrAn('artist'), 'an');
+  assert.equal(L.aOrAn('ideator'), 'an');
+  assert.equal(L.aOrAn('UI'), 'a', 'the acronym is spoken "you-eye", so it takes "a"');
+  assert.equal(L.aOrAn('ui'), 'a');
+});
+
 // ---- THE ANSWERABLE CLAUSE ------------------------------------------------
 test('the asker can settle in place, with both outcomes', () => {
   const js = read('modules', 'hall-ui', 'public', 'collab.js');