@bongos/core 1.19.903 → 1.19.904

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.903",
-  "core_contract": "1.19.903",
-  "source_commit": "53ab83b870bf45e758ab22a2fb93103bfa42e51d",
+  "core_version": "1.19.904",
+  "core_contract": "1.19.904",
+  "source_commit": "a20b94f5efe38b09072d0456c5e352a2cf7bba1c",
   "source_ref": "HEAD",
-  "built_at": "2026-09-20T12:28:20.291Z",
+  "built_at": "2026-09-20T12:45:09.857Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 502,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 2806,
-  "tree_sha256": "80c42879b74b051029afdcbf6fdcbbf26804064e32ea7abbcdc58a4fa44811fb",
+  "tree_sha256": "e03f442cd778ef6dd35a6c2f47a07e0f4d7c72a8d86882256367239d4b87989b",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2097,12 +2097,12 @@
     {
       "path": "docs/copy-inventory.md",
       "mode": "0000644",
-      "sha256": "bee7d1411eaf22aaaf7887b53e1151a0654055f8b4a7f6d78802b1eea766aa71"
+      "sha256": "3f1539c0050241b9dd7200170d664fc193c977958c2fee57e4bf5309591ccae6"
     },
     {
       "path": "docs/copy-registry.json",
       "mode": "0000644",
-      "sha256": "120d68ae5ad77ce670704ccd385b14b523ff7a530742b0038788e480084c6e34"
+      "sha256": "1be015a58b02240690be5a2c5fcad56b42074500dcc7ebb8255ffa5156063748"
     },
     {
       "path": "docs/design/apex-pass-2-direction.md",
@@ -2632,7 +2632,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "d6d904e3287c4286cd615dc97eb5d48295c06da5b430cb799aec003a34bdc5a1"
+      "sha256": "25f3aef34d52ca5c8a93b25fa0cd79aeba0e2395e2f66d2e192ca57464d71b65"
     },
     {
       "path": "docs/modules-contract.md",
@@ -4647,7 +4647,7 @@
     {
       "path": "modules/hall-ui/public/collab-lib.js",
       "mode": "0000644",
-      "sha256": "c8c30e5f3cb5982a8218b6e8b135923c76b75604be553dcf3ed46fca0466e67f"
+      "sha256": "bfadae8700cc22ea13f8bc39a3e2a1876b58da6151032e9a973402bc9bd0aaa7"
     },
     {
       "path": "modules/hall-ui/public/collab.css",
@@ -4662,7 +4662,7 @@
     {
       "path": "modules/hall-ui/public/collab.js",
       "mode": "0000644",
-      "sha256": "7d589e6c98f9f52831a9be9429493b49e68c3aa62f98f19cbcb77adbac70c0ca"
+      "sha256": "91a0751cebcbc179f28ad1cac7a6c447f90369ae40f29e5f60c1bd934ac68f85"
     },
     {
       "path": "modules/hall-ui/public/collab.states.json",
@@ -7762,12 +7762,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "20d17854b6e4522308515c26c6efe033baa02b0d1b86a40c211fddc2b0cecfde"
+      "sha256": "f6623c9d73536e00c2c9a3d44dc68f3e8bdbe44e47543c32aaa22f3059efa410"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "8ee9f9ba3532c45ffd794bbdcae1c6d8d38fad130d73cf9c5275787ccfb60e53"
+      "sha256": "f092d5149aa7e2518d2ddd4b940e92c4d61f8c553afedd810d97752efa9a207e"
     },
     {
       "path": "public-docs/index.html",
@@ -9762,7 +9762,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "565add1bbddcccee0c1b0e3e748b36d607af667350a541338faf48025cbfb904"
+      "sha256": "f15a6c9c7458ce744ffbe72c8997b25e0098a2a26b2f6f41e7e3513fc073110d"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -10602,7 +10602,7 @@
     {
       "path": "tests/collab_page.mjs",
       "mode": "0000644",
-      "sha256": "d7bbf03d41d8808f5f86f333a9e925291a628b5e5b4cac483be34880a6d42d04"
+      "sha256": "b710669fabe9e747fe37abf429356e80c1f7a36cd63ac308dda2a933243e2e6d"
     },
     {
       "path": "tests/compose_demo_credentials.mjs",

package/docs/copy-inventory.md

@@ -4,13 +4,13 @@
 > Deterministic on a given tree — regenerate and commit rather than hand-editing.
 > Machine-readable twin: [`copy-registry.json`](copy-registry.json).
 
-**1827 strings** across 3 surfaces · 1585 distinct pieces of copy · 1827 certain, 0 heuristic · 166 shown in more than one place.
+**1826 strings** across 3 surfaces · 1584 distinct pieces of copy · 1826 certain, 0 heuristic · 166 shown in more than one place.
 
 ## Surfaces
 
 | surface | lives at | files | strings |
 |---|---|---|---|
-| `builders-hall` | `modules/hall-ui/public` | 84 | 1337 |
+| `builders-hall` | `modules/hall-ui/public` | 84 | 1336 |
 | `status-dashboard` | `modules/status-ui/public` | 4 | 100 |
 | `landing` | `modules/public-landing/public` | 5 | 390 |
 
@@ -78,7 +78,7 @@ Identical copy within one surface. Sometimes right (a repeated button), sometime
 | `996edffc1966` | 2x | Access requests | modules/hall-ui/public/watch.html:46, modules/hall-ui/public/watch.html:61 |
 | … | | _126 more in the JSON registry_ | |
 
-## `builders-hall` — 1337 strings
+## `builders-hall` — 1336 strings
 
 | id | conf | text | where |
 |---|---|---|---|
@@ -135,7 +135,6 @@ Identical copy within one surface. Sometimes right (a repeated button), sometime
 | `0b9adf029094` | certain | A task cannot wait for itself. | `modules/hall-ui/public/task.js:890` |
 | `0aaa0f2c4bdc` | certain | A title is required. | `modules/hall-ui/public/blockers.js:345` |
 | `daf73127afff` | certain | A word on why | `modules/hall-ui/public/hall-render.js:294` |
-| `9fe51a2e1e71` | certain | A {…} — you are a {…}. Mingle pairs across roles. | `modules/hall-ui/public/collab.js:421` |
 | `996edffc1966` | certain | Access requests | `modules/hall-ui/public/watch.html:46` |
 | `996edffc1966` | certain | Access requests | `modules/hall-ui/public/watch.html:61` |
 | `303f8d90266f` | certain | Achievements could not be loaded. | `modules/hall-ui/public/builders.js:1196` |
@@ -304,7 +303,7 @@ Identical copy within one surface. Sometimes right (a repeated button), sometime
 | `90691bceaf68` | certain | Could not load | `modules/hall-ui/public/task.js:982` |
 | `589a4cfc5442` | certain | Could not load idea {…}. | `modules/hall-ui/public/ideas.js:644` |
 | `192c893fc64e` | certain | Could not load modules. | `modules/hall-ui/public/modules.js:318` |
-| `8a4b590fa1a0` | certain | Could not load requests. | `modules/hall-ui/public/collab.js:514` |
+| `9912c3835136` | certain | Could not load requests — reload to try again. | `modules/hall-ui/public/collab.js:529` |
 | `7775fec0fa85` | certain | Could not load sessions. | `modules/hall-ui/public/sessions.js:399` |
 | `7775fec0fa85` | certain | Could not load sessions. | `modules/hall-ui/public/sessions.js:437` |
 | `a2f2e8babef5` | certain | Could not load that page. Try again. | `modules/hall-ui/public/blockers.js:274` |
@@ -669,7 +668,7 @@ Identical copy within one surface. Sometimes right (a repeated button), sometime
 | `c72e0bdb834a` | certain | Not declared in module.json — this is who ships the module. | `modules/hall-ui/public/modules.js:62` |
 | `361b353ded5e` | certain | Not enough shipped work yet to chart. | `modules/hall-ui/public/hall-widgets.js:184` |
 | `90230572d017` | certain | Not found | `modules/hall-ui/public/task.js:970` |
-| `8226c979db4d` | certain | Not now | `modules/hall-ui/public/collab.js:421` |
+| `8226c979db4d` | certain | Not now | `modules/hall-ui/public/collab.js:435` |
 | `5ffcdc1a0176` | certain | Not scored — this builder’s own profile waived every signal, or the session predates this measure. | `modules/hall-ui/public/sessions.js:100` |
 | `61250b49a90b` | certain | Not scored. | `modules/hall-ui/public/idea.js:84` |
 | `8d6afe6def47` | certain | Not signed in | `modules/hall-ui/public/settings.html:40` |
@@ -847,7 +846,7 @@ Identical copy within one surface. Sometimes right (a repeated button), sometime
 | `42cbc20a6ec8` | certain | Saves when you press Save; your next | `modules/hall-ui/public/settings.html:136` |
 | `645dd8117cf3` | certain | Say why it is being retired — the reason goes in the record. | `modules/hall-ui/public/task.js:924` |
 | `fc9d783ed0f5` | certain | Say why it is better. Whoever reviews this decides it from your reason, without asking you. | `modules/hall-ui/public/copy-desk.js:446` |
-| `12c1ec21a2c6` | certain | Say yes | `modules/hall-ui/public/collab.js:421` |
+| `12c1ec21a2c6` | certain | Say yes | `modules/hall-ui/public/collab.js:435` |
 | `46711f7bc3df` | certain | Search every string the product shows a person, by what it says or the file it lives in. | `modules/hall-ui/public/copy-desk.html:65` |
 | `5d2ba8e72fa1` | certain | Search failed. | `modules/hall-ui/public/copy-desk.js:343` |
 | `373a7639bcb9` | certain | Sections in this primer | `modules/hall-ui/public/primer.html:52` |

package/docs/copy-registry.json

@@ -3,9 +3,9 @@
   "generator": "scripts/gds/copy-inventory.js",
   "goal": 1000074,
   "counts": {
-    "strings": 1827,
-    "unique_ids": 1585,
-    "certain": 1827,
+    "strings": 1826,
+    "unique_ids": 1584,
+    "certain": 1826,
     "heuristic": 0,
     "duplicate_ids": 166
   },
@@ -13,7 +13,7 @@
     "builders-hall": {
       "at": "modules/hall-ui/public",
       "files": 84,
-      "strings": 1337
+      "strings": 1336
     },
     "status-dashboard": {
       "at": "modules/status-ui/public",
@@ -2253,15 +2253,6 @@
       "origin": "js-markup",
       "confidence": "certain"
     },
-    {
-      "id": "9fe51a2e1e71",
-      "surface": "builders-hall",
-      "text": "A {…} — you are a {…}. Mingle pairs across roles.",
-      "file": "modules/hall-ui/public/collab.js",
-      "line": 421,
-      "origin": "js-markup",
-      "confidence": "certain"
-    },
     {
       "id": "996edffc1966",
       "surface": "builders-hall",
@@ -3775,11 +3766,11 @@
       "confidence": "certain"
     },
     {
-      "id": "8a4b590fa1a0",
+      "id": "9912c3835136",
       "surface": "builders-hall",
-      "text": "Could not load requests.",
+      "text": "Could not load requests — reload to try again.",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 514,
+      "line": 529,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -7064,7 +7055,7 @@
       "surface": "builders-hall",
       "text": "Not now",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 421,
+      "line": 435,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8666,7 +8657,7 @@
       "surface": "builders-hall",
       "text": "Say yes",
       "file": "modules/hall-ui/public/collab.js",
-      "line": 421,
+      "line": 435,
       "origin": "js-markup",
       "confidence": "certain"
     },

package/docs/module-api-changelog.md

@@ -2280,5 +2280,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.901 with no explicit bump. run 35497860558. (task 1002620)
   1.19.903 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.902 with no explicit bump. run 35510679104. (task 1002620)
+  1.19.904 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.903 with no explicit bump. run 35511494246. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/hall-ui/public/collab-lib.js

@@ -313,6 +313,27 @@
     return req.needs_craft ? who + ' asked ' + req.needs_craft + 's' : who + ' asked';
   }
 
+  // "an engineer", "an artist", "an ideator" — but "a UI", which is why this cannot be a
+  // plain vowel test. roleWord() carries the same acronym exception one file over.
+  function aOrAn(word) {
+    const w = String(word || '');
+    if (/^ui$/i.test(w)) return 'a';
+    return /^[aeiou]/i.test(w) ? 'an' : 'a';
+  }
+
+  // The mingle row's sub-line (task 1003967, artist review of 1003960). Takes the two
+  // roles ALREADY RESOLVED to their sentence words, so this stays pure and the caller
+  // owns the vocabulary — and so this can be RUN in a test rather than grepped, which is
+  // the only way a swapped article gets caught. An empty side means the pair has a role
+  // nobody set: the comparison then has nothing to compare, so it is dropped rather than
+  // rendered with the database's own word in it.
+  function pairSentence(theirWord, myWord) {
+    if (!theirWord || !myWord) return 'Mingle pairs across roles.';
+    const lead = `${aOrAn(theirWord)} ${theirWord}`;
+    return `${lead.charAt(0).toUpperCase()}${lead.slice(1)} — you are ${aOrAn(myWord)} ${myWord}. `
+      + 'Mingle pairs across roles.';
+  }
+
   window.OTBCollabLib = {
     BANDS: BANDS, ageBand: ageBand, ageLabel: ageLabel,
     byAgeOldestFirst: byAgeOldestFirst, byNewestFirst: byNewestFirst,
@@ -320,5 +341,6 @@
     directionLine: directionLine, boardLine: boardLine,
     titleOf: titleOf, summaryOf: summaryOf, clipWords: clipWords, LEAD_MAX: LEAD_MAX, groupOf: groupOf,
     httpUrl: httpUrl, initialOf: initialOf, faceOf: faceOf, askers: askers, splitShown: splitShown,
+    aOrAn: aOrAn, pairSentence: pairSentence,
   };
 })();

package/modules/hall-ui/public/collab.js

@@ -418,11 +418,25 @@
     const whoName = o.name || o.login || `builder ${o.id}`;
     const who = escapeHtml(whoName);
     const face = { kind: 'person', id: o.id, name: whoName, avatar: null, initial: L.initialOf(whoName) };
+
+    // A SENTENCE TAKES roleWord() — the rule dom-utils.js writes down beside the helper
+    // (task 1004041). This row took neither helper and interpolated the raw column, so a
+    // pair whose role was unset rendered the database's own word: "A unclassified — you
+    // are a engineer", which is V2's named failure and a wrong article in the same line.
+    // Where a role is missing the comparison has nothing to compare, so the row says the
+    // one thing that is still true rather than naming a value nobody chose.
+    // roleIsUnset() is how a caller asks (dom-utils.js:198). Spelling 'unclassified' here
+    // would be a second definition of the axis in a third file — the drift V1 forbids, and
+    // the exact shape this review was filed to remove.
+    const theirs = window.OTB.roleIsUnset(o.craft) ? '' : window.OTB.roleWord(o.craft);
+    const mine = window.OTB.roleIsUnset(o.myCraft) ? '' : window.OTB.roleWord(o.myCraft);
+    const pairLine = L.pairSentence(theirs, mine);
+
     return `<li class="ov-row ov-row--lead cb-row">
       ${faceHtml(face)}
       <div class="ov-row__main">
         <a class="ov-row__title" href="/builders/profile?id=${escapeHtml(String(o.id))}">${who}</a>
-        <p class="ov-row__sub">A ${escapeHtml(String(o.craft))} — you are a ${escapeHtml(String(o.myCraft))}. Mingle pairs across roles.</p>
+        <p class="ov-row__sub">${escapeHtml(pairLine)}</p>
       </div>
       <div class="ov-row__right">
         <div class="ov-row__actions">
@@ -511,6 +525,7 @@
 
   load().catch(() => {
     const sub = $('#cb-sub');
-    if (sub) sub.textContent = 'Could not load requests.';
+    // V6: a message that stops someone points at the next move in the same breath.
+    if (sub) sub.textContent = 'Could not load requests — reload to try again.';
   });
 })();

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.903",
+  "version": "1.19.904",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.903",
+      "version": "1.19.904",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.903",
+  "version": "1.19.904",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.903'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.904'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/collab_page.mjs

@@ -421,6 +421,50 @@ test('the SIDEBAR badge: the Collab item declares the help_requests count', () =
   assert.match(fn, /href: '\/collab'/, 'pointing at the page, not the retired hash view');
 });
 
+// ---- THE MINGLE ROW SPEAKS THE ROLE ---------------------------------------
+// task 1003967 (artist review of 1003960). Run, not grepped: the first version of this
+// guard matched identifier names in the source, which would have agreed with a swapped
+// article just as happily as with a correct one. The sentence is pure, so execute it.
+
+test('the mingle sub-line reads as English for every pair, and never shows the column', () => {
+  const L = lib();
+  const OTB = domUtils();
+  const word = (d) => (OTB.roleIsUnset(d) ? '' : OTB.roleWord(d));
+  const line = (a, b) => L.pairSentence(word(a), word(b));
+
+  assert.equal(line('engineer', 'artist'), 'An engineer — you are an artist. Mingle pairs across roles.');
+  assert.equal(line('artist', 'ideator'), 'An artist — you are an ideator. Mingle pairs across roles.');
+
+  // 'ui' is the acronym exception roleWord() already makes, and it is why the article
+  // cannot be a plain vowel test — "an UI" is how that shortcut fails.
+  assert.equal(line('ui', 'engineer'), 'A UI — you are an engineer. Mingle pairs across roles.');
+  assert.equal(line('engineer', 'ui'), 'An engineer — you are a UI. Mingle pairs across roles.');
+});
+
+test('a pair with an unset role drops the comparison rather than naming the default', () => {
+  const L = lib();
+  const OTB = domUtils();
+  const word = (d) => (OTB.roleIsUnset(d) ? '' : OTB.roleWord(d));
+
+  // The defect this replaced rendered the database's own word — "A unclassified — you are
+  // a engineer" — which is the example V2 names. Nothing a person did not choose may reach
+  // the sentence, whichever side is missing.
+  for (const pair of [[OTB.ROLE_UNSET, 'engineer'], ['engineer', OTB.ROLE_UNSET], [null, 'artist'], ['', '']]) {
+    const out = L.pairSentence(word(pair[0]), word(pair[1]));
+    assert.equal(out, 'Mingle pairs across roles.', `pair ${JSON.stringify(pair)}`);
+    assert.doesNotMatch(out, /unclassified/);
+  }
+});
+
+test('aOrAn is the article rule, stated once', () => {
+  const L = lib();
+  assert.equal(L.aOrAn('engineer'), 'an');
+  assert.equal(L.aOrAn('artist'), 'an');
+  assert.equal(L.aOrAn('ideator'), 'an');
+  assert.equal(L.aOrAn('UI'), 'a', 'the acronym is spoken "you-eye", so it takes "a"');
+  assert.equal(L.aOrAn('ui'), 'a');
+});
+
 // ---- THE ANSWERABLE CLAUSE ------------------------------------------------
 test('the asker can settle in place, with both outcomes', () => {
   const js = read('modules', 'hall-ui', 'public', 'collab.js');