@bongos/core 1.19.880 → 1.19.881

package/modules/lifecycle/db-versions.js

@@ -23,7 +23,7 @@ const { createGoal } = require('./db-goals.js');
 
 async function listVersions() {
   const { rows } = await pool.query(
-    `SELECT id, name, track, status, scope_doc_path, started_at, shipped_at, done_when
+    `SELECT id, name, status, scope_doc_path, started_at, shipped_at, done_when
        FROM versions
        ORDER BY started_at`
   );
@@ -46,7 +46,7 @@ async function getVersion(id, deps = {}) {
     throw new Error('getVersion({ forUpdate }) requires deps.client — a row lock outside a transaction holds nothing');
   }
   const { rows } = await executorFor(deps, pool).query(
-    `SELECT id, name, track, status, scope_doc_path, started_at, shipped_at, done_when
+    `SELECT id, name, status, scope_doc_path, started_at, shipped_at, done_when
        FROM versions WHERE id = $1${deps.forUpdate ? ' FOR UPDATE' : ''}`,
     [id]
   );
@@ -167,10 +167,14 @@ async function versionsWithStatus(status, deps = {}) {
 // goal-less criteria, and ADR 0183 criteria satisfy themselves off LINKED tasks.
 // Criteria nobody can link a task to can never close. Stamping goal_id here is
 // what gives them something to hang from.
-async function createVersion({ id, name, status = 'planning', track = 'product', scopeDocPath = null, doneWhen = null, criteria = [], firstGoal = null, createdBy = null }, deps = {}) {
-  // versions.track is NOT NULL with no DB default (migration 003) — omitting it
-  // here made every create 500. An instance's first version is its product
-  // track, so that's the default; 'internal' is the platform's own track.
+async function createVersion({ id, name, status = 'planning', scopeDocPath = null, doneWhen = null, criteria = [], firstGoal = null, createdBy = null }, deps = {}) {
+  // No `track`: the two-track (product/internal) model was retired by task
+  // 1002006 and its code unwound by task 1003665. versions.track survives as a
+  // column, NOT NULL but carrying DEFAULT 'product' since core_205, so an INSERT
+  // that omits it is legal — which is what lets this path stop naming it. The
+  // comment that used to sit here said the column had NO default; that was true
+  // when it was written and stale by core_205, and believing it is why five
+  // insert paths kept supplying a value nobody read.
   //
   // deps.pool is the module's existing test seam (listVersions, versionProgress):
   // honoured ONLY under NODE_ENV=test, so production can never be pointed at an
@@ -179,10 +183,10 @@ async function createVersion({ id, name, status = 'planning', track = 'product',
   const txPool = (deps.pool && process.env.NODE_ENV === 'test') ? deps.pool : pool;
   return withTx(async (client) => {
     const { rows } = await client.query(
-      `INSERT INTO versions (id, name, status, track, scope_doc_path, done_when)
-            VALUES ($1, $2, $3, $4, $5, $6)
-       RETURNING id, name, status, track, scope_doc_path, started_at, shipped_at, done_when`,
-      [id, name, status, track, scopeDocPath, doneWhen]
+      `INSERT INTO versions (id, name, status, scope_doc_path, done_when)
+            VALUES ($1, $2, $3, $4, $5)
+       RETURNING id, name, status, scope_doc_path, started_at, shipped_at, done_when`,
+      [id, name, status, scopeDocPath, doneWhen]
     );
     const version = rows[0];
     // The first goal. Titled for the version it opens unless the caller names one —
@@ -340,7 +344,7 @@ async function promotePlanningVersion(exec) {
         SET status = 'building', started_at = COALESCE(started_at, now())
       WHERE id = (SELECT id FROM versions WHERE status = 'planning' ORDER BY id LIMIT 1)
         AND NOT EXISTS (SELECT 1 FROM versions WHERE status = 'building')
-      RETURNING id, name, track, status, started_at`
+      RETURNING id, name, status, started_at`
   );
   return rows[0] ?? null;
 }
@@ -352,7 +356,7 @@ async function closeVersion({ versionId, plan = [], reason, planningVersionId =
     await client.query('BEGIN');
 
     const { rows: vRows } = await client.query(
-      `SELECT id, name, track, status, scope_doc_path, started_at, shipped_at, done_when
+      `SELECT id, name, status, scope_doc_path, started_at, shipped_at, done_when
          FROM versions WHERE id = $1 FOR UPDATE`,
       [versionId]
     );
@@ -576,7 +580,7 @@ async function closeVersion({ versionId, plan = [], reason, planningVersionId =
     const { rows: closed } = await client.query(
       `UPDATE versions SET status = 'shipped', shipped_at = now()
         WHERE id = $1
-        RETURNING id, name, track, status, scope_doc_path, started_at, shipped_at, done_when`,
+        RETURNING id, name, status, scope_doc_path, started_at, shipped_at, done_when`,
       [versionId]
     );
 

package/modules/lifecycle/routes/versions.js

@@ -30,10 +30,6 @@ const { asyncHandler, validateOrRespond } = api;
 // 'building'; 'shipped'/'frozen' are end states reached via the close flow.
 const VALID_VERSION_STATUSES = new Set(['planning', 'building', 'shipped', 'frozen']);
 
-// versions.track CHECK (migration 003) — NOT NULL with no DB default, so the
-// create path must always supply one. 'product' is the caller-facing default:
-// an instance seeding its first version is seeding its product track.
-const VALID_VERSION_TRACKS = new Set(['product', 'internal']);
 
 module.exports = function buildVersionsRouter() {
   const router = express.Router();
@@ -99,7 +95,6 @@ module.exports = function buildVersionsRouter() {
       id: { required: true, type: 'string', maxLength: 64, minLength: 1 },
       name: { required: true, type: 'string', maxLength: 200, minLength: 1 },
       status: { type: 'string', maxLength: 32 },
-      track: { type: 'string', maxLength: 16 },
       done_when: { type: 'string', maxLength: 8000 },
       scope_doc_path: { type: 'string', maxLength: 256 },
       criteria: { type: 'array', maxItems: 100 },
@@ -116,11 +111,6 @@ module.exports = function buildVersionsRouter() {
       return res.fail('bad_status', 400, { valid: Array.from(VALID_VERSION_STATUSES) });
     }
 
-    const track = body.track || 'product';
-    if (!VALID_VERSION_TRACKS.has(track)) {
-      return res.fail('bad_track', 400, { valid: Array.from(VALID_VERSION_TRACKS) });
-    }
-
     if (await db.getVersion(id)) {
       return res.fail('version_exists', { status: 409, message: `Version '${id}' already exists.` });
     }
@@ -187,7 +177,7 @@ module.exports = function buildVersionsRouter() {
     let version, goal, created;
     try {
       ({ version, goal, criteria: created } = await db.createVersion({
-        id, name, status, track,
+        id, name, status,
         doneWhen: body.done_when ?? null,
         scopeDocPath: body.scope_doc_path ?? null,
         criteria,

package/modules/lifecycle/version-autoclose.js

@@ -65,7 +65,7 @@ async function autoCloseVersionIfComplete(exec, versionId) {
              AND g.status = 'open'
              AND ${NOT_MAINTENANCE}
         )
-      RETURNING v.id, v.name, v.track, v.status, v.shipped_at`,
+      RETURNING v.id, v.name, v.status, v.shipped_at`,
     [versionId]
   );
   return rows[0] ?? null;

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.880",
+  "version": "1.19.881",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.880",
+      "version": "1.19.881",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.880",
+  "version": "1.19.881",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/init.js

@@ -391,9 +391,6 @@ function versionPayload(spec) {
     id: v.id,
     name: v.name,
     status: v.status || 'building',
-    // versions.track is NOT NULL (no DB default) — always send it explicitly.
-    // An instance's first version is its product track unless the spec says otherwise.
-    track: v.track === 'internal' ? 'internal' : 'product',
     done_when: v.done_when,
     criteria: [{ criterion_id: v.criterion_id ? slugify(v.criterion_id) : 'first-goal', criterion_md: v.done_when }],
   };

package/scripts/gds/provision-repo.js

@@ -55,8 +55,9 @@ function migrateCmd(inst, { privileged = false } = {}) {
 // ONLY IF the versions table is empty: idempotent, safe to re-run, and it never
 // disturbs a project that already has versions. Mirrors seedViaApi's shape — V1
 // (status 'building') + one done-when criterion so /status has a finish line from day
-// one. `track` is set EXPLICITLY: versions.track is NOT NULL with no default (mig 112
-// dropped the CHECK), and 'product' matches the canonical V1 seed in 003_pms.sql.
+// one. No `track` column: the two-track model was retired (task 1002006, unwound
+// by task 1003665). The seed runs on a freshly-MIGRATED database, so core_205's
+// DEFAULT 'product' is in place and an INSERT that omits the column is legal.
 //
 // The id/name/done_when come from instanceInitSpec so the starter version has ONE
 // source of truth (the same spec the greenfield `bongos init` seed uses). SQL string
@@ -68,8 +69,8 @@ function seedFirstVersionCmd(inst, { privileged = false } = {}) {
   const v = instanceInitSpec(inst).version;
   const q = (s) => `$v$${s}$v$`;                 // dollar-quoted literal (no value contains a single quote or $)
   const sql =
-    `INSERT INTO versions (id, name, track, status, done_when) ` +
-    `SELECT ${q(v.id)}, ${q(v.name)}, $v$product$v$, $v$building$v$, ${q(v.done_when)} ` +
+    `INSERT INTO versions (id, name, status, done_when) ` +
+    `SELECT ${q(v.id)}, ${q(v.name)}, $v$building$v$, ${q(v.done_when)} ` +
     `WHERE NOT EXISTS (SELECT 1 FROM versions); ` +
     `INSERT INTO done_when_criteria (version_id, criterion_id, criterion_md, sort_order) ` +
     `SELECT ${q(v.id)}, $v$first-goal$v$, ${q(v.done_when)}, 10 ` +

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.880'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.881'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/init.mjs

@@ -204,16 +204,18 @@ test('versionPayload: explicit criterion_id is slugified', () => {
   assert.equal(init.versionPayload(spec).criteria[0].criterion_id, 'prove-the-loop');
 });
 
-// versions.track is NOT NULL with no DB default — leaving it off the payload is
-// exactly the 1.18.18 bug (every POST /versions 500ed, blocking init outright).
-test('versionPayload: always sends an explicit, valid track', () => {
-  assert.equal(init.versionPayload(fullSpec()).track, 'product'); // instance's first version = product
-  const internal = fullSpec();
-  internal.version.track = 'internal';
-  assert.equal(init.versionPayload(internal).track, 'internal');  // explicit internal respected
-  const junk = fullSpec();
-  junk.version.track = 'bogus';
-  assert.equal(init.versionPayload(junk).track, 'product');       // junk coerced, never forwarded
+// The inverse of the case this replaces. That case pinned "always send an
+// explicit track", guarding the 1.18.18 bug where omitting it 500ed every
+// POST /versions against a NOT NULL column with no default. core_205 gave the
+// column DEFAULT 'product' and task 1003665 retired the concept, so the payload
+// must now NOT carry it — and a spec that still names one must not smuggle it
+// through to a route that no longer accepts the field.
+test('versionPayload: sends no track, and drops one a spec still names', () => {
+  assert.equal('track' in init.versionPayload(fullSpec()), false);
+  const legacy = fullSpec();
+  legacy.version.track = 'internal';
+  assert.equal('track' in init.versionPayload(legacy), false,
+    'an old spec file cannot reintroduce the field');
 });
 
 // ---- provisioning arm (ADR 0111 §3, task 1946) ----
@@ -661,12 +663,13 @@ async function runSeedTests() {
     assert.ok(findTaskPost(api, /Production topology/), 'filed the manual fallback task on error');
   });
 
-  await at('seedViaApi: version POST carries the explicit track (the NOT NULL column)', async () => {
+  await at('seedViaApi: the version POST carries NO track (task 1003665)', async () => {
     const api = fakeApi();
     await init.seedViaApi(provSpec({}), { log: () => {}, api });
     const vpost = api.calls.find((c) => c.path.endsWith('/versions'));
     assert.ok(vpost, 'POSTed the version');
-    assert.equal(vpost.body.track, 'product');
+    assert.equal('track' in vpost.body, false,
+      'POST /versions no longer accepts the field; the DB default supplies the column');
   });
 
   await at('seedViaApi: the ideator kickoff task POSTs kind=decision + discipline=ideator', async () => {

package/tests/provision.mjs

@@ -59,16 +59,21 @@ t('dbCreateCmd / migrateCmd use the slug db + GDS-only migrate', () => {
   assert.match(P.migrateCmd(coTenant), /PGDATABASE=mercury MEDUSA_GDS_ONLY=1 \.\/scripts\/migrate\.sh/);
 });
 
-t('seedFirstVersionCmd: idempotent (only-if-empty) V1 seed against the slug db, track explicit, one criterion — the fix for the empty-versions bug (task 2119)', () => {
+t('seedFirstVersionCmd: idempotent (only-if-empty) V1 seed against the slug db, no track, one criterion — the fix for the empty-versions bug (task 2119)', () => {
   const cmd = P.seedFirstVersionCmd(coTenant);
   // targets the instance's OWN db, matching createdb/migrate
   assert.match(cmd, /psql .*-d mercury /, 'seeds the instance db');
   assert.match(cmd, /ON_ERROR_STOP=1/, 'aborts on any error (atomic, no half-seed)');
   // the version the greenfield init spec defines — ONE source of truth
   const v = P.instanceInitSpec(coTenant).version;
-  assert.match(cmd, /INSERT INTO versions \(id, name, track, status, done_when\)/);
+  assert.match(cmd, /INSERT INTO versions \(id, name, status, done_when\)/);
   assert.match(cmd, new RegExp(`\\$v\\$${reEsc(v.id)}\\$v\\$`), 'seeds the spec version id (V1)');
-  assert.match(cmd, /\$v\$product\$v\$/, 'track is set EXPLICITLY (versions.track is NOT NULL, no default since mig 112)');
+  // task 1003665 retired the two-track model. The seed names no track: it runs on
+  // a freshly-MIGRATED database, so core_205's DEFAULT 'product' fills the still-
+  // NOT NULL column. If that default is ever dropped, THIS seed 500s first and a
+  // new instance cannot stand up — which is why the assertion is stated that way.
+  assert.doesNotMatch(cmd, /\btrack\b/, 'the seed names no track column');
+  assert.doesNotMatch(cmd, /\$v\$product\$v\$/, 'nor smuggles its value in positionally');
   assert.match(cmd, /\$v\$building\$v\$/, 'status building, mirroring seedViaApi');
   assert.ok(cmd.includes(v.done_when), 'carries the spec done_when verbatim (incl. the → arrows)');
   // the IDEMPOTENT guard — only seeds when there is NO version yet, so it never disturbs an existing project

package/tests/version_first_goal.mjs

@@ -57,7 +57,9 @@ function fakeDb({ goalRow = { id: 77, title: 'Foundations' } } = {}) {
     query: async (sql, params) => {
       log.push({ sql, params });
       if (/^\s*(BEGIN|COMMIT|ROLLBACK)/i.test(sql)) return { rows: [] };
-      if (/INSERT INTO versions/i.test(sql)) return { rows: [{ id: params[0], name: params[1], status: params[2], track: params[3] }] };
+      // params are positional: (id, name, status, scope_doc_path, done_when).
+      // `track` sat at index 3 until task 1003665 removed it from the INSERT.
+      if (/INSERT INTO versions/i.test(sql)) return { rows: [{ id: params[0], name: params[1], status: params[2] }] };
       if (/INSERT INTO goals/i.test(sql)) return { rows: [goalRow] };
       if (/INSERT INTO done_when_criteria/i.test(sql)) {
         return { rows: [{ id: log.length, version_id: params[0], criterion_id: params[1], criterion_md: params[2], sort_order: params[3], goal_id: params[4], satisfied: false }] };
@@ -83,7 +85,7 @@ const CRITERIA = [
 console.log('createVersion — the version, its first goal, and its criteria:');
 
 const out = await createVersion({
-  id: 'V1', name: 'Foundations', status: 'building', track: 'product',
+  id: 'V1', name: 'Foundations', status: 'building',
   doneWhen: 'The loop closes.', criteria: CRITERIA, createdBy: 7,
 }, { pool: db.pool });
 

package/tests/versions_route.mjs

@@ -10,6 +10,7 @@
 
 import { strict as assert } from 'node:assert';
 import { createRequire } from 'node:module';
+import fs from 'node:fs';
 
 const require = createRequire(import.meta.url);
 const { validate } = require('../src/bongos/routes/_helpers.js');
@@ -23,12 +24,14 @@ function test(name, fn) {
 }
 
 // The EXACT schema declared in versions.js → POST /versions validateOrRespond().
-// Keep in sync if the route's schema changes.
+// Keep in sync if the route's schema changes — and note that "keep in sync" is a
+// promise a copy cannot keep on its own, so the track case below reads the
+// ROUTE SOURCE rather than this object. A copy that still declared `track` would
+// happily prove the old contract forever.
 const VERSIONS_POST_SCHEMA = {
   id: { required: true, type: 'string', maxLength: 64, minLength: 1 },
   name: { required: true, type: 'string', maxLength: 200, minLength: 1 },
   status: { type: 'string', maxLength: 32 },
-  track: { type: 'string', maxLength: 16 },
   done_when: { type: 'string', maxLength: 8000 },
   scope_doc_path: { type: 'string', maxLength: 256 },
   criteria: { type: 'array', maxItems: 100 },
@@ -75,18 +78,40 @@ test('INIT: unknown extra fields pass through (forward-compat)', () => {
   assert.equal(validate({ id: 'V1', name: 'x', future_field: 42 }, VERSIONS_POST_SCHEMA), null);
 });
 
-// versions.track is NOT NULL with no DB default (migration 003) — the create
-// path must accept it so callers can choose, and default it so omitting it can
-// never again 500 the route (the @bongos/core 1.18.18 `bongos init` blocker).
-test('INIT: explicit track passes the schema guard (both tracks)', () => {
-  assert.equal(validate({ id: 'V1', name: 'x', track: 'product' }, VERSIONS_POST_SCHEMA), null);
-  assert.equal(validate({ id: 'GDS-V5', name: 'x', track: 'internal' }, VERSIONS_POST_SCHEMA), null);
+// The two-track (product/internal) model was retired by task 1002006 and its code
+// unwound by task 1003665: role/discipline is the sole work-type axis. These read
+// the ROUTE'S OWN SOURCE, not the copied schema above — the point is that the
+// concept is gone from the file that enforces it.
+//
+// What made the removal safe, and what would make it unsafe again: versions.track
+// is still NOT NULL, so an INSERT omitting it is legal ONLY because core_205 gave
+// the column DEFAULT 'product'. Drop that default and every create 500s. The
+// comments this task deleted asserted the opposite ("no DB default") and were
+// stale from core_205 onward — which is precisely why five insert paths went on
+// supplying a value nothing read.
+const routeSrc = fs.readFileSync(
+  new URL('../modules/lifecycle/routes/versions.js', import.meta.url), 'utf8');
+
+test('the route no longer knows what a track is', () => {
+  for (const gone of ['VALID_VERSION_TRACKS', 'bad_track']) {
+    assert.ok(!routeSrc.includes(gone), `${gone} is gone from POST /versions`);
+  }
+  assert.ok(!/\btrack\b/.test(routeSrc.replace(/tracked|tracking/g, '')),
+    'no track identifier survives in the versions route');
 });
 
-test('BAD: non-string track → structured 400 shape, not a DB 500', () => {
-  const r = validate({ id: 'V1', name: 'x', track: 42 }, VERSIONS_POST_SCHEMA);
-  assert.ok(r);
-  assert.ok(r.details.some((d) => d.field === 'track'));
+test('a version is created WITHOUT a track, and that is the whole contract', () => {
+  // The create shape `bongos init` and provision-repo.js now send.
+  assert.equal(validate({ id: 'V1', name: 'x' }, VERSIONS_POST_SCHEMA), null);
+  assert.equal(validate({ id: 'GDS-V5', name: 'x', status: 'planning' }, VERSIONS_POST_SCHEMA), null);
+});
+
+test('the INSERT does not name the column either', () => {
+  const dbSrc = fs.readFileSync(
+    new URL('../modules/lifecycle/db-versions.js', import.meta.url), 'utf8');
+  const insert = dbSrc.slice(dbSrc.indexOf('INSERT INTO versions'));
+  assert.ok(!/^[^`]*\btrack\b/.test(insert.slice(0, insert.indexOf('`'))),
+    'INSERT INTO versions names no track column — the DB default supplies it');
 });
 
 // ---- BAD shapes must return a structured 400, never throw / 500 ----