@bongos/core 1.19.878 → 1.19.879

package/tests/hall_nav.mjs

@@ -287,7 +287,7 @@ test('sidebar groups read by audience, in order', () => {
   // 'deploy' (task 1003159, ADR 0293) is the SECOND archon item, beside 'government':
   // its gate is the `core.pin.move` atom, archon-floor and system:true. It sits with
   // the steering surfaces because that is what it is — the owner's third release gate.
-  assert.deepEqual(nav[4].items.map((i) => i.id), ['watch', 'harbor', 'gate', 'sessions', 'project-settings', 'deploy', 'government']);
+  assert.deepEqual(nav[4].items.map((i) => i.id), ['watch', 'gate', 'sessions', 'project-settings', 'deploy', 'government']);
 });
 
 test('Economy lives in Docs and points at the reward-schedule page', () => {

package/tests/hall_oversight_world.mjs

@@ -1,5 +1,5 @@
 // tests/hall_oversight_world.mjs — the oversight family in the chrome world
-// (task 1003469, goal 1000081): government, watch, harbor and gate share one
+// (task 1003469, goal 1000081): government, watch and gate share one
 // archetype sheet (oversight.css) the way the records share record.css and the
 // reading rooms room.css. These are static pins over the shipped source: the
 // family sheet is linked and spends only the fifteen, every page renders the
@@ -17,7 +17,7 @@ import { fileURLToPath } from 'node:url';
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
 const PUB = path.join(ROOT, 'modules', 'hall-ui', 'public');
 const read = (f) => fs.readFileSync(path.join(PUB, f), 'utf8').replace(/\r\n/g, '\n');
-const PAGES = ['government', 'watch', 'harbor', 'gate'];
+const PAGES = ['government', 'watch', 'gate'];
 
 test('every oversight page links the family sheet, before its own', () => {
   for (const p of PAGES) {
@@ -76,8 +76,8 @@ test('Government renders the rank description the create form collects', () => {
   assert.match(read('government.html'), /id="gov-create-desc"/, 'the form still collects it');
 });
 
-test('Harbor and Gate carry no coloured band: state is a pill', () => {
-  for (const p of ['harbor', 'gate']) {
+test('Gate carries no coloured band: state is a pill', () => {
+  for (const p of ['gate']) {
     assert.ok(!/__roof|__seal/.test(read(`${p}.js`)), `${p}.js emits no roof or seal band`);
     assert.ok(!/__roof|__seal/.test(read(`${p}.css`)), `${p}.css has no band rule`);
     assert.match(read(`${p}.js`), /fact-pill fact-pill--/, `${p}.js paints state as a .fact-pill`);
@@ -91,7 +91,7 @@ test('the shared confirm modal sits on --z-modal, closed by one hairline and no
   const modal = css.slice(css.indexOf('.ov-modal {'), css.indexOf('.ov-modal .scroll__h'));
   assert.ok(!/box-shadow/.test(modal), 'no shadow under the dialog');
   assert.match(modal, /border: var\(--line\) solid var\(--rule\)/, 'one rule hairline');
-  for (const p of ['harbor', 'gate']) {
+  for (const p of ['gate']) {
     assert.match(read(`${p}.js`), /className = 'ov-modal-bg'/, `${p}.js opens the family modal`);
     assert.ok(!/-modal-bg/.test(read(`${p}.css`)), `${p}.css no longer styles a modal of its own`);
   }

package/tests/hall_page_gate_map.mjs

@@ -44,7 +44,6 @@ const SRC = fs.readFileSync(path.join(ROOT, 'src/bongos/serve-internal.js'), 'ut
 const ORACLE = {
   // Any signed-in builder — no rank floor.
   '/builders/work': 'requireBuilderPage',
-  '/builders/pair': 'requireBuilderPage',
   '/builders/settings': 'requireBuilderPage',
   '/builders/atlas': 'requireBuilderPage',
   '/builders/modules': 'requireBuilderPage',
@@ -74,7 +73,6 @@ const ORACLE = {
 
   // Metic+ operator surfaces (the Governance nav group).
   '/builders/watch': 'requireGovernmentPage',
-  '/builders/harbor': 'requireGovernmentPage',
   '/builders/gate': 'requireGovernmentPage',
   '/builders/sessions': 'requireGovernmentPage',
   // The five fundamentals of the project (task 1003280, goal 1000072). Same tier as
@@ -155,6 +153,14 @@ const ORACLE = {
   // catch. GONE_PAGES below keeps the row honest if the file ever returns.
   '/builders/my-projects': null,
 
+  // Gone with the dev box (task 1003890, goal 1000091). Harbor was the Archon
+  // view of the box fleet and pair the device-pairing page; the fleet was turned
+  // off at the control plane by task 1003886, so both pages drove an API that no
+  // longer answers. Their gates left serve-internal.js with them — a gate in
+  // front of nothing is the dead-guard shape the check below exists to catch.
+  '/builders/harbor': null,
+  '/builders/pair': null,
+
   // Gone too, and for a reason worth keeping in front of the next reader: this
   // was a bespoke refusal PAGE ("not yet — ship three tasks to graduate"), the
   // deniedTo of the thetes+ gate. Task 1002613 replaced that whole idea with a
@@ -278,6 +284,9 @@ const GONE_PAGES = {
   '/builders/my-projects': 'task 1003308 — the hub owns "my projects"',
   // Task 1003450 — the shell's ?denied= banner replaced the bespoke refusal page.
   '/builders/not-ready': 'task 1003450 — the shell renders the refusal from ?denied=',
+  // Task 1003890 — the dev-box deprecation removed the fleet these two drove.
+  '/builders/harbor': 'task 1003890 — the dev box is gone, so its Archon view is too',
+  '/builders/pair': 'task 1003890 — the dev box is gone, so its pairing page is too',
 };
 
 test('a row that is null because the page left the hall serves no page', () => {

package/tests/hall_settings_world.mjs

@@ -1,5 +1,6 @@
 // tests/hall_settings_world.mjs — the PANEL family in the chrome world
-// (task 1003308, goal 1000081): settings, profile, pair.
+// (task 1003308, goal 1000081): settings and profile. Pair left with the dev
+// box (task 1003890).
 //
 // tests/hall_tokens.mjs pins the TIER these pages spend; this pins how they
 // spend it. Everything here is a fact that is silent in a browser: the page
@@ -9,9 +10,9 @@
 //
 // What it locks:
 //   * ONE ARCHETYPE SHEET. panel.css holds the row, the switch, the field, the
-//     chip control and the family's voices; the four page sheets hold only what
-//     one page has. Every page links panel.css BEFORE its own sheet.
-//   * THE ONE h1. None of the five had one — the hall predates the floor — so
+//     chip control and the family's voices; the page sheets hold only what one
+//     page has. Every page links panel.css BEFORE its own sheet.
+//   * THE ONE h1. None of them had one — the hall predates the floor — so
 //     every render failed one-header-main-h1. The h1 is the page's name in the
 //     room voice, and it lives in the static markup so the DOM has it in every
 //     state, not only the happy path.
@@ -26,14 +27,14 @@
 //   * WHITE ON THE ACCENT, AND THE ONE EXCEPTION. Eight literals across three
 //     sheets are gone; the Discord blurple pair stays, because it is Discord's
 //     mark and not the world's, and it is named as the exception in a comment.
-//   * THE COMPAT ALIASES. Five sheets, zero aliases spent.
+//   * THE COMPAT ALIASES. Every sheet in the family, zero aliases spent.
 //
 // Reproduce the renders these came from (the family needs the fixture harness —
 // every panel is filled from /me/* reads the kit stub does not carry):
 //   node scripts/hall-preview/server.js --port 4621 --fixture-me
 //   node modules/ui-design/kit/render.js --states modules/hall-ui/public/settings.states.json \
 //     --base-in http://builders.localhost:4621 --base-out http://builders.localhost:4621
-//   (and profile / pair .states.json the same way)
+//   (and profile .states.json the same way)
 
 import { test } from 'node:test';
 import assert from 'node:assert/strict';
@@ -48,9 +49,10 @@ const stripComments = (css) => css.replace(/\/\*[\s\S]*?\*\//g, '');
 
 // not-ready was the fourth until task 1003450 deleted the page — see
 // tests/hall_page_gate_map.mjs (GONE_PAGES) for why, and for the row that stops
-// it coming back ungated. The archetype is unaffected: three pages still spend it.
-const PAGES = ['settings', 'profile', 'pair'];
-const SHEETS = ['panel.css', 'settings.css', 'pair.css', 'profile.css'];
+// it coming back ungated; pair left the same way in task 1003890. The archetype
+// is unaffected: the pages that remain still spend it.
+const PAGES = ['settings', 'profile'];
+const SHEETS = ['panel.css', 'settings.css', 'profile.css'];
 
 const panelCss = read('panel.css');
 const settingsCss = read('settings.css');
@@ -94,7 +96,7 @@ test('the archetype holds the row, the switch, the field and the voices; the pag
   for (const sel of ['.prow', '.sw', '.sw__track', '.sw__knob', '.field-label', '.pinput', '.chip-ctl', '.panel-note', '.panel-status', '.gate']) {
     assert.ok(ruleOf(panelCss, sel), `panel.css defines ${sel}`);
   }
-  for (const sheet of ['settings.css', 'pair.css', 'profile.css']) {
+  for (const sheet of ['settings.css', 'profile.css']) {
     const css = read(sheet);
     for (const sel of ['.prow', '.sw', '.sw__track', '.pinput', '.chip-ctl']) {
       assert.equal(ruleOf(css, sel), null, `${sheet} must not redefine ${sel} — that is how the family would drift`);
@@ -104,7 +106,7 @@ test('the archetype holds the row, the switch, the field and the voices; the pag
 
 // ---- 2. the one h1, in the static markup ----------------------------------
 
-test('each of the five pages has exactly one h1, in the family\'s page head', () => {
+test('each page in the family has exactly one h1, in the family\'s page head', () => {
   for (const p of PAGES) {
     const html = read(`${p}.html`).replace(/<!--[\s\S]*?-->/g, '');
     const h1s = html.match(/<h1\b/g) || [];
@@ -301,7 +303,7 @@ test('no sheet in the family spends a compat alias', () => {
 });
 
 test('white on the accent is gone, and the Discord mark is the one named exception', () => {
-  for (const sheet of ['panel.css', 'pair.css', 'profile.css']) {
+  for (const sheet of ['panel.css', 'profile.css']) {
     const bare = stripComments(read(sheet));
     assert.doesNotMatch(bare, /#[0-9a-f]{3,8}\b/i, `${sheet} carries no colour literal`);
     assert.doesNotMatch(bare, /:\s*white\b/i, `${sheet} carries no named white`);
@@ -318,16 +320,17 @@ test('white on the accent is gone, and the Discord mark is the one named excepti
     assert.match(selector, /\.settings-btn--discord/, `${lit} is spent only on the Discord button`);
   }
   assert.match(settingsCss, /THIRD-PARTY MARK, KEPT ON PURPOSE/, 'the exception is named in a comment so a literal sweep leaves it alone');
-  // the save/accent buttons take --accent-on. `.pair-approve` and `.craft-save`
-  // are members of the base pill rule AND the save rule, so the save rule is
-  // found by its own name and the two are asserted as its members.
+  // the save/accent buttons take --accent-on. `.craft-save` is a member of the
+  // base pill rule AND the save rule, so the save rule is found by its own name
+  // and the member is asserted against it. (`.pair-approve` was its sibling here
+  // until task 1003890 removed the pair page.)
   const save = ruleOf(panelCss, '.pbtn--save');
   assert.ok(save, '.pbtn--save has a rule');
   assert.match(save, /background:\s*var\(--accent\)/);
   assert.match(save, /color:\s*var\(--accent-on\)/, 'the dark ink for the salmon — white on it fails AA');
   const saveSelector = stripComments(panelCss).match(/([^{}]*\.pbtn--save[^{}]*)\{/);
   assert.ok(saveSelector, 'the save rule\'s selector list is readable');
-  for (const member of ['.craft-save', '.pair-approve']) {
+  for (const member of ['.craft-save']) {
     assert.ok(saveSelector[1].split(',').map((s) => s.trim()).includes(member), `${member} is the accent door on its page`);
   }
 });
@@ -394,14 +397,14 @@ test('the profile identity band is a MODIFIER on the shell\'s .profile, never a
 
 // ---- 6. the floors are reproducible ------------------------------------------
 
-test('all five pages have a states file, so the floors are reproducible', () => {
+test('every page in the family has a states file, so the floors are reproducible', () => {
   for (const p of PAGES) {
     const json = JSON.parse(read(`${p}.states.json`));
     assert.equal(json.surface, 'hall-ui', `${p}.states.json names its surface`);
     assert.ok(Object.keys(json.states).length >= 2, `${p}.states.json renders more than the default state`);
   }
   assert.ok(Object.keys(JSON.parse(read('settings.states.json')).states).length >= 4, 'settings renders every rail group');
-  for (const fx of ['me__sessions', 'auth__app-pair__info']) {
+  for (const fx of ['me__sessions']) {
     assert.ok(fs.existsSync(path.join(ROOT, 'scripts', 'hall-preview', 'fixtures', `${fx}.json`)),
       `the harness serves ${fx} — without it the page only ever rendered its empty state`);
   }