@bongos/core 1.19.873 → 1.19.875

package/tests/deploy_page_projects.mjs

@@ -0,0 +1,193 @@
+// tests/deploy_page_projects.mjs — the deploy page now drives every hosted project,
+// not only the control plane's own row (task 1004046).
+//
+// These EXECUTE deploy.js in a DOM stub and read what it painted. The sibling suite
+// (core_upgrade_door.mjs) asserts the page's invariants against its SOURCE, which is
+// right for "never computes a version comparison" but cannot see the thing that broke
+// when this page went multi-box: whether a click on one box arms that box and not
+// another. That is behaviour, so it is tested as behaviour.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/deploy.js'), 'utf8');
+
+const preview = (id, slug, over = {}) => ({
+  instance_id: id, slug, hosting_shape: 'standalone',
+  served_version: '1.19.800', recommended_version: '1.19.871',
+  behind: true, reading: 'ok', observed_at: new Date().toISOString(), open_intent: null,
+  ...over,
+});
+
+// The fleet as the control plane really reports it: mostly torn down, a couple live.
+const FLEET = [
+  { id: '31', slug: 'mercury', status: 'active', hosting_shape: 'standalone' },
+  { id: '32', slug: 'hoodify-finance', status: 'active', hosting_shape: 'co-tenant' },
+  { id: '33', slug: 'walk-lantern', status: 'torn_down', hosting_shape: 'standalone' },
+  { id: '34', slug: 'testccc', status: 'torn_down', hosting_shape: 'standalone' },
+  { id: '35', slug: 'unreadable-one', status: 'active', hosting_shape: 'standalone' },
+];
+
+function boot({ controlPlane = preview('1', 'cloudbongos'), controlPlaneStatus = 200, fleet = FLEET, fleetStatus = 200 } = {}) {
+  const els = new Map();
+  const posts = [];
+  const gets = [];
+  const makeEl = () => ({
+    _on: {}, _html: '', hidden: false, textContent: '', disabled: false,
+    addEventListener(ev, fn) { this._on[ev] = fn; },
+    set innerHTML(v) { this._html = String(v); }, get innerHTML() { return this._html; },
+  });
+  const documentObj = {
+    getElementById(id) { if (!els.has(id)) els.set(id, makeEl()); return els.get(id); },
+    addEventListener(ev, fn) { if (ev === 'DOMContentLoaded') this._ready = fn; },
+  };
+  const request = async (method, url, opts) => {
+    const p = url.replace('/api/bongos', '');
+    if (method === 'GET') gets.push(p);
+    if (method === 'POST') { posts.push({ path: p, body: opts && opts.body }); return { ok: true, status: 200, data: { message: 'Queued.' } }; }
+    if (p === '/provisioning/control-plane') {
+      if (controlPlaneStatus !== 200) {
+        return { ok: false, status: controlPlaneStatus, data: { error: { code: 'control_plane_not_enrolled', message: 'This platform has no deploy door yet. Run enroll-control-plane.js once.' } } };
+      }
+      return { ok: true, status: 200, data: { preview: controlPlane } };
+    }
+    if (p === '/provisioning/fleet') {
+      if (fleetStatus !== 200) return { ok: false, status: fleetStatus, data: { error: { code: 'forbidden' } } };
+      return { ok: true, status: 200, data: { instances: fleet } };
+    }
+    if (p === '/provisioning/instances') return { ok: true, status: 200, data: { instances: fleet } };
+    const m = /^\/provisioning\/instances\/(\w+)\/core-upgrade$/.exec(p);
+    if (m) {
+      const inst = fleet.find((f) => f.id === m[1]);
+      if (!inst || inst.slug === 'unreadable-one') {
+        return { ok: false, status: 500, data: { error: { code: 'core_upgrade_preview_failed', message: 'internal error' } } };
+      }
+      return { ok: true, status: 200, data: { preview: preview(inst.id, inst.slug, { hosting_shape: inst.hosting_shape }) } };
+    }
+    return { ok: false, status: 404, data: { error: { code: 'not_found' } } };
+  };
+  const windowObj = {
+    BongosClient: { createClient: () => ({ request }) },
+    OTB: { escapeHtml: (s) => String(s).replace(/[&<>"]/g, (c) => ({ '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;' }[c])), toast() {} },
+    location: { assign() {} },
+  };
+  const sandbox = { window: windowObj, document: documentObj, console, setTimeout, clearTimeout, queueMicrotask, Date, Set, Map, Promise };
+  sandbox.globalThis = sandbox;
+  vm.createContext(sandbox);
+  vm.runInContext(SRC, sandbox, { filename: 'deploy.js' });
+  documentObj._ready();
+  const settle = async () => { for (let i = 0; i < 12; i++) await new Promise((r) => setTimeout(r, 0)); };
+  return { els, posts, gets, settle, panel: () => els.get('dp-panel').innerHTML, sub: () => els.get('dp-sub').textContent };
+}
+
+test('the platform AND every live hosted project get a row', async () => {
+  const b = boot();
+  await b.settle();
+  const html = b.panel();
+  assert.match(html, /cloudbongos/, 'the platform is still here');
+  assert.match(html, /mercury/, 'a standalone project');
+  assert.match(html, /hoodify-finance/, 'a co-tenant project');
+  assert.match(b.sub(), /3 hosted projects/);
+});
+
+test('torn-down projects never appear — the page is about what is live', async () => {
+  const b = boot();
+  await b.settle();
+  const html = b.panel();
+  assert.doesNotMatch(html, /walk-lantern/);
+  assert.doesNotMatch(html, /testccc/);
+});
+
+test('a project whose state cannot be read is LISTED, not silently dropped', async () => {
+  // A box missing from a deploy page reads as a box that needs no deploying.
+  const b = boot();
+  await b.settle();
+  assert.match(b.panel(), /unreadable-one/);
+  assert.match(b.panel(), /Could not read this project/);
+});
+
+test('opening the confirm on one project does not arm another', async () => {
+  const b = boot();
+  await b.settle();
+  b.els.get('dp-preview-31')._on.click();
+  const html = b.panel();
+  assert.match(html, /id="dp-confirm-31"/, 'mercury is armed');
+  assert.doesNotMatch(html, /id="dp-confirm-32"/, 'hoodify-finance is NOT');
+  assert.match(html, /id="dp-preview-32"/, 'and is still at step one');
+});
+
+test('confirming sends THAT project’s id and the version it was shown', async () => {
+  const b = boot();
+  await b.settle();
+  b.els.get('dp-preview-32')._on.click();
+  b.els.get('dp-confirm-32')._on.click();
+  await b.settle();
+  assert.equal(b.posts.length, 1);
+  assert.equal(b.posts[0].path, '/provisioning/instances/32/core-upgrade');
+  // Field-wise, not deepEqual: the body is built inside the vm realm, so its
+  // prototype is not this realm's Object and deepStrictEqual rejects it on identity
+  // alone — a harness artifact that says nothing about the payload.
+  assert.equal(b.posts[0].body.to, '1.19.871');
+  assert.deepEqual(Object.keys(b.posts[0].body), ['to'], 'and nothing else is sent');
+});
+
+test('a box with nothing newer offers no button', async () => {
+  const b = boot({ controlPlane: preview('1', 'cloudbongos', { behind: false, recommended_version: null }) });
+  await b.settle();
+  assert.match(b.panel(), /There is nothing to deploy/);
+});
+
+test('a box that did not answer is never rendered as up to date', async () => {
+  const b = boot({ controlPlane: preview('1', 'cloudbongos', { reading: 'no_answer', served_version: null, behind: false }) });
+  await b.settle();
+  const html = b.panel();
+  assert.match(html, /unknown rather than unchanged/);
+  assert.doesNotMatch(html, /id="dp-preview-1"/, 'and is offered no move');
+});
+
+test('an unenrolled control plane still lets the projects through', async () => {
+  // The regression this pins: the platform's own missing row used to be the whole
+  // page, so one un-run setup command would hide every project too.
+  const b = boot({ controlPlaneStatus: 404 });
+  await b.settle();
+  const html = b.panel();
+  assert.match(html, /has no deploy door yet/, 'the server’s own sentence, naming the fix');
+  assert.match(html, /mercury/, 'and the projects are still listed');
+});
+
+test('a viewer without the fleet atom falls back to their own projects', async () => {
+  const b = boot({ fleetStatus: 403 });
+  await b.settle();
+  assert.match(b.panel(), /mercury/);
+});
+
+test('a move re-reads ONLY the box it moved, not every project again', async () => {
+  // The grader's finding on the first round: refreshing one row by re-running the
+  // whole page load fans a probe out at every hosted project, including ones the
+  // owner never touched.
+  const b = boot();
+  await b.settle();
+  b.gets.length = 0;
+  b.els.get('dp-preview-32')._on.click();
+  b.els.get('dp-confirm-32')._on.click();
+  await b.settle();
+  const previewReads = b.gets.filter((g) => g.endsWith('/core-upgrade'));
+  assert.deepEqual(previewReads, ['/provisioning/instances/32/core-upgrade'],
+    'exactly one preview re-read, and it is the moved box');
+  assert.ok(!b.gets.includes('/provisioning/fleet'), 'the fleet is not re-listed');
+});
+
+test('a move on the platform row re-reads the control plane, not a tenant preview', async () => {
+  const b = boot();
+  await b.settle();
+  b.gets.length = 0;
+  b.els.get('dp-preview-1')._on.click();
+  b.els.get('dp-confirm-1')._on.click();
+  await b.settle();
+  assert.ok(b.gets.includes('/provisioning/control-plane'), 'the self row is read from its own endpoint');
+  assert.ok(!b.gets.some((g) => /instances\/3\d\/core-upgrade/.test(g)), 'and no tenant is re-probed');
+});