@bongos/core 1.19.871 → 1.19.872

package/modules/hall-ui/public/blockers.js

@@ -1,5 +1,5 @@
-// blockers.js — the Blockers page: the full open-blocker queue, and now (task
-// 1003456, goal 1000089) the write half — file, resolve, link.
+// blockers.js — the Blockers page: the full open-blocker queue, the write half
+// (task 1003456, goal 1000089), and server-offset paging (task 1003983).
 //
 // GET /blockers (modules/ideas/routes/blockers.js) is PUBLIC and had ZERO hall
 // consumers before task 1003455 — the only blocker a builder could ever see was
@@ -30,6 +30,21 @@
 // public, the roster/drachmae precedent: a page must not be gated tighter than
 // the API it fronts. A signed-out visitor sees the queue and the File button;
 // clicking it redirects to sign-in, same as every other hall write.
+//
+// SERVER-OFFSET PAGING (task 1003983): this used to fetch the whole queue at
+// the max page size once and slice it client-side, which silently truncated
+// past 200 open blockers and undercounted the headline pill from that same
+// truncated array. It now asks the server for one page at a time via the
+// kit's serverPager primitives (hall-ui/CLAUDE.md, the profile activity-log /
+// session-ledger precedent), hand-wired rather than `makeLedger` because
+// these rows are `.ov-row` `<li>`s, not a `<table>` — the same reason
+// sessions.js wires them by hand, and this file keeps its two behaviours:
+// every control dead while a fetch is in flight, and a failed fetch rolls
+// the pager back to the last page that actually painted. `reload()` (fired
+// after a file/resolve/link write, and by the overlay's
+// `otb:blocker-resolved` event) re-fetches the CURRENT server page rather
+// than the whole queue — the total and which rows belong on this page can
+// both have moved.
 (function () {
   'use strict';
   var kit = window.OTBKit;
@@ -83,7 +98,6 @@
   };
   var blockerHref = function (id) { return '#/blocker/' + encodeURIComponent(id); };
 
-  var all = [];
   // Which rank a reviewer action (Resolve / Link) needs — mirrors the server's
   // blocker.review floor (metic+archon), cosmetically only; the server holds
   // the actual gate regardless of what this variable says.
@@ -148,47 +162,136 @@
   }
 
   var pager = kit.makePager('blockers', 'hall-blockers-per-page', { defaultPerPage: 25 });
-  var listEl = null;
-
-  function rerender() {
-    var slice = kit.paginate(all, pager);
-    listEl.innerHTML = slice.length
-      ? slice.map(rowHtml).join('')
-      : kit.emptyStateHtml('Nothing is stuck on the owner right now.');
-  }
+  // `total`/`shown` are the server's own count of the whole open set and how
+  // many rows the last fetch actually returned — the headline pill and the
+  // pager bar both read off these, never off a held array's length.
+  // `page`/`perPage` are the last values that actually PAINTED: the kit moves
+  // the pager first and calls back second, so a failed fetch has to put it
+  // back to these, the sessions.js contract — otherwise the bar goes on
+  // claiming a page whose rows never arrived.
+  var state = { total: 0, shown: 0, page: pager.page, perPage: pager.perPage };
+  // Nothing has painted yet on the very first load, so a failure there has no
+  // prior page to roll back to or keep on screen — that one case still falls
+  // through to notice()'s full-body replacement.
+  var painted = false;
+  var loading = false;
+  // Two page clicks (or a slow first load racing a fast second one) can be in
+  // flight at once; only the newest may paint (the profile activity-log idiom).
+  var inFlight = 0;
+  // The rows currently on screen — kept ONLY so a purely local state change
+  // (a row's action form opening/closing, the viewer's rank arriving) can
+  // repaint without asking the server again. Never sliced or paged from here.
+  var lastRows = [];
 
-  function reload() {
-    return fetchBlockers().catch(function () { toast('Couldn’t refresh the queue — try reloading the page.'); });
+  function renderPager() {
+    var clamped = kit.renderServerPage(pager, state.total, state.shown);
+    // The per-page control has no bounds of its own, so it tracks `loading`
+    // directly both ways. Prev/Next re-enabling is left to the kit, which
+    // knows whether there is a page on either side — only the DISABLING past
+    // that is ours.
+    var perPage = document.getElementById(pager.prefix + '-per-page');
+    if (perPage) perPage.disabled = loading;
+    if (loading) {
+      var prev = document.getElementById(pager.prefix + '-prev');
+      var next = document.getElementById(pager.prefix + '-next');
+      if (prev) prev.disabled = true;
+      if (next) next.disabled = true;
+    }
+    return clamped;
   }
 
-  function mountBlockers(rows) {
-    all = Array.isArray(rows) ? rows : [];
-    if (countPill) { countPill.textContent = String(all.length); countPill.hidden = all.length === 0; }
+  function paintHeadline() {
+    if (countPill) { countPill.textContent = String(state.total); countPill.hidden = state.total === 0; }
     if (sub) {
-      sub.textContent = all.length
-        ? (all.length === 1 ? 'One thing' : all.length + ' things') + ' stuck on the owner — a credential, a '
+      sub.textContent = state.total
+        ? (state.total === 1 ? 'One thing' : state.total + ' things') + ' stuck on the owner — a credential, a '
           + 'purchase, a product call only they can make. Resolving one un-sticks every task waiting on it automatically.'
         : 'Nothing is stuck on the owner right now.';
     }
-    body.innerHTML = '<ul class="ov-rows" id="blockers-list"></ul>' + kit.pagerBarHtml(pager.prefix, { label: 'blockers' });
-    listEl = document.getElementById('blockers-list');
-    kit.wirePager(pager, rerender);
-    rerender();
   }
 
-  function notice(msg) {
-    body.innerHTML = '';
-    body.className = 'note';
-    body.textContent = msg;
+  function renderList(rows) {
+    var listEl = document.getElementById('blockers-list');
+    if (!listEl) return;
+    listEl.innerHTML = rows.length
+      ? rows.map(rowHtml).join('')
+      : kit.emptyStateHtml('Nothing is stuck on the owner right now.');
   }
 
-  function fetchBlockers() {
-    return fetch(API + '/blockers?limit=200', { headers: { Accept: 'application/json' } })
+  // Repaint the rows already on screen — no server call. Used when only local
+  // UI state changed (a row's Resolve/Link form opened or closed, or the
+  // viewer's rank just arrived and rowHtml() needs to reconsider isReviewer()).
+  function rerender() { renderList(lastRows); }
+
+  // Fetch the page the pager currently points at. `reclamped` guards against a
+  // shrinking queue looping forever — one re-ask, never a spin.
+  function fetchPage(reclamped) {
+    var seq = ++inFlight;
+    loading = true;
+    renderPager();
+    var url = API + '/blockers?limit=' + encodeURIComponent(String(Number(pager.perPage) || 0))
+      + '&offset=' + encodeURIComponent(String(kit.pageOffset(pager)));
+    return fetch(url, { headers: { Accept: 'application/json' } })
       .then(function (r) {
         if (!r.ok) throw new Error('http ' + r.status);
         return r.json();
       })
-      .then(function (data) { mountBlockers(data && data.blockers); });
+      .then(function (data) {
+        if (seq !== inFlight) return;
+        var rows = (data && Array.isArray(data.blockers)) ? data.blockers : [];
+        state.total = (data && data.page && Number.isFinite(data.page.total)) ? data.page.total : rows.length;
+        state.shown = rows.length;
+        lastRows = rows;
+        renderList(rows);
+        paintHeadline();
+        painted = true;
+        loading = false;
+        var clamped = renderPager();
+        // The page that just painted is now the one to roll back to if a
+        // LATER page-turn fails.
+        state.page = pager.page;
+        state.perPage = pager.perPage;
+        // The queue shrank under an open page (a blocker got resolved between
+        // loads) — the kit already pulled the page back into range, so go get
+        // the rows that page actually holds rather than leaving a range that
+        // disagrees with the list.
+        if (clamped && !reclamped) return fetchPage(true);
+      })
+      .catch(function () {
+        if (seq !== inFlight) return;
+        loading = false;
+        // Put the pager back to the last page that actually painted — the kit
+        // already moved it forward before this call ran, so left alone the
+        // bar would go on claiming a page whose rows never arrived.
+        pager.page = state.page;
+        pager.perPage = state.perPage;
+        if (!painted) {
+          notice('Couldn’t load the blocker queue right now.');
+          return;
+        }
+        renderPager();
+        if (window.OTB && typeof window.OTB.toast === 'function') {
+          window.OTB.toast('Could not load that page. Try again.');
+        }
+      });
+  }
+
+  // Re-fetch the CURRENT server page — after a file/resolve/link write (the
+  // total and which rows belong on this page can both have moved) and on the
+  // overlay's `otb:blocker-resolved` event.
+  function reload() {
+    return fetchPage().catch(function () { toast('Couldn’t refresh the queue — try reloading the page.'); });
+  }
+
+  function mountShell() {
+    body.innerHTML = '<ul class="ov-rows" id="blockers-list"></ul>' + kit.pagerBarHtml(pager.prefix, { label: 'blockers' });
+    kit.wirePager(pager, function () { fetchPage(); });
+  }
+
+  function notice(msg) {
+    body.innerHTML = '';
+    body.className = 'note';
+    body.textContent = msg;
   }
 
   // ---- filing (any signed-in builder) ----------------------------------------
@@ -330,6 +433,9 @@
     } catch (_) { /* signed out or offline — viewer stays { rank: null }, isReviewer() false */ }
   }
 
+  mountShell();
+  fetchPage();
+
   loadViewer().then(function () {
     if (fileArea) { fileArea.innerHTML = fileFormHtml(); wireFileForm(); }
     // Boot race: GET /me and GET /blockers fire together, and rowHtml() reads
@@ -338,14 +444,12 @@
     // with isReviewer() still false and nothing re-draws it once the real
     // rank lands — a Metic/Archon would see no Resolve/Link buttons until an
     // unrelated re-render (a pager click, a file, an otb:blocker-resolved).
-    // Re-render now that the viewer is known, but only if the list actually
-    // exists yet (fetchBlockers may still be in flight — it will render
+    // Re-render now that the viewer is known, but only if a page has actually
+    // painted yet (fetchPage may still be in flight — it will render
     // correctly on its own the moment it resolves).
-    if (listEl) rerender();
+    if (painted) rerender();
   });
 
-  fetchBlockers().catch(function () { notice('Couldn’t load the blocker queue right now.'); });
-
   // A row's title opens the #/blocker/N overlay ON TOP of this page
   // (task-detail.js), whose own Resolve panel fires this — refresh the queue
   // in place rather than leaving a resolved row sitting there.

package/modules/hall-ui/public/builders.js

@@ -457,7 +457,8 @@
       }
       if (resp.onboarding) renderOnboarding(resp.onboarding, lastMeState && lastMeState.discord);
       if (resp.builder) renderProfile(resp.builder);
-      toast(selected.length ? `Craft: ${selected.join(', ')}.` : 'Craft cleared.');
+      const axis = window.OTB.roleAxisLabel();
+      toast(selected.length ? `${axis}: ${selected.map((d) => window.OTB.roleLabel(d)).join(', ')}.` : `${axis} cleared.`);
     } catch (err) {
       if (err && err.message === 'redirecting to auth') return;
       console.error('[builders] pick discipline failed', err);

package/modules/hall-ui/public/collab.html

@@ -43,7 +43,7 @@
             </div>
             <ul class="ov-rows" id="cb-for-me"></ul>
             <div class="empty-state cb-empty" id="cb-for-me-empty" hidden>
-              <p>Nobody is waiting on you. Requests reach you by craft —
+              <p>Nobody is waiting on you. Requests reach you by role —
               <a href="/builders/settings">set yours in Settings</a>.</p>
             </div>
             <button class="btn-ghost cb-more" id="cb-for-me-more" type="button" aria-expanded="false" aria-controls="cb-for-me" hidden></button>
@@ -77,7 +77,7 @@
              changes, it does not gain a destination. -->
         <section class="scroll cb-block" id="cb-mingle-section" aria-labelledby="cb-mingle-h" hidden>
           <h2 class="scroll__h" id="cb-mingle-h">Introductions</h2>
-          <p class="scroll__lede" id="cb-mingle-note">Mingle pairs you with someone from another craft. Saying no costs nothing.</p>
+          <p class="scroll__lede" id="cb-mingle-note">Mingle pairs you with someone from another role. Saying no costs nothing.</p>
           <ul class="ov-rows" id="cb-mingle"></ul>
           <div class="empty-state cb-empty" id="cb-mingle-empty" hidden>
             <p>No introductions right now. One appears here when a pairing round runs.</p>

package/modules/hall-ui/public/collab.js

@@ -329,9 +329,12 @@
 
     const sub = $('#cb-sub');
     if (sub) {
+      // task 1003936: the axis word comes from OTB.roleAxisLabel(), never typed.
+      // The VALUES are named through roleLabel() for the same reason the filters are.
+      const axis = window.OTB.roleAxisLabel().toLowerCase();
       sub.textContent = crafts.length
-        ? `Builders asking builders. Asks to ${crafts.join(', ')}s, and to you by name, land in your block.`
-        : 'Builders asking builders. With no craft set, only asks addressed to you by name land in your block.';
+        ? `Builders asking builders. Asks to ${crafts.map((c) => `${window.OTB.roleLabel(c)}s`).join(', ')}, and to you by name, land in your block.`
+        : `Builders asking builders. With no ${axis} set, only asks addressed to you by name land in your block.`;
     }
 
     // The social half. Best-effort and LAST: an introductions read that fails
@@ -366,7 +369,7 @@
       ${faceHtml(face)}
       <div class="ov-row__main">
         <a class="ov-row__title" href="/builders/profile?id=${escapeHtml(String(o.id))}">${who}</a>
-        <p class="ov-row__sub">A ${escapeHtml(String(o.craft))} — you are a ${escapeHtml(String(o.myCraft))}. Mingle pairs across crafts.</p>
+        <p class="ov-row__sub">A ${escapeHtml(String(o.craft))} — you are a ${escapeHtml(String(o.myCraft))}. Mingle pairs across roles.</p>
       </div>
       <div class="ov-row__right">
         <div class="ov-row__actions">

package/modules/hall-ui/public/dom-utils.js

@@ -155,21 +155,60 @@
   }
 
   // How a kind is named in a picker — 'blocker-resolution' → 'Blocker resolution'.
-  // The same shape disciplineLabel takes below, and it reproduces every label the
+  // The same shape roleLabel takes below, and it reproduces every label the
   // hand-written <option> list in ideas.html carried, so no copy changes.
   function kindLabel(k) {
     const s = String(k || '').replace(/-/g, ' ');
     return s ? s.charAt(0).toUpperCase() + s.slice(1) : '';
   }
 
-  // How a craft is named in a picker. An acronym stays upper-case ('ui' → 'UI');
-  // anything else is Title Case, so a craft a module adds later needs no new entry.
-  function disciplineLabel(d) {
+  // THE ONE USER-FACING WORD FOR THE tasks.discipline AXIS (task 1003936).
+  // Before this the hall shipped four words for one axis: Discipline on the Tasks
+  // board, Discipline AND Craft on the Goals page 77 lines apart, Craft in the
+  // Directory and Settings, craft in Collab, Type/lane on the builder-start card.
+  // A label repeated in six files is free to drift back, so the word lives HERE and
+  // every surface reads it — the same argument fillKindFilter above was written on.
+  //
+  // The word is ROLE, per ADR 0174 Decision 5 ("role" means a craft — and nothing
+  // else), confirmed by the owner on 2026-09-18 as the label that ships. Renaming
+  // the COLUMN or the API field is goal 1000066’s job and deliberately not done here.
+  const ROLE_AXIS_LABEL = 'Role';
+  function roleAxisLabel() { return ROLE_AXIS_LABEL; }
+
+  // A task with no role carries the DB default 'unclassified'. That is a word a
+  // column chose, not one a person would say (docs/voice.md V2), so a picker shows
+  // "No role yet" and a row tag renders NOTHING — roleIsUnset() is how a caller asks.
+  const ROLE_UNSET = 'unclassified';
+  function roleIsUnset(d) { return !d || String(d) === ROLE_UNSET; }
+
+  // NOT ESCAPE-SAFE: this returns a capitalised copy of its input, so a caller
+  // rendering it into markup must escapeHtml() the result, as every call site does.
+  // How a role is named wherever one is shown. An acronym stays upper-case
+  // ('ui' → 'UI'); anything else is sentence case, so a role a module adds later
+  // needs no new entry. Was disciplineLabel() — renamed with the axis.
+  function roleLabel(d) {
     const s = String(d || '');
     if (!s) return '';
+    if (s === ROLE_UNSET) return 'No role yet';
     return s === 'ui' ? 'UI' : s.charAt(0).toUpperCase() + s.slice(1);
   }
 
+  // The option list for any Role <select>, so no surface types the values or the
+  // labels again. Prefers the roles the SERVER serves (the same list
+  // db.updateBuilderDisciplines validates a PATCH against), and falls back to the
+  // four this tree ships when an older server sent none — never to an empty picker.
+  // `unset: true` appends the "No role yet" bucket for the boards that filter on it.
+  function roleOptions({ any = '— any —', unset = false } = {}) {
+    // disciplines() is the ONE reader of the served list, and it carries this
+    // file's only fallback enumeration — a second one here would be the very
+    // duplication this vocabulary exists to remove.
+    const list = disciplines();
+    const opts = [{ value: '', label: any }];
+    for (const d of list) opts.push({ value: d, label: roleLabel(d) });
+    if (unset) opts.push({ value: ROLE_UNSET, label: roleLabel(ROLE_UNSET) });
+    return opts;
+  }
+
   // Module→core settings-panel contribution seam (BV1.R42, ADR 0083) — the
   // browser twin of the server's 'profile.fields' seam (src/module-seams.js). A
   // module that has left core registers a Settings panel from its own client
@@ -365,7 +404,9 @@
   }
 
   window.OTB = {
-    escapeHtml, $, fmtNum, num, fmtInt, fmtCompact, fmtDate, rankLabel, toast, moduleOn, disciplines, disciplineLabel,
+    escapeHtml, $, fmtNum, num, fmtInt, fmtCompact, fmtDate, rankLabel, toast, moduleOn, disciplines,
+    // task 1003936 — ONE word for the role axis, all six surfaces
+    roleAxisLabel, roleLabel, roleOptions, roleIsUnset, ROLE_UNSET,
     fillKindFilter, kindLabel, // task 1003453 — one Kind filler, all three surfaces
     errCode, errMessage, errDetails, // task 1002462 — ADR 0116 envelope readers
     contributeSettingsPanel, settingsPanels,

package/modules/hall-ui/public/goals-page.js

@@ -963,8 +963,11 @@
       // disciplines a goal's tasks carry, derived in loadRollups. Staleness
       // buckets are the shared STALE_CHOICES from task-lib.js so this page and
       // the Tasks board offer the same lenses.
-      { id: 'f-goal-role', label: 'Craft', options: [ // ADR 0174: "role" means a craft
-        { value: '', label: '— any —' }, 'engineer', 'artist', 'ideator', 'ui'] },
+      // task 1003936 — this bar filters GOALS, the overflow bar below filters the
+      // TASKS inside one. Both are the same axis, so both take the word from
+      // OTB.roleAxisLabel() (ADR 0174: "role" is the CRAFT axis, never a goal
+      // membership, which stays a membership_kind — ADR 0177).
+      { id: 'f-goal-role', label: window.OTB.roleAxisLabel(), options: window.OTB.roleOptions() }, // ADR 0174
       { id: 'f-goal-stale', label: 'Age', options: window.OTBTaskLib.STALE_CHOICES },
     ],
     onChange: onListFilterChange,
@@ -1040,7 +1043,8 @@
       // here — this copy had gone stale against the DB CHECK exactly as the
       // board's had, so 'verify' work could not be filtered for on either.
       { id: 'f-goal-kind', label: 'Kind', options: [{ value: '', label: '— any —' }] },
-      { id: 'f-goal-discipline', label: 'Discipline', options: [{ value: '', label: '— any —' }, 'engineer', 'artist', 'ideator', 'ui', 'unclassified'] },
+      // ADR 0174: the craft axis again, scoped to the tasks inside one goal.
+      { id: 'f-goal-discipline', label: `Task ${window.OTB.roleAxisLabel().toLowerCase()}`, options: window.OTB.roleOptions({ unset: true }) }, // ADR 0174
       { id: 'f-goal-newcomer', label: 'Newcomer', options: [{ value: '', label: '— any —' }, { value: 'yes', label: 'newcomer-friendly only' }] },
       { id: 'f-goal-fit', label: 'Run mode', options: [{ value: '', label: '— any —' },
         { value: 'parallel', label: 'parallel-safe only' },

package/modules/hall-ui/public/goals-render.js

@@ -318,8 +318,9 @@
     const cpm = creditsPerMinute(t);
     const cpmText = Number.isFinite(cpm) ? `${cpm.toFixed(2)} ${curLabel()}/min` : `— ${curLabel()}/min`;
     const minutesText = t.est_minutes ? `${t.est_minutes}m` : '—';
-    const discipline = t.discipline || 'unclassified';
-    const disciplineTag = discipline !== 'unclassified' ? `<span class="task__tag">${escapeHtml(discipline)}</span>` : '';
+    const disciplineTag = window.OTB.roleIsUnset(t.discipline)
+      ? ''
+      : `<span class="task__tag">${escapeHtml(window.OTB.roleLabel(t.discipline))}</span>`;
     const newcomerTag = t.newcomer_friendly ? '<span class="task__tag task__tag--newcomer">newcomer</span>' : '';
     const rankTag = rankTagHtml(t.requires_rank);
     const touches = Array.isArray(t.touches) ? t.touches : [];
@@ -502,7 +503,7 @@
     let list = state.work.todo.filter((t) => {
       if (!matchesTodoSearch(t, sQuery)) return false;
       if (kFilter && (t.kind || 'unclassified') !== kFilter) return false;
-      if (dFilter && (t.discipline || 'unclassified') !== dFilter) return false;
+      if (dFilter && (t.discipline || window.OTB.ROLE_UNSET) !== dFilter) return false;
       if (nFilter === 'yes' && !t.newcomer_friendly) return false;
       return true;
     });

package/modules/hall-ui/public/hall-render.js

@@ -1013,7 +1013,7 @@
           // a module-contributed craft (ui-design → ui) never appeared here at all.
           action = `
             <div class="onboarding-item__action onboarding-item__disc-pick">
-              ${OTB.disciplines().map((d) => discBtn(d, OTB.disciplineLabel(d))).join('')}
+              ${OTB.disciplines().map((d) => discBtn(d, OTB.roleLabel(d))).join('')}
             </div>`;
         } else if (s.id === 'ship_three') {
           action = `

package/modules/hall-ui/public/people.js

@@ -196,13 +196,13 @@
     crafts.sort();
     kit.makeFilterBar({
       mount: document.getElementById('people-filters'),
-      search: { id: 'people-q', label: 'Search', placeholder: 'name or craft' },
+      search: { id: 'people-q', label: 'Search', placeholder: `name or ${window.OTB.roleAxisLabel().toLowerCase()}` },
       primary: [
         { id: 'people-sort', label: 'Sort', options: [
           { value: '', label: 'track record' }, { value: 'ships', label: 'most ships' },
           { value: 'credits', label: 'most ' + currencyLabel().toLowerCase() }, { value: 'karma', label: 'most karma' },
           { value: 'projects', label: 'most projects' }, { value: 'recent', label: 'most recently active' }] },
-        { id: 'people-craft', label: 'Craft', options: [{ value: '', label: '— any —' }].concat(crafts) },
+        { id: 'people-craft', label: window.OTB.roleAxisLabel(), options: [{ value: '', label: '— any —' }].concat(crafts.map((c) => ({ value: c, label: window.OTB.roleLabel(c) }))) },
       ],
       onChange: function (vals) {
         query = String(vals['people-q'] || '').trim().toLowerCase();
@@ -217,7 +217,7 @@
     ledger = kit.makeLedger({
       mount: body,
       columns: ['Builder', { label: 'Projects', class: 'ledger__num' }, { label: 'Ships', class: 'ledger__num' },
-        { label: currencyLabel(), class: 'ledger__num' }, { label: 'Karma', class: 'ledger__num' }, 'Crafts', 'Last active'],
+        { label: currencyLabel(), class: 'ledger__num' }, { label: 'Karma', class: 'ledger__num' }, `${window.OTB.roleAxisLabel()}s`, 'Last active'],
       rowHtml: rowHtml,
       // Reached only when the directory HAS builders and the lenses excluded them
       // all — the empty-API case returns above with its own explanation.

package/modules/hall-ui/public/profile-charts.js

@@ -128,7 +128,10 @@
   function craftMix(rows, max = MIX_MAX) {
     const counts = new Map();
     for (const r of rows || []) {
-      const k = (r && r.discipline) || 'unclassified';
+      // task 1003936: the bucket KEY stays the stored value, but what a person
+      // reads is OTB.roleLabel() — an unset role charted as "unclassified" was the
+      // database's word on a page (docs/voice.md V2).
+      const k = window.OTB.roleLabel((r && r.discipline) || window.OTB.ROLE_UNSET);
       counts.set(k, (counts.get(k) || 0) + 1);
     }
     const sorted = [...counts.entries()].map(([label, n]) => ({ label, n })).sort((a, b) => b.n - a.n || a.label.localeCompare(b.label));
@@ -462,7 +465,7 @@
           : `${fmtNum(paidFull.length ? paidFull[paidFull.length - 1].value : 0)} paid, from the credits ledger · ${span}`,
       }),
       mixChart({
-        id: 'chart-mix', title: 'Works by craft', mix,
+        id: 'chart-mix', title: `Works by ${window.OTB.roleAxisLabel().toLowerCase()}`, mix,
         footer: `${fmtNum(inWindow.length)} work${inWindow.length === 1 ? '' : 's'} · ${span}`,
       }),
     ];

package/modules/hall-ui/public/profile.html

@@ -105,7 +105,7 @@
                  craft at a time, with goals and the idea trail. -->
             <section class="scroll" id="works-scroll" aria-labelledby="works-h" data-group="works">
               <h2 id="works-h" class="scroll__h">Works</h2>
-              <p class="scroll__lede" id="works-lede">Everything this builder has shipped. Seen one craft at a time, with goals and ideas, under <a href="#activity">activity</a>.</p>
+              <p class="scroll__lede" id="works-lede">Everything this builder has shipped. Seen one role at a time, with goals and ideas, under <a href="#activity">activity</a>.</p>
               <table class="ledger" id="works-table">
                 <thead>
                   <tr>
@@ -130,8 +130,8 @@
                  the ideator view) every idea they filed with what became of it.
                  All three ledgers page server-side; profile.js fills them. -->
             <section class="scroll" id="activity-scroll" aria-labelledby="activity-h" data-group="activity">
-              <h2 id="activity-h" class="scroll__h">Activity, by craft</h2>
-              <p class="scroll__lede" id="activity-lede">What this builder has done, seen one craft at a time.</p>
+              <h2 id="activity-h" class="scroll__h">Activity, by role</h2>
+              <p class="scroll__lede" id="activity-lede">What this builder has done, seen one role at a time.</p>
               <div id="activity-tabs"></div>
               <div id="activity-body">
                 <div class="profile__placeholder" id="activity-placeholder">…</div>

package/modules/hall-ui/public/profile.js

@@ -305,7 +305,7 @@
       `</div>`;
     const discs = Array.isArray(cp.disciplines) ? cp.disciplines.filter((d) => typeof d === 'string') : [];
     const metaBits = [];
-    if (discs.length) metaBits.push(`Disciplines: ${discs.join(', ')}`);
+    if (discs.length) metaBits.push(`${window.OTB.roleAxisLabel()}s: ${discs.map((d) => window.OTB.roleLabel(d)).join(', ')}`);
     if (cp.last_active) metaBits.push(`Last active ${fmtDate(cp.last_active)}`);
     const meta = metaBits.length ? `<p class="scroll__lede">${escapeHtml(metaBits.join(' · '))}</p>` : '';
     const named = Array.isArray(cp.projects) ? cp.projects : [];
@@ -459,10 +459,10 @@
       columns: [
         { label: '#', class: 'ledger__num' },
         'Work',
-        { label: 'Craft' },
+        { label: window.OTB.roleAxisLabel() },
         { label: 'Shipped', class: 'ledger__date' },
       ],
-      emptyMsg: 'No completed works in this craft.',
+      emptyMsg: `No completed works in this ${window.OTB.roleAxisLabel().toLowerCase()}.`,
       fetchPage: async (offset, limit) => {
         const res = await api.request('GET', `${API}/builders/${encodeURIComponent(builderId)}/activity`
           + `?section=tasks&limit=${limit}&offset=${offset}${role ? `&role=${encodeURIComponent(role)}` : ''}`);
@@ -477,7 +477,7 @@
         return `<tr>
           <td class="ledger__num">#${escapeHtml(String(t.id))}</td>
           <td><a href="${taskHref(t.id)}">${escapeHtml(t.title || `Task ${t.id}`)}</a>${summary}${visual ? `<span style="display:block;margin-top:6px">${visual}</span>` : ''}</td>
-          <td><span class="task__tag">${escapeHtml(t.discipline || 'unclassified')}</span></td>
+          <td>${window.OTB.roleIsUnset(t.discipline) ? '' : `<span class="task__tag">${escapeHtml(window.OTB.roleLabel(t.discipline))}</span>`}</td>
           <td class="ledger__date">${fmtDate(t.shipped_at)}</td>
         </tr>`;
       },
@@ -489,10 +489,10 @@
       columns: [
         { label: '#', class: 'ledger__num' },
         'Goal',
-        'Crafts',
+        `${window.OTB.roleAxisLabel()}s`,
         'Progress',
       ],
-      emptyMsg: 'No goals created in this craft.',
+      emptyMsg: `No goals created in this ${window.OTB.roleAxisLabel().toLowerCase()}.`,
       fetchPage: async (offset, limit) => {
         const res = await api.request('GET', `${API}/builders/${encodeURIComponent(builderId)}/activity`
           + `?section=goals&limit=${limit}&offset=${offset}${role ? `&role=${encodeURIComponent(role)}` : ''}`);

package/modules/hall-ui/public/settings-specialities.js

@@ -69,7 +69,7 @@
       <details class="speciality-contract"${theirs ? ' open' : ''}>
         <summary>${theirs ? 'What this adds to your sessions — written by someone else' : 'What this adds to your sessions'}</summary>
         <pre class="speciality-contract__body">${escapeHtml(s.contract_md)}</pre>
-        ${theirs ? '<p class="prow__hint">You did not write this. Read it before using the speciality — it reaches every session where you hold work in that craft, and it is passed to Claude as this author\'s stated preferences, not as instructions it must obey.</p>' : ''}
+        ${theirs ? '<p class="prow__hint">You did not write this. Read it before using the speciality — it reaches every session where you hold work in that role, and it is passed to Claude as this author\'s stated preferences, not as instructions it must obey.</p>' : ''}
       </details>`;
   }
 
@@ -253,7 +253,7 @@
         const name = create.elements.name.value.trim();
         const discipline = create.elements.discipline.value;
         if (!name) { statusLine('Give it a name.'); return; }
-        if (!discipline) { statusLine('Pick which craft it sits under.'); return; }
+        if (!discipline) { statusLine(`Pick which ${window.OTB.roleAxisLabel().toLowerCase()} it sits under.`); return; }
         try {
           await call('POST', '/specialities', {
             name,

package/modules/hall-ui/public/settings.html

@@ -123,7 +123,7 @@
 
             <!-- CRAFT — discipline preferences (GET /me, PATCH /me/disciplines). -->
             <section class="scroll" id="craft-scroll" aria-labelledby="craft-h" data-group="account" hidden>
-              <h2 id="craft-h" class="scroll__h">Preferred disciplines</h2>
+              <h2 id="craft-h" class="scroll__h">Preferred roles</h2>
               <p class="scroll__lede">
                 The kinds of work you prefer. Task suggestions lean toward your
                 choices — pick one, several, or none.
@@ -278,9 +278,9 @@
             <section class="scroll" id="specialities-scroll" aria-labelledby="specialities-h" data-group="preferences" hidden>
               <h2 id="specialities-h" class="scroll__h">Your specialities</h2>
               <p class="scroll__lede">
-                A craft says how you work. A speciality says what you work on — and how you,
+                A role says how you work. A speciality says what you work on — and how you,
                 as someone who knows the subject, want to be engaged inside it. Whichever one
-                you are using reaches every session where you hold a claim in that craft.
+                you are using reaches every session where you hold a claim in that role.
                 Train it by adding things you have written; it also picks things up on its own
                 as you work.
               </p>
@@ -294,7 +294,7 @@
                   <input type="text" name="name" maxlength="80" required placeholder="Economics" />
                 </label>
                 <label class="speciality-field">
-                  <span>Craft it sits under</span>
+                  <span>Role it sits under</span>
                   <select name="discipline" required>
                     <option value="">Pick one…</option>
                     <option value="engineer">Engineer</option>

package/modules/hall-ui/public/settings.js

@@ -555,7 +555,7 @@
     const follows = !data || data.recruiter_discoverable == null;
     const grant = data && data.hide_stats
       ? 'Because your cross-project record is hidden, they will see your name and your picture, and nothing else.'
-      : 'They will see your name, your picture, your disciplines, and whether you have been active in the last 30 days — never your credits, works shipped, karma, or the projects you build on.';
+      : 'They will see your name, your picture, your roles, and whether you have been active in the last 30 days — never your credits, works shipped, karma, or the projects you build on.';
     // The surprising half, and only where it applies: a private profile answers
     // "not found" to every visitor, and this one switch is the exception.
     const despitePrivate = isPublic ? ''
@@ -684,7 +684,7 @@
       return (
         `<label class="craft-chip" data-disc="${escapeHtml(d)}" data-on="${on ? '1' : '0'}">` +
         `<input type="checkbox" class="craft-pref" value="${escapeHtml(d)}"${on ? ' checked' : ''}>` +
-        `${escapeHtml(window.OTB.disciplineLabel(d))}</label>`
+        `${escapeHtml(window.OTB.roleLabel(d))}</label>`
       );
     }).join('');
   }