@bongos/core 1.19.865 → 1.19.866

package/docs/module-api-changelog.md

@@ -2204,5 +2204,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.863 with no explicit bump. run 35294233113. (task 1002620)
   1.19.865 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.864 with no explicit bump. run 35295856053. (task 1002620)
+  1.19.866 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.865 with no explicit bump. run 35355019469. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/hall-ui/public/builders.js

@@ -790,7 +790,7 @@
       const title = escapeHtml(t.value_summary || t.title || `task #${t.id}`);
       return `
         <tr data-acclaim-row="${tid}">
-          <td>${title}</td>
+          <td>${title}${acclaimEvidenceHtml(t)}</td>
           <td>${by}</td>
           <td class="acclaim__net ${netCls}" data-acclaim-net="${tid}">${netText}</td>
           <td>${controls}</td>
@@ -1424,7 +1424,7 @@
   // reads what this page holds NOW rather than what it held at boot. Everything
   // else is stable for the life of the page. This call sits AFTER every
   // declaration it passes — moving it earlier is a temporal-dead-zone crash.
-  const { SETUP_CONFIG_KEY, analyticsState, lbState, mountHallWidgets, onboardingBox, renderCurveBody, renderGreeting, renderLanding, renderNav, renderOnboarding, renderProfile, renderRecentShips, renderWelcomeCore, shipState, shipsPager, welcomeDismissalKey } = window.OTBHallRender({
+  const { SETUP_CONFIG_KEY, acclaimEvidenceHtml, analyticsState, lbState, mountHallWidgets, onboardingBox, renderCurveBody, renderGreeting, renderLanding, renderNav, renderOnboarding, renderProfile, renderRecentShips, renderWelcomeCore, shipState, shipsPager, welcomeDismissalKey } = window.OTBHallRender({
     API, RANK_ORDER, api, brandWorld, curLabel, emptyRow, fmtDate, mins, normalizeRank, pct, postJSON, rankLabel, rankWeight, signClasses, toast, usd,
     get instanceRepo() { return instanceRepo; },
     get lastClaimableCount() { return lastClaimableCount; },

package/modules/hall-ui/public/hall-render.js

@@ -332,6 +332,46 @@
           </div>`;
   }
 
+  // task 1002835: a karma vote on a peer's ship was a vote on a title alone.
+  // The two facts the ship already recorded — what the grader scored it and
+  // what it cost — turn it into an informed one. ABSENCE IS NOT ZERO: an
+  // ungraded ship says so, and so does an unlogged cost, because "0.0" and
+  // "$0.00" would read as measurements that were never taken.
+  function acclaimEvidenceHtml(t) {
+    const score = t.grade_score == null ? null : Number(t.grade_score);
+    const grade = score == null || !Number.isFinite(score)
+      ? '<span class="ledger__verdict--none">not graded</span>'
+      : `<span class="${t.grade_passed ? 'ledger__verdict--ok' : 'ledger__verdict--danger'}">${score.toFixed(1)} / 10</span>`;
+    // Three states, not two. The route OMITS cost_usd for a builder who may not
+    // vote, and that is not the same fact as a logged cost of nothing: a reader
+    // who is shown no figure is told nothing, never "no cost logged".
+    const parts = [grade];
+    if (Object.prototype.hasOwnProperty.call(t, 'cost_usd')) {
+      const usd = t.cost_usd == null ? null : Number(t.cost_usd);
+      parts.push(usd == null || !Number.isFinite(usd)
+        ? '<span class="ledger__verdict--none">no cost logged</span>'
+        : `<span class="acclaim__cost">$${usd.toFixed(2)}</span>`);
+    }
+    return `<span class="acclaim__evidence">${parts.join(' · ')}</span>`;
+  }
+  // The RETURNING builder's door (task 1002851). `open` and `invite_only`
+  // already render a real .landing__btn sign-in inside the primary door, so a
+  // second button there would be a third scattered path rather than a clearer
+  // one — those modes keep the prose note alone. Only the `apply` door, whose
+  // primary control is the request FORM, left signing in as a footnote link.
+  // It gets a real button: the request button's geometry so it reads as a
+  // control, a quieter fill so the request path still leads for the strangers
+  // who are most of this page's traffic.
+  function returningDoorHtml(mode) {
+    if (mode !== 'apply') return '';
+    return `
+          <div class="landing__returning" id="landing-returning">
+            <h3 class="landing__request-h">Already a member?</h3>
+            <p class="landing__request-lede">You've been approved before — sign in and pick up where you left off.</p>
+            <p class="landing__cta"><a class="landing__btn landing__btn--quiet" href="${API}/auth/web/start">Sign in with GitHub</a></p>
+          </div>`;
+  }
+
   function renderLanding() {
     // task 1723: collapse the shell nav to the signed-out minimum (Home + a
     // Sign-in button). Cosmetic — the server gates every page regardless.
@@ -343,14 +383,20 @@
     const landing = $('#landing-root');
     if (landing) {
       landing.hidden = false;
+      const mode = joinabilityMode();
+      // On the apply door the sign-in is a real button above, so the note keeps
+      // only the privacy sentence — one sign-in path per landing, never two.
+      const signInNote = mode === 'apply'
+        ? ''
+        : `Already a member? <a href="${API}/auth/web/start">Sign in with GitHub</a>. `;
       landing.innerHTML = `
         <div class="scroll landing">
           <h2 class="scroll__h">Welcome</h2>
-          ${landingDoorHtml(joinabilityMode())}
+          ${landingDoorHtml(mode)}
+          ${returningDoorHtml(mode)}
 
           <p class="landing__signin-note">
-            Already a member? <a href="${API}/auth/web/start">Sign in with GitHub</a>.
-            We store only your GitHub login, avatar, and the work you ship.
+            ${signInNote}We store only your GitHub login, avatar, and the work you ship.
           </p>
         </div>
       `;
@@ -1305,6 +1351,6 @@
     return idx === -1 ? null : { place: idx + 1, total: ranked.length };
   }
 
-    return { SETUP_CONFIG_KEY, analyticsState, lbState, mountHallWidgets, onboardingBox, renderCurveBody, renderGreeting, renderLanding, renderNav, renderOnboarding, renderProfile, renderRecentShips, renderWelcomeCore, shipState, shipsPager, welcomeDismissalKey };
+    return { SETUP_CONFIG_KEY, acclaimEvidenceHtml, analyticsState, lbState, mountHallWidgets, onboardingBox, renderCurveBody, renderGreeting, renderLanding, renderNav, renderOnboarding, renderProfile, renderRecentShips, renderWelcomeCore, shipState, shipsPager, welcomeDismissalKey };
   };
 })();

package/modules/hall-ui/public/people.css

@@ -24,5 +24,14 @@
 .dir-who__t { display: flex; flex-direction: column; gap: 1px; min-width: 132px; }
 .dir-name { font-weight: 500; color: var(--ink); overflow-wrap: anywhere; }
 .dir-login { font-family: var(--font-mono); font-size: 11.5px; color: var(--ink-faint); }
+/* The roster's place cell carries two facts: the place, and under it the
+   builder's number in the same mono/faint voice the login uses (task
+   1002837). Block display so the id never wraps up beside the place. */
+.ledger__place .ledger__id {
+  display: block;
+  font-family: var(--font-mono);
+  font-size: 11.5px;
+  color: var(--ink-faint);
+}
 .dir-crafts { display: inline-flex; flex-wrap: wrap; gap: 6px; }
 .dir-none { color: var(--ink-faint); }

package/modules/hall-ui/public/roster.js

@@ -148,9 +148,19 @@
     return fmtInt(Math.round((Number(b.tokens_used) || 0) / credits)) + ' tokens per ' + one;
   }
 
+  // task 1002837: a builder's place answers "who is ahead", their NUMBER
+  // answers "which builder is this" — the id every task row, claim and ship
+  // note already cites. It sits under the place in the same mono/faint voice
+  // the login uses, and only when the payload carries one, so an older
+  // /builders response degrades to the place alone.
+  function idHtml(b) {
+    if (b.id == null || b.id === '') return '';
+    return '<span class="ledger__id">#' + esc(String(b.id)) + '</span>';
+  }
+
   function rowHtml(b) {
     return '<tr>'
-      + '<td class="ledger__num">' + esc(String(b.__place || '—')) + '</td>'
+      + '<td class="ledger__num ledger__place">' + esc(String(b.__place || '—')) + idHtml(b) + '</td>'
       + '<td>' + whoHtml(b) + achRowHtml(b.achievements) + '</td>'
       + '<td class="ledger__rank">' + rankBadgeHtml(b.rank) + '</td>'
       + '<td class="ledger__num">' + esc(fmtInt(b.total_credits)) + '</td>'

package/modules/hall-ui/public/style.css

@@ -1536,6 +1536,16 @@ main [id] { scroll-margin-top: calc(var(--topbar-h) + 16px); }
 .ledger__verdict--ok { color: var(--ok); font-weight: 600; }
 .ledger__verdict--danger { color: var(--danger); font-weight: 600; }
 .ledger__verdict--none { color: var(--ink-soft); }
+/* The acclaim feed's evidence line (task 1002835): the grade and the cost the
+   ship recorded, under the work it describes. Secondary to the title — this is
+   what a voter checks, not what they read first. */
+.acclaim__evidence {
+  display: block;
+  margin-top: 3px;
+  font-size: 12px;
+  color: var(--ink-faint);
+}
+.acclaim__cost { font-variant-numeric: tabular-nums; }
 .ledger th.ledger__sortable { cursor: pointer; user-select: none; }
 .ledger th.ledger__sortable:hover { color: var(--ink); }
 .ledger th.ledger__sortable[aria-sort="ascending"]::after { content: " ↑"; }
@@ -2492,6 +2502,24 @@ main [id] { scroll-margin-top: calc(var(--topbar-h) + 16px); }
 .landing__btn--request { align-self: flex-start; }
 .landing__request-status { font-size: 13px; margin: 0; color: var(--ok); }
 .landing__request-status[data-kind="err"] { color: var(--danger); }
+/* The returning builder's door, rendered only on the `apply` landing (task
+   1002851). Same panel as the request block and the same button geometry, so
+   signing in reads as a real control rather than a footnote — but a quiet
+   fill, because the request path is what most of this page's traffic needs. */
+.landing__returning {
+  border: 0;
+  border-radius: var(--radius);
+  background: var(--surface-2);
+  padding: 18px 20px;
+  margin: 16px 0;
+}
+.landing__returning .landing__cta { margin: 0; }
+.landing__btn--quiet {
+  background: transparent;
+  color: var(--ink);
+  box-shadow: inset 0 0 0 1px var(--border-strong);
+}
+.landing__btn--quiet:hover { background: var(--surface-2); color: var(--ink); }
 .landing__signin-note { font-size: 13px; color: var(--ink-soft); }
 
 /* ---------- goals ---------- */

package/modules/lifecycle/routes/tasks.js

@@ -29,6 +29,10 @@ const api = require('../../../src/module-api');
 // depRefusalRow: the ONE shape a dependency refusal carries, shared with the claim
 // path so promote and claim describe a blocked task identically (task 1003553).
 const { depRefusalRow } = require('../dead-deps.js');
+// gradeQualityWhere: the ONE definition of a task_grades row that is an actual
+// quality verdict rather than an outage or an errored worker (task 1002652).
+// The acclaim feed reads it so a grader outage never reaches a voter as 0.0.
+const { gradeQualityWhere } = require('../db-shared');
 const auth = api;
 const db = require('../db');
 const hierarchy = require('../hierarchy');
@@ -771,9 +775,28 @@ module.exports = function buildTasksRouter() {
                 t.shipped_at, t.shipped_by,
                 b.github_login, b.display_name,
                 COALESCE(pv.net, 0)::int AS net_votes,
-                mine.vote                AS my_vote
+                mine.vote                AS my_vote,
+                -- task 1002835: a karma vote is uninformed without the two facts
+                -- the ship already recorded. BOTH stay NULL when absent — an
+                -- ungraded ship and a zero-scoring one are different claims, and
+                -- so are an unlogged cost and a free one, so neither is
+                -- COALESCEd to a number the client would print as a measurement.
+                --
+                -- BOTH JOINS ARE INDEXED LOOKUPS, not scans: task_grades.task_id
+                -- is declared UNIQUE (migrations/016_pms_task_grades.sql:14, which
+                -- gives it its own index) and cost_log.task_id carries
+                -- idx_cost_log_task (migrations/003_pms.sql:152). Neither needs a
+                -- migration here, and neither degrades as cost_log grows.
+                CASE WHEN ${gradeQualityWhere('g')} THEN g.score END  AS grade_score,
+                CASE WHEN ${gradeQualityWhere('g')} THEN g.passed END AS grade_passed,
+                cost.total_usd          AS cost_usd
            FROM tasks t
            LEFT JOIN builders b ON b.id = t.shipped_by
+           LEFT JOIN task_grades g ON g.task_id = t.id
+           LEFT JOIN LATERAL (
+             SELECT SUM(amount_usd) AS total_usd
+               FROM cost_log WHERE task_id = t.id
+           ) cost ON true
            LEFT JOIN LATERAL (
              SELECT SUM(vote) AS net
                FROM peer_votes WHERE target_task_id = t.id
@@ -788,7 +811,15 @@ module.exports = function buildTasksRouter() {
           LIMIT $2`,
         [req.builder.id, limit]
       );
-      res.json({ tasks: rows, can_vote: ['metic', 'archon'].includes(req.builder.rank) });
+      const canVote = ['metic', 'archon'].includes(req.builder.rank);
+      // The cost is INTERNAL SPEND, and it is on this feed for one reason: to
+      // inform a vote. So it reaches only the ranks that can cast one. The grade
+      // is a quality verdict rather than spend and stays readable by any builder,
+      // as it already is on the grades table. Note the field is OMITTED, not
+      // nulled: a null here means "nothing was logged", and a reader who is not
+      // shown a figure must not be told a figure is missing.
+      const tasks = canVote ? rows : rows.map(({ cost_usd, ...rest }) => rest);
+      res.json({ tasks, can_vote: canVote });
     } catch (err) {
       // Log the detail server-side; don't return err.message — a raw Postgres
       // error can leak schema internals (table/column/constraint names).

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.865",
+  "version": "1.19.866",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.865",
+      "version": "1.19.866",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.865",
+  "version": "1.19.866",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/run-unit-tests.js

@@ -71,6 +71,11 @@ const SUPPORT_MODULES = new Set(['helpers']);
 
 // Need a live DB / server / network — run in the integration-smoke gate instead.
 const INTEGRATION = new Set([
+  // task 1004004: the acclaim feed proves a claim about SQL semantics — that a
+  // grader outage nulls rather than scoring 0.0, and that a summed cost over no
+  // rows is NULL rather than a free ship. Only a transaction engine settles
+  // those, so this runs here and the DB-free sibling covers the renderer.
+  'acclaim_feed_evidence_db',
   'asset_version', 'auth_flow_slice1', 'backfill_sessions', 'bfg', 'bfg_write',
   'box_connect_e2e', 'box_onboard', 'boxes', 'cf_tunnel', 'cli_token_reissue',
   // consumer_layout_boot builds the core .tgz, `npm install`s it, and boots a live

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.865'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.866'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/acclaim_feed_evidence_db.mjs

@@ -0,0 +1,186 @@
+// tests/acclaim_feed_evidence_db.mjs — the peer-acclaim feed's grade + cost
+// evidence, against a REAL Postgres (task 1004004, from task 1002835).
+//
+// WHY THIS EXISTS AND ITS DB-FREE SIBLING IS NOT ENOUGH.
+// tests/hall_builders_page_pass.mjs runs the RENDERER over every shape the row
+// can take, and asserts the route's SQL by reading its source. That proves the
+// client is honest about a NULL — it cannot prove the query ever PRODUCES one.
+// The whole argument of part C is a claim about SQL semantics that only a
+// transaction engine can settle:
+//
+//   - a grader OUTAGE row carries score 0 / passed=false in task_grades, and
+//     gradeQualityWhere must turn that into NULL rather than let a voter read
+//     it as a 0.0 verdict;
+//   - SUM(amount_usd) over ZERO cost_log rows is NULL, not 0, which is the
+//     difference between "no cost logged" and "this ship was free";
+//   - a ship with several cost rows must sum them, not pick one;
+//   - the two LATERALs and the grades join must not multiply the row out.
+//
+// Runs the route's own query text — sliced out of the shipped source, never
+// retyped — so a future edit to the route is tested rather than a copy of it.
+// Self-skips without a reachable Postgres; in the INTEGRATION set, so the
+// DB-free unit gate never runs it and .github/workflows/integration.yml does.
+//
+// Run:  DATABASE_URL=... node tests/acclaim_feed_evidence_db.mjs
+import { createRequire } from 'node:module';
+import { strict as assert } from 'node:assert';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const { Pool } = require('pg');
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+
+const pool = new Pool({ connectionString: process.env.DATABASE_URL || undefined });
+try {
+  await pool.query('SELECT 1');
+} catch (e) {
+  console.log(`acclaim_feed_evidence_db.mjs SKIPPED — no reachable Postgres (${e.code || e.message}).`);
+  await pool.end().catch(() => {});
+  process.exit(0);
+}
+
+// The query under test, taken from the shipped route. gradeQualityWhere is
+// interpolated by the route at call time, so interpolate it the same way.
+const { gradeQualityWhere } = require('../modules/lifecycle/db-shared.js');
+const routeSrc = fs.readFileSync(path.join(ROOT, 'modules/lifecycle/routes/tasks.js'), 'utf8');
+const start = routeSrc.indexOf('`SELECT t.id, t.title, t.value_summary, t.version_id, t.status,');
+assert.ok(start > 0, 'the peer-votes feed query is still where this test slices it from');
+const end = routeSrc.indexOf('LIMIT $2`', start);
+assert.ok(end > start, 'the feed query still ends at its LIMIT');
+const SQL = routeSrc
+  .slice(start + 1, end + 'LIMIT $2'.length)
+  .replace(/\$\{gradeQualityWhere\('g'\)\}/g, gradeQualityWhere('g'));
+assert.ok(!SQL.includes('${'), 'every interpolation in the sliced query was resolved');
+
+const VOTER = 90000801;
+const SHIPPER = 90000802;
+const VER = 'ZZZ-ACC';
+// graded+costed, outage, ungraded, costed-twice, zero-cost
+const T = { GOOD: 90000811, OUTAGE: 90000812, UNGRADED: 90000813, TWICE: 90000814, FREE: 90000815 };
+const IDS = Object.values(T);
+
+const q = (sql, params) => pool.query(sql, params).then((r) => r.rows);
+
+async function cleanup() {
+  await q('DELETE FROM peer_votes WHERE target_task_id = ANY($1)', [IDS]);
+  await q('DELETE FROM cost_log WHERE task_id = ANY($1)', [IDS]);
+  await q('DELETE FROM task_grades WHERE task_id = ANY($1)', [IDS]);
+  await q('DELETE FROM tasks WHERE id = ANY($1)', [IDS]);
+  await q('DELETE FROM builders WHERE id = ANY($1)', [[VOTER, SHIPPER]]);
+  await q('DELETE FROM versions WHERE id = $1', [VER]);
+}
+
+let failures = 0;
+const check = (name, fn) => {
+  try { fn(); console.log(`  PASS  ${name}`); } catch (e) {
+    failures += 1; console.log(`  FAIL  ${name}\n        ${e.message}`);
+  }
+};
+
+try {
+  await cleanup();
+
+  await q("INSERT INTO versions (id, name, status) VALUES ($1, 'acclaim evidence fixture', 'planning')", [VER]);
+  for (const [id, login] of [[VOTER, 'zz-acc-voter'], [SHIPPER, 'zz-acc-shipper']]) {
+    await q("INSERT INTO builders (id, github_login, display_name, rank) VALUES ($1, $2, $2, 'metic')", [id, login]);
+  }
+  for (const [id, title] of [
+    [T.GOOD, '__acc__ graded and costed'],
+    [T.OUTAGE, '__acc__ grader outage'],
+    [T.UNGRADED, '__acc__ never graded'],
+    [T.TWICE, '__acc__ two cost rows'],
+    [T.FREE, '__acc__ a real zero'],
+  ]) {
+    await q(
+      `INSERT INTO tasks (id, version_id, title, status, shipped_by, shipped_at, discipline, kind)
+       VALUES ($1, $2, $3, 'shipped', $4, now(), 'engineer', 'feature')`,
+      [id, VER, title, SHIPPER],
+    );
+  }
+
+  const grade = (taskId, score, passed, rubric, signals) => q(
+    `INSERT INTO task_grades (task_id, score, passed, threshold, grader_kind, grader_version, rubric_scores, signals)
+     VALUES ($1, $2, $3, 7.0, 'subagent', 'test', $4::jsonb, $5::jsonb)`,
+    [taskId, score, passed, JSON.stringify(rubric), JSON.stringify(signals)],
+  );
+  const FULL = { functional_fidelity: 8, code_quality: 8 };
+  await grade(T.GOOD, 8.5, true, FULL, {});
+  // The shape that matters: an outage parks score 0 / passed=false with
+  // json-null rubric axes. A voter must never read that as a 0.0 verdict.
+  await grade(T.OUTAGE, 0, false, { functional_fidelity: null, code_quality: null }, { panel_outcome: 'unavailable' });
+  await grade(T.TWICE, 6.0, false, FULL, {});
+  await grade(T.FREE, 0, false, FULL, {});
+
+  const cost = (taskId, amount) => q(
+    "INSERT INTO cost_log (task_id, amount_usd, category, source) VALUES ($1, $2, 'api', 'test')",
+    [taskId, amount],
+  );
+  await cost(T.GOOD, '12.3456');
+  await cost(T.TWICE, '1.50');
+  await cost(T.TWICE, '2.25');
+  await cost(T.FREE, '0');
+  // T.OUTAGE and T.UNGRADED get no cost row at all.
+
+  const rows = await q(SQL, [VOTER, 100]);
+  const byId = new Map(rows.map((r) => [String(r.id), r]));
+  const got = (id) => {
+    const row = byId.get(String(id));
+    assert.ok(row, `task ${id} is on the feed`);
+    return row;
+  };
+
+  check('every fixture ship reaches the feed exactly once (the joins do not multiply rows)', () => {
+    for (const id of IDS) got(id);
+    for (const id of IDS) {
+      const n = rows.filter((r) => String(r.id) === String(id)).length;
+      assert.equal(n, 1, `task ${id} appears once, not ${n}`);
+    }
+  });
+
+  check('a graded, costed ship carries both figures', () => {
+    const r = got(T.GOOD);
+    assert.equal(Number(r.grade_score), 8.5);
+    assert.equal(r.grade_passed, true);
+    assert.equal(Number(r.cost_usd), 12.3456);
+  });
+
+  check('a GRADER OUTAGE arrives as NULL, never as its placeholder 0', () => {
+    const r = got(T.OUTAGE);
+    assert.equal(r.grade_score, null, 'the outage score is nulled by gradeQualityWhere');
+    assert.equal(r.grade_passed, null, 'and so is its passed flag — no verdict was reached');
+  });
+
+  check('a ship that was never graded has no grade row and so no score', () => {
+    assert.equal(got(T.UNGRADED).grade_score, null);
+  });
+
+  check('an unlogged cost is NULL, not 0 — the sum is never COALESCEd', () => {
+    assert.equal(got(T.UNGRADED).cost_usd, null, 'no cost_log row means no figure, not a free ship');
+    assert.equal(got(T.OUTAGE).cost_usd, null);
+  });
+
+  check('several cost rows sum rather than one winning', () => {
+    assert.equal(Number(got(T.TWICE).cost_usd), 3.75);
+  });
+
+  check('a genuine zero survives, because it IS a measurement', () => {
+    const r = got(T.FREE);
+    assert.equal(Number(r.cost_usd), 0, 'a logged 0 is a logged 0, distinct from NULL');
+    assert.notEqual(r.cost_usd, null);
+    assert.equal(Number(r.grade_score), 0, 'a real 0.0 verdict is not an outage and is not nulled');
+    assert.equal(r.grade_passed, false);
+  });
+
+  check('the caller never sees their own ships, so nobody votes on themselves', () => {
+    assert.ok(!rows.some((r) => String(r.shipped_by) === String(VOTER)));
+  });
+} finally {
+  await cleanup().catch(() => {});
+  await pool.end().catch(() => {});
+}
+
+const passed = 8 - failures;
+console.log(`\nacclaim_feed_evidence_db: ${passed} passed, ${failures} failed`);
+process.exit(failures ? 1 : 0);