@bongos/core 1.19.819 → 1.19.821

package/scripts/gds/backfill-session-types.js

@@ -0,0 +1,87 @@
+#!/usr/bin/env node
+'use strict';
+
+// scripts/gds/backfill-session-types.js — classify the sessions that predate the
+// classifier (task 1003975, from idea 1001033).
+//
+// WHAT THIS IS, and what it is NOT. It writes ONE column, `session_records.session_type`,
+// and only where that column is NULL. It moves no money, books no reward, touches
+// no `task_ids` and creates no attribution. That separation is deliberate and it
+// is the lesson this module already paid for once: the attribution sweep had to be
+// windowed because it ran on the same tick as a payout and would have minted a mass
+// retroactive payment nobody authorised (see the warning in modules/sessions/CLAUDE.md).
+// A sweep that both labels and pays is the wrong shape whatever its intent, so this
+// one cannot pay even in principle — db.setSessionType writes that column alone.
+//
+// WHY IT IS NEEDED. The upload path classifies every session from now on, but the
+// corpus is ~4,600 rows old and none of them carry a verdict. Without this pass the
+// ledger's new filter would only ever see today's sessions, which is exactly the
+// half of the corpus nobody needs help reading.
+//
+// SAFETY. DRY-RUN BY DEFAULT: with no flags it classifies in memory, prints the
+// distribution it WOULD write, and writes nothing. `--apply` performs the UPDATEs.
+// Idempotent by construction: the verdict is a pure function of the row's own
+// stored digest, so a re-run lands on the same answer, and a row that already has
+// a type is never revisited (the query selects `WHERE session_type IS NULL`).
+// `--limit N` bounds one pass so the first apply can be small and checked.
+//
+// Run:  node scripts/gds/backfill-session-types.js [--limit N]
+//       node scripts/gds/backfill-session-types.js --apply
+
+const { classifySession, SESSION_TYPES } = require('../../modules/sessions/session-type');
+const db = require('../../modules/sessions/db');
+const { arg, hasFlag } = require('./cli-lib');
+
+const BATCH = 500;
+
+async function main() {
+  const apply = hasFlag('--apply');
+  const limitArg = Number(arg('--limit'));
+  const cap = Number.isFinite(limitArg) && limitArg > 0 ? Math.trunc(limitArg) : Infinity;
+
+  const tally = Object.fromEntries(SESSION_TYPES.map((t) => [t, 0]));
+  let scanned = 0;
+  let written = 0;
+
+  // Paged rather than one big SELECT: `detail` is a jsonb per row and the corpus
+  // is the largest table this module owns, so pulling it whole would hold the
+  // entire transcript corpus in memory at once for no gain.
+  for (;;) {
+    const room = Math.min(BATCH, cap - scanned);
+    if (room <= 0) break;
+    const rows = await db.unclassifiedSessions(room);
+    if (rows.length === 0) break;
+    for (const row of rows) {
+      const type = classifySession({ detail: row.detail, metrics: row.metrics });
+      tally[type] = (tally[type] || 0) + 1;
+      scanned++;
+      if (apply) written += await db.setSessionType(row.id, type);
+    }
+    // A dry run never writes, so the same unclassified page comes back forever.
+    // One page is enough to show the shape; say so rather than looping.
+    if (!apply) break;
+  }
+
+  console.log(`\nsession-type backfill — ${apply ? 'APPLIED' : 'DRY RUN (no writes)'}`);
+  console.log(`  rows classified     ${scanned}`);
+  if (apply) console.log(`  rows written        ${written}`);
+  console.log(`  distribution:`);
+  for (const t of SESSION_TYPES) {
+    const n = tally[t] || 0;
+    const pct = scanned ? ` (${Math.round((n / scanned) * 100)}%)` : '';
+    console.log(`    ${t.padEnd(14)} ${String(n).padStart(6)}${pct}`);
+  }
+
+  if (apply) {
+    console.log(`\n  corpus now:`);
+    for (const r of await db.sessionTypeCounts()) {
+      console.log(`    ${String(r.type).padEnd(14)} ${String(r.n).padStart(6)}`);
+    }
+  } else if (scanned > 0) {
+    console.log(`\n  dry run reads one page of ${BATCH}; re-run with --apply to write and walk the whole corpus.`);
+  }
+}
+
+main()
+  .then(() => process.exit(0))
+  .catch((err) => { console.error(err); process.exit(1); });

package/scripts/gds/fitness.js

@@ -200,9 +200,19 @@ function checkGeneratedArtifactsFresh() {
   } catch {
     violations.push('docs/api/openapi.json + docs/api-reference.md + docs/routes-permissions.md are STALE (or the spec is not valid OpenAPI 3.1) — run `node scripts/gds/gen-api-docs.js` and commit (task 1918).');
   }
+  try {
+    // task 1003556: the copy registry's rows carry LINE NUMBERS, so editing any scanned
+    // UI file stales it. It was covered only by ship-check's OPTIONAL step, which a
+    // builder has to remember to run — so the first signal was CI failing on the PR's
+    // MERGE ref, where the shift is hardest to attribute. Gated here so a local fitness
+    // run says so first.
+    execFileSync(process.execPath, [path.join(__dirname, 'copy-inventory.js'), '--check'], { cwd: REPO_ROOT, stdio: 'pipe' });
+  } catch {
+    violations.push('docs/copy-registry.json + docs/copy-inventory.md are STALE — every row carries a line number, so editing any scanned UI file shifts them. Run `node scripts/gds/copy-inventory.js` and commit (task 1003556).');
+  }
   // NB the role packs' responsibility blocks are generated too, but their freshness
   // is asserted by role-pack-guard.js — one check owns "the packs are correct".
-  return { name: 'generated artifacts fresh', ok: violations.length === 0, hardFail: violations.length > 0, violations, warnings: [], note: 'Tracked generated content matches source: nested CLAUDE.md symbol blocks (code) + the CLAUDE.md §13 snippet (sessions) via --check-block, plus the CLAUDE.md §2 interaction-posture block (the knob defaults), docs/file-map.md skills/scheduled-tasks sections and docs/api/openapi.json + api-reference.md (API). The gitignored docs/repo-map.md + docs/session-log-index.md are deploy-regenerated (ADR 0110), not gated here.' };
+  return { name: 'generated artifacts fresh', ok: violations.length === 0, hardFail: violations.length > 0, violations, warnings: [], note: 'Tracked generated content matches source: nested CLAUDE.md symbol blocks (code) + the CLAUDE.md §13 snippet (sessions) via --check-block, plus the CLAUDE.md §2 interaction-posture block (the knob defaults), docs/file-map.md skills/scheduled-tasks sections, docs/api/openapi.json + api-reference.md (API) and docs/copy-registry.json + copy-inventory.md (the reader-facing copy, task 1003556). The gitignored docs/repo-map.md + docs/session-log-index.md are deploy-regenerated (ADR 0110), not gated here.' };
 }
 
 // ---- deterministic cron routine boundary (System 4 / ADR 0078) -------------
@@ -1223,6 +1233,7 @@ const CHECKS = [
   // crashes later, so a start-up refusal would trade an outage risk for a cosmetic
   // one (ADR 0289). Rationale + the seam→consumer table live in that file.
   require('./seam-wiring-guard.js').checkSeamWiring,
+  require('./home-isolation-guard.js').checkHomeIsolation, // Check 34 — task 1003763: a test that sets HOME for a child without USERPROFILE isolates NOTHING on win32, so it silently stops testing what its comment says. Three tasks fixed this one site at a time. Rationale in that file.
   require('./adr-namespace.js').checkAdrNumbering, require('./exec-path-guard.js').checkExecPathsStatic, // Check 32 — task 1003371 / B50: what the server EXECUTES, out of whose tree — the blind spot all three 2026-08-29 CRITICALs shared. Rationale + reviewed exemptions live in that file. Sharing Check 31's line (the 19c/19d + 23/24 precedent above): fitness.js is AT the 1,500 ratchet and a new check cannot afford a line until task 1003825 buys it back.
 ];
 

package/scripts/gds/home-isolation-guard.js

@@ -0,0 +1,126 @@
+'use strict';
+
+// scripts/gds/home-isolation-guard.js — setting HOME for a child process isolates
+// nothing on Windows (task 1003763).
+//
+// THE DEFECT, three times now. os.homedir() reads USERPROFILE on win32 and never
+// consults HOME, so `env: { ...process.env, HOME: tmp }` leaves the child looking at
+// the DEVELOPER'S REAL home — and therefore their real CLI session.
+//
+//   tests/cli_sessions.mjs  (task 1003760) — DESTROYED the developer's live session.
+//   tests/cli_surface.mjs   (task 1003941) — guidance printers took the authenticated
+//                                            branch, so the test failed for a false
+//                                            reason on any signed-in Windows box.
+//   tests/cli_package.mjs   (task 1003763) — an unauthenticated-path assertion could
+//                                            pass because the machine was signed in.
+//
+// The last two are the dangerous shape: a test that isolates nothing does not
+// announce itself, it just quietly stops testing what its comment says it tests.
+//
+// WHY A GUARD AND NOT THREE FIXES. Three sites, three separate tasks, each found by
+// accident. tests/memory_pull.mjs, tests/redteam_patrol.mjs and
+// tests/setup_device_flow_fallback.mjs already do it correctly, so the convention
+// exists and is simply easy to miss — which is the definition of something CI should
+// hold rather than a reviewer.
+
+const fs = require('node:fs');
+const path = require('node:path');
+
+const REPO_ROOT = path.resolve(__dirname, '..', '..');
+const TESTS_DIR = path.join(REPO_ROOT, 'tests');
+
+// WHAT COUNTS AS A SPAWN ENV. Only a literal that SPREADS process.env and assigns
+// HOME — that is the shape every real defect had. Two narrowings, both learned by
+// getting this wrong on the first run against the tree:
+//
+//   - COMMENTS ARE STRIPPED. All three fixed files now explain the bug by QUOTING
+//     the broken line, so a raw text scan reports the very files that fixed it.
+//   - A HELPER'S CALL SITE IS NOT A SPAWN ENV. tests/setup_smoke.mjs passes
+//     `{ HOME: fakeHome }` to its own runSetup(), which adds USERPROFILE itself.
+//     Requiring `...process.env` in the same literal distinguishes 'building a
+//     child's environment' from 'passing an option to a function', and flags the
+//     helper rather than each of its callers — which is where the fix belongs.
+const HOME_ASSIGN_RE = /(^|[{,\s])HOME\s*:/;
+const USERPROFILE_RE = /(^|[{,\s])USERPROFILE\s*:/;
+const PROCESS_ENV_RE = /\.\.\.process\.env/;
+
+// Strip line and block comments so prose ABOUT the bug is not read as the bug.
+// Errs toward keeping text (a guard should fail loud, not quiet): only the two
+// unambiguous comment forms are removed.
+function stripComments(src) {
+  return String(src || '')
+    .replace(/\/\*[\s\S]*?\*\//g, '')
+    .replace(/(^|[^:])\/\/.*$/gm, '$1');
+}
+
+// Files where HOME is the SUBJECT rather than an isolation mechanism, named in task
+// 1003763. An allowlist entry is a claim that the file means something else by HOME,
+// so each one says which.
+const ALLOW = new Map([
+  ['scrubber_corpus.mjs', "HOME:'/root' is literal corpus DATA — a string the scrubber is asked to redact, not an env handed to a child"],
+  ['lib_sh_resolution.mjs', 'exercises POSIX shell HOME resolution; HOME is the thing under test, and a win32 variable would change the subject'],
+  ['home_isolation_guard.mjs', "this guard's OWN tests carry the broken shape as fixture strings — it must not report its own corpus, the same way category-advisory-guard.js had to stop matching its own filename"],
+]);
+
+// PURE — the lines that build a child env with HOME and no USERPROFILE. Exported so
+// the matching is testable without the tree: a scanner whose pattern silently stops
+// matching reports a clean repo, which is the failure mode this whole file is about.
+function offendingLines(src) {
+  const lines = stripComments(src).split('\n');
+  const out = [];
+  for (let i = 0; i < lines.length; i++) {
+    if (!HOME_ASSIGN_RE.test(lines[i])) continue;
+    // A literal can wrap: read a small window either side for its companions.
+    const window = lines.slice(Math.max(0, i - 4), i + 5).join('\n');
+    if (!PROCESS_ENV_RE.test(window)) continue;   // an option object, not a child env
+    if (USERPROFILE_RE.test(window)) continue;    // already isolated properly
+    out.push({ line: i + 1, text: lines[i].trim() });
+  }
+  return out;
+}
+function checkHomeIsolation() {
+  const name = 'a child env that sets HOME also sets USERPROFILE (task 1003763)';
+  let names = [];
+  try {
+    names = fs.readdirSync(TESTS_DIR).filter((f) => f.endsWith('.mjs'));
+  } catch (e) {
+    return { name, ok: true, hardFail: false, violations: [], warnings: [`tests/ unreadable: ${e.message}`], note: 'skipped.' };
+  }
+  // The scan must not pass by finding nothing.
+  if (names.length === 0) {
+    return {
+      name, ok: false, hardFail: true,
+      violations: ['no tests/*.mjs found at all — that is a broken scan, not a clean one'],
+      warnings: [], note: 'the scan produced an empty file set.',
+    };
+  }
+
+  const violations = [];
+  let scanned = 0;
+  let sitesSeen = 0;
+  for (const n of names) {
+    const src = fs.readFileSync(path.join(TESTS_DIR, n), 'utf8');
+    scanned += 1;
+    const hits = offendingLines(src);
+    if (HOME_ASSIGN_RE.test(stripComments(src)) && PROCESS_ENV_RE.test(stripComments(src))) sitesSeen += 1;
+    if (ALLOW.has(n)) continue;
+    for (const h of hits) {
+      violations.push(`tests/${n}:${h.line} sets HOME for a child without USERPROFILE — \`${h.text.slice(0, 90)}\`. `
+        + 'On Windows os.homedir() reads USERPROFILE and ignores HOME, so this isolates NOTHING: the child sees the '
+        + 'developer\'s real home and real session, and an unauthenticated-path assertion can pass because the machine '
+        + 'happens to be signed in. Set USERPROFILE (and HOMEDRIVE/HOMEPATH) to the same directory.');
+    }
+  }
+
+  return {
+    name,
+    ok: violations.length === 0,
+    hardFail: violations.length > 0,
+    violations,
+    warnings: [],
+    note: `${scanned} test file(s) scanned, ${sitesSeen} of them build a child env with HOME; ${ALLOW.size} allowlisted where HOME is the subject rather than the isolation. `
+      + 'Three separate tasks (1003760, 1003941, 1003763) fixed this one site at a time before it was worth a check.',
+  };
+}
+
+module.exports = { checkHomeIsolation, offendingLines, stripComments, ALLOW, HOME_ASSIGN_RE, USERPROFILE_RE, PROCESS_ENV_RE };

package/scripts/gds/ship-merge.js

@@ -27,7 +27,7 @@ const {
 } = require('./ship-land.js');
 const { runSmoke } = require('./ship-grade.js');
 const { dbOnlyIgnoredNotice } = require('./ship-honesty.js');
-const { currentBranch, mainWorktreeBusy, regenerateApiClient, regenerateApiDocs, regenerateDiagrams, regenerateFileMap, regenerateRepoMap, regenerateSessionIndex } = require('./ship-regen.js');
+const { currentBranch, mainWorktreeBusy, regenerateApiClient, regenerateApiDocs, regenerateCopyInventory, regenerateDiagrams, regenerateFileMap, regenerateRepoMap, regenerateSessionIndex } = require('./ship-regen.js');
 const { REPO_ROOT } = require('./ship-state.js');
 
 // zeroCommitVerdict — dbOnly is deliberately consulted ONLY at zero commits
@@ -119,6 +119,10 @@ async function mergeLocally(taskId, valueSummary, { dbOnly = false } = {}) {
   regenerateSessionIndex();
   // Refresh the generated file-map sections (skills + scheduled-tasks) on the same beat (ADR 0066 / task 1276).
   regenerateFileMap();
+  // Refresh the copy registry + inventory on the same beat (task 1003556). Its rows
+  // carry line numbers, so ANY edit to a scanned UI file staled it — and nothing in
+  // the ship path regenerated it, so the PR was born stale and CI said so.
+  regenerateCopyInventory();
   // Refresh the generated OpenAPI spec + API reference from the shipped route tree (task 1918).
   regenerateApiDocs();
   // ...then the typed client FROM that spec (+ the devbox vendored copy) on the same beat (task 2051).

package/scripts/gds/ship-regen.js

@@ -235,6 +235,34 @@ function regenerateFileMap() {
   return 'committed-nofatal';
 }
 
+// docs/copy-registry.json + docs/copy-inventory.md — the reader-facing copy the UI
+// actually renders (task 1003556).
+//
+// WHY IT HAS TO RUN HERE. Every row in the registry carries a `line`, so editing ANY
+// scanned UI file shifts line numbers and makes tests/copy_inventory.mjs red — on the
+// PR's MERGE ref, not on the branch, which is the worst place to find out. Nothing in
+// the ship path regenerated it (grep for copy-inventory across ship.js, ship-regen.js
+// and ship-preflight-steps.js used to return zero hits) and fitness did not cover the
+// pair either, so the builder got no local signal at all and learned from CI.
+//
+// Task 1003546 fixed the SERVER-side merge heals for the same artifact. Those repair a
+// strand after it happens; this is the prevention, so the PR is not born stale.
+function regenerateCopyInventory() {
+  console.log('  regenerating the copy registry + inventory from the shipped tree...');
+  shellOk(`"${process.execPath}" ${JSON.stringify(path.join(__dirname, 'copy-inventory.js'))}`);
+  const dirty = gitOk('git status --porcelain docs/copy-registry.json docs/copy-inventory.md');
+  if (!dirty) {
+    console.log('  copy registry already current — nothing to commit');
+    return 'current';
+  }
+  shellOk('git add docs/copy-registry.json docs/copy-inventory.md');
+  if (shellOk('git commit -m "chore(copy): auto-regenerate the copy registry + inventory (task 1003556)"')) {
+    console.log('  committed auto-regenerated copy registry');
+    return 'committed';
+  }
+  return 'committed-nofatal';
+}
+
 // ---------- merge serialization lock (#462 C4; extended in #269 C6) ----------
 //
 // autoMerge() mutates the SHARED main worktree (REPO_ROOT). Two concurrent
@@ -313,6 +341,7 @@ module.exports = {
   regenerateApiClient,
   regenerateApiDocs,
   regenerateDiagrams,
+  regenerateCopyInventory,
   regenerateFileMap,
   regenerateRepoMap,
   regenerateSessionIndex,

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.819'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.821'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/cli_package.mjs

@@ -21,6 +21,22 @@ import { spawnSync } from 'node:child_process';
 import { fileURLToPath, pathToFileURL } from 'node:url';
 
 const REPO_ROOT = path.join(path.dirname(fileURLToPath(import.meta.url)), '..');
+
+// HOME ALONE IS NOT ISOLATION ON WINDOWS (task 1003763).
+//
+// os.homedir() reads USERPROFILE on win32 and never consults HOME, so
+// `env: { ...process.env, HOME: home }` isolated nothing there: the installed CLI
+// saw the DEVELOPER'S REAL session file. That is precisely the false green the
+// comment below guards against — an unauthenticated-path assertion passing because
+// the machine happens to be signed in.
+//
+// HOMEDRIVE/HOMEPATH are os.homedir()'s second win32 source, so all four go. Named
+// rather than inlined twice: this is the third site in the repo to need it (after
+// tests/cli_sessions.mjs in task 1003760 and tests/cli_surface.mjs in task 1003941),
+// and every one of them got it half-right first.
+function homelessEnv(home, extra = {}) {
+  return { ...process.env, HOME: home, USERPROFILE: home, HOMEDRIVE: '', HOMEPATH: home, ...extra };
+}
 const BUILDER = path.join(REPO_ROOT, 'scripts', 'gds', 'build-cli-package.js');
 // Running npm from a test (task 1003529). On Windows `npm` is a .cmd shim: bare
 // 'npm' is ENOENT and 'npm.cmd' is EINVAL under Node 24's CVE-2024-27980 mitigation,
@@ -152,7 +168,7 @@ test('the packed tarball installs and every verb runs with no repo present', (t)
   // file on this machine cannot make a verb look healthier than it is.
   fs.writeFileSync(path.join(site, 'package.json'), JSON.stringify({ name: 'probe', private: true }));
   const installed = npm(['install', '--no-audit', '--no-fund', '--silent', path.join(site, tarball)], {
-    cwd: site, encoding: 'utf8', env: { ...process.env, HOME: home },
+    cwd: site, encoding: 'utf8', env: homelessEnv(home),
   });
   assert.equal(installed.status, 0, `npm install failed:\n${installed.stderr}`);
 
@@ -166,7 +182,7 @@ test('the packed tarball installs and every verb runs with no repo present', (t)
 
   const runVerb = (args) => spawnSync(process.execPath, [bongos, ...args], {
     cwd: site, encoding: 'utf8', input: '',
-    env: { ...process.env, HOME: home, CLOUDBONGOS_API_BASE: 'http://127.0.0.1:45999', NO_COLOR: '1' },
+    env: homelessEnv(home, { CLOUDBONGOS_API_BASE: 'http://127.0.0.1:45999', NO_COLOR: '1' }),
   });
 
   // help and version must work with nothing configured at all.

package/tests/hall_roster_world.mjs

@@ -271,11 +271,16 @@ test('sessions: every id on a row is a door, the earned figure is shown, the tot
   assert.match(html, /<div class="stat-row" id="stats-body"><\/div>/);
   const ths = (html.match(/<th[ >]/g) || []).length;
   // task 1002516: a tenth column, "Plain speech" — the transcript accessibility
-  // dimension the criterion asks to surface on the dashboard (ADR 0291). The
-  // per-cell contract (a not-scored session is a dash, never a zero) lives in
-  // tests/hall_sessions_ledger.mjs; this pin is only the column count.
-  assert.equal(ths, 10, 'ten columns: session, builder, tasks, earned, turns, tokens, tool errors, duration, plain speech, recorded');
-  assert.match(src, /colspan="10"/, 'the empty row spans them all');
+  // dimension the criterion asks to surface on the dashboard (ADR 0291).
+  // task 1003975: an eleventh, "Kind" — the session's derived shape, so the 54%
+  // of rows with no task chip are readable at all. The per-cell contracts (a
+  // not-scored session is a dash, never a zero; an unclassified one is a dash,
+  // never 'Unclear') live in tests/hall_sessions_ledger.mjs and
+  // tests/session_type.mjs; this pin is the column count AND that the empty row
+  // still spans them — a header added without widening the colspan leaves the
+  // empty state short by a column, which no screenshot pass would catch.
+  assert.equal(ths, 11, 'eleven columns: session, builder, kind, tasks, earned, turns, tokens, tool errors, duration, plain speech, recorded');
+  assert.match(src, new RegExp(`colspan="${ths}"`), 'the empty row spans them all');
   const fam = html.indexOf('/builders/oversight.css');
   assert.ok(fam > 0 && html.indexOf('/builders/sessions.css') > fam, 'sessions.html links the family sheet before its own');
 });

package/tests/home_isolation_guard.mjs

@@ -0,0 +1,95 @@
+// tests/home_isolation_guard.mjs — setting HOME for a child isolates nothing on
+// Windows (task 1003763).
+//
+// os.homedir() reads USERPROFILE on win32 and never consults HOME, so
+// `env: { ...process.env, HOME: tmp }` leaves the child looking at the developer's
+// real home — and their real CLI session. Three tasks fixed this one site at a time:
+// 1003760 (cli_sessions, which DESTROYED a live session), 1003941 (cli_surface) and
+// this one (cli_package). The last two are the dangerous shape — a test that isolates
+// nothing does not announce itself, it quietly stops testing what its comment claims.
+//
+// Run:  node tests/home_isolation_guard.mjs
+
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { readFileSync } from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const { checkHomeIsolation, offendingLines, stripComments, ALLOW } =
+  require('../scripts/gds/home-isolation-guard.js');
+
+const REPO_ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+
+test('the live tree is clean, and the scan is not empty', () => {
+  const r = checkHomeIsolation();
+  assert.deepEqual(r.violations, [], r.violations.join('\n'));
+  // A guard that scans nothing passes for free. The note carries the counts so a
+  // silently-broken scan is visible rather than reassuring.
+  const scanned = Number(/^(\d+) test file/.exec(r.note)?.[1] ?? 0);
+  const sites = Number(/(\d+) of them build a child env/.exec(r.note)?.[1] ?? 0);
+  assert.ok(scanned > 100, `expected the whole tests/ tree, scanned ${scanned}`);
+  assert.ok(sites > 0, 'no file builds a child env with HOME — the pattern has drifted and this guard is inert');
+});
+
+test('the original broken shape IS caught', () => {
+  const src = 'const r = spawnSync(node, [x], { env: { ...process.env, HOME: home } });';
+  assert.equal(offendingLines(src).length, 1);
+});
+
+test('the fixed shape is not', () => {
+  const src = 'const r = spawnSync(node, [x], { env: { ...process.env, HOME: home, USERPROFILE: home } });';
+  assert.deepEqual(offendingLines(src), []);
+});
+
+test('a HELPER CALL SITE is not a child env', () => {
+  // tests/setup_smoke.mjs passes { HOME: fakeHome } to its own runSetup(), which adds
+  // USERPROFILE itself. Flagging the callers would point at the wrong line and, worse,
+  // train someone to "fix" three call sites instead of the one helper.
+  assert.deepEqual(offendingLines("runSetup(['--dry-run'], { HOME: fakeHome });"), []);
+});
+
+test('a COMMENT quoting the bug is not the bug', () => {
+  // Every file that fixed this now explains it by quoting the broken line. A raw text
+  // scan therefore reports exactly the files that already fixed it — which is how the
+  // first run of this guard produced three false positives.
+  assert.deepEqual(offendingLines('// env: { ...process.env, HOME: home } isolated nothing'), []);
+  assert.deepEqual(offendingLines('/* env: { ...process.env, HOME: home } */'), []);
+  assert.ok(!stripComments('// { ...process.env, HOME: x }').includes('HOME'));
+});
+
+test('a multi-line literal is still read', () => {
+  const src = [
+    'const r = spawnSync(node, [x], {',
+    '  env: {',
+    '    ...process.env,',
+    '    HOME: home,',
+    '  },',
+    '});',
+  ].join('\n');
+  assert.equal(offendingLines(src).length, 1, 'the literal wraps — a single-line matcher misses the real shape');
+});
+
+test('every allowlisted file exists and still means HOME differently', () => {
+  // An allowlist entry is a claim. If the file is gone, the claim is stale and the
+  // entry is a hole nobody is watching.
+  for (const [name, why] of ALLOW) {
+    const p = path.join(REPO_ROOT, 'tests', name);
+    let src;
+    try { src = readFileSync(p, 'utf8'); } catch {
+      assert.fail(`allowlisted tests/${name} no longer exists — remove the entry rather than leaving an unwatched hole`);
+    }
+    assert.ok(why && why.length > 20, `tests/${name} needs a reason, not just an exemption`);
+    assert.match(src, /HOME/, `tests/${name} no longer mentions HOME, so its exemption is dead`);
+  }
+});
+
+test('the two sites this task fixed are actually fixed', () => {
+  const src = readFileSync(path.join(REPO_ROOT, 'tests', 'cli_package.mjs'), 'utf8');
+  assert.deepEqual(offendingLines(src), []);
+  assert.match(src, /USERPROFILE/, 'cli_package must set USERPROFILE alongside HOME');
+  const surface = readFileSync(path.join(REPO_ROOT, 'tests', 'cli_surface.mjs'), 'utf8');
+  assert.deepEqual(offendingLines(surface), []);
+});