@bongos/core 1.19.817 → 1.19.819

package/scripts/gds/bug-attachment-audit.js

@@ -0,0 +1,143 @@
+#!/usr/bin/env node
+// scripts/gds/bug-attachment-audit.js — do the images our task descriptions
+// promise actually exist? (task 1003918)
+//
+// WHY THIS EXISTS. A re-hosted #bugs screenshot is the one artefact in this
+// system that cannot be regenerated: the Discord CDN URL it was copied from is
+// signed and expires in about a day, so our copy IS the image. They live on disk
+// under var/bug-attachments — outside Postgres, outside git — and nothing
+// noticed when all five this instance had ever stored disappeared in the
+// 2026-07-05 droplet move. The loss surfaced on 2026-09-14, two months later,
+// because somebody happened to open an old bug task and saw a broken image.
+//
+// So: read the descriptions, extract every attachment link they promise, and ask
+// the disk whether it can keep that promise. A count of broken promises is the
+// thing that should have been non-zero and visible in July.
+//
+// Usage:
+//   node scripts/gds/bug-attachment-audit.js          # human report; exit 1 if any are missing
+//   node scripts/gds/bug-attachment-audit.js --json   # { described, present, missing: [...] }
+//   node scripts/gds/bug-attachment-audit.js --line   # one line, or nothing; always exit 0
+//
+// Read-only. It never writes, never deletes, and never touches Discord.
+
+'use strict';
+
+const fs = require('node:fs');
+const path = require('node:path');
+
+// The link shape the bot embeds in a description. Deliberately matched against
+// the SERVE ROUTE's path rather than any filename found on disk: what matters is
+// what a reader will click, and a file nothing links to is not a broken promise.
+const LINK_RE = /\/api\/(?:gds|bongos)\/bug-attachments\/(bug-[a-z0-9]{1,40}-[0-9a-f]{16}\.(?:png|jpg|gif|webp))/gi;
+
+// PURE — every attachment name a body of text promises, deduped, in first-seen
+// order. Exported so the extraction is testable without a database or a disk.
+function describedAttachments(text) {
+  const out = [];
+  const seen = new Set();
+  for (const m of String(text || '').matchAll(LINK_RE)) {
+    const name = m[1];
+    if (!seen.has(name)) { seen.add(name); out.push(name); }
+  }
+  return out;
+}
+
+// PURE — split the promised names into kept and broken, given an existence test.
+// `rows` are { id, title, description }; the result names the TASK for each
+// missing file, because "three files are gone" is not actionable and "the image
+// in task N is gone" is.
+function auditRows(rows, exists) {
+  const described = [];
+  const missing = [];
+  for (const row of rows || []) {
+    for (const name of describedAttachments(row && row.description)) {
+      described.push({ name, taskId: row.id });
+      if (!exists(name)) missing.push({ name, taskId: row.id, title: row.title || '' });
+    }
+  }
+  return { described, missing, present: described.length - missing.length };
+}
+
+// EVERY status, explicitly, and paged. Two ways to get a comfortable zero here,
+// both of which I hit while building this:
+//
+//   - GET /tasks omits abandoned rows unless you ask for them. The five files this
+//     audit exists for are described in tasks that are now abandoned or shipped, so
+//     the obvious query returned '0 linked, 0 missing' — indistinguishable from
+//     'nothing is broken'.
+//   - the route clamps `limit`, so one page is not the table.
+//
+// A probe whose failure mode is a clean bill of health is worse than no probe, so
+// the status list is spelled out rather than defaulted.
+// 'claimed' is not one — claimTask sets status='active' (db-claims.js). Listing it
+// only bought a no-op query, and a comment promising EVERY status should be right.
+const TASK_STATUSES = ['backlog', 'ready', 'active', 'completed', 'confirmed', 'shipped', 'abandoned'];
+
+async function fetchRows() {
+  const { cliClient } = require('./cli-lib');
+  const { TASK_LIST_MAX_LIMIT, buildTaskPageQuery } = require('../../modules/lifecycle/task-list-limits.js');
+  const api = await cliClient();
+  const byId = new Map();
+  for (const status of TASK_STATUSES) {
+    let offset = 0;
+    for (let page = 0; page < 100; page++) {
+      const q = buildTaskPageQuery({ kind: 'bug', status, limit: TASK_LIST_MAX_LIMIT, offset });
+      const r = await api.tasks.getTasks({ query: q });
+      if (!r || !r.ok) throw new Error(`could not list ${status} tasks (${r && r.status})`);
+      const rows = (r.data && r.data.tasks) || [];
+      for (const t of rows) byId.set(String(t.id), t);
+      // A short page is the end. Compare against the limit the route HONOURED.
+      if (rows.length < q.limit) break;
+      offset += q.limit;
+    }
+  }
+  return [...byId.values()];
+}
+
+async function main() {
+  const argv = process.argv.slice(2);
+  const dir = require('../../modules/discord/bug-attachments.js').attachmentsDir();
+  let rows;
+  try {
+    rows = await fetchRows();
+  } catch (e) {
+    if (argv.includes('--line')) process.exit(0); // a probe never blocks a session
+    console.error(`bug-attachment-audit: undetermined — ${e.message || e}`);
+    process.exit(2);
+  }
+  // Through the serve route's OWN resolver, not a bare path.join. The name pattern
+  // already excludes slashes and dots, and a test pins that '../../etc/passwd' is
+  // never extracted — but the route that actually opens these files defends itself
+  // with a resolved-path prefix check, and a probe that reads the same store should
+  // not hold itself to a weaker rule than the thing it audits.
+  const { resolveSafe } = require('../../modules/discord/bug-attachments.js');
+  const r = auditRows(rows, (name) => {
+    const p = resolveSafe(name);
+    return Boolean(p) && fs.existsSync(p);
+  });
+
+  if (argv.includes('--json')) {
+    console.log(JSON.stringify({ dir, described: r.described.length, present: r.present, missing: r.missing }, null, 2));
+    return;
+  }
+  if (argv.includes('--line')) {
+    if (r.missing.length) {
+      console.log(`Bug attachments: ${r.missing.length} of ${r.described.length} linked screenshot(s) are MISSING from ${dir} `
+        + '— every task describing one renders a broken image. These cannot be re-fetched (the Discord URL has expired).');
+    }
+    return;
+  }
+  console.log(`  Bug attachments: ${r.described.length} linked, ${r.present} present, ${r.missing.length} missing`);
+  console.log(`  Store: ${dir}`);
+  for (const m of r.missing) console.log(`    missing  ${m.name}  (task ${m.taskId})`);
+  if (r.missing.length) {
+    console.log('  These cannot be re-fetched — the Discord CDN URL they were copied from has expired.');
+    console.log('  Restore from a nightly attachments archive: /var/backups/gds/<db>-attachments-*.tar.gz');
+    process.exit(1);
+  }
+}
+
+if (require.main === module) main();
+
+module.exports = { describedAttachments, auditRows, LINK_RE };

package/scripts/gds/capture.js

@@ -282,6 +282,25 @@ async function main() {
   const noPrompt = hasFlag('--no-prompt', args);
   const goalArg = arg('--goal', args);
 
+  // A BAD --kind used to reach the server and come back a 400 (task 1003694).
+  // That is not merely late, it is invisible where it matters: a SCHEDULED routine
+  // filing its findings gets the 400 into a log nobody reads, the audit work still
+  // runs, and only the step that turns a finding into a durable row fails — so no
+  // queue accumulates to make the absence noticeable. dep-audit-nightly filed with
+  // `--kind security`, which is not a kind, and had therefore NEVER filed anything.
+  //
+  // Refusing here makes the same typo surface at authoring time, on the machine of
+  // whoever wrote the command, with the valid list in the message.
+  if (kindFromArg !== null) {
+    const { VALID_KINDS } = require('../../modules/ideas/inbox.js');
+    if (!VALID_KINDS.includes(kindFromArg)) {
+      console.error(`--kind "${kindFromArg}" is not a valid kind. The server would refuse this with a 400.`);
+      console.error(`Valid kinds: ${VALID_KINDS.join(', ')}`);
+      console.error('Adding a new kind is a schema change (the idea_inbox CHECK constraint) and needs its own migration + ADR.');
+      process.exit(2);
+    }
+  }
+
   if (parseGoalArg(goalArg).kind === 'invalid') {
     console.error(`--goal must be a positive goal id, or the literal "none" to file homeless (got "${goalArg}").`);
     process.exit(2);

package/scripts/gds/db-backup-nightly.sh

@@ -170,6 +170,42 @@ if [ "$BYTES" -gt "$WARN_BYTES" ]; then
   echo "[$(date -u +%FT%TZ)] gds-db-backup: WARN latest dump is ${BYTES} bytes (> ${WARN_BYTES} threshold) — review what grew; is it a regenerable table excludable like search_chunks?" >&2
 fi
 
+# ---- bug attachments (task 1003918) -----------------------------------------
+
+# The DB dump above is not the whole state. Re-hosted #bugs screenshots live on
+# disk under var/bug-attachments, outside Postgres and outside git, and they are
+# the one artefact here that CANNOT be regenerated: the Discord CDN URL they were
+# copied from is signed and expires in about a day, so our copy IS the image.
+#
+# Nothing backed them up. All five this instance ever stored are gone — the
+# 2026-07-05 droplet move carried the database and not var/ — and every task
+# description embedding one now renders a broken image in the hall.
+#
+# Tarred beside the dump, same timestamp, same retention, so a restore drill that
+# picks a date gets the database and the images that go with it. Best-effort by
+# design: a missing or empty attachments dir is the ordinary case on a fresh
+# instance and must never fail a night of database backup.
+ATTACH_DIR="${BUG_ATTACHMENTS_DIR:-$REPO_ROOT/var/bug-attachments}"
+ATTACH_OUT="${BACKUP_DIR}/${DB_NAME}-attachments-${TS}.tar.gz"
+ATTACH_GLOB="${DB_NAME}-attachments-${D}${D}${D}${D}-${D}${D}-${D}${D}T${D}${D}${D}${D}${D}${D}Z.tar.gz"
+
+if [ -d "$ATTACH_DIR" ]; then
+  ATTACH_COUNT=$(find "$ATTACH_DIR" -maxdepth 1 -type f | wc -l)
+  if [ "$ATTACH_COUNT" -gt 0 ]; then
+    if tar -czf "$ATTACH_OUT.partial" -C "$ATTACH_DIR" . 2>/dev/null; then
+      mv "$ATTACH_OUT.partial" "$ATTACH_OUT"
+      echo "[$(date -u +%FT%TZ)] gds-db-backup: wrote ${ATTACH_OUT} (${ATTACH_COUNT} attachment(s))"
+    else
+      rm -f "$ATTACH_OUT.partial"
+      echo "[$(date -u +%FT%TZ)] gds-db-backup: WARN could not archive ${ATTACH_DIR} — database dump is unaffected" >&2
+    fi
+  else
+    echo "[$(date -u +%FT%TZ)] gds-db-backup: no bug attachments to archive"
+  fi
+else
+  echo "[$(date -u +%FT%TZ)] gds-db-backup: no bug-attachment dir at ${ATTACH_DIR} — nothing to archive"
+fi
+
 # ---- retention prune --------------------------------------------------------
 
 # Delete dumps older than RETENTION_DAYS. -mtime +N means strictly older
@@ -177,7 +213,7 @@ fi
 # Done AFTER the new dump lands so a streak of failed runs can't erase
 # everything: we never delete on a day we didn't successfully dump.
 PRUNED=$(find "$BACKUP_DIR" -maxdepth 1 -type f \
-    -name "$DUMP_GLOB" \
+    \( -name "$DUMP_GLOB" -o -name "$ATTACH_GLOB" \) \
     -mtime +"${RETENTION_DAYS}" \
     -print -delete | wc -l)
 

package/scripts/gds/linkify-refs.js

@@ -115,6 +115,14 @@ const { API_BASE } = require('./cli-lib');
 // the root CLAUDE.md/README.md plus all of docs/** (session-logs included). A
 // "GENERATED FILE" marker means the bare refs reappear on the next regen, so
 // the generator — not its output — is where those get fixed; skip them here.
+// PATHS COME BACK POSIX-STYLE, on every platform (task 1003935). path.join gives
+// OS-native separators, so on Windows this used to return 'docs\\adr\\0001-….md'.
+// Three things read these paths and only one of them tolerates that: fs accepts
+// either separator on Windows, but the --check report PRINTS them (so CI output
+// differed by platform for identical content) and the test that pins recursion
+// into docs/ compares against 'docs/' — which is how a permanently-red case hid
+// for months in a file no lane ran. Normalising here, at the one boundary that
+// produces them, is cheaper than teaching every consumer to be separator-aware.
 function discoverDocs() {
   const out = [];
   const walk = (rel) => {
@@ -123,7 +131,7 @@ function discoverDocs() {
     if (fs.statSync(abs).isDirectory()) {
       for (const name of fs.readdirSync(abs).sort()) walk(path.join(rel, name));
     } else if (rel.endsWith('.md')) {
-      out.push(rel);
+      out.push(rel.split(path.sep).join('/'));
     }
   };
   for (const root of ['CLAUDE.md', 'README.md', 'docs']) walk(root);

package/scripts/gds/run-unit-tests.js

@@ -131,7 +131,14 @@ const INTEGRATION = new Set([
   // the --integration lane never saw them either, because it runs only this set. A
   // test that cannot fail in either lane is a file that looks like a gate.
   'handle_machinery', 'hub_profile_leak', 'profile_fields',
-  'linkify_refs', 'memory_isolation',
+  // task 1003935: 'linkify_refs' was swept in with the three above without the
+  // no-DB check they were being fixed for. It touches no Postgres at all — pure
+  // string work plus a filesystem walk — so the DB-free lane skipped it and the
+  // --integration lane, which runs only this set, never had a reason to. It ran in
+  // NEITHER lane, which is the exact failure the comment above describes, and it
+  // is why one permanently-red Windows case sat unnoticed. It is now in the unit
+  // gate, where it is the only coverage linkifyText has.
+  'memory_isolation',
   'memory_pull', 'needs_rebase', 'parallel-load', 'profile_rollup_consent',
   // task 1003145: whether the PLANNER uses the migration 225 index for the recall
   // freshness probe. The DB-free sibling (recall_corpus_health) pins the query

package/scripts/gds/skill-preflight.js

@@ -120,13 +120,36 @@ const CAPABILITIES = {
   },
 };
 
+// EVERY read of a SKILL.md goes through here (task 1003754).
+//
+// These files are CRLF in a Windows checkout — .gitattributes pins *.js, *.json,
+// *.sh and *.sql, but Markdown falls through `* text=auto`. Every regex below is
+// anchored on \n, starting with the frontmatter fence /^---\n/, so on Windows the
+// frontmatter simply did not match and parseRequires returned `declared: false`
+// for EVERY skill.
+//
+// That is worse than one red test. Fitness check G03 compares what a skill's fenced
+// commands imply against what it declares — and with nothing parsed as declared, the
+// check reported '53 skill(s) scanned; 0 declare a machine contract' and had nothing
+// to compare. The guard against a skill's ops commands outrunning its declaration
+// was inert on any Windows box.
+//
+// Normalising once at the boundary is deliberately not 'make each regex CRLF-aware':
+// there are six of them and the next one added would forget.
+function readSkillMd(p) {
+  return String(fs.readFileSync(p, 'utf8')).replace(/\r\n/g, '\n');
+}
+
 // ---- the declaration ------------------------------------------------------
 // Read `requires:` out of a skill's YAML frontmatter. Accepts the inline form
 // (`requires: [gh, main-checkout]`) and the dash-list form. Returns
 // { requires, declared, error }: `declared` distinguishes "declared nothing"
 // from "declared an empty list", which the fitness check needs to tell apart.
 function parseRequires(md) {
-  const m = /^---\n([\s\S]*?)\n---/.exec(String(md || ''));
+  // Normalised here too, not only in readSkillMd: this is exported and a caller may
+  // hand it raw file text (the fitness check's injected `read` does exactly that).
+  const src = String(md || '').replace(/\r\n/g, '\n');
+  const m = /^---\n([\s\S]*?)\n---/.exec(src);
   if (!m) return { requires: [], declared: false, error: null };
   const fm = m[1];
   const inline = /^requires:[ \t]*\[(.*?)\][ \t]*$/m.exec(fm);
@@ -176,7 +199,8 @@ function fencedCode(md) {
 }
 
 function inferRequired(md) {
-  const code = fencedCode(md);
+  // Same reason as parseRequires: the SIGNALS below are ^-anchored per line.
+  const code = fencedCode(String(md || '').replace(/\r\n/g, '\n'));
   const out = new Set();
   for (const [rx, cap] of SIGNALS) if (rx.test(code)) out.add(cap);
   return [...out].sort();
@@ -224,7 +248,7 @@ function preflightSkill(name, caps = CAPABILITIES) {
     return { ok: false, requires: [], missing: [{ name: 'skill', why: `"${name}" is not a skill name — it must be a single directory name under .claude/skills/.` }], unknown: [], checked: [] };
   }
   let md;
-  try { md = fs.readFileSync(p, 'utf8'); } catch {
+  try { md = readSkillMd(p); } catch {
     return { ok: false, missing: [{ name: 'skill', why: `no skill named "${name}" at .claude/skills/${name}/SKILL.md` }], unknown: [], checked: [] };
   }
   const { requires, error } = parseRequires(md);
@@ -263,7 +287,7 @@ function checkOpsSkillsDeclareMachine({ dir = SKILLS_DIR, read = null, names: in
     };
   }
   const readOne = read || ((n) => {
-    try { return fs.readFileSync(path.join(dir, n, 'SKILL.md'), 'utf8'); } catch { return null; }
+    try { return readSkillMd(path.join(dir, n, 'SKILL.md')); } catch { return null; }
   });
 
   let declaring = 0;

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.817'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.819'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/bug_attachment_audit.mjs

@@ -0,0 +1,122 @@
+// tests/bug_attachment_audit.mjs — the described-but-missing probe (task 1003918).
+//
+// WHY THIS FILE EXISTS. Five re-hosted #bugs screenshots — every one this instance
+// ever stored — disappeared in the 2026-07-05 droplet move, and nobody noticed for
+// two months. They cannot be re-fetched: the Discord CDN URL they were copied from
+// is signed and expires in about a day, so our copy IS the image. The probe is what
+// should have said so in July.
+//
+// A probe like this fails by finding nothing, and a clean bill of health looks
+// identical to working — which is exactly what happened while building it: the
+// first cut queried GET /tasks without naming a status, the route omits abandoned
+// rows by default, and every task describing these files is now abandoned or
+// shipped. It printed "0 linked, 0 missing". So the cases below lean on the ways
+// the extraction can go quietly empty.
+//
+// Run:  node tests/bug_attachment_audit.mjs
+
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const { describedAttachments, auditRows } = require('../scripts/gds/bug-attachment-audit.js');
+const { attachmentsDir } = require('../modules/discord/bug-attachments.js');
+const path = require('node:path');
+
+// The real link shape, taken verbatim from task 1003718's description.
+const REAL = '/api/gds/bug-attachments/bug-1523688670492627115-8bb16de1f5b4c20e.png';
+
+test('extracts the attachment name from a real embedded link', () => {
+  const got = describedAttachments(`![screenshot](https://cloudbongos.com${REAL})`);
+  assert.deepEqual(got, ['bug-1523688670492627115-8bb16de1f5b4c20e.png']);
+});
+
+test('the 19-digit Discord message id is not too long for the name pattern', () => {
+  // The id in every real filename here is 19 characters. A pattern sized for
+  // something shorter would match nothing and report a clean board.
+  assert.equal(describedAttachments(REAL).length, 1);
+});
+
+test('both /gds/ and /bongos/ spellings of the route are recognised', () => {
+  const a = describedAttachments('/api/gds/bug-attachments/bug-1-0123456789abcdef.png');
+  const b = describedAttachments('/api/bongos/bug-attachments/bug-1-0123456789abcdef.png');
+  assert.deepEqual(a, b, 'the route was renamed; a description can carry either');
+  assert.equal(a.length, 1);
+});
+
+test('the same file linked twice in one description is counted once', () => {
+  const text = `![a](${REAL}) and again ![a](${REAL})`;
+  assert.equal(describedAttachments(text).length, 1);
+});
+
+test('a description with no attachment yields nothing — and that is not an error', () => {
+  assert.deepEqual(describedAttachments('a bug about the hall sidebar'), []);
+  assert.deepEqual(describedAttachments(null), []);
+  assert.deepEqual(describedAttachments(undefined), []);
+});
+
+test('a malformed name is NOT extracted — the pattern is the traversal defence too', () => {
+  assert.deepEqual(describedAttachments('/api/gds/bug-attachments/../../etc/passwd'), []);
+  assert.deepEqual(describedAttachments('/api/gds/bug-attachments/bug-1-short.png'), []);
+  assert.deepEqual(describedAttachments('/api/gds/bug-attachments/bug-1-0123456789abcdef.exe'), []);
+});
+
+test('auditRows names the TASK for each missing file, not just the file', () => {
+  const rows = [
+    { id: '1003718', title: 'a re-filed bug', description: `![x](${REAL})` },
+    { id: '1003719', title: 'no images here', description: 'plain prose' },
+  ];
+  const r = auditRows(rows, () => false);
+  assert.equal(r.described.length, 1);
+  assert.equal(r.missing.length, 1);
+  assert.equal(r.missing[0].taskId, '1003718', '"a file is gone" is not actionable; "the image in task N is gone" is');
+  assert.equal(r.present, 0);
+});
+
+test('a present file is not reported missing', () => {
+  const rows = [{ id: '1', title: 't', description: `![x](${REAL})` }];
+  const r = auditRows(rows, () => true);
+  assert.deepEqual(r.missing, []);
+  assert.equal(r.present, 1);
+});
+
+test('the same file described by two tasks is reported for BOTH', () => {
+  // task 1002076 was re-filed as 1003718 and both descriptions carry the links;
+  // each renders a broken image, so each is worth naming.
+  const rows = [
+    { id: '1002076', title: 'original', description: `![x](${REAL})` },
+    { id: '1003718', title: 're-file', description: `![x](${REAL})` },
+  ];
+  const r = auditRows(rows, () => false);
+  assert.equal(r.missing.length, 2);
+});
+
+test('the store resolves against the INSTANCE root, not the core package (task 1003918)', () => {
+  // The old default was __dirname/../../var, which on a vendored core is
+  // node_modules/@bongos/core/var — wiped by every reinstall, and these files
+  // cannot be regenerated.
+  const prev = process.env.BUG_ATTACHMENTS_DIR;
+  delete process.env.BUG_ATTACHMENTS_DIR;
+  try {
+    const dir = attachmentsDir();
+    assert.ok(!dir.includes('node_modules'), `the store must not live inside an installed package: ${dir}`);
+    assert.equal(path.basename(dir), 'bug-attachments');
+    assert.equal(path.basename(path.dirname(dir)), 'var');
+  } finally {
+    if (prev === undefined) delete process.env.BUG_ATTACHMENTS_DIR;
+    else process.env.BUG_ATTACHMENTS_DIR = prev;
+  }
+});
+
+test('BUG_ATTACHMENTS_DIR still wins outright', () => {
+  const prev = process.env.BUG_ATTACHMENTS_DIR;
+  process.env.BUG_ATTACHMENTS_DIR = '/srv/persistent/bug-attachments';
+  try {
+    assert.equal(attachmentsDir(), '/srv/persistent/bug-attachments',
+      'on a box whose instance root is impermanent, the override is the answer');
+  } finally {
+    if (prev === undefined) delete process.env.BUG_ATTACHMENTS_DIR;
+    else process.env.BUG_ATTACHMENTS_DIR = prev;
+  }
+});

package/tests/cli_surface.mjs

@@ -169,18 +169,47 @@ function runGuidance(fn, env) {
   const code =
     `const l=require(${JSON.stringify(path.join(REPO_ROOT, 'scripts', 'gds', 'cli-lib.js'))});` +
     `Promise.resolve(l[${JSON.stringify(fn)}]()).catch(()=>{});`;
+  // HOME ALONE IS NOT ISOLATION ON WINDOWS (task 1003941). cli-lib resolves the
+  // session through os.homedir(), which on win32 reads USERPROFILE and ignores
+  // HOME entirely — so the child found the DEVELOPER'S REAL session, requireSession
+  // succeeded, and the guidance these tests exist to read was never printed. That
+  // failed on any Windows box whose builder happened to be signed in, and went
+  // green again once their CLI session expired, which made it read as a flake.
+  //
+  // HOMEDRIVE/HOMEPATH are os.homedir()'s second win32 source, so all four go.
+  const HOMELESS = path.join(REPO_ROOT, 'no-such-home-for-tests');
   const r = spawnSync(process.execPath, ['-e', code], {
     encoding: 'utf8',
-    env: { ...process.env, ...env, HOME: path.join(REPO_ROOT, 'no-such-home-for-tests') },
+    env: {
+      ...process.env,
+      ...env,
+      HOME: HOMELESS,
+      USERPROFILE: HOMELESS,
+      HOMEDRIVE: '',
+      HOMEPATH: HOMELESS,
+    },
   });
   return `${r.stdout || ''}${r.stderr || ''}`;
 }
 
+// The isolation above either worked or it did not, and the difference is visible:
+// a child with no session PRINTS guidance, and a child that found one prints
+// nothing. Every assertion below that looks for something ABSENT is satisfied for
+// free by that silence, so the silence is checked for first (task 1003941).
+function guidanceOutput(fn, env) {
+  const out = runGuidance(fn, env);
+  assert.ok(out.trim().length > 0,
+    `${fn} printed NOTHING. That means the child found a real CLI session instead of `
+    + 'the blanked home, so this test is reading an unisolated environment and every '
+    + '"must not contain" assertion here is vacuous (task 1003941).');
+  return out;
+}
+
 const GUIDANCE = ['printUnauthGuidanceAndExit', 'printBoxScopeGuidanceAndExit', 'requireSession'];
 
 test('no guidance path speaks slash commands to a terminal reader', () => {
   for (const fn of GUIDANCE) {
-    const out = runGuidance(fn, { BONGOS_SURFACE: 'terminal' });
+    const out = guidanceOutput(fn, { BONGOS_SURFACE: 'terminal' });
     const leaks = [...out.matchAll(/\/builder-[a-z-]+/g)].map((m) => m[0]);
     assert.deepEqual(leaks, [], `${fn} leaked to a terminal reader: ${leaks.join(', ')}\n${out}`);
     assert.ok(!/node scripts\/gds\//.test(out), `${fn} told a terminal reader to run a repo script:\n${out}`);

package/tests/linkify_refs.mjs

@@ -290,6 +290,23 @@ t('a known idea link is never unwrapped by the past-mislink pass', () => {
   assert.equal(runIds(s, ids), s);
 });
 
+// task 1003935: the separator contract, stated rather than assumed.
+//
+// discoverDocs builds with path.join, so on Windows it returned
+// 'docs\\adr\\0001-….md' and the recursion assertion below — which compares against
+// 'docs/' — was permanently red. Nobody saw it: this file was in run-unit-tests'
+// INTEGRATION exclusion set while touching no database, so it ran in neither lane
+// (fixed in the same task). The assertion was right and the walker was wrong to
+// hand it OS-native paths, so the fix is here at the boundary; this test exists so
+// the next reader does not have to rediscover which of the two was at fault.
+t('discoverDocs returns POSIX-style paths on every platform (task 1003935)', () => {
+  const docs = discoverDocs();
+  const native = docs.filter((d) => d.includes('\\'));
+  assert.equal(native.length, 0,
+    `paths must not carry OS-native separators; got ${JSON.stringify(native.slice(0, 3))}`);
+  assert.ok(docs.some((d) => d.includes('/')), 'and nested paths must still be nested');
+});
+
 t('discoverDocs finds CLAUDE.md, recurses docs/ subdirs (only .md), skips the generated ideas file', () => {
   const docs = discoverDocs();
   assert.ok(docs.includes('CLAUDE.md'), 'includes CLAUDE.md');

package/tests/module_api_lazy.mjs

@@ -35,8 +35,13 @@ function loadedAfter(spec, read = null) {
     const ROOT = ${JSON.stringify(ROOT)};
     const m = require(path.join(ROOT, ${JSON.stringify(spec)}));
     ${read ? `void m[${JSON.stringify(read)}];` : ''}
+    // POSIX-normalised before filtering (task 1003941). path.relative returns
+    // backslashes on win32, so 'src/bongos/' matched NOTHING and every list came
+    // back empty — which made the two laziness assertions below pass VACUOUSLY on
+    // Windows: they assert that a filtered-empty list is empty. An eager require
+    // reintroduced at the doorway would have shipped green.
     const files = Object.keys(require.cache)
-      .map((f) => path.relative(ROOT, f))
+      .map((f) => path.relative(ROOT, f).split(path.sep).join('/'))
       .filter((f) => f.startsWith('src/bongos/'));
     process.stdout.write(JSON.stringify(files));
   `;
@@ -50,6 +55,32 @@ function loadedAfter(spec, read = null) {
   return JSON.parse(out);
 }
 
+// CALIBRATION — can the instrument see anything at all? (task 1003941)
+//
+// Every other assertion in this file has the shape "nothing heavy is in this
+// list", which an EMPTY list satisfies for free. So an empty list is not evidence
+// of laziness; it is evidence of nothing, and the two tests that guard the ADR
+// 0083 doorway invariant cannot tell the difference.
+//
+// That is not hypothetical. loadedAfter filtered on a 'src/bongos/' prefix after
+// path.relative, which returns BACKSLASHES on win32 — so on Windows the filter
+// matched nothing, every list was empty, and both doorway tests passed vacuously.
+// An eager require reintroduced at the doorway would have shipped green.
+//
+// The fix normalises separators, but a normalisation can break again silently, and
+// asserting the doorway's own list is non-empty would be wrong — loading NOTHING
+// from src/bongos/ is precisely what the doorway is supposed to do. So the probe
+// is calibrated against a module that certainly does load one. If this test fails,
+// every emptiness assertion below is meaningless and should be read as untested.
+test('CALIBRATION: the probe can see a src/bongos/ require at all', () => {
+  const files = loadedAfter('src/bongos/pool.js');
+  assert.ok(files.includes('src/bongos/pool.js'),
+    'requiring src/bongos/pool.js must show up in the probe\'s own list. It does not, so '
+    + 'the list is empty for reasons unrelated to laziness — check the path normalisation '
+    + 'in loadedAfter (task 1003941). Until this passes, every "loads nothing" assertion '
+    + `in this file is vacuous. Saw: ${JSON.stringify(files.slice(0, 5))}`);
+});
+
 test('importing the doorway loads no server: no pool, no auth, no routes', () => {
   const files = loadedAfter('src/module-api.js');
   const heavy = files.filter((f) => HEAVY.test(f));