@bongos/core 1.19.813 → 1.19.815

package/docs/copy-registry.json

@@ -3,9 +3,9 @@
   "generator": "scripts/gds/copy-inventory.js",
   "goal": 1000074,
   "counts": {
-    "strings": 1856,
-    "unique_ids": 1610,
-    "certain": 1856,
+    "strings": 1860,
+    "unique_ids": 1614,
+    "certain": 1860,
     "heuristic": 0,
     "duplicate_ids": 170
   },
@@ -13,7 +13,7 @@
     "builders-hall": {
       "at": "modules/hall-ui/public",
       "files": 86,
-      "strings": 1366
+      "strings": 1370
     },
     "status-dashboard": {
       "at": "modules/status-ui/public",
@@ -270,9 +270,9 @@
       "occurrences": 4,
       "at": [
         "modules/hall-ui/public/task.js:494",
-        "modules/hall-ui/public/task.js:518",
-        "modules/hall-ui/public/task.js:910",
-        "modules/hall-ui/public/task.js:922"
+        "modules/hall-ui/public/task.js:530",
+        "modules/hall-ui/public/task.js:959",
+        "modules/hall-ui/public/task.js:971"
       ]
     },
     {
@@ -348,8 +348,8 @@
       "text": "Copy prompt",
       "occurrences": 3,
       "at": [
-        "modules/hall-ui/public/task.js:742",
-        "modules/hall-ui/public/task.js:763",
+        "modules/hall-ui/public/task.js:791",
+        "modules/hall-ui/public/task.js:812",
         "modules/hall-ui/public/work.js:599"
       ]
     },
@@ -721,7 +721,7 @@
       "occurrences": 2,
       "at": [
         "modules/hall-ui/public/project-settings.js:242",
-        "modules/hall-ui/public/task.js:929"
+        "modules/hall-ui/public/task.js:978"
       ]
     },
     {
@@ -2154,7 +2154,7 @@
       "surface": "builders-hall",
       "text": "A dependency keeps this task out of the claimable queue until that one ships. Remove one with the × beside it under “Blocked by”.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 595,
+      "line": 607,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -2271,7 +2271,7 @@
       "surface": "builders-hall",
       "text": "A shipped task cannot be retired — it is immutable history now.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 719,
+      "line": 747,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -2316,7 +2316,7 @@
       "surface": "builders-hall",
       "text": "A task cannot wait for itself.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 837,
+      "line": 886,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -2415,7 +2415,7 @@
       "surface": "builders-hall",
       "text": "Add dependency",
       "file": "modules/hall-ui/public/task.js",
-      "line": 595,
+      "line": 607,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -2811,7 +2811,7 @@
       "surface": "builders-hall",
       "text": "Awaiting the grader, or a confirmation, before it can ship.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 698,
+      "line": 710,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3234,7 +3234,7 @@
       "surface": "builders-hall",
       "text": "Choose a goal first.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 885,
+      "line": 934,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3540,7 +3540,7 @@
       "surface": "builders-hall",
       "text": "Confirm that verification for #{…} actually passed?",
       "file": "modules/hall-ui/public/task.js",
-      "line": 778,
+      "line": 827,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3675,7 +3675,7 @@
       "surface": "builders-hall",
       "text": "Copy prompt",
       "file": "modules/hall-ui/public/task.js",
-      "line": 742,
+      "line": 791,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3684,7 +3684,7 @@
       "surface": "builders-hall",
       "text": "Copy prompt",
       "file": "modules/hall-ui/public/task.js",
-      "line": 763,
+      "line": 812,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -3918,7 +3918,7 @@
       "surface": "builders-hall",
       "text": "Could not load",
       "file": "modules/hall-ui/public/task.js",
-      "line": 929,
+      "line": 978,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -4062,7 +4062,7 @@
       "surface": "builders-hall",
       "text": "Could not load {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 922,
+      "line": 971,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -4917,7 +4917,7 @@
       "surface": "builders-hall",
       "text": "Enter the id of the task this one should wait for.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 834,
+      "line": 883,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -6231,7 +6231,7 @@
       "surface": "builders-hall",
       "text": "Last claimed by",
       "file": "modules/hall-ui/public/task.js",
-      "line": 640,
+      "line": 652,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6753,7 +6753,7 @@
       "surface": "builders-hall",
       "text": "Move to goal",
       "file": "modules/hall-ui/public/task.js",
-      "line": 565,
+      "line": 577,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7059,7 +7059,7 @@
       "surface": "builders-hall",
       "text": "No open goals in this version",
       "file": "modules/hall-ui/public/task.js",
-      "line": 564,
+      "line": 576,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7212,7 +7212,7 @@
       "surface": "builders-hall",
       "text": "Not found",
       "file": "modules/hall-ui/public/task.js",
-      "line": 917,
+      "line": 966,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -7842,7 +7842,7 @@
       "surface": "builders-hall",
       "text": "Pick a priority first.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 819,
+      "line": 868,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -7968,7 +7968,7 @@
       "surface": "builders-hall",
       "text": "Priority is already {…}.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 822,
+      "line": 871,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -8715,7 +8715,7 @@
       "surface": "builders-hall",
       "text": "Retire task {…}? It leaves the claimable queue. Promote restores it to the backlog.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 872,
+      "line": 921,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -8733,7 +8733,7 @@
       "surface": "builders-hall",
       "text": "Retire this task",
       "file": "modules/hall-ui/public/task.js",
-      "line": 726,
+      "line": 775,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8742,7 +8742,7 @@
       "surface": "builders-hall",
       "text": "Retire this task…",
       "file": "modules/hall-ui/public/task.js",
-      "line": 737,
+      "line": 786,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8850,7 +8850,7 @@
       "surface": "builders-hall",
       "text": "Say why it is being retired — the reason goes in the record.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 871,
+      "line": 920,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -9093,7 +9093,7 @@
       "surface": "builders-hall",
       "text": "Set priority",
       "file": "modules/hall-ui/public/task.js",
-      "line": 595,
+      "line": 607,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9174,7 +9174,7 @@
       "surface": "builders-hall",
       "text": "Ship it",
       "file": "modules/hall-ui/public/task.js",
-      "line": 694,
+      "line": 706,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9192,7 +9192,7 @@
       "surface": "builders-hall",
       "text": "Shipped {…}{…}, {…}.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 675,
+      "line": 687,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9408,7 +9408,7 @@
       "surface": "builders-hall",
       "text": "Someone is holding a claim on this task. It has to be released before the task can be retired.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 721,
+      "line": 749,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9660,7 +9660,7 @@
       "surface": "builders-hall",
       "text": "Task {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 518,
+      "line": 530,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9669,7 +9669,7 @@
       "surface": "builders-hall",
       "text": "Task {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 910,
+      "line": 959,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9678,7 +9678,7 @@
       "surface": "builders-hall",
       "text": "Task {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 922,
+      "line": 971,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9714,7 +9714,7 @@
       "surface": "builders-hall",
       "text": "Tasks in the ledger are numbered separately from GitHub pull requests, so this may be a PR number rather than a task. The work board lists everything that does exist.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 910,
+      "line": 959,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10119,7 +10119,7 @@
       "surface": "builders-hall",
       "text": "The reason is recorded in the audit log. This is recoverable: a retired task can be restored to the backlog with Promote.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 726,
+      "line": 775,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10299,7 +10299,7 @@
       "surface": "builders-hall",
       "text": "The task feed did not answer. Nothing on the record has changed, only the read failed. Try again in a moment, or go back.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 922,
+      "line": 971,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10650,7 +10650,7 @@
       "surface": "builders-hall",
       "text": "This task has shipped and its credits have landed. Neither Ship it nor Confirm is available.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 703,
+      "line": 715,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10659,7 +10659,7 @@
       "surface": "builders-hall",
       "text": "This task is already retired. Promote restores it to the backlog.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 723,
+      "line": 751,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10884,7 +10884,7 @@
       "surface": "builders-hall",
       "text": "Wait for task",
       "file": "modules/hall-ui/public/task.js",
-      "line": 595,
+      "line": 607,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11217,7 +11217,7 @@
       "surface": "builders-hall",
       "text": "Why retire this task?",
       "file": "modules/hall-ui/public/task.js",
-      "line": 726,
+      "line": 775,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11392,6 +11392,42 @@
       "origin": "js-notice",
       "confidence": "certain"
     },
+    {
+      "id": "bcf33947aff6",
+      "surface": "builders-hall",
+      "text": "You created this task and it is already retired.",
+      "file": "modules/hall-ui/public/task.js",
+      "line": 767,
+      "origin": "js-markup",
+      "confidence": "certain"
+    },
+    {
+      "id": "23c68db6db4e",
+      "surface": "builders-hall",
+      "text": "You created this task, but it has already moved past planning. Retiring it now is a change to the record, so it needs a Metic.",
+      "file": "modules/hall-ui/public/task.js",
+      "line": 772,
+      "origin": "js-markup",
+      "confidence": "certain"
+    },
+    {
+      "id": "cf0c107a39fc",
+      "surface": "builders-hall",
+      "text": "You created this task, but it has shipped. Shipped work is immutable history — nobody can retire it, whatever their rank.",
+      "file": "modules/hall-ui/public/task.js",
+      "line": 765,
+      "origin": "js-markup",
+      "confidence": "certain"
+    },
+    {
+      "id": "b91183c02c63",
+      "surface": "builders-hall",
+      "text": "You created this task, but someone is holding a claim on it. Once that is released you can retire it yourself.",
+      "file": "modules/hall-ui/public/task.js",
+      "line": 770,
+      "origin": "js-markup",
+      "confidence": "certain"
+    },
     {
       "id": "da274462bb30",
       "surface": "builders-hall",
@@ -12126,7 +12162,7 @@
       "surface": "builders-hall",
       "text": "e.g. superseded by task 1002891",
       "file": "modules/hall-ui/public/task.js",
-      "line": 726,
+      "line": 775,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -12936,7 +12972,7 @@
       "surface": "builders-hall",
       "text": "task id",
       "file": "modules/hall-ui/public/task.js",
-      "line": 595,
+      "line": 607,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -13737,7 +13773,7 @@
       "surface": "builders-hall",
       "text": "{…}, no such task",
       "file": "modules/hall-ui/public/task.js",
-      "line": 910,
+      "line": 959,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -13782,7 +13818,7 @@
       "surface": "builders-hall",
       "text": "{…}{…} · {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 637,
+      "line": 649,
       "origin": "js-markup",
       "confidence": "certain"
     },

package/docs/module-api-changelog.md

@@ -2100,5 +2100,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.811 with no explicit bump. run 35191850392. (task 1002620)
   1.19.813 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.812 with no explicit bump. run 35193306517. (task 1002620)
+  1.19.814 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.813 with no explicit bump. run 35194334679. (task 1002620)
+  1.19.815 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.814 with no explicit bump. run 35197139985. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/agents/lib/validate.js

@@ -45,7 +45,7 @@
 
 // The WIRED event set for v1. Widening this is a deliberate act that must land
 // together with something that actually dispatches the new event.
-const EVENT_CATALOG = Object.freeze(['task.shipped']);
+const EVENT_CATALOG = Object.freeze(['task.shipped', 'idea.graded.full']);
 
 // Mirrors agents_definitions_trigger_type_chk. 'event' consumes the catalog above;
 // 'on-demand' is the historian shape (a builder asks, the agent answers).

package/modules/dev-box/app/src/vendor/bongos-client.cjs

@@ -898,7 +898,7 @@ function createClient(opts = {}) {
       getTasksId: (args) => request("GET", "/tasks/{id}", { hasBody: false }, args),
       // PATCH /tasks/{id} — rank: metic+archon — PATCH /tasks/:id
       patchTasksId: (args) => request("PATCH", "/tasks/{id}", { hasBody: true }, args),
-      // POST /tasks/{id}/abandon — rank: metic+archon — POST /tasks/:id/abandon
+      // POST /tasks/{id}/abandon — rank: any-builder — POST /tasks/:id/abandon
       postTasksIdAbandon: (args) => request("POST", "/tasks/{id}/abandon", { hasBody: true }, args),
       // POST /tasks/{id}/attest-gate — rank: any-builder — POST /tasks/:id/attest-gate
       postTasksIdAttestGate: (args) => request("POST", "/tasks/{id}/attest-gate", { hasBody: true }, args),

package/modules/discord/discord-channels.js

@@ -40,7 +40,46 @@ const VIEW_CHANNEL = 1024n;
 // `view: "<rank>"` grants that rank and everyone above it.
 const RANK_LADDER = ['xenos', 'thetes', 'metic', 'archon'];
 
-const CONFIG_PATH = path.resolve(__dirname, '..', '..', 'docs', 'discord', 'channels.json');
+// WHERE channels.json LIVES (task 1003973). The layout file describes ONE
+// guild's channels, names and topics — instance identity, which ADR 0062 §7
+// puts on the HOST side of the core/host cut. So it is NOT published in the
+// neutral core, and resolving it against the core package (as this module used
+// to) means that on a deployed instance — where the module lives under
+// node_modules/@bongos/core/modules/discord/ — the file is simply not there and
+// every plan/apply died as a bare 500.
+//
+// Resolution order, first hit wins:
+//   1. <instance root>/docs/discord/channels.json  (ADR 0108's instance-root
+//      injection: <PREFIX>_INSTANCE_ROOT env, a bongos.config.json pointer, or
+//      process.cwd()) — each instance reads its OWN layout.
+//   2. <core root>/docs/discord/channels.json — the historical path, kept so a
+//      core checkout that is not the instance root still resolves.
+// In a single checkout (the live instance today) instance root === core root, so
+// this is byte-identical to the old constant.
+const CORE_CONFIG_PATH = path.resolve(__dirname, '..', '..', 'docs', 'discord', 'channels.json');
+
+function instanceConfigPath() {
+  // Through the published doorway (ADR 0083), which is where resolveInstanceRoot
+  // lives — the same core/host resolution the government pack already uses.
+  try {
+    const root = require('../../src/module-api').resolveInstanceRoot();
+    return path.resolve(root, 'docs', 'discord', 'channels.json');
+  } catch (e) { return null; }
+}
+
+// The path channels.json is actually read from, or the instance-root candidate
+// when neither exists (so the error names where the operator should put it).
+function resolveConfigPath() {
+  const inst = instanceConfigPath();
+  for (const c of [inst, CORE_CONFIG_PATH]) {
+    if (c && fs.existsSync(c)) return c;
+  }
+  return inst || CORE_CONFIG_PATH;
+}
+
+// Back-compat alias for the old export. Callers that want the live answer use
+// resolveConfigPath(); this stays the core-package path it always named.
+const CONFIG_PATH = CORE_CONFIG_PATH;
 
 // ---------------------------------------------------------------------------
 // PURE helpers (no Discord, no IO) — the load-bearing, fully-tested logic.
@@ -340,11 +379,41 @@ function planChannelReconcile(snapshot, config, ctx) {
 // IO + Discord REST (impure) — invoked by the bot sweep and the Archon command.
 // ---------------------------------------------------------------------------
 
-function loadConfig(configPath = CONFIG_PATH) {
-  const raw = fs.readFileSync(configPath, 'utf8');
+// Throws a TAGGED error when the layout file is absent (code CONFIG_NOT_FOUND,
+// carrying the path it looked at) so the callers below can report 'channels.json
+// not readable at <path>' instead of collapsing into a bare 500 — the silent
+// failure half of task 1003973.
+function loadConfig(configPath) {
+  const p = configPath || resolveConfigPath();
+  let raw;
+  try {
+    raw = fs.readFileSync(p, 'utf8');
+  } catch (e) {
+    if (e && e.code === 'ENOENT') {
+      const err = new Error(`channels.json not readable at ${p}`);
+      err.code = 'CONFIG_NOT_FOUND';
+      err.configPath = p;
+      throw err;
+    }
+    throw e;
+  }
   return JSON.parse(raw);
 }
 
+// Run a deps.loadConfig() that may be missing its file, and turn the tagged
+// CONFIG_NOT_FOUND into the same {ok:false, reason} shape the no_guild /
+// no_token paths already use, so every caller reports it the same way.
+function tryLoadConfig(deps) {
+  try {
+    return { config: deps.loadConfig() };
+  } catch (err) {
+    if (err && err.code === 'CONFIG_NOT_FOUND') {
+      return { fail: { ok: false, reason: 'no_config', configPath: err.configPath, detail: err.message } };
+    }
+    throw err;
+  }
+}
+
 // The managing bot's own user id, used to grant it an explicit VIEW overwrite on
 // any channel it restricts so it never locks itself out. Best-effort: returns
 // null if the client/user isn't resolvable (then the self-lockout guard is a
@@ -407,7 +476,9 @@ async function discordRest(token, method, urlPath, body) {
 function computePlan(deps = realDeps) {
   const guild = deps.getGuild();
   if (!guild) return { ok: false, reason: 'no_guild', ops: [], warnings: [] };
-  const config = deps.loadConfig();
+  const loaded = tryLoadConfig(deps);
+  if (loaded.fail) return { ...loaded.fail, ops: [], warnings: [] };
+  const config = loaded.config;
   const roleMap = deps.loadRoleMap();
   const ctx = { everyoneId: String(guild.id), roleMap, botId: botIdFromGuild(guild) };
   const snapshot = snapshotFromGuild(guild);
@@ -435,7 +506,9 @@ async function reconcileChannels(deps = realDeps) {
   const token = deps.loadBotToken();
   if (!token) return { ok: false, reason: 'no_token', applied: 0, failed: 0 };
 
-  const config = deps.loadConfig();
+  const loaded = tryLoadConfig(deps);
+  if (loaded.fail) return { ...loaded.fail, applied: 0, failed: 0 };
+  const config = loaded.config;
   const roleMap = deps.loadRoleMap();
   const ctx = { everyoneId: String(guild.id), roleMap, botId: botIdFromGuild(guild) };
   const snapshot = snapshotFromGuild(guild);
@@ -509,11 +582,13 @@ module.exports = {
   planChannelReconcile,
   // io
   loadConfig,
+  resolveConfigPath,
   snapshotFromGuild,
   computePlan,
   computeSnapshotConfig,
   reconcileChannels,
   CONFIG_PATH,
+  CORE_CONFIG_PATH,
   VIEW_CHANNEL,
   RANK_LADDER,
 };

package/modules/discord/routes/discord.js

@@ -79,6 +79,18 @@ function registerSeams() {
       console.log('[discord] role-sync (non-blocking):', e && e.message)));
 }
 
+// A !ok result from the channels module is either 'the bot is not connected'
+// or 'the layout file is not where I looked'. The second used to surface as a
+// bare 500 with the reason only in the server log, which made a missing
+// channels.json indistinguishable from a bot outage (task 1003973) — so it gets
+// its own code and names the path it tried.
+function failFor(res, r) {
+  if (r.reason === 'no_config') {
+    return res.fail('config_not_found', 503, { reason: r.reason, detail: r.detail, config_path: r.configPath });
+  }
+  return res.fail('bot_unavailable', 503, { reason: r.reason });
+}
+
 module.exports = function buildDiscordRouter() {
   registerSeams();
   const router = express.Router();
@@ -92,7 +104,7 @@ module.exports = function buildDiscordRouter() {
       const channels = require('../discord-channels');
       const plan = channels.computePlan();
       if (!plan.ok) {
-        return res.fail('bot_unavailable', 503, { reason: plan.reason });
+        return failFor(res, plan);
       }
       return res.json({ ok: true, guild_id: plan.guildId, op_count: plan.ops.length, ops: plan.ops, warnings: plan.warnings });
     } catch (err) {
@@ -131,7 +143,7 @@ module.exports = function buildDiscordRouter() {
       const channels = require('../discord-channels');
       const result = await channels.reconcileChannels();
       if (!result.ok) {
-        return res.fail('bot_unavailable', 503, { reason: result.reason });
+        return failFor(res, result);
       }
       return res.json({ ok: true, applied: result.applied, failed: result.failed, total: result.total, warnings: result.warnings });
     } catch (err) {