@bongos/core 1.19.803 → 1.19.804

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.803",
-  "core_contract": "1.19.803",
-  "source_commit": "64756c1e9ea07986f673c430081e2f89b870e038",
+  "core_version": "1.19.804",
+  "core_contract": "1.19.804",
+  "source_commit": "992839692e5a396ca7655a00df02413a3300b72a",
   "source_ref": "HEAD",
-  "built_at": "2026-09-17T02:45:59.094Z",
+  "built_at": "2026-09-17T03:35:15.794Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 487,
     "agent_docs_stubbed": 25,
-    "functional_verbatim": 2190,
+    "functional_verbatim": 2191,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2702,
-  "tree_sha256": "0103e5b2dbd5bc126390f3057c7fe8bbcb65f2f1c76c6e63a108dada00d358b2",
+  "file_count": 2703,
+  "tree_sha256": "773756af73632e2824a78bf24ff19e17d3c1e2c077d511030de84bda409ed684",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2532,7 +2532,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "3eb224e03b2a96ab275cd972eab2c9db4ae8b16b0b7297aa8bc5701857e27660"
+      "sha256": "b1b8571ef8f537feeffbca2a68ee1bb71b5d127bbfcfe1a45b3a3ac0d807e717"
     },
     {
       "path": "docs/modules-contract.md",
@@ -5052,12 +5052,12 @@
     {
       "path": "modules/hall-ui/public/people.html",
       "mode": "0000644",
-      "sha256": "5e5c99eab08f89feb05ab4db5015d6db3a78324777ffad245aa03c91a633032e"
+      "sha256": "ee7118a1d61518750d4ec105d9965a92784ad1564f7e6b75496d412b9d54be85"
     },
     {
       "path": "modules/hall-ui/public/people.js",
       "mode": "0000644",
-      "sha256": "145f767f473b11c222bde97e5de519c9eb0a9be0ddb2f75969d35dff086b3e01"
+      "sha256": "8834c3f6ec31d669dafc268ffbc12c9375e9ca4a8b00c45b164aa2d103af8db9"
     },
     {
       "path": "modules/hall-ui/public/people.states.json",
@@ -7712,12 +7712,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "eb3019123b9a5320bb5e3af69404dd3d230788a4fce4746e108f27aa93c05d99"
+      "sha256": "95dd4df126fd7a7617f5a1bc84c6f0ad6403d59edb377102978beab0180f0dca"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "921560195171c3d526e3f0b9b97702949a4cc50035cf910141d7f6e307b28cbb"
+      "sha256": "8cfddd30203037f279a7c1d4e5205bfcda5b464b57022c5af3db7da4ac930e70"
     },
     {
       "path": "public-docs/index.html",
@@ -9607,7 +9607,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "ca2eb0aedd6b859a96a1ea7e8762c4694cd0090d55e83864108f575a3ee30345"
+      "sha256": "8778f98197e12eaa8fc397413c13584bc079d72bedb8737ba4a7db15109bb497"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -12129,6 +12129,11 @@
       "mode": "0000644",
       "sha256": "6c623a5abe9aadf4821ad8ca291fb5d7805a7a5bc874bfc3cd7e51e83de289d2"
     },
+    {
+      "path": "tests/people_directory_clip.mjs",
+      "mode": "0000644",
+      "sha256": "a7d4e29162194a67e2f1b948d0522f1ecdff11218d49fbd2b9d7eb0be1cc624c"
+    },
     {
       "path": "tests/permission_path.mjs",
       "mode": "0000644",
@@ -12217,7 +12222,7 @@
     {
       "path": "tests/profile_route.mjs",
       "mode": "0000644",
-      "sha256": "d70924dd2ddfc4e05c4b52d9763d76b0a68cf0ed16db6ffd1b07a1834bef0890"
+      "sha256": "ac7f07f4226ed410012ee2650e1870c109d0f3eb8b9142208d8a339ebff27e6c"
     },
     {
       "path": "tests/profile_ui_cross_project.mjs",

package/docs/module-api-changelog.md

@@ -2080,5 +2080,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.801 with no explicit bump. run 35174865190. (task 1002620)
   1.19.803 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.802 with no explicit bump. run 35175617185. (task 1002620)
+  1.19.804 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.803 with no explicit bump. run 35178689663. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/hall-ui/public/people.html

@@ -39,6 +39,10 @@
           <div id="people-body">
             <div class="profile__placeholder">Loading the directory…</div>
           </div>
+          <!-- task 1003110: the clipped-directory footnote. Hidden unless the
+               response came back FULL, which is the only truncation signal the
+               rollup offers; people.js writes it. -->
+          <p class="ledger__note" id="people-foot" hidden></p>
         </section>
       </main>
 

package/modules/hall-ui/public/people.js

@@ -25,6 +25,7 @@
   var body = document.getElementById('people-body');
   var sub = document.getElementById('people-sub');
   var countPill = document.getElementById('people-count');
+  var foot = document.getElementById('people-foot');
 
   function fmtRecency(iso) {
     if (!iso) return '—';
@@ -73,6 +74,23 @@
     }).join('') + '</span>';
   }
 
+  // THE DIRECTORY ASKS FOR THE ENDPOINT MAXIMUM, so a full response is the only
+  // truncation signal that exists. `GET /scouting` clamps at parsePagination
+  // maxLimit: 500, takes no offset, and `listScoutingRollup` returns rows with no
+  // count of the whole set — so `length === DIRECTORY_LIMIT` means "at least this
+  // many", never "exactly this many", and there is nothing else to read it from.
+  // ONE constant feeds the request AND every sentence written about it, so the
+  // number a reader is shown can never drift from the number that was asked for.
+  //
+  // This is part 1 of task 1003110 — the honest half, which removes the
+  // silent-lie property whatever the real count turns out to be. Part 2 is
+  // server-offset paging, and it is deliberately NOT here: the kit has carried
+  // the mode since task 1003281 (`makeLedger({ serverPager, onPage })`), but the
+  // ROUTE cannot serve it — no offset parameter, no total, a hard 500 ceiling —
+  // so paging this page is a server change first. Its trigger is a directory
+  // approaching ~400; a read on 2026-09-16 returned far fewer.
+  var DIRECTORY_LIMIT = 500;
+
   var all = [];
   var query = '';
   var craft = '';
@@ -143,10 +161,31 @@
         + 'and none are listed without it. Their work still shows on each project’s own ledger.');
       return;
     }
-    if (countPill) { countPill.textContent = String(all.length); countPill.hidden = false; }
+    // A FULL PAGE IS A CLIPPED PAGE. Every sentence below has to hedge when this
+    // is true, because each of them otherwise states a total the page cannot know.
+    var clipped = all.length >= DIRECTORY_LIMIT;
+    if (countPill) {
+      countPill.textContent = clipped ? fmtInt(DIRECTORY_LIMIT) + '+' : String(all.length);
+      countPill.hidden = false;
+    }
     if (sub) {
-      sub.textContent = fmtInt(all.length) + ' builder' + (all.length === 1 ? '' : 's') + ' listed across hosted projects, ranked by track record. '
-        + 'Descriptive only — cross-project numbers never carry authority here.';
+      sub.textContent = clipped
+        ? 'Showing the first ' + fmtInt(DIRECTORY_LIMIT) + ' builders across hosted projects, ranked by track record — there are more than this page can load. '
+          + 'Descriptive only — cross-project numbers never carry authority here.'
+        : fmtInt(all.length) + ' builder' + (all.length === 1 ? '' : 's') + ' listed across hosted projects, ranked by track record. '
+          + 'Descriptive only — cross-project numbers never carry authority here.';
+    }
+    // THE LENSES LIE HARDER THAN THE COUNT DOES, and that is worth its own
+    // sentence. Search, sort and the craft filter all re-order the set this page
+    // already loaded (see SORTS above) — so on a clipped directory "most karma"
+    // is the most karma AMONG THE TOP 500 BY TRACK RECORD, and a builder outside
+    // that 500 cannot be found by any of them. A reader who is told only that the
+    // list is long would still trust the search.
+    if (foot) {
+      foot.textContent = clipped
+        ? 'The directory is clipped at the first ' + fmtInt(DIRECTORY_LIMIT) + ' by track record. Search and the sort lenses only re-order what this page loaded, so a builder outside that ' + fmtInt(DIRECTORY_LIMIT) + ' will not appear in them.'
+        : '';
+      foot.hidden = !clipped;
     }
     var crafts = [];
     all.forEach(function (b) {
@@ -194,7 +233,7 @@
     body.textContent = msg;
   }
 
-  fetch('/api/gds/scouting?limit=500', { headers: { Accept: 'application/json' } })
+  fetch('/api/gds/scouting?limit=' + DIRECTORY_LIMIT, { headers: { Accept: 'application/json' } })
     .then(function (r) {
       if (r.status === 403 || r.status === 401) { throw { gated: true }; }
       if (!r.ok) throw new Error('http ' + r.status);

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.803",
+  "version": "1.19.804",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.803",
+      "version": "1.19.804",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.803",
+  "version": "1.19.804",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.803'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.804'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/people_directory_clip.mjs

@@ -0,0 +1,219 @@
+// tests/people_directory_clip.mjs — the People directory says so when it is
+// clipped (task 1003110, goal 1000095).
+//
+// WHY THIS FILE EXISTS. `people.js` asks `GET /scouting` for 500 rows, which is
+// that route's HARD CEILING (parsePagination maxLimit: 500). The rollup returns
+// no count of the whole set and the route takes no offset, so a response that
+// comes back FULL is the only truncation signal the page will ever get — and
+// until this task the page simply printed "500 builders listed" and said nothing
+// else. A directory that lies by omission is worse than one that admits it is
+// incomplete.
+//
+// It runs the REAL people.js in a vm against a stub DOM and a fake fetch, so
+// what is asserted is the sentence a reader actually sees, not a regex agreeing
+// with a regex. A source-text assertion would have passed just as happily with
+// the comparison written the wrong way round.
+//
+// The four behaviours:
+//   1. the page asks for exactly the number its copy then names (no drift)
+//   2. a SHORT response is not hedged — the exact count is the honest one
+//   3. a FULL response hedges every sentence that states a total: the pill, the
+//      subtitle, and a footnote about the lenses
+//   4. one row short of the ceiling is NOT clipped (the boundary, in the
+//      direction that would otherwise cry wolf on every load)
+//
+// Run:  node tests/people_directory_clip.mjs
+import { strict as assert } from 'node:assert';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+import { makeRunner } from './helpers.mjs';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const read = (rel) => fs.readFileSync(path.join(ROOT, rel), 'utf8');
+const KIT_JS = read('modules/hall-ui/public/hall-kit.js');
+const PEOPLE_JS = read('modules/hall-ui/public/people.js');
+const PEOPLE_HTML = read('modules/hall-ui/public/people.html');
+
+// The route's ceiling, spelled here as the CONTRACT rather than read out of the
+// page — a test that imports the page's own constant cannot notice it changing.
+const CEILING = 500;
+
+const { test, summary } = makeRunner();
+const tick = () => new Promise((r) => setTimeout(r, 0));
+
+function makeEl(id) {
+  return {
+    id,
+    innerHTML: '', textContent: '', value: '',
+    hidden: false, disabled: false, className: '',
+    options: [], style: {}, dataset: {},
+    classList: { add() {}, remove() {}, toggle() {}, contains: () => false },
+    appendChild() {}, setAttribute() {}, removeAttribute() {},
+    addEventListener() {},
+    querySelector() { return makeEl(); },
+    querySelectorAll() { return []; },
+  };
+}
+
+// `count` builders, each distinct enough that a filter lens has something to bite.
+function buildersFor(count) {
+  return Array.from({ length: count }, (_, i) => ({
+    github_id: 1000 + i,
+    github_login: `builder${i}`,
+    display_name: `Builder ${i}`,
+    avatar_url: null,
+    project_count: 1,
+    total_credits: count - i,
+    total_tasks_shipped: 1,
+    total_karma: 1,
+    last_active: '2026-09-01T00:00:00Z',
+    disciplines: ['engineer'],
+  }));
+}
+
+function harness({ count }) {
+  const els = new Map();
+  const getEl = (id) => {
+    if (!els.has(id)) els.set(id, makeEl(id));
+    return els.get(id);
+  };
+  const documentObj = {
+    documentElement: { dataset: {}, style: {}, classList: { add() {}, remove() {} } },
+    getElementById: getEl,
+    querySelector(sel) { return getEl(String(sel).replace(/^#/, '')); },
+    querySelectorAll() { return []; },
+    createElement() { return makeEl(); },
+    addEventListener() {},
+  };
+
+  const requests = [];
+  const store = new Map();
+  const windowObj = {
+    location: { assign() {}, href: '/people' },
+    localStorage: {
+      getItem: (k) => (store.has(k) ? store.get(k) : null),
+      setItem: (k, v) => store.set(k, String(v)),
+      removeItem: (k) => store.delete(k),
+    },
+    scrollTo() {},
+    addEventListener() {},
+    matchMedia: () => ({ matches: false, addEventListener() {}, addListener() {} }),
+    OTBBranding: { currencyLabel: () => 'Credits' },
+    OTB: {
+      escapeHtml: (s) => String(s == null ? '' : s),
+      $: (sel) => documentObj.querySelector(sel),
+      num: (n) => Number(n) || 0,
+      fmtInt: (n) => String(Number(n) || 0),
+      fmtCompact: (n) => String(Number(n) || 0),
+      fmtDate: (iso) => String(iso ?? '').slice(0, 10),
+      rankLabel: (r) => String(r ?? ''),
+      toast() {},
+    },
+  };
+
+  const sandbox = {
+    window: windowObj, document: documentObj, location: windowObj.location,
+    console: { error() {}, warn() {}, log() {} },
+    setTimeout, clearTimeout, URLSearchParams, encodeURIComponent, Date, Math, JSON,
+    fetch: (url) => {
+      requests.push(String(url));
+      return Promise.resolve({
+        ok: true,
+        status: 200,
+        json: () => Promise.resolve({ builders: buildersFor(count) }),
+      });
+    },
+  };
+  sandbox.globalThis = sandbox;
+  vm.createContext(sandbox);
+  // The real kit, for the same reason sessions_kit_pager.mjs runs it: the page is
+  // held to the shipped contract, not to a stub that agrees with it.
+  vm.runInContext(KIT_JS, sandbox, { filename: 'hall-kit.js' });
+  vm.runInContext(PEOPLE_JS, sandbox, { filename: 'people.js' });
+
+  return { getEl, requests };
+}
+
+// ---------------------------------------------------------------------------
+
+await test('the page markup carries the footnote slot, hidden until the page writes it', () => {
+  assert.match(PEOPLE_HTML, /id="people-foot"/, 'the clipped-directory footnote has a mount');
+  const tag = PEOPLE_HTML.match(/<p[^>]*id="people-foot"[^>]*>/);
+  assert.ok(tag, 'the footnote is a <p>');
+  assert.match(tag[0], /\bhidden\b/, 'it starts hidden — an empty note is still a visible gap');
+  assert.match(tag[0], /class="ledger__note"/, "the shell's ledger footnote class, not a bespoke one");
+});
+
+await test('the page asks for exactly the ceiling, and asks for it ONCE', async () => {
+  const h = harness({ count: 3 });
+  await tick(); await tick();
+  assert.equal(h.requests.length, 1, 'one directory read');
+  assert.match(h.requests[0], /\/api\/gds\/scouting\?limit=/);
+  const limit = Number(new URLSearchParams(h.requests[0].split('?')[1]).get('limit'));
+  assert.equal(limit, CEILING, `the page must ask for the route ceiling (${CEILING})`);
+});
+
+await test('a SHORT directory is not hedged — the exact count is the honest one', async () => {
+  const h = harness({ count: 3 });
+  await tick(); await tick();
+  assert.equal(h.getEl('people-count').textContent, '3', 'the pill states the real count');
+  assert.equal(h.getEl('people-count').hidden, false);
+  assert.match(h.getEl('people-sub').textContent, /^3 builders listed/, 'the subtitle states the real count');
+  assert.doesNotMatch(h.getEl('people-sub').textContent, /first|more than/i,
+    'nothing is clipped, so nothing may suggest it is');
+  assert.equal(h.getEl('people-foot').hidden, true, 'no footnote on a complete directory');
+  assert.equal(h.getEl('people-foot').textContent, '', 'and no stale text left behind it');
+});
+
+await test('a FULL response hedges the pill, the subtitle AND the lenses', async () => {
+  const h = harness({ count: CEILING });
+  await tick(); await tick();
+
+  const pill = h.getEl('people-count').textContent;
+  assert.equal(pill, `${CEILING}+`, 'the pill may not state a total the page cannot know');
+
+  const sub = h.getEl('people-sub').textContent;
+  assert.match(sub, new RegExp(`first ${CEILING}\\b`), 'the subtitle says which slice this is');
+  assert.match(sub, /more than this page can load/, 'and says the directory is larger');
+  assert.doesNotMatch(sub, new RegExp(`^${CEILING} builders listed`),
+    'the old sentence claimed the slice was the whole set');
+
+  const foot = h.getEl('people-foot');
+  assert.equal(foot.hidden, false, 'the footnote is shown');
+  // THE LENSES ARE THE SHARPER LIE. Search/sort/craft re-order only the loaded
+  // set, so on a clipped directory a builder outside the top 500 cannot be found
+  // by any of them — a reader told only "the list is long" would still trust the
+  // search box.
+  assert.match(foot.textContent, /search/i, 'the footnote names the search');
+  assert.match(foot.textContent, /sort/i, 'and the sort lenses');
+  assert.match(foot.textContent, new RegExp(`will not appear`),
+    'and says plainly that a builder outside the slice is unreachable through them');
+});
+
+await test('one row short of the ceiling is NOT clipped', async () => {
+  const h = harness({ count: CEILING - 1 });
+  await tick(); await tick();
+  assert.equal(h.getEl('people-count').textContent, String(CEILING - 1),
+    'a nearly-full page is still a complete one');
+  assert.equal(h.getEl('people-foot').hidden, true, 'crying wolf here would train the notice away');
+});
+
+await test('every number in the clipped copy is the number that was requested', async () => {
+  const h = harness({ count: CEILING });
+  await tick(); await tick();
+  const limit = new URLSearchParams(h.requests[0].split('?')[1]).get('limit');
+  // The drift this guards: someone raises the request to 1000 and leaves "500"
+  // written in three sentences. Every integer the clipped copy prints must be
+  // the one the request carried.
+  const copy = [h.getEl('people-count').textContent, h.getEl('people-sub').textContent,
+    h.getEl('people-foot').textContent].join(' ');
+  const printed = copy.match(/\d+/g) || [];
+  assert.ok(printed.length >= 3, 'the clipped copy states the number more than once');
+  for (const n of printed) {
+    assert.equal(n, limit, `copy prints ${n} but the page requested ${limit}`);
+  }
+});
+
+summary();

package/tests/profile_route.mjs

@@ -651,8 +651,19 @@ await t('R06.3 GET /scouting drops the hidden, the provisional AND the private b
 await t('R06.3 the /people page reads /scouting and nothing else', async () => {
   // /people is the hall's render of the same endpoint, so whatever /scouting
   // drops, /people drops. Pin that it has no second data source.
-  const endpoints = [...sourceOf('modules/hall-ui/public/people.js').matchAll(/fetch\(\s*'([^']+)'/g)].map((m) => m[1]);
-  assert.deepEqual(endpoints, ['/api/gds/scouting?limit=500'], '/people has exactly one data source');
+  //
+  // MATCHED AS AN EXPRESSION, NOT A STRING LITERAL. This used to capture the
+  // whole URL out of `fetch('…')` and compare it to one hardcoded string, which
+  // pinned the row limit as a side effect of pinning the ENDPOINT — so task
+  // 1003110 naming that limit (`DIRECTORY_LIMIT`, the one constant that feeds
+  // both the request and the "showing the first N" copy) failed a test about
+  // data sources. What is load-bearing here is the count and the destination:
+  // ONE read, and it goes to the scouting rollup. How the query string is
+  // assembled is the page's business.
+  const args = [...sourceOf('modules/hall-ui/public/people.js').matchAll(/\bfetch\(\s*([^,)]+)/g)].map((m) => m[1].trim());
+  assert.equal(args.length, 1, '/people has exactly one data source');
+  assert.match(args[0], /^'\/api\/gds\/scouting\?limit='/,
+    'and it is the scouting rollup — nothing may re-enter through a second endpoint');
 });
 
 scout.server.close();