@bongos/core 1.19.790 → 1.19.791

package/docs/copy-registry.json

@@ -12,7 +12,7 @@
   "surfaces": {
     "builders-hall": {
       "at": "modules/hall-ui/public",
-      "files": 84,
+      "files": 85,
       "strings": 1303
     },
     "status-dashboard": {
@@ -269,10 +269,10 @@
       "text": "Task {…}",
       "occurrences": 4,
       "at": [
-        "modules/hall-ui/public/task.js:454",
-        "modules/hall-ui/public/task.js:463",
-        "modules/hall-ui/public/task.js:691",
-        "modules/hall-ui/public/task.js:703"
+        "modules/hall-ui/public/task.js:451",
+        "modules/hall-ui/public/task.js:460",
+        "modules/hall-ui/public/task.js:688",
+        "modules/hall-ui/public/task.js:700"
       ]
     },
     {
@@ -348,8 +348,8 @@
       "text": "Copy prompt",
       "occurrences": 3,
       "at": [
-        "modules/hall-ui/public/task.js:617",
-        "modules/hall-ui/public/task.js:637",
+        "modules/hall-ui/public/task.js:614",
+        "modules/hall-ui/public/task.js:634",
         "modules/hall-ui/public/work.js:599"
       ]
     },
@@ -700,7 +700,7 @@
       "occurrences": 2,
       "at": [
         "modules/hall-ui/public/project-settings.js:242",
-        "modules/hall-ui/public/task.js:710"
+        "modules/hall-ui/public/task.js:707"
       ]
     },
     {
@@ -979,8 +979,8 @@
       "text": "Let it be for now",
       "occurrences": 2,
       "at": [
-        "modules/hall-ui/public/studio.js:203",
-        "modules/hall-ui/public/studio.js:218"
+        "modules/hall-ui/public/studio.js:204",
+        "modules/hall-ui/public/studio.js:219"
       ]
     },
     {
@@ -1689,8 +1689,8 @@
       "text": "to tend now · {…}",
       "occurrences": 2,
       "at": [
-        "modules/hall-ui/public/studio.js:203",
-        "modules/hall-ui/public/studio.js:218"
+        "modules/hall-ui/public/studio.js:204",
+        "modules/hall-ui/public/studio.js:219"
       ]
     },
     {
@@ -2692,7 +2692,7 @@
       "surface": "builders-hall",
       "text": "Awaiting the grader, or a confirmation, before it can ship.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 607,
+      "line": 604,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3106,7 +3106,7 @@
       "surface": "builders-hall",
       "text": "Choose a goal first.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 666,
+      "line": 663,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3358,7 +3358,7 @@
       "surface": "builders-hall",
       "text": "Coach the grader",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 181,
+      "line": 182,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3412,7 +3412,7 @@
       "surface": "builders-hall",
       "text": "Confirm that verification for #{…} actually passed?",
       "file": "modules/hall-ui/public/task.js",
-      "line": 652,
+      "line": 649,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -3538,7 +3538,7 @@
       "surface": "builders-hall",
       "text": "Copy prompt",
       "file": "modules/hall-ui/public/task.js",
-      "line": 617,
+      "line": 614,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -3547,7 +3547,7 @@
       "surface": "builders-hall",
       "text": "Copy prompt",
       "file": "modules/hall-ui/public/task.js",
-      "line": 637,
+      "line": 634,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -3781,7 +3781,7 @@
       "surface": "builders-hall",
       "text": "Could not load",
       "file": "modules/hall-ui/public/task.js",
-      "line": 710,
+      "line": 707,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -3925,7 +3925,7 @@
       "surface": "builders-hall",
       "text": "Could not load {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 703,
+      "line": 700,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -4510,7 +4510,7 @@
       "surface": "builders-hall",
       "text": "Dismissed — the copy and visuals are good as shipped.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 356,
+      "line": 357,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -4942,7 +4942,7 @@
       "surface": "builders-hall",
       "text": "Filed as task {…} — this review is closed against it.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 445,
+      "line": 446,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -5131,7 +5131,7 @@
       "surface": "builders-hall",
       "text": "Full log",
       "file": "modules/hall-ui/public/task.js",
-      "line": 443,
+      "line": 440,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5860,7 +5860,7 @@
       "surface": "builders-hall",
       "text": "It shipped and it is live. Say what you see — your review coaches the grader and never blocks what shipped.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 201,
+      "line": 202,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -5869,7 +5869,7 @@
       "surface": "builders-hall",
       "text": "It shipped and it is live. Your review coaches the grader on how it judged the work, then remakes or tweaks the words or art only if they need it — it never blocks what shipped.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 202,
+      "line": 203,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6049,7 +6049,7 @@
       "surface": "builders-hall",
       "text": "Last claimed by",
       "file": "modules/hall-ui/public/task.js",
-      "line": 549,
+      "line": 546,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6085,7 +6085,7 @@
       "surface": "builders-hall",
       "text": "Let it be for now",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 203,
+      "line": 204,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6094,7 +6094,7 @@
       "surface": "builders-hall",
       "text": "Let it be for now",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 218,
+      "line": 219,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6364,7 +6364,7 @@
       "surface": "builders-hall",
       "text": "Looks good",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 161,
+      "line": 162,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6553,7 +6553,7 @@
       "surface": "builders-hall",
       "text": "Move to goal",
       "file": "modules/hall-ui/public/task.js",
-      "line": 510,
+      "line": 507,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6607,7 +6607,7 @@
       "surface": "builders-hall",
       "text": "Needs work",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 161,
+      "line": 162,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -6859,7 +6859,7 @@
       "surface": "builders-hall",
       "text": "No open goals in this version",
       "file": "modules/hall-ui/public/task.js",
-      "line": 509,
+      "line": 506,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7003,7 +7003,7 @@
       "surface": "builders-hall",
       "text": "Not found",
       "file": "modules/hall-ui/public/task.js",
-      "line": 698,
+      "line": 695,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -7075,7 +7075,7 @@
       "surface": "builders-hall",
       "text": "Note it",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 161,
+      "line": 162,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7084,7 +7084,7 @@
       "surface": "builders-hall",
       "text": "Noted on the review — it stays open.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 388,
+      "line": 389,
       "origin": "js-notice",
       "confidence": "certain"
     },
@@ -7246,7 +7246,7 @@
       "surface": "builders-hall",
       "text": "Only if it needs it — with the AI at your side, or on your own.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 181,
+      "line": 182,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7291,7 +7291,7 @@
       "surface": "builders-hall",
       "text": "Open in Sessions",
       "file": "modules/hall-ui/public/task.js",
-      "line": 443,
+      "line": 440,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7300,7 +7300,7 @@
       "surface": "builders-hall",
       "text": "Open in the copy desk",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 218,
+      "line": 219,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7381,7 +7381,7 @@
       "surface": "builders-hall",
       "text": "Open this review",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 203,
+      "line": 204,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -7966,7 +7966,7 @@
       "surface": "builders-hall",
       "text": "Read the handoff notes",
       "file": "modules/hall-ui/public/task.js",
-      "line": 441,
+      "line": 438,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8155,7 +8155,7 @@
       "surface": "builders-hall",
       "text": "Remake or tweak",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 181,
+      "line": 182,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8434,7 +8434,7 @@
       "surface": "builders-hall",
       "text": "Review how it judged this work, and teach it what good looked like.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 181,
+      "line": 182,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8722,7 +8722,7 @@
       "surface": "builders-hall",
       "text": "Session log{…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 447,
+      "line": 444,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8821,7 +8821,7 @@
       "surface": "builders-hall",
       "text": "Ship it",
       "file": "modules/hall-ui/public/task.js",
-      "line": 603,
+      "line": 600,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -8839,7 +8839,7 @@
       "surface": "builders-hall",
       "text": "Shipped {…}{…}, {…}.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 584,
+      "line": 581,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9136,7 +9136,7 @@
       "surface": "builders-hall",
       "text": "Start over",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 234,
+      "line": 235,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9262,7 +9262,7 @@
       "surface": "builders-hall",
       "text": "Task {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 454,
+      "line": 451,
       "origin": "js-text-assign",
       "confidence": "certain"
     },
@@ -9271,7 +9271,7 @@
       "surface": "builders-hall",
       "text": "Task {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 463,
+      "line": 460,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9280,7 +9280,7 @@
       "surface": "builders-hall",
       "text": "Task {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 691,
+      "line": 688,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9289,7 +9289,7 @@
       "surface": "builders-hall",
       "text": "Task {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 703,
+      "line": 700,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9325,7 +9325,7 @@
       "surface": "builders-hall",
       "text": "Tasks in the ledger are numbered separately from GitHub pull requests, so this may be a PR number rather than a task. The work board lists everything that does exist.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 691,
+      "line": 688,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9442,7 +9442,7 @@
       "surface": "builders-hall",
       "text": "The adversarial panel. Each worker reports pass, concerns or fail on its own; the gating workers must all pass before confirmed becomes {…}, and one concerns falls the task through to the manual confirm path.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 391,
+      "line": 388,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9559,7 +9559,7 @@
       "surface": "builders-hall",
       "text": "The grading panel could not run when this task was shipped, so no quality signal was recorded — an outage, not a verdict.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 373,
+      "line": 370,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9568,7 +9568,7 @@
       "surface": "builders-hall",
       "text": "The headline lands, but the sub-line reads like a brochure.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 161,
+      "line": 162,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -9883,7 +9883,7 @@
       "surface": "builders-hall",
       "text": "The task feed did not answer. Nothing on the record has changed, only the read failed. Try again in a moment, or go back.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 703,
+      "line": 700,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10189,7 +10189,7 @@
       "surface": "builders-hall",
       "text": "This task has shipped and its credits have landed. Neither Ship it nor Confirm is available.",
       "file": "modules/hall-ui/public/task.js",
-      "line": 612,
+      "line": 609,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -10567,7 +10567,7 @@
       "surface": "builders-hall",
       "text": "What you saw",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 161,
+      "line": 162,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11161,7 +11161,7 @@
       "surface": "builders-hall",
       "text": "Your verdict on a review is recorded from the review itself — open it to dismiss it, note what you saw, or file the follow-up.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 158,
+      "line": 159,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11332,7 +11332,7 @@
       "surface": "builders-hall",
       "text": "and {…} more waiting{…}",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 276,
+      "line": 277,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -11980,7 +11980,7 @@
       "surface": "builders-hall",
       "text": "no data",
       "file": "modules/hall-ui/public/hall-kit.js",
-      "line": 761,
+      "line": 705,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -12511,7 +12511,7 @@
       "surface": "builders-hall",
       "text": "to tend now · {…}",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 203,
+      "line": 204,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -12520,7 +12520,7 @@
       "surface": "builders-hall",
       "text": "to tend now · {…}",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 218,
+      "line": 219,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -12547,7 +12547,7 @@
       "surface": "builders-hall",
       "text": "verdict {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 395,
+      "line": 392,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -12790,7 +12790,7 @@
       "surface": "builders-hall",
       "text": "{…} awarded",
       "file": "modules/hall-ui/public/task.js",
-      "line": 438,
+      "line": 435,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -12943,7 +12943,7 @@
       "surface": "builders-hall",
       "text": "{…} sessions",
       "file": "modules/hall-ui/public/task.js",
-      "line": 446,
+      "line": 443,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -13159,7 +13159,7 @@
       "surface": "builders-hall",
       "text": "{…}, no such task",
       "file": "modules/hall-ui/public/task.js",
-      "line": 691,
+      "line": 688,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -13204,7 +13204,7 @@
       "surface": "builders-hall",
       "text": "{…}{…} · {…}",
       "file": "modules/hall-ui/public/task.js",
-      "line": 546,
+      "line": 543,
       "origin": "js-markup",
       "confidence": "certain"
     },
@@ -13321,7 +13321,7 @@
       "surface": "builders-hall",
       "text": "— your words, in your voice. Needed for a note or a follow-up.",
       "file": "modules/hall-ui/public/studio.js",
-      "line": 161,
+      "line": 162,
       "origin": "js-markup",
       "confidence": "certain"
     },

package/docs/module-api-changelog.md

@@ -2054,5 +2054,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.788 with no explicit bump. run 35159544354. (task 1002620)
   1.19.790 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.789 with no explicit bump. run 35163350575. (task 1002620)
+  1.19.791 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.790 with no explicit bump. run 35165066743. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/hall-ui/public/hall-kit.js

@@ -579,70 +579,14 @@
     };
   }
 
-  // ---- ship-time task visual (task 1003109, goal 1000072) -------------------
+  // ---- ship-time task visual — MOVED OUT (task 1003835) ---------------------
   //
-  // A shipped task may carry an optional IMAGE alongside its value summary — the
-  // same claim in another medium, so a non-engineer can SEE what changed rather
-  // than read about it. In a FEED the summary is one line in a list, so the image
-  // appears as a small thumbnail linking to the full-size file; the task page
-  // renders it properly (task.js taskVisualHtml).
-  //
-  // Lives here because three separate feeds render it (Standing's ship ledger,
-  // a profile's recent ships, the status dashboard) and a fourth copy of an
-  // HTML-building helper is how the pre-kit drift started.
-
-  // Same-origin, SERVER-MINTED paths only. The URL arrives from our own API, but
-  // it lands in an href and a src, so it is matched literally against the shape
-  // modules/lifecycle/task-visuals.js mints rather than trusted. Anything else
-  // renders nothing at all.
-  const VISUAL_URL_RE = /^\/api\/(gds|bongos)\/task-visuals\/task-\d+-[0-9a-f]{16}\.(png|jpg|gif|webp)$/;
-  function isTaskVisualUrl(url) {
-    return VISUAL_URL_RE.test(String(url ?? ''));
-  }
-
-  // The compact thumbnail. Returns '' when the row carries no visual — a task
-  // without one must never look incomplete, so nothing is drawn (no placeholder).
-  function shipVisualThumbHtml(row) {
-    const url = String((row && row.visual_url) ?? '');
-    if (!isTaskVisualUrl(url)) return '';
-    const alt = String((row && row.visual_alt) || `Visual for task ${(row && row.id) ?? ''}`).trim();
-    return `<a href="${esc(url)}" target="_blank" rel="noopener" title="${esc(alt)}">` +
-      `<img class="ship-visual-thumb" src="${esc(url)}" alt="${esc(alt)}" loading="lazy"></a>`;
-  }
-
-  // The FULL-SIZE form: the picture as the thing being looked at, with
-  // visual_alt as its caption. The thumbnail above is for a FEED, where the
-  // summary is one line in a list; this is for a surface whose subject IS the
-  // image — the task record, and the Studio's review card (task 1003829).
-  //
-  // It lives here so the Studio did not become the THIRD hand-rolled <figure>
-  // for this one image. Be precise about what that did and did not fix: the two
-  // that already existed — task.js's taskVisualHtml (.tk-visual) and
-  // task-detail.js's overlay (.td-visual) — are NOT converged onto this yet and
-  // are untouched by the task that added it (1003829). Neither page loads the
-  // kit, so migrating them means adding it to task.html, which is a call of its
-  // own. So: one canonical renderer exists and new callers take it; the two
-  // legacy copies are a known, named cleanup rather than a claim already met.
-  //
-  // `className` is the caller's BEM base, because the size is the surface's
-  // decision and not the kit's: the task record caps at 52vh inside a record
-  // column (.tk-visual), the Studio gives the plate the card's whole width.
-  // The markup, the URL guard and the escaping are the kit's and identical
-  // everywhere. Returns '' with no visual, like the thumbnail.
-  function taskVisualFigureHtml(row, { className = 'task-visual' } = {}) {
-    const url = String((row && row.visual_url) ?? '');
-    if (!isTaskVisualUrl(url)) return '';
-    const written = String((row && row.visual_alt) || '').trim();
-    const alt = written || `Visual for task ${(row && row.id) ?? ''}`;
-    const base = String(className).replace(/[^A-Za-z0-9_-]/g, '');
-    // The caption is only drawn when the shipper WROTE one — the fallback alt is
-    // a machine sentence for a screen reader, not a caption to show a reader.
-    const caption = written ? `<figcaption class="${base}__caption">${esc(written)}</figcaption>` : '';
-    return `<figure class="${base}">` +
-      `<a href="${esc(url)}" target="_blank" rel="noopener">` +
-      `<img class="${base}__img" src="${esc(url)}" alt="${esc(alt)}" loading="lazy">` +
-      `</a>${caption}</figure>`;
-  }
+  // isTaskVisualUrl / shipVisualThumbHtml / taskVisualFigureHtml now live in
+  // hall-visual.js. They left because the task record page renders a visual and
+  // needs nothing else in this file, so converging it here would have loaded 61KB
+  // on the hall's most-visited record page for one function. A page that draws a
+  // visual loads hall-visual.js; pages that only use the kit no longer carry the
+  // renderers at all. Callers read window.OTBVisual, not OTBKit.
 
   // ---- charts (task 1003445) ------------------------------------------------
   //
@@ -1218,8 +1162,6 @@
     plotBox, plotWindow,
     // states
     emptyStateHtml, skeletonRows, collapsibleCard,
-    // ship-time task visual (task 1003109; the full-size figure, task 1003829)
-    isTaskVisualUrl, shipVisualThumbHtml, taskVisualFigureHtml,
     // age (task 1002955)
     fmtAge, fmtAbsDate, ageChipHtml, AGE_STALE_DAYS,
   };

package/modules/hall-ui/public/hall-render.js

@@ -1100,7 +1100,7 @@
         <td>
           <div>${escapeHtml(s.title)}</div>
           ${s.value_summary ? `<div style="color:var(--ink-soft);font-size:0.88rem;font-style:italic;margin-top:2px">${escapeHtml(s.value_summary)}</div>` : ''}
-          ${s.visual_url ? `<div style="margin-top:6px">${window.OTBKit.shipVisualThumbHtml(s)}</div>` : ''}
+          ${s.visual_url && window.OTBVisual ? `<div style="margin-top:6px">${window.OTBVisual.shipVisualThumbHtml(s)}</div>` : ''}
         </td>
         <td class="ledger__drachmae">${fmtNum(window.OTBBranding?.taskCreditValue?.(s) ?? s.credits_reward)}</td>
         <td class="ledger__date">${fmtDate(s.shipped_at)}</td>