@bongos/core 1.19.782 → 1.19.783

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.782",
-  "core_contract": "1.19.782",
-  "source_commit": "43084c4331ee19b9a1b432551b7dc5367ef092ab",
+  "core_version": "1.19.783",
+  "core_contract": "1.19.783",
+  "source_commit": "6e5366479023ac5cbbd19fda61ebf8abc48a6113",
   "source_ref": "HEAD",
-  "built_at": "2026-09-16T21:10:46.341Z",
+  "built_at": "2026-09-16T21:29:40.397Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 482,
     "agent_docs_stubbed": 25,
-    "functional_verbatim": 2153,
+    "functional_verbatim": 2154,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2660,
-  "tree_sha256": "83d13b3c4946e711eea1e2165a2e2d08a1d57b9bcd1f66581b655c23be655e18",
+  "file_count": 2661,
+  "tree_sha256": "76a7394b33c9a3c9d901bfc6016b4cc40c410b80f7958034ce571b72e952fdda",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2507,7 +2507,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "a3aa8f4408b6eca9fd810fe7303f63bb30e9afaf8590444f31e021db2ed3e39a"
+      "sha256": "a57c986ed1da32c1bd0bbb2724b8cf178e5df174970f1d1fac2b5a42d36d2279"
     },
     {
       "path": "docs/modules-contract.md",
@@ -7612,12 +7612,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "321f79fbe68b9551888b6f48a11b1ce420e898899330c15897f448a57e674938"
+      "sha256": "e998a3dbacba277f1fce790f6b672738f339819dd866d3bef1896aee8a44d4a8"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "1e634a5a9705590ef73213ae2c4e853303aee1afcbcc001f68c8947b7cd43928"
+      "sha256": "914d6c6f028d4708afd08513c3e04f062098d14a4d08e2061c5051db928d026a"
     },
     {
       "path": "public-docs/index.html",
@@ -8977,7 +8977,7 @@
     {
       "path": "scripts/gds/start.js",
       "mode": "0000644",
-      "sha256": "6f871e5c89d2f256fbaf5b556a4ffacd5da86a72577d913b086a45893baf445a"
+      "sha256": "3b9cbebddc633952450ee38c933e42b465bd107edb28532ada58a113d6b5cbe5"
     },
     {
       "path": "scripts/gds/status.js",
@@ -9477,7 +9477,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "99015e0c64696cc31a85fff0ccf81d99ae1358b8f91b1d27a8a7a6b349b759f1"
+      "sha256": "2b4da6b2263db105e394608f3043a0b7c1c46eb43b36928ccb2f761ccfb2ea6a"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -12934,6 +12934,11 @@
       "mode": "0000644",
       "sha256": "dd7171dbc59e024de99a063763219237814cf4c943fb3d873cc324f3bfde7f25"
     },
+    {
+      "path": "tests/start_inbox_count.mjs",
+      "mode": "0000644",
+      "sha256": "525f37837e39059c1b40c99b117764ba0547b803f01d709e80354744ad3438b7"
+    },
     {
       "path": "tests/start_rebase_warning.mjs",
       "mode": "0000644",

package/docs/module-api-changelog.md

@@ -2038,5 +2038,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.780 with no explicit bump. run 35150109281. (task 1002620)
   1.19.782 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.781 with no explicit bump. run 35150844959. (task 1002620)
+  1.19.783 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.782 with no explicit bump. run 35152631705. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.782",
+  "version": "1.19.783",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.782",
+      "version": "1.19.783",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.782",
+  "version": "1.19.783",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/start.js

@@ -112,6 +112,30 @@ function formatCostRow(cost) {
   return `${fmtUsd(spent)} logged spend  ·  ${credits}c reward shipped`;
 }
 
+// inboxOpenCount — how many ideas are OPEN in the inbox, from a GET /inbox response.
+//
+// WHY THIS IS NOT ideas.length (task 1003454). GET /inbox answers
+// { ideas, open_count }, where `ideas` is a PAGE (default 50 rows) and
+// `open_count` is the real total, counted server-side under the same rank gate
+// as the rows. Reading the array length therefore reported the page size: the
+// card said "50 ideas in inbox" while the payload said 99, and once the queue
+// passed one page the figure pinned at exactly 50 forever — a number that looks
+// plausible, never moves, and understates the backlog the card exists to make
+// visible. capture.js already destructured open_count correctly, which is what
+// made this an oversight rather than a convention.
+//
+// The page length stays as a FALLBACK so an older core that predates open_count
+// still renders a figure rather than "N/A". Returns null when neither is
+// readable, which the callers render as "ideas: N/A".
+function inboxOpenCount(inboxRes) {
+  if (!inboxRes || !inboxRes.ok) return null;
+  const data = inboxRes.data;
+  if (data && typeof data.open_count === 'number') return data.open_count;
+  if (data && Array.isArray(data.ideas)) return data.ideas.length;
+  if (data && typeof data.count === 'number') return data.count;
+  return null;
+}
+
 function formatRecentRow({ recentShipped, inboxCount, blockerCount }) {
   const bits = [];
   // "1 ship in last 24h" — recent_shipped returns tasks shipped within
@@ -741,9 +765,7 @@ async function main() {
   const progress = progressRes.ok && Array.isArray(progressRes.data?.progress) ? progressRes.data.progress : null;
   const cost = costRes.ok ? costRes.data : null;
   const recentShipped = recentRes.ok && Array.isArray(recentRes.data?.tasks) ? recentRes.data.tasks : null;
-  const inboxCount = inboxRes.ok && Array.isArray(inboxRes.data?.ideas)
-    ? inboxRes.data.ideas.length
-    : (inboxRes.ok && typeof inboxRes.data?.count === 'number' ? inboxRes.data.count : null);
+  const inboxCount = inboxOpenCount(inboxRes);
   const blockerCount = blockersRes.ok && Array.isArray(blockersRes.data?.blockers)
     ? blockersRes.data.blockers.filter((b) => b.status === 'open' || !b.status).length
     : null;
@@ -1023,6 +1045,7 @@ if (require.main === module) {
 }
 
 module.exports = {
+  inboxOpenCount,
   rankCrossDisciplineRecommendations,
   rebaseWarningModel,
   rebaseWarningMarkdown,

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.782'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.783'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/start_inbox_count.mjs

@@ -0,0 +1,112 @@
+// tests/start_inbox_count.mjs
+//
+// task 1003454 — /builder-start's "N ideas in inbox" figure must be the inbox's
+// OPEN COUNT, not the length of the page it happened to be served.
+//
+// GET /inbox answers { ideas, open_count }: `ideas` is a page (default 50 rows)
+// and `open_count` is the real total, counted server-side under the same rank
+// gate as the rows. start.js read `ideas.length`, so the card reported the page
+// size — measured live at "50 ideas in inbox" against an open_count of 99, and
+// pinned at exactly 50 for any queue larger than one page.
+//
+// Exercises the pure helper start.js exports, DB-free — no live server, mirroring
+// start_rebase_warning.mjs. The invariants under test:
+//   - open_count wins whenever it is present, INCLUDING when it disagrees with
+//     the page length (the regression's exact shape)
+//   - a queue larger than one page reports honestly, not the page size
+//   - 0 is a real answer, not a missing one (the falsy trap)
+//   - the page length survives as a fallback for a core predating open_count
+//   - an unreadable/failed response is null, which renders as "ideas: N/A"
+//
+// Run:  node tests/start_inbox_count.mjs
+
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+
+const require = createRequire(import.meta.url);
+const START_PATH = require.resolve('../scripts/gds/start.js');
+const { inboxOpenCount } = require(START_PATH);
+
+let passed = 0;
+let failed = 0;
+function t(name, fn) {
+  try { fn(); passed++; console.log(`  PASS  ${name}`); }
+  catch (e) { failed++; console.log(`  FAIL  ${name}\n        ${e.message}`); }
+}
+
+t('the helper is exported (the test cannot silently cover nothing)', () => {
+  assert.equal(typeof inboxOpenCount, 'function');
+});
+
+// --- the regression itself -------------------------------------------------
+
+t('open_count wins over the page length — the measured 50-vs-99 case', () => {
+  const res = { ok: true, data: { ideas: new Array(50).fill({}), open_count: 99 } };
+  assert.equal(inboxOpenCount(res), 99, 'must report the real total, not the page');
+});
+
+t('a queue larger than one page does not pin at the page size', () => {
+  // The old code returned 50 for every one of these; the figure never moved.
+  for (const total of [51, 99, 250, 1000]) {
+    const res = { ok: true, data: { ideas: new Array(50).fill({}), open_count: total } };
+    assert.equal(inboxOpenCount(res), total, `expected ${total}`);
+  }
+});
+
+t('a queue smaller than a page still reads open_count (page length agrees)', () => {
+  const res = { ok: true, data: { ideas: new Array(7).fill({}), open_count: 7 } };
+  assert.equal(inboxOpenCount(res), 7);
+});
+
+t('zero open ideas is a real answer, not a missing one', () => {
+  // The falsy trap: `open_count || ideas.length` would fall through to the page
+  // here, so an empty inbox and an unreadable one would render identically.
+  const res = { ok: true, data: { ideas: [], open_count: 0 } };
+  assert.equal(inboxOpenCount(res), 0);
+  assert.notEqual(inboxOpenCount(res), null, 'an empty inbox must not render as N/A');
+});
+
+// --- the fallbacks ---------------------------------------------------------
+
+t('page length is the fallback when open_count is absent (older core)', () => {
+  const res = { ok: true, data: { ideas: new Array(12).fill({}) } };
+  assert.equal(inboxOpenCount(res), 12);
+});
+
+t('a non-numeric open_count does not poison the figure', () => {
+  const res = { ok: true, data: { ideas: new Array(4).fill({}), open_count: '99' } };
+  assert.equal(inboxOpenCount(res), 4, 'a string count is not a count; fall back to the page');
+});
+
+t('the legacy `count` field is still honoured when there are no rows to count', () => {
+  const res = { ok: true, data: { count: 5 } };
+  assert.equal(inboxOpenCount(res), 5);
+});
+
+// --- the null paths (rendered as "ideas: N/A") -----------------------------
+
+t('a failed request is null, never 0', () => {
+  const res = { ok: false, data: { ideas: new Array(50).fill({}), open_count: 99 } };
+  assert.equal(inboxOpenCount(res), null, 'a failed read must not report a figure');
+});
+
+t('missing / malformed responses are null, and never throw', () => {
+  for (const res of [null, undefined, {}, { ok: true }, { ok: true, data: null },
+    { ok: true, data: 'nope' }, { ok: true, data: { ideas: 'nope' } }]) {
+    assert.equal(inboxOpenCount(res), null, `expected null for ${JSON.stringify(res)}`);
+  }
+});
+
+// --- the guard: the bug must not be reintroduced in the caller -------------
+
+t('the card derivation calls the helper — no inline ideas.length survives', () => {
+  const src = fs.readFileSync(START_PATH, 'utf8');
+  assert.match(src, /const inboxCount = inboxOpenCount\(inboxRes\);/,
+    'the header derivation must go through the helper');
+  assert.doesNotMatch(src, /inboxRes\.data\?\.ideas\.length/,
+    'no caller may read the page length directly again');
+});
+
+console.log(`\nstart_inbox_count: ${passed} passed, ${failed} failed`);
+process.exit(failed ? 1 : 0);