@bongos/core 1.19.743 → 1.19.744

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.743",
-  "core_contract": "1.19.743",
-  "source_commit": "ab27f1b16b14260ffd2f5ae8342504053928aa40",
+  "core_version": "1.19.744",
+  "core_contract": "1.19.744",
+  "source_commit": "a1c9e8b6b38e48c9f3a6040ff29b76ee3457b808",
   "source_ref": "HEAD",
-  "built_at": "2026-09-15T14:55:42.206Z",
+  "built_at": "2026-09-15T15:04:25.874Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 479,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 2611,
-  "tree_sha256": "7eed1fd142643158bd9ddbb2f69beff6924a75e10c6b3ac121eb4c029787d4e5",
+  "tree_sha256": "4cfb37d1d47bb997d911c6ae24958d363737b154c725bfb76fb65f3e71c92449",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2492,7 +2492,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "97ecbfdf15f6707e5f4a0d46ce1597667e0fd592e1adf2d36f3cf006adf5d2ce"
+      "sha256": "8f98164df753a9a4a8c77ade44d450eeb65eee2987dcc5b46d0d251f2a62d399"
     },
     {
       "path": "docs/modules-contract.md",
@@ -6257,7 +6257,7 @@
     {
       "path": "modules/provisioning/provisioning.js",
       "mode": "0000644",
-      "sha256": "18cb9676bd343e49873e2a3cface6d491aa59a840215531184b0d1863f3de271"
+      "sha256": "9e6d1356fa046f97f3141c353302637dad2deed4c2460d124c8d7636b0ff0065"
     },
     {
       "path": "modules/provisioning/rate-limit.js",
@@ -6297,7 +6297,7 @@
     {
       "path": "modules/provisioning/tests/provisioning.mjs",
       "mode": "0000644",
-      "sha256": "904b1a6f8c704e606e7f93937465b14840857c287d31abda9d4772c528501f92"
+      "sha256": "8fbac4b6857f7ccd1dab9355b01c2574c537196af8ec2755901189b14829fbe5"
     },
     {
       "path": "modules/provisioning/ui/.gitkeep",
@@ -7542,12 +7542,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "9b9d8bc2b152c80ee2cbe2c9ee8e235f0130fbc317e67b7b8cfedbfa806129c2"
+      "sha256": "7d86631d2cad28001db3920822fd96bb638cede683d627fe0101445320c12d7e"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "b954e60f7093cbdd715857d5fed0f33c91e1f84fc4844714a59e9ab38669284d"
+      "sha256": "d4c3e36f1af2829fc4bc7d9b6dc29be667c75e6d5fd870855398bc5e13380ddc"
     },
     {
       "path": "public-docs/index.html",
@@ -9347,7 +9347,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "ff5ab852aa0fe991ee391e3ede0b07bf25316d90525e2c40ea9863ada99834e0"
+      "sha256": "6cec169dc7c62404bb81e3b7fc00506de07048b3a0ce2ef59f892d467b9e0c3b"
     },
     {
       "path": "src/module-loader/catalog.js",

package/docs/module-api-changelog.md

@@ -1960,5 +1960,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.741 with no explicit bump. run 34983109625. (task 1002620)
   1.19.743 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.742 with no explicit bump. run 34984876076. (task 1002620)
+  1.19.744 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.743 with no explicit bump. run 34985887902. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/provisioning/provisioning.js

@@ -275,6 +275,19 @@ const TIER_MONTHLY_USD = {
   's-4vcpu-8gb': 48,
 };
 
+// The size the RUNNER actually creates when a dedicated instance names no tier
+// (`scripts/gds/provision.js`: `size: inst.tier || 's-2vcpu-4gb'`). It lives here
+// because costEstimateUsd has to agree with it: before task 1003692 the estimate
+// treated an absent tier as unpriced and reported $0 for a droplet the runner was
+// really billing at $24/mo, so the fleet cost ledger under-reported by the full
+// cost of every tier-less dedicated instance.
+//
+// The runner cannot import this. `provision.js` is reachable from a generator's
+// executed closure (via onboard.js) and tests/executed_closure.mjs pins how far
+// that closure may grow, so a new require there is a test failure, not a tidy-up.
+// `tests/provisioning.mjs` pins the two against each other instead.
+const DEFAULT_DEDICATED_TIER = 's-2vcpu-4gb';
+
 // ---------------------------------------------------------------------------
 // Pure helpers (no I/O — exported for unit tests)
 // ---------------------------------------------------------------------------
@@ -295,7 +308,12 @@ function isValidSlug(slug) {
 // rate (0 if the tier is unknown/unset). PURE.
 function costEstimateUsd({ hostingShape, tier } = {}) {
   if (hostingShape !== 'dedicated') return 0;
-  return TIER_MONTHLY_USD[tier] || 0;
+  // An ABSENT tier is not an unknown one. The runner substitutes its own default
+  // and bills for it, so the estimate has to price that same default or the ledger
+  // reports $0 for a real droplet (task 1003692). An unrecognised tier STILL falls
+  // through to 0 — unpriced rather than wrong, per the table's own note.
+  const effective = tier == null || tier === '' ? DEFAULT_DEDICATED_TIER : tier;
+  return TIER_MONTHLY_USD[effective] || 0;
 }
 
 // Normalize an SNI/hostname for an EXACT allow-list match: lowercase, trim, drop a
@@ -1427,7 +1445,7 @@ module.exports = {
   SETTINGS_VOCAB, DEFAULT_SETTINGS, SETTINGS_COMPANION_ENV, PROJECT_DETAIL_VOCAB, DESCRIPTION_MAX,
   PLANET_TEMPLATES, PLANET_ACCENTS, PLANET_VOCAB,
   // pure
-  isValidSlug, costEstimateUsd, publicInstance, normalizeHostname,
+  isValidSlug, costEstimateUsd, DEFAULT_DEDICATED_TIER, publicInstance, normalizeHostname,
   defaultDomainForSlug, isReservedHostname, effectiveSettings, planetChoice,
   settingsPushOwed,
   // pure — the artist gate's non-retroactivity stamp (ADR 0241 §5, task 1003575)

package/modules/provisioning/tests/provisioning.mjs

@@ -9,6 +9,7 @@
 
 import { strict as assert } from 'node:assert';
 import { createRequire } from 'node:module';
+import { readFileSync } from 'node:fs';
 
 const require = createRequire(import.meta.url);
 const P = require('../provisioning.js');
@@ -145,6 +146,51 @@ t('isValidSlug basic contract', () => {
   assert.equal(P.isValidSlug('a--b'), false);   // double dash
 });
 
+console.log('\ncostEstimateUsd — what a shape costs the fleet ledger (task 1003692):');
+
+t('a dedicated instance is priced at its named tier', () => {
+  assert.equal(P.costEstimateUsd({ hostingShape: 'dedicated', tier: 's-1vcpu-1gb' }), 6);
+  assert.equal(P.costEstimateUsd({ hostingShape: 'dedicated', tier: 's-4vcpu-8gb' }), 48);
+});
+
+t('a dedicated instance with NO tier is priced at the runner default, not $0', () => {
+  // The bug: tier is optional on the create route, so it is commonly null, and the
+  // estimate used to read that as unpriced -> the ledger reported $0 for a droplet
+  // the runner really creates and bills. null, undefined and '' are all "not named".
+  for (const tier of [null, undefined, '']) {
+    assert.equal(P.costEstimateUsd({ hostingShape: 'dedicated', tier }), 24,
+      `a tier-less dedicated instance costs the default tier's price (tier=${JSON.stringify(tier)})`);
+  }
+  assert.equal(P.costEstimateUsd({ hostingShape: 'dedicated' }), 24, 'tier absent entirely');
+});
+
+t('an UNRECOGNISED tier is still $0 — unpriced rather than wrong', () => {
+  // Deliberately NOT folded into the default above. An absent tier is a known
+  // quantity (the runner substitutes one); an unknown string is not, and guessing
+  // a price for it would be inventing a number.
+  assert.equal(P.costEstimateUsd({ hostingShape: 'dedicated', tier: 's-99vcpu-1tb' }), 0);
+});
+
+t('every non-dedicated shape is $0 — it co-tenants on infrastructure already paid for', () => {
+  for (const shape of ['standalone', 'co-tenant', 'shared', undefined]) {
+    assert.equal(P.costEstimateUsd({ hostingShape: shape, tier: 's-4vcpu-8gb' }), 0,
+      `shape ${JSON.stringify(shape)} is never metered, whatever tier rides along`);
+  }
+});
+
+t('the estimate and the RUNNER agree on the default — they cannot import each other', () => {
+  // provision.js sits in a generator's executed closure (tests/executed_closure.mjs
+  // pins its size), so it cannot require this module for the constant. This pin is
+  // what stops the two literals drifting apart again.
+  const runner = readFileSync(new URL('../../../scripts/gds/provision.js', import.meta.url), 'utf8');
+  const m = runner.match(/size:\s*inst\.tier\s*\|\|\s*'([^']+)'/);
+  assert.ok(m, "provision.js no longer spells its default as `inst.tier || '<size>'` — re-pin this");
+  assert.equal(m[1], P.DEFAULT_DEDICATED_TIER,
+    'the runner creates a different size than the ledger prices — the 1003692 bug, returning');
+  assert.ok(P.DEFAULT_DEDICATED_TIER in { 's-1vcpu-1gb': 1, 's-1vcpu-2gb': 1, 's-2vcpu-2gb': 1, 's-2vcpu-4gb': 1, 's-4vcpu-8gb': 1 },
+    'the default tier must be one the price table knows, or the fix silently returns 0 again');
+});
+
 console.log('\nGitHub App Manifest — pure builders (task 2080, ADR 0133):');
 
 t('githubAppName prefers the DOMAIN (unique + reads on the consent screen)', () => {

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.743",
+  "version": "1.19.744",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.743",
+      "version": "1.19.744",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.743",
+  "version": "1.19.744",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.743'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.744'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');