@bongos/core 1.19.708 → 1.19.709

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.708",
-  "core_contract": "1.19.708",
-  "source_commit": "42f201a980e11b8b417c2afa527230ed1ab05775",
+  "core_version": "1.19.709",
+  "core_contract": "1.19.709",
+  "source_commit": "e931b6db287584c48e0e0fbb4f302198e7ad7ae1",
   "source_ref": "HEAD",
-  "built_at": "2026-09-13T06:14:54.451Z",
+  "built_at": "2026-09-13T06:55:41.726Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 477,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 2138,
+    "functional_verbatim": 2140,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2639,
-  "tree_sha256": "369223629e32da5858cc92a00ab2643eaa169ca59d1d89d6ab77ab8c50e3fd57",
+  "file_count": 2641,
+  "tree_sha256": "38d60d3f6875f0ae881aeb4942d3a09b3aa7f9d0df66d7ec712d0ead28d6b3dd",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2802,7 +2802,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "fd622c24f29995f2c8ebdd272cf5784f05285bbafc6c3da490308ed5e1730ba7"
+      "sha256": "ebca814eb4d786c2958e44b166b23986ef624b9145bc9c5a6b5a0068ef05a411"
     },
     {
       "path": "docs/modules-contract.md",
@@ -3859,6 +3859,11 @@
       "mode": "0000644",
       "sha256": "03df9104a0309011df1b6e96627c62cc6612f34b654134306d13fd5c89b8f038"
     },
+    {
+      "path": "migrations/core_239_claimable_respects_blocker_status.sql",
+      "mode": "0000644",
+      "sha256": "75a3d09bce8a40b51015054b4f4c77706ce76e7f8cb3fc4a54048c9bd33814b8"
+    },
     {
       "path": "modules/agents/lib/validate.js",
       "mode": "0000644",
@@ -7782,12 +7787,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "4f9b97401aebd998dd23bf3ec95a333fd6c596c0ea5551dc02dc6e863ad92742"
+      "sha256": "9e9bbca8f0efb3bed421d30ad97be1b18edf775e80cbc07590a583b2452ea609"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "9002e7fc0a70168d56042d71c7905aa045b541dbc36d61e88180a8dfb1e0f559"
+      "sha256": "eb6d8897c8a65579eaee354a12435b412606029b3f182f192cf5628941580075"
     },
     {
       "path": "public-docs/index.html",
@@ -9567,7 +9572,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "98205e89563b71f2e6ddbe44a9639464bdc589c20f3f0a8de12a2b968ac06569"
+      "sha256": "5359ee8368381b16bb0d6e18a13e390dd9366b3a3cdc3965e749cb5746f5cc4f"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -10159,6 +10164,11 @@
       "mode": "0000644",
       "sha256": "6e5ff3acb835fd6219136ee2a5e144841076a82733915cc7111688f707464442"
     },
+    {
+      "path": "tests/claimable_blocker_status.mjs",
+      "mode": "0000644",
+      "sha256": "6bb10ab7ee346bbe673055e46e9fc53865540157c48c203e57c11ad51ba44336"
+    },
     {
       "path": "tests/claims_bind_session.mjs",
       "mode": "0000644",

package/docs/module-api-changelog.md

@@ -1875,5 +1875,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.706 with no explicit bump. run 34741980536. (task 1002620)
   1.19.708 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.707 with no explicit bump. run 34742245823. (task 1002620)
+  1.19.709 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.708 with no explicit bump. run 34743928060. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/migrations/core_239_claimable_respects_blocker_status.sql

@@ -0,0 +1,67 @@
+-- core_239 — claimable_tasks must filter on the blocker being OPEN, not on the
+-- link row existing (task 1003863).
+--
+-- THE DEFECT. core_231's claimable_tasks excludes a task if ANY task_blockers row
+-- exists for it, with no check on the blocker's status:
+--
+--     AND NOT EXISTS (SELECT 1 FROM task_blockers tb WHERE tb.task_id = t.id)
+--
+-- Nothing ever deletes that link: there is no `DELETE FROM task_blockers` in
+-- migrations/ or modules/. So when core_223's trg_promote_tasks_on_blocker_resolve
+-- flips a task 'blocked' -> 'ready' on its last blocker resolving, the link row
+-- survives and this view keeps hiding the task. A task that has ever been blocked
+-- is promoted to ready and then never appears in /builder-start again.
+--
+-- It stays claimable BY ID — modules/lifecycle/db-claims.js checks b.status='open'
+-- correctly (task 1002650) — so the row is workable but unfindable. Same family as
+-- bug 1003553, inverted: there the feed advertises what the claim path refuses;
+-- here the claim path accepts what the feed hides.
+--
+-- LATENT, NOT HARMLESS. Every blocker on the instance was status='open' when this
+-- was written, so the bad branch had never executed. Eleven tasks were linked to
+-- open blockers at that moment, and each would have vanished from the queue the
+-- moment its blocker resolved — including task 1001440 behind blocker 1000144.
+--
+-- THE LEFT JOIN IS LOAD-BEARING. Legacy markdown-anchor links carry
+-- task_blockers.blocker_ref with NO blockers row (core_223's header, same scope as
+-- 176). An inner join would drop those rows from the NOT EXISTS and thereby
+-- UNHIDE their tasks — a silent widening of the feed. `LEFT JOIN` plus
+-- `b.id IS NULL OR b.status = 'open'` keeps an unresolvable legacy link blocking,
+-- which is exactly today's behaviour. Fail closed on anything we cannot resolve.
+--
+-- Scope: this view only. The OTHER gap in the same view — it never filters
+-- unshipped dependencies either (finding #60 of task 1000379) — is a separate
+-- clause with a separate fix and is deliberately NOT bundled here.
+--
+-- Idempotent: DROP VIEW IF EXISTS + CREATE, the same shape core_231 used. The
+-- column list is `t.*` plus the calibrated-minutes column, byte-identical to
+-- core_231 so the wildcard re-expands to every current column (core_227's header
+-- records six columns that silently never reached the feed by diverging here).
+
+BEGIN;
+
+DROP VIEW IF EXISTS claimable_tasks;
+CREATE VIEW claimable_tasks AS
+SELECT t.*,
+       pms_calibrated_minutes(t.est_minutes, t.kind) AS est_minutes_calibrated
+  FROM tasks t
+ WHERE t.status = 'ready'
+   AND t.title NOT LIKE '\_\_smoke\_\_%' ESCAPE '\'
+   AND NOT EXISTS (
+     SELECT 1
+       FROM task_blockers tb
+       LEFT JOIN blockers b ON b.id = tb.blocker_id
+      WHERE tb.task_id = t.id
+        AND (b.id IS NULL OR b.status = 'open')
+   )
+   AND NOT EXISTS (
+     SELECT 1 FROM claims c
+       JOIN tasks t2 ON t2.id = c.task_id
+      WHERE c.released_at IS NULL
+        AND t2.touches && t.touches
+   );
+
+COMMIT;
+
+INSERT INTO schema_migrations (version) VALUES ('core_239_claimable_respects_blocker_status')
+  ON CONFLICT (version) DO NOTHING;

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.708",
+  "version": "1.19.709",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.708",
+      "version": "1.19.709",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.708",
+  "version": "1.19.709",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.708'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.709'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/claimable_blocker_status.mjs

@@ -0,0 +1,98 @@
+// tests/claimable_blocker_status.mjs
+//
+// Task 1003863 — claimable_tasks must hide a task only while a blocker on it is
+// still OPEN, not forever because a link row exists. Static shape guard for
+// core_239, in the style of blocker_resolve_guard.mjs: no live DB, assert the SQL
+// TEXT so a future edit cannot silently drop the fix or "simplify" the LEFT JOIN
+// back into the bug. Runtime behaviour is proven against real Postgres at deploy.
+//
+// THE BUG THIS PINS. core_231's view excluded a task if ANY task_blockers row
+// existed, and nothing ever deletes that row. core_223's trigger flips the task
+// 'blocked' -> 'ready' when its last blocker resolves, so the task became ready
+// and permanently invisible to /builder-start — workable by id, unfindable in the
+// feed. Latent when found (every blocker was open), but eleven tasks were one
+// resolve away from vanishing.
+//
+// Run:  node tests/claimable_blocker_status.mjs
+
+import { strict as assert } from 'node:assert';
+import { readFileSync, readdirSync } from 'node:fs';
+import { fileURLToPath } from 'node:url';
+import { dirname, join } from 'node:path';
+import { makeRunner } from './helpers.mjs';
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const repoRoot = join(__dirname, '..');
+const read = (...p) => readFileSync(join(repoRoot, ...p), 'utf8');
+
+const MIG = 'core_239_claimable_respects_blocker_status.sql';
+const mig = read('migrations', MIG);
+// Comments carry the rationale; strip them when asserting on the executable body
+// so a claim in prose can never stand in for the real SQL.
+const body = mig.replace(/^\s*--.*$/gm, '').replace(/\s+/g, ' ');
+
+const { test, summary } = makeRunner();
+
+await test('239 replaces claimable_tasks, in core_231-s drop-and-create shape', () => {
+  assert.match(body, /DROP VIEW IF EXISTS claimable_tasks;/);
+  assert.match(body, /CREATE VIEW claimable_tasks AS/);
+});
+
+await test('the blocker clause filters on the blocker being OPEN, not on the link existing', () => {
+  assert.match(body, /FROM task_blockers tb/, 'it still looks at the link table');
+  assert.match(body, /blockers b ON b\.id = tb\.blocker_id/, 'and resolves the blocker itself');
+  assert.match(body, /b\.status = 'open'/, 'so a RESOLVED blocker stops hiding the task');
+});
+
+await test('the join is a LEFT JOIN with the fail-closed arm — an inner join would UNHIDE legacy links', () => {
+  // Legacy markdown-anchor links carry task_blockers.blocker_ref with no blockers
+  // row (core_223 header, same scope as 176). An inner join drops them from the
+  // NOT EXISTS and silently widens the feed. This is the one line most likely to
+  // be "tidied" later, so it is asserted from both directions.
+  assert.match(body, /LEFT JOIN blockers b/, 'LEFT, so an unresolvable link survives the join');
+  assert.match(body, /b\.id IS NULL OR b\.status = 'open'/, 'and an unresolvable link still blocks');
+  assert.doesNotMatch(
+    body,
+    /(?<!LEFT )JOIN blockers b ON b\.id = tb\.blocker_id/,
+    'a bare inner JOIN onto blockers would unhide every legacy link'
+  );
+});
+
+await test('the view-s OTHER guards survive the rewrite', () => {
+  // A view rewrite replaces the whole definition, so dropping a sibling clause is
+  // a silent regression with no error anywhere. Each of these was its own fix.
+  assert.match(body, /t\.status = 'ready'/, 'only ready tasks are claimable');
+  assert.match(body, /NOT LIKE '\\_\\_smoke\\_\\_%'/, 'smoke rows stay out of the feed');
+  assert.match(body, /c\.released_at IS NULL/, 'and the touches-overlap parallel-safety guard holds');
+  assert.match(body, /t2\.touches && t\.touches/, 'against other live claims');
+});
+
+await test('the column list stays the t.* wildcard (core_227-s silent-column lesson)', () => {
+  // core_227's header records six columns that never reached the feed because a
+  // rewrite spelled the list out instead of re-expanding it.
+  assert.match(body, /SELECT t\.\*,/, 'the wildcard re-expands to every current column');
+  assert.match(body, /pms_calibrated_minutes\(t\.est_minutes, t\.kind\) AS est_minutes_calibrated/);
+});
+
+await test('239 is the LAST definition of claimable_tasks in migrations/', () => {
+  // If a later migration redefines the view, it inherits whatever that one says —
+  // which is exactly how 177 silently dropped migration 176's blocker clause from
+  // task_is_fully_unblocked. Catch the next one at the source.
+  const defs = readdirSync(join(repoRoot, 'migrations'))
+    .filter((f) => f.endsWith('.sql'))
+    .filter((f) => /CREATE VIEW claimable_tasks/.test(read('migrations', f)))
+    .sort();
+  assert.ok(defs.includes(MIG), 'this migration defines the view');
+  assert.equal(defs[defs.length - 1], MIG,
+    `a later migration redefines claimable_tasks and must carry the blocker-status clause: ${defs.join(', ')}`);
+});
+
+await test('the feed and the claim path enforce the SAME rule', () => {
+  // The whole bug class is the two gates disagreeing. db-claims.js got this right
+  // for the by-id path in task 1002650; this pins that they still match.
+  const claims = read('modules', 'lifecycle', 'db-claims.js');
+  assert.match(claims, /b\.status = 'open'/,
+    'the by-id claim path checks blocker STATUS, and the view must not be laxer or stricter');
+});
+
+summary();