@bongos/core 1.19.706 → 1.19.708

package/tests/agent_invoke_live.mjs

@@ -0,0 +1,111 @@
+// tests/agent_invoke_live.mjs — the end-to-end proof, reproducible (task 1002491).
+//
+// tests/agent_invoke.mjs proves the DECISIONS with a fake pool, a fake runner and
+// a fake tree. It cannot prove the one thing criterion `agents-historian-exemplar`
+// actually claims: that the real historian, given the real corpus, comes back with
+// an answer whose citations are real. Only a real model call can say that, and a
+// real model call costs real money (~$0.90 a question at the time of writing) and
+// needs an authenticated `claude` CLI — so it must never run in CI or in the unit
+// gate, and it is OPT-IN.
+//
+//   AGENT_INVOKE_LIVE=1 node tests/agent_invoke_live.mjs ["<question>"]
+//
+// Skipped and exit 0 otherwise, so `run-unit-tests.js` sweeps it up harmlessly.
+//
+// The POOL is still faked — a builder box has no database, which is also why the
+// script's every edge is injectable. What is real here is the definition (parsed
+// from the committed .claude/agents/historian.md exactly as agents-sync would land
+// it), the corpus (this checkout), the model, and the citation check.
+
+import { strict as assert } from 'node:assert';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+
+if (process.env.AGENT_INVOKE_LIVE !== '1') {
+  console.log('  skip  agent_invoke_live — set AGENT_INVOKE_LIVE=1 to spend ~$1 proving the chain for real');
+  process.exit(0);
+}
+
+const invoke = require('../scripts/gds/agent-invoke.js');
+const agentsSync = require('../scripts/gds/agents-sync.js');
+const grader = require('../modules/grading/grader.js');
+
+// The definition exactly as the deploy-time reconcile would land it, so what runs
+// is the committed file and not a fixture that drifted from it.
+const candidate = agentsSync.parseAgentFile(
+  fs.readFileSync(path.join(ROOT, '.claude/agents/historian.md'), 'utf8'),
+  { name: 'historian' },
+);
+const definition = {
+  id: 1,
+  ...candidate,
+  trigger_spec: {},
+  scope_modules: [],
+  scope_paths: [],
+  scope_violation: null,
+  source: 'file',
+  provenance: 'built-in',
+  // Armed for the duration of this check. Note that a real deploy does NOT land
+  // it armed — see the header of scripts/gds/agent-invoke.js.
+  author_rank: 'archon',
+  enabled: true,
+};
+
+const ledger = [];
+const pool = {
+  async query(sql, params) {
+    if (/FROM agents_definitions/.test(sql)) return { rows: [definition] };
+    // No database on a builder box; the degrade path is exercised for free.
+    if (/FROM learnings/.test(sql)) throw new Error('no database on this box');
+    if (/^INSERT INTO agents_runs/.test(sql)) { ledger.push(['insert', params]); return { rows: [{ id: 1 }] }; }
+    ledger.push(['update', params]);
+    return { rows: [] };
+  },
+};
+
+const question = process.argv.slice(2).join(' ')
+  || 'Why does this project enforce permissions server-side rather than in the client, and what is the rule about editing local files to grant yourself authority?';
+
+console.log(`  Q: ${question}`);
+const started = Date.now();
+const result = await invoke.invokeAgent(
+  { name: 'historian', question, requestedByBuilderId: 1, requestedByLogin: 'live-check' },
+  {
+    pool,
+    runSubagentCached: (a) => grader.runSubagentCached({ ...a, opts: { ...a.opts, timeoutMs: 600000 } }),
+    spawnDeps: { brandingModels: { subagentDefault: 'claude-opus-5', subagentRoutine: 'claude-haiku-4-5-20251001' } },
+    warn: (m) => console.log(`  warn: ${m}`),
+  },
+);
+const secs = Math.round((Date.now() - started) / 1000);
+
+if (!result.ok) {
+  console.error(`  FAIL  ${result.code} — ${result.reason || ''} (${secs}s)`);
+  process.exit(1);
+}
+
+console.log(`\n${result.answer.answer}\n`);
+console.log('  Citations, every one resolved against this checkout:');
+for (const c of result.answer.citations) console.log(`    - ${c.ref}`);
+console.log(`\n  ${secs}s · ${result.model} · $${result.cost_usd} · confidence ${result.answer.confidence}`);
+
+// The claim the criterion makes, asserted rather than eyeballed.
+assert.ok(result.answer.citations.length > 0, 'a cited result');
+for (const c of result.answer.citations) {
+  const p = invoke.citationPath(c.ref);
+  if (/^learning:/.test(c.ref)) continue;
+  assert.ok(fs.existsSync(path.join(ROOT, p)), `${p} exists in the tree`);
+}
+// ...and the ledger said so: one go row, finished ok, with a real cost on it.
+const [insert] = ledger.filter(([k]) => k === 'insert');
+const [update] = ledger.filter(([k]) => k === 'update');
+assert.ok(insert && insert[1].includes('go'), 'the gate said go');
+assert.ok(update && update[1].includes('ok'), 'the run finished ok');
+assert.ok(Number(result.cost_usd) > 0, 'a real fire costs real money and the ledger carries it');
+
+console.log('\n  ok  the historian returned a cited result end-to-end, and the ledger agrees');

package/tests/box_infra_resolve.mjs

@@ -17,8 +17,12 @@ import { createRequire } from 'node:module';
 import fs from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { makeRunner } from './helpers.mjs';
 
+// This repo's root — the boundary tests at the bottom read the REAL tree.
+const REPO_ROOT = path.join(path.dirname(fileURLToPath(import.meta.url)), '..');
+
 const require = createRequire(import.meta.url);
 const box = require('../scripts/gds/box.js');
 
@@ -153,5 +157,90 @@ await test('readCloudInit renders a non-empty cloud-init with no leftover __PLAC
   assert.ok(!/__[A-Z0-9_]+__/.test(out), 'no unsubstituted __PLACEHOLDER__ tokens remain');
 });
 
+// ===========================================================================
+// An UNKNOWN placeholder half-wires the box (task 1003635, ADR 0150 prong B)
+//
+// missingInfra only catches files this renderer knows to ask for. The other
+// direction — an instance template carrying a token box-infra.js never
+// substitutes — used to render straight through, leaving the literal token in
+// the cloud-init for cloud-init to write out as a file. ADR 0150 named the
+// assertion as an escalation and it was never implemented.
+// ===========================================================================
+
+await test('an UNKNOWN __TOKEN__ in the instance template is refused, not rendered through', () => {
+  const { infra } = makeInfra();
+  fs.appendFileSync(path.join(infra, TEMPLATE), '\n# __SOME_FUTURE_THING_B64__\n');
+  assert.throws(
+    () => box.readCloudInit({ infraDir: infra }),
+    (err) => /__SOME_FUTURE_THING_B64__/.test(err.message) && /placeholder|half-wired|ADR 0150/i.test(err.message),
+    'an unsubstituted placeholder must fail loud — rendering it through writes garbage onto the box',
+  );
+});
+
+await test('a misspelled AUTHORIZED_KEYS token cannot ship a permanently SSH-unreachable box', () => {
+  // The stakes case. A template that spells the key block even slightly wrong
+  // gets no substitution, so the box boots with a garbage authorized_keys and
+  // nobody can SSH in — the outcome task 1003635 reported, by the mechanism it
+  // did not find. It must be refused before DigitalOcean is touched.
+  const { infra } = makeInfra();
+  fs.appendFileSync(path.join(infra, TEMPLATE), '\n# __BUILDER_AUTHORIZED_KEY_B64__\n');
+  assert.throws(
+    () => box.readCloudInit({ infraDir: infra, authorizedKeysBlock: 'ssh-ed25519 AAAA' }),
+    /__BUILDER_AUTHORIZED_KEY_B64__/,
+  );
+});
+
+await test('the happy path still renders — the assertion does not fire on a correct template', () => {
+  const { infra } = makeInfra();
+  const out = box.readCloudInit({
+    infraDir: infra, authorizedKeysBlock: 'ssh-ed25519 AAAA', boxEnv: 'X=1', gdsSession: '{"t":1}',
+  });
+  assert.ok(out && out.length > 0, 'a correct template must still render');
+});
+
+// ===========================================================================
+// The core / instance boundary (task 1003635)
+//
+// The absence of the cloud-init set from the core's own infra/ was filed once as
+// a P1 outage ("a dev box becomes permanently SSH-unreachable"). It is not one —
+// ADR 0150 says the neutral core ships no box cloud-init, and the two throws
+// above are what make a missing one legible instead of dangerous. These pin that
+// boundary against the REAL tree so the next reader gets a test telling them so.
+// ===========================================================================
+
+await test('the INLINED list is exactly what box-infra.js actually asks fileGzB64 for', () => {
+  // The list above says "kept in sync with box.js's fileGzB64 calls" — by hand.
+  // Derive it instead, so adding a 10th inlined file cannot leave these tests
+  // silently proving less than they claim.
+  const SRC = fs.readFileSync(path.join(REPO_ROOT, 'scripts/gds/box-infra.js'), 'utf8');
+  const called = [...SRC.matchAll(/fileGzB64\('([^']+)'\)/g)].map((m) => m[1]);
+  assert.ok(called.length > 0, 'found no fileGzB64 calls — did box-infra.js move or get renamed?');
+  assert.deepEqual([...new Set(called)].sort(), [...INLINED].sort(),
+    'the INLINED fixture list has drifted from box-infra.js — the happy-path test would stop covering every inlined file');
+});
+
+await test('the neutral core ships NO box cloud-init — that is ADR 0150, not a missing file', () => {
+  const coreInfra = path.join(REPO_ROOT, 'infra');
+  assert.ok(!fs.existsSync(path.join(coreInfra, TEMPLATE)),
+    `the core now ships infra/${TEMPLATE}. ADR 0150 says it must not ("The neutral core still ships no infra/") — the cloud-init is instance-owned. If that decision changed, amend ADR 0150 and this test together.`);
+  for (const name of INLINED) {
+    assert.ok(!fs.existsSync(path.join(coreInfra, name)),
+      `infra/${name} is a cloud-init asset and belongs to the host instance, not the core (ADR 0150)`);
+  }
+});
+
+await test("core infra/ carries only the CLONE-RIDE scripts, which is why it looks half-empty", () => {
+  // The other population: these run on the box out of /workspace/infra/, arriving
+  // with the cloned source rather than through cloud-init. Their presence beside
+  // nine absences is the thing that reads as "files are missing" — infra/README.md
+  // exists to answer that, so it is required to stay.
+  const coreInfra = path.join(REPO_ROOT, 'infra');
+  for (const name of ['box-heartbeat.sh', 'box-report-host-keys.sh', 'box-report-terminal.sh', 'box-report-version.sh']) {
+    assert.ok(fs.existsSync(path.join(coreInfra, name)), `infra/${name} rides the clone and must stay in the core`);
+  }
+  assert.ok(fs.existsSync(path.join(coreInfra, 'README.md')),
+    'infra/README.md explains the two populations — without it the nine absences read as breakage again (task 1003635)');
+});
+
 for (const d of tmps) { try { fs.rmSync(d, { recursive: true, force: true }); } catch { /* best-effort */ } }
 summary();