@bongos/core 1.19.705 → 1.19.707

package/scripts/gds/smoke-write.sh

@@ -11,6 +11,9 @@
 #                session_logs row exists for this claim
 #                public/recent-shipped does NOT contain the smoke title
 #                public/progress weighting unchanged (smoke tasks filtered)
+#   6. On PASS, abandon the throwaway task so the ledger does not refill with
+#      test noise (task 1002018). A FAILED run deliberately KEEPS its task and
+#      claim so the failure can be read from the ledger afterwards.
 #
 # The synthetic task has credits_reward=0 so no credit_log row is written
 # and the leaderboard is unaffected. The credit-award path is implicitly
@@ -68,6 +71,51 @@ VERSION_ID=$(node "$(dirname "$0")/version-select.js") || {
 }
 echo "Version: ${VERSION_ID}"
 
+# Caused by task 1003598 (BV1.R11, ADR 0250 D4), found and fixed under task
+# 1002018: goal_id became REQUIRED on POST /tasks and this script still sent none, so step 1 died on a 400 goal_id_required
+# and the whole smoke could not run. Resolved at RUNTIME, not hardcoded, for the
+# same reason version-select.js exists (task 1003166): an id literal goes stale
+# the moment the version rolls, and the failure then looks like a broken API
+# rather than a stale constant. Every version auto-creates exactly ONE
+# is_maintenance goal (BV1.R18), and a synthetic row is maintenance-goal work.
+#
+# node, not python3, on purpose: this script already shells out to node for
+# version-select.js, and node is the interpreter a Windows builder box actually
+# has — the python3 the rest of this file depends on is frequently absent there
+# (it is the Microsoft Store stub), so a python3 step cannot be verified locally.
+GOAL_ID=$(call GET "/api/gds/goals?version=${VERSION_ID}" | node -e '
+let s = "";
+process.stdin.on("data", (d) => { s += d; });
+process.stdin.on("end", () => {
+  const goals = JSON.parse(s).goals || [];
+  const m = goals.filter((g) => g.is_maintenance && g.status === "open");
+  if (m.length !== 1) {
+    process.stderr.write("expected exactly 1 open maintenance goal, found " + m.length + "\n");
+    process.exit(1);
+  }
+  // The caller splices this straight into a python3 -c SOURCE string, unquoted,
+  // so a non-numeric id would be executed as Python rather than read as data.
+  // Validating the COUNT is not validating the ID: check its shape too.
+  const id = String(m[0].id);
+  if (!/^[0-9]+$/.test(id)) {
+    process.stderr.write("goal id is not numeric: " + JSON.stringify(id) + "\n");
+    process.exit(1);
+  }
+  process.stdout.write(id);
+});
+') || {
+  echo "FAIL: could not resolve the maintenance goal for ${VERSION_ID}" >&2
+  exit 1
+}
+# Belt-and-braces at the point of use: the resolver above already refuses a
+# non-numeric id, but this value is interpolated into python3 source below as
+# CODE, not as a quoted literal, so it is re-checked where the risk actually is.
+[[ "${GOAL_ID}" =~ ^[0-9]+$ ]] || {
+  echo "FAIL: resolved goal id is not numeric: ${GOAL_ID}" >&2
+  exit 1
+}
+echo "Goal: ${GOAL_ID}"
+
 echo "--- 0. snapshot progress before ---"
 PROGRESS_BEFORE=$(snapshot_progress)
 echo "${PROGRESS_BEFORE}"
@@ -78,6 +126,7 @@ CREATE_BODY=$(python3 -c "
 import json
 print(json.dumps({
   'version_id': '${VERSION_ID}',
+  'goal_id': ${GOAL_ID},
   'title': '${SMOKE_TITLE}',
   'description': 'Synthetic smoke task. Auto-shipped by smoke-write.sh.',
   'status': 'ready',
@@ -177,6 +226,45 @@ else
   echo "SKIP session_logs DB check (set GDS_SMOKE_DB_SSH + GDS_SMOKE_DB_NAME to enable)"
 fi
 
+echo
+echo "--- 5. clean up the throwaway task ---"
+# task 1002018 — this smoke CREATES a real task to exercise the create API, and
+# used to leave it in the ledger forever: 94 rows accumulated under PMS-V1 before
+# the task-2016 sweep cleared them by hand. Abandon is the right terminal state —
+# a smoke row is not shipped work, and the route refuses to abandon a shipped one
+# anyway (cannot_abandon_shipped). The row sits at 'completed' after step 3, and
+# only 'shipped' and an unreleased claim are refused, so this is always legal here.
+#
+# ONLY on success, deliberately: a FAILED run leaves its task and claim in place
+# so the failure can be inspected in the ledger, which is why the FAIL branch of
+# the summary below still prints both ids.
+#
+# Strictly best-effort. A cleanup that cannot run must never turn a passing smoke
+# into a failing one, so this never touches ${fail} and never trips set -e:
+# task.abandon is floor-metic (ADR 0152), so a Xenos/Thetes token gets a 403 here
+# while every assertion above genuinely passed.
+cleanup_throwaway_task() {
+  local out code
+  local reason='{"reason":"smoke cleanup (task 1002018) - write-path smoke passed; the throwaway row has served its purpose"}'
+  out=$(curl -sS -X POST \
+    -H "Authorization: Bearer ${TOKEN}" -H "Content-Type: application/json" \
+    -d "${reason}" -w "\n%{http_code}" \
+    "${API}/api/gds/tasks/${TASK_ID}/abandon") || true
+  code="${out##*$'\n'}"
+  case "${code}" in
+    2*)  echo "PASS cleaned up throwaway task #${TASK_ID} (abandoned)" ;;
+    403) echo "SKIP cleanup — task.abandon needs Metic+ (ADR 0152); task #${TASK_ID} left in the ledger" ;;
+    000) echo "SKIP cleanup — POST /tasks/${TASK_ID}/abandon got no response; task #${TASK_ID} left in the ledger" ;;
+    *)   echo "SKIP cleanup — POST /tasks/${TASK_ID}/abandon returned HTTP ${code:-none}; task #${TASK_ID} left in the ledger" ;;
+  esac
+}
+
+if [[ "${fail}" -eq 0 ]]; then
+  cleanup_throwaway_task
+else
+  echo "SKIP cleanup — run FAILED; task #${TASK_ID} and claim #${CLAIM_ID} kept for post-mortem"
+fi
+
 echo
 echo "--- summary ---"
 if [[ "${fail}" -eq 0 ]]; then

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.705'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.707'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');