@bongos/core 1.19.702 → 1.19.704

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.702",
-  "core_contract": "1.19.702",
-  "source_commit": "3b1a2e8029758a6ee091812baccb9e24fdc4670a",
+  "core_version": "1.19.704",
+  "core_contract": "1.19.704",
+  "source_commit": "86a7901eed7ffd687d8366c14b70b6dbce1a36f8",
   "source_ref": "HEAD",
-  "built_at": "2026-09-13T03:33:51.903Z",
+  "built_at": "2026-09-13T04:51:44.117Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 477,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 2130,
+    "functional_verbatim": 2132,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2631,
-  "tree_sha256": "7bf1dff3812c90015cc9d2476643856d5c6e9e950d26c6859e219c0eab9796b5",
+  "file_count": 2633,
+  "tree_sha256": "6a38a87e7ab24df8fa7020189772ed67bc02d6271601eda7a94aeddf84bfc12d",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2802,7 +2802,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "7458093aecd8dd3fcc7753356a12e995b25663e9251a295c406e4ecc4cc54c27"
+      "sha256": "339e97fa485b7a1b3090c5964a23d6d30d3863781e549e30af68610fb3eedb91"
     },
     {
       "path": "docs/modules-contract.md",
@@ -3067,7 +3067,7 @@
     {
       "path": "docs/recipes/windows-builders.md",
       "mode": "0000644",
-      "sha256": "e5bcc0b4da0755546cb10870052099def2745c890cd8157d36d997e58a0399b3"
+      "sha256": "6760a34d404aa68c61896983c8aa621bd26244e5c98ed056045b3467359c4b53"
     },
     {
       "path": "docs/recipes/work-on-a-task-from-your-dev-box.md",
@@ -3862,7 +3862,7 @@
     {
       "path": "modules/agents/lib/validate.js",
       "mode": "0000644",
-      "sha256": "5cff70fc4e280c49d33dfb8f60ddb01181decd1645625b0bb5e7c2eb97335b81"
+      "sha256": "cd3659ad5831c767fe6600fabbe883f33b3429107a0b999092158dfa7c95b4e7"
     },
     {
       "path": "modules/agents/migrations/agents_001_definitions.sql",
@@ -4642,7 +4642,7 @@
     {
       "path": "modules/government/protected-surfaces.json",
       "mode": "0000644",
-      "sha256": "6d9a7520b2565b34bf002df016598543101639ccc384d81a622d313ed688acbc"
+      "sha256": "2a6c392d4499498f0e0fb80c80002ba9d82a3f5e66e48cce9802c21c276af2a0"
     },
     {
       "path": "modules/government/ranks.js",
@@ -7782,12 +7782,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "1aa096840e001b544038432419a0e07577014954f7cb83d8e19c716704e3f36c"
+      "sha256": "8eb4b18a9a0ee8ec64bab2712698fca515ff92277ebeed12adbb7126fe30e3e2"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "cee79b868fecce6053d7d04108233e795a92c3635854bea1bf3003b909953e20"
+      "sha256": "6c55beca8912927a2d103ef0efee212341daa09be17e346d4d298377e3958d19"
     },
     {
       "path": "public-docs/index.html",
@@ -7859,6 +7859,11 @@
       "mode": "0000644",
       "sha256": "9c7ef61b64e41ee5dd6d913883e16dfed6d44bd6eefa4960b8dde566a63b5621"
     },
+    {
+      "path": "scripts/gds/agents-sync.js",
+      "mode": "0000644",
+      "sha256": "7a639c73f8d2f4f523899ab737641174ca7b5ed5409427238d7fc397cdba65ed"
+    },
     {
       "path": "scripts/gds/api.js",
       "mode": "0000644",
@@ -9177,7 +9182,7 @@
     {
       "path": "scripts/migrate.sh",
       "mode": "0000644",
-      "sha256": "0768bf9c9d6368ae673e1e5ac161cfe9bae4d113129f11f8b89afeeef1f9dc1b"
+      "sha256": "669ba0cd4e0c5ad2c7809364e4ac17b24bfa3f8542fae5ba7ec05e9bcf77053f"
     },
     {
       "path": "scripts/migrate_cost_ledger.sh",
@@ -9552,7 +9557,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "be1bd4054da76be7eb7aa62d3e9ee2805de116d811e25043a49bbd4731ad1643"
+      "sha256": "0954b91956641ff68caa5c9373be6d33d3ac3fdacda102846de75a339326fc86"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -9664,10 +9669,15 @@
       "mode": "0000644",
       "sha256": "8cc261471a36e3c447df57b46082997b6a50da3c8ff4b214787ae55ab27cb9ef"
     },
+    {
+      "path": "tests/agents_sync.mjs",
+      "mode": "0000644",
+      "sha256": "f7f6d88fd31a2eb1a81678d883706d2716e6a2ae20159599d3dbe7ed4c267f2e"
+    },
     {
       "path": "tests/agents_validate.mjs",
       "mode": "0000644",
-      "sha256": "c698b80ab8d64421b5c81e91172e1f219c41924af19721106f1899cd29c2fabc"
+      "sha256": "82c7bcef316f5c0068cb53a43b2ef4a01367ff285939f132f01b0d8633d36353"
     },
     {
       "path": "tests/api_cli_flags.mjs",
@@ -10982,7 +10992,7 @@
     {
       "path": "tests/government_protected_surfaces.mjs",
       "mode": "0000644",
-      "sha256": "3517e05c1264fbdbeadc533884942926689952c8995548863ca1cfbfc365428e"
+      "sha256": "d11562d59861a5f5d294c072b3aa15f03703ddbb2102210ff92f7ccbcff5b5f6"
     },
     {
       "path": "tests/government_rank_sync.mjs",

package/docs/module-api-changelog.md

@@ -1863,5 +1863,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.700 with no explicit bump. run 34735311256. (task 1002620)
   1.19.702 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.701 with no explicit bump. run 34735775228. (task 1002620)
+  1.19.703 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.702 with no explicit bump. run 34736566183. (task 1002620)
+  1.19.704 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.703 with no explicit bump. run 34738864605. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/docs/recipes/windows-builders.md

@@ -88,30 +88,57 @@ DB-backed tests with no local Postgres — the count drifts and is not worth rec
 **`node scripts/gds/run-unit-tests.js`** instead: it is the DB-free gate CI actually runs, so its
 result means something locally.
 
-**That gate's Windows baseline as of task 1003529 (2026-09-12): 4 suites** — `sound_player`
-(task 1003628), `session_caps` (1003827), `skill_preflight` (1003754), `task_recommendations`
-(1003759) — **plus the 6 carried by task 1003848**: `cli_surface`, `module_api_lazy`,
-`search_index_poller`, `search_isolation`, `tool_scan_engine`, `security/mirror`. Everything else
-is green, and a red suite outside those ten is yours.
-
-`logger` is **not** on that list and needs no work: it was the whole of the old "missing deps in
-the worktree" family and task 1003616 fixed it on 2026-09-07 — see the walk-up section below.
-
-**Two of the ten are INTERMITTENT, so a green run does not mean fixed.** `session_caps` and
-`search_isolation` exit `3221226505` (`0xC0000409`, STATUS_STACK_BUFFER_OVERRUN) — the process
-dies during teardown *after* its assertions have all passed, so whether the suite counts them as
-failures depends on timing. Measured in task 1003529: `session_caps` passed inside a full
-`run-unit-tests.js` sweep and failed twice in a row when run on its own, minutes apart, with task
-1003827 still open and nothing on main having touched it. This is the `cliExit` class documented in
+**That gate's Windows baseline, re-measured for task 1003860 on 2026-09-12 in a deps-installed
+`origin/main` worktree (core 1.19.703): 9 suites** — `session_caps` (task 1003827),
+`skill_preflight` (1003754), `task_recommendations` (1003759) — **plus the 6 carried by task
+1003848**: `cli_surface`, `module_api_lazy`, `search_index_poller`, `search_isolation`,
+`tool_scan_engine`, `security/mirror`. Everything else is green, and a red suite outside those
+nine is yours.
+
+**`sound_player` LEFT this list on 2026-09-12** — task 1003628 fixed the real bug behind it (the
+sound-prefs case read the builder's own settings instead of a fixture), and it is now green in two
+full sweeps and two standalone runs. It is called out rather than quietly deleted because it was
+listed as expected-red for a matter of hours: the list was written the same day the fix shipped.
+`logger` is likewise **not** on the list and needs no work — it was the whole of the old "missing
+deps in the worktree" family and task 1003616 fixed it on 2026-09-07 (see the walk-up section
+below).
+
+**THREE suites are INTERMITTENT on a Windows box, so neither a green run nor a red one settles
+anything on its own.** Two of the three are on the baseline above; the third is NOT, and keeping
+that distinction straight is the whole point of this paragraph — "intermittent" is a property of a
+suite, not a licence to add it to the expected-red list.
+
+*Intermittent AND on the list:* `session_caps` and `search_isolation` exit `3221226505`
+(`0xC0000409`, STATUS_STACK_BUFFER_OVERRUN) — the process dies during teardown *after* its
+assertions have all passed, so whether the suite counts them as failures depends on timing. Both
+directions are now on record. Task 1003529: `session_caps` passed inside a full
+`run-unit-tests.js` sweep and failed twice in a row when run on its own, minutes apart. Task
+1003860, two sweeps minutes apart on one unchanged tree: `session_caps` was RED in the first and
+GREEN in the second, plus green twice standalone — so the same tree answers 9 failures or 8
+depending on nothing you did, and `search_isolation` was red in both. Task 1003827 is still open
+and nothing on main has touched either. This is the `cliExit` class documented in
 [scripts/gds/CLAUDE.md](../../scripts/gds/CLAUDE.md) — a hard exit while handles are still closing.
 Do not mark either fixed on the strength of one green sweep, and do not let their noise cover a
 real regression: diff by name AND re-run the individual suite.
 
+*Intermittent but NOT on the list:* `<redacted>` (task 1003860). It failed inside one
+full sweep on 2026-09-12 and has not reproduced since — green standalone 7-of-7 then, and green in
+both full sweeps and three more standalone runs when the baseline was re-measured. It binds an
+ephemeral socket (`app.listen(0)`) and calls `server.close()` without awaiting it, so it is the
+same teardown-timing class as the two above. Know the name, so a red here does not send you
+hunting your own diff — but it stays OFF the expected-red list, because it is green on
+`origin/main`. **A suite that reds once and then will not reproduce is not a baseline entry.**
+Promoting a one-off red to a known name buys nothing and gives a genuine regression somewhere to
+hide; `git_merge_regen` below is the case that cost a whole session. Re-run this one alone before
+you touch anything.
+
 Two warnings about that list, both paid for:
 
 - **It drifts in BOTH directions.** The measurement before it (2026-08-27, 25 suites) had 7
   entries already fixed and was missing 6 that had since broken — so more than half of it was
-  wrong within a fortnight. Re-measure; never inherit a list.
+  wrong within a fortnight. And the one after THAT went stale in hours rather than weeks:
+  `sound_player` was fixed by task 1003628 the same day it was written down as expected-red
+  (task 1003860). Re-measure; never inherit a list.
 - **Compare NAMES, never counts**, and never bank a local red as "environmental" without a
   by-name baseline run in a deps-installed `origin/main` worktree. A count that matches can hide
   one suite fixed and another broken.

package/modules/agents/lib/validate.js

@@ -143,6 +143,11 @@ function validateAgentDefinition(obj, opts = {}) {
   const rawProtected = safeGet(options, 'protectedModules');
   const allowedModules = Array.isArray(rawAllowed) ? rawAllowed : [];
   const protectedModules = Array.isArray(rawProtected) ? rawProtected : [];
+  // (path) => boolean — "does this repo-relative path reach a protected
+  // surface?". Supplied by the caller from the protected-surface registry
+  // (task 1002492); see the scope_paths wall below for why it is passed in and
+  // why its absence refuses rather than admits.
+  const isProtectedPath = safeGet(options, 'isProtectedPath');
 
   // --- name ----------------------------------------------------------------
   const name = safeGet(obj, 'name');
@@ -276,6 +281,57 @@ function validateAgentDefinition(obj, opts = {}) {
     }
   }
 
+  // --- scope: THE OTHER HALF OF THE SAME WALL (task 1002492) -----------------
+  //
+  // Until now the rank wall ran over `scope_modules` only, and `scope_paths` was
+  // checked for tree-escape and nothing else. So one wall had two halves that
+  // disagreed: `scope_modules: ['government']` was refused below Metic, while
+  // `scope_paths: ['modules/government/']` reached the same code and passed at
+  // any rank. A definition could scope itself onto the authority surface by
+  // spelling it as a path — which is the one thing this check exists to stop.
+  //
+  // The matcher is PASSED IN rather than required, for the same reason
+  // `protectedModules` is: this module may not require core (ADR 0083), and the
+  // protected-surface registry must stay readable with no DB and no server so
+  // the out-of-band enforcers keep working (ADR 0043). The caller owns both.
+  if (scopePaths && scopePaths.length > 0) {
+    if (typeof isProtectedPath !== 'function') {
+      // FAIL-CLOSED, and deliberately not a default of "nothing is protected":
+      // scope_paths has no allowlist counterpart the way scope_modules has
+      // `allowedModules`, so an absent matcher would be a silent hole rather
+      // than a narrow scope. Declaring paths REQUIRES the caller to supply the
+      // means to check them.
+      E('scope_paths_uncheckable', 'scope_paths',
+        'scope_paths: declared, but no protected-path matcher was supplied, so they cannot be checked against the protected-surface registry. Refused rather than admitted — a path scope that nothing verified is indistinguishable from one nobody walled.');
+    } else {
+      const hits = [];
+      for (const p of scopePaths) {
+        let protectedPath;
+        try {
+          // ONLY an explicit `false` clears a path. Not `=== true`: that reads
+          // every ambiguous answer — undefined from a matcher that forgot a
+          // return, a truthy string, null — as "not protected", which is
+          // fail-OPEN on the exact question the wall exists to ask. Reading
+          // ambiguity as protected is loud and gets fixed; reading it as clean
+          // is silent and does not.
+          protectedPath = isProtectedPath(p) !== false;
+        } catch {
+          // A throwing matcher is treated as a HIT for the same reason: the
+          // question going unanswered must not read as no.
+          protectedPath = true;
+        }
+        if (protectedPath) hits.push(p);
+      }
+      if (hits.length > 0) {
+        const rankIdx = typeof authorRank === 'string' ? RANK_ORDER.indexOf(authorRank) : -1;
+        if (rankIdx < RANK_ORDER.indexOf(SCOPE_RANK_FLOOR)) {
+          E('scope_protected_rank', 'scope_paths',
+            `scope_paths: ${hits.map((p) => JSON.stringify(p)).join(', ')} ${hits.length === 1 ? 'reaches a protected surface' : 'reach protected surfaces'} and require a ${SCOPE_RANK_FLOOR}+ author; the author's resolved rank is ${JSON.stringify(authorRank ?? null)} (ADR 0016 / ADR 0043). A path scope is walled exactly as a module scope is — spelling the surface as a path is not a way around it.`);
+        }
+      }
+    }
+  }
+
   if (errors.length > 0) return { ok: false, errors, value: null };
 
   // The normalized row, built fresh — the caller's object is never mutated, and

package/modules/government/protected-surfaces.json

@@ -55,6 +55,14 @@
     { "glob": "scripts/gds/install-git-hooks.js", "group": "pipeline", "why": "the hook installer (self-protect)" },
     { "glob": "scripts/gds/hooks/", "group": "pipeline", "why": "the git hooks themselves (self-protect)" },
     { "glob": "scripts/gds/cli-lib.js", "group": "pipeline", "why": "session/token + apiCall the gate relies on" },
+    { "glob": "scripts/gds/git-merge-regen.js", "group": "pipeline", "why": "task 1003366, audit ref MIT1. EXECUTION ROOT: registerMergeDriver writes 'node scripts/gds/git-merge-regen.js' as a RELATIVE command with cwd at the clone root, so git merge runs the BRANCH's copy, with the live server's DATABASE_URL and BUILDER_SECRET_KEY, before any post-merge step. This and the six generators below are the ENTRYPOINTS in modules/lifecycle/executed-closure.js; tests/government_protected_surfaces.mjs fails the build if that list ever grows past this registry." },
+    { "glob": "scripts/gds/gen-repo-map.js", "group": "pipeline", "why": "task 1003366, audit ref MIT1. EXECUTION ROOT: run by the merge resolver as execFile(node, [<clone>/...]) after the merge — the branch's copy, the server's environment." },
+    { "glob": "scripts/gds/gen-file-map.js", "group": "pipeline", "why": "task 1003366, audit ref MIT1. EXECUTION ROOT: the same post-merge generator path as gen-repo-map.js." },
+    { "glob": "scripts/gds/gen-session-index.js", "group": "pipeline", "why": "task 1003366, audit ref MIT1. EXECUTION ROOT: the same post-merge generator path as gen-repo-map.js." },
+    { "glob": "scripts/gds/copy-inventory.js", "group": "pipeline", "why": "task 1003366, audit ref MIT1. EXECUTION ROOT: a generator the resolver runs out of the clone. NOT named by the 2026-08-29 audit, which said 'the gen-* trio' — that trio was already stale against GENERATOR_SCRIPTS, which is why this registry is pinned to the closure's ENTRYPOINTS rather than to the audit's prose." },
+    { "glob": "scripts/gds/gen-api-docs.js", "group": "pipeline", "why": "task 1003366, audit ref MIT1. EXECUTION ROOT: a generator the resolver runs out of the clone, and the widest one — it require()s src/bongos/route-rank-check, api-prefix and routes/_helpers." },
+    { "glob": "scripts/gds/gen-api-client.js", "group": "pipeline", "why": "task 1003366, audit ref MIT1. EXECUTION ROOT: a generator the resolver runs out of the clone." },
+    { "glob": ".gitattributes", "group": "pipeline", "why": "task 1003366, audit ref MIT1. Not code and never require()d, but it NAMES which paths git hands the otb-regen driver — so editing it changes how much of the tree that driver rewrites during a merge. modules/lifecycle/executed-closure.js carries it as TRUSTED_NON_CODE for exactly this reason (ADR 0043)." },
     { "glob": "scripts/migrate.sh", "group": "pipeline", "why": "applies migrations on deploy" },
     { "glob": "scripts/deploy/", "group": "pipeline", "why": "the deploy scripts run on the droplet at deploy (ADR 0058)" },
     { "glob": "modules/lifecycle/merge-lock.js", "group": "pipeline", "why": "BV1.R86: serializes a ship" },

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.702",
+  "version": "1.19.704",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.702",
+      "version": "1.19.704",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.702",
+  "version": "1.19.704",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",