@bongos/core 1.19.683 → 1.19.685

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.683",
-  "core_contract": "1.19.683",
-  "source_commit": "40eeb484085efb69d5aaa3645233d23854e2bbc1",
+  "core_version": "1.19.685",
+  "core_contract": "1.19.685",
+  "source_commit": "b1f9d9ab3a9892d6ccca5a2624ffbe732f23b98b",
   "source_ref": "HEAD",
-  "built_at": "2026-09-12T17:02:13.044Z",
+  "built_at": "2026-09-12T21:13:17.682Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 477,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 2626,
-  "tree_sha256": "aa8a467c8dcd7322882229d5b60da130eb5b67e726e38a0dde2b34d2ce6bfa4a",
+  "tree_sha256": "39b75c53e1b9736b4820105974401f9c9a67a3b5ed629b7434c0272f0a64d5eb",
   "files": [
     {
       "path": ".claude/skills/ask-for-help/SKILL.md",
@@ -2802,7 +2802,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "abe1e67ec7bd2d5d4bf27a2b5d8b4337fc1d4b7374c1edab6c5392016a83fde3"
+      "sha256": "aa474c62aed632c8ff75731a38bf22b286866cb6aa30953a64f2ea46e3c83ee2"
     },
     {
       "path": "docs/modules-contract.md",
@@ -7782,12 +7782,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "81888175ae0227d30c633c8f51a25936418cfdbf1d36c77bdd7c329d41d0c429"
+      "sha256": "e1896f085954a25abf57b98c3e16dc53825a88f657cb70f0839e65cf45960cdc"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "b5cd5f5c6b24980f4b85986be1919f4cb2697c3ba219277d51b1ef07de72343b"
+      "sha256": "4f32692ff1a262f499c156645e05890e5814346a1ddbe081846bfbebaf3c6f20"
     },
     {
       "path": "public-docs/index.html",
@@ -8287,7 +8287,7 @@
     {
       "path": "scripts/gds/gen-api-client.js",
       "mode": "0000644",
-      "sha256": "2d8b35709e19b339bc55c57237f2add36fa6bdeb83a9b036faa902b0c4b8e3f9"
+      "sha256": "a023a19001d63b671409efe1afeae400dae96ea50debd6e3a49a7d10dffb55b0"
     },
     {
       "path": "scripts/gds/gen-api-docs.js",
@@ -9547,7 +9547,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "2adaf10cbc0a2e65aeaa820f95b2b789c8e66c398c5f56299e9d1f52e82b86a1"
+      "sha256": "50802a77ae69160c8c739f40a02cae66c61bfd200e3d9a6d6be4024baa382793"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -9667,7 +9667,7 @@
     {
       "path": "tests/api_client.mjs",
       "mode": "0000644",
-      "sha256": "fa360a42fa5d11b225afe1b13622f2a27fe43f2b7d0a47c2fef158bc8a11ecb6"
+      "sha256": "c1563c043f34e84aa6c0eec722244b24c51dc1254750fe1a27d3664c327bacd1"
     },
     {
       "path": "tests/api_docs.mjs",
@@ -9972,7 +9972,7 @@
     {
       "path": "tests/box_infra_resolve.mjs",
       "mode": "0000644",
-      "sha256": "99209d0e407333bdd00236f0efe9ea63a94678bc206e1c5ae2995f76381f87fd"
+      "sha256": "cf261fa549f36d47ee42343bac2a297b132638aedf03beb8f521370b0c45c0e3"
     },
     {
       "path": "tests/box_onboard.mjs",

package/docs/module-api-changelog.md

@@ -1825,5 +1825,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.681 with no explicit bump. run 34704993368. (task 1002620)
   1.19.683 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.682 with no explicit bump. run 34706984747. (task 1002620)
+  1.19.684 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.683 with no explicit bump. run 34718471740. (task 1002620)
+  1.19.685 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.684 with no explicit bump. run 34719298791. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.683",
+  "version": "1.19.685",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.683",
+      "version": "1.19.685",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.683",
+  "version": "1.19.685",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/gen-api-client.js

@@ -21,6 +21,7 @@
 const fs = require('node:fs');
 const path = require('node:path');
 const { resolveDocsRoot } = require('../../src/instance-config');
+const { sameContent } = require('./gen-freshness'); // eol-insensitive freshness (CRLF checkouts)
 
 // The client is generated FROM the spec and lives beside it as a per-instance
 // artifact: both resolve to the DOCS root — the instance repo when a consumer
@@ -516,7 +517,15 @@ function main() {
   for (const [name, content] of Object.entries(files)) {
     const dest = path.join(OUT_DIR, name);
     const existing = fs.existsSync(dest) ? fs.readFileSync(dest, 'utf8') : null;
-    if (existing !== content) {
+    // Freshness is a question about CONTENT, so compare content (task 1003844 — the
+    // same defect as 1003619). We render with join('\n') = LF, but a core.autocrlf
+    // checkout hands readFileSync back CRLF, so a byte-wise `!==` called the already
+    // -correct client STALE on every Windows clone, forever: regenerating writes LF,
+    // git restores CRLF, gate red again. Comparing via sameContent cures it for every
+    // file here at once, so a seventh generated file can't reintroduce it by missing
+    // an eol pin. A missing file reads as null, which never matches a non-empty
+    // render — still stale, as before.
+    if (!sameContent(existing, content)) {
       stale = true;
       if (!check) { fs.mkdirSync(OUT_DIR, { recursive: true }); fs.writeFileSync(dest, content); }
     }

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.683'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.685'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/api_client.mjs

@@ -11,12 +11,15 @@ import { strict as assert } from 'node:assert';
 import { test } from 'node:test';
 import { createRequire } from 'node:module';
 import fs from 'node:fs';
+import os from 'node:os';
 import path from 'node:path';
+import { spawnSync } from 'node:child_process';
 import { fileURLToPath } from 'node:url';
 import { createClient, ApiError, API_VERSION, DEFAULT_BASE_URL } from '../clients/bongos-client/index.mjs';
 
 const require = createRequire(import.meta.url);
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const { sameContent } = require(path.join(ROOT, 'scripts', 'gds', 'gen-freshness.js'));
 
 function fakeFetch(recorder, response = { ok: true, status: 200, body: { ok: true } }) {
   return async (url, init) => {
@@ -149,12 +152,21 @@ test('baseUrl:"" is honored (absolute-path passthrough for the hall fetch wrappe
   assert.deepEqual(res, { status: 200, ok: true, data: { x: 1 } });
 });
 
+// The CI-gate twin of `gen-api-client.js --check`, and it carried the SAME defect
+// (task 1003844): a byte-wise assert.equal against a CRLF working copy failed on
+// every Windows checkout, forever — index.d.ts and README.md have no eol pin, so
+// core.autocrlf hands them back CRLF while the generator renders LF. Compare with
+// sameContent for the same reason gen-freshness.js exists; a real content change
+// still fails, which tests/gen_freshness.mjs pins.
 test('committed client is fresh (regenerate with gen-api-client.js if this fails)', () => {
   const gen = require('../scripts/gds/gen-api-client.js');
   const { files } = gen.build();
   for (const [name, content] of Object.entries(files)) {
     const onDisk = fs.readFileSync(path.join(ROOT, 'clients/bongos-client', name), 'utf8');
-    assert.equal(onDisk, content, `clients/bongos-client/${name} is STALE — run node scripts/gds/gen-api-client.js`);
+    assert.ok(
+      sameContent(onDisk, content),
+      `clients/bongos-client/${name} is STALE — run node scripts/gds/gen-api-client.js`,
+    );
   }
 });
 
@@ -245,3 +257,49 @@ test('browser-global build exposes window.BongosClient and shapes requests ident
   assert.equal(rec.init.headers.Authorization, 'Bearer tok');
   assert.equal(rec.init.body, JSON.stringify({ a: 1 }));
 });
+
+// --- the --check gate itself (task 1003844) ---------------------------------
+//
+// The assertions above compare the client this checkout HAS, so they can only ever
+// see the eol convention this checkout happens to use. The bug lived in the other
+// direction: a Windows clone whose committed client is already correct was told it
+// was STALE, forever. So drive the real CLI against a throwaway docs root where we
+// control the line endings, and pin BOTH halves — the eol-only case must pass, and
+// a genuine edit must still fail, which is what stops an over-broad "fix" (the same
+// pairing tests/gen_freshness.mjs makes for the helper).
+function runGen(root, args = []) {
+  return spawnSync(process.execPath, [path.join(ROOT, 'scripts/gds/gen-api-client.js'), ...args], {
+    encoding: 'utf8',
+    env: { ...process.env, BONGOS_INSTANCE_ROOT: root },
+  });
+}
+
+test('--check reads a CRLF working copy as fresh, and a real edit as stale (task 1003844)', () => {
+  const root = fs.mkdtempSync(path.join(os.tmpdir(), 'gen-api-client-'));
+  try {
+    fs.mkdirSync(path.join(root, 'docs', 'api'), { recursive: true });
+    fs.copyFileSync(path.join(ROOT, 'docs/api/openapi.json'), path.join(root, 'docs/api/openapi.json'));
+
+    const wrote = runGen(root);
+    assert.equal(wrote.status, 0, `generator failed: ${wrote.stderr}`);
+
+    // What a core.autocrlf=true checkout hands back for the two files with no eol
+    // pin. Nothing about the CONTENT changed, so --check must stay quiet.
+    for (const name of ['index.d.ts', 'README.md']) {
+      const f = path.join(root, 'clients/bongos-client', name);
+      fs.writeFileSync(f, fs.readFileSync(f, 'utf8').replace(/\n/g, '\r\n'));
+    }
+    const fresh = runGen(root, ['--check']);
+    assert.equal(fresh.status, 0, `CRLF must not read as STALE — this is the bug: ${fresh.stderr}`);
+    assert.match(fresh.stdout, /is fresh/);
+
+    // ...and the gate is still a gate.
+    const target = path.join(root, 'clients/bongos-client/index.mjs');
+    fs.writeFileSync(target, `${fs.readFileSync(target, 'utf8')}\nexport const SMUGGLED = 1;\n`);
+    const stale = runGen(root, ['--check']);
+    assert.equal(stale.status, 2, 'a real content change must still exit 2');
+    assert.match(stale.stderr, /STALE/);
+  } finally {
+    fs.rmSync(root, { recursive: true, force: true });
+  }
+});

package/tests/box_infra_resolve.mjs

@@ -69,22 +69,30 @@ function makeInfra({ template = true, inlined = INLINED } = {}) {
 // ===========================================================================
 // boxInfraCandidates — ordering (pure, injected; ADR 0150 prong A)
 // ===========================================================================
+// Expected candidates are built with path.join/path.resolve — the same calls
+// boxInfraCandidates makes — never as literal POSIX strings (task 1003821). A
+// hardcoded '/inst/infra' is 'C:\inst\infra' once the code has run it through
+// path.resolve, so these two tests were permanently red for every Windows builder
+// while ubuntu CI stayed green. A known-noise entry in a local baseline is the
+// thing that teaches a reader to skim the fail list instead of diffing it by name.
+const VENDORED_ROOT = '/srv/app/node_modules/@bongos/core';
+
 await test('candidate order: override → explicit instance root → repoRoot → node_modules walk-up', () => {
-  const env = { CLOUDBONGOS_BOX_INFRA_DIR: '/ovr', CLOUDBONGOS_INSTANCE_ROOT: '/inst' };
-  const c = box.boxInfraCandidates({ env, repoRoot: '/srv/app/node_modules/@bongos/core' });
+  const env = { BONGOS_BOX_INFRA_DIR: '/ovr', BONGOS_INSTANCE_ROOT: '/inst' };
+  const c = box.boxInfraCandidates({ env, repoRoot: VENDORED_ROOT });
   assert.equal(c[0], path.resolve('/ovr'), 'explicit override is first');
-  assert.equal(c[1], path.join('/inst', 'infra'), 'then the explicit instance root');
-  assert.equal(c[2], '/srv/app/node_modules/@bongos/core/infra', 'then REPO_ROOT/infra');
+  assert.equal(c[1], path.join(path.resolve('/inst'), 'infra'), 'then the explicit instance root');
+  assert.equal(c[2], path.join(VENDORED_ROOT, 'infra'), 'then REPO_ROOT/infra');
   // the load-bearing case: a vendored core walks UP out of node_modules to its host
   // instance root, so infra/ is found with no pointer at all.
-  assert.ok(c.includes('/srv/app/infra'), 'walk-up recovers the host instance root infra/');
+  assert.ok(c.includes(path.join('/srv/app', 'infra')), 'walk-up recovers the host instance root infra/');
 });
 
 await test('repoRoot/infra precedes its ancestors in the walk-up (robust to any cwd pointer)', () => {
   const c = box.boxInfraCandidates({ env: {}, repoRoot: '/x/y/z' });
-  const i0 = c.indexOf('/x/y/z/infra');
-  const i1 = c.indexOf('/x/y/infra');
-  const i2 = c.indexOf('/x/infra');
+  const i0 = c.indexOf(path.join('/x/y/z', 'infra'));
+  const i1 = c.indexOf(path.join('/x/y', 'infra'));
+  const i2 = c.indexOf(path.join('/x', 'infra'));
   assert.ok(i0 >= 0 && i1 > i0 && i2 > i1, 'repoRoot/infra, then /x/y/infra, then /x/infra — in order');
 });
 
@@ -93,7 +101,7 @@ await test('repoRoot/infra precedes its ancestors in the walk-up (robust to any
 // ===========================================================================
 await test('resolveBoxInfraDir picks the override dir when it holds the template', () => {
   const { infra } = makeInfra();
-  const got = box.resolveBoxInfraDir({ env: { CLOUDBONGOS_BOX_INFRA_DIR: infra }, repoRoot: '/nope/does/not/exist' });
+  const got = box.resolveBoxInfraDir({ env: { BONGOS_BOX_INFRA_DIR: infra }, repoRoot: '/nope/does/not/exist' });
   assert.equal(got, infra);
 });
 
@@ -103,7 +111,7 @@ await test('resolveBoxInfraDir falls THROUGH a template-less override to the ins
   const { infra } = makeInfra();                    // a real infra/ to fall through to
   const instRoot = path.dirname(infra);             // <root>, so <root>/infra === the real one
   const got = box.resolveBoxInfraDir({
-    env: { CLOUDBONGOS_BOX_INFRA_DIR: emptyOverride, CLOUDBONGOS_INSTANCE_ROOT: instRoot },
+    env: { BONGOS_BOX_INFRA_DIR: emptyOverride, BONGOS_INSTANCE_ROOT: instRoot },
     repoRoot: '/nope',
   });
   assert.equal(got, infra, 'skips the template-less override, takes the instance-root infra/');