@bongos/core 1.19.656 → 1.19.657

package/tests/rank_tier_single_source.mjs

@@ -107,23 +107,35 @@ const STATIC_LADDER_FILES = [
   'modules/hall-ui/public/ranks.js',
   'modules/hall-ui/public/profile.js',
   'modules/hall-ui/public/watch.js',
-  // task 1003094: the Constitution panel expands the `rank:<key>+` membership
-  // form ("that rank and above") to render who governs in plain language, so it
-  // needs the ladder to expand against. Browser code cannot require the server
-  // module — the established mirror pattern here — and listing it in this array
-  // is what makes the copy provable rather than merely allowed. A second,
-  // government-specific pin lives in tests/government_constitution_view.mjs,
-  // which holds it against catalog.RANK_ORDER and holds the whole browser parser
-  // equal to the server one.
+  // task 1003094: the Constitution panel and the Board Room's sitting card both
+  // expand the `rank:<key>+` membership form ("that rank and above") to render
+  // who governs in plain language, so both need the ladder to expand against.
+  // Browser code cannot require the server module — the established mirror
+  // pattern here — and listing it in this array is what makes the copy provable
+  // rather than merely allowed.
+  //
+  // ONE ROW, not two, since task 1003761. ADR 0266 carved the Board Room onto
+  // its own page and the carve COPIED the ladder and the parser into both page
+  // files, so this array had to allowlist BOTH — which permitted a drift between
+  // them by construction: the exact-literal pin below proved each matched the
+  // canonical ladder, but nothing held the two parsers equal to EACH OTHER, and
+  // government_constitution_view.mjs lifted only one of them. board-lib.js is
+  // the single copy now. A second, government-specific pin lives in
+  // tests/government_constitution_view.mjs, which holds it against
+  // catalog.RANK_ORDER and runs the whole browser parser against the server one.
+  //
+  // This row used to claim tests/government_board_vote_ui.mjs pinned the
+  // board-room copy. It does not — that file asserts the sitting card, the
+  // ballot and the vote form, and has no parser assertion at all, so the second
+  // copy was guarded only by the exact-literal ladder match.
+  'modules/hall-ui/public/board-lib.js',
+  // government.js keeps a ladder literal of its own — the charter library's
+  // `seatsRanks` worked example for `rank:xenos+` (the full ladder, spelled out
+  // so a reader sees what the predicate resolves to). That is documentation of
+  // the grammar rather than a second implementation of it, and it must still
+  // match the canonical order or the example teaches a ladder that does not
+  // exist.
   'modules/hall-ui/public/government.js',
-  // ADR 0266: the Board Room moved off the government page onto its own, and the
-  // sitting card's `decidedByHtml` expands the same `rank:<key>+` membership form
-  // to say who may vote on THAT sitting — so the carve took a copy of the ladder
-  // with it. Same reason as the row above (browser code cannot require the server
-  // module), and the same pinning: `tests/government_board_vote_ui.mjs` reads
-  // board-room.js and holds its predicate parser equal to the server's, and the
-  // pin below in this file holds the array itself against LIVE_RANK_LADDER.
-  'modules/hall-ui/public/board-room.js',
   // task 1002487: the pure agent-definition validator applies the ADR 0043
   // sub-Metic floor to an agent's declared scope, so it needs the ladder to
   // compare against. It is one of the "dependency-free" cases this array exists