@bongos/core 1.19.655 → 1.19.657

package/modules/hall-ui/public/board-room.css

@@ -9,25 +9,14 @@
    rows are the oversight family's (oversight.css); the ?v= cache-bust is
    stamped from this file's content hash at boot (src/asset-version.js).
 
-   TWO RULES ARE DUPLICATED FROM government.css, KNOWINGLY. `.gov-grid-note` is
-   the government family's framing-line voice, and the sitting card spends it in
-   three places (decidedByHtml, the own-idea note, the objection hint) — while
-   the Constitution panel still spends it over there. Copying two short rules is
-   the cheaper of two bad options: the alternative is this page loading a
-   stylesheet named for a different room in order to inherit them, which is what
-   the first cut of this carve did and what the review called out. The NAMES stay
+   `.gov-grid-note` AND `.gov-held-note` LIVE IN oversight.css (task 1003761).
+   They were duplicated here under a note calling the copy the cheaper of two bad
+   options, the alternative being this page loading a stylesheet named for a
+   different room. oversight.css is named for neither room and is already loaded
+   by both pages, which is the option that note did not weigh. The NAMES stay
    `gov-*` because board-room.js emits them and
    tests/government_board_room_copy.mjs reads them as literal markup. */
 
-/* The framing line under a heading — the family voice, duplicated per the header
-   note above rather than inherited across pages. */
-.gov-grid-note { margin: 0 0 14px; font-size: 13.5px; line-height: 1.5; color: var(--ink-soft); max-width: var(--measure); }
-.gov-grid-note strong { color: var(--ink); font-weight: 500; }
-.gov-grid-note code { font-family: var(--font-mono); font-size: 12.5px; color: var(--ink); overflow-wrap: anywhere; }
-
-/* "your vote" beside the reader's own row in the open ballot. */
-.gov-held-note { font-size: 12.5px; color: var(--ok); white-space: nowrap; }
-
 /* ---- the Board Room: one sitting, one panel -------------------------------------
    The card order is task 1003270's (title, ballot, the idea, the apparatus); the
    surface is the shell's .scroll (task 1003469). The subject of the vote is the

package/modules/hall-ui/public/board-room.html

@@ -65,6 +65,9 @@
 <script src="/builders/palette.js" defer></script>
 <script src="/builders/dom-utils.js?v=2026-06-16-board"></script>
 <script src="/builders/hall-kit.js"></script>
+<!-- task 1003761: the vocabulary this page and /government both speak. Must load
+     BEFORE board-room.js, which destructures window.OTBBoardLib at IIFE entry. -->
+<script src="/builders/board-lib.js?v=2026-09-10-boardlib1"></script>
 <script src="/builders/board-room.js?v=2026-09-09-board-carve"></script>
 </body>
 </html>

package/modules/hall-ui/public/board-room.js

@@ -35,14 +35,23 @@
 // reason and names one section. That requirement is why voting lives in the
 // hall and not on a chat reaction.
 //
-// ON THE DUPLICATED HELPERS. `pill` / `groupHead` / `when` / `fetchJson` /
-// `sendJson` are per-page in this module by convention (gate.js, harbor.js and
-// watch.js each carry their own — a hall page script is a self-contained IIFE
-// over the DOM). Two are a real drift risk rather than boilerplate and are
-// called out where they sit: `membershipRankKeys` mirrors the SERVER's predicate
-// grammar, and `fmtWindow` is also read by the Constitution panel that stayed in
-// government.js. tests/government_board_vote_ui.mjs holds the first equal to the
-// server; keep the second in step by hand.
+// ON THE SHARED HELPERS (task 1003761). The vocabulary this page and the
+// Constitution panel on /government BOTH speak now lives in board-lib.js, loaded
+// before this script as window.OTBBoardLib: the ladder and `membershipRankKeys`
+// (which mirror the SERVER's predicate grammar), `rankNames`, `fmtWindow`, the
+// two pass-rule maps, and the `pill` / `groupHead` / `when` row pieces. The carve
+// that split the two pages copied all of it, which is the two-copies state
+// modules/government/CLAUDE.md forbids — "the grammar is written ONCE".
+// tests/government_constitution_view.mjs holds the lib's parser equal to the
+// server's. (This header used to name tests/government_board_vote_ui.mjs for
+// that; it never asserted the parser, so the copy that lived here was pinned by
+// nothing.)
+//
+// `fetchJson` / `sendJson` stay per-page: a hall page script is a self-contained
+// IIFE over the DOM, and those two carry this page's own error copy.
+//
+// SECTION_LABELS and fmtRemaining stay HERE, not in the lib — this page is their
+// only reader, and the lib is for what the two pages share.
 //
 // The function ORDER here is deliberate and matches the pre-carve source:
 // tests/government_board_room_copy.mjs slices this file by function-name
@@ -57,8 +66,13 @@
   // /lib/bongos-client.js. baseUrl:'' passes the full `${API}${path}` URLs below
   // through unchanged; result-mode ({ status, ok, data }) preserves control flow 1:1.
   const api = window.BongosClient.createClient({ baseUrl: '', credentials: 'same-origin', throwOnError: false });
-  const { escapeHtml, fmtInt } = window.OTB;
+  const { escapeHtml } = window.OTB;
   const { emptyStateHtml } = window.OTBKit;
+  // The vocabulary /government and this page share (task 1003761). board-lib.js
+  // is loaded before this script; see the header note. The ladder and fmtInt went
+  // with it — groupHead was this page's only fmtInt reader.
+  const { membershipRankKeys, rankNames, fmtWindow,
+    PASS_RULE_PLAIN, pill, groupHead, when } = window.OTBBoardLib;
   const toast = (msg) => window.OTB.toast(msg);
 
   // ---- fetch helpers (mirror gate.js) --------------------------------------
@@ -98,52 +112,6 @@
   };
   const friendlyError = (code) => ERROR_COPY[code] || null;
 
-  // ---- shared row pieces ---------------------------------------------------
-
-  // A state pill in the shell's vocabulary. `mod` is one of the .fact-pill
-  // states (ok / warn / danger / info / quiet); the label is what the reader sees.
-  const pill = (mod, label) => `<span class="fact-pill fact-pill--${mod}">${escapeHtml(label)}</span>`;
-  const groupHead = (name, n, note) =>
-    `<div class="ov-group__head"><span class="ov-group__name">${escapeHtml(name)}</span>` +
-    (n === undefined ? '' : `<span class="ov-group__n">${fmtInt(n)}</span>`) +
-    (note ? `<span class="ov-group__note">${escapeHtml(note)}</span>` : '') +
-    '</div>';
-  // A timestamp the way the rows have always shown one: "2026-08-30 14:05".
-  const when = (iso) => escapeHtml(String(iso || '').slice(0, 16).replace('T', ' '));
-
-  // The predicate grammar, in plain language (task 1003094). This MIRRORS
-  // modules/government/membership-predicate.js — browser code cannot import the
-  // server module, the established pattern here (the five section labels do the
-  // same) — and tests/government_board_vote_ui.mjs holds the two equal.
-  //
-  // Rendering the raw predicate was fine while the only form was `rank:<key>`.
-  // It is not fine now: `rank:metic+` would read as "builders holding the metic+
-  // rank", which names a rank that does not exist and hides the very thing the
-  // suffix says.
-  const STANDARD_LADDER = ['xenos', 'thetes', 'metic', 'archon'];
-
-  function membershipRankKeys(predicate) {
-    const m = String(predicate || '');
-    if (!m.startsWith('rank:')) return null;
-    const body = m.slice(5);
-    if (!body) return null;
-    const keys = [];
-    for (const element of body.split(',')) {
-      const match = /^([a-z][a-z0-9_-]*)(\+?)$/.exec(element);
-      if (!match) return null;
-      let expanded;
-      if (match[2] === '+') {
-        const i = STANDARD_LADDER.indexOf(match[1]);
-        if (i === -1) return null;        // "and above" is undefined off the ladder
-        expanded = STANDARD_LADDER.slice(i);
-      } else {
-        expanded = [match[1]];
-      }
-      for (const k of expanded) if (keys.indexOf(k) === -1) keys.push(k);
-    }
-    return keys.length ? keys : null;
-  }
-
   // ---- the Board Room panel (R16) --------------------------------------------
 
   // The room renders what the server assembled: open items with the database's
@@ -257,37 +225,9 @@
   //
   // Read from the item's SNAPSHOT constitution (the rules in force when the
   // window opened), never today's config — the same rules the server tallies
-  // under. Rank KEYS never surface: the display label comes from the branding
-  // pack via OTB.rankLabel, as on every other hall surface. The one place a raw
-  // predicate still shows is an UNREADABLE one, where the broken string is the
-  // actionable fact and hiding it would help nobody.
-  function rankNames(keys) {
-    const labels = keys.map((k) => escapeHtml(window.OTB.rankLabel(k)));
-    if (labels.length === 1) return labels[0];
-    return `${labels.slice(0, -1).join(', ')} or ${labels[labels.length - 1]}`;
-  }
-
-  // A sitting length in the unit a person would say it in. The config stores
-  // minutes; "2880 minutes" is a number nobody converts in their head.
-  //
-  // DUPLICATED, KNOWINGLY: government.js keeps its own copy for the Constitution
-  // panel's windowSentence. Two readers, two files, one wording — if you change
-  // the phrasing here, change it there.
-  function fmtWindow(minutes) {
-    const m = Number(minutes);
-    if (!Number.isFinite(m) || m <= 0) return `${escapeHtml(String(minutes))} minutes`;
-    const plural = (n, word) => `${n} ${word}${n === 1 ? '' : 's'}`;
-    if (m % 1440 === 0) return plural(m / 1440, 'day');
-    if (m % 60 === 0) return plural(m / 60, 'hour');
-    return plural(m, 'minute');
-  }
-
-  const PASS_RULE_PLAIN = {
-    first_ratifier: 'The first vote decides it: a yes ratifies, an objection returns it to its author.',
-    consent: 'It passes unless someone objects — silence is agreement, and one reasoned objection returns it.',
-    majority: 'It passes only when more than half the board votes yes. Silence is not agreement here.',
-    unanimous: 'Everyone who votes must vote yes, and at least one member must. One objection sends it back for revision.',
-  };
+  // under. `rankNames`, `fmtWindow` and `PASS_RULE_PLAIN` come from board-lib.js
+  // (task 1003761) — the Constitution panel on /government says the same three
+  // things and used to say them from its own copies.
 
   function decidedByHtml(item) {
     const c = item.constitution || {};

package/modules/hall-ui/public/government.css

@@ -23,11 +23,9 @@
   color: var(--ink);
   text-shadow: var(--type-halo);
 }
-.gov-grid-note { margin: 0 0 14px; font-size: 13.5px; line-height: 1.5; color: var(--ink-soft); max-width: var(--measure); }
-.gov-grid-note strong { color: var(--ink); font-weight: 500; }
-.gov-grid-note code, .ov-row__sub code, .ov-row__title code, .ov-foot code {
-  font-family: var(--font-mono); font-size: 12.5px; color: var(--ink); overflow-wrap: anywhere;
-}
+/* `.gov-grid-note` (and the `.ov-*` code rule it shared a declaration with) moved
+   to oversight.css in task 1003761 — /board-room renders it too and had a copy.
+   `.gov-h` stays: this page is its only renderer. */
 
 /* Holds the ladder-rank reset button. Empty for every other rank, so it collapses
    rather than reserving a gap — hence no margin on the empty box itself. */
@@ -57,9 +55,13 @@
 }
 
 /* ---- the Board Room: MOVED OUT to board-room.css (ADR 0266) ----------------
-   The sitting card, the ballot controls and `.gov-held-note` went with the room
-   when it became its own page. Nothing on THIS page renders them, so they are
-   not kept here "just in case" — board-room.css is where they live. */
+   The sitting card and the ballot controls went with the room when it became its
+   own page, and nothing here renders them.
+   CORRECTION (task 1003761): `.gov-held-note` went with them under the same
+   "nothing on THIS page renders them" reasoning, and that was wrong —
+   renderRankList marks a held Archon rank with one, so it rendered unstyled here
+   from the carve until this task. It lives in oversight.css now, which both
+   pages load. */
 
 /* ---- the charter library ------------------------------------------------------- */
 /* The configuration line under a charter: what an owner would type, in the

package/modules/hall-ui/public/government.html

@@ -139,6 +139,9 @@
 <script src="/builders/palette.js" defer></script>
 <script src="/builders/dom-utils.js?v=2026-06-16-gate"></script>
 <script src="/builders/hall-kit.js"></script>
+<!-- task 1003761: the vocabulary this page and /board-room both speak. Must load
+     BEFORE government.js, which destructures window.OTBBoardLib at IIFE entry. -->
+<script src="/builders/board-lib.js?v=2026-09-10-boardlib1"></script>
 <script src="/builders/government.js?v=2026-09-02-gov-rows"></script>
 </body>
 </html>

package/modules/hall-ui/public/government.js

@@ -79,6 +79,10 @@
   const api = window.BongosClient.createClient({ baseUrl: '', credentials: 'same-origin', throwOnError: false });
   const { escapeHtml, fmtInt } = window.OTB;
   const { emptyStateHtml } = window.OTBKit;
+  // The vocabulary this page and the Board Room share (task 1003761).
+  // board-lib.js is loaded before this script.
+  const { STANDARD_LADDER, membershipRankKeys, rankNames, fmtWindow,
+    PASS_RULE_NAME, pill, groupHead, when } = window.OTBBoardLib;
   const toast = (msg) => window.OTB.toast(msg);
 
   // ---- fetch helpers (mirror gate.js) --------------------------------------
@@ -137,19 +141,6 @@
 
   const selectedRank = () => ranks.find((r) => r.rank_key === selectedRankKey) || null;
 
-  // ---- shared row pieces ---------------------------------------------------
-
-  // A state pill in the shell's vocabulary. `mod` is one of the .fact-pill
-  // states (ok / warn / danger / info / quiet); the label is what the reader sees.
-  const pill = (mod, label) => `<span class="fact-pill fact-pill--${mod}">${escapeHtml(label)}</span>`;
-  const groupHead = (name, n, note) =>
-    `<div class="ov-group__head"><span class="ov-group__name">${escapeHtml(name)}</span>` +
-    (n === undefined ? '' : `<span class="ov-group__n">${fmtInt(n)}</span>`) +
-    (note ? `<span class="ov-group__note">${escapeHtml(note)}</span>` : '') +
-    '</div>';
-  // A timestamp the way the rows have always shown one: "2026-08-30 14:05".
-  const when = (iso) => escapeHtml(String(iso || '').slice(0, 16).replace('T', ' '));
-
   // ---- render: rank list ---------------------------------------------------
 
   // One rank, one selectable oversight row: the label, the DESCRIPTION the
@@ -539,39 +530,12 @@
   // switch can never be flipped quietly, and every change is auditable against
   // the constitution of its day.
 
-  // The predicate grammar, in plain language (task 1003094). This MIRRORS
-  // modules/government/membership-predicate.js — browser code cannot import the
-  // server module, the established pattern here (the five section labels do the
-  // same) — and tests/government_board_vote_ui.mjs holds the two equal.
-  //
-  // Rendering the raw predicate was fine while the only form was `rank:<key>`.
-  // It is not fine now: `rank:metic+` would read as "builders holding the metic+
-  // rank", which names a rank that does not exist and hides the very thing the
-  // suffix says. A constitution panel that misdescribes who governs is the
-  // failure this whole task exists to fix, one layer up.
-  const STANDARD_LADDER = ['xenos', 'thetes', 'metic', 'archon'];
-
-  function membershipRankKeys(predicate) {
-    const m = String(predicate || '');
-    if (!m.startsWith('rank:')) return null;
-    const body = m.slice(5);
-    if (!body) return null;
-    const keys = [];
-    for (const element of body.split(',')) {
-      const match = /^([a-z][a-z0-9_-]*)(\+?)$/.exec(element);
-      if (!match) return null;
-      let expanded;
-      if (match[2] === '+') {
-        const i = STANDARD_LADDER.indexOf(match[1]);
-        if (i === -1) return null;        // "and above" is undefined off the ladder
-        expanded = STANDARD_LADDER.slice(i);
-      } else {
-        expanded = [match[1]];
-      }
-      for (const k of expanded) if (keys.indexOf(k) === -1) keys.push(k);
-    }
-    return keys.length ? keys : null;
-  }
+  // The predicate grammar and the ladder it expands against come from
+  // board-lib.js (task 1003761). They MIRROR modules/government/
+  // membership-predicate.js — browser code cannot import the server module —
+  // and the carve that took the Board Room onto its own page had left a second
+  // copy here. A constitution panel that misdescribes who governs is the failure
+  // this whole area exists to fix, and two copies is how it gets there.
 
   function membershipSentence(board) {
     const raw = String(board.membership || '');
@@ -682,18 +646,10 @@
     close_early_on_full_turnout: 'Closing early on full turnout',
   };
 
-  // A list of rank keys as their display labels, in a phrase a person would say
-  // ("Metic or Archon"). Carved-region residue with a twist (ADR 0266): the copy
-  // that lived here went to board-room.js with the sitting card, and this one
-  // came BACK because the divergence warning below (task 1003739, ADR 0268)
-  // landed a new reader on the Constitution side while the room was moving out.
-  // Its only caller is fieldValueHtml; membershipSentence above spells its own
-  // labels inline, so do not route that through here expecting one wording.
-  function rankNames(keys) {
-    const labels = keys.map((k) => escapeHtml(window.OTB.rankLabel(k)));
-    if (labels.length === 1) return labels[0];
-    return `${labels.slice(0, -1).join(', ')} or ${labels[labels.length - 1]}`;
-  }
+  // `rankNames` comes from board-lib.js (task 1003761). Its only caller here is
+  // fieldValueHtml; membershipSentence above spells its own labels inline because
+  // it wraps each in <strong>, so do not route that through it expecting one
+  // wording.
 
   // One constitution VALUE, in the words a person would use — the same rule the
   // dials keep, applied to the two halves of a divergence. Without this the
@@ -716,32 +672,11 @@
 
   // One dial, one row: the dial's name as the title, the live sentence as the
   // sub line. The sentence is trusted HTML from the helpers above.
-  // A sitting length in the unit a person would say it in. The config stores
-  // minutes; "2880 minutes" is a number nobody converts in their head.
   //
-  // Lived in the Board Room region until ADR 0266 carved that room onto its own
-  // page. It stayed because windowSentence above reads it; board-room.js keeps
-  // its own copy for the sitting card. Two readers, two files, one wording — if
-  // you change the phrasing here, change it there.
-  function fmtWindow(minutes) {
-    const m = Number(minutes);
-    if (!Number.isFinite(m) || m <= 0) return `${escapeHtml(String(minutes))} minutes`;
-    const plural = (n, word) => `${n} ${word}${n === 1 ? '' : 's'}`;
-    if (m % 1440 === 0) return plural(m / 1440, 'day');
-    if (m % 60 === 0) return plural(m / 60, 'hour');
-    return plural(m, 'minute');
-  }
-
-  // The short name of a pass rule, for a place a whole sentence will not fit —
-  // the change-history line below. Also carved-region residue (ADR 0266): the
-  // sentence-length twin PASS_RULE_PLAIN went to board-room.js with the card,
-  // this one stayed with its only reader, historyRow.
-  const PASS_RULE_NAME = {
-    first_ratifier: 'by first ratifier',
-    consent: 'by consent',
-    majority: 'by majority',
-    unanimous: 'by unanimous agreement',
-  };
+  // `fmtWindow` and `PASS_RULE_NAME` come from board-lib.js (task 1003761).
+  // fmtWindow had a twin in board-room.js under a "keep the phrasing in step by
+  // hand" note; PASS_RULE_NAME sits beside its sentence-length twin
+  // PASS_RULE_PLAIN there, so the two renderings of one pass rule cannot drift.
 
   function dialRow(name, sentenceHtml) {
     return `<li class="ov-row"><div class="ov-row__main"><span class="ov-row__title">${escapeHtml(name)}</span><p class="ov-row__sub">${sentenceHtml}</p></div></li>`;
@@ -794,6 +729,14 @@
   // `predicate: null` means the predicate is the owner's to choose (Foundation
   // names their own custom rank), which is honest rather than unchecked — the
   // test asserts such a charter says so in its `how`.
+  //
+  // A SECOND test pins these too, for a different reason. The `rank:xenos+` row
+  // spells the full ladder out in `seatsRanks`, and that literal is why this file
+  // stays in tests/rank_tier_single_source.mjs's STATIC_LADDER_FILES even though
+  // task 1003761 moved the page's real ladder to board-lib.js. It is documentation
+  // of the grammar rather than a second implementation of it — but a worked
+  // example that drifts teaches a ladder nobody has, so it is held to the
+  // canonical order.
   const CHARTERS = [
     { key: 'monarchy', name: 'Monarchy / BDFL', selectable: true,
       predicate: 'rank:archon', seatsRanks: ['archon'],
@@ -919,8 +862,11 @@
   // What stayed behind, and why, so neither reads as a leftover:
   //   • fmtWindow      — windowSentence (the Constitution's clock dial) reads it.
   //   • PASS_RULE_NAME — historyRow (the amendment history line) reads it.
-  // Both are duplicated in board-room.js rather than shared; a hall page script
-  // is a self-contained IIFE, which is the convention here.
+  // Both READERS are still here; the two helpers themselves are not. Task 1003761
+  // hoisted them into board-lib.js, which this page destructures at IIFE entry.
+  // This block used to end "both are duplicated in board-room.js rather than
+  // shared; a hall page script is a self-contained IIFE, which is the convention
+  // here" — that was the justification for the copies, and it is retired.
   //
   // The old deep link is redirected below in init() — a fragment never reaches
   // the server, so #board-room could not be caught by a route.

package/modules/hall-ui/public/oversight.css

@@ -178,6 +178,37 @@ a.fact-chip:hover { color: var(--accent-ink); border-color: var(--accent-ink); t
 .ov-danger { color: var(--danger); }
 .ov-ok { color: var(--ok); }
 
+/* ---- the government family's two shared lines (task 1003761) -----------------
+   Both are rendered by /government AND /board-room, so they belong to the family
+   sheet both pages load rather than to either page's own. ADR 0266's carve had
+   put them elsewhere, and each half of that was wrong in its own way:
+
+   `.gov-grid-note` was COPIED into board-room.css under a header note calling
+   the duplication the cheaper of two bad options — the alternative it weighed
+   was one page loading a sheet named for the other page's room. This sheet is
+   named for neither room, which is the option that was missing.
+
+   `.gov-held-note` was MOVED to board-room.css under a note in government.css
+   saying "nothing on THIS page renders them". government.js does: it marks a
+   held Archon rank with one (renderRankList). So that line has rendered unstyled
+   on /government since the carve — a live defect, not a tidiness point.
+
+   The NAMES stay `gov-*`: board-room.js and government.js emit them, and
+   tests/government_board_room_copy.mjs reads `.gov-grid-note` as literal markup.
+   The `.ov-*` selectors on the code rule came with it from government.css, where
+   they were already sharing the declaration. */
+
+/* The framing line under a heading — the family's voice. */
+.gov-grid-note { margin: 0 0 14px; font-size: 13.5px; line-height: 1.5; color: var(--ink-soft); max-width: var(--measure); }
+.gov-grid-note strong { color: var(--ink); font-weight: 500; }
+.gov-grid-note code, .ov-row__sub code, .ov-row__title code, .ov-foot code {
+  font-family: var(--font-mono); font-size: 12.5px; color: var(--ink); overflow-wrap: anywhere;
+}
+
+/* "your vote" beside the reader's own row in the open ballot (/board-room), and
+   "held" beside an Archon-held rank (/government). */
+.gov-held-note { font-size: 12.5px; color: var(--ok); white-space: nowrap; }
+
 /* Detail lines under a row: a reason per line (the gate's holds), or a key and
    a value (the harbor's make and cost). Hairlines between, none on the first. */
 .ov-lines { list-style: none; margin: 10px 0 0; padding: 0; max-width: 72ch; }

package/modules/lifecycle/db-rank-authz.js

@@ -80,15 +80,33 @@ function xenosClaimAllowed(rank, newcomerFriendly) {
 
 // claimPermissionsFor — the builder's effective permission set for the claim
 // decision, read through the `governance` kernel PORT (never by importing the
-// module — the one-way rule, ADR 0083). Returns a Set, or NULL when authority
-// cannot be ESTABLISHED, which claimEligibilityAllows reads as "fall back to the
-// incumbent rank rule":
-//   • the governance module is not mounted (no port), or the resolver throws;
-//   • the builder resolves to ZERO permissions — i.e. they hold no role row.
-//     governance_002's backfill is run-once and nothing yet re-assigns a rank-role
-//     when a builder is created or re-ranked, so this is a live gap, not a theory.
-// Every seeded rank-role grants at least twelve permissions, so an empty set never
-// means "a real role that grants nothing" today.
+// module — the one-way rule, ADR 0083).
+//
+// NULL means authority could not be ESTABLISHED, which claimEligibilityAllows
+// reads as "fall back to the incumbent rank rule". Exactly two things mean that:
+//   • the governance module is not mounted (no port), so there is no authority
+//     system to ask;
+//   • the resolver threw, so the answer is unknown rather than empty.
+//
+// AN EMPTY SET IS AN ANSWER, NOT A FAILURE (task 1003816). It used to be folded
+// into the null above, on the stated grounds that governance_002's backfill was
+// run-once and nothing re-assigned a rank-role afterwards — so a builder holding
+// no role row was a live gap rather than a real verdict. That is no longer true,
+// and the three writes that closed it are all shipped:
+//   • BV1.R95b rotates the role inside the rank-change transaction, and syncs it
+//     on every sign-in (src/bongos/auth-admission.js safeSyncRankRole);
+//   • task 1003193 rotates it in-tx on offboard AND reactivation;
+//   • governance_005 repaired the rows already written.
+// governance_005 states the intended reading in as many words — a builder with no
+// role row "resolves to the empty set (denied everywhere)" — and
+// syncGovernanceRankRole calls that same outcome "the fail-closed answer". Folding
+// it back into the rank rule is what stopped those three from being true at the
+// claim gate, so the empty set now flows through as a real deny.
+//
+// The residual way to hold no role row is the sign-in sync failing transiently
+// (it is deliberately best-effort so a governance hiccup cannot block a sign-in).
+// Denying the claim is the correct read of that state, and it self-repairs on the
+// next successful sign-in.
 //
 // Called BEFORE the claim transaction opens: authority is a per-request read (ADR
 // 0016 — resolved server-side, uncached), and taking a second pool connection while
@@ -98,7 +116,9 @@ async function claimPermissionsFor(builderId) {
   if (!governance || typeof governance.resolveBuilderPermissions !== 'function') return null;
   try {
     const keys = await governance.resolveBuilderPermissions(builderId);
-    if (!keys || keys.length === 0) return null;
+    // A non-array is a broken port contract, not a verdict — resolveBuilderPermissions
+    // always returns an array. Treat it as "could not establish", never as "denied".
+    if (!Array.isArray(keys)) return null;
     return new Set(keys);
   } catch (err) {
     console.error('[gds] claim eligibility: permission resolve failed, falling back to the rank rule', err);

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.655",
+  "version": "1.19.657",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.655",
+      "version": "1.19.657",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.655",
+  "version": "1.19.657",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.655'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.657'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/government_board_room_copy.mjs

@@ -36,6 +36,10 @@ const CLIENT = fs.readFileSync(path.join(ROOT, 'modules', 'hall-ui', 'public', '
 const HTML = fs.readFileSync(path.join(ROOT, 'modules', 'hall-ui', 'public', 'government.html'), 'utf8');
 const BOARD = fs.readFileSync(path.join(ROOT, 'modules', 'hall-ui', 'public', 'board-room.js'), 'utf8');
 const BOARD_HTML = fs.readFileSync(path.join(ROOT, 'modules', 'hall-ui', 'public', 'board-room.html'), 'utf8');
+// The vocabulary both pages speak (task 1003761). The pass-rule maps and
+// rankNames were one copy per page until the hoist; the assertions that read
+// them come here now, and there is one place to read rather than two.
+const LIB = fs.readFileSync(path.join(ROOT, 'modules', 'hall-ui', 'public', 'board-lib.js'), 'utf8');
 const { PASS_RULES } = require(path.join(ROOT, 'modules', 'government', 'config.js'));
 
 const card = () => BOARD.slice(BOARD.indexOf('function itemCard'), BOARD.indexOf('async function loadBoard'));
@@ -47,7 +51,13 @@ const card = () => BOARD.slice(BOARD.indexOf('function itemCard'), BOARD.indexOf
 const CODE = BOARD.split(/\r?\n/).filter((l) => !/^\s*\/\//.test(l)).join('\n');
 
 test('every pass rule the server can hold has a plain-language sentence', () => {
-  const block = BOARD.slice(BOARD.indexOf('const PASS_RULE_PLAIN'), BOARD.indexOf('function decidedByHtml'));
+  // In board-lib.js since task 1003761. Both landmarks are asserted before the
+  // slice for the reason the next test spells out: an indexOf that misses
+  // returns -1, and slice(start, -1) would hand this most of the file.
+  const start = LIB.indexOf('const PASS_RULE_PLAIN');
+  const end = LIB.indexOf('shared row pieces');
+  assert.ok(start !== -1 && end > start, 'PASS_RULE_PLAIN sits above the row pieces in board-lib.js');
+  const block = LIB.slice(start, end);
   assert.ok(PASS_RULES.length >= 3, `sanity: found the real rule set (${PASS_RULES})`);
   for (const rule of PASS_RULES) {
     assert.ok(block.includes(`${rule}:`), `PASS_RULE_PLAIN must explain '${rule}' — a rule with no copy renders its enum key`);
@@ -60,24 +70,24 @@ test('every pass rule the server can hold has a plain-language sentence', () =>
 });
 
 test('the short name map covers the same rule set (the history line)', () => {
-  // Its reader (historyRow, the amendment change-history) stayed on the
-  // government page when ADR 0266 carved the room out, so this map stayed with
-  // it. The slice therefore ends at a landmark that is still IN government.js —
-  // it used to end at `const PASS_RULE_PLAIN`, which has moved to board-room.js,
-  // and an indexOf that misses returns -1: `slice(start, -1)` would have handed
-  // this assertion most of the file and passed for the wrong reason.
-  const start = CLIENT.indexOf('const PASS_RULE_NAME');
-  const end = CLIENT.indexOf('function dialRow');
-  assert.ok(start !== -1 && end > start, 'PASS_RULE_NAME sits above dialRow in government.js');
-  const block = CLIENT.slice(start, end);
+  // Its reader (historyRow, the amendment change-history) is on the government
+  // page; the map itself joined its sentence-length twin in board-lib.js in task
+  // 1003761, so the two renderings of one pass rule sit adjacent and cannot
+  // describe the same rule differently. The landmark check stays and matters:
+  // an indexOf that misses returns -1, and `slice(start, -1)` would hand this
+  // assertion most of the file and pass for the wrong reason.
+  const start = LIB.indexOf('const PASS_RULE_NAME');
+  const end = LIB.indexOf('const PASS_RULE_PLAIN');
+  assert.ok(start !== -1 && end > start, 'PASS_RULE_NAME sits above PASS_RULE_PLAIN in board-lib.js');
+  const block = LIB.slice(start, end);
   for (const rule of PASS_RULES) {
     assert.ok(block.includes(`${rule}:`), `PASS_RULE_NAME must name '${rule}'`);
   }
 });
 
 test('a rank reaches the reader as a LABEL, never as the enum key', () => {
-  assert.match(BOARD, /function rankNames\(keys\)[\s\S]*?window\.OTB\.rankLabel\(k\)/,
-    'the board card resolves rank keys through the branding pack');
+  assert.match(LIB, /function rankNames\(keys\)[\s\S]*?window\.OTB\.rankLabel\(k\)/,
+    'the shared vocabulary resolves rank keys through the branding pack');
   const membership = CLIENT.slice(CLIENT.indexOf('function membershipSentence'), CLIENT.indexOf('function passRuleSentence'));
   assert.match(membership, /window\.OTB\.rankLabel\(k\)/,
     'so does the Constitution sentence — `archon` is an enum, "Owner" is what a person reads');
@@ -101,7 +111,13 @@ test('the card order is title → action → the idea → the apparatus', () =>
 });
 
 test('the idea renders OPEN — never behind a summary', () => {
-  const sections = BOARD.slice(BOARD.indexOf('function ideaSectionsHtml'), BOARD.indexOf('function rankNames'));
+  // Ends at decidedByHtml, the declaration that now follows: rankNames was the
+  // old landmark and moved to board-lib.js in task 1003761. Asserted, not
+  // assumed — a missing landmark is -1 and would silently invert this test.
+  const from = BOARD.indexOf('function ideaSectionsHtml');
+  const to = BOARD.indexOf('function decidedByHtml');
+  assert.ok(from !== -1 && to > from, 'ideaSectionsHtml sits above decidedByHtml in board-room.js');
+  const sections = BOARD.slice(from, to);
   assert.ok(!/<details/.test(sections),
     'the substance of the vote is not a disclosure — that was the reported bug');
   assert.match(sections, /gov-idea__body/, 'and it is set as prose, not as a config row');