@bongos/core 1.19.622 → 1.19.624

package/docs/module-api-changelog.md

@@ -1693,5 +1693,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.620 with no explicit bump. run 34321546662. (task 1002620)
   1.19.622 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.621 with no explicit bump. run 34322091367. (task 1002620)
+  1.19.623 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.622 with no explicit bump. run 34323141703. (task 1002620)
+  1.19.624 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.623 with no explicit bump. run 34326009063. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/builder-settings/builder-needs.js

@@ -219,6 +219,36 @@ function mingleIntroductionsNeed(ctx) {
 
 const NEEDS = [artKeyNeed, helpRequestsNeed, taskRecommendationsNeed, boardVotesNeed, mingleIntroductionsNeed];
 
+// Priority WITHIN a state bucket (task 1003738). computeNeeds used to sort by
+// state alone with a stable sort, so the NEEDS array order silently decided
+// which item a single-slot renderer showed. board_votes sits fourth, behind
+// art_key — so any builder with an unset image key never saw a waiting board
+// vote, while both renderers' comments claimed they showed "the highest-priority"
+// need. Within a bucket there was no such thing.
+//
+// NOT keyed on `severity`, which is the obvious-looking choice and the wrong
+// one: art_key is severity 'action' and board_votes is 'info', so ordering by
+// severity would have PRESERVED the exact bug this fixes. The rule here is who
+// is waiting:
+//
+//   A NEED SOMEONE ELSE IS BLOCKED ON OUTRANKS A NEED THAT ONLY AFFECTS YOU.
+//
+// A sitting cannot be decided until a member votes, and its window can expire;
+// an unset art key stops only your own art, whenever you next want it.
+//
+// Lower number = louder. An id missing from this map sorts last, so appending to
+// NEEDS without a weight is safe (it just lands at the back of its bucket).
+// founding_welcome is deliberately negative: during the founding grace the
+// roster leads with the welcome, which is what the grace is for.
+const NEED_PRIORITY = {
+  founding_welcome: -1,
+  board_votes: 0,
+  help_requests: 1,
+  art_key: 2,
+  task_recommendations: 3,
+  mingle_introductions: 4,
+};
+
 // ---- founding grace (task 1002739 / direction §5.6, idea 1000701) -----------
 //
 // A freshly-provisioned instance used to greet its founding owner with "your
@@ -265,9 +295,14 @@ function foundingWelcomeNeed(ctx) {
 // functions read (see each need's doc). Returns:
 //   { items: Need[], action_needed_count, has_action_needed }
 // items is ordered: action_needed first (loudest), then covered, then satisfied,
-// so any renderer that takes "the first one" gets the most urgent. During the
-// founding grace nothing is action_needed, so the welcome (prepended before the
-// stable sort) is what that renderer shows.
+// and WITHIN each bucket by NEED_PRIORITY above — so a renderer that takes "the
+// first one" really does get the most urgent, which before task 1003738 it did
+// not (it got whichever need NEEDS happened to list first). During the founding
+// grace nothing is action_needed, so the welcome is what that renderer shows.
+//
+// A renderer that can show a LIST should render every action_needed item rather
+// than the first: ordering decides emphasis, it does not make the rest safe to
+// drop. Home's "From the system" inbox does exactly that.
 function computeNeeds(ctx = {}) {
   const grace = foundingGraceActive(ctx);
   let items = NEEDS.map((fn) => fn(ctx)).filter(Boolean);
@@ -282,7 +317,8 @@ function computeNeeds(ctx = {}) {
     items.unshift(foundingWelcomeNeed(ctx));
   }
   const order = { action_needed: 0, covered: 1, satisfied: 2 };
-  items.sort((a, b) => (order[a.state] ?? 9) - (order[b.state] ?? 9));
+  const weight = (n) => NEED_PRIORITY[n.id] ?? 99;
+  items.sort((a, b) => ((order[a.state] ?? 9) - (order[b.state] ?? 9)) || (weight(a) - weight(b)));
   const actionNeeded = items.filter((n) => n.state === 'action_needed');
   return {
     items,
@@ -299,4 +335,5 @@ module.exports = {
   foundingGraceActive,
   FOUNDING_GRACE_DAYS,
   SETTINGS_PATH,
+  NEED_PRIORITY,
 };

package/modules/economy/credits.js

@@ -931,6 +931,43 @@ async function sumCreditsForTasks(builderId, taskIds) {
   return rows[0] ? rows[0].total : 0;
 }
 
+// sumSessionEarnings — what ONE session actually earned its builder, across BOTH
+// of the ledger's attribution keys. The authoritative answer to the question
+// session_records.drachmae_earned exists to mirror.
+//
+// Why it has to be two keys: credit_log rows reach a builder by two different
+// routes, and each stream picks exactly one. The per-task streams (the confirm
+// credit, the idea slices) key on `task_id` and leave session_id NULL. The
+// cost-plus session reward (ADR 0054) is the mirror image — it keys on
+// `session_id` and leaves task_id NULL deliberately, because it pays for the
+// SESSION's real token spend, not for any one task in it.
+//
+// sumCreditsForTasks() above sees only the first route. That was survivable while
+// every instance paid both streams, but under reward mode 'cost-plus-only'
+// (ADR 0146 — this instance's standing choice) the session reward is the ONLY
+// stream that pays, so a task_id-keyed sum is structurally always 0 and the hall
+// told every builder they had earned nothing for work they were genuinely paid
+// for (task 1003634). A builder reported it as missing pay; the money was never
+// missing, the mirror was.
+//
+// `executor` is a Pool or a tx client, so the caller can ask INSIDE the same
+// transaction that just booked the reward and see it. The OR is one predicate over
+// one scan, so a row matching both keys is summed once, not twice — the figure is
+// a pure function of ledger state and can be re-derived any number of times.
+async function sumSessionEarnings(executor, builderId, taskIds, sessionId) {
+  const ids = Array.isArray(taskIds) ? taskIds.map(Number).filter(Number.isFinite) : [];
+  const sid = sessionId == null ? null : String(sessionId);
+  if (ids.length === 0 && !sid) return 0;
+  const { rows } = await executor.query(
+    `SELECT COALESCE(SUM(delta), 0)::int AS total
+       FROM credit_log
+      WHERE builder_id = $1
+        AND (task_id = ANY($2::bigint[]) OR ($3::text IS NOT NULL AND session_id = $3))`,
+    [builderId, ids, sid]
+  );
+  return rows[0] ? rows[0].total : 0;
+}
+
 // The three ideator streams (ADR 0172) each book under a reason key that EMBEDS
 // the idea (and, for stream 1, the task) — that string IS the idempotency
 // predicate, which is why it can't be a bare constant:
@@ -1038,6 +1075,7 @@ module.exports = {
   netNegativeBonusAmount,
   awardNetNegativeBonus,
   sumCreditsForTasks,
+  sumSessionEarnings,
   // the ledger read surface (task 1003484, blocker 1000127)
   creditLedger,
   IDEA_STREAM_REASON_PREFIXES,

package/modules/economy/reward.js

@@ -73,6 +73,11 @@ module.exports = {
   getBuilderAchievements: (...a) => achievements.getBuilderAchievements(...a),
   getLockedAchievementsProgress: (...a) => achievements.getLockedAchievementsProgress(...a),
   sumCreditsForTasks: (...a) => credits.sumCreditsForTasks(...a),
+  // The two-key session earnings sum (task 1003634) — transaction-participant:
+  // the sessions module passes its tx `client` so it reads the cost-plus reward
+  // its own transaction just booked. On the port because credit_log is economy's
+  // table and sessions may only cross the wall through here (ADR 0083 / 0093 §2).
+  sumSessionEarnings: (...a) => credits.sumSessionEarnings(...a),
   // The per-row ledger read (task 1003484). On the port because the surface core
   // most wants it for is a HALL view — "what did this idea earn me" — and a core
   // route must reach economy through here, never by importing the module.

package/modules/hall-ui/public/board-room.css

@@ -0,0 +1,83 @@
+/* board-room.css — Page-local styles for the Board Room (/builders/board-room).
+
+   Carved out of government.css by ADR 0266, with the room itself: these rules
+   were the `#board-room` tab's and nothing on the government page reads them
+   any more, so leaving them there would have been dead weight on a sheet two
+   other rooms still load. What lives here is what only this page has — the
+   sitting card in task 1003270's order (title, ballot, the idea, the
+   apparatus) and the ballot controls. The panel is the shell's .scroll and the
+   rows are the oversight family's (oversight.css); the ?v= cache-bust is
+   stamped from this file's content hash at boot (src/asset-version.js).
+
+   TWO RULES ARE DUPLICATED FROM government.css, KNOWINGLY. `.gov-grid-note` is
+   the government family's framing-line voice, and the sitting card spends it in
+   three places (decidedByHtml, the own-idea note, the objection hint) — while
+   the Constitution panel still spends it over there. Copying two short rules is
+   the cheaper of two bad options: the alternative is this page loading a
+   stylesheet named for a different room in order to inherit them, which is what
+   the first cut of this carve did and what the review called out. The NAMES stay
+   `gov-*` because board-room.js emits them and
+   tests/government_board_room_copy.mjs reads them as literal markup. */
+
+/* The framing line under a heading — the family voice, duplicated per the header
+   note above rather than inherited across pages. */
+.gov-grid-note { margin: 0 0 14px; font-size: 13.5px; line-height: 1.5; color: var(--ink-soft); max-width: var(--measure); }
+.gov-grid-note strong { color: var(--ink); font-weight: 500; }
+.gov-grid-note code { font-family: var(--font-mono); font-size: 12.5px; color: var(--ink); overflow-wrap: anywhere; }
+
+/* "your vote" beside the reader's own row in the open ballot. */
+.gov-held-note { font-size: 12.5px; color: var(--ok); white-space: nowrap; }
+
+/* ---- the Board Room: one sitting, one panel -------------------------------------
+   The card order is task 1003270's (title, ballot, the idea, the apparatus); the
+   surface is the shell's .scroll (task 1003469). The subject of the vote is the
+   panel heading; the ballot sits directly under it; the idea is prose; the
+   constitutional apparatus stays one disclosure away with the tally on its summary. */
+.gov-item__head { display: flex; flex-wrap: wrap; align-items: baseline; justify-content: space-between; gap: 6px 14px; }
+.gov-item__title {
+  margin: 0 0 8px;
+  min-width: 0;
+  font-family: var(--font-display);
+  font-weight: 300;
+  font-size: 21px;
+  line-height: 1.15;
+  letter-spacing: -0.03em;
+  color: var(--ink);
+  text-shadow: var(--type-halo);
+  overflow-wrap: anywhere;
+}
+.gov-item__title a { color: inherit; text-decoration: none; }
+.gov-item__title a:hover { color: var(--accent-ink); text-decoration: underline; text-underline-offset: 3px; }
+.gov-item__title .fact-pill { vertical-align: middle; margin-left: 10px; text-shadow: none; }
+.gov-item__state { display: inline-flex; align-items: center; gap: 10px; font-size: 12.5px; color: var(--ink-faint); font-variant-numeric: tabular-nums; }
+.gov-item__amend { margin: 0 0 12px; font-size: 13.5px; line-height: 1.5; color: var(--ink-soft); max-width: var(--measure); overflow-wrap: anywhere; }
+.gov-item__act { margin: 8px 0 4px; }
+.gov-item__cast { margin: 0; font-size: 13.5px; color: var(--ink-soft); }
+.gov-item__meta { margin: var(--sp-sm) 0 0; border-top: var(--line) solid var(--rule-soft); }
+.gov-item__summary { padding: 12px 0 0; min-height: 24px; cursor: pointer; font-size: 12.5px; color: var(--ink-soft); list-style-position: inside; }
+.gov-item__summary:hover { color: var(--ink); }
+.gov-item__metabody { padding: 12px 0 0; }
+.gov-item__metabody .gov-grid-note { margin: 0 0 8px; }
+.gov-item__metabody .gov-grid-note:last-child { margin-bottom: 0; }
+.gov-item__metabody .ov-rows { margin-top: 12px; }
+/* The head over the closed sittings sits on the ground between panels, so it
+   carries the air a panel would. */
+.gov-board__divider { margin: var(--sp-md) 0 var(--sp-sm); }
+
+/* ---- the ballot controls ------------------------------------------------------ */
+/* The two ballot controls sit on one row; the objection disclosure takes the
+   whole row only once it is open, so its form drops under both buttons. */
+.gov-vote { display: flex; flex-wrap: wrap; align-items: flex-start; gap: 10px; }
+.gov-vote > .gov-grid-note { flex: 1 1 100%; margin: 0; }
+.gov-vote__no { flex: 0 1 auto; }
+.gov-vote__no[open] { flex: 1 1 100%; }
+/* The disclosure IS the secondary button, so its marker must go — otherwise the
+   triangle sits inside the pill. */
+.gov-vote__no > summary { display: inline-flex; cursor: pointer; }
+.gov-vote__no > summary::marker { content: ''; }
+.gov-vote__no > summary::-webkit-details-marker { display: none; }
+.gov-vote__no > *:not(summary) { margin-top: 10px; }
+.gov-vote__no textarea { display: block; width: 100%; max-width: var(--measure); box-sizing: border-box; }
+.gov-vote__sections { display: flex; flex-wrap: wrap; gap: 6px 16px; }
+.gov-vote__section { display: inline-flex; align-items: center; gap: 8px; min-height: 24px; font-size: 13px; color: var(--ink); cursor: pointer; }
+.gov-vote__section input { width: 16px; height: 16px; margin: 0; }

package/modules/hall-ui/public/board-room.html

@@ -0,0 +1,70 @@
+<!doctype html>
+<html lang="en">
+<head>
+  <meta charset="utf-8">
+  <meta name="viewport" content="width=device-width, initial-scale=1">
+  <title>Board Room — {{worldName}}</title>
+  <meta name="description" content="The Board Room — where a Full Idea that cleared the completeness grade is ratified, and where the constitution itself is amended.">
+  <link rel="icon" href="data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 32 32'><text x='16' y='24' font-size='24' text-anchor='middle' font-family='sans-serif'>⌂</text></svg>">
+  <link rel="preconnect" href="https://fonts.googleapis.com">
+  <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
+  <link rel="stylesheet" href="/builders/style.css?v=2026-07-02-shell1">
+  <link rel="stylesheet" href="/builders/oversight.css">
+  <!-- The room's own sheet: the sitting card and the ballot controls moved here
+       out of government.css with the room (ADR 0266), so neither page carries the
+       other's rules. board-room.css's header records the two family rules it
+       duplicates rather than inherit across pages. -->
+  <link rel="stylesheet" href="/builders/board-room.css">
+</head>
+<body data-page="board-room" data-page-title="Board Room">
+
+<div class="app">
+  <aside class="app-sidebar" id="app-sidebar" aria-label="Primary"></aside>
+  <div class="app-scrim" id="app-scrim" hidden></div>
+  <div class="app-body">
+    <header class="app-topbar" id="app-topbar"></header>
+    <div class="app-content">
+      <!-- The board page head (task 1003307): the LABEL voice, not a display
+           line, because on a working surface the page's own name is the least
+           interesting thing on it. -->
+      <div class="page-head page-head--board">
+        <h1 class="page-head__h">Board Room</h1>
+        <p class="page-head__sub" id="board-sub">Loading…</p>
+      </div>
+
+      <main id="hall-main">
+        <!-- task 1003469: the sealed state is a panel with a heading, not a bare
+             line on the ground. board-room.js writes the floor into the lede from
+             the pack's rank label, so the copy cannot drift. Unlike its
+             neighbours this page's floor is the VOTE atom (xenos), so the sealed
+             state is what a signed-out or ineligible visitor sees, not a rank
+             notice — see ADR 0266. -->
+        <section class="scroll" id="board-sealed" aria-labelledby="board-sealed-h" hidden>
+          <h2 class="scroll__h" id="board-sealed-h">Restricted</h2>
+          <p class="scroll__lede" id="board-sealed-body">This page is for members of the board.</p>
+        </section>
+
+        <!-- A sitting IS the panel (task 1003469), so the room itself is bare
+             ground: the lede sits over the sittings, each of which is a .scroll.
+             The <h1> above is the room's name, so there is no second heading. -->
+        <section id="board-body" hidden>
+          <p class="gov-grid-note">Read an idea, then decide. An objection needs a reason and the section it faults.</p>
+          <div id="gov-board"><span class="kit-skel"></span></div>
+        </section>
+      </main>
+
+      <footer class="app-foot" id="app-foot"></footer>
+    </div>
+  </div>
+</div>
+
+<div id="toast" class="toast" role="status" aria-live="polite" data-visible="0"></div>
+
+<script src="/builders/shell.js?v=2026-07-02-shell1"></script>
+<!-- jump palette (Ctrl/Cmd-K). Optional by design: without it the shell's slot stays hidden. -->
+<script src="/builders/palette.js" defer></script>
+<script src="/builders/dom-utils.js?v=2026-06-16-board"></script>
+<script src="/builders/hall-kit.js"></script>
+<script src="/builders/board-room.js?v=2026-09-09-board-carve"></script>
+</body>
+</html>