@bongos/core 1.19.621 → 1.19.622

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.621",
-  "core_contract": "1.19.621",
-  "source_commit": "09c7ba3955b0789f34ce6265e17cfcf52de9f146",
+  "core_version": "1.19.622",
+  "core_contract": "1.19.622",
+  "source_commit": "d7fca718550089ea07dc0180b88bcf356c86e06f",
   "source_ref": "HEAD",
-  "built_at": "2026-09-09T06:59:03.131Z",
+  "built_at": "2026-09-09T07:05:49.899Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 464,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 2086,
+    "functional_verbatim": 2087,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2574,
-  "tree_sha256": "76d591f3c619056f89124f5d2abb9e8d1fc2745277375693f575438d155faf7e",
+  "file_count": 2575,
+  "tree_sha256": "b42f3efc74c1736882f7545a20d0ab217990c61535f00a1c38b916f8ee92f029",
   "files": [
     {
       "path": ".claude/skills/backlog-review/SKILL.md",
@@ -2757,7 +2757,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "37afa2a8a4f3e0d4b2689de8b45dfafa6c17569ff07575ff4b3d6b1b1393d683"
+      "sha256": "502e05437441903b3c3a5388f43bfc60e1c910005a6ac0ff7ff07e5d2199a3e1"
     },
     {
       "path": "docs/modules-contract.md",
@@ -5597,7 +5597,7 @@
     {
       "path": "modules/lifecycle/db-tasks.js",
       "mode": "0000644",
-      "sha256": "15c9efea1fb5a8187fe5bae756777ebeb1a214e47e0434d7a8adeb156bd1e093"
+      "sha256": "65558689ccfcea8f71b98cd51eaf1fb45d39267f7e6f6cf8fc35814da2752a34"
     },
     {
       "path": "modules/lifecycle/db-versions.js",
@@ -7662,12 +7662,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "cc6fce6807181651ec0ec230ad34473092623805b54a1ac9fbaa84e3092b3f34"
+      "sha256": "f56943090b50301c55cc7bb459c1d2b805aaaee4dc57953071c80268ea3bcac0"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "aa932c27317fc8f47d1939478cd55134c96eb1265357cc37de7765e98fe146fc"
+      "sha256": "0bf4bc86183612ce855831f54233cec5ff5f2f9cbf56925dcc63d28a50338636"
     },
     {
       "path": "public-docs/index.html",
@@ -8922,7 +8922,7 @@
     {
       "path": "scripts/gds/start.js",
       "mode": "0000644",
-      "sha256": "061a477c618ca76aba4f3abfb2d22ad89ceb0bee46bac65b139ad8ee2f30413a"
+      "sha256": "d0adb1267fc2d75482a37ba252ebffce15cdd32ef2af178579668776a8dfa3a4"
     },
     {
       "path": "scripts/gds/status.js",
@@ -9397,7 +9397,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "155f6fd854a43d20569e168af8238b3a082a03d74360d9e6248650ec453568a8"
+      "sha256": "aa73b7f2356cde88eb58d423517adc364cf6fb7e8c9fd5dc177ae4d73b83e3e2"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -10159,6 +10159,11 @@
       "mode": "0000644",
       "sha256": "1ab482fea7d56cccd811c760e21bf564c7952cd5c11d5831faa500b6c2eaa331"
     },
+    {
+      "path": "tests/cross_discipline_priority_direction.mjs",
+      "mode": "0000644",
+      "sha256": "d7e67ada5978b56e271439233c4c8cd7bcb2abfada593c4591dee4904a8a6233"
+    },
     {
       "path": "tests/currency_label.mjs",
       "mode": "0000644",

package/docs/module-api-changelog.md

@@ -1691,5 +1691,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.619 with no explicit bump. run 34321089991. (task 1002620)
   1.19.621 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.620 with no explicit bump. run 34321546662. (task 1002620)
+  1.19.622 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.621 with no explicit bump. run 34322091367. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/lifecycle/db-tasks.js

@@ -855,11 +855,22 @@ function taskTouchesProtectedPath(task) {
 // and rank them.
 //
 // Ranking key (most relevant first):
-//   1. priority DESC          — a P5 in another lane still beats a P1
+//   1. priority ASC, unset last — 1 is the MOST urgent. This is the DB's own
+//      convention: CHECK (priority BETWEEN 1 AND 5), and every version-progress
+//      view weights work as 6 - COALESCE(priority, 5), so a lower number earns
+//      more weight. It is the same order the SQL feeds use — `priority ASC
+//      NULLS LAST` in the optimizer, `priority NULLS LAST` in listTasks and the
+//      goal rollup. A task with no priority set ranks after an explicit P5,
+//      never ahead of a P1.
 //   2. credits-per-minute DESC — best bang-for-effort among equal priority
 //   3. est_minutes ASC         — shorter wins the tiebreak (easier to try)
 //   4. id ASC                  — stable final tiebreak
 //
+// scripts/gds/start.js keeps a hand-copied mirror of this function (it is a
+// pure HTTP client and cannot import this module). The two are a documented
+// mirror pair: tests/cross_discipline_priority_direction.mjs executes BOTH and
+// fails if either drifts. Change one, change the other.
+//
 // 'unclassified' tasks are excluded: they're un-triaged, not a real lane to
 // recommend exploring. If preferred_disciplines is empty (no preference), the
 // builder already sees everything in the main list, so there is nothing
@@ -876,13 +887,22 @@ function rankCrossDisciplineRecommendations(claimable, preferredDisciplines, lim
     const mins = Number(t.est_minutes_calibrated ?? t.est_minutes) || 0;
     return mins > 0 ? credits / mins : 0;
   };
+  // `ASC NULLS LAST` expressed in JS: an absent, blank or non-numeric priority
+  // sorts AFTER every explicit 1..5. Deliberately not `Number(t.priority) || 0`
+  // — that maps NULL to 0, which under an ascending sort is more urgent than a
+  // P1. Infinity is the only value that keeps unset work at the back.
+  const prio = (t) => {
+    if (t.priority === null || t.priority === undefined || t.priority === '') return Infinity;
+    const n = Number(t.priority);
+    return Number.isFinite(n) ? n : Infinity;
+  };
   const outside = rows.filter(
     (t) => t.discipline && t.discipline !== 'unclassified' && !prefSet.has(t.discipline)
   );
   outside.sort((a, b) => {
-    const pa = Number(a.priority) || 0;
-    const pb = Number(b.priority) || 0;
-    if (pb !== pa) return pb - pa; // higher priority first
+    const pa = prio(a);
+    const pb = prio(b);
+    if (pa !== pb) return pa - pb; // lower number = more urgent; unset last
     const ca = cpm(a);
     const cb = cpm(b);
     if (cb !== ca) return cb - ca; // higher credits/min first

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.621",
+  "version": "1.19.622",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.621",
+      "version": "1.19.622",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.621",
+  "version": "1.19.622",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/start.js

@@ -45,9 +45,9 @@
 //
 // Below the main list, a "You might enjoy" section surfaces up to 3 claimable
 // tasks OUTSIDE the builder's disciplines, ranked by relevance. The ranking
-// mirrors db.rankCrossDisciplineRecommendations (the canonical server-side
-// home for this logic — kept in sync deliberately; start.js is a pure HTTP
-// client and cannot import the server db module).
+// mirrors rankCrossDisciplineRecommendations in modules/lifecycle/db-tasks.js
+// (the canonical server-side home for this logic — kept in sync deliberately;
+// start.js is a pure HTTP client and cannot import the server db module).
 //
 //
 // Returns JSON if --json is passed (for the slash command to parse cleanly).
@@ -470,12 +470,19 @@ function renderWidget({ builder, claims, claimable, total, streak, recommendatio
 }
 
 // Cross-discipline recommendations — mirror of
-// db.rankCrossDisciplineRecommendations (src/bongos/db.js). Given the full
-// claimable list and the builder's preferred_disciplines, return up to `limit`
-// tasks whose discipline is OUTSIDE the builder's preferences, ranked:
-//   priority DESC, credits/min DESC, est_minutes ASC, id ASC.
+// rankCrossDisciplineRecommendations in modules/lifecycle/db-tasks.js (the
+// canonical copy; it moved there from src/bongos/db.js in the twelve-unit
+// carve). Given the full claimable list and the builder's
+// preferred_disciplines, return up to `limit` tasks whose discipline is OUTSIDE
+// the builder's preferences, ranked:
+//   priority ASC (unset last), credits/min DESC, est_minutes ASC, id ASC.
+// Priority 1 is the MOST urgent — the DB's own convention (CHECK (priority
+// BETWEEN 1 AND 5), weighted 6 - COALESCE(priority, 5)); an unset priority
+// sorts after an explicit P5, never ahead of a P1.
 // 'unclassified' tasks are excluded (un-triaged, not a real lane). Empty
 // preferences → [] (everything is already in the main list; nothing outside).
+// This copy and the canonical one are pinned together by
+// tests/cross_discipline_priority_direction.mjs — change one, change the other.
 function rankCrossDisciplineRecommendations(claimable, preferredDisciplines, limit = 3) {
   const rows = Array.isArray(claimable) ? claimable : [];
   const prefs = Array.isArray(preferredDisciplines) ? preferredDisciplines : [];
@@ -486,13 +493,21 @@ function rankCrossDisciplineRecommendations(claimable, preferredDisciplines, lim
     const mins = Number(t.est_minutes_calibrated ?? t.est_minutes) || 0;
     return mins > 0 ? credits / mins : 0;
   };
+  // `ASC NULLS LAST` in JS — an absent/blank/non-numeric priority sorts after
+  // every explicit 1..5. Not `Number(t.priority) || 0`: that maps NULL to 0,
+  // which under an ascending sort outranks a P1.
+  const prio = (t) => {
+    if (t.priority === null || t.priority === undefined || t.priority === '') return Infinity;
+    const n = Number(t.priority);
+    return Number.isFinite(n) ? n : Infinity;
+  };
   const outside = rows.filter(
     (t) => t.discipline && t.discipline !== 'unclassified' && !prefSet.has(t.discipline)
   );
   outside.sort((a, b) => {
-    const pa = Number(a.priority) || 0;
-    const pb = Number(b.priority) || 0;
-    if (pb !== pa) return pb - pa;
+    const pa = prio(a);
+    const pb = prio(b);
+    if (pa !== pb) return pa - pb;
     const ca = cpm(a);
     const cb = cpm(b);
     if (cb !== ca) return cb - ca;
@@ -973,7 +988,9 @@ async function main() {
 // Only auto-run when invoked directly (`node start.js …`); a `require()` (the
 // unit test) imports the pure render helpers without executing the fetch flow —
 // the claim.js precedent. The owed-rebase warning helpers (ADR 0120 part 5) are
-// exported so they can be unit-tested without a live server.
+// exported so they can be unit-tested without a live server, and so is
+// rankCrossDisciplineRecommendations — the mirror test executes THIS copy
+// alongside the canonical one rather than pattern-matching the source.
 if (require.main === module) {
   main().catch((err) => {
     console.error('fatal:', err);
@@ -982,6 +999,7 @@ if (require.main === module) {
 }
 
 module.exports = {
+  rankCrossDisciplineRecommendations,
   rebaseWarningModel,
   rebaseWarningMarkdown,
   rebaseWarningWidget,

package/src/module-api.js

@@ -55,7 +55,7 @@ const { buildInfo } = require('./build-info');
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.621'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.622'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/cross_discipline_priority_direction.mjs

@@ -0,0 +1,196 @@
+// tests/cross_discipline_priority_direction.mjs — priority sorts ONE way
+// (task 1003756).
+//
+// tasks.priority is 1..5 with 1 the MOST urgent. The DB says so in two places
+// that cannot drift (the CHECK constraint and the 6 - COALESCE(priority, 5)
+// weighting every version-progress view uses), and every SQL feed orders
+// `priority ASC NULLS LAST`. rankCrossDisciplineRecommendations used to sort
+// the other way and its header comment asserted the inverse as the global rule,
+// so re-ranking a task moved it the wrong direction in /builder-start's
+// "You might enjoy" section.
+//
+// The function has TWO hand-copied implementations — the canonical one in
+// modules/lifecycle/db-tasks.js and a mirror in scripts/gds/start.js, which is
+// a pure HTTP client and cannot import the server module. This test EXECUTES
+// both against the same fixtures and asserts they agree, so the pair cannot
+// drift apart again.
+//
+// Run:  node tests/cross_discipline_priority_direction.mjs
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { createRequire } from 'node:module';
+import { makeRunner } from './helpers.mjs';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const read = (rel) => fs.readFileSync(path.join(ROOT, rel), 'utf8');
+
+const CANONICAL = require(path.join(ROOT, 'modules/lifecycle/db-tasks.js'))
+  .rankCrossDisciplineRecommendations;
+const MIRROR = require(path.join(ROOT, 'scripts/gds/start.js'))
+  .rankCrossDisciplineRecommendations;
+
+// Both copies, run over the same input. Every behavioural assertion below goes
+// through this so a fix applied to only one file fails the suite.
+const IMPLS = [['db-tasks.js (canonical)', CANONICAL], ['start.js (mirror)', MIRROR]];
+const bothRank = (rows, prefs, limit) => IMPLS.map(([name, fn]) => [name, fn(rows, prefs, limit)]);
+const eachImpl = (rows, prefs, limit, check) => {
+  for (const [name, out] of bothRank(rows, prefs, limit)) check(out, name);
+};
+
+// A claimable row. discipline defaults OUTSIDE the caller's prefs (['engineer'])
+// so the partition step never eats the fixture; credits/minutes are equal by
+// default so priority is the only live sort key unless a test says otherwise.
+const row = (id, priority, extra = {}) => ({
+  id, priority, discipline: 'design', credits_reward: 10, est_minutes: 10, ...extra,
+});
+const PREFS = ['engineer'];
+const ids = (out) => out.map((t) => t.id);
+
+const { test, summary } = makeRunner();
+
+// ---- the direction itself ---------------------------------------------------
+
+await test('P1 outranks P5 — 1 is the most urgent, in BOTH copies', () => {
+  // Input deliberately in the wrong order so a no-op sort cannot pass.
+  const rows = [row('p5', 5), row('p3', 3), row('p1', 1)];
+  eachImpl(rows, PREFS, 10, (out, name) => {
+    assert.deepEqual(ids(out), ['p1', 'p3', 'p5'],
+      `${name}: ascending — the DB weights work 6 - COALESCE(priority, 5), so P1 earns the most`);
+  });
+});
+
+await test('the limit keeps the MOST urgent, not the least', () => {
+  const rows = [row('p5', 5), row('p4', 4), row('p1', 1), row('p2', 2)];
+  eachImpl(rows, PREFS, 2, (out, name) => {
+    assert.deepEqual(ids(out), ['p1', 'p2'],
+      `${name}: slicing after a backwards sort would surface the two LEAST urgent tasks`);
+  });
+});
+
+// ---- the NULL mapping -------------------------------------------------------
+// The old code read priority as `Number(t.priority) || 0`. Under the old DESC
+// sort that put unset work last by accident; under the corrected ASC sort the
+// same expression would rank it 0 — ahead of every P1. These pin the explicit
+// handling that replaced it.
+
+await test('an unset priority sorts LAST, not first (the || 0 trap)', () => {
+  for (const blank of [null, undefined, '']) {
+    const rows = [row('blank', blank), row('p1', 1), row('p5', 5)];
+    eachImpl(rows, PREFS, 10, (out, name) => {
+      assert.deepEqual(ids(out), ['p1', 'p5', 'blank'],
+        `${name}: priority=${JSON.stringify(blank)} must rank after an explicit P5`);
+    });
+  }
+});
+
+await test('a non-numeric priority is treated as unset, not as 0', () => {
+  const rows = [row('junk', 'urgent'), row('p5', 5)];
+  eachImpl(rows, PREFS, 10, (out, name) => {
+    assert.deepEqual(ids(out), ['p5', 'junk'], `${name}: NaN must not outrank a real priority`);
+  });
+});
+
+await test('a numeric string priority still sorts as its number', () => {
+  const rows = [row('five', '5'), row('one', '1')];
+  eachImpl(rows, PREFS, 10, (out, name) => {
+    assert.deepEqual(ids(out), ['one', 'five'], `${name}: the API can hand back stringified integers`);
+  });
+});
+
+// ---- the rest of the ranking key, so fixing direction did not disturb it ----
+
+await test('credits-per-minute DESC breaks a priority tie', () => {
+  const rows = [
+    row('cheap', 2, { credits_reward: 10, est_minutes: 100 }),
+    row('rich', 2, { credits_reward: 100, est_minutes: 10 }),
+  ];
+  eachImpl(rows, PREFS, 10, (out, name) => {
+    assert.deepEqual(ids(out), ['rich', 'cheap'], `${name}: best bang-for-effort first`);
+  });
+});
+
+await test('shorter est_minutes, then id, break the remaining ties', () => {
+  const rows = [
+    row('long', 2, { credits_reward: 10, est_minutes: 10 }),
+    row('short', 2, { credits_reward: 5, est_minutes: 5 }),
+  ];
+  // Equal credits/min (1.0), so est_minutes decides.
+  eachImpl(rows, PREFS, 10, (out, name) => {
+    assert.deepEqual(ids(out), ['short', 'long'], `${name}: shorter is easier to try`);
+  });
+  const tied = [row(9, 2), row(3, 2)];
+  eachImpl(tied, PREFS, 10, (out, name) => {
+    assert.deepEqual(ids(out), [3, 9], `${name}: id ASC is the stable final tiebreak`);
+  });
+});
+
+await test('partitioning is unchanged: outside-prefs only, no unclassified, empty prefs → []', () => {
+  const rows = [
+    row('mine', 1, { discipline: 'engineer' }),
+    row('untriaged', 1, { discipline: 'unclassified' }),
+    row('theirs', 4, { discipline: 'design' }),
+  ];
+  eachImpl(rows, PREFS, 10, (out, name) => {
+    assert.deepEqual(ids(out), ['theirs'], `${name}: only lanes outside the builder's prefs`);
+  });
+  eachImpl(rows, [], 10, (out, name) => {
+    assert.deepEqual(out, [], `${name}: no stated preference → nothing is "outside"`);
+  });
+});
+
+await test('the two copies agree row-for-row on a mixed corpus', () => {
+  const disciplines = ['design', 'ops', 'research', 'engineer', 'unclassified'];
+  const priorities = [1, 2, 3, 4, 5, null, undefined, '', '2', 'junk'];
+  const rows = [];
+  for (let i = 0; i < 60; i++) {
+    rows.push(row(i, priorities[i % priorities.length], {
+      discipline: disciplines[i % disciplines.length],
+      credits_reward: (i % 7) * 5,
+      est_minutes: (i % 4) * 15,
+    }));
+  }
+  const [[, fromCanonical], [, fromMirror]] = bothRank(rows, ['engineer'], 25);
+  assert.ok(fromCanonical.length > 5, 'fixture must actually exercise the ranking');
+  assert.deepEqual(ids(fromMirror), ids(fromCanonical),
+    'start.js is a hand-copied mirror — it must produce the identical order');
+});
+
+// ---- the convention this direction is anchored to ---------------------------
+// If someone ever inverts the DB's meaning of priority, these fail and force the
+// behavioural assertions above to be reconsidered rather than silently re-flipped.
+
+await test('the DB still says 1 is most urgent (CHECK + the 6 - COALESCE weighting)', () => {
+  const schema = read('migrations/003_pms.sql');
+  assert.match(schema, /priority\s+integer\s+CHECK \(priority BETWEEN 1 AND 5\)/,
+    'priority is a 1..5 integer');
+  assert.match(schema, /6 - COALESCE\(t\.priority, 5\)/,
+    'progress weighting subtracts from 6, so a LOWER priority number earns MORE weight');
+  assert.match(read('src/bongos/optimizer.js'), /priority ASC NULLS LAST/,
+    'the optimizer — the closest analogue to this recommender — orders ascending');
+});
+
+await test('neither copy claims priority DESC, and the mirror pointer resolves', () => {
+  const canonicalSrc = read('modules/lifecycle/db-tasks.js');
+  const mirrorSrc = read('scripts/gds/start.js');
+  for (const [name, src] of [['db-tasks.js', canonicalSrc], ['start.js', mirrorSrc]]) {
+    assert.ok(!/priority DESC/.test(src), `${name}: no comment may assert priority DESC`);
+  }
+  // The canonical home moved out of src/bongos/db.js in the twelve-unit carve;
+  // start.js pointed at the old address long after the function had left it.
+  assert.ok(
+    !/rankCrossDisciplineRecommendations \(src\/bongos\/db\.js\)/.test(mirrorSrc)
+      && !/db\.rankCrossDisciplineRecommendations/.test(mirrorSrc),
+    'start.js must name modules/lifecycle/db-tasks.js as the canonical home'
+  );
+  assert.match(mirrorSrc, /modules\/lifecycle\/db-tasks\.js/,
+    'the mirror names where the canonical copy actually lives');
+  assert.ok(
+    !/rankCrossDisciplineRecommendations/.test(read('src/bongos/db.js')),
+    'src/bongos/db.js really does not define it — the old pointer was dangling'
+  );
+});
+
+summary();