@bongos/core 1.19.600 → 1.19.602

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.600",
-  "core_contract": "1.19.600",
-  "source_commit": "8e02f02563986161d1b77b266027bab29d5534aa",
+  "core_version": "1.19.602",
+  "core_contract": "1.19.602",
+  "source_commit": "ca03701e78c9390c176c73f0dec2b563083b1e43",
   "source_ref": "HEAD",
-  "built_at": "2026-09-08T04:42:02.346Z",
+  "built_at": "2026-09-08T05:15:57.913Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 457,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 2075,
+    "functional_verbatim": 2077,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2556,
-  "tree_sha256": "a008ff8e9029ba8be4b741e6ce36012a90a005bad10e76f4fed030cee2404487",
+  "file_count": 2558,
+  "tree_sha256": "13e4a26b146d93eb6acf0b25727174b402c29e627a2a522f800f30be739dab2f",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -392,7 +392,7 @@
     {
       "path": "clients/bongos-client/index.d.ts",
       "mode": "0000644",
-      "sha256": "16af99cbe6df845f0f7a90f4569f77550635af0967dce552e2ef07a7b4ef0080"
+      "sha256": "877ca14cd017c1392fcc5206c2f3603fb24becdc32670aa1e2ad0de9d930dfca"
     },
     {
       "path": "clients/bongos-client/index.mjs",
@@ -1852,7 +1852,7 @@
     {
       "path": "docs/api/openapi.json",
       "mode": "0000644",
-      "sha256": "f2433a337aed6aa2f0f1a1c2d61b17103b493a028fa03c2944b92b5f3bb5e609"
+      "sha256": "81485c0440de636511dc9ee723e18af89f313b175ea626723d0beeeed31bba2f"
     },
     {
       "path": "docs/architecture.md",
@@ -2727,7 +2727,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "251ae2f82d65d325f220649d865bc5413a3febbf493db6994b6f3e9713968ac8"
+      "sha256": "bd7f11eca7a06de98c0f11aad60e8128cda215ac91d9bc108af94b54e9c7df91"
     },
     {
       "path": "docs/modules-contract.md",
@@ -5567,12 +5567,12 @@
     {
       "path": "modules/lifecycle/db-versions.js",
       "mode": "0000644",
-      "sha256": "53f87c20f89c33a3d14ee4410bafa0f3122fb7534708ce5bdacb8cc1098a487c"
+      "sha256": "2c10a17f86506788ab2f9db25c23024120ec9fddb3c7c4894e65d8354cd46869"
     },
     {
       "path": "modules/lifecycle/db.js",
       "mode": "0000644",
-      "sha256": "33fc8959d522bcf18c445b1a5710940379f84d1e938eecdc52cdf52bec9c4b3d"
+      "sha256": "b4b2d6d7890ec67e52fc00718a814bf01a64f4432ed7380a175dca8bc794b0e4"
     },
     {
       "path": "modules/lifecycle/dead-deps.js",
@@ -5817,7 +5817,7 @@
     {
       "path": "modules/lifecycle/routes/versions.js",
       "mode": "0000644",
-      "sha256": "35919f2cdd1e9a5da11a89adc9731818aa6b1b292c0754d9123a4cd8324bd970"
+      "sha256": "014de34389dbf26b4b089b677466c9c7cfd81f79b9e1714241be12f589086c0f"
     },
     {
       "path": "modules/lifecycle/routes/visuals.js",
@@ -7627,12 +7627,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "d3456f52cc8555eb1a20f884dc2d32240032138193c5d525ea455d07423e9656"
+      "sha256": "4f6f3fe27c26565c9b2b010a7970bfe1322e4d91d53d6bb8c4f5cfd592c8c7d3"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "107d899ff6ec92f0f2dd863f62ab2a68eaa82c7f60d9e172c243b9b5ff421f52"
+      "sha256": "43b5dfed26f44044bbb3730cd8dd0ac08f251e95a2c0942d440d1dd8c5ca5633"
     },
     {
       "path": "public-docs/index.html",
@@ -8932,7 +8932,7 @@
     {
       "path": "scripts/gds/version-close.js",
       "mode": "0000644",
-      "sha256": "32e0c1f2a955d4cabeae00d3749b283abd70f05f34b5fcbd84be3f35e2e655c8"
+      "sha256": "2db9a69b8a64873eee7cd473ce2915df51ccfffb79f289ec01e0419d2861ba3e"
     },
     {
       "path": "scripts/gds/version-literal-guard.js",
@@ -9347,7 +9347,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "fa5a67fefe06f235502a19ee017a75467ab1f5cadf77c2b004edd4109b397ece"
+      "sha256": "ecb3569e4061f1cb6cb82d9d88eeb00e0cf7eaf56796ee5c1bacba73ca6b2ef1"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -12704,6 +12704,11 @@
       "mode": "0000644",
       "sha256": "372c80d42e122a70a4fae8fcfbaaa47459575d3e0a2b80fff8876dfc512c5aeb"
     },
+    {
+      "path": "tests/version_close_cli.mjs",
+      "mode": "0000644",
+      "sha256": "7f7f4cc397bea0d319d5549b50aea178507dfeb2bdaf680fd42f4c80f56509ac"
+    },
     {
       "path": "tests/version_close_route.mjs",
       "mode": "0000644",
@@ -12719,6 +12724,11 @@
       "mode": "0000644",
       "sha256": "692261c26e3da46519757733a7fcf9a9998e0942bc5890688b66b79590d82c27"
     },
+    {
+      "path": "tests/version_promotion.mjs",
+      "mode": "0000644",
+      "sha256": "43ba25381f3d02d7ecaaa8a2639bb8f1f72587d6966e6498db1c887b289148eb"
+    },
     {
       "path": "tests/version_roll_forward.mjs",
       "mode": "0000644",

package/clients/bongos-client/index.d.ts

@@ -390,7 +390,7 @@ export interface PostTasksNewcomerRestockResponse { ok: boolean; stamped: unknow
 export interface PostTasksRequest { version_id: string; title: string; description?: string; status?: string; touches?: string[]; est_minutes?: number; est_cost_usd?: number; manual_degree?: number; priority?: number; automation_tag?: string; credits_reward?: number; source?: string; source_ref?: string; value_summary?: string; kind?: string; discipline?: string; parallel_safe?: unknown; newcomer_friendly?: boolean; security_sensitive?: boolean; requires_rank?: string; auto_detect_touches?: boolean; criterion_ids?: unknown[]; module_key?: string; goal_id?: number }
 export interface PostTasksResponse { task: unknown; needs_migration: unknown; criteria: unknown; idempotent: boolean }
 export interface PostVersionsIdCloseRequest { reason?: string; dispositions?: Record<string, unknown> }
-export interface PostVersionsIdCloseResponse { ok: boolean; version: unknown; applied: unknown }
+export interface PostVersionsIdCloseResponse { ok: boolean; version: unknown; applied: unknown; promoted: unknown; carried: unknown }
 export interface PostVersionsIdDoneWhenRequest { criterion_id: string; criterion_md: string; goal_id?: number; sort_order?: number }
 export interface PostVersionsIdDoneWhenResponse { ok: boolean; criterion: unknown }
 export interface PostVersionsRequest { id: string; name: string; status?: string; track?: string; done_when?: string; scope_doc_path?: string; criteria?: unknown[] }

package/docs/api/openapi.json

@@ -22494,12 +22494,16 @@
             "type": "boolean"
           },
           "version": {},
-          "applied": {}
+          "applied": {},
+          "promoted": {},
+          "carried": {}
         },
         "required": [
           "ok",
           "version",
-          "applied"
+          "applied",
+          "promoted",
+          "carried"
         ]
       },
       "PostVersionsIdDoneWhenRequest": {

package/docs/module-api-changelog.md

@@ -1649,5 +1649,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.598 with no explicit bump. run 34187136306. (task 1002620)
   1.19.600 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.599 with no explicit bump. run 34187881031. (task 1002620)
+  1.19.601 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.600 with no explicit bump. run 34188958832. (task 1002620)
+  1.19.602 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.601 with no explicit bump. run 34189930315. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/lifecycle/db-versions.js

@@ -245,14 +245,51 @@ async function openNonMaintenanceGoals(versionId, deps = {}) {
 //     must run INSIDE this transaction and BEFORE any carry-over, because
 //     `ensureMaintenanceGoal` returns null for a non-`building` version. The seam
 //     is `deps.onClosed` below rather than a later edit to this function.
-//   • It does not create successor goals. `roll_forward` here only ABSTAINS from
-//     cutting the goal; task 1003604 (R17) does the lineage write. Until it ships,
-//     a rolled-forward goal simply stays open on the closed version — visible and
-//     recoverable, which is the right failure while half the feature exists.
+//   • It DOES create successor goals now — task 1003604 (R17) shipped, so
+//     `roll_forward` writes the successor, moves the unfinished tasks and records
+//     `succeeded_by_goal_id`. This note used to say the opposite; it is kept,
+//     corrected, because a reader who met the old wording would otherwise go
+//     looking for the abstention it described.
 //   • It does not write `limitations/<version>-shipped.md`. That is a repo file; a
 //     route cannot write one, and file I/O has no business in this transaction.
 //
 // `plan` is planVersionClose's validated output: [{ goalId, verb }].
+// promotePlanningVersion — the single `planning` version becomes the live train
+// (BV1.R20, task 1003607, goal 1000086, ADR 0263 §8).
+//
+// WHY IT RUNS IN THE CLOSE'S TRANSACTION. A project with zero building versions
+// is a BROKEN state, not an intermediate one: `currentBuildingVersionId` returns
+// null there and every routing path closed over it fails, so nothing is
+// claimable. Promoting in a second transaction would leave exactly that window
+// open, however briefly.
+//
+// ZERO PLANNING VERSIONS IS NOT AN ERROR. The close succeeds and the project sits
+// with no live train until someone cuts one. Refusing the close instead would
+// trap a finished version open because nobody had scoped the next one yet — and
+// the close is the thing that makes scoping the next one worth doing.
+//
+// SELF-GUARDING IN SQL rather than by a read-then-write. The `NOT EXISTS`
+// sub-select is what keeps this from creating the second building version R19
+// forbids: it is evaluated inside the same statement, so a concurrent close
+// cannot slip a promotion past a check that has already run. `ORDER BY id LIMIT 1`
+// makes the pick deterministic; R04 guarantees there is at most one to pick.
+//
+// `started_at` is stamped only if it was never set — a version's start is when it
+// began building, and a re-promotion (which cannot happen, but the COALESCE costs
+// nothing) must not rewrite history.
+//
+// Returns the promoted row, or null when there was nothing to promote.
+async function promotePlanningVersion(exec) {
+  const { rows } = await exec.query(
+    `UPDATE versions
+        SET status = 'building', started_at = COALESCE(started_at, now())
+      WHERE id = (SELECT id FROM versions WHERE status = 'planning' ORDER BY id LIMIT 1)
+        AND NOT EXISTS (SELECT 1 FROM versions WHERE status = 'building')
+      RETURNING id, name, track, status, started_at`
+  );
+  return rows[0] ?? null;
+}
+
 async function closeVersion({ versionId, plan = [], reason, planningVersionId = null }, deps = {}) {
   const activePool = (deps.pool && process.env.NODE_ENV === 'test') ? deps.pool : pool;
   const client = await activePool.connect();
@@ -437,6 +474,7 @@ async function closeVersion({ versionId, plan = [], reason, planningVersionId =
 
 module.exports = {
   closeVersion,
+  promotePlanningVersion,
   createVersion,
   maintenanceGoalExemptSql,
   openNonMaintenanceGoals,

package/modules/lifecycle/db.js

@@ -63,7 +63,7 @@ const {
   singleRungPromotionError,
   xenosClaimAllowed,
 } = require('./db-rank-authz.js');
-const { closeVersion, createVersion, currentBuildingVersionId, getVersion, listVersions, maintenanceGoalExemptSql, openNonMaintenanceGoals, versionProgress, versionsWithStatus } = require('./db-versions.js');
+const { closeVersion, promotePlanningVersion, createVersion, currentBuildingVersionId, getVersion, listVersions, maintenanceGoalExemptSql, openNonMaintenanceGoals, versionProgress, versionsWithStatus } = require('./db-versions.js');
 const {
   acceptMembershipRequestAndAddMember,
   achieveGoalIfComplete,
@@ -222,6 +222,7 @@ module.exports = {
   openNonMaintenanceGoals,
   versionsWithStatus,
   closeVersion,
+  promotePlanningVersion,
   createVersion,
   currentBuildingVersionId,
   createGoal,

package/modules/lifecycle/routes/versions.js

@@ -287,12 +287,53 @@ module.exports = function buildVersionsRouter() {
     try {
       const out = await db.closeVersion({
         versionId, plan: plan.plan, reason,
+        // BV1.R20 (task 1003607, ADR 0263 §8): the close's last act, inside its
+        // own transaction. A project with zero building versions is a BROKEN
+        // state — `currentBuildingVersionId` returns null and nothing is
+        // claimable — so promoting in a second transaction would leave exactly
+        // that window open.
+        //
+        // ORDER IS LOAD-BEARING: promote, THEN carry the bugs forward.
+        // `ensureMaintenanceGoal` returns null for a version that is not yet
+        // `building`, so a carry-over run first silently carries nothing and the
+        // defect queue stays entombed on the version that just shipped.
+        //
+        // COMPOSED HERE rather than inside closeVersion because the two halves
+        // live in different db units (versions and goals, siblings in the
+        // module's require DAG) and the route is the one place already holding
+        // the whole facade — reaching sideways between the units is how that DAG
+        // stops being one.
+        //
+        // Zero planning versions is NOT an error: the close succeeds and the
+        // project sits idle until someone cuts the next version.
         // R04 guarantees at most one planning version, so [0] is THE successor
         // rather than a pick. Null when nothing rolls forward, which is the
         // common close.
         planningVersionId: planning[0]?.id ?? null,
+      }, {
+        // NOTE THE SECOND ARGUMENT. `closeVersion` reads this hook from `deps`,
+        // not from its options object — putting it in the first one is silently
+        // ignored, the hook never runs, and the close still returns 200 having
+        // promoted nothing. Caught here by running the real close against a real
+        // Postgres; no fake would have noticed.
+        onClosed: async (client, { versionId: closedId }) => {
+          const promoted = await db.promotePlanningVersion(client);
+          const carried = promoted
+            ? await db.carryBugsForward({ fromVersionId: closedId, toVersionId: promoted.id }, { client })
+            : null;
+          return { promoted, carried };
+        },
+      });
+      // `promoted` and `carried` ride the response because a close now changes
+      // WHICH version is live, and a caller that has to go and re-read
+      // /versions to discover that has been told half the outcome. `promoted:
+      // null` is the honest answer for a project with nothing scoped next, not
+      // an omission.
+      return res.json({
+        ok: true, version: out.version, applied: out.applied,
+        promoted: out.after?.promoted ?? null,
+        carried: out.after?.carried ?? null,
       });
-      return res.json({ ok: true, version: out.version, applied: out.applied });
     } catch (err) {
       if (err && err.code === 'VERSION_NOT_FOUND') return res.fail('version_not_found', 404);
       if (err && err.code === 'VERSION_NOT_BUILDING') {

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.600",
+  "version": "1.19.602",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.600",
+      "version": "1.19.602",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.600",
+  "version": "1.19.602",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/version-close.js

@@ -11,12 +11,15 @@
 //   3. Identifies carry-over candidates (backlog + ready) and drafts a
 //      next-version scope stub (e.g. limitations/pms-v3.md) with a
 //      "## Carried Over from <VID>" section.
-//   4. Prints the SQL needed to (a) flip the closing version to 'shipped',
-//      (b) insert the next-version row with status='building', and
-//      (c) rebind carry-over task version_id values. The GDS API does not
-//      yet expose endpoints for these operations; per task #43 spec this
-//      ships with explicit "MANUAL STEP REQUIRED" output rather than
-//      extending routes.js (out of touches[]).
+//   4. CLOSES the version through POST /versions/:id/close (BV1.R23, task
+//      1003610). This step used to print a "MANUAL STEP REQUIRED" block of SQL
+//      to paste into psql on the droplet, because at the time the API genuinely
+//      exposed no version status transition. BV1.R12 (task 1003599) built the
+//      route, so that text became false — and by then the SQL was actively
+//      harmful, since it bypasses the disposition two-step, the closure
+//      invariant, the successor lineage, the promotion and the bug carry-forward.
+//      Closing a version by hand now silently strands everything the route
+//      carries.
 //   5. Prints a suggested git commit message.
 //
 // Every destructive write (file create, INSERT, UPDATE) prompts y/N first.
@@ -38,7 +41,7 @@ const REPO_ROOT = path.resolve(__dirname, '..', '..');
 // -------------------------------------------------------------------------
 
 function parseArgs(argv) {
-  const out = { versionId: null, yes: false, nextId: null, noNextStub: false };
+  const out = { versionId: null, yes: false, nextId: null, noNextStub: false, reason: null, dispositions: {} };
   for (let i = 2; i < argv.length; i++) {
     const a = argv[i];
     if (a === '--yes' || a === '-y') {
@@ -49,6 +52,16 @@ function parseArgs(argv) {
       out.nextId = argv[++i];
     } else if (a.startsWith('--next=')) {
       out.nextId = a.slice('--next='.length);
+    } else if (a === '--reason') {
+      out.reason = argv[++i];
+    } else if (a.startsWith('--reason=')) {
+      out.reason = a.slice('--reason='.length);
+    } else if (a === '--disposition' || a.startsWith('--disposition=')) {
+      // `<goalId>=<verb>`, repeatable. Parsed into the exact map shape
+      // POST /versions/:id/close expects, so the operator never hand-writes JSON.
+      const raw = a.startsWith('--disposition=') ? a.slice('--disposition='.length) : argv[++i];
+      const eq = String(raw || '').indexOf('=');
+      if (eq > 0) out.dispositions[raw.slice(0, eq)] = { verb: raw.slice(eq + 1) };
     } else if (a === '-h' || a === '--help') {
       out.help = true;
     } else if (!out.versionId && !a.startsWith('-')) {
@@ -62,8 +75,15 @@ function usage() {
   return [
     'Usage: node scripts/gds/version-close.js <VERSION_ID> [--yes|-y] [--next <ID>] [--no-next-stub]',
     '',
-    'Drafts <scope>-shipped.md + next-version stub, prints SQL for the',
-    'destructive parts. Always interactive without --yes.',
+    'Drafts <scope>-shipped.md + next-version stub, then CLOSES the version',
+    'through POST /versions/:id/close. Always interactive without --yes.',
+    '',
+    '  --reason <text>            recorded on the close; stamped on any task a',
+    '                             disposition abandons. Required by the route',
+    '                             whenever a goal is dispositioned.',
+    '  --disposition <id>=<verb>  roll_forward | abandon, repeatable — one per',
+    '                             open goal. Without them the close REFUSES and',
+    '                             lists the goals, so nothing is cut by omission.',
     '',
     '  --no-next-stub  Skip drafting the next-version scope stub entirely',
     '                  (enforces the guided-review-pass memory rule). The',
@@ -74,6 +94,8 @@ function usage() {
     '  node scripts/gds/version-close.js PMS-V2 --next GDS-V3',
     '  node scripts/gds/version-close.js PMS-V2 --yes',
     '  node scripts/gds/version-close.js PMS-V2 --no-next-stub',
+    '  node scripts/gds/version-close.js PMS-V2 --disposition 44=roll_forward \\',
+    '         --disposition 51=abandon --reason "V2 is done; 51 is not coming back"',
   ].join('\n');
 }
 
@@ -277,74 +299,66 @@ function buildNextVersionStub({ nextVersionId, prevVersionId, carryOverTasks })
 }
 
 // -------------------------------------------------------------------------
-// SQL builders (no API endpoints exist for these — print as manual steps)
+// The close itself — a ROUTE call, not printed SQL (BV1.R23, task 1003610)
 // -------------------------------------------------------------------------
+//
+// THIS FILE USED TO PRINT A `-- MANUAL STEP REQUIRED` BLOCK and tell the operator
+// to run three UPDATEs on the production droplet, on the entirely true grounds
+// that "the GDS API does not currently expose endpoints for version status
+// transitions". BV1.R12 (task 1003599) built `POST /versions/:id/close`, so that
+// sentence became false — and a script that keeps printing it is worse than one
+// that never offered anything, because the SQL path BYPASSES every rule this goal
+// exists to enforce: the disposition two-step (R12/R14), the closure invariant
+// (R08/R09), the successor lineage (R17), the promotion (R20) and the bug
+// carry-forward (R18). An operator pasting that SQL would close a version and
+// silently strand everything the route would have carried.
+//
+// The advisory half of this script — `suggestClose`, the shipped archive, the
+// next-version scope stub — is unchanged and still the reason to run it.
 
-function sqlEscape(s) {
-  return String(s).replace(/'/g, "''");
+async function closeVersionViaApi({ versionId, reason, dispositions }) {
+  const api = await cliClient();
+  const body = { reason };
+  if (dispositions && Object.keys(dispositions).length > 0) body.dispositions = dispositions;
+  const { ok, status, data } = await api.versions.postVersionsIdClose({ path: { id: versionId }, body });
+  return { ok, status, data };
 }
 
-function buildManualSql({ versionId, versionName, nextVersionId, nextScopeDocPath, carryOverTasks, nextVersionExists }) {
+// The route answers the R12 two-step: called with open goals and no disposition
+// it REFUSES and returns them, so the operator can decide per goal rather than
+// being told only that something is in the way. Rendered here rather than dumped
+// as JSON because the next thing the operator types is the re-run.
+function renderOpenGoalsRefusal(versionId, details) {
+  const goals = (details && details.goals) || [];
   const lines = [
-    '-- MANUAL STEP REQUIRED -----------------------------------------------',
-    '-- The GDS API does not currently expose endpoints for: version status',
-    '-- transitions, version creation from CLI, or task version_id rebinding.',
-    '-- Run the SQL below on the production droplet (psql amazonprimea).',
-    '-- ---------------------------------------------------------------------',
-    'BEGIN;',
+    `[refused] ${versionId} still holds ${goals.length} open goal(s). Nothing was changed.`,
     '',
-    `-- 1. Close ${versionId}.`,
-    `UPDATE versions`,
-    `   SET status = 'shipped'`,
-    `     , shipped_at = now()`,
-    ` WHERE id = '${sqlEscape(versionId)}'`,
-    `   AND status = 'building';`,
+    'Decide what happens to each, then re-run with --disposition:',
     '',
   ];
-
-  if (nextVersionExists) {
-    lines.push(`-- 2. ${nextVersionId} already exists in the versions table — no INSERT needed.`);
-    lines.push('');
-  } else {
-    lines.push(`-- 2. Insert ${nextVersionId} stub with status='building'.`);
-    lines.push(`INSERT INTO versions (id, name, track, status, scope_doc_path, started_at)`);
-    lines.push(`VALUES ('${sqlEscape(nextVersionId)}',`);
-    lines.push(`        '${sqlEscape(nextVersionId)}',`);
-    lines.push(`        (SELECT track FROM versions WHERE id = '${sqlEscape(versionId)}'),`);
-    lines.push(`        'building',`);
-    lines.push(`        '${sqlEscape(nextScopeDocPath)}',`);
-    lines.push(`        now())`);
-    lines.push(`ON CONFLICT (id) DO NOTHING;`);
-    lines.push('');
+  for (const g of goals) {
+    const open = g.open_tasks ? ` (${g.open_tasks} unfinished task${g.open_tasks === 1 ? '' : 's'})` : '';
+    lines.push(`  #${g.id}  ${g.title || ''}${open}`);
   }
-
-  if (carryOverTasks.length > 0) {
-    const ids = carryOverTasks.map((t) => t.id).join(', ');
-    lines.push(`-- 3. Rebind ${carryOverTasks.length} carry-over task(s) to ${nextVersionId}.`);
-    lines.push(`UPDATE tasks`);
-    lines.push(`   SET version_id = '${sqlEscape(nextVersionId)}'`);
-    lines.push(`     , updated_at = now()`);
-    lines.push(` WHERE id IN (${ids})`);
-    lines.push(`   AND version_id = '${sqlEscape(versionId)}'`);
-    lines.push(`   AND status IN ('backlog', 'ready');`);
-    lines.push('');
-  } else {
-    lines.push(`-- 3. No carry-over tasks — skip rebind step.`);
-    lines.push('');
-  }
-
-  lines.push('COMMIT;');
-  lines.push('-- ---------------------------------------------------------------------');
+  lines.push('');
+  lines.push('  --disposition <goalId>=roll_forward   carry it into the planning version');
+  lines.push('  --disposition <goalId>=abandon        cut it, stamping the close reason on its tasks');
+  lines.push('');
+  lines.push(`  e.g. node scripts/gds/version-close.js ${versionId} \\`);
+  const example = goals.slice(0, 2).map((g) => `--disposition ${g.id}=roll_forward`).join(' ');
+  lines.push(`         ${example || '--disposition <goalId>=roll_forward'} --reason "…"`);
   return lines.join('\n');
 }
 
+
 function buildCommitMessage({ versionId, nextVersionId, shippedCount, carryCount }) {
   const subject = `pms: close ${versionId}, open ${nextVersionId}`;
   const body = [
     '',
     `- Archive ${versionId} scope to <scope>-shipped.md (${shippedCount} shipped task(s)).`,
     `- Open ${nextVersionId} scope stub${carryCount ? ` with ${carryCount} carry-over task(s)` : ' (clean close)'}.`,
-    '- Run the printed SQL on the droplet to flip version status + rebind tasks.',
+    '- Version status, task rebinding and the successor promotion were done by',
+    '  POST /versions/:id/close (BV1.R23) — this commit is the drafted docs only.',
   ].join('\n');
   return `${subject}\n${body}\n`;
 }
@@ -500,34 +514,85 @@ async function main() {
     } else {
       await writeFileWithConfirm(prompter, nextScopeDocPath, nextStubMd, `${nextVersionId} scope stub`);
     }
+
+    // Step 8 runs INSIDE this try so the prompter is still open for its confirm
+    // and is closed on every exit — including the refusal paths, which return
+    // early. A leaked readline keeps the process alive forever, which on a CLI
+    // reads as a hang rather than a failure.
+    return await closeStep();
   } finally {
     prompter.close();
   }
 
-  // Step 8: print manual SQL + commit message.
-  const sql = buildManualSql({
-    versionId,
-    versionName: target.name,
-    nextVersionId,
-    nextScopeDocPath: nextScopeDocRel,
-    carryOverTasks: carryOver,
-    nextVersionExists,
-  });
+  // Step 8: CLOSE THE VERSION THROUGH THE ROUTE (BV1.R23, task 1003610).
+  //
+  // Everything above this point is advisory — it drafts documents and reports the
+  // gate. This is the one destructive act, and it now goes through
+  // `POST /versions/:id/close` so it obeys the disposition two-step, the closure
+  // invariant, the successor lineage, the promotion and the bug carry-forward.
+  // The `--yes` flag the drafting steps honour gates it too: without it the
+  // operator is asked, because closing a version cannot be undone through the API.
+  async function closeStep() {
   console.log('');
-  console.log(sql);
+  if (!args.yes) {
+    const go = await prompter.ask(`Close ${versionId} now via POST /versions/${versionId}/close?`);
+    if (!go) {
+      console.log(`[skip] ${versionId} left building. Re-run with --yes, or close it from the hall.`);
+      printCommit();
+      return;
+    }
+  }
 
-  const commit = buildCommitMessage({
-    versionId,
-    nextVersionId,
-    shippedCount: shipped.length,
-    carryCount: carryOver.length,
-  });
-  console.log('');
-  console.log('--- suggested git commit message ---');
-  console.log(commit);
-  console.log('--- end commit message ---');
+  const closeReason = args.reason || `Closing ${versionId} (${shipped.length} shipped, ${carryOver.length} carry-over).`;
+  const res = await closeVersionViaApi({ versionId, reason: closeReason, dispositions: args.dispositions });
+
+  if (!res.ok) {
+    const err = (res.data && res.data.error) || `http_${res.status}`;
+    if (err === 'version_holds_open_goals' || err === 'disposition_incomplete') {
+      console.log(renderOpenGoalsRefusal(versionId, res.data && res.data.details));
+      process.exitCode = 1;
+      return;
+    }
+    // Every other refusal is already NAMED by the route (ADR 0250 §7), so the
+    // honest thing is to relay it rather than re-word it into something the
+    // operator cannot search for.
+    console.log(`[refused] ${err}: ${(res.data && res.data.message) || ''}`);
+    process.exitCode = 1;
+    return;
+  }
+
+  console.log(`[closed] ${versionId} → ${res.data.version.status}`);
+  for (const a of (res.data.applied || [])) {
+    const extra = a.successor_goal_id ? ` → successor goal #${a.successor_goal_id} (${a.tasks_moved} task(s) moved)`
+      : (a.tasks_abandoned != null ? ` (${a.tasks_abandoned} task(s) abandoned)` : '');
+    console.log(`         goal #${a.goal_id}: ${a.verb} — ${a.result}${extra}`);
+  }
+  if (res.data.promoted) {
+    console.log(`[promoted] ${res.data.promoted.id} is now building.`);
+    if (res.data.carried && res.data.carried.moved) {
+      console.log(`[carried]  ${res.data.carried.moved} open defect(s) moved to its maintenance goal.`);
+    }
+  } else {
+    console.log('[note] no version was in planning — the project has no live train until one is cut.');
+  }
+
+  printCommit();
   console.log('');
-  console.log(`[done] ${versionId} close drafted. Run the SQL above on the droplet to finalize.`);
+  console.log(`[done] ${versionId} closed. Commit the drafted docs with the message above.`);
+  }
+
+  function printCommit() {
+    const commit = buildCommitMessage({
+      versionId,
+      nextVersionId,
+      shippedCount: shipped.length,
+      carryCount: carryOver.length,
+    });
+    console.log('');
+    console.log('--- suggested git commit message ---');
+    console.log(commit);
+    console.log('--- end commit message ---');
+  }
 }
 
 if (require.main === module) {
@@ -539,11 +604,11 @@ if (require.main === module) {
 
 module.exports = {
   parseArgs,
+  usage,
   deriveNextVersionId,
   deriveNextScopePath,
   deriveShippedPath,
   buildShippedArchive,
   buildNextVersionStub,
-  buildManualSql,
   buildCommitMessage,
 };

package/src/module-api.js

@@ -55,7 +55,7 @@ const { buildInfo } = require('./build-info');
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.600'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.602'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/version_close_cli.mjs

@@ -0,0 +1,164 @@
+// tests/version_close_cli.mjs — version-close.js drives the ROUTE, and no longer
+// prints SQL for a human to paste into the production droplet
+// (BV1.R23, task 1003610, goal 1000086).
+//
+// WHAT THIS SCRIPT USED TO DO, AND WHY IT WAS RIGHT AT THE TIME. It ended with a
+// `-- MANUAL STEP REQUIRED` block: three UPDATEs to flip the version, insert the
+// successor and rebind carry-over tasks, with the instruction to run them on the
+// droplet. Its own header explained why — "the GDS API does not currently expose
+// endpoints for version status transitions" — and that was simply true.
+//
+// WHY IT IS NOW THE MOST DANGEROUS THING IN THE FILE. BV1.R12 (task 1003599)
+// built `POST /versions/:id/close`, so the claim became false. Worse, by then the
+// route had accumulated everything this goal exists to enforce: the disposition
+// two-step (R12/R14), the closure invariant (R08/R09), the successor lineage
+// (R17), the promotion (R20) and the bug carry-forward (R18). An operator pasting
+// that SQL would close a version and silently strand every one of them — a goal
+// left open on a shipped version, a defect queue entombed where nothing routes,
+// no successor promoted. The bypass was printed by the tool meant to prevent it.
+//
+// Run:  node --test tests/version_close_cli.mjs
+
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { readFileSync } from 'node:fs';
+import { createRequire } from 'node:module';
+
+process.env.NODE_ENV = 'test';
+const require = createRequire(import.meta.url);
+const { parseArgs, usage } = require('../scripts/gds/version-close.js');
+
+const SRC = readFileSync(new URL('../scripts/gds/version-close.js', import.meta.url), 'utf8');
+// Comments explain the history on purpose, so the prohibitions below read CODE.
+const CODE = SRC.replace(/\/\/[^\n]*/g, '').replace(/\/\*[\s\S]*?\*\//g, '');
+
+// ---------------------------------------------------------------------------
+// The bypass is gone
+// ---------------------------------------------------------------------------
+
+test('the script no longer BUILDS any version-mutating SQL', () => {
+  assert.equal(/buildManualSql/.test(CODE), false, 'the SQL builder must be deleted, not merely unused');
+  for (const bad of [/UPDATE\s+versions/i, /INSERT INTO versions/i, /UPDATE\s+tasks/i]) {
+    assert.equal(bad.test(CODE), false, `the script must not emit ${bad} — that is the path around every rule this goal built`);
+  }
+});
+
+test('it does not tell the operator to run anything on the droplet', () => {
+  assert.equal(/MANUAL STEP REQUIRED/.test(CODE), false);
+  assert.equal(/psql/i.test(CODE), false);
+  assert.equal(/droplet/i.test(CODE), false);
+});
+
+test('the commit message no longer promises SQL that will not be run', () => {
+  // It said "Run the printed SQL on the droplet to flip version status" — a
+  // commit body describing a step that no longer exists is a instruction someone
+  // eventually follows.
+  assert.equal(/Run the printed SQL/.test(CODE), false);
+  assert.match(SRC, /this commit is the drafted docs only/);
+});
+
+// ---------------------------------------------------------------------------
+// It calls the route
+// ---------------------------------------------------------------------------
+
+test('the close goes through POST /versions/:id/close', () => {
+  assert.match(CODE, /postVersionsIdClose\(\{ path: \{ id: versionId \}, body \}\)/);
+});
+
+test('a disposition map is only sent when there is one', () => {
+  // The route treats an EMPTY map as "the caller dispositioned nothing", which is
+  // a different call from "the caller sent no map at all" — the first can satisfy
+  // a close of a version holding no open goals, the second is the two-step's
+  // first leg. Sending `{}` unconditionally would blur them.
+  assert.match(CODE, /if \(dispositions && Object\.keys\(dispositions\)\.length > 0\) body\.dispositions = dispositions;/);
+});
+
+test('the advisory half is kept — this is still the script that drafts the archive', () => {
+  // The brief is explicit that suggestClose stays. Only the destructive tail moved.
+  assert.match(CODE, /fetchCloseSuggestions/);
+  assert.match(CODE, /buildShippedArchive|shippedDocPath/);
+});
+
+// ---------------------------------------------------------------------------
+// The two-step, rendered for a human
+// ---------------------------------------------------------------------------
+
+test('an open-goals refusal lists the goals and the exact re-run', () => {
+  // R12 refuses and RETURNS the goals precisely so the caller can decide per
+  // goal. Dumping that JSON would make the operator translate it themselves.
+  assert.match(CODE, /renderOpenGoalsRefusal/);
+  assert.match(SRC, /--disposition <goalId>=roll_forward/);
+  assert.match(SRC, /--disposition <goalId>=abandon/);
+});
+
+test('both incomplete-disposition refusals are handled, not just one', () => {
+  // The route answers `version_holds_open_goals` when nothing was sent and
+  // `disposition_incomplete` when a partial map was. Handling only the first
+  // leaves the commoner second attempt printing a bare error code.
+  assert.match(CODE, /version_holds_open_goals/);
+  assert.match(CODE, /disposition_incomplete/);
+});
+
+test('any other refusal is RELAYED by name, not re-worded', () => {
+  // ADR 0250 §7: the codes are named so an agent can act on them. Re-phrasing one
+  // into prose makes it unsearchable.
+  assert.match(CODE, /\[refused\] \$\{err\}/);
+});
+
+test('a refusal exits non-zero', () => {
+  assert.match(CODE, /process\.exitCode = 1;/);
+});
+
+// ---------------------------------------------------------------------------
+// The flags
+// ---------------------------------------------------------------------------
+
+test('--disposition parses into the exact map shape the route expects', () => {
+  const a = parseArgs(['node', 'x', 'BONGOS-V1', '--disposition', '44=roll_forward', '--disposition=51=abandon']);
+  assert.deepEqual(a.dispositions, { 44: { verb: 'roll_forward' }, 51: { verb: 'abandon' } },
+    'so the operator never hand-writes JSON');
+  assert.equal(a.versionId, 'BONGOS-V1');
+});
+
+test('--reason survives both spellings', () => {
+  assert.equal(parseArgs(['n', 'x', 'V', '--reason', 'because']).reason, 'because');
+  assert.equal(parseArgs(['n', 'x', 'V', '--reason=because']).reason, 'because');
+});
+
+test('a malformed --disposition is dropped rather than sent as nonsense', () => {
+  // `--disposition 44` with no verb would otherwise reach the route as
+  // {44: {verb: undefined}} and come back a bad_disposition the operator has to
+  // decode. Dropping it means the close refuses with the goal still listed.
+  const a = parseArgs(['n', 'x', 'V', '--disposition', '44', '--disposition', '=abandon']);
+  assert.deepEqual(a.dispositions, {});
+});
+
+test('no flags means no dispositions — nothing is cut by omission', () => {
+  assert.deepEqual(parseArgs(['n', 'x', 'V']).dispositions, {});
+  assert.equal(parseArgs(['n', 'x', 'V']).reason, null);
+});
+
+test('usage documents both new flags', () => {
+  const u = usage();
+  assert.match(u, /--reason/);
+  assert.match(u, /--disposition/);
+  assert.match(u, /POST \/versions\/:id\/close/);
+  assert.equal(/SQL/.test(u), false, 'the usage must not still advertise printed SQL');
+});
+
+// ---------------------------------------------------------------------------
+// The close is still a confirmed, destructive act
+// ---------------------------------------------------------------------------
+
+test('without --yes the operator is asked before the version closes', () => {
+  // Closing cannot be undone through the API (ADR 0263 §2: nothing un-closes a
+  // version), so this is the one prompt that must not be dropped.
+  assert.match(CODE, /if \(!args\.yes\) \{[\s\S]{0,200}prompter\.ask\(`Close \$\{versionId\}/);
+});
+
+test('the prompter is closed on every exit, including the refusal returns', () => {
+  // Step 8 returns early on a refusal. A leaked readline keeps the process alive,
+  // which on a CLI reads as a hang rather than a failure — so the close step runs
+  // inside the same try whose finally closes it.
+  assert.match(CODE, /return await closeStep\(\);\s*\}\s*finally \{\s*prompter\.close\(\);/);
+});

package/tests/version_promotion.mjs

@@ -0,0 +1,143 @@
+// tests/version_promotion.mjs — the planning version promotes itself when the
+// building version closes (BV1.R20, task 1003607, goal 1000086, ADR 0263 §8).
+//
+// WHY IT RUNS INSIDE THE CLOSE'S TRANSACTION. A project with zero building
+// versions is a BROKEN state, not an intermediate one: `currentBuildingVersionId`
+// returns null there and every routing path closed over it fails, so nothing is
+// claimable. Promoting in a second transaction leaves exactly that window open,
+// however briefly.
+//
+// AND WHY THE ORDER IS LOAD-BEARING. Promote, THEN carry the bugs forward.
+// `ensureMaintenanceGoal` returns null for a version that is not yet `building`,
+// so a carry-over run first silently carries nothing and the defect queue stays
+// entombed on the version that just shipped — the 1000771 shape, arriving through
+// the close instead of through routing.
+//
+// ONE MORE THING THIS FILE PINS, because it is the bug that actually happened
+// while building R20: `closeVersion` reads the hook from its SECOND argument
+// (`deps`), not from its options object. Passing `onClosed` in the first one is
+// silently ignored — the hook never runs, nothing is promoted, and the close
+// still answers 200. No fake caught it; running the real close against a real
+// Postgres did.
+//
+// Run:  node --test tests/version_promotion.mjs
+
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { readFileSync } from 'node:fs';
+import { createRequire } from 'node:module';
+import { makeSqlAwareClient } from './helpers.mjs';
+
+process.env.NODE_ENV = 'test';
+const require = createRequire(import.meta.url);
+const { promotePlanningVersion } = require('../modules/lifecycle/db-versions.js');
+
+const src = (rel) => readFileSync(new URL('../' + rel, import.meta.url), 'utf8');
+const ROUTES = src('modules/lifecycle/routes/versions.js');
+const DBV = src('modules/lifecycle/db-versions.js');
+
+const recorder = (handler) => {
+  const seen = [];
+  const c = makeSqlAwareClient((sql, params) => { seen.push({ sql: String(sql).replace(/\s+/g, ' '), params }); return handler(sql, params); });
+  return { seen, exec: { query: (sql, params) => c._client.query(sql, params) } };
+};
+
+// ---------------------------------------------------------------------------
+// The promotion itself
+// ---------------------------------------------------------------------------
+
+test('promotion is ONE self-guarding statement, not a read-then-write', async () => {
+  // A read-then-write leaves a window in which a concurrent close promotes too,
+  // producing the second building version R19 forbids. The NOT EXISTS is
+  // evaluated inside the same statement, so it cannot be raced past.
+  const r = recorder(() => ({ rows: [] }));
+  await promotePlanningVersion(r.exec);
+  assert.equal(r.seen.length, 1, 'one statement — a separate check could be raced');
+  const sql = r.seen[0].sql;
+  assert.match(sql, /UPDATE versions SET status = 'building'/);
+  assert.match(sql, /WHERE status = 'planning' ORDER BY id LIMIT 1/);
+  assert.match(sql, /NOT EXISTS \(SELECT 1 FROM versions WHERE status = 'building'\)/,
+    'the guard against creating a second building version must be in the statement');
+});
+
+test('started_at is stamped only if it was never set', async () => {
+  const r = recorder(() => ({ rows: [] }));
+  await promotePlanningVersion(r.exec);
+  assert.match(r.seen[0].sql, /started_at = COALESCE\(started_at, now\(\)\)/,
+    "a version's start is when it began building; a re-promotion must not rewrite history");
+});
+
+test('nothing to promote returns null — an idle project is not an error', async () => {
+  const r = recorder(() => ({ rows: [] }));
+  assert.equal(await promotePlanningVersion(r.exec), null);
+});
+
+test('the promoted row is returned so the caller can carry bugs into it', async () => {
+  const r = recorder(() => ({ rows: [{ id: 'V2', name: 'two', status: 'building', started_at: 't' }] }));
+  const out = await promotePlanningVersion(r.exec);
+  assert.equal(out.id, 'V2');
+  assert.equal(out.status, 'building');
+});
+
+// ---------------------------------------------------------------------------
+// The wiring — where the bug was
+// ---------------------------------------------------------------------------
+
+test('onClosed is passed as the DEPS argument, not in the options object', () => {
+  // THE BUG THIS PINS. `closeVersion({...opts}, deps)` reads `deps.onClosed`.
+  // Putting the hook in the first object is silently ignored: no promotion, no
+  // carry-over, and a 200 response that looks correct.
+  const call = ROUTES.slice(ROUTES.indexOf('const out = await db.closeVersion('), ROUTES.indexOf('return res.json({ ok: true, version: out.version'));
+  const optsEnd = call.indexOf('}, {');
+  assert.ok(optsEnd !== -1, 'the close must be called with a second (deps) argument');
+  assert.equal(call.slice(0, optsEnd).includes('onClosed'), false,
+    'onClosed in the options object is a silent no-op — it belongs in deps');
+  assert.ok(call.slice(optsEnd).includes('onClosed'), 'and it must actually be in deps');
+});
+
+test('the hook promotes BEFORE it carries — the ordering trap', () => {
+  const hook = ROUTES.slice(ROUTES.indexOf('onClosed: async (client'), ROUTES.indexOf('return { promoted, carried };'));
+  const promoteAt = hook.indexOf('promotePlanningVersion');
+  const carryAt = hook.indexOf('carryBugsForward');
+  assert.ok(promoteAt !== -1 && carryAt !== -1);
+  assert.ok(promoteAt < carryAt,
+    'ensureMaintenanceGoal returns null for a non-building version, so carrying first silently carries nothing');
+});
+
+test('no promotion means no carry attempt at all', () => {
+  // Not "carry into null and hope" — there is genuinely nowhere to put them, and
+  // the honest answer is that the bugs stay findable on the closed version until
+  // someone cuts the next one.
+  assert.match(ROUTES, /const carried = promoted\s*\n?\s*\?\s*await db\.carryBugsForward/);
+  assert.match(ROUTES, /:\s*null;/);
+});
+
+test('the close reports what it promoted and carried', () => {
+  // A close now changes WHICH version is live. A caller made to re-read /versions
+  // to discover that has been told half the outcome.
+  assert.match(ROUTES, /promoted: out\.after\?\.promoted \?\? null/);
+  assert.match(ROUTES, /carried: out\.after\?\.carried \?\? null/);
+});
+
+// ---------------------------------------------------------------------------
+// Composition
+// ---------------------------------------------------------------------------
+
+test('the hook is composed in the ROUTE, not inside closeVersion', () => {
+  // The two halves live in different db units — versions and goals, siblings in
+  // the module's require DAG — and the route is the one place already holding the
+  // whole facade. Reaching sideways between the units is how that DAG stops being
+  // one.
+  assert.equal(/carryBugsForward/.test(DBV), false,
+    'db-versions.js must not reach into db-goals.js');
+  assert.match(ROUTES, /db\.promotePlanningVersion\(client\)/);
+  assert.match(ROUTES, /db\.carryBugsForward\(/);
+});
+
+test('the stale R17 note in closeVersion was corrected, not left to mislead', () => {
+  // It said roll_forward "only ABSTAINS from cutting the goal ... until R17
+  // ships". R17 shipped; a reader meeting the old wording would go looking for
+  // an abstention that is no longer there.
+  assert.equal(/Until it ships/.test(DBV), false);
+  assert.match(DBV, /It DOES create successor goals now/);
+});