@bongos/core 1.19.598 → 1.19.599

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.598",
-  "core_contract": "1.19.598",
-  "source_commit": "765987c9bfd5277ee8bd4a6dc5c73f6aab9224bc",
+  "core_version": "1.19.599",
+  "core_contract": "1.19.599",
+  "source_commit": "f59ebfca96e7c415cbc1fad82765ad3a5b9928f0",
   "source_ref": "HEAD",
-  "built_at": "2026-09-08T04:22:59.900Z",
+  "built_at": "2026-09-08T04:29:29.015Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 457,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 2074,
+    "functional_verbatim": 2073,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2555,
-  "tree_sha256": "2193f9634af7589ddd47ef00b03be7824679582ec0ca3688709c68ffe2e78d7b",
+  "file_count": 2554,
+  "tree_sha256": "aedc5cdbc47fef15f2a6faed62adffd158b835cfe6b534ff142dc4bef06645ea",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2727,7 +2727,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "162a1e6f165acd0b744497fd19ecc34fa10a9229dca13c7b1d35c795511a85b4"
+      "sha256": "2fc4af2f63b7d20ac659d4e25f0c17a4489e45ab57f8c03e2591063266d5017c"
     },
     {
       "path": "docs/modules-contract.md",
@@ -5532,7 +5532,7 @@
     {
       "path": "modules/lifecycle/db-goals.js",
       "mode": "0000644",
-      "sha256": "c3e06daaf78911c9dc44f72aa7a104f269624c92f343cd808b2962076a641a23"
+      "sha256": "e8df5e0da281082f8627d3c985dc1993c3c36e9a9848594fadc8393ea7c128d2"
     },
     {
       "path": "modules/lifecycle/db-grade.js",
@@ -5572,7 +5572,7 @@
     {
       "path": "modules/lifecycle/db.js",
       "mode": "0000644",
-      "sha256": "14c05469abcf349c9173a80059e7fa0dd880b1b5a0b25680ba0d9e524e46d5d9"
+      "sha256": "33fc8959d522bcf18c445b1a5710940379f84d1e938eecdc52cdf52bec9c4b3d"
     },
     {
       "path": "modules/lifecycle/dead-deps.js",
@@ -7622,12 +7622,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "a20139fc06badf4713e2ad023c865eb4339b49d1caabfa79d5ea8282c1e13cea"
+      "sha256": "89f20f42f441b010cc5a6ea07f38828987932c85779d01278988f85428d3465e"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "cfc6a9c8fd26745544ca7256e40c41929174e617e199cf972e1df59f68e98e51"
+      "sha256": "8bba17aa2a21a1b48b9bfb7fb50aad31f75df0d63e459b7fc4ef504375c4c80a"
     },
     {
       "path": "public-docs/index.html",
@@ -9342,7 +9342,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "922414a017882732619bc7ae7c14ec5c056c0bd2f950447ca9abac23d0b3a687"
+      "sha256": "55821676bf2fdb2f703e9c6137c877f3b5ede7291985bbce9c611f262a2fc48b"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -11289,11 +11289,6 @@
       "mode": "0000644",
       "sha256": "9a1813d6036886ea07d1563e71a466e66c28554b75b22605464c795fd9fa2ebb"
     },
-    {
-      "path": "tests/maintenance_carry_forward.mjs",
-      "mode": "0000644",
-      "sha256": "4ac9164b84ad7bf8e9c1b45e7cb5e157762c992ddde16041410a528a534e60f5"
-    },
     {
       "path": "tests/maintenance_goal.mjs",
       "mode": "0000644",
@@ -11302,7 +11297,7 @@
     {
       "path": "tests/maintenance_goal_flag.mjs",
       "mode": "0000644",
-      "sha256": "37356bcd78ff92537a5512b60f2274d573b6c90bb30f5deca006a14d4841fc95"
+      "sha256": "d1f662d8533544ca1e7575f8b7c75fc93d89a4a60880bd47b873b068a3241e4b"
     },
     {
       "path": "tests/manage_manifest_shared_read.mjs",

package/docs/module-api-changelog.md

@@ -1645,5 +1645,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.596 with no explicit bump. run 34186368179. (task 1002620)
   1.19.598 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.597 with no explicit bump. run 34186758247. (task 1002620)
+  1.19.599 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.598 with no explicit bump. run 34187136306. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/lifecycle/db-goals.js

@@ -231,79 +231,45 @@ async function carryBugsForward({ fromVersionId, toVersionId }, deps = {}) {
   );
   if (!from[0]) return { fromGoalId: null, toGoalId: null, moved: 0 };
 
+  // RETURNS, NEVER THROWS (BV1.R18c, task 1003709). This used to throw
+  // CARRY_FORWARD_NO_DESTINATION here, and the call site is closeVersion's
+  // `deps.onClosed` — INSIDE the close transaction. A throw there rolls the whole
+  // close back, so a version whose successor had not been promoted yet would
+  // simply refuse to close. ADR 0263 §4 is explicit that this path may never fail
+  // the close, for the same reason closeCompletedWorkForShip may never fail a ship.
+  //
+  // The reason still travels, because a bare 0 is indistinguishable from "there
+  // was nothing to carry" — and the two want opposite responses: one is fine, the
+  // other means R20 ran the carry-over before the promotion (ADR 0263 §8's
+  // ordering trap) and the queue is still sitting on a shipped version.
   const to = await ensureMaintenanceGoal(toVersionId, deps);
-  if (!to) {
-    throw Object.assign(new Error('successor version cannot hold a maintenance goal'), {
-      code: 'CARRY_FORWARD_NO_DESTINATION', toVersionId,
-      hint: 'ensureMaintenanceGoal returns null unless the destination version is `building` — promote it before carrying forward (ADR 0263 §8).',
-    });
-  }
+  if (!to) return { fromGoalId: String(from[0].id), toGoalId: null, moved: 0, reason: 'successor_not_building' };
 
   // Only the UNFINISHED ones move. A shipped or abandoned defect is history and
   // belongs to the version it was fixed in — dragging it forward would make every
   // successor's maintenance goal a growing archive of everything ever reported.
+  // THE VERSION MOVES WITH THE GOAL (BV1.R18c, task 1003709). Setting only
+  // `goal_id` strands the task's `version_id` on the version being closed, and
+  // that column is not decoration: `version_progress` joins
+  // `tasks t ON t.version_id = v.id`, and `version-close.getCarryOverCount`
+  // filters on it directly. A half-moved task therefore counts against a SHIPPED
+  // version forever, never counts toward the successor, and leaves the closed
+  // version still reporting carry-over it no longer holds.
+  //
+  // Smoke rows are excluded the way version_progress excludes them — a test
+  // fixture must not ride across a version boundary into a real queue.
   const { rows: moved } = await exec.query(
-    `UPDATE tasks SET goal_id = $2, updated_at = now()
+    `UPDATE tasks SET goal_id = $2, version_id = $3, updated_at = now()
       WHERE goal_id = $1 AND ${nonTerminalSql('status')}
+        AND ${SMOKE_NOT_LIKE}
       RETURNING id::text`,
-    [from[0].id, to.id]
-  );
-  return { fromGoalId: String(from[0].id), toGoalId: String(to.id), moved: moved.length };
-}
-
-// carryMaintenanceForward — move a closing version's unfinished maintenance work
-// into the successor's maintenance goal (BV1.R18, task 1003605, ADR 0263 §7).
-//
-// THE ONE GOAL THAT LEGITIMATELY SPANS VERSIONS. Every other goal either finishes
-// or is dispositioned at close (roll forward, or abandon — R12). A maintenance
-// goal is neither: it holds defects against already-shipped work, and those arrive
-// on their own schedule rather than on the version's. Cutting them because a
-// version ended would delete a bug queue for a reason that has nothing to do with
-// the bugs; making them need an override to survive would put a counted escape
-// hatch on the ordinary path, which is what ADR 0250 §3 built the counter to
-// prevent. So they move.
-//
-// RUNS ON THE CLOSE'S OWN CLIENT, inside its transaction, via the `deps.onClosed`
-// seam R12 left in closeVersion. Two things follow, both load-bearing:
-//
-//   The successor must ALREADY be `building` when this runs. `ensureMaintenanceGoal`
-//   returns null for a version in any other state, so a carry-over run before R20's
-//   promotion silently carries nothing and reports success. That is why the seam
-//   fires after the flip and why this asserts rather than assumes.
-//
-//   Nothing here may fail the close for want of a destination. A version with no
-//   successor (no planning version was scoped) closes with its maintenance work
-//   left where it is — visible on a shipped version, recoverable, and honest —
-//   rather than the close failing or the bugs being cut. Returns a summary saying
-//   which happened.
-//
-// The source goal is left ARCHIVED with nothing open, so it passes R10's own
-// check on the way out rather than being special-cased around it.
-async function carryMaintenanceForward({ fromVersionId, toVersionId }, deps = {}) {
-  const exec = deps.client || ((deps.pool && process.env.NODE_ENV === 'test') ? deps.pool : pool);
-  const { rows: src } = await exec.query(
-    `SELECT id FROM goals WHERE version_id = $1 AND is_maintenance LIMIT 1`, [fromVersionId]
-  );
-  if (!src[0]) return { carried: 0, from: null, to: null, reason: 'no_maintenance_goal' };
-  if (!toVersionId) return { carried: 0, from: String(src[0].id), to: null, reason: 'no_successor' };
-
-  const dest = await ensureMaintenanceGoal(toVersionId, { client: exec });
-  // Null means the successor is not `building` — see the ordering note above. Do
-  // not "fix" this by relaxing ensureMaintenanceGoal's version gate: that gate is
-  // what stops a defect being filed into a shipped version's goal (the 1000771 bug).
-  if (!dest) return { carried: 0, from: String(src[0].id), to: null, reason: 'successor_not_building' };
-
-  const { rows: moved } = await exec.query(
-    `UPDATE tasks SET goal_id = $2, version_id = $3, updated_at = now()
-      WHERE goal_id = $1 AND ${nonTerminalSql()}
-        AND ${SMOKE_NOT_LIKE.replace(/title/, 'tasks.title')}
-      RETURNING id`,
-    [src[0].id, dest.id, toVersionId]
+    [from[0].id, to.id, toVersionId]
   );
-  // The emptied goal closes behind them. Archived rather than achieved: it was
-  // never "done", it stopped being the live queue.
-  await exec.query(`UPDATE goals SET status = 'archived', updated_at = now() WHERE id = $1`, [src[0].id]);
-  return { carried: moved.length, from: String(src[0].id), to: String(dest.id), reason: null };
+  // The emptied source goal closes behind them: archived, not achieved — it was
+  // never "done", it stopped being the live queue. Leaving it open on a shipped
+  // version is the mirror of the defect this whole goal exists to remove.
+  await exec.query(`UPDATE goals SET status = 'archived', updated_at = now() WHERE id = $1`, [from[0].id]);
+  return { fromGoalId: String(from[0].id), toGoalId: String(to.id), moved: moved.length, reason: null };
 }
 
 // listVersionAdmissions (BV1.R07, task 1003594) — every goal admitted into ONE
@@ -1228,7 +1194,6 @@ module.exports = {
   carryBugsForward,
   achieveGoalIfComplete,
   archiveGoalWithDispositions,
-  carryMaintenanceForward,
   addGoalMember,
   addGoalScopeModules,
   createGoal,

package/modules/lifecycle/db.js

@@ -83,7 +83,6 @@ const {
   listActiveClaimsForTasks,
   listCriteriaForGoal,
   archiveGoalWithDispositions,
-  carryMaintenanceForward,
   openTasksInGoal,
   listGoalMembers,
   listGoals,
@@ -260,7 +259,6 @@ module.exports = {
   listPendingRequestsForGoal,
   listCriteriaForGoal,
   archiveGoalWithDispositions,
-  carryMaintenanceForward,
   openTasksInGoal,
   createTask,
   generalGoalIdForVersion,

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.598",
+  "version": "1.19.599",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.598",
+      "version": "1.19.599",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.598",
+  "version": "1.19.599",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -55,7 +55,7 @@ const { buildInfo } = require('./build-info');
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.598'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.599'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/maintenance_goal_flag.mjs

@@ -117,7 +117,7 @@ test('carryBugsForward moves only NON-TERMINAL tasks', async () => {
     return { rows: [] };
   });
   const out = await carryBugsForward({ fromVersionId: 'V1', toVersionId: 'V2' }, { client: r.client });
-  assert.deepEqual(out, { fromGoalId: '1', toGoalId: '5', moved: 2 });
+  assert.deepEqual(out, { fromGoalId: '1', toGoalId: '5', moved: 2, reason: null });
   const move = r.seen.find((q) => /UPDATE tasks/.test(q.sql));
   assert.match(move.sql, /status NOT IN \('shipped', 'abandoned'\)/,
     'a fixed or cut defect belongs to the version it was resolved in — carrying it forward would make every successor an archive');
@@ -130,20 +130,33 @@ test('a version with no maintenance goal carries nothing, and that is not an err
   assert.equal(r.seen.some((q) => /UPDATE tasks/.test(q.sql)), false, 'nothing is written');
 });
 
-test('carrying into a version that is not building FAILS LOUDLY', async () => {
+test('carrying into a version that is not building REPORTS loudly — without failing the close', async () => {
   // ADR 0263 §8: promotion must happen BEFORE the carry-over, because
   // ensureMaintenanceGoal returns null for a version that is not `building`. A
   // silent no-op here would strand the bug queue on a shipped version — the
   // exact entombment this whole path exists to end — and look like success.
+  //
+  // BV1.R18c (task 1003709) changed HOW it is loud, not whether. This threw
+  // CARRY_FORWARD_NO_DESTINATION, and the call site is closeVersion's
+  // `deps.onClosed` — inside the close transaction. A throw there rolls the whole
+  // close back, so a version whose successor had not been promoted yet would
+  // refuse to close at all, and ADR 0263 §4 says this path may never fail the
+  // close (the same posture closeCompletedWorkForShip has toward a ship).
+  //
+  // The distinction the throw was protecting is kept in the RETURN: `reason` tells
+  // a caller that the destination was missing, which a bare `moved: 0` could not —
+  // and that is the whole point, because "nothing to carry" and "you ran this
+  // before the promotion" want opposite responses.
   const r = recorder((sql) => {
     if (/SELECT id FROM goals/.test(sql)) return { rows: [{ id: 1 }] };
     if (/FROM versions/.test(sql)) return { rows: [{ status: 'planning' }] };
     return { rows: [] };
   });
-  await assert.rejects(
-    () => carryBugsForward({ fromVersionId: 'V1', toVersionId: 'V2' }, { client: r.client }),
-    (e) => e.code === 'CARRY_FORWARD_NO_DESTINATION'
-  );
+  const out = await carryBugsForward({ fromVersionId: 'V1', toVersionId: 'V2' }, { client: r.client });
+  assert.equal(out.moved, 0);
+  assert.equal(out.reason, 'successor_not_building');
+  assert.equal(out.toGoalId, null, 'and it names no destination, because there was none');
+  assert.equal(r.seen.some((q) => /UPDATE tasks/.test(q.sql)), false, 'nothing moved');
 });
 
 test('carryBugsForward does NOT refuse an actively-claimed task', () => {
@@ -221,3 +234,55 @@ test('the find-or-create survives a pre-existing duplicate rather than throwing'
   assert.match(fn.slice(0, 2500), /ORDER BY id LIMIT 1/,
     'with no unique constraint, a duplicate must be survivable and the answer stable');
 });
+
+// ---- BV1.R18c (task 1003709): the two defects the merge closed -------------
+//
+// `main` briefly carried TWO carry-forward functions, one per session that built
+// R18. Collapsing them was not a coin toss: each had something the other needed,
+// and the two below are the halves that were missing here.
+
+test('R18c: the VERSION moves with the goal, or the task counts against a shipped version forever', async () => {
+  // `version_progress` joins `tasks t ON t.version_id = v.id` (verified against the
+  // live view), and `version-close.getCarryOverCount` filters on it directly. A task
+  // moved to the successor's goal but left stamped with the closing version counts
+  // against a SHIPPED version, never counts toward the successor, and leaves the
+  // closed version still reporting carry-over it no longer holds.
+  const r = recorder((sql) => {
+    if (/SELECT id FROM goals/.test(sql)) return { rows: [{ id: 1 }] };
+    if (/FROM versions/.test(sql)) return { rows: [{ status: 'building' }] };
+    if (/pg_advisory_xact_lock/.test(sql)) return { rows: [] };
+    if (/SELECT id, version_id/.test(sql)) return { rows: [{ id: 5 }] };
+    if (/UPDATE tasks/.test(sql)) return { rows: [{ id: '11' }] };
+    return { rows: [] };
+  });
+  await carryBugsForward({ fromVersionId: 'V1', toVersionId: 'V2' }, { client: r.client });
+  const mv = r.seen.find((q) => /UPDATE tasks/.test(q.sql));
+  assert.ok(mv, 'the move must happen');
+  assert.match(mv.sql, /version_id = \$3/, 'goal_id alone leaves the task half-moved');
+  assert.equal(mv.params[2], 'V2');
+  assert.match(mv.sql, /NOT LIKE/, 'and a smoke fixture must not ride across a version boundary');
+});
+
+test('R18c: a successor that is not yet building RETURNS, it does not throw', async () => {
+  // The call site is closeVersion's `deps.onClosed` — inside the close
+  // transaction. A throw there rolls the whole close back, so a version whose
+  // successor had not been promoted would refuse to close. ADR 0263 §4 says this
+  // path may never fail the close.
+  const r = recorder((sql) => {
+    if (/SELECT id FROM goals/.test(sql)) return { rows: [{ id: 1 }] };
+    if (/FROM versions/.test(sql)) return { rows: [{ status: 'planning' }] };
+    return { rows: [] };
+  });
+  const out = await carryBugsForward({ fromVersionId: 'V1', toVersionId: 'V2' }, { client: r.client });
+  assert.equal(out.moved, 0);
+  assert.equal(out.reason, 'successor_not_building',
+    'a bare 0 is indistinguishable from "nothing to carry", and the two want opposite responses');
+  assert.equal(out.toGoalId, null);
+});
+
+test('R18c: exactly ONE carry-forward is exported', () => {
+  const db = require('../modules/lifecycle/db.js');
+  assert.equal(typeof db.carryBugsForward, 'function');
+  assert.equal(db.carryMaintenanceForward, undefined,
+    'two functions for one job is how a call site picks the wrong one');
+});

package/tests/maintenance_carry_forward.mjs

@@ -1,122 +0,0 @@
-// tests/maintenance_carry_forward.mjs — the one goal that spans versions
-// (BV1.R18b, task 1003708, goal 1000086, ADR 0263 §7).
-//
-// WHY THIS GOT A COLUMN. Since task 1003691 the maintenance goal was found by
-// matching `'<version> — maintenance'`. For the ROUTING path that was a
-// provenance wrinkle — a hand-titled goal receives a bug. For the CLOSING path
-// it was a way through the gate: `maintenanceGoalExemptSql` decides which goals
-// hold a VERSION open, so anyone who named a goal `'BONGOS-V1 — maintenance'`
-// exempted it from the rule that decides when a version may close.
-//
-// A naming convention is not an access control. That sentence is the whole task,
-// and most of this file is that sentence made mechanical.
-//
-// Run:  node tests/maintenance_flag.mjs
-
-import { strict as assert } from 'node:assert';
-import { createRequire } from 'node:module';
-import { readFileSync } from 'node:fs';
-import { makeRunner, makeSqlAwareClient } from './helpers.mjs';
-
-process.env.NODE_ENV = 'test';
-const require = createRequire(import.meta.url);
-const { maintenanceGoalExemptSql, ensureMaintenanceGoal, carryMaintenanceForward, openNonMaintenanceGoals } = require('../modules/lifecycle/db.js');
-const { test, summary } = makeRunner();
-
-const src = (rel) => readFileSync(new URL('../' + rel, import.meta.url), 'utf8');
-const MIG = src('migrations/core_235_one_maintenance_goal_per_version.sql');
-const MIG234 = src('migrations/core_234_goals_is_maintenance.sql');
-const flat = (q) => String(q.sql).replace(/\s+/g, ' ').trim();
-function pool(handler) {
-  const c = makeSqlAwareClient(handler);
-  return { connect: c.connect, query: (sql, p) => c._client.query(sql, p), queries: c._client.queries };
-}
-
-// ---- one per version is a CONSTRAINT ---------------------------------------
-
-await test('the per-version uniqueness is enforced by the DATABASE, not a convention', () => {
-  // core_234 gave the flag a partial index for lookup speed, which is right. But a
-  // NON-unique one leaves two flagged goals on one version possible, and
-  // ensureMaintenanceGoal's read is `WHERE version_id = $1 AND is_maintenance
-  // LIMIT 1` — with two rows that returns whichever the planner picks, and every
-  // homeless bug files into an arbitrary one of them, permanently.
-  assert.match(MIG, /CREATE UNIQUE INDEX IF NOT EXISTS goals_one_maintenance_per_version_idx[\s\S]*?ON goals \(version_id\)[\s\S]*?WHERE is_maintenance/);
-  assert.match(MIG, /DROP INDEX IF EXISTS goals_maintenance_by_version_idx/,
-    'and it replaces the plain one — a UNIQUE index serves every read the plain one did');
-  assert.match(MIG, /BEGIN;[\s\S]*COMMIT;/);
-});
-
-await test('it closes the door the advisory lock could not', () => {
-  // The lock (task 1003691) serialises the RACE. It cannot stop a second
-  // maintenance goal created any other way, and `goals` never had a unique
-  // constraint on (version_id, title) for the lock to fall back on.
-  const dbg = src('modules/lifecycle/db-goals.js');
-  assert.match(dbg, /pg_advisory_xact_lock/, 'the lock stays — it solves a different problem');
-  assert.match(MIG234, /is_maintenance boolean NOT NULL DEFAULT false/, 'core_234 still owns the column');
-});
-
-// ---- carry forward ---------------------------------------------------------
-
-function carryPool({ src = { id: 5 }, destStatus = 'building', destFound = { id: 9 } } = {}) {
-  return pool((sql) => {
-    const q = String(sql).replace(/\s+/g, ' ');
-    if (/SELECT id FROM goals WHERE version_id = \$1 AND is_maintenance LIMIT 1/.test(q)) return { rows: src ? [src] : [] };
-    if (/SELECT status FROM versions/.test(q)) return { rows: [{ status: destStatus }] };
-    if (/pg_advisory_xact_lock/.test(q)) return { rows: [] };
-    if (/FROM goals WHERE version_id = \$1 AND is_maintenance/.test(q)) return { rows: destFound ? [destFound] : [] };
-    if (/UPDATE tasks SET goal_id/.test(q)) return { rows: [{ id: 1 }, { id: 2 }, { id: 3 }] };
-    return { rows: [] };
-  });
-}
-
-await test('open bugs move to the successor, and the emptied goal archives behind them', async () => {
-  const p = carryPool();
-  const out = await carryMaintenanceForward({ fromVersionId: 'V1', toVersionId: 'V2' }, { pool: p });
-  assert.deepEqual(out, { carried: 3, from: '5', to: '9', reason: null });
-  const mv = p.queries.find((x) => /UPDATE tasks SET goal_id/.test(flat(x)));
-  assert.match(flat(mv), /NOT IN \('shipped', 'abandoned'\)/, 'only the unfinished ones travel');
-  assert.equal(mv.params[2], 'V2', 'and their version_id moves with them, or they are orphaned across the boundary');
-  assert.ok(p.queries.some((x) => /UPDATE goals SET status = 'archived'/.test(flat(x))));
-});
-
-await test('NO successor: the bugs stay put and the close still succeeds', async () => {
-  // A version with nothing scoped after it must not fail its close, and its bug
-  // queue must not be cut for a reason that has nothing to do with the bugs.
-  const p = carryPool();
-  const out = await carryMaintenanceForward({ fromVersionId: 'V1', toVersionId: null }, { pool: p });
-  assert.equal(out.carried, 0);
-  assert.equal(out.reason, 'no_successor');
-  assert.equal(p.queries.some((x) => /UPDATE tasks/.test(flat(x))), false, 'nothing moved');
-  assert.equal(p.queries.some((x) => /UPDATE goals SET status = 'archived'/.test(flat(x))), false,
-    'and the source goal is NOT closed — the queue is still live');
-});
-
-await test('a successor that is not yet BUILDING carries nothing, and says so', async () => {
-  // The ordering trap ADR 0263 §8 names: ensureMaintenanceGoal returns null for a
-  // non-building version, so a carry-over run before R20's promotion would report
-  // success while moving nothing.
-  const p = carryPool({ destStatus: 'planning', destFound: null });
-  const out = await carryMaintenanceForward({ fromVersionId: 'V1', toVersionId: 'V2' }, { pool: p });
-  assert.equal(out.carried, 0);
-  assert.equal(out.reason, 'successor_not_building', 'a silent zero would be indistinguishable from success');
-  assert.equal(p.queries.some((x) => /UPDATE tasks/.test(flat(x))), false);
-});
-
-await test('a version with no maintenance goal at all is a clean no-op', async () => {
-  const p = carryPool({ src: null });
-  const out = await carryMaintenanceForward({ fromVersionId: 'V1', toVersionId: 'V2' }, { pool: p });
-  assert.equal(out.reason, 'no_maintenance_goal');
-  assert.equal(out.carried, 0);
-});
-
-await test('it runs on the CALLER exec, so it joins the close transaction', () => {
-  // R12 left `deps.onClosed(client, …)` for exactly this. Opening its own
-  // connection would commit the carry-over independently of the close it belongs to.
-  const dbg = src('modules/lifecycle/db-goals.js');
-  const fn = dbg.slice(dbg.indexOf('async function carryMaintenanceForward'), dbg.indexOf('// listVersionAdmissions'));
-  assert.match(fn, /const exec = deps\.client \|\|/, 'it must accept the caller\'s client');
-  assert.doesNotMatch(fn, /\.connect\(\)/, 'and must never open its own');
-  assert.doesNotMatch(fn, /BEGIN|COMMIT/, 'nor manage a transaction it does not own');
-});
-
-summary();