@bongos/core 1.19.585 → 1.19.587

package/tests/task_goal_required.mjs

@@ -186,7 +186,8 @@ test('no FIFTH vector has appeared', () => {
   // which case delete its opt-in and this line, do not extend the list.
   const roster = new Set([...OPT_INS.map(([f]) => f), 'modules/lifecycle/db-tasks.js']);
   const suspects = [
-    'modules/ideas/inbox.js', 'modules/lifecycle/routes/goals.js',
+    'modules/ideas/inbox.js', 'modules/ideas/homeless-home.js',
+    'modules/lifecycle/routes/goals.js',
     'modules/lifecycle/routes/task-write-routes.js',
   ];
   for (const f of suspects) {

package/tests/wizard_preselect_why.mjs

@@ -0,0 +1,137 @@
+// tests/wizard_preselect_why.mjs — the module picker always says WHY the preselect is on
+// (task 1003684).
+//
+// The bug as filed said the starter-bundle "why" sentence was being dropped for
+// Game + small-team. It was not: `adjustments` is a DELTA, and a rule that fires without
+// changing anything claims nothing (ADR 0243). The game bundle is already
+// ['dev-box','discord'] and the small-team rule ADDS dev-box, so the rule fires, moves
+// nothing, and correctly reports []. Verified against live core 1.19.580:
+//   byTeamShape['small-team'] => {"bundle":["dev-box","discord"],"adjustments":[]}
+//
+// The real defect is what the owner then saw: two extras pre-switched-on with no reason
+// beside them — precisely the state the paint site's own comment calls out, "a preselect an
+// owner cannot see the reason for is one they have to audit, which is the thing ADR 0237
+// says is worse than no preselect at all". Each bundle carries a curated `summary` authored
+// for this, served on every row of GET /provisioning/starter-bundles, and never rendered
+// anywhere in the wizard. It is now the floor beneath the adjustment sentences.
+//
+// Harness: the vm-slice idiom (tests/project_door_ui.mjs), since the wizard's script is
+// inline in the page and there is no jsdom here.
+//
+// Run:  node --test --test-reporter=tap tests/wizard_preselect_why.mjs
+
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const HUB = fs.readFileSync(path.join(ROOT, 'modules', 'public-landing', 'public', 'projects.html'), 'utf8');
+
+const SLICE_RE = /function bundleRow\(\)[\s\S]*?function preselectReasons\(\)[\s\S]*?\n {4}\}/;
+const slice = (HUB.match(SLICE_RE) || [null])[0];
+
+test('the preselect-reason slice is still findable', () => {
+  assert.ok(slice, 'bundleRow/tailoredRow/preselectReasons were not found in projects.html');
+  assert.match(slice, /function tailoredRow\(\)/, 'the slice spans the tailoring lookup too');
+});
+
+// Faithful to the real payload shape (confirmed against live): every bundle row carries
+// label/summary/bundle, and byTeamShape holds the resolved answer per team shape.
+const BUNDLES = {
+  bundles: [
+    {
+      type: 'game',
+      label: 'Game starter',
+      summary: 'Somewhere for players to gather, and a place to walk a change through before anyone plays it.',
+      bundle: ['dev-box', 'discord'],
+      byTeamShape: {
+        // the live case: the rule fires, moves nothing, reports nothing
+        'small-team': { bundle: ['dev-box', 'discord'], adjustments: [] },
+        solo: {
+          bundle: ['discord'],
+          adjustments: [{ reason: 'You are building this alone, so the shared cloud environment is off — your own machine is the setup.' }],
+        },
+      },
+    },
+    {
+      type: 'research',
+      label: 'Research starter',
+      summary: 'Extra agents to run the reading and the experiments the question needs.',
+      bundle: ['agents'],
+      byTeamShape: {
+        'small-team': {
+          bundle: ['agents', 'dev-box'],
+          adjustments: [{ reason: 'A small team gets one shared environment to build in, so nobody is debugging their own laptop.' }],
+        },
+      },
+    },
+    { type: 'not-sure', label: 'Not sure', summary: '', bundle: [], byTeamShape: {} },
+  ],
+};
+
+function why({ projType, teamShape, modules = null, bundles = BUNDLES }) {
+  const sandbox = { starterBundles: bundles, state: { projType, teamShape, modules } };
+  sandbox.globalThis = sandbox;
+  vm.createContext(sandbox);
+  vm.runInContext(slice + '\nvar __out = preselectReasons();', sandbox);
+  // Copy out of the vm realm: its Array has a different prototype, and assert/strict's
+  // deepEqual compares prototypes — so a correct result would otherwise fail as
+  // "same structure but not reference-equal".
+  return Array.from(sandbox.__out);
+}
+
+test('game + small-team: no delta, so the type\'s own summary is the reason', () => {
+  // This is the exact combination from the live walk that surfaced the bug.
+  const out = why({ projType: 'game', teamShape: 'small-team' });
+  assert.deepEqual(out, ['Somewhere for players to gather, and a place to walk a change through before anyone plays it.']);
+});
+
+test('a REAL adjustment still speaks for itself — the summary does not displace it', () => {
+  const out = why({ projType: 'research', teamShape: 'small-team' });
+  assert.equal(out.length, 1);
+  assert.match(out[0], /shared environment/);
+  assert.doesNotMatch(out[0], /reading and the experiments/, 'the rule\'s sentence wins, not the summary');
+});
+
+test('a removal adjustment is reported the same way', () => {
+  const out = why({ projType: 'game', teamShape: 'solo' });
+  assert.equal(out.length, 1);
+  assert.match(out[0], /building this alone/);
+});
+
+test('no team shape answered: falls through to the bundle, still explained', () => {
+  // tailoredRow() returns the unadjusted bundle with adjustments: [] when no shape is set,
+  // which before this change also produced an unexplained preselect.
+  const out = why({ projType: 'game', teamShape: null });
+  assert.deepEqual(out, ['Somewhere for players to gather, and a place to walk a change through before anyone plays it.']);
+});
+
+test('once the owner has answered for themselves, the panel says nothing', () => {
+  // The pre-existing rule, and the one a careless fallback would have broken: handing back
+  // a reason for a toggle they just flipped reads as the panel arguing with them.
+  assert.deepEqual(why({ projType: 'game', teamShape: 'small-team', modules: [] }), []);
+  assert.deepEqual(why({ projType: 'game', teamShape: 'small-team', modules: ['agents'] }), []);
+});
+
+test('an unknown type, or a bundle with no summary, says nothing rather than crashing', () => {
+  assert.deepEqual(why({ projType: 'no-such-type', teamShape: 'small-team' }), []);
+  assert.deepEqual(why({ projType: null, teamShape: 'small-team' }), []);
+  assert.deepEqual(why({ projType: 'not-sure', teamShape: 'small-team' }), [], 'empty summary is not a sentence');
+});
+
+test('before the bundles read lands, nothing is claimed', () => {
+  assert.deepEqual(why({ projType: 'game', teamShape: 'small-team', bundles: null }), []);
+});
+
+test('every sentence returned is a plain string, so the paint site can escape it directly', () => {
+  for (const t of ['game', 'research']) {
+    for (const s of ['small-team', 'solo', null]) {
+      for (const line of why({ projType: t, teamShape: s })) {
+        assert.equal(typeof line, 'string', `${t}/${s} yielded a non-string`);
+      }
+    }
+  }
+});