@bongos/core 1.19.58 → 1.19.59

package/.bongos-core.json

@@ -2,11 +2,11 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.58",
-  "core_contract": "1.19.58",
-  "source_commit": "138d3a9bbd75c0edac9f89c279e76e9ce9789b0b",
+  "core_version": "1.19.59",
+  "core_contract": "1.19.59",
+  "source_commit": "e93244fafbe4236b1b90218f03c70c92bfd0becb",
   "source_ref": "HEAD",
-  "built_at": "2026-08-11T23:20:42.316Z",
+  "built_at": "2026-08-11T23:37:01.674Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 291,
@@ -17,7 +17,7 @@
     "gate": "passed"
   },
   "file_count": 1529,
-  "tree_sha256": "08cfb44880c063d98dfdd34b729592669fd80917f30027532bf691f3f0a2abe4",
+  "tree_sha256": "0f793cd7617fce56439932f68de11239e7639d28e50f8d9ee485ba8a602a5f30",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2577,7 +2577,7 @@
     {
       "path": "modules/dev-box/boxes.js",
       "mode": "0000644",
-      "sha256": "acb95d0a5fb535197e949effd0a8720dfaa743a6d86109f10d91505401197c63"
+      "sha256": "fbf9bb7bd4c70ac81627d7d473a94e98e6976581bc29f60c5342d428a39238cf"
     },
     {
       "path": "modules/dev-box/db.js",
@@ -2962,7 +2962,7 @@
     {
       "path": "modules/hall-ui/public/box-panel.js",
       "mode": "0000644",
-      "sha256": "271246b55dfd787c338b6f844b96d0032e111b2943d5e12cfaeb9bca3ef75f26"
+      "sha256": "d4b32aa4382100a7e60cc83e83ef23ba34dac0ff759143286b2deaebb8f56cb1"
     },
     {
       "path": "modules/hall-ui/public/brand-apply.js",
@@ -4032,12 +4032,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "32227d0bece0f036772ed8a6f01a5aee0ea6c47d81b471a3e7cf734aeb24f1ed"
+      "sha256": "f2e15bf06d0e8080e47aeea514dfc26dc267c14a96d32fe805cb240491f0baad"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "b2931ffd8ff5d2fd5d320c3c435e3bc16d59a2757c248529d6160f305216a24d"
+      "sha256": "c3feb3c561c5bf96e9580673b6995835a0d5674f54f96c8b3109fc304e090556"
     },
     {
       "path": "public-docs/index.html",
@@ -5657,7 +5657,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "98dd7f963174211b172a2023fe2d13a249362d7471d59ab6eb411424332bee3f"
+      "sha256": "a02eb4c1cfa272d700a9776652612143de38566cd86208f059ed1d0fed24934b"
     },
     {
       "path": "src/module-loader/loader.js",
@@ -5947,7 +5947,7 @@
     {
       "path": "tests/box_code_staleness.mjs",
       "mode": "0000644",
-      "sha256": "fc29b6b8be8aa4780486ff33abceceb3a46fc421198a78a09a2a8cf693fd33f1"
+      "sha256": "59d4580504c7352d5f83eec0914f21d0af559b9782bdde1353b5cb3eb2dbb31f"
     },
     {
       "path": "tests/box_connect_e2e.mjs",

package/modules/dev-box/boxes.js

@@ -752,8 +752,17 @@ const CODE_STALE_LAG_MS = 2 * 24 * 60 * 60 * 1000; // 2 days behind deployed cod
 // { stale, reason } where reason ∈
 //   not_active            — only active boxes are judged (parked/destroyed → n/a)
 //   awaiting_first_report — active, never reported, still inside provision grace
-//   never_reported        — active, past grace, never reported ⇒ too old to even
-//                           run the reporter (a pre-self-update box) ⇒ STALE
+//   never_reported        — active, past grace, never reported ⇒ NOT stale. Silence
+//                           is an unknown, not a verdict: it means the reporter never
+//                           ran, which is at least as likely to be OUR fault as the
+//                           box's. It was our fault for the whole life of this feature
+//                           (task 1002698) — ADR 0072 specified infra/box-report-version.sh
+//                           and it was never written (task 1002699), so EVERY box in the
+//                           fleet read as stale, and the banner's only remedy (destroy the
+//                           box, provision a fresh one) could not possibly clear it. A
+//                           builder who believed it rebuilt in a loop, losing uncommitted
+//                           work and spending money each time. Only a box that has ACTUALLY
+//                           REPORTED can be called stale — see 'behind'.
 //   behind                — reported, but its commit is > CODE_STALE_LAG_MS older
 //                           than the server's deployed commit ⇒ STALE (a box whose
 //                           `pull --ff-only` has been silently failing)
@@ -772,7 +781,9 @@ function computeCodeStaleness({ state, provisionedAt, codeReportedAt, codeCommit
     const prov = toMs(provisionedAt);
     const withinGrace = prov != null && (now - prov) < CODE_REPORT_GRACE_MS;
     if (withinGrace) return { stale: false, reason: 'awaiting_first_report' };
-    return { stale: true, reason: 'never_reported' };
+    // Not stale — see the 'never_reported' note above. The reason is still returned
+    // so an operator surface can show "we don't know", which is the honest answer.
+    return { stale: false, reason: 'never_reported' };
   }
 
   const boxCommit = toMs(codeCommittedAt);

package/modules/hall-ui/public/box-panel.js

@@ -183,15 +183,28 @@
     function renderBoxActive(box, term, cost) {
       const parts = ['<p class="setup__box-msg setup__box-msg--ok">Your dev box is ready.</p>'];
 
-      // idea 332 / task 1316 (ADR 0072): flag a box running old code. A box too
-      // old to self-update can't be fixed in place — only a rebuild (Close box →
-      // provision fresh) brings it onto current code. Points at the Close button
-      // below. The server decides `stale` (boxes.computeCodeStaleness).
+      // idea 332 / task 1316 (ADR 0072): flag a box running old code. The server
+      // decides `stale` (boxes.computeCodeStaleness), and since task 1002698 it says
+      // so ONLY for reason 'behind' — a box that actually reported a commit far
+      // behind the deployed one. Silence ('never_reported') is an unknown and no
+      // longer flags, so this banner can't fire on a healthy box any more.
+      //
+      // Lead with the CHEAP, NON-DESTRUCTIVE fix. A 'behind' box is reporting, so its
+      // sync cron is alive and a pull usually clears this on its own; closing the box
+      // destroys uncommitted work and costs a fresh spin-up. The old copy named the
+      // rebuild as the ONLY remedy ("It can't update itself"), which sent builders
+      // straight to the destructive option — and while never_reported still flagged,
+      // sent them there in a loop it could never resolve.
       if (box.code && box.code.stale) {
+        const days = Number(box.code.lag_ms) > 0
+          ? Math.floor(Number(box.code.lag_ms) / 86400000) : 0;
         parts.push(
-          '<p class="setup__box-msg setup__box-msg--warn">⚠ This box is running <strong>old code</strong>, '
-          + 'which can break art generation and reconnecting. It can\'t update itself — '
-          + 'use <strong>Close box</strong> below, then provision a fresh one to bring it current.</p>'
+          '<p class="setup__box-msg setup__box-msg--warn">⚠ This box is running <strong>older code</strong>'
+          + (days ? ` (about ${days} day${days === 1 ? '' : 's'} behind)` : '')
+          + ', which can break art generation and reconnecting. '
+          + 'Run <code>/builder-sync</code> in the terminal to pull the latest — that fixes it in place, '
+          + 'and keeps your work. If it is still behind after that, use <strong>Close box</strong> below '
+          + 'and provision a fresh one.</p>'
         );
       }
 

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.58",
+  "version": "1.19.59",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.58",
+      "version": "1.19.59",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.58",
+  "version": "1.19.59",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -543,8 +543,10 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.56 with no explicit bump. run 31542659439. (task 1002620)
 //   1.19.58 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.57 with no explicit bump. run 31546064883. (task 1002620)
+//   1.19.59 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.58 with no explicit bump. run 31547103265. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.58'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.59'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/box_code_staleness.mjs

@@ -42,14 +42,27 @@ t('active + never reported + just provisioned → not stale (awaiting first repo
   assert.equal(r.reason, 'awaiting_first_report');
 });
 
-t('active + never reported + past the provision grace → STALE (never_reported, ancient box)', () => {
+t('active + never reported + past the provision grace → NOT stale (never_reported is an unknown, task 1002698)', () => {
   const r = boxes.computeCodeStaleness({
     state: 'active', provisionedAt: iso(NOW - 13 * DAY), codeReportedAt: null, now: NOW,
   });
-  assert.equal(r.stale, true);
+  assert.equal(r.stale, false);
   assert.equal(r.reason, 'never_reported');
 });
 
+// Regression (task 1002698): the whole fleet reported never_reported because the
+// reporter ADR 0072 specified was never written (task 1002699). Silence must never
+// be enough on its own to tell a builder to destroy a working box.
+t('silence alone never flags a box — a report is required to call it stale', () => {
+  for (const age of [31 * 60 * 1000, 13 * DAY, 400 * DAY]) {
+    const r = boxes.computeCodeStaleness({
+      state: 'active', provisionedAt: iso(NOW - age), codeReportedAt: null,
+      serverCommittedAt: iso(NOW - HOUR), now: NOW,
+    });
+    assert.equal(r.stale, false, `age=${age}`);
+  }
+});
+
 t('active + reported a commit within the lag window → current', () => {
   const r = boxes.computeCodeStaleness({
     state: 'active',