@bongos/core 1.19.579 → 1.19.580

package/tests/adr_renumber_integrity.mjs

@@ -0,0 +1,84 @@
+// tests/adr_renumber_integrity.mjs — a renumbered ADR must move ALL of itself
+// (task 1003681, from a grader finding).
+//
+// Renumbering an ADR is not one edit, it is four, and `fitness.js` only checks
+// two of them (numbers are unique, and the index has one row per file). This
+// pins the other two, plus the class of stale reference that caused the finding.
+//
+// THE INCIDENT. Task 1002972's branch authored ADR 0241 while main landed a
+// DIFFERENT 0241; the collision failed fitness and stranded the PR for four
+// days. Renumbering the never-landed one to 0260 moved its filename, its
+// heading and its index row's link — but left its own session log still saying
+// "ADR 0241" in prose, twice. Because 0241 is a REAL, DIFFERENT, ALREADY-LANDED
+// ADR, that is worse than a dangling link: a reader follows it and arrives,
+// with no error, at the wrong decision. `docs-entropy.js` cannot see this — it
+// resolves LINKS, and these were bare prose references to a number that does
+// resolve, just to something else.
+//
+// What each check would have caught:
+//   • heading vs filename — a rename that forgot the `# ADR NNNN` line
+//   • index row number vs its own link target — a row renumbered IN PLACE
+//     (which is also how the row ended up sorted between 0240 and 0241)
+//   • the session log's references — the finding itself, as a regression pin
+//
+// Run:  node --test --test-reporter=tap tests/adr_renumber_integrity.mjs
+
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const ADR_DIR = path.join(ROOT, 'docs', 'adr');
+
+const adrFiles = fs
+  .readdirSync(ADR_DIR)
+  .filter((f) => f.endsWith('.md') && /^\d{4}-/.test(f))
+  .sort();
+
+test('every ADR file’s heading carries its own number — a rename must move the heading too', () => {
+  assert.ok(adrFiles.length > 200, 'the ADR corpus should be substantial; a tiny count means the glob broke');
+  const wrong = [];
+  for (const f of adrFiles) {
+    const fileNum = /^(\d{4})-/.exec(f)[1];
+    const first = fs.readFileSync(path.join(ADR_DIR, f), 'utf8').split(/\r?\n/)[0];
+    // both conventions ship in this corpus: "# ADR 0259 — …" and "# 0001 — …"
+    const heading = /^#\s*(?:ADR\s*)?(\d{4})\b/.exec(first);
+    if (!heading) { wrong.push(`${f} :: heading carries no number (${first.slice(0, 60)})`); continue; }
+    if (heading[1] !== fileNum) wrong.push(`${f} :: heading says ${heading[1]}`);
+  }
+  assert.deepEqual(wrong, [], 'an ADR whose heading and filename disagree is a half-finished renumber');
+});
+
+test('every index row’s number matches the file it links — a row renumbered in place is caught here', () => {
+  const readme = fs.readFileSync(path.join(ADR_DIR, 'README.md'), 'utf8');
+  const rows = readme.split(/\r?\n/).filter((l) => /^\|\s*\d{4}\s*\|/.test(l));
+  assert.ok(rows.length > 200, 'the index should carry a row per ADR');
+  const wrong = [];
+  for (const row of rows) {
+    const rowNum = /^\|\s*(\d{4})\s*\|/.exec(row)[1];
+    // A row's summary CITES many other ADRs, so the first `](NNNN-….md)` is
+    // usually a citation. The row's OWN target is the one closing its
+    // `[**Title**](…)` cell — i.e. the last link before the trailing category
+    // cell. Matching the first one instead reports ~60 false mismatches.
+    const link = /\]\((\d{4})-[^)]*\.md\)\s*\|[^|]*\|\s*$/.exec(row);
+    if (!link) continue; // a handful of legacy rows link elsewhere or not at all
+    if (link[1] !== rowNum) wrong.push(`row ${rowNum} links ${link[1]}-…`);
+  }
+  assert.deepEqual(wrong, [], 'a row whose number and link disagree sends every citation to the wrong ADR');
+});
+
+test('the ADR that was renumbered out of a collision leaves no reference to its old number (task 1003681)', () => {
+  // The regression itself. 0241 is a real, different, landed ADR — so a stale
+  // reference here resolves silently to the wrong decision rather than 404ing,
+  // which is exactly why no link checker flagged it.
+  const log = path.join(ROOT, 'docs', 'session-logs', '2026-09-03-goal-1000045-applicant-profile-d7.md');
+  const src = fs.readFileSync(log, 'utf8');
+  assert.doesNotMatch(src, /ADR 0241\b/, 'this task’s ADR moved to 0260; 0241 now names the artist-gate decision');
+  assert.match(src, /ADR 0260\b/, 'the log must cite the decision it actually produced');
+  assert.ok(
+    fs.existsSync(path.join(ADR_DIR, '0260-the-application-is-the-consent-and-the-echo-is-the-gate.md')),
+    'and that ADR must exist under the number the log now cites',
+  );
+});