@bongos/core 1.19.565 → 1.19.567

package/tests/projects_hub.mjs

@@ -1449,11 +1449,33 @@ test('the in-flight line reads open_intent only, and re-asks the manifest when t
 test('the settings reads fire on entry + tab return only — never on the in-flight tick', () => {
   assert.match(SCRIPT, /if \(!keepRepo\) loadVisibility\(inst\);/);
   const load = fnHub('loadVisibility');
-  assert.match(load, /\/settings', \{ credentials: 'same-origin' \}/, 'GET /provisioning/instances/:id/settings');
-  assert.match(load, /res\.status === 401 \? signInAgain\(\)/, 'a lapsed session is said as sign-in, not as an outage');
+  assert.match(load, /ensureSettings\(\)/, 'the row comes from the shared reader, not a GET of its own');
+  assert.match(load, /ans\.status === 401 \? signInAgain\(\)/, 'a lapsed session is said as sign-in, not as an outage');
   assert.match(load, /var asked = manageId;/, 'a stale answer must never describe a newer project');
 });
 
+/* One read of the settings row per manage entry (task 1003582). Three cards
+   render three different keys out of the SAME row, and each used to fetch it
+   for itself — three identical round trips per entry, one more with every card
+   added. tests/manage_settings_shared_read.mjs proves the reader's behaviour;
+   this pins that all three cards actually go through it. */
+test('the three settings cards share ONE read of the row per manage entry', () => {
+  const ensure = fnHub('ensureSettings');
+  assert.match(ensure, /\/settings', \{ credentials: 'same-origin' \}/, 'GET /provisioning/instances/:id/settings — the one reader');
+  assert.match(ensure, /if \(settingsPromise && settingsFor === manageId\) return settingsPromise;/,
+    'memoised AND keyed on the project — a switch must never be served the last one’s row');
+  for (const fn of ['loadVisibility', 'loadJoinability', 'loadDoor']) {
+    assert.match(fnHub(fn), /ensureSettings\(\)/, `${fn} reads the row through the shared reader`);
+    assert.doesNotMatch(fnHub(fn), /fetch\(/, `${fn} fires no GET of its own`);
+  }
+  assert.match(SCRIPT, /if \(!keepRepo\) forgetSettings\(\);/,
+    'the memo is dropped on entry + tab return, so neither is ever served a cached row');
+  /* only the READS are shared: each card still writes its own key */
+  for (const fn of ['doVisSave', 'doJoinSave', 'doDoorSave']) {
+    assert.match(fnHub(fn), /method: 'PATCH'/, `${fn} still PATCHes its own key`);
+  }
+});
+
 /* ── how people join (task 1003044): the joinability toggle — the visibility
    section's shape, key for key: the choice from the platform's row, what the
    project runs from its own manifest (brand.project.joinability), the save's