@bongos/core 1.19.561 → 1.19.562

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.561",
-  "core_contract": "1.19.561",
-  "source_commit": "c3f698331dac2a2225920780b219c28b7a354dc6",
+  "core_version": "1.19.562",
+  "core_contract": "1.19.562",
+  "source_commit": "8812128543b799aea8050fb1d51256bbdd0fc717",
   "source_ref": "HEAD",
-  "built_at": "2026-09-06T17:18:36.999Z",
+  "built_at": "2026-09-06T17:33:48.313Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 443,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 2024,
+    "functional_verbatim": 2025,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2491,
-  "tree_sha256": "e6f6d8606c0eeca8894673e7d1e73a986383fab212dc83aedbc0cb8a02f5a631",
+  "file_count": 2492,
+  "tree_sha256": "dc363435f4898d5c74509b25e810a61c1f3a4962b038c4f1c0c1527167e48217",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2657,7 +2657,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "b6fc3c1b36687285aa44544babb749b5dfff005f8fb95428e771302ff2f3fe5e"
+      "sha256": "9c9e6c53ef623de12cdca7cd96dfc2221c19843f45d3a84a196862f4e195c908"
     },
     {
       "path": "docs/modules-contract.md",
@@ -5647,12 +5647,12 @@
     {
       "path": "modules/lifecycle/routes/goal-route-authz.js",
       "mode": "0000644",
-      "sha256": "909686de2d34b184e9676370782e4b07179b784c72eb6db4af22399051b15642"
+      "sha256": "c380ad664c18beff53dd50e9bd5ad9ba78c05c18fae182cc0b0cc8ea41ee1a75"
     },
     {
       "path": "modules/lifecycle/routes/goals.js",
       "mode": "0000644",
-      "sha256": "9bef42b55351651b188e95e254814edd4e845e77cc67bc230960af77d0f6eaa2"
+      "sha256": "9d3079d7f3f610aa5893f02fb4858f73ec98718d6096c423cd52c15d2b30d1ec"
     },
     {
       "path": "modules/lifecycle/routes/help-requests.js",
@@ -7477,12 +7477,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "7dc793d8391910582ab02e387931d90ef58114fc118ed14954d15ee8c4697658"
+      "sha256": "c9fb4551642e3a6cdd1db0e7795805314e2a62b413eb96d2b6ee981146d666c3"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "f70384732bde00c05eeb33f54faa28fcc77df835866cb35df9dcd8f812e01ed7"
+      "sha256": "fe6556a8d666ce01124d6666fd07d7ad01920fe596ca3718398fb4bbcc885465"
     },
     {
       "path": "public-docs/index.html",
@@ -9182,7 +9182,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "84964fd2a837b5f09f4fc45abef8a9eea2e79cc9072292272e4219b6860af9d7"
+      "sha256": "c08cf2ff080e74afdd1c88cb06f4960909b4984bc803f6eeddab57abe14fed79"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -10294,6 +10294,11 @@
       "mode": "0000644",
       "sha256": "1dd92e13f21ed2b029c64d07dcdd6c47aa4f59ce25e288786c4fa7245ba707c5"
     },
+    {
+      "path": "tests/goal_create_version_gate.mjs",
+      "mode": "0000644",
+      "sha256": "addd9fe7179236d24c316923fd47a60947c1a34f9e01eb1a4d47faa49b4fa18f"
+    },
     {
       "path": "tests/goal_criterion_confirm_ui.mjs",
       "mode": "0000644",

package/docs/module-api-changelog.md

@@ -1571,5 +1571,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.559 with no explicit bump. run 34047736326. (task 1002620)
   1.19.561 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.560 with no explicit bump. run 34048169727. (task 1002620)
+  1.19.562 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.561 with no explicit bump. run 34048961786. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/lifecycle/routes/goal-route-authz.js

@@ -15,6 +15,7 @@ const db = require('../db');
 const { isModuleKey, scopeIncludesProtected, moduleKeys } = api.moduleScopeMap;
 const goalScopeCheck = api.goalScopeCheck;
 const { isGoalOwner, authorizeGoalManagement } = require('../goal-authz');
+const { versionAcceptsNewWork } = require('../db-tasks.js');
 const METIC_PLUS = ['metic', 'archon'];
 
 async function isMemberOrArchon(builder, goalId) {
@@ -65,6 +66,62 @@ function goalNotOpenRefusal(goal) {
   };
 }
 
+// authorizeGoalCreate — PURE, FAIL-CLOSED. May a goal be created on this version?
+// (BV1.R03, task 1003591, goal 1000086, ADR 0250 D1.)
+//
+// THE RULE: a version's goal set closes when the version starts BUILDING. New
+// goals go on the `planning` version — that is what a planning version is for,
+// scoping the next one in advance and at leisure. `POST /goals` used to fetch the
+// version row and discard it after the null check, so a goal could be added to a
+// version that had been building for months, which is how a version's scope grew
+// without anyone deciding to widen it.
+//
+// Three answers, ordered fail-closed (an absent or unrecognised version denies):
+//   no version            → 404 version_not_found
+//   not open to work      → 409 version_closed      (shipped, or a status we
+//                                                    cannot vouch for)
+//   building              → 409 version_not_planning (the R07 override admits
+//                                                    ONE named goal, with a reason)
+//   planning              → ok
+//
+// The open-to-work question is `versionAcceptsNewWork` — the same predicate the
+// task-create path uses — rather than a second spelling of the status list, so
+// "a version we can still file into" has one definition. This gate is STRICTER
+// than that predicate on purpose: work may land on a building version, but its
+// SCOPE may not grow. Reusing the predicate for the first question and adding the
+// planning test on top is what keeps those two facts from being confused.
+//
+// `override` is the R07 Archon admission (task 1003594), which is not built yet.
+// It is a parameter here rather than a later edit to the signature so that R07
+// wires a decision in without reopening this ordering: pass true and a building
+// version is accepted. It does NOT bypass version_closed — a shipped version is
+// closed history, and no override makes it writable again.
+function authorizeGoalCreate({ version, override = false }) {
+  if (!version) {
+    return { ok: false, status: 404, body: {
+      error: 'version_not_found', message: 'No such version.',
+    } };
+  }
+  if (!versionAcceptsNewWork(version.status)) {
+    return { ok: false, status: 409, body: {
+      error: 'version_closed', status: version.status,
+      // Says which status refused rather than asserting 'shipped': the predicate
+      // is fail-closed, so it also catches null and any status added later, and
+      // telling someone their planning-adjacent version "has shipped" would be a
+      // confident lie about state they can see for themselves.
+      message: version.status === 'shipped'
+        ? `Version '${version.id}' has shipped — it is closed history and cannot take new goals.`
+        : `Version '${version.id}' is '${version.status}', which is not a state that takes new goals.`,
+    } };
+  }
+  if (version.status !== 'planning' && override !== true) {
+    return { ok: false, status: 409, body: {
+      error: 'version_not_planning', status: version.status,
+      message: `Version '${version.id}' is already building — its goal set is closed. Scope this goal onto the planning version instead, or ask an Archon to admit it with a reason.`,
+    } };
+  }
+  return { ok: true };
+}
 function authorizeGoalTaskCreate({ goal, version, isMember, builderRank, touches }) {
   if (!goal) {
     return { ok: false, status: 404, body: { error: 'goal_not_found' } };
@@ -458,6 +515,7 @@ function decorateGoalScope(goal) {
 
 module.exports = {
   authorizeCreateJoinRequest,
+  authorizeGoalCreate,
   authorizeGoalTaskCreate,
   authorizeInvitationAccept,
   authorizeInvitationResponse,

package/modules/lifecycle/routes/goals.js

@@ -63,7 +63,7 @@ const JOIN_REQUEST_RESPONSE_ACTIONS = ['approve', 'deny']; // an owner/manager/A
 // proceed; a false result means "not a member" → the route should 403. This is the
 // membership half of the wall; the protected-module rank check is enforced per-route
 // (scope is never self-granted).
-const { authorizeCreateJoinRequest, authorizeGoalTaskCreate, authorizeInvitationAccept, authorizeInvitationResponse, authorizeJoinRequestResponse, authorizeMembershipKindChange, authorizeOwnershipTransfer, authorizeRescindInvitation, authorizeWithdrawJoinRequest, decorateGoalScope, isMemberOrArchon, protectedScopeAdmissionBlock } = require('./goal-route-authz.js');
+const { authorizeCreateJoinRequest, authorizeGoalCreate, authorizeGoalTaskCreate, authorizeInvitationAccept, authorizeInvitationResponse, authorizeJoinRequestResponse, authorizeMembershipKindChange, authorizeOwnershipTransfer, authorizeRescindInvitation, authorizeWithdrawJoinRequest, decorateGoalScope, isMemberOrArchon, protectedScopeAdmissionBlock } = require('./goal-route-authz.js');
 // task 1003208: structured logging (pino via the doorway) — was console.*.
 const log = api.logger('lifecycle');
 module.exports = function buildGoalsRouter() {
@@ -99,8 +99,13 @@ module.exports = function buildGoalsRouter() {
 
     try {
       const version = await db.getVersion(req.body.version_id);
-      if (!version) {
-        return res.fail('version_not_found', { status: 404, message: 'No such version.' });
+      // BV1.R03 (task 1003591, goal 1000086, ADR 0250 D1): the version row was
+      // fetched and then discarded after the null check — its status was never
+      // read, so a goal could be added to a version that had been building for
+      // months. The ordered, DB-free gate answers all of it, including the 404.
+      const versionDecision = authorizeGoalCreate({ version });
+      if (!versionDecision.ok) {
+        return res.status(versionDecision.status).json(versionDecision.body);
       }
       // Rescope carry-forward (ADR 0086 §6 / BV1.R64): a new-version goal may declare
       // the (achieved) goal it continues. Validate the predecessor exists BEFORE

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.561",
+  "version": "1.19.562",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.561",
+      "version": "1.19.562",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.561",
+  "version": "1.19.562",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -49,7 +49,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.561'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.562'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/goal_create_version_gate.mjs

@@ -0,0 +1,136 @@
+// tests/goal_create_version_gate.mjs — a version's goal set closes when the
+// version starts building (BV1.R03, task 1003591, goal 1000086, ADR 0250 D1).
+//
+// THE HOLE. `POST /goals` fetched the version row and discarded it after the null
+// check. `version.status` was never read, so a goal could be added to a version
+// that had been building for months — which is how a version's scope grows
+// without anyone deciding to widen it, and why 64 goals accumulated on
+// BONGOS-V1. New goals belong on the `planning` version: that is what a planning
+// version is FOR, scoping the next one in advance.
+//
+// The gate is pure and DB-free (the `authorizeGoalTaskCreate` precedent), so its
+// whole truth table is exercised here without a database, and the route's only
+// job is to render the decision.
+//
+// Run:  node --test tests/goal_create_version_gate.mjs
+
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { readFileSync } from 'node:fs';
+import { createRequire } from 'node:module';
+
+process.env.NODE_ENV = 'test';
+const require = createRequire(import.meta.url);
+const { authorizeGoalCreate } = require('../modules/lifecycle/routes/goal-route-authz.js');
+const { versionAcceptsNewWork } = require('../modules/lifecycle/db-tasks.js');
+
+const V = (status) => ({ id: 'BONGOS-V1', status });
+const decide = (version, override) => authorizeGoalCreate({ version, override });
+
+// ---- the truth table --------------------------------------------------------
+
+test('planning accepts — that is what a planning version is for', () => {
+  assert.deepEqual(decide(V('planning')), { ok: true });
+});
+
+test('building refuses with a named 409 an agent can act on', () => {
+  const d = decide(V('building'));
+  assert.equal(d.ok, false);
+  assert.equal(d.status, 409);
+  assert.equal(d.body.error, 'version_not_planning');
+  assert.equal(d.body.status, 'building', 'the caller learns WHICH state refused');
+  assert.match(d.body.message, /planning version/,
+    'and where the goal should go instead — a refusal with no next move gets routed around');
+});
+
+test('shipped refuses as closed history, not as "not planning"', () => {
+  // Two different facts deserve two different codes: a building version might
+  // still admit this goal via an Archon override; a shipped one never will.
+  const d = decide(V('shipped'));
+  assert.equal(d.body.error, 'version_closed');
+  assert.match(d.body.message, /has shipped/);
+});
+
+test('a missing version is a 404, before any status reasoning', () => {
+  const d = decide(null);
+  assert.equal(d.status, 404);
+  assert.equal(d.body.error, 'version_not_found');
+});
+
+test('FAIL-CLOSED: a status nobody taught this gate about refuses', () => {
+  // A version status added later must not default to "sure, file it here".
+  for (const status of ['paused', 'draft', '', undefined, null, 42]) {
+    const d = decide(V(status));
+    assert.equal(d.ok, false, `'${String(status)}' must not be accepted`);
+    assert.equal(d.body.error, 'version_closed');
+  }
+});
+
+test('an unrecognised status is NOT described as shipped', () => {
+  // The fail-closed arm catches more than `shipped`, and telling someone their
+  // version "has shipped" when it says 'paused' is a confident lie about state
+  // they can see for themselves.
+  const d = decide(V('paused'));
+  assert.match(d.body.message, /is 'paused'/);
+  assert.equal(/has shipped/.test(d.body.message), false);
+});
+
+// ---- the override seam (R07 is not built yet) -------------------------------
+
+test('override admits a building version — the R07 seam, already shaped', () => {
+  assert.deepEqual(decide(V('building'), true), { ok: true });
+});
+
+test('override does NOT reopen a shipped version', () => {
+  // The escape hatch is for a scope decision, not for rewriting closed history.
+  assert.equal(decide(V('shipped'), true).body.error, 'version_closed');
+  assert.equal(decide(V('paused'), true).body.error, 'version_closed');
+});
+
+test('only a literal true overrides — a truthy value does not', () => {
+  for (const v of ['yes', 1, {}, [] ]) {
+    assert.equal(decide(V('building'), v).ok, false,
+      'a JSON body coercing to truthy must not open the gate');
+  }
+});
+
+// ---- one definition of "open to work" ---------------------------------------
+
+test('the gate reuses versionAcceptsNewWork rather than respelling the statuses', () => {
+  const src = readFileSync(new URL('../modules/lifecycle/routes/goal-route-authz.js', import.meta.url), 'utf8');
+  const body = src.slice(src.indexOf('function authorizeGoalCreate'), src.indexOf('function authorizeGoalTaskCreate'));
+  assert.match(body, /versionAcceptsNewWork\(version\.status\)/);
+  assert.equal(/'shipped'\s*,\s*'planning'|new Set\(\[/.test(body), false,
+    'no second copy of the status list lives in this gate');
+});
+
+test('the gate is STRICTER than versionAcceptsNewWork, deliberately', () => {
+  // Work may still LAND on a building version; its SCOPE may not grow. Those are
+  // two different questions and this pins that they give different answers.
+  assert.equal(versionAcceptsNewWork('building'), true, 'tasks may still be filed');
+  assert.equal(decide(V('building')).ok, false, 'but a new goal may not');
+  assert.equal(versionAcceptsNewWork('planning'), true);
+  assert.equal(decide(V('planning')).ok, true);
+});
+
+// ---- the route renders the decision and nothing else ------------------------
+
+test('POST /goals consults the gate and returns its exact status + body', () => {
+  const src = readFileSync(new URL('../modules/lifecycle/routes/goals.js', import.meta.url), 'utf8');
+  const start = src.indexOf("router.post('/goals'");
+  assert.notEqual(start, -1);
+  const body = src.slice(start, src.indexOf('router.', start + 20));
+  assert.match(body, /const versionDecision = authorizeGoalCreate\(\{ version \}\);/);
+  assert.match(body, /return res\.status\(versionDecision\.status\)\.json\(versionDecision\.body\);/,
+    'the route renders the decision, it does not re-derive one');
+  assert.equal(/version\.status\s*[=!]==/.test(body), false,
+    'and it must not compare the status itself — that is the gate\'s job');
+});
+
+test('the 404 moved INTO the gate, so the route has no second version check', () => {
+  const src = readFileSync(new URL('../modules/lifecycle/routes/goals.js', import.meta.url), 'utf8');
+  const start = src.indexOf("router.post('/goals'");
+  const body = src.slice(start, src.indexOf('router.', start + 20));
+  assert.equal(/if \(!version\)/.test(body), false,
+    'one ordered decision, not a null check here and a status check there');
+});