@bongos/core 1.19.560 → 1.19.561

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.560",
-  "core_contract": "1.19.560",
-  "source_commit": "a65212ce04681b336f274effbd8962cf32ac11b2",
+  "core_version": "1.19.561",
+  "core_contract": "1.19.561",
+  "source_commit": "c3f698331dac2a2225920780b219c28b7a354dc6",
   "source_ref": "HEAD",
-  "built_at": "2026-09-06T17:10:29.635Z",
+  "built_at": "2026-09-06T17:18:36.999Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 443,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 2023,
+    "functional_verbatim": 2024,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2490,
-  "tree_sha256": "7c9bed5bb4565d0f0fdc718c676b3af9993ddf1a8c7ea463815469c4c24d38f5",
+  "file_count": 2491,
+  "tree_sha256": "e6f6d8606c0eeca8894673e7d1e73a986383fab212dc83aedbc0cb8a02f5a631",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2657,7 +2657,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "56724ff4d04be88dd0a7a1f938d1620d71f843f5f3bc951b5b913e64f7794e08"
+      "sha256": "b6fc3c1b36687285aa44544babb749b5dfff005f8fb95428e771302ff2f3fe5e"
     },
     {
       "path": "docs/modules-contract.md",
@@ -5432,7 +5432,7 @@
     {
       "path": "modules/lifecycle/db-goals.js",
       "mode": "0000644",
-      "sha256": "abba32642e123860fee7b33fe429294783480afd2e25a78f63f9d4af3b1613e8"
+      "sha256": "16c5f2ed9ae4b70a30eb47a4864c4ad6273afbe19e925edcac5f9d965e670f24"
     },
     {
       "path": "modules/lifecycle/db-grade.js",
@@ -5472,7 +5472,7 @@
     {
       "path": "modules/lifecycle/db.js",
       "mode": "0000644",
-      "sha256": "df5de732d9484e1bcf801c657c78b618d1a0353a912cdb1ee4fdd2c9f121749c"
+      "sha256": "e7f65fbc43a0963ab6a7e6d25e0b52521f46b82f05115ffef80ea64d9e9fac81"
     },
     {
       "path": "modules/lifecycle/dead-deps.js",
@@ -5652,7 +5652,7 @@
     {
       "path": "modules/lifecycle/routes/goals.js",
       "mode": "0000644",
-      "sha256": "1729e085b7d83b2e4579ada11ab2b51f75a9f92686cc1d48a19f34a839fe5b73"
+      "sha256": "9bef42b55351651b188e95e254814edd4e845e77cc67bc230960af77d0f6eaa2"
     },
     {
       "path": "modules/lifecycle/routes/help-requests.js",
@@ -7477,12 +7477,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "9c4d3a611995e84c828f539bf2f87ca6a92b6c165cffc4754e985513b1010080"
+      "sha256": "7dc793d8391910582ab02e387931d90ef58114fc118ed14954d15ee8c4697658"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "3816fc5ab250ecfa35f68b9383e6357d900be8ddca3d3f6ae643fb48a2c5edca"
+      "sha256": "f70384732bde00c05eeb33f54faa28fcc77df835866cb35df9dcd8f812e01ed7"
     },
     {
       "path": "public-docs/index.html",
@@ -9182,7 +9182,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "6a833a6e4e92f2675ea5e5a66a8134cb087bba01f6bba371109c953649535f0a"
+      "sha256": "84964fd2a837b5f09f4fc45abef8a9eea2e79cc9072292272e4219b6860af9d7"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -10264,6 +10264,11 @@
       "mode": "0000644",
       "sha256": "b8c179ae6c5ad962356e5d82a5c6aa89bd523913de10799e53de16279404d07d"
     },
+    {
+      "path": "tests/goal_archive_disposition.mjs",
+      "mode": "0000644",
+      "sha256": "d2056a3ae84b79d64409e6e43c477f6b160f202903be61710b40bc4fd06c00c9"
+    },
     {
       "path": "tests/goal_category.mjs",
       "mode": "0000644",

package/docs/module-api-changelog.md

@@ -1569,5 +1569,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.558 with no explicit bump. run 34047187381. (task 1002620)
   1.19.560 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.559 with no explicit bump. run 34047736326. (task 1002620)
+  1.19.561 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.560 with no explicit bump. run 34048169727. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/lifecycle/db-goals.js

@@ -324,6 +324,35 @@ async function listGoalMembers(goalId, deps = {}) {
 // "linked criteria" half of GET /goals/:id; projection matches done-when.js's
 // listCriteria so the hall renders goal + version criteria identically.
 
+// openTasksInGoal — the work a goal is still holding, newest-blocking-first, for
+// the archive preview (BV1.R10, task 1003597, goal 1000086, ADR 0250 D3).
+//
+// Archiving used to be a single call that checked only whether the goal was
+// ALREADY archived — no criterion check and no task check — which is how goal
+// 1000018 was archived with all seven of its tasks still open. It is the hole
+// that bypasses the R08/R09 closure rule entirely: the rule guards `achieved`,
+// and archive is the other way out.
+//
+// "Still holding" is the same question the closure rule asks — non-terminal per
+// task-status.js, smoke fixtures excluded — so a goal cannot be refused for work
+// that would not have held it open on the achieve path. `cap` bounds the returned
+// rows (the caller renders them); `total` is the true count, so a goal holding
+// forty tasks reports forty and shows the first few.
+async function openTasksInGoal(goalId, { cap = 50 } = {}, deps = {}) {
+  const activePool = (deps.pool && process.env.NODE_ENV === 'test') ? deps.pool : pool;
+  const { rows } = await activePool.query(
+    `SELECT t.id::text, t.title, t.status,
+            count(*) OVER ()::int AS total
+       FROM tasks t
+      WHERE t.goal_id = $1
+        AND ${nonTerminalSql()}
+        AND ${SMOKE_NOT_LIKE.replace(/title/, 't.title')}
+      ORDER BY t.id
+      LIMIT $2`,
+    [goalId, cap]
+  );
+  return { total: rows[0]?.total ?? 0, tasks: rows.map(({ total, ...t }) => t) };
+}
 async function listCriteriaForGoal(goalId, deps = {}) {
   const activePool = (deps.pool && process.env.NODE_ENV === 'test') ? deps.pool : pool;
   // task 1002164: carry the linked-task counts so the caller can derive the
@@ -784,6 +813,7 @@ module.exports = {
   isGoalMember,
   listActiveClaimsForTasks,
   listCriteriaForGoal,
+  openTasksInGoal,
   listGoalMembers,
   listGoals,
   listInboxFor,

package/modules/lifecycle/db.js

@@ -78,6 +78,7 @@ const {
   isGoalMember,
   listActiveClaimsForTasks,
   listCriteriaForGoal,
+  openTasksInGoal,
   listGoalMembers,
   listGoals,
   listInboxFor,
@@ -243,6 +244,7 @@ module.exports = {
   listInboxFor,
   listPendingRequestsForGoal,
   listCriteriaForGoal,
+  openTasksInGoal,
   createTask,
   generalGoalIdForVersion,
   findTaskBySourceRef,

package/modules/lifecycle/routes/goals.js

@@ -1048,6 +1048,28 @@ module.exports = function buildGoalsRouter() {
       if (goal.status === 'archived') {
         return res.fail('already_archived', 409);
       }
+      // BV1.R10 (task 1003597, goal 1000086, ADR 0250 D3): archive is the OTHER
+      // way out of a goal, and it checked nothing — which is how goal 1000018 was
+      // archived with all seven of its tasks still open. R08/R09 guard `achieved`;
+      // without this, anyone refused there could archive instead and the work
+      // would vanish from every rollup just the same.
+      //
+      // The refusal RETURNS the work rather than merely naming a count, because
+      // the caller's next move is to decide what happens to each task — and an
+      // agent that has to go fetch the list first will guess instead. Applying a
+      // disposition (abandon with the archive's reason, or move to a named
+      // surviving goal) is task 1003601 (R14); until then the honest answer is
+      // "not without saying what happens to these", not a silent discard.
+      //
+      // A goal holding nothing open stays a single call, unchanged.
+      const held = await db.openTasksInGoal(id);
+      if (held.total > 0) {
+        return res.fail('goal_holds_open_tasks', {
+          status: 409,
+          message: `Goal #${id} still holds ${held.total} unfinished task(s). Ship or abandon them, or move them to another goal, before archiving it.`,
+          details: { total: held.total, shown: held.tasks.length, tasks: held.tasks },
+        });
+      }
       const updated = await db.setGoalStatus({ goalId: id, status: 'archived' });
       return res.json({ ok: true, goal: updated });
     } catch (err) {

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.560",
+  "version": "1.19.561",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.560",
+      "version": "1.19.561",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.560",
+  "version": "1.19.561",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -49,7 +49,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.560'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.561'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/goal_archive_disposition.mjs

@@ -0,0 +1,144 @@
+// tests/goal_archive_disposition.mjs — archiving a goal is a recorded decision,
+// not a silent discard (BV1.R10, task 1003597, goal 1000086, ADR 0250 D3).
+//
+// THE HOLE. `POST /goals/:id/archive` refused exactly one thing: a goal that was
+// ALREADY archived. No criterion check, no task check. R08/R09 guard the flip to
+// `achieved`, so archive was the other way out — anyone refused there could
+// archive instead and the work disappeared from every rollup just the same. Goal
+// 1000018 went that way with all seven of its tasks still open.
+//
+// "Still holding" must be the SAME question the closure rule asks — non-terminal
+// per task-status.js, smoke fixtures excluded — or the two doors disagree about
+// what unfinished means and a goal is refused here for work that would not have
+// held it open there. That equivalence is what most of this file pins.
+//
+// Run:  node --test tests/goal_archive_disposition.mjs
+
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { readFileSync } from 'node:fs';
+import { createRequire } from 'node:module';
+import { makeSqlAwareClient } from './helpers.mjs';
+
+process.env.NODE_ENV = 'test';
+const require = createRequire(import.meta.url);
+const { openTasksInGoal } = require('../modules/lifecycle/db.js');
+const { TERMINAL_STATUSES } = require('../modules/lifecycle/task-status.js');
+
+const src = (rel) => readFileSync(new URL('../' + rel, import.meta.url), 'utf8');
+
+function fakePool(handler) {
+  const c = makeSqlAwareClient(handler);
+  return { query: (sql, params) => c._client.query(sql, params), connect: c.connect, queries: c._client.queries };
+}
+
+// The archive handler slice, so assertions land on the right route.
+const GOALS = src('modules/lifecycle/routes/goals.js');
+const ARCHIVE = (() => {
+  const a = GOALS.indexOf("router.post('/goals/:id/archive'");
+  assert.notEqual(a, -1, 'archive route not found');
+  const b = GOALS.indexOf("router.post('/goals/:id/reopen'", a);
+  assert.notEqual(b, -1, 'reopen route should follow archive');
+  return GOALS.slice(a, b);
+})();
+
+// ---- the read ---------------------------------------------------------------
+
+test('openTasksInGoal asks the SAME question the closure rule asks', async () => {
+  let seen = null;
+  const pool = fakePool((s) => { seen = s; return { rows: [] }; });
+  await openTasksInGoal(77, {}, { pool });
+  assert.match(seen, /FROM tasks t WHERE t\.goal_id = \$1/);
+  assert.match(seen, /t\.status NOT IN \('shipped', 'abandoned'\)/,
+    'the terminal set is task-status.js\'s, not a fourth hand-typed copy');
+  assert.match(seen, /t\.title NOT LIKE/,
+    'a smoke fixture must not be able to block an archive either');
+});
+
+test('openTasksInGoal reports the TRUE total even when it returns a capped page', async () => {
+  // A goal holding forty tasks must say forty. Returning only the page length
+  // would understate the decision the caller is about to make.
+  const rows = [
+    { id: '1', title: 'a', status: 'backlog', total: 40 },
+    { id: '2', title: 'b', status: 'ready', total: 40 },
+  ];
+  const pool = fakePool(() => ({ rows }));
+  const out = await openTasksInGoal(77, { cap: 2 }, { pool });
+  assert.equal(out.total, 40, 'the window count is the real total');
+  assert.equal(out.tasks.length, 2, 'and the page is what was asked for');
+  assert.deepEqual(Object.keys(out.tasks[0]), ['id', 'title', 'status'],
+    'the window column is stripped from the rows the caller renders');
+});
+
+test('openTasksInGoal binds the cap rather than interpolating it', async () => {
+  const pool = fakePool(() => ({ rows: [] }));
+  await openTasksInGoal(77, { cap: 5 }, { pool });
+  assert.deepEqual(pool.queries[0].params, [77, 5]);
+  assert.match(String(pool.queries[0].sql), /LIMIT \$2/);
+});
+
+test('an empty goal reports nothing held — the single-call path stays open', async () => {
+  const pool = fakePool(() => ({ rows: [] }));
+  const out = await openTasksInGoal(77, {}, { pool });
+  assert.deepEqual(out, { total: 0, tasks: [] });
+});
+
+// ---- the route --------------------------------------------------------------
+
+test('archive refuses with a NAMED 409 when the goal holds open work', () => {
+  assert.match(ARCHIVE, /const held = await db\.openTasksInGoal\(id\);/,
+    'the archive route must consult the work before discarding it');
+  assert.match(ARCHIVE, /res\.fail\('goal_holds_open_tasks', \{[\s\S]*?status: 409/,
+    'a named code an agent can branch on, not a bare 409');
+});
+
+test('the refusal RETURNS the tasks, so the caller can decide without a second fetch', () => {
+  assert.match(ARCHIVE, /details: \{ total: held\.total, shown: held\.tasks\.length, tasks: held\.tasks \}/,
+    'an agent that has to go fetch the list will guess instead');
+});
+
+test('the check runs AFTER identity/authorization and BEFORE the status write', () => {
+  const auth = ARCHIVE.indexOf('isMemberOrArchon');
+  const already = ARCHIVE.indexOf("'already_archived'");
+  const gate = ARCHIVE.indexOf('openTasksInGoal');
+  const write = ARCHIVE.indexOf('db.setGoalStatus');
+  assert.ok(auth !== -1 && already !== -1 && gate !== -1 && write !== -1, 'all four landmarks present');
+  assert.ok(auth < gate, 'a non-member must not learn what a goal is holding');
+  assert.ok(already < gate, 're-archiving an archived goal keeps its own answer');
+  assert.ok(gate < write, 'a refusal after the write is not a refusal');
+});
+
+test('archiving a goal that holds nothing is still ONE call', () => {
+  // The guard must not turn the ordinary case into a two-step. There is exactly
+  // one setGoalStatus in this handler and no second round trip in front of it.
+  assert.equal((ARCHIVE.match(/db\.setGoalStatus/g) || []).length, 1);
+  assert.equal(/disposition_required|preview=/.test(ARCHIVE), false,
+    'no extra confirm parameter on the empty-goal path');
+});
+
+// ---- the two doors agree ----------------------------------------------------
+
+test('archive and achieve mean the same thing by "unfinished"', () => {
+  // If these drift, a goal is refused on one door for work the other would have
+  // let through — the confusing half of a rule people then route around.
+  const dbGoals = src('modules/lifecycle/db-goals.js');
+  const openTasks = dbGoals.slice(dbGoals.indexOf('async function openTasksInGoal'));
+  const achieve = dbGoals.slice(dbGoals.indexOf('async function achieveGoalIfComplete'));
+  for (const [name, body] of [['openTasksInGoal', openTasks], ['achieveGoalIfComplete', achieve]]) {
+    assert.match(body, /\$\{nonTerminalSql\(\)\}/, name + ' must read the shared terminal set');
+    assert.match(body, /SMOKE_NOT_LIKE\.replace/, name + ' must exclude smoke rows');
+  }
+});
+
+test('every non-terminal status is one the archive gate would catch', () => {
+  // Stated as data rather than prose: the statuses that hold a goal open are
+  // exactly the ones absent from the terminal set, and archive filters on that
+  // same set, so the enumeration cannot drift out of step with the constant.
+  const HOLDS_OPEN = ['backlog', 'ready', 'blocked', 'active', 'completed', 'confirmed'];
+  for (const s of HOLDS_OPEN) {
+    assert.equal(TERMINAL_STATUSES.includes(s), false,
+      `'${s}' must not be terminal — it is unfinished work an archive would discard`);
+  }
+  assert.deepEqual([...TERMINAL_STATUSES].sort(), ['abandoned', 'shipped'],
+    'and the terminal set is exactly the two deliberate endings');
+});