@bongos/core 1.19.558 → 1.19.560

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.558",
-  "core_contract": "1.19.558",
-  "source_commit": "3f1c35f7e8595d597e7174a4b57801739138e35a",
+  "core_version": "1.19.560",
+  "core_contract": "1.19.560",
+  "source_commit": "a65212ce04681b336f274effbd8962cf32ac11b2",
   "source_ref": "HEAD",
-  "built_at": "2026-09-06T16:50:32.542Z",
+  "built_at": "2026-09-06T17:10:29.635Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 443,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 2020,
+    "functional_verbatim": 2023,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2487,
-  "tree_sha256": "cf1dadb6f0fb444dffe307f0e5b6d7ad76eb9e3fc7833a3e034f456f45ecf4c3",
+  "file_count": 2490,
+  "tree_sha256": "7c9bed5bb4565d0f0fdc718c676b3af9993ddf1a8c7ea463815469c4c24d38f5",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2657,7 +2657,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "7fd202776ba59c21897773679f9f07221de79ba577a6d5e6500df52698b85386"
+      "sha256": "56724ff4d04be88dd0a7a1f938d1620d71f843f5f3bc951b5b913e64f7794e08"
     },
     {
       "path": "docs/modules-contract.md",
@@ -7477,12 +7477,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "3d98dfe15e37d556fbb8b69fe49aefaa10ffb350560704361a420803e5bd1169"
+      "sha256": "9c4d3a611995e84c828f539bf2f87ca6a92b6c165cffc4754e985513b1010080"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "94d2145a407d981305d11aa4f7b6fcb2997d831856b978836ceece7f91f48de5"
+      "sha256": "3816fc5ab250ecfa35f68b9383e6357d900be8ddca3d3f6ae643fb48a2c5edca"
     },
     {
       "path": "public-docs/index.html",
@@ -7917,7 +7917,7 @@
     {
       "path": "scripts/gds/fitness-ratchets.js",
       "mode": "0000644",
-      "sha256": "fa16d4c62a16b7827fe82d556dd6a5de327362ba17fc54cc9d86e1d34e2a45f5"
+      "sha256": "40f6cb65333235d35f6672c700ec91648549e57912ee7f522cff80af4b611fc2"
     },
     {
       "path": "scripts/gds/fitness.js",
@@ -7954,6 +7954,11 @@
       "mode": "0000644",
       "sha256": "26a3dcc15c98128229df015292b8f9e9d3a41152c8803555f858fa4bb6a26d53"
     },
+    {
+      "path": "scripts/gds/gds-literal-scan.js",
+      "mode": "0000644",
+      "sha256": "fe622c9abf848a668fe2672d699fef22141156f41bb2396523461d1484341ec1"
+    },
     {
       "path": "scripts/gds/gen-api-client.js",
       "mode": "0000644",
@@ -9177,7 +9182,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "8e9e2a140d38ec1307d8c062aeb950ee5cadc17a0a166d5e96ec41f3b202c375"
+      "sha256": "6a833a6e4e92f2675ea5e5a66a8134cb087bba01f6bba371109c953649535f0a"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -10159,6 +10164,11 @@
       "mode": "0000644",
       "sha256": "5e5b53d5a1dce6b7ffacbea7198375aac6f77259ee948c00c24eb157f62a034d"
     },
+    {
+      "path": "tests/fitness_gds_ratchet.mjs",
+      "mode": "0000644",
+      "sha256": "10b3d6db55dd8d20de69fe8757575cf965ca8a14e91512c2f7b71b62ba3af855"
+    },
     {
       "path": "tests/fitness_ratchets.mjs",
       "mode": "0000644",
@@ -10269,6 +10279,11 @@
       "mode": "0000644",
       "sha256": "8d1f3511b8ecd0bb88f75a936ee29035d9f789a2be4f6aedabb46b9be5bd2385"
     },
+    {
+      "path": "tests/goal_closure_invariants.mjs",
+      "mode": "0000644",
+      "sha256": "eace8ebcf39f40683bf9cbcfbc0e554b115e73d1f72894ca57a89e82d119d357"
+    },
     {
       "path": "tests/goal_conflicts.mjs",
       "mode": "0000644",

package/docs/module-api-changelog.md

@@ -1565,5 +1565,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.556 with no explicit bump. run 34045753301. (task 1002620)
   1.19.558 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.557 with no explicit bump. run 34046699120. (task 1002620)
+  1.19.559 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.558 with no explicit bump. run 34047187381. (task 1002620)
+  1.19.560 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.559 with no explicit bump. run 34047736326. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.558",
+  "version": "1.19.560",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.558",
+      "version": "1.19.560",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.558",
+  "version": "1.19.560",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/fitness-ratchets.js

@@ -276,6 +276,17 @@ function readBaselines() {
 }
 
 // Pure ratchet verdict — exported for the hermetic test.
+// A metric whose name does not, by itself, tell the builder who tripped it what
+// to do gets one line of guidance here. Appended to the regression message only
+// — the ratchet-down warning already says exactly what to do.
+const METRIC_HINTS = {
+  legacy_gds_literals:
+    ' — a NEW "GDS" literal entered the tree (goal 1000073 C5: the rename cannot come back). '
+    + 'Write Bongos instead. Run `node scripts/gds/gds-literal-scan.js` to see every counted file. '
+    + 'Version ids (GDS-V##), docs/adr, docs/session-logs, docs/audits, limitations and migrations '
+    + 'are excluded by construction — if your literal is history, it belongs in one of those.',
+};
+
 function compareToBaselines(metrics, baselines) {
   const violations = [];
   const warnings = [];
@@ -285,7 +296,7 @@ function compareToBaselines(metrics, baselines) {
     if (floor === undefined) {
       warnings.push(`no baseline for "${name}" (value ${value}) — run --update-baselines`);
     } else if (value > floor) {
-      violations.push(`${name} regressed: ${value} > baseline ${floor} — fix the regression; never raise the baseline to pass`);
+      violations.push(`${name} regressed: ${value} > baseline ${floor} — fix the regression; never raise the baseline to pass${METRIC_HINTS[name] || ''}`);
     } else if (value < floor) {
       warnings.push(`ratchet-down available: ${name} improved to ${value} (baseline ${floor}) — lower the baseline in config/fitness-baselines.json`);
     }
@@ -293,6 +304,19 @@ function compareToBaselines(metrics, baselines) {
   return { violations, warnings };
 }
 
+// legacy_gds_literals — criterion C5 of goal 1000073, "the rename cannot come
+// back" (task 1003669). A shrink-only count of the GDS acronym outside the
+// frozen record, so a NEW literal reds the build the way any other regression
+// does. It rides the ratchet machinery rather than being its own check on
+// purpose: --update-baselines, the floors, and baseline-staleness then all
+// apply to it for free, and a metric outside `metrics` would be silently
+// dropped the next time anyone refreshed the file. Detector + the reasons for
+// every exclusion: scripts/gds/gds-literal-scan.js.
+function gdsMetrics() {
+  const { scanGdsLiterals } = require('./gds-literal-scan.js');
+  return { legacy_gds_literals: scanGdsLiterals().total };
+}
+
 function computeMetrics({ withDocs = true } = {}) {
   const files = trackedJsFiles();
   const contents = new Map(files.map((f) => [f, readRepoFile(f)]));
@@ -301,6 +325,7 @@ function computeMetrics({ withDocs = true } = {}) {
     duplicate_window_count: duplicateWindowCount(contents),
     require_cycle_count: countCycles(requireGraph(contents)),
     console_call_count: consoleCallCount(contents),
+    ...gdsMetrics(),
     ...(withDocs ? docMetrics() : {}),
   };
 }
@@ -314,7 +339,7 @@ function checkQualityRatchets() {
   // FIRST so it is the headline rather than buried under per-metric noise.
   if (baselineError) violations.unshift(baselineError);
   return {
-    name: 'quality ratchets — size, duplication, cycles, console, doc entropy only tighten (task 1003129)',
+    name: 'quality ratchets — size, duplication, cycles, console, doc entropy, legacy GDS literals only tighten (task 1003129)',
     hardFail: violations.length > 0,
     violations,
     warnings,

package/scripts/gds/gds-literal-scan.js

@@ -0,0 +1,162 @@
+#!/usr/bin/env node
+'use strict';
+// gds-literal-scan.js — the detector behind the GDS→Bongos rename ratchet
+// (criterion C5 of goal 1000073, "the rename cannot come back"; task 1003669).
+//
+// WHY THIS EXISTS. The rename is landing criterion by criterion, and the goal's
+// own sequencing says the ratchet lands SECOND — immediately after the prose
+// pass — because "a rename without a ratchet reappears within a release, which
+// is exactly how this term survived this long". This module is the measurement;
+// the gate is the `legacy_gds_literals` metric in fitness-ratchets.js, which
+// fails the build when the count RISES.
+//
+// WHY A COUNT AND NOT ZERO. Measured after C1 shipped (2026-09-06) there are
+// still ~1,400 GDS literals outside the historical record: the `GDS_*` env
+// names and the `scripts/gds/` + `/api/gds` paths are criterion C2's job, and
+// C2 deliberately lands BEHIND this ratchet because it is the risky one (hooks,
+// cron routines, .service files and CI all name those paths). A zero-tolerance
+// check could not be landed today and would red every unrelated ship. So this
+// holds the line instead: the number may fall, never rise.
+//
+// WHAT IS NEVER COUNTED. Four kinds of thing, for four different reasons:
+//
+//   1. THE FROZEN RECORD (path-excluded). ADRs, session logs, audits, shipped
+//      scope archives. The goal's rule is "rename what the project says about
+//      itself going forward; leave what it recorded about its past" — an ADR
+//      rewritten to today's vocabulary destroys the evidence that the words
+//      changed.
+//   2. APPLIED MIGRATION FILENAMES (path-excluded). schema_migrations is keyed
+//      by filename stem, so renaming an applied migration makes it look
+//      unapplied and RE-RUNS it. This one is an outage, not an aesthetic.
+//   3. VERSION IDS (token-excluded). `GDS-V3` / `GDS-V4` are row keys in the
+//      versions table, not vocabulary. They are stripped from every line before
+//      counting, so they stay legal even inside a file that is otherwise
+//      counted.
+//
+// Usage:
+//   node scripts/gds/gds-literal-scan.js            # count + the top offending files
+//   node scripts/gds/gds-literal-scan.js --files    # every file with its count
+//   node scripts/gds/gds-literal-scan.js --json
+
+const fs = require('node:fs');
+const path = require('node:path');
+const { execFileSync } = require('node:child_process');
+
+const ROOT = path.resolve(__dirname, '..', '..');
+
+// The frozen record + applied migration filenames. Matched against the
+// repo-relative path, at any depth, so an instance's own migrations/ and a
+// module-owned migrations/ are covered by the same rule as the core's.
+const GDS_EXCLUDED_PATHS = [
+  /(^|\/)docs\/adr\//,
+  /(^|\/)docs\/session-logs\//,
+  /(^|\/)docs\/audits\//,
+  /(^|\/)limitations\//,
+  /(^|\/)migrations\//,
+];
+
+// Vendored / generated / third-party trees the budgets must not count — the
+// same exclusion fitness-ratchets.js applies to its own metrics.
+const GDS_EXCLUDED_TREES = /(^|\/)(node_modules|public-docs)\/|\.min\.js$|(^|\/)vendor\//;
+
+// The files that STATE the rule. Meta-commentary about a banned word has to be
+// able to name it, or the gate cannot explain itself — the same principle as
+// VOCAB_ALLOW's "the manifest states the rule itself" entry in
+// fitness-checks-vocabulary.js. Without this the detector counts its own
+// explanation, and improving a comment here would red the build.
+const GDS_RULE_FILES = new Set([
+  'scripts/gds/gds-literal-scan.js',      // this file
+  'scripts/gds/fitness-ratchets.js',      // the gate: names the metric and carries the builder-facing hint
+  'tests/fitness_gds_ratchet.mjs',        // its test, which must write the literal to prove the gate fires
+  'config/fitness-baselines.json',        // the baseline's own _comment explains what is counted
+]);
+
+// A version id is a row key, not vocabulary. Stripped before matching so it is
+// legal on any line in any counted file.
+const GDS_VERSION_ID_RE = /GDS-V\d+/g;
+
+// The literal itself: case-sensitive, so the lowercase path/env spellings that
+// criterion C2 owns (`scripts/gds/`, `/api/gds`, `gds_session`) are counted
+// only where they appear in their SHOUTING form. Case-sensitivity is the point
+// — `GDS` is the acronym a newcomer trips over.
+const GDS_LITERAL_RE = /GDS/g;
+
+function isExcludedPath(relPath) {
+  if (GDS_RULE_FILES.has(relPath)) return true;
+  if (GDS_EXCLUDED_TREES.test(relPath)) return true;
+  return GDS_EXCLUDED_PATHS.some((re) => re.test(relPath));
+}
+
+// countInText — occurrences of the literal in one file's text, with version ids
+// removed first. Exported so the test and any future sweep share ONE detector
+// (the checkErrorEnvelope precedent: a gate whose detector drifts from its
+// sweep is worse than no gate).
+function countInText(text) {
+  const stripped = text.replace(GDS_VERSION_ID_RE, '');
+  return (stripped.match(GDS_LITERAL_RE) || []).length;
+}
+
+function trackedFiles() {
+  const out = execFileSync('git', ['ls-files'], { cwd: ROOT, encoding: 'utf8', maxBuffer: 64 * 1024 * 1024 });
+  return out.split('\n').map((s) => s.trim()).filter(Boolean);
+}
+
+// scanGdsLiterals — { total, byFile } across every tracked, countable file.
+// Unreadable and binary files are skipped rather than guessed at: a NUL byte
+// means the "occurrences" would be meaningless anyway.
+//
+// `files` and `readFile` are both injectable so the test can exercise the real
+// aggregation — exclusions, counting, per-file totals — WITHOUT writing to the
+// repo. That is not tidiness: the unit lane runs test files in parallel, and an
+// earlier version of the test proved the point by temporarily editing
+// docs/architecture.md and breaking whichever suite happened to be scanning the
+// tree at that moment.
+function scanGdsLiterals({ files = null, readFile = null } = {}) {
+  const read = readFile || ((relPath) => fs.readFileSync(path.join(ROOT, relPath), 'utf8'));
+  const byFile = {};
+  let total = 0;
+  for (const relPath of files || trackedFiles()) {
+    if (isExcludedPath(relPath)) continue;
+    let text;
+    try {
+      text = read(relPath);
+    } catch {
+      continue;
+    }
+    if (text.includes(String.fromCharCode(0))) continue; // binary (a NUL byte)
+    const n = countInText(text);
+    if (n) {
+      byFile[relPath] = n;
+      total += n;
+    }
+  }
+  return { total, byFile };
+}
+
+function main() {
+  const { total, byFile } = scanGdsLiterals();
+  const ranked = Object.entries(byFile).sort((a, b) => b[1] - a[1]);
+  if (process.argv.includes('--json')) {
+    process.stdout.write(`${JSON.stringify({ total, byFile }, null, 2)}\n`);
+    return;
+  }
+  const show = process.argv.includes('--files') ? ranked : ranked.slice(0, 20);
+  console.log(`legacy GDS literals: ${total} across ${ranked.length} file(s)`);
+  console.log('(version ids GDS-V## are not counted; docs/adr, docs/session-logs, docs/audits, limitations and migrations are excluded by construction)');
+  console.log('');
+  for (const [f, n] of show) console.log(`  ${String(n).padStart(5)}  ${f}`);
+  if (show.length < ranked.length) console.log(`  … and ${ranked.length - show.length} more file(s) — pass --files for all`);
+}
+
+if (require.main === module) main();
+
+module.exports = {
+  GDS_EXCLUDED_PATHS,
+  GDS_RULE_FILES,
+  GDS_EXCLUDED_TREES,
+  GDS_LITERAL_RE,
+  GDS_VERSION_ID_RE,
+  countInText,
+  isExcludedPath,
+  scanGdsLiterals,
+};

package/src/module-api.js

@@ -49,7 +49,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.558'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.560'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/fitness_gds_ratchet.mjs

@@ -0,0 +1,152 @@
+// tests/fitness_gds_ratchet.mjs — the GDS→Bongos rename ratchet (task 1003669,
+// criterion C5 of goal 1000073, "the rename cannot come back").
+//
+// WHY. A gate nobody has watched FAIL is not a gate. The criterion's whole point
+// is that the old name cannot creep back, so the load-bearing assertion here is
+// the negative one: a newly-introduced literal must red the build, and the
+// exclusions must NOT swallow it. The positive case (today's tree passes) is the
+// cheap half — it would also pass if the detector were broken and returned zero.
+//
+// The detector is exercised directly rather than through the filesystem: it takes
+// an explicit `files` list, so a case can name exactly the paths under test
+// without writing into the repo or depending on what happens to be committed.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const scan = require(path.join(ROOT, 'scripts', 'gds', 'gds-literal-scan.js'));
+const ratchets = require(path.join(ROOT, 'scripts', 'gds', 'fitness-ratchets.js'));
+
+const LITERAL = ['G', 'D', 'S'].join(''); // built, not written, so this file needs no exemption of its own
+
+test('the detector COUNTS a bare literal — the gate is not a no-op', () => {
+  assert.equal(scan.countInText(`the ${LITERAL} is the old name`), 1);
+  assert.equal(scan.countInText(`${LITERAL} and ${LITERAL} again`), 2);
+  assert.equal(scan.countInText('Bongos all the way down'), 0);
+});
+
+test('a version id is NOT counted — it is a row key, not vocabulary', () => {
+  assert.equal(scan.countInText(`${LITERAL}-V3`), 0);
+  assert.equal(scan.countInText(`${LITERAL}-V4 shipped`), 0);
+  // …but a bare literal on the same line still counts: stripping the version id
+  // must not blind the detector to real drift beside it.
+  assert.equal(scan.countInText(`${LITERAL}-V3 and the ${LITERAL} acronym`), 1);
+});
+
+test('the frozen record is excluded — an ADR or session log may say the old name', () => {
+  for (const p of [
+    'docs/adr/0064-rename.md',
+    'docs/session-logs/2026-09-06-something.md',
+    'docs/audits/some-audit.md',
+    'limitations/v3-shipped.md',
+    'migrations/047_something.sql',
+    'modules/copy-desk/migrations/copy_desk_001_flags.sql', // a MODULE's migrations too
+  ]) {
+    assert.equal(scan.isExcludedPath(p), true, `expected excluded: ${p}`);
+  }
+});
+
+test('ordinary source and docs are NOT excluded — otherwise the gate guards nothing', () => {
+  for (const p of [
+    'docs/architecture.md',
+    'docs/recipes/self-host.md',
+    'src/bongos/routes/live.js',
+    'modules/discord/discord-bot.js',
+    '.claude/skills/builder-ship/SKILL.md',
+  ]) {
+    assert.equal(scan.isExcludedPath(p), false, `expected counted: ${p}`);
+  }
+});
+
+// A fake tree, so these cases touch no real file. See the note on
+// scanGdsLiterals's `readFile` parameter: the unit lane runs test files in
+// parallel, and a test that edits the repo to make its point breaks whichever
+// suite is reading the repo at the time.
+function fakeTree(contents) {
+  return {
+    files: Object.keys(contents),
+    readFile: (relPath) => contents[relPath],
+  };
+}
+
+test('a NEW literal in a counted file REDS the ratchet (the criterion itself)', () => {
+  const clean = fakeTree({ 'docs/architecture.md': 'The platform is Bongos.\n' });
+  const dirty = fakeTree({ 'docs/architecture.md': `The platform is Bongos.\nBut this line says ${LITERAL}.\n` });
+
+  const before = scan.scanGdsLiterals(clean).total;
+  const after = scan.scanGdsLiterals(dirty).total;
+  assert.equal(before, 0);
+  assert.equal(after, 1, 'a new literal must raise the count');
+
+  // …and a count above its baseline must be a VIOLATION, not a warning.
+  const { violations } = ratchets.compareToBaselines(
+    { legacy_gds_literals: after },
+    { legacy_gds_literals: before }
+  );
+  assert.equal(violations.length, 1, 'rising above the baseline must violate');
+  assert.match(violations[0], /legacy_gds_literals regressed/);
+  assert.match(violations[0], /rename cannot come back/, 'the message must tell the builder what rule they broke');
+});
+
+test('an edit to the FROZEN record never reds the build', () => {
+  const tree = fakeTree({
+    'docs/adr/README.md': `The ${LITERAL} was renamed; this line is history.\n`,
+    'docs/session-logs/2026-09-06-x.md': `A session that mentions ${LITERAL} twice: ${LITERAL}.\n`,
+    'migrations/047_x.sql': `-- ${LITERAL} era migration\n`,
+  });
+  assert.equal(
+    scan.scanGdsLiterals(tree).total,
+    0,
+    'the frozen record may name the old name freely — that is the goal\'s stated rule'
+  );
+});
+
+test('the aggregation is per-file and additive across a mixed tree', () => {
+  const tree = fakeTree({
+    'docs/architecture.md': `${LITERAL} and ${LITERAL}\n`,   // 2, counted
+    'src/bongos/routes/live.js': `// ${LITERAL}\n`,          // 1, counted
+    'docs/adr/0064-rename.md': `${LITERAL} ${LITERAL}\n`,    // excluded
+    'docs/recipes/self-host.md': 'Bongos only\n',            // 0
+  });
+  const { total, byFile } = scan.scanGdsLiterals(tree);
+  assert.equal(total, 3);
+  assert.deepEqual(byFile, { 'docs/architecture.md': 2, 'src/bongos/routes/live.js': 1 });
+});
+
+test('the ratchet only tightens — a FALLING count is a warning, never a failure', () => {
+  const { violations, warnings } = ratchets.compareToBaselines(
+    { legacy_gds_literals: 10 },
+    { legacy_gds_literals: 20 }
+  );
+  assert.equal(violations.length, 0);
+  assert.equal(warnings.length, 1);
+  assert.match(warnings[0], /ratchet-down available/);
+});
+
+test('the metric is MANAGED — it survives --update-baselines and has a committed baseline', () => {
+  // A metric outside computeMetrics() would be silently dropped the next time
+  // anyone refreshed the file, which is the failure mode this asserts against.
+  const metrics = ratchets.computeMetrics({ withDocs: false });
+  assert.ok(
+    Object.prototype.hasOwnProperty.call(metrics, 'legacy_gds_literals'),
+    'legacy_gds_literals must come from computeMetrics(), or --update-baselines will drop it'
+  );
+  assert.equal(typeof metrics.legacy_gds_literals, 'number');
+
+  const baselines = JSON.parse(fs.readFileSync(path.join(ROOT, 'config', 'fitness-baselines.json'), 'utf8'));
+  assert.equal(typeof baselines.metrics.legacy_gds_literals, 'number', 'the baseline must be committed');
+});
+
+test('the files that STATE the rule may name it', () => {
+  // Meta-commentary about a banned word has to be able to name the word, or the
+  // gate cannot explain itself to the person who tripped it.
+  for (const p of scan.GDS_RULE_FILES) {
+    assert.equal(scan.isExcludedPath(p), true, `rule-stating file must be exempt: ${p}`);
+    assert.ok(fs.existsSync(path.join(ROOT, p)), `rule-stating file must exist (stale exemption otherwise): ${p}`);
+  }
+});

package/tests/goal_closure_invariants.mjs

@@ -0,0 +1,332 @@
+// tests/goal_closure_invariants.mjs — the C2 invariant, pinned across BOTH
+// achievement writers (BV1.R13, task 1003600, goal 1000086, ADR 0250 D2).
+//
+// THE INVARIANT: a goal reaches `achieved` only when its criteria are satisfied
+// AND no task in it is left in a non-terminal state. Terminal is `shipped` or
+// deliberately `abandoned`; `backlog`, `ready`, `blocked`, `active`, `completed`
+// and `confirmed` all hold the goal open.
+//
+// WHY A DEDICATED SUITE. The rule is written TWICE on purpose — `db-goals.js`
+// `achieveGoalIfComplete` for the manual `POST /done-when/:id/satisfy`, and the
+// cascade inside `done-when.js` `autoSatisfyShippedCriteria` for the path that
+// fires on every ship and every reconciler tick. They cannot be collapsed into
+// one helper (db-goals requires done-when; sharing creates a require cycle), so
+// the failure mode is DRIFT: one writer moves, the other does not, and a goal
+// closes correctly through one door and wrongly through the other. That is
+// precisely how the two "finished" vocabularies drifted apart before task
+// 1003588. This file states the invariant once and asserts it of both.
+//
+// WHAT THIS FILE IS, AND IS NOT. It runs both writers against a small in-memory
+// model of the two statements they issue — the model implements the SQL's
+// SEMANTICS (who is terminal, which goals qualify) by hand, so what is proven
+// here is the behaviour and the wiring: which view each writer consults, what it
+// decides, and what it leaves alone. The literal SQL TEXT is pinned separately —
+// tests/auto_satisfy_criteria.mjs for the cascade, tests/goal_achievement.mjs for
+// the manual path — and neither file replaces the other. A change that alters the
+// SQL's meaning has to get past both.
+//
+// Run:  node --test tests/goal_closure_invariants.mjs
+
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+
+process.env.NODE_ENV = 'test';
+const require = createRequire(import.meta.url);
+const { achieveGoalIfComplete } = require('../modules/lifecycle/db.js');
+const { autoSatisfyShippedCriteria, closeCompletedWorkForShip } =
+  require('../modules/lifecycle/done-when.js');
+const { TERMINAL_STATUSES } = require('../modules/lifecycle/task-status.js');
+
+// ---------------------------------------------------------------------------
+// The model. A `world` is { goals, criteria, tasks }, where a task carries
+// { id, goal_id, status, title } and a criterion { id, goal_id, satisfied,
+// task_ids }. `makeExec(world)` returns something shaped like a pg client whose
+// two statements answer FROM THAT WORLD — so handing two writers two different
+// worlds is how the uncommitted-flip case below is expressed.
+// ---------------------------------------------------------------------------
+
+const isTerminal = (t) => TERMINAL_STATUSES.includes(t.status);
+const isSmoke = (t) => String(t.title || '').startsWith('__smoke__');
+
+// The terminal set the STATEMENT asks for, read back out of its own text, so a
+// change to task-status.js flows into the model instead of being asserted twice.
+function terminalSetIn(sql) {
+  const m = sql.match(/t\.status NOT IN \(([^)]*)\)/);
+  assert.ok(m, 'the cascade must name a terminal set the model can read');
+  return m[1].split(',').map((x) => x.trim().replace(/^'|'$/g, ''));
+}
+// "Holds the goal open": not terminal, and not a test fixture.
+const holdsOpen = (t) => !isTerminal(t) && !isSmoke(t);
+
+function world({ goalStatus = 'open', criteria = [], tasks = [] } = {}) {
+  return {
+    goals: [{ id: 77, title: 'Strict versioning', version_id: 'BONGOS-V1', status: goalStatus }],
+    criteria: criteria.map((c, i) => ({
+      id: 100 + i, goal_id: 77, version_id: 'BONGOS-V1',
+      criterion_id: 'c' + i, criterion_md: 'x', satisfied: false, task_ids: [], ...c,
+    })),
+    tasks: tasks.map((t, i) => ({ id: 200 + i, goal_id: 77, title: 'task ' + i, ...t })),
+  };
+}
+
+function makeExec(w) {
+  const calls = [];
+  const taskById = (id) => w.tasks.find((t) => t.id === id);
+  return {
+    calls,
+    world: w,
+    async query(sql, params) {
+      const s = String(sql).replace(/\s+/g, ' ').trim();
+      calls.push({ sql: s, params });
+
+      // (1) close every unsatisfied criterion whose linked tasks are ALL terminal
+      // and at least one of which actually shipped (the delivery guard).
+      if (/UPDATE done_when_criteria/.test(s)) {
+        const scoped = params[0] == null ? null : Number(params[0]);
+        const closed = w.criteria.filter((c) => {
+          if (c.satisfied) return false;
+          if (scoped != null && !c.task_ids.includes(scoped)) return false;
+          const linked = c.task_ids.map(taskById).filter(Boolean);
+          if (linked.length === 0) return false;
+          return linked.every(isTerminal) && linked.some((t) => t.status === 'shipped');
+        });
+        closed.forEach((c) => { c.satisfied = true; });
+        return { rows: closed.map((c) => ({ ...c, satisfied_by_task_id: scoped })) };
+      }
+
+      // (2) the cascade. NOT hand-coded: the model reads the statement it was
+      // actually handed and honours only the clauses PRESENT in it — including
+      // the terminal set, parsed out of the SQL rather than imported. That is
+      // what keeps this suite non-vacuous. Delete the R09 clause from
+      // done-when.js and the model stops filtering on tasks, the goal closes,
+      // and these tests go red — which `the suite can actually fail` below
+      // demonstrates rather than asserts.
+      if (/UPDATE goals g/.test(s)) {
+        const ids = (params[0] || []).map(Number);
+        const flipped = w.goals.filter((g) => {
+          if (!ids.includes(g.id)) return false;
+          if (/g\.status = 'open'/.test(s) && g.status !== 'open') return false;
+          const crit = w.criteria.filter((c) => c.goal_id === g.id);
+          if (/EXISTS \(SELECT 1 FROM done_when_criteria/.test(s) && crit.length === 0) return false;
+          if (/AND NOT d\.satisfied\)/.test(s) && crit.some((c) => !c.satisfied)) return false;
+          if (/NOT EXISTS \(SELECT 1 FROM tasks t/.test(s)) {
+            const terminal = terminalSetIn(s);
+            const smokeFiltered = /t\.title NOT LIKE/.test(s);
+            const held = w.tasks.some((t) => t.goal_id === g.id
+              && !terminal.includes(t.status)
+              && !(smokeFiltered && isSmoke(t)));
+            if (held) return false;
+          }
+          return true;
+        });
+        flipped.forEach((g) => { g.status = 'achieved'; });
+        return { rows: flipped.map((g) => ({ ...g })) };
+      }
+
+      // The manual path: getGoal, then the combined criteria + task counts, then
+      // the status flip.
+      if (/FROM goals WHERE id = \$1/.test(s)) {
+        const g = w.goals.find((x) => x.id === Number(params[0]));
+        return { rows: g ? [g] : [] };
+      }
+      if (/FROM done_when_criteria WHERE goal_id = \$1/.test(s)) {
+        const crit = w.criteria.filter((c) => c.goal_id === Number(params[0]));
+        return { rows: [{
+          total: crit.length,
+          unsatisfied: crit.filter((c) => !c.satisfied).length,
+          unfinished_tasks: w.tasks.filter((t) => t.goal_id === Number(params[0]) && holdsOpen(t)).length,
+        }] };
+      }
+      if (/^UPDATE goals/.test(s)) {
+        const g = w.goals.find((x) => x.id === Number(params[0]));
+        g.status = params[1];
+        return { rows: [{ ...g }] };
+      }
+      return { rows: [] };
+    },
+  };
+}
+const asPool = (exec) => ({ query: (sql, p) => exec.query(sql, p), connect: async () => exec, calls: exec.calls });
+
+const SHIPPED = (over) => ({ status: 'shipped', ...over });
+
+// ---------------------------------------------------------------------------
+// 1. The invariant holds on BOTH writers, for every non-terminal status
+// ---------------------------------------------------------------------------
+
+const HOLDS_OPEN = ['backlog', 'ready', 'blocked', 'active', 'completed', 'confirmed'];
+
+for (const status of HOLDS_OPEN) {
+  test(`a '${status}' sibling holds the goal open — manual path`, async () => {
+    const w = world({
+      criteria: [{ satisfied: true, task_ids: [200] }],
+      tasks: [SHIPPED(), { status }],
+    });
+    const out = await achieveGoalIfComplete({ goalId: 77 }, { pool: asPool(makeExec(w)) });
+    assert.equal(out.achieved, false, `'${status}' is not finished work`);
+    assert.equal(w.goals[0].status, 'open', 'and the row is not flipped');
+  });
+
+  test(`a '${status}' sibling holds the goal open — cascade`, async () => {
+    const w = world({
+      criteria: [{ satisfied: false, task_ids: [200] }],
+      tasks: [SHIPPED(), { status }],
+    });
+    const out = await autoSatisfyShippedCriteria(makeExec(w), { taskId: 200 });
+    assert.equal(out.criteria.length, 1, 'the criterion itself still closes — ADR 0183 is untouched');
+    assert.deepEqual(out.goals, [], 'but the goal does not');
+    assert.equal(w.goals[0].status, 'open');
+  });
+}
+
+for (const status of TERMINAL_STATUSES) {
+  test(`a '${status}' sibling does NOT hold the goal open — both writers agree`, async () => {
+    const manual = world({ criteria: [{ satisfied: true, task_ids: [200] }], tasks: [SHIPPED(), { status }] });
+    const m = await achieveGoalIfComplete({ goalId: 77 }, { pool: asPool(makeExec(manual)) });
+    assert.equal(m.achieved, true, `'${status}' is finished with the project`);
+
+    const casc = world({ criteria: [{ satisfied: false, task_ids: [200] }], tasks: [SHIPPED(), { status }] });
+    const c = await autoSatisfyShippedCriteria(makeExec(casc), { taskId: 200 });
+    assert.equal(c.goals.length, 1, 'the cascade reaches the same verdict');
+    assert.equal(casc.goals[0].status, 'achieved');
+  });
+}
+
+test('a __smoke__ fixture cannot wedge a real goal open — both writers', async () => {
+  const smoke = { status: 'backlog', title: '__smoke__ probe' };
+  const manual = world({ criteria: [{ satisfied: true, task_ids: [200] }], tasks: [SHIPPED(), smoke] });
+  assert.equal((await achieveGoalIfComplete({ goalId: 77 }, { pool: asPool(makeExec(manual)) })).achieved, true);
+
+  const casc = world({ criteria: [{ satisfied: false, task_ids: [200] }], tasks: [SHIPPED(), smoke] });
+  assert.equal((await autoSatisfyShippedCriteria(makeExec(casc), { taskId: 200 })).goals.length, 1);
+});
+
+test('the rule does not become "goals never close": clean goal still achieves', async () => {
+  const w = world({ criteria: [{ satisfied: false, task_ids: [200, 201] }], tasks: [SHIPPED(), SHIPPED()] });
+  const out = await autoSatisfyShippedCriteria(makeExec(w), { taskId: 200 });
+  assert.equal(out.goals.length, 1, 'every task terminal + every criterion satisfied = achieved');
+  assert.equal(w.goals[0].status, 'achieved');
+});
+
+test('a task linked to NO criterion still holds the goal open — the original hole', async () => {
+  // This is the exact shape that produced 14 wrongly-closed goals on the live
+  // instance: achievement was computed from criteria alone, and an unlinked task
+  // was therefore invisible to it.
+  const w = world({
+    criteria: [{ satisfied: false, task_ids: [200] }],
+    tasks: [SHIPPED(), { status: 'backlog' }], // 201 is linked to nothing
+  });
+  const out = await autoSatisfyShippedCriteria(makeExec(w), { taskId: 200 });
+  assert.equal(out.criteria.length, 1, 'the criterion is satisfied — its own tasks all shipped');
+  assert.deepEqual(out.goals, [], 'and the unlinked backlog task still holds the goal open');
+});
+
+// ---------------------------------------------------------------------------
+// 2. The cascade sees the ship transaction's UNCOMMITTED flip
+// ---------------------------------------------------------------------------
+
+test('the cascade reads through the exec it was handed, so it sees the ship\'s own uncommitted flip', async () => {
+  // Two views of the same instant, mid-ship: the transaction has already flipped
+  // task 200 confirmed→shipped but has not committed, so anything reading the
+  // module pool still sees 'confirmed' — non-terminal.
+  const inTxn = world({ criteria: [{ satisfied: false, task_ids: [200] }], tasks: [SHIPPED()] });
+  const outsideTxn = world({ criteria: [{ satisfied: false, task_ids: [200] }], tasks: [{ status: 'confirmed' }] });
+
+  const viaTxn = await autoSatisfyShippedCriteria(makeExec(inTxn), { taskId: 200 });
+  assert.equal(viaTxn.goals.length, 1,
+    "the shipping task is terminal inside its own transaction, so the goal closes");
+  assert.equal(inTxn.goals[0].status, 'achieved');
+
+  const viaPool = await autoSatisfyShippedCriteria(makeExec(outsideTxn), { taskId: 200 });
+  assert.deepEqual(viaPool.goals, [],
+    'and on a pre-commit view it would NOT — which is the bug passing the pool would cause');
+  assert.equal(outsideTxn.goals[0].status, 'open');
+
+  // Both halves matter: the first alone would pass even if the function ignored
+  // its exec and the world were globally shipped. The pair proves the OUTCOME
+  // tracks the view handed in — i.e. that the reads go through `exec`.
+});
+
+test('every statement goes through the caller exec — none reaches the module pool', async () => {
+  const exec = makeExec(world({ criteria: [{ satisfied: false, task_ids: [200] }], tasks: [SHIPPED()] }));
+  await autoSatisfyShippedCriteria(exec, { taskId: 200 });
+  assert.equal(exec.calls.length, 2, 'the criterion close and the cascade, both on exec');
+  assert.match(exec.calls[0].sql, /UPDATE done_when_criteria/);
+  assert.match(exec.calls[1].sql, /UPDATE goals g/);
+});
+
+// ---------------------------------------------------------------------------
+// 3. A ship still LANDS while its goal is held open
+// ---------------------------------------------------------------------------
+
+test('a ship lands even though a sibling backlog task holds its goal open', async () => {
+  // The ship-time hook is the only thing the closure rule touches on the ship
+  // path. It must complete quietly: the criterion closes, the goal does not, and
+  // nothing is thrown into the transaction that is landing the task.
+  const w = world({
+    criteria: [{ satisfied: false, task_ids: [200] }],
+    tasks: [SHIPPED(), { status: 'backlog' }],
+  });
+  const logged = [];
+  const line = await closeCompletedWorkForShip(makeExec(w), 200, (m) => logged.push(m));
+  assert.ok(line, 'it reports what it closed');
+  assert.match(line, /criteri/i, 'namely the criterion');
+  assert.equal(w.goals[0].status, 'open', 'the goal is held open by the sibling');
+  assert.equal(w.tasks[0].status, 'shipped', 'and the ship itself is untouched');
+});
+
+test('the hook swallows a failure rather than failing the ship', async () => {
+  // Belt and braces on the same guarantee: even if the cascade throws outright,
+  // the ship must not. The reconciler's unscoped sweep retries every tick.
+  const exploding = { query: async () => { throw new Error('deadlock detected'); } };
+  const logged = [];
+  const line = await closeCompletedWorkForShip(exploding, 200, (m) => logged.push(m));
+  assert.match(line, /auto-satisfy skipped \(sweep retries\): deadlock detected/,
+    'the failure is reported, not raised');
+});
+
+// ---------------------------------------------------------------------------
+// 4. The two writers may not drift apart
+// ---------------------------------------------------------------------------
+
+test('the suite can actually fail: strip the R09 clause and the goal wrongly closes', async () => {
+  // A model that answers from its own logic would pass these tests no matter what
+  // the code said. This one interprets the statement it is handed, so removing the
+  // clause is observable — demonstrated here against the SAME world that is held
+  // open above, with the clause edited out of the SQL on its way in.
+  const w = world({ criteria: [{ satisfied: false, task_ids: [200] }], tasks: [SHIPPED(), { status: 'backlog' }] });
+  const base = makeExec(w);
+  const stripTaskClause = (sql) => {
+    const text = String(sql);
+    const from = text.indexOf('AND NOT EXISTS (SELECT 1 FROM tasks t');
+    if (from === -1) return text;
+    const to = text.indexOf('RETURNING', from);
+    assert.notEqual(to, -1, 'the clause is expected inside the cascade UPDATE');
+    return text.slice(0, from) + text.slice(to);
+  };
+  const crippled = { query: (sql, params) => base.query(stripTaskClause(sql), params) };
+  const out = await autoSatisfyShippedCriteria(crippled, { taskId: 200 });
+  assert.equal(out.goals.length, 1,
+    'without the clause the backlog sibling is invisible and the goal closes — the pre-R09 bug');
+  assert.equal(w.goals[0].status, 'achieved',
+    'so the passing tests above are load-bearing, not decorative');
+});
+
+test('both writers reach the SAME verdict on every status, one status at a time', async () => {
+  // The anti-drift assertion, stated as behaviour rather than as matching source
+  // text: for each task status, ask both writers and require they agree.
+  const ALL = [...HOLDS_OPEN, ...TERMINAL_STATUSES];
+  const disagreements = [];
+  for (const status of ALL) {
+    const m = world({ criteria: [{ satisfied: true, task_ids: [200] }], tasks: [SHIPPED(), { status }] });
+    const manual = (await achieveGoalIfComplete({ goalId: 77 }, { pool: asPool(makeExec(m)) })).achieved;
+
+    const c = world({ criteria: [{ satisfied: false, task_ids: [200] }], tasks: [SHIPPED(), { status }] });
+    const cascade = (await autoSatisfyShippedCriteria(makeExec(c), { taskId: 200 })).goals.length > 0;
+
+    if (manual !== cascade) disagreements.push(`${status}: manual=${manual} cascade=${cascade}`);
+  }
+  assert.deepEqual(disagreements, [],
+    'the duplicate is deliberate; the DRIFT is the bug — both writers or neither');
+});