@bongos/core 1.19.551 → 1.19.552

package/.bongos-core.json

@@ -2,22 +2,22 @@
   "artifact": "bongos-core",
   "manifest_schema": 1,
   "generator": "scripts/gds/package-core.js",
-  "core_version": "1.19.551",
-  "core_contract": "1.19.551",
-  "source_commit": "de0b6c99753fd502f2356bcfb6bf338227445cc7",
+  "core_version": "1.19.552",
+  "core_contract": "1.19.552",
+  "source_commit": "c33c4fe6dd1cf9319051a7bee1e9c940472549a5",
   "source_ref": "HEAD",
-  "built_at": "2026-09-04T20:39:18.276Z",
+  "built_at": "2026-09-06T15:55:11.203Z",
   "redaction": {
     "model": "docs-redacted+functional-verbatim",
     "docs_redacted": 442,
     "agent_docs_stubbed": 24,
-    "functional_verbatim": 2018,
+    "functional_verbatim": 2019,
     "rules": 3,
     "gate_literals": 3,
     "gate": "passed"
   },
-  "file_count": 2484,
-  "tree_sha256": "38fea0008aa898d10d6e7388c30a7d422be81dcde8d201172848e551d72d361b",
+  "file_count": 2485,
+  "tree_sha256": "c628eebd2a60fa4e7346604f1f5507a913cfac851f45fc632f3eff4aedf36487",
   "files": [
     {
       "path": ".claude/skills/blocker-review/SKILL.md",
@@ -2652,7 +2652,7 @@
     {
       "path": "docs/module-api-changelog.md",
       "mode": "0000644",
-      "sha256": "1389ff20919a19aef2fbff28102f596f0ca168c34bc4c4114cf557bbf52627a5"
+      "sha256": "2fb63f0c4427c7f7bff711fcf41f5637cca7b31a8009a21305530748b130e310"
     },
     {
       "path": "docs/modules-contract.md",
@@ -5427,7 +5427,7 @@
     {
       "path": "modules/lifecycle/db-goals.js",
       "mode": "0000644",
-      "sha256": "3ad7f78cbad987307d2203facbc91cec879565f398f9893a0218bbf29fc061bb"
+      "sha256": "713b7165b1dbbfe43a77db5678ea98ebb03e17209d7b7bee5dbd1fc416be5cc2"
     },
     {
       "path": "modules/lifecycle/db-grade.js",
@@ -5477,7 +5477,7 @@
     {
       "path": "modules/lifecycle/done-when.js",
       "mode": "0000644",
-      "sha256": "fab91acf54bea4fca254bfd420a9a934e6eae434101ff57ae2a1bed48d2342d5"
+      "sha256": "4e276151342f0eab3d4c0cea1ed55db8716a1d3d4b40568966be495f4892c1f4"
     },
     {
       "path": "modules/lifecycle/est-advisory.js",
@@ -5517,7 +5517,7 @@
     {
       "path": "modules/lifecycle/goal-rollup.js",
       "mode": "0000644",
-      "sha256": "cd3c3c28e9e1361b1f02a8de7a973d0d4d87b916477af98b9032de87dfbc588d"
+      "sha256": "1debae561ef745ba22440ea2b32f27dd567e9e7ed56f8a5509e90fc1ddecd10e"
     },
     {
       "path": "modules/lifecycle/goal-suggest.js",
@@ -5734,6 +5734,11 @@
       "mode": "0000644",
       "sha256": "7ed98bbd3d4954808dc64228acb6899a96083081ecc241e81f2b5db9eb568f1f"
     },
+    {
+      "path": "modules/lifecycle/task-status.js",
+      "mode": "0000644",
+      "sha256": "28db8b28430bbb1bc901b300322ce42ed5e9254e0b934941d3647b83c92b2083"
+    },
     {
       "path": "modules/lifecycle/task-visual-db.js",
       "mode": "0000644",
@@ -5752,7 +5757,7 @@
     {
       "path": "modules/lifecycle/version-close.js",
       "mode": "0000644",
-      "sha256": "d71d0c0583cfa873001c0e359d6ee6e0e0a26d846121064c25ed36a1d27054ae"
+      "sha256": "a977d807adb1e73544d1c02f6231005c2dbbb1a491316a8160080fd279e1b7a0"
     },
     {
       "path": "modules/memory/CLAUDE.md",
@@ -7467,12 +7472,12 @@
     {
       "path": "package-lock.json",
       "mode": "0000644",
-      "sha256": "c71d59c13b87d9ffbd6c792eb56b26eb434704e855aed3afdfc58914dba02e29"
+      "sha256": "cc08dead6d4714851b7db549d9b6ad9829bbd0e22722fab29cef54f9b28f7693"
     },
     {
       "path": "package.json",
       "mode": "0000644",
-      "sha256": "6a2c55e98a36d257177254a100569a14bec9b3720931caf9ef265971b81ba319"
+      "sha256": "36e67dc71f4fced7aa31d42102c8ff9c424ded06dea1a6f2f67d45888e95e406"
     },
     {
       "path": "public-docs/index.html",
@@ -8497,7 +8502,7 @@
     {
       "path": "scripts/gds/sequence.js",
       "mode": "0000644",
-      "sha256": "52c43371c2e6e8f7ffeac588143167ffc43e0010bceb7137ebce4ed61eaa64e6"
+      "sha256": "08b2165b899aa71983826789613d7eadd1bdded7f4ef12b05d7c1a60bb79337e"
     },
     {
       "path": "scripts/gds/session-cost.js",
@@ -9167,7 +9172,7 @@
     {
       "path": "src/module-api.js",
       "mode": "0000644",
-      "sha256": "95e7b476152291d84e955bfd585e62c48c48d85dcab0ca8d73c4519af2997e8b"
+      "sha256": "bd96dabd37302c58d3519dde872d4a77f20302b5da263dc829db0fda37654edb"
     },
     {
       "path": "src/module-loader/catalog.js",
@@ -9427,7 +9432,7 @@
     {
       "path": "tests/auto_satisfy_criteria.mjs",
       "mode": "0000644",
-      "sha256": "135d0af6b1535e50d68ed62baa36b616ba28888e899940cabf2f2940f3cd6f9d"
+      "sha256": "548e6a477660bb5e5cb260a0d5821bc3e11201225e64cfa45611c2fae07c80b2"
     },
     {
       "path": "tests/autonomous_fit_protected_paths.mjs",
@@ -10302,7 +10307,7 @@
     {
       "path": "tests/goal_sort_staleness.mjs",
       "mode": "0000644",
-      "sha256": "1c34a429a1e96c409e8f6e2199d79a0f75b95f25a2cd5f1a86b6f2e254d6ac40"
+      "sha256": "cf399c4c8ea36f96bbdb1f68e36a71eb3d0f4965c3e88278c9387d92896e7db4"
     },
     {
       "path": "tests/goal_subtitle.mjs",

package/docs/module-api-changelog.md

@@ -1551,5 +1551,7 @@ is load-bearing: the script throws rather than guess if it is missing, and
         landed since 1.19.549 with no explicit bump. run 33907331050. (task 1002620)
   1.19.551 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
         landed since 1.19.550 with no explicit bump. run 33917261720. (task 1002620)
+  1.19.552 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+        landed since 1.19.551 with no explicit bump. run 34043771286. (task 1002620)
 ---------------------------------------------------------------------------
 ```

package/modules/lifecycle/db-goals.js

@@ -14,6 +14,7 @@ const api = require('../../src/module-api');
 const { pool } = api;
 const doneWhen = require('./done-when.js');
 const { deriveRequiredRank, highestRank } = require('./db-rank-authz.js');
+const { nonTerminalSql } = require('./task-status');
 
 // -------------------------------------------------------------------------
 // Goals (ADR 0086 §2 / BV1.R56 — task 1510)
@@ -328,7 +329,7 @@ async function listCriteriaForGoal(goalId, deps = {}) {
               -- task 1002651 (migration 017's family): abandoned is a terminal
               -- state (deliberately cut), not pending work — it must not hold a
               -- criterion's "met — pending review" flip hostage forever.
-              count(*) FILTER (WHERE t.status NOT IN ('shipped', 'abandoned'))::int AS unshipped_tasks
+              count(*) FILTER (WHERE ${nonTerminalSql()})::int AS unshipped_tasks
          FROM task_criteria tc
          JOIN tasks t ON t.id = tc.task_id
         WHERE tc.criterion_id IN (SELECT id FROM crit)

package/modules/lifecycle/done-when.js

@@ -24,6 +24,7 @@
 //   POST /api/gds/done-when/:criterionId/unsatisfy      — auth
 
 const { pool } = require('../../src/module-api');
+const { nonTerminalSql } = require('./task-status');
 
 // isPendingReview — the ONE derivation of the "met — pending review" auto-flag
 // (ADR 0086 §6 / BV1.R63): a criterion with >=1 linked task, every one shipped,
@@ -134,7 +135,7 @@ async function listPendingReviewCriteria({ versionId = null } = {}, deps = {}) {
          JOIN tasks t          ON t.id = tc.task_id
         WHERE c.satisfied = false
         GROUP BY c.id
-       HAVING count(*) FILTER (WHERE t.status NOT IN ('shipped', 'abandoned')) = 0
+       HAVING count(*) FILTER (WHERE ${nonTerminalSql()}) = 0
      ),
      goal_unsat AS (
        SELECT goal_id, count(*)::int AS unsatisfied
@@ -426,7 +427,7 @@ async function autoSatisfyShippedCriteria(exec, { taskId = null } = {}) {
           AND ($1::bigint IS NULL OR c.id IN (
                 SELECT criterion_id FROM task_criteria WHERE task_id = $1::bigint))
         GROUP BY c.id
-       HAVING count(*) FILTER (WHERE t.status NOT IN ('shipped', 'abandoned')) = 0
+       HAVING count(*) FILTER (WHERE ${nonTerminalSql()}) = 0
           AND count(*) FILTER (WHERE t.status = 'shipped') >= 1
      )
      UPDATE done_when_criteria c

package/modules/lifecycle/goal-rollup.js

@@ -32,10 +32,12 @@
 const api = require('../../src/module-api');
 const { pool } = api;
 
-// The status vocabularies, kept beside the SQL that uses them so a reader can
-// check them against goals-lib.js in one glance.
-const DONE_STATUSES = ['shipped', 'confirmed', 'completed'];
-const CUT_STATUSES = ['abandoned', 'dropped'];
+// The status vocabularies live in task-status.js (task 1003588) so this module
+// has ONE spelling of each. These two are the PRESENTATIONAL buckets — they
+// mirror goals-lib.js `readinessOf`, and they are NOT the terminal set: `done`
+// here includes the mid-ship states on purpose, which is right for a progress
+// ring and wrong for any question about whether a goal may close.
+const { DONE_STATUSES, CUT_STATUSES } = require('./task-status');
 
 // goalRollups — one row per goal that has at least one task in `versionId`.
 // Returns [{ goal_id, done, active, ready, blocked, backlog, cut, total,

package/modules/lifecycle/task-status.js

@@ -0,0 +1,72 @@
+'use strict';
+
+// modules/lifecycle/task-status.js — the task-status vocabulary, declared once
+// (task 1003588, goal 1000086, criterion sv-goal-outlives-nothing).
+//
+// WHY THIS FILE EXISTS. "Finished" had two spellings inside one module.
+// `goal-rollup.js` counted shipped|confirmed|completed as done; `done-when.js`
+// counted only shipped and treated abandoned as accounted-for; `db-goals.js`,
+// `version-close.js` and the `sequence` CLI each re-typed the SQL literal
+// `NOT IN ('shipped', 'abandoned')` by hand. Two definitions of finished in one
+// module is precisely what lets a goal read closed on one surface and open on
+// another — the failure goal 1000086 exists to make impossible. So the
+// vocabulary is declared here, once, and every consumer reads it.
+//
+// THE TWO SETS ARE NOT THE SAME QUESTION, and conflating them is the bug in the
+// other direction:
+//
+//   TERMINAL_STATUSES — the LEDGER truth. A task is finished with the project
+//     when it shipped or was deliberately abandoned. Nothing else is terminal:
+//     `completed` and `confirmed` are mid-ship states that can still fail a
+//     grade or strand, so work sitting in them is unfinished work and must hold
+//     its goal open. This is the set the closure invariants read.
+//
+//   DONE_STATUSES / CUT_STATUSES — a PRESENTATIONAL bucketing for the goals
+//     board, mirroring the client's `goals-lib.js readinessOf` verbatim (a
+//     divergence shows a person different numbers per surface, which
+//     tests/goal_sort_staleness.mjs pins). "Done" there means "no longer in the
+//     queue", which deliberately includes the mid-ship states. It is a progress
+//     ring, not a ledger, and must never be used to decide whether a goal may
+//     close.
+//
+// NO DEPENDENCIES, deliberately. This file requires nothing — not even
+// `module-api` — so a CLI (`scripts/gds/sequence.js`) can read the vocabulary
+// without dragging the server's `db.js` and its connection pool into a process
+// that only needs a Set of two strings.
+
+// TERMINAL_STATUSES — the only spelling of "this task is finished with the
+// project". shipped = delivered; abandoned = deliberately cut (task 1002651,
+// migration 017's family). Everything else holds work open.
+const TERMINAL_STATUSES = ['shipped', 'abandoned'];
+
+// TERMINAL_STATUS_SET — the same set for JS membership tests.
+const TERMINAL_STATUS_SET = new Set(TERMINAL_STATUSES);
+
+// isTerminalStatus — true when a task in this status is finished with the
+// project and can no longer hold a criterion, a goal, or a version open.
+function isTerminalStatus(status) {
+  return TERMINAL_STATUS_SET.has(status);
+}
+
+// nonTerminalSql — the SQL predicate for "this task is still unfinished",
+// rendered from TERMINAL_STATUSES so the literal exists in exactly one place.
+// `column` is the status expression in the caller's query (`t.status` under a
+// join, bare `status` in a single-table read). Output is the byte-identical
+// `<column> NOT IN ('shipped', 'abandoned')` every call site used to hardcode.
+function nonTerminalSql(column = 't.status') {
+  return `${column} NOT IN (${TERMINAL_STATUSES.map((s) => `'${s}'`).join(', ')})`;
+}
+
+// DONE_STATUSES / CUT_STATUSES — the goals-board buckets. Presentational only;
+// see the header. Mirrors goals-lib.js `readinessOf`.
+const DONE_STATUSES = ['shipped', 'confirmed', 'completed'];
+const CUT_STATUSES = ['abandoned', 'dropped'];
+
+module.exports = {
+  TERMINAL_STATUSES,
+  TERMINAL_STATUS_SET,
+  isTerminalStatus,
+  nonTerminalSql,
+  DONE_STATUSES,
+  CUT_STATUSES,
+};

package/modules/lifecycle/version-close.js

@@ -11,6 +11,7 @@
 // (separate task #43).
 
 const { pool } = require('../../src/module-api');
+const { nonTerminalSql } = require('./task-status');
 
 const PERCENT_GATE = 80;
 
@@ -54,7 +55,7 @@ async function getCarryOverCount(versionId) {
     `SELECT count(*) AS n
        FROM tasks
       WHERE version_id = $1
-        AND status NOT IN ('shipped', 'abandoned')
+        AND ${nonTerminalSql('status')}
         AND title NOT LIKE '\\_\\_smoke\\_\\_%' ESCAPE '\\'`,
     [versionId]
   );

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.551",
+  "version": "1.19.552",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.551",
+      "version": "1.19.552",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.551",
+  "version": "1.19.552",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/scripts/gds/sequence.js

@@ -33,8 +33,10 @@ const RANK_TIER = { xenos: 1, thetes: 2, metic: 3, archon: 4 };
 
 // A task in one of these statuses is done as far as the chain is concerned —
 // 'completed'/'confirmed' are mid-ship states, so the chain must not re-claim
-// them, but they are also not yet 'shipped' so successors stay gated.
-const TERMINAL = new Set(['shipped', 'abandoned']);
+// them, but they are also not yet 'shipped' so successors stay gated. The set
+// itself comes from the lifecycle's one declaration (task 1003588); that file
+// requires nothing, so reading it costs this CLI no server pool.
+const { TERMINAL_STATUS_SET: TERMINAL } = require('../../modules/lifecycle/task-status');
 const IN_FLIGHT = new Set(['active', 'completed', 'confirmed']);
 
 const DEFAULT_LIMIT = 50;

package/src/module-api.js

@@ -49,7 +49,7 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.551'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.552'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');

package/tests/auto_satisfy_criteria.mjs

@@ -61,7 +61,10 @@ const CRIT = { id: 10, version_id: 'BONGOS-V1', criterion_id: 'c-one', criterion
 await test('GUARD (sql): the update requires BOTH nothing-pending AND >=1 shipped', () => {
   const src = readFileSync(new URL('../modules/lifecycle/done-when.js', import.meta.url), 'utf8');
   const body = src.slice(src.indexOf('async function autoSatisfyShippedCriteria'));
-  assert.match(body, /HAVING count\(\*\) FILTER \(WHERE t\.status NOT IN \('shipped', 'abandoned'\)\) = 0/,
+  // task 1003588: the literal moved to task-status.js nonTerminalSql(), which
+  // renders this exact predicate - so the guard is asserted here on the CALL,
+  // and below on what that one declaration actually produces.
+  assert.match(body, /HAVING count\(\*\) FILTER \(WHERE \$\{nonTerminalSql\(\)\}\) = 0/,
     'nothing may still be pending');
   assert.match(body, /AND count\(\*\) FILTER \(WHERE t\.status = 'shipped'\) >= 1/,
     'THE GUARD: an all-abandoned gating set delivered nothing and must not close a criterion');
@@ -72,7 +75,7 @@ await test('ASYMMETRY (sql): the review queue deliberately does NOT carry the de
   const start = src.indexOf('async function listPendingReviewCriteria');
   const body = src.slice(start, src.indexOf('async function criterionProgress', start));
   assert.ok(body.length > 200, 'the slice must actually contain the function');
-  assert.match(body, /HAVING count\(\*\) FILTER \(WHERE t\.status NOT IN \('shipped', 'abandoned'\)\) = 0/);
+  assert.match(body, /HAVING count\(\*\) FILTER \(WHERE \$\{nonTerminalSql\(\)\}\) = 0/);
   assert.ok(!/status = 'shipped'\) >= 1/.test(body),
     'task 1002651 intends an all-abandoned criterion to SURFACE for review; only auto-close is gated');
 });
@@ -211,3 +214,22 @@ await test('closeCompletedWorkForShip: silent on the common no-op, and logs what
 });
 
 summary();
+
+// ---- 4. the terminal vocabulary has exactly one spelling (task 1003588) ----
+
+await test('VOCABULARY: nonTerminalSql renders the predicate every call site used to hardcode', async () => {
+  const mod = await import('../modules/lifecycle/task-status.js');
+  const { nonTerminalSql, TERMINAL_STATUSES } = mod.default || mod;
+  assert.deepEqual(TERMINAL_STATUSES, ['shipped', 'abandoned'],
+    'shipped or deliberately abandoned - the mid-ship states are NOT terminal');
+  assert.equal(nonTerminalSql(), "t.status NOT IN ('shipped', 'abandoned')");
+  assert.equal(nonTerminalSql('status'), "status NOT IN ('shipped', 'abandoned')");
+});
+
+await test('VOCABULARY: no consumer re-types the terminal set behind the constant', () => {
+  for (const f of ['done-when.js', 'db-goals.js', 'version-close.js', 'goal-rollup.js']) {
+    const src = readFileSync(new URL('../modules/lifecycle/' + f, import.meta.url), 'utf8');
+    assert.ok(!/NOT IN \('shipped', 'abandoned'\)/.test(src),
+      f + ' must read the terminal set from task-status.js, not spell it again');
+  }
+});

package/tests/goal_sort_staleness.mjs

@@ -156,10 +156,16 @@ await test('the SQL rollup buckets MIRROR goals-lib readinessOf exactly', () =>
   // surface they opened, which is the opposite of what this goal is for.
   const rollup = read('modules/lifecycle/goal-rollup.js');
   const lib = GOALS_LIB_SRC;
-  // done + cut vocabularies
-  assert.match(rollup, /const DONE_STATUSES = \['shipped', 'confirmed', 'completed'\]/);
+  // done + cut vocabularies. task 1003588 moved the server side's declaration
+  // into task-status.js so the module has one spelling of each; the mirror this
+  // test defends is unchanged, it is just read from where the constant now
+  // lives, plus the assertion that goal-rollup.js consumes it rather than
+  // re-declaring a second copy that could drift from the client.
+  const vocab = read('modules/lifecycle/task-status.js');
+  assert.match(rollup, /require\('\.\/task-status'\)/);
+  assert.match(vocab, /const DONE_STATUSES = \['shipped', 'confirmed', 'completed'\]/);
   assert.match(lib, /DONE_STATUSES = new Set\(\['completed', 'confirmed', 'shipped'\]\)/);
-  assert.match(rollup, /const CUT_STATUSES = \['abandoned', 'dropped'\]/);
+  assert.match(vocab, /const CUT_STATUSES = \['abandoned', 'dropped'\]/);
   assert.match(lib, /CUT_STATUSES = new Set\(\['abandoned', 'dropped'\]\)/);
   // blocked = backlog with >=1 unshipped dependency, both sides
   assert.match(rollup, /WHEN s\.status = 'backlog' AND s\.has_unshipped_dep THEN 'blocked'/);