@bongos/core 1.19.545 → 1.19.547

package/tests/skill_lint.mjs

@@ -3,6 +3,8 @@
 import { strict as assert } from 'node:assert';
 import { test } from 'node:test';
 import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import os from 'node:os';
 import path from 'node:path';
 import { fileURLToPath } from 'node:url';
 
@@ -58,11 +60,58 @@ test('no frontmatter at all is an error', () => {
   assert.equal(run('# Title\n\nBody.\n').errors.length, 1);
 });
 
-test('the hook path filter matches only .claude/skills/<name>/SKILL.md', () => {
+test('the hook path filter matches a SKILL.md in either home — .claude/skills/ or a module (task 1003587)', () => {
   assert.ok(lint.isSkillMd('C:\\repo\\.claude\\skills\\dev\\SKILL.md'));
   assert.ok(lint.isSkillMd('/repo/.claude/skills/dev/SKILL.md'));
+  // The module copy is the file a builder EDITS; .claude/skills/ holds the generated
+  // copy, so a hook that only watched the tracked root never saw the real edit.
+  assert.ok(lint.isSkillMd('/repo/modules/ui-design/skills/dev/SKILL.md'));
+  assert.ok(lint.isSkillMd('C:\\repo\\modules\\ui-design\\skills\\vendor\\dev\\SKILL.md'));
   assert.ok(!lint.isSkillMd('/repo/.claude/skills/dev/notes.md'));
-  assert.ok(!lint.isSkillMd('/repo/modules/ui-design/skills/dev/SKILL.md'));
+  assert.ok(!lint.isSkillMd('/repo/modules/ui-design/skills/dev/notes.md'));
+  assert.ok(!lint.isSkillMd('/repo/docs/skills/dev/SKILL.md'));
+});
+
+// A fixture root, because a real dev checkout may or may not have materialized its
+// module skills into .claude/skills/ (claude-materialize.js, task 1003330) and the
+// lister's contract must hold either way.
+function fixtureRoot(files) {
+  const root = fs.mkdtempSync(path.join(os.tmpdir(), 'skill-lint-'));
+  for (const [rel, body] of Object.entries(files)) {
+    const abs = path.join(root, rel);
+    fs.mkdirSync(path.dirname(abs), { recursive: true });
+    fs.writeFileSync(abs, body);
+  }
+  return root;
+}
+
+test('the lister reaches module-owned skills, and a core copy of the same name wins (task 1003587)', () => {
+  const skill = fm('>-\n  A description long enough for the harness to route on, written as a block scalar.');
+  const root = fixtureRoot({
+    '.claude/skills/only-core/SKILL.md': skill,
+    '.claude/skills/both/SKILL.md': skill,
+    'modules/ui-design/skills/both/SKILL.md': skill,
+    'modules/ui-design/skills/only-module/SKILL.md': skill,
+    'modules/ui-design/skills/vendor/vendored/SKILL.md': skill,
+    'modules/ui-design/skills/README.md': '# not a skill\n',
+  });
+  const files = lint.listSkillFiles(root).map((f) => path.relative(root, f).replace(/\\/g, '/'));
+  assert.deepEqual(files.sort(), [
+    '.claude/skills/both/SKILL.md',
+    '.claude/skills/only-core/SKILL.md',
+    'modules/ui-design/skills/only-module/SKILL.md',
+    'modules/ui-design/skills/vendor/vendored/SKILL.md',
+  ], 'a module skill is linted at its source; a name already in .claude/skills/ is not counted twice');
+  fs.rmSync(root, { recursive: true, force: true });
+});
+
+test('every module-owned skill this repo ships parses too — the 14 that did not on 2026-09-04 (task 1003587)', () => {
+  const dir = path.join(ROOT, 'modules', 'ui-design', 'skills');
+  const files = lint.listSkillFiles(ROOT).filter((f) => f.startsWith(dir) || fs.existsSync(path.join(dir, path.basename(path.dirname(f)), 'SKILL.md')));
+  assert.ok(files.length >= 14, `the ui-design module ships 14+ skills; found ${files.length}`);
+  const report = lint.lintSkills(files);
+  const broken = report.results.filter((r) => r.errors.length).map((r) => path.relative(ROOT, r.file) + ': ' + r.errors.join('; '));
+  assert.deepEqual(broken, [], broken.join('\n'));
 });
 
 test('every committed skill parses (the ten that did not on 2026-09-03 must stay fixed)', () => {

package/tests/ui_design_skills.mjs

@@ -34,14 +34,24 @@ const policy = readJson(path.join(SKILLS, 'policy.json'));
 const manifest = readJson(path.join(MODULE, 'module.json'));
 const materialize = require(path.join(ROOT, 'scripts', 'gds', 'claude-materialize.js'));
 
-// Minimal YAML-frontmatter reader: `key: value` lines between the first two `---` fences.
+// Minimal YAML-frontmatter reader: `key: value` lines between the first two `---`
+// fences, plus folded block scalars (`key: >-` then the text indented), which is the
+// only safe way to write a description carrying a colon-space (task 1003587) — a plain
+// scalar with ": " in it makes Claude Code's YAML reader drop EVERY field silently.
 function frontmatter(text) {
   const m = text.match(/^---\n([\s\S]*?)\n---\n/);
   const out = {};
   if (!m) return out;
+  let block = null; // the key whose folded value the indented lines below belong to
   for (const line of m[1].split('\n')) {
     const kv = line.match(/^([A-Za-z][A-Za-z0-9_-]*):\s*(.*)$/);
-    if (kv) out[kv[1]] = kv[2].replace(/^["']|["']$/g, '').trim();
+    if (kv) {
+      const v = kv[2].trim();
+      block = /^[>|][+-]?\d*$/.test(v) ? kv[1] : null;
+      out[kv[1]] = block ? '' : v.replace(/^["']|["']$/g, '').trim();
+      continue;
+    }
+    if (block && /^\s+\S/.test(line)) out[block] = (out[block] ? out[block] + ' ' : '') + line.trim();
   }
   return out;
 }