@bongos/core 1.19.536 → 1.19.538
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.bongos-core.json +37 -22
- package/docs/adr/0248-a-hub-project-s-owner-is-the-provisioning-row-carried-on-a-port.md +144 -0
- package/docs/adr/README.md +1 -0
- package/docs/api/openapi.json +2 -2
- package/docs/api-reference.md +1 -1
- package/docs/module-api-changelog.md +4 -0
- package/modules/platform-identity/invite-authz.js +117 -0
- package/modules/platform-identity/routes/projects.js +49 -22
- package/modules/provisioning/module.json +1 -1
- package/modules/provisioning/provisioning.js +71 -4
- package/modules/provisioning/routes/provisioning.js +21 -1
- package/modules/provisioning/tests/provisioning.mjs +29 -2
- package/package-lock.json +2 -2
- package/package.json +1 -1
- package/src/module-api.js +1 -1
- package/tests/project_catalog_routes.mjs +22 -0
- package/tests/project_invite_ownership.mjs +366 -0
- package/tests/provisioning_module_selection.mjs +114 -5
package/.bongos-core.json
CHANGED
|
@@ -2,22 +2,22 @@
|
|
|
2
2
|
"artifact": "bongos-core",
|
|
3
3
|
"manifest_schema": 1,
|
|
4
4
|
"generator": "scripts/gds/package-core.js",
|
|
5
|
-
"core_version": "1.19.
|
|
6
|
-
"core_contract": "1.19.
|
|
7
|
-
"source_commit": "
|
|
5
|
+
"core_version": "1.19.538",
|
|
6
|
+
"core_contract": "1.19.538",
|
|
7
|
+
"source_commit": "27d5678834bfd261666f02a704b7840851b767e0",
|
|
8
8
|
"source_ref": "HEAD",
|
|
9
|
-
"built_at": "2026-09-04T15:
|
|
9
|
+
"built_at": "2026-09-04T15:34:15.511Z",
|
|
10
10
|
"redaction": {
|
|
11
11
|
"model": "docs-redacted+functional-verbatim",
|
|
12
|
-
"docs_redacted":
|
|
12
|
+
"docs_redacted": 440,
|
|
13
13
|
"agent_docs_stubbed": 24,
|
|
14
|
-
"functional_verbatim":
|
|
14
|
+
"functional_verbatim": 1997,
|
|
15
15
|
"rules": 3,
|
|
16
16
|
"gate_literals": 3,
|
|
17
17
|
"gate": "passed"
|
|
18
18
|
},
|
|
19
|
-
"file_count":
|
|
20
|
-
"tree_sha256": "
|
|
19
|
+
"file_count": 2461,
|
|
20
|
+
"tree_sha256": "4707649225bfa5206e00215584d7af14215d63884dea6d8e45213d98dda405af",
|
|
21
21
|
"files": [
|
|
22
22
|
{
|
|
23
23
|
"path": ".claude/skills/blocker-review/SKILL.md",
|
|
@@ -1749,20 +1749,25 @@
|
|
|
1749
1749
|
"mode": "0000644",
|
|
1750
1750
|
"sha256": "f46ee74d7b83ad4422e1832fdba68a8b9ea0deccb425ab3083d4c8fbfd06eb02"
|
|
1751
1751
|
},
|
|
1752
|
+
{
|
|
1753
|
+
"path": "docs/adr/0248-a-hub-project-s-owner-is-the-provisioning-row-carried-on-a-port.md",
|
|
1754
|
+
"mode": "0000644",
|
|
1755
|
+
"sha256": "cbcac548fc3b683fd7219e312ab1542768c973aca5112d8cbc9ad0b2d09da650"
|
|
1756
|
+
},
|
|
1752
1757
|
{
|
|
1753
1758
|
"path": "docs/adr/README.md",
|
|
1754
1759
|
"mode": "0000644",
|
|
1755
|
-
"sha256": "
|
|
1760
|
+
"sha256": "d5043a4e032d28341a3619a0cf6a6ce54b01ba83af24f2a7b28298da73ff769c"
|
|
1756
1761
|
},
|
|
1757
1762
|
{
|
|
1758
1763
|
"path": "docs/api-reference.md",
|
|
1759
1764
|
"mode": "0000644",
|
|
1760
|
-
"sha256": "
|
|
1765
|
+
"sha256": "aef38c3ecd8942f0a38c56cbb390fd3590e785634d24e95660900a5140636b5f"
|
|
1761
1766
|
},
|
|
1762
1767
|
{
|
|
1763
1768
|
"path": "docs/api/openapi.json",
|
|
1764
1769
|
"mode": "0000644",
|
|
1765
|
-
"sha256": "
|
|
1770
|
+
"sha256": "923202b89890cc048769c8b05087181fa06ff126aa80aeaa4d9f669f4d96c27e"
|
|
1766
1771
|
},
|
|
1767
1772
|
{
|
|
1768
1773
|
"path": "docs/architecture.md",
|
|
@@ -2637,7 +2642,7 @@
|
|
|
2637
2642
|
{
|
|
2638
2643
|
"path": "docs/module-api-changelog.md",
|
|
2639
2644
|
"mode": "0000644",
|
|
2640
|
-
"sha256": "
|
|
2645
|
+
"sha256": "a5362e7ae082e4377ed2bf228a99d7ad0df0e1d059488a819595ef646dd1f1ae"
|
|
2641
2646
|
},
|
|
2642
2647
|
{
|
|
2643
2648
|
"path": "docs/modules-contract.md",
|
|
@@ -5824,6 +5829,11 @@
|
|
|
5824
5829
|
"mode": "0000644",
|
|
5825
5830
|
"sha256": "01d30570d828a1f06ccac693cc5c268d00fb091a13412a3f3890f10828a05203"
|
|
5826
5831
|
},
|
|
5832
|
+
{
|
|
5833
|
+
"path": "modules/platform-identity/invite-authz.js",
|
|
5834
|
+
"mode": "0000644",
|
|
5835
|
+
"sha256": "2eb5577450d3bc1d67b7eab9a13256889aca945c6ac6a6a0ca919e195952b7a1"
|
|
5836
|
+
},
|
|
5827
5837
|
{
|
|
5828
5838
|
"path": "modules/platform-identity/migrations/platform_identity_001_tables.sql",
|
|
5829
5839
|
"mode": "0000644",
|
|
@@ -5977,7 +5987,7 @@
|
|
|
5977
5987
|
{
|
|
5978
5988
|
"path": "modules/platform-identity/routes/projects.js",
|
|
5979
5989
|
"mode": "0000644",
|
|
5980
|
-
"sha256": "
|
|
5990
|
+
"sha256": "dac39b920025d696ba34e20aa4a9fbfb70d1cbc9ffe8f3b0da823f333d6a8d7a"
|
|
5981
5991
|
},
|
|
5982
5992
|
{
|
|
5983
5993
|
"path": "modules/platform-identity/routes/public-profile.js",
|
|
@@ -6097,7 +6107,7 @@
|
|
|
6097
6107
|
{
|
|
6098
6108
|
"path": "modules/provisioning/module.json",
|
|
6099
6109
|
"mode": "0000644",
|
|
6100
|
-
"sha256": "
|
|
6110
|
+
"sha256": "c451d94736219198d10d1bb8837ff9aecd6d4f90f8bf46790deba38f0d2168ec"
|
|
6101
6111
|
},
|
|
6102
6112
|
{
|
|
6103
6113
|
"path": "modules/provisioning/onboard-plan.js",
|
|
@@ -6112,7 +6122,7 @@
|
|
|
6112
6122
|
{
|
|
6113
6123
|
"path": "modules/provisioning/provisioning.js",
|
|
6114
6124
|
"mode": "0000644",
|
|
6115
|
-
"sha256": "
|
|
6125
|
+
"sha256": "39635718015b8fcb0cf5d21f3769e292e129bfe312b5802d073ef63b0d8b7b1e"
|
|
6116
6126
|
},
|
|
6117
6127
|
{
|
|
6118
6128
|
"path": "modules/provisioning/rate-limit.js",
|
|
@@ -6132,7 +6142,7 @@
|
|
|
6132
6142
|
{
|
|
6133
6143
|
"path": "modules/provisioning/routes/provisioning.js",
|
|
6134
6144
|
"mode": "0000644",
|
|
6135
|
-
"sha256": "
|
|
6145
|
+
"sha256": "00585a2de10a05c814fb0c1ad3cd6b564096b70b7729695b54953ab98c75601b"
|
|
6136
6146
|
},
|
|
6137
6147
|
{
|
|
6138
6148
|
"path": "modules/provisioning/starter-bundles.js",
|
|
@@ -6147,7 +6157,7 @@
|
|
|
6147
6157
|
{
|
|
6148
6158
|
"path": "modules/provisioning/tests/provisioning.mjs",
|
|
6149
6159
|
"mode": "0000644",
|
|
6150
|
-
"sha256": "
|
|
6160
|
+
"sha256": "aac930ed566f9b6fb7ec9fa4e240f42025e854369a94f6a8c63aa20b5d1995a8"
|
|
6151
6161
|
},
|
|
6152
6162
|
{
|
|
6153
6163
|
"path": "modules/provisioning/ui/.gitkeep",
|
|
@@ -7392,12 +7402,12 @@
|
|
|
7392
7402
|
{
|
|
7393
7403
|
"path": "package-lock.json",
|
|
7394
7404
|
"mode": "0000644",
|
|
7395
|
-
"sha256": "
|
|
7405
|
+
"sha256": "8043c81f64ede9c38cdae0f527ba8fc6d3ce04f9c3ca99846dbb1b88e5b67aa6"
|
|
7396
7406
|
},
|
|
7397
7407
|
{
|
|
7398
7408
|
"path": "package.json",
|
|
7399
7409
|
"mode": "0000644",
|
|
7400
|
-
"sha256": "
|
|
7410
|
+
"sha256": "9845a25af2217c1713641a4ae22c09c5686af460ee7e55ec269a733dbc573ca7"
|
|
7401
7411
|
},
|
|
7402
7412
|
{
|
|
7403
7413
|
"path": "public-docs/index.html",
|
|
@@ -9082,7 +9092,7 @@
|
|
|
9082
9092
|
{
|
|
9083
9093
|
"path": "src/module-api.js",
|
|
9084
9094
|
"mode": "0000644",
|
|
9085
|
-
"sha256": "
|
|
9095
|
+
"sha256": "2327888e4ad6a89296b1e8aab4237bd90d301debb313576c109850b450903eb0"
|
|
9086
9096
|
},
|
|
9087
9097
|
{
|
|
9088
9098
|
"path": "src/module-loader/catalog.js",
|
|
@@ -11307,13 +11317,18 @@
|
|
|
11307
11317
|
{
|
|
11308
11318
|
"path": "tests/project_catalog_routes.mjs",
|
|
11309
11319
|
"mode": "0000644",
|
|
11310
|
-
"sha256": "
|
|
11320
|
+
"sha256": "afef4620252bc212b4326863abb021e8cd6033e258345e44cf78e97fc3b28b63"
|
|
11311
11321
|
},
|
|
11312
11322
|
{
|
|
11313
11323
|
"path": "tests/project_door_ui.mjs",
|
|
11314
11324
|
"mode": "0000644",
|
|
11315
11325
|
"sha256": "29f59ab64b231a7ec5d17a3e784d451f75d80c19efd4cb6a523d263e8f88b581"
|
|
11316
11326
|
},
|
|
11327
|
+
{
|
|
11328
|
+
"path": "tests/project_invite_ownership.mjs",
|
|
11329
|
+
"mode": "0000644",
|
|
11330
|
+
"sha256": "743436b1191353bf687d8fb553d423a6003707a25a548367644928478569f171"
|
|
11331
|
+
},
|
|
11317
11332
|
{
|
|
11318
11333
|
"path": "tests/project_join_door.mjs",
|
|
11319
11334
|
"mode": "0000644",
|
|
@@ -11407,7 +11422,7 @@
|
|
|
11407
11422
|
{
|
|
11408
11423
|
"path": "tests/provisioning_module_selection.mjs",
|
|
11409
11424
|
"mode": "0000644",
|
|
11410
|
-
"sha256": "
|
|
11425
|
+
"sha256": "92db65b8da5b849379bab03e70287239deab8b9a2b2e47b4574f12b8acac013e"
|
|
11411
11426
|
},
|
|
11412
11427
|
{
|
|
11413
11428
|
"path": "tests/provisioning_onboard_mode.mjs",
|
|
@@ -0,0 +1,144 @@
|
|
|
1
|
+
# ADR 0248 — A hub project's owner is the provisioning row, carried on a port and bound to both halves of the catalog projection
|
|
2
|
+
|
|
3
|
+
- **Status:** accepted
|
|
4
|
+
- **Date:** 2026-09-04
|
|
5
|
+
- **Task:** [task 1003580](https://cloudbongos.com/builders#/task/1003580) (BONGOS-V1, goal 1000046 — *Project creation*, criterion `proj-invite-builders` / C6), GAP 2
|
|
6
|
+
- **Deciders:** Claude, under the Archon's standing scope
|
|
7
|
+
- **Implements:** [ADR 0246](<redacted>.md)'s named remainder — *"what remains there is purely the ownership branch… the ownership proof it should carry is `provisioning_instances.owner_builder_id`"*
|
|
8
|
+
- **Related:** [ADR 0210](<redacted>.md) (owner-or-rank as one middleware; the atom stays spelled in the route's own list) · [ADR 0238](<redacted>.md) (the hub's `owner_github_id` columns are attribution, never authority) · [ADR 0083](<redacted>.md) (the one-way module rule — why this travels on a port) · [ADR 0182](<redacted>.md) D2a (a stealth project is anonymous, so a refusal may not identify it) · [ADR 0016](<redacted>.md) (fail-closed authority)
|
|
9
|
+
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
## Context
|
|
13
|
+
|
|
14
|
+
`POST /projects/invite` is gated `requirePermission('project.curate')`, floor `metic`
|
|
15
|
+
([ADR 0157](<redacted>.md)). It is a **curation** gate:
|
|
16
|
+
`requirePermission` is purely grant/rank-based and has no own-scope branch. The creation
|
|
17
|
+
wizard's audience is any signed-in GitHub user — on the hub, typically a `xenos` holding
|
|
18
|
+
nothing at all. So the person who created a project got **403 on inviting anyone into their
|
|
19
|
+
own project**, and BV1.R27 ([task 1002346](https://cloudbongos.com/builders#/task/1002346)),
|
|
20
|
+
R28, R29 and the C6 proof all sat behind it.
|
|
21
|
+
|
|
22
|
+
ADR 0246 closed the other half (the project is now a resolvable catalog row) and named this
|
|
23
|
+
one as its own decision, with the constraint it has to answer to: **ADR 0238 says the hub's
|
|
24
|
+
ownership columns are attribution, not authority.** Lowering `project.curate`'s floor is not
|
|
25
|
+
available either — the same reason ADR 0210 gives: a floor is a rank, ownership is a
|
|
26
|
+
relationship, and no floor low enough to reach a project's registrant excludes anybody.
|
|
27
|
+
|
|
28
|
+
## Decision
|
|
29
|
+
|
|
30
|
+
**Admit a `project.curate` holder OR the project's own owner, where "owner" means
|
|
31
|
+
`provisioning_instances.owner_builder_id` — asked of provisioning through a kernel port, and
|
|
32
|
+
bound to BOTH halves of the ADR 0246 projection.** Three parts:
|
|
33
|
+
|
|
34
|
+
1. **The proof is the provisioning row.** That column is the authority `instanceAccessDenied`
|
|
35
|
+
already enforces on every owner-facing provisioning route (the manage page, both settings
|
|
36
|
+
routes, the detail answers). The hub's `sso_clients.owner_github_id` and
|
|
37
|
+
`platform_identity_projects.owner_github_id` stay what their migration comment and ADR 0238
|
|
38
|
+
say they are: attribution. Nothing here promotes them.
|
|
39
|
+
|
|
40
|
+
2. **It travels on a NEW port, in the direction ADR 0246 did not open.** `project.catalog`
|
|
41
|
+
carries a write hub-ward (provisioning → platform-identity); this question runs the other
|
|
42
|
+
way, so provisioning provides **`provisioning.projectOwnedBy` ({ slug, host, builderId }) →
|
|
43
|
+
boolean**, registered beside `provisioning.instanceState`. platform-identity resolves it
|
|
44
|
+
with `resolveOptional` and does **not** declare it in `consumes` (the
|
|
45
|
+
`provisioning.projectPlanets` precedent): provisioning is `default: false`, and a hub
|
|
46
|
+
without it simply has no control-plane project to own. **A boolean, not the owner's id** —
|
|
47
|
+
the comparison is authority and belongs on the plane holding the row, so no consumer ever
|
|
48
|
+
handles an ownership fact it could mis-compare.
|
|
49
|
+
|
|
50
|
+
3. **The question names both halves of the projection.** ADR 0246 puts a project on the map as
|
|
51
|
+
`client_id = slug` at `origin = https://<domain>`, and the port answers only when the
|
|
52
|
+
caller owns the instance carrying **both**, in one statement. Matching the slug alone would
|
|
53
|
+
let whoever registers an instance *named after* a client the control plane never created —
|
|
54
|
+
a hand-seeded row, whose origin the catalog's own claim rule (ADR 0246 rule 1) already
|
|
55
|
+
refuses to overwrite — speak for that project. The invite arm answers to the same binding
|
|
56
|
+
the catalog write does.
|
|
57
|
+
|
|
58
|
+
### The OR is one middleware, and the atom stays spelled in the route
|
|
59
|
+
|
|
60
|
+
`modules/platform-identity/invite-authz.js` is `scouting-authz.js`'s shape, and it is that
|
|
61
|
+
shape for ADR 0210's reasons, restated because they are load-bearing rather than stylistic:
|
|
62
|
+
|
|
63
|
+
- **`requirePermission('project.curate')` is built in the route's own middleware list** and
|
|
64
|
+
handed to the helper. A gate hidden inside a helper is invisible to `route-rank-check.js`
|
|
65
|
+
and `gen-api-docs.js`, which classify a route from its middleware — this route would have
|
|
66
|
+
been recorded `any-builder`, wrong in the dangerous direction, and the published API
|
|
67
|
+
reference would have said so. It still classifies `metic+archon` with
|
|
68
|
+
`x-permissions: ["project.curate"]`; the "or owner" lives in the description, which is the
|
|
69
|
+
same over-strict-but-safe answer ADR 0210 accepted.
|
|
70
|
+
- **Ownership is asked FIRST, and a refusal falls through to the UNMODIFIED gate.** Asking the
|
|
71
|
+
permission gate first is not available: a middleware that has denied has already *sent* its
|
|
72
|
+
response, so there is nothing to fall through from. Paying one extra lookup on the curator
|
|
73
|
+
path is what makes the 403 byte-identical — same code, same `required`/`held`, same floors
|
|
74
|
+
map. **The widening can only ever ADMIT; it cannot change, soften, or swallow a refusal.**
|
|
75
|
+
|
|
76
|
+
### The refusal is not an existence oracle — in body OR in latency
|
|
77
|
+
|
|
78
|
+
This is why the gate runs **before** the target is resolved rather than after. Resolving first
|
|
79
|
+
and then authorizing would split the answer into 404-for-absent and 403-for-present, handing
|
|
80
|
+
any signed-in stranger a membership oracle over every private project on the platform —
|
|
81
|
+
exactly what ADR 0182 D2a's server-side anonymisation exists to prevent. Because the gate
|
|
82
|
+
delegates to the untouched permission middleware, a stranger's refusal is identical for a real
|
|
83
|
+
project, a stealth project, a project that does not exist, and a malformed body; the gate runs
|
|
84
|
+
before the body validator, exactly as `requirePermission` always did.
|
|
85
|
+
|
|
86
|
+
**A body-identical refusal that is measurably faster is still an oracle**, so every path does
|
|
87
|
+
the same two reads. An unknown `client_id` is asked about anyway, with the empty host, and
|
|
88
|
+
`projectOwnedBy` **queries** it rather than short-circuiting: an empty host names no address
|
|
89
|
+
and matches nothing (`domain` is a hostname or NULL, and `lower(NULL) = ''` is NULL), so it is
|
|
90
|
+
a real round-trip with a guaranteed-empty result rather than a dummy delay. That is the one
|
|
91
|
+
place in this design where the cheap-looking early return is the wrong call, and it is written
|
|
92
|
+
into the function's own doc-comment so a later "optimisation" cannot quietly reopen the
|
|
93
|
+
channel. Equalising the lookup must not DUPLICATE it, so the resolved row rides forward on
|
|
94
|
+
`req.inviteTargetClient` (the `req.builder` / `req.rawPermissionKeys` precedent) and the
|
|
95
|
+
handler reads it instead of fetching the same row again.
|
|
96
|
+
|
|
97
|
+
## Consequences
|
|
98
|
+
|
|
99
|
+
- **[task 1002346](https://cloudbongos.com/builders#/task/1002346) (BV1.R27) is unblocked**, and
|
|
100
|
+
is the pure wizard-step task it was scoped as. The route path, body and responses are
|
|
101
|
+
unchanged: `POST /api/bongos/projects/invite` with `{ client_id, github_login }` → `201
|
|
102
|
+
{ invited: true, row }` on a fresh invite, `200 { invited: false, alreadyMember: true }` when
|
|
103
|
+
the membership already exists.
|
|
104
|
+
- **Owning a project buys exactly one act on the hub** — pre-seeding a `pending` membership on
|
|
105
|
+
your own project. No rank, no curation, no read of anyone else's project, and nothing else
|
|
106
|
+
consults it. The reverse also holds: this reads ownership and grants none.
|
|
107
|
+
- **Fail-closed in three directions.** No provisioning module → the old door, unchanged. A
|
|
108
|
+
throwing ownership check → the old door, unchanged (never a 500, never an admit). A
|
|
109
|
+
non-string `client_id` → not a claim, and neither the port nor the client registry is asked.
|
|
110
|
+
- **Every caller now costs two indexed reads before the permission gate runs**, including one
|
|
111
|
+
who will be refused. That is the deliberate price of equal latency on a cold, authenticated
|
|
112
|
+
route; it is bounded (two primary-key/`LIMIT 1` lookups) and it is why the equalisation is
|
|
113
|
+
affordable here and would not be on a hot public path.
|
|
114
|
+
- **A re-pointed co-tenant project can lose the own arm.** The catalog's claim rule 1 refuses
|
|
115
|
+
to rewrite a *credentialed* client's origin, so a federated project that moves address keeps
|
|
116
|
+
a stale `origin` while its provisioning row carries the new domain, and the binding stops
|
|
117
|
+
matching. That degrades to curator-only — the safe direction — and is named here so the next
|
|
118
|
+
reader recognises it rather than rediscovering it as a bug.
|
|
119
|
+
- **The port is a general capability with one consumer.** Any future hub surface that wants to
|
|
120
|
+
own-scope a control-plane project asks the same question rather than inventing a second
|
|
121
|
+
answer — which is what keeps a hub ownership column from being promoted to authority the
|
|
122
|
+
next time this comes up.
|
|
123
|
+
|
|
124
|
+
## Alternatives rejected
|
|
125
|
+
|
|
126
|
+
- **Read `sso_clients.owner_github_id` (candidate B as originally scouted).** Rejected: it is
|
|
127
|
+
the exact thing its own migration comment and ADR 0238 forbid — a hub catalog column with no
|
|
128
|
+
instance behind it, writable by hub curation, and NULL on the hand-seeded rows.
|
|
129
|
+
- **Lower `project.curate`'s floor to `xenos`.** Rejected on ADR 0210's grounds: it would admit
|
|
130
|
+
every stranger who ever signed in, to every project on the platform.
|
|
131
|
+
- **Mint a `project.invite.own` ownership-scoped atom** and use `authorizeOwnedOrAny`.
|
|
132
|
+
Rejected: the ownership-scoped axis resolves the *rank* fact from a catalog floor and the
|
|
133
|
+
*owner* fact from a row the handler loaded, and here the owner fact lives on another module's
|
|
134
|
+
plane entirely — so the atom would still need this port, plus a catalog-floor change this
|
|
135
|
+
task is not authorised to make. The recruiting wave's `project.recruit`
|
|
136
|
+
([spike 1002786](https://cloudbongos.com/builders#/task/1002786) R3) is where a new atom is
|
|
137
|
+
defined; when it lands it replaces the `project.curate` half of this OR and the ownership
|
|
138
|
+
half is unaffected — the same seam ADR 0210 left.
|
|
139
|
+
- **Key the ownership question on the slug alone.** Rejected: see decision 3 — it makes a
|
|
140
|
+
hand-seeded catalog row's name a squattable claim on that project's membership directory.
|
|
141
|
+
- **Reuse the `membership_kind = 'owner'` proof `scouting-authz.js` uses.** Rejected: that row
|
|
142
|
+
is written by a federated instance's `POST /sso/membership/check-in`, which a standalone
|
|
143
|
+
wizard-made project never calls — it would be empty for exactly the audience this task
|
|
144
|
+
exists to admit.
|
package/docs/adr/README.md
CHANGED
|
@@ -334,6 +334,7 @@ This keeps the decision history honest and traceable.
|
|
|
334
334
|
| 0245 | [**The way back into an optional step is that step’s own answer route** ([task 1002342](https://cloudbongos.com/builders#/task/1002342) · goal 1000046, criterion `proj-module-select`). R20 ([ADR 0240](<redacted>.md)) made the create wizard’s module picker skippable and left a project’s module set write-once — the route file said so out loud (“there is no mutation route yet”). R23 closes it WITHOUT a new endpoint: `modules` joins `description` and `detail` on `PATCH /provisioning/instances/:id/detail`, because the wizard’s two optional steps are the same kind of thing — asked optionally at creation, stored on the platform row, reaching no running instance — and that route already carried the ownership gate, the `api:self`/`api:archon:<id>` actor rule, the 404-no-existence-leak shape, and (since [ADR 0243](<redacted>.md)) an `effectiveModules` answer it could report but not set. Deliberately NOT the settings channel: a setting is a policy the running instance obeys and would queue a restart to deliver a value the instance does not read. Only an ARRAY is a change — an omitted or null key leaves the column alone — so the three-valued contract’s `NULL` (“never asked”) stays unreachable by a later edit, and `modules` REPLACES where `detail` merges, because a merging write would make removal impossible. The surface is the manage view’s extras band (`/projects?view=manage&id=N`), where a toggle IS the save and the band repaints from the platform’s answer rather than from what was sent.](<redacted>.md) | provisioning / project creation |
|
|
335
335
|
| 0244 | [**A catalog search is a view over the rows, never an edit to the selection** ([task 1002340](https://cloudbongos.com/builders#/task/1002340) · goal 1000046, criterion `proj-module-select`). The creation picker ([ADR 0240](<redacted>.md)) paints one toggle per optional module, and the catalog is meant to grow — so R21 adds a keyword search over it. A search over a list of links is trivial; a search over a list of TOGGLES is not, because the list is also an answer. Two failure modes follow from letting a row be hidden: the filter **edits** the answer (narrow the rendered array and the read-back array together, and typing `discord` then pressing Next files one module instead of three — silently, with every screen looking right), or the filter **lies** about it (a switched-on module off screen reads as switched off, which is [ADR 0237](<redacted>.md)’s "a preselect they have to audit" in its harsher form — one they cannot see at all). **Decision: the search is a VIEW and `state.modules` is the answer; the view may not write to it.** `moduleQuery` is a plain variable, never part of the draft, so `saveDraft` is not called from the input handler and a search can never turn an untouched picker into an answered one (ADR 0240’s `null` survives); `visibleModules()` derives the shown rows per render while `pickedModules()`, `modulesForCreate()` and `extrasRow()` keep reading the whole catalog; and the panel STATES what the filter is hiding — one line under the field counting what is **on**, not what is visible. Matching is `moduleMatches(mod, terms)`, a pure function: lower-cased **label + summary + key** as one haystack, every whitespace-separated term an AND’d substring. AND because adding a word means the list is still too long; substring because a filter that shows nothing until you finish typing reads as broken; the key because that is what a returning owner names a module by. No ranking (reordering toggles under a typing hand is worse than not), and deliberately **not semantic** — by-meaning search is deferred with the rest of the creation AI layer (idea 1000552). Rejected: filtering the read-back array (failure mode 1), CSS-hiding non-matches (leaves invisible `aria-pressed` toggles in the a11y tree), pinning switched-on rows above the query (a filter that lies the other way), persisting the query in the draft, and debouncing a pass over already-loaded rows.](<redacted>.md) |
|
|
336
336
|
| 0247 | [**The join door is ONE composed answer, and dark matter has no live verdict to compose with yet** ([task 1002331](https://cloudbongos.com/builders#/task/1002331) · goal 1000046, criterion `proj-join-policy`). [ADR 0182](<redacted>.md) D6 wrote the rule — visibility is the ceiling, join policy may only narrow it — and nothing implemented it: the public `POST /access-requests` read `joinability` alone, so an owner could set their project private or stealth on the map and the application endpoint behaved exactly as before. R12 adds the third knob (`join_grant` = view | apply | full, one line of settings vocabulary, default `full` so nothing existing changes) and composes all three in one pure kernel file, `src/bongos/project-door.js`, published through the doorway so no module can re-open a door the others closed. Three things worth carrying: the door vocabulary is a list ordered widest→strictest, so “the stricter wins” is the data structure rather than a branch; the refusal never names WHICH knob closed the door, because a stealth project that could be identified by its 403 gives back exactly what R06’s server-side redaction protects; and `locked` (dark matter) is specified, tested and deliberately UNWIRED — the instance cannot derive publishability (no description in its pack, and a pushed verdict goes stale the moment the owner writes one), while the hub’s cached copy says every live project is dark matter today, so enforcing off it would refuse every join on the platform.](<redacted>.md) | onboarding / provisioning / project creation |
|
|
337
|
+
| 0248 | [**A hub project’s owner is the provisioning row, carried on a port and bound to both halves of the catalog projection** ([task 1003580](https://cloudbongos.com/builders#/task/1003580) · goal 1000046, criterion `proj-invite-builders`). [ADR 0246](<redacted>.md) made a wizard-made project resolvable by `POST /projects/invite` and named the remainder: the route is gated `project.curate` (floor metic) with no own-scope arm, so the project’s own owner — a `xenos` on the hub — got 403 on their own project, blocking BV1.R27–R29 and the C6 proof. The arm admits a `project.curate` holder **OR** the owner, where owner means `provisioning_instances.owner_builder_id` — never the hub’s `owner_github_id` columns, which [ADR 0238](<redacted>.md) fixes as attribution. Three things worth carrying: the fact travels on a NEW port `provisioning.projectOwnedBy` answering a **boolean**, so the comparison stays on the plane that holds the row and no consumer handles an ownership id it could mis-compare; the port is asked about **both halves of the ADR 0246 projection** (slug AND origin), because a hand-seeded catalog row’s name is otherwise a squattable claim on that project’s membership directory; and ownership is asked BEFORE the target is resolved, so the refusal stays the untouched `requirePermission` 403 and cannot become an existence oracle over stealth projects ([ADR 0182](<redacted>.md) D2a). The atom stays spelled in the route’s own middleware list ([ADR 0210](<redacted>.md)’s rule), so the route still classifies `metic+archon`.](<redacted>.md) | onboarding / provisioning / project creation |
|
|
337
338
|
|
|
338
339
|
| 0246 | [**Catalog membership is a projection of the provisioning row, not a side effect of federation** ([task 1003576](https://cloudbongos.com/builders#/task/1003576) · goal 1000046, criterion `proj-detail-interview` / C3). The BV1.R18 proof ([task 1002337](https://cloudbongos.com/builders#/task/1002337)) demonstrated C3 against live and found its last clause — “then it publishes” — structurally false: the owner’s verdict reads `provisioning_instances` while the public map reads `platform_identity_projects`, and the ONLY bridge was `federateInstance → registerClient → upsertProject`, which `shouldFederate` refuses for anything but `co-tenant` (the wizard hard-codes `standalone`) and which runs ONCE, at provision time, through a COALESCE. So a wizard-made project was never catalogued at all and a co-tenant one that answered later never updated — `publishable: true`, `{"projects": []}`, forever. The same missing row is [task 1003580](https://cloudbongos.com/builders#/task/1003580)’s GAP 1: `POST /projects/invite` resolves against `platform_identity_sso_clients`, whose only writer is that same `registerClient`. Underneath is one conflation — federation mints CREDENTIALS and was incidentally the only thing that minted MEMBERSHIP, while [ADR 0182](<redacted>.md) D4 already fixed the map’s gate at IDENTITY, which has nothing to do with hosting topology. **Decision: the catalog row is a PROJECTION of the provisioning row, re-derived at every write that can change its inputs** — two halves, neither sufficient alone. (1) THE ROW SHAPE: every control-plane project gets both rows whatever its hosting shape, and the client row carries NO credential (`secret_hash = ''`, `redirect_uris = '{}'`), so **the shape is the enforcement** rather than a flag a caller could forget — `redirectUriAllowed` refuses `/sso/authorize`, `clientSecretValid` refuses `/sso/token`, `/sso/membership/check-in` and `/sso/activity/rollup`, and the one leg that checked NEITHER (`/sso/device/start`, which resolves a client from a user-typed origin) grew an explicit `clientIsCredentialed` guard. (2) THE TIMING: re-taken on create, on `PATCH …/detail`, on `PATCH …/settings` when the door changes, and on `POST …/domain` (which re-keys the row, retiring the abandoned origin — [ADR 0181](0181-teardown-state-gate-and-address-retention.md) §2’s leak, in the catalog instead of DNS). **NO MIGRATION** — `secret_hash` is `NOT NULL` and `''` satisfies it while hashing to nothing. `description` and `visibility` are ASSIGNED, not COALESCEd (clearing a description must UN-publish); `featured`/`tagline`/`art_url`/`template` are curation and stay untouched, so [ADR 0182](<redacted>.md) D3 holds. It grants nothing — the row is attribution per [ADR 0238](<redacted>.md), ownership stays `provisioning_instances.owner_builder_id` — and because it writes rows keyed on owner-supplied values (a slug, a BYO domain) each write carries its **claim rule in the ON CONFLICT action’s own WHERE**: the client is refreshed only `WHERE secret_hash = ''` (a real client’s origin, which binds the CLI mint audience, can never be rewritten) and the project only `WHERE owner_github_id = EXCLUDED.owner_github_id` (`NULL = anything` is not true, so the hand-seeded rows cannot be claimed). Writing `visibility` does not contradict [ADR 0182](<redacted>.md) D5: the hub authorizes nothing — the authority already ran on the provisioning plane ([ADR 0238](<redacted>.md)’s own-scoped, audited PATCH), and a project the control plane does NOT own has no provisioning row, so D5’s instance report (R08) stays the only channel for those. `tearing_down`/`torn_down` project `hidden`; a `no_address` instance is not catalogued at all. Travels on the kernel port `project.catalog`, the `project.publishGate` seam in the other direction ([ADR 0083](<redacted>.md) forbids the import). Rejected: extending `shouldFederate` to every shape (hands a real secret to instances whose web.env the platform does not write, and keeps the once-at-standup bug); bridging only at the publish moment (leaves the invite with nothing to resolve); registering only at standup (the bug itself); a `catalog_only` boolean column (needs a migration and is weaker than the shape); letting the bridge write `featured`; and backfilling the three existing catalog rows from code.](<redacted>.md) | provisioning / project creation |
|
|
339
340
|
|
package/docs/api/openapi.json
CHANGED
|
@@ -11162,7 +11162,7 @@
|
|
|
11162
11162
|
"projects"
|
|
11163
11163
|
],
|
|
11164
11164
|
"summary": "POST /projects/invite",
|
|
11165
|
-
"description": "invite a builder into a project (ADR 0141 §5, task #1002115). Pre-seeds a 'pending' membership the invitee accepts from My Projects. V1 invites by github_login and requires the invitee to already have a platform account (they build on some project); inviting someone entirely new to the platform (GitHub-id resolution) is a follow-up.\n\n**Rank:** `metic+archon` — Metic or Archon rank (review/triage powers).\n\n**Permissions:** `project.curate` (all required).",
|
|
11165
|
+
"description": "own-or-metic in effect: invite a builder into a project (ADR 0141 §5, task #1002115), called by a `project.curate` holder OR the project's OWN OWNER (task 1003580; the ownership proof is `provisioning_instances.owner_builder_id`, reached through a port — see invite-authz.js). The wizard's audience is any signed-in GitHub user, typically a xenos who used to get 403 on their own project. A caller who is neither gets the unchanged permission refusal, identical whether or not the project exists. Pre-seeds a 'pending' membership the invitee accepts from My Projects. V1 invites by github_login and requires the invitee to already have a platform account (they build on some project); inviting someone entirely new to the platform (GitHub-id resolution) is a follow-up.\n\n**Rank:** `metic+archon` — Metic or Archon rank (review/triage powers).\n\n**Permissions:** `project.curate` (all required).",
|
|
11166
11166
|
"x-rank": "metic+archon",
|
|
11167
11167
|
"x-source": "modules/platform-identity/routes/projects.js",
|
|
11168
11168
|
"x-permissions": [
|
|
@@ -11555,7 +11555,7 @@
|
|
|
11555
11555
|
"provisioning"
|
|
11556
11556
|
],
|
|
11557
11557
|
"summary": "PATCH /provisioning/instances/:id/detail",
|
|
11558
|
-
"description": "── The optional project detail (task 1002334, goal 1000046) ────────────── PATCH /provisioning/instances/:id/detail — answer (or re-answer) the wizard's OPTIONAL creation steps after creation. Body: any subset of { description, detail, modules }. rank: any authenticated builder (own resource; archon may change any — same gate as settings). THIS ROUTE IS WHAT MAKES THE STEP SKIPPABLE. Skipping at creation leaves the project dark-matter — off the map and un-joinable (ADR 0182 D4) — and that is a supported default only because there is a way back. Without this route \"optional\" would mean \"permanently unpublishable\", i.e. a dead end, which is precisely what criterion `proj-detail-interview` refuses. Deliberately NOT a settings-apply: nothing here is a policy the running instance obeys, so there is no web.env to patch and no restart to queue. The answers live on the platform row until a catalog row materializes (the provisioning_007 `type` precedent), and R16 (task 1002335) is the surface that reads `description` to compute publishability and name what is still missing. `modules` rides the SAME route for the same reason (BV1.R23, task 1002342, ADR 0245): step 4 of the wizard is skippable exactly as step 3 is, so it needs the same way back, and it lands on the same platform row under the same ownership gate. Only an ARRAY is a change — an omitted or null key leaves the column alone, so the \"never asked\" NULL (ADR 0240 §2) can never be written by a later edit. The always-on core stays unremovable by construction: badModuleSelection refuses its keys and `effectiveModules` re-adds it on read.\n\n**Rank:** `any-builder` — Any authenticated builder (row-level ownership enforced in-handler).",
|
|
11558
|
+
"description": "── The optional project detail (task 1002334, goal 1000046) ────────────── PATCH /provisioning/instances/:id/detail — answer (or re-answer) the wizard's OPTIONAL creation steps after creation. Body: any subset of { description, detail, modules }. rank: any authenticated builder (own resource; archon may change any — same gate as settings). THIS ROUTE IS WHAT MAKES THE STEP SKIPPABLE. Skipping at creation leaves the project dark-matter — off the map and un-joinable (ADR 0182 D4) — and that is a supported default only because there is a way back. Without this route \"optional\" would mean \"permanently unpublishable\", i.e. a dead end, which is precisely what criterion `proj-detail-interview` refuses. Deliberately NOT a settings-apply: nothing here is a policy the running instance obeys, so there is no web.env to patch and no restart to queue. The answers live on the platform row until a catalog row materializes (the provisioning_007 `type` precedent), and R16 (task 1002335) is the surface that reads `description` to compute publishability and name what is still missing. `modules` rides the SAME route for the same reason (BV1.R23, task 1002342, ADR 0245): step 4 of the wizard is skippable exactly as step 3 is, so it needs the same way back, and it lands on the same platform row under the same ownership gate. Only an ARRAY is a change — an omitted or null key leaves the column alone, so the \"never asked\" NULL (ADR 0240 §2) can never be written by a later edit. The always-on core stays unremovable by construction: badModuleSelection refuses its keys and `effectiveModules` re-adds it on read. AN ANSWER CAN BE TAKEN BACK (task 1003577). `detail` merges, so before this the first `team_shape` an owner sent was permanent — and \"never answered\" is a state `effectiveModules` reads (ADR 0240), not merely the absence of one. Sending `detail: { <key>: null }` UN-ANSWERS that question: the key is dropped from the jsonb, so the row reads back exactly as one that was never asked and the bundle the answer moved moves back. Only null does it — an empty string or any other value is still refused as off-vocabulary, and `detail: {}` still changes nothing, because a form that collected no answers is not asking for any to be erased.\n\n**Rank:** `any-builder` — Any authenticated builder (row-level ownership enforced in-handler).",
|
|
11559
11559
|
"x-rank": "any-builder",
|
|
11560
11560
|
"x-source": "modules/provisioning/routes/provisioning.js",
|
|
11561
11561
|
"parameters": [
|
package/docs/api-reference.md
CHANGED
|
@@ -457,7 +457,7 @@ Base path: `/api/bongos`. Ranks (enforced server-side, [ADR 0016](adr/<redacted>
|
|
|
457
457
|
| POST | `/api/bongos/projects` | `metic+archon` | `origin`, `name`, `tagline`, `description`, `art_url`, `type`, `template` | create / update a catalog entry (manual seed for hand-wired instances; federated projects auto-catalogue at registration). |
|
|
458
458
|
| PATCH | `/api/bongos/projects/:id/featured` | `metic+archon` | `featured` | the feature / unfeature control (the ADR 0141 §5 curation gate), BOUNDED BY THE PUBLISH GATE (ADR 0182 D3, task 1002335). |
|
|
459
459
|
| GET | `/api/bongos/projects/featured` | `public` | — | the public map of projects; no auth by design. |
|
|
460
|
-
| POST | `/api/bongos/projects/invite` | `metic+archon` | `client_id`, `github_login` | invite a builder into a project (ADR 0141 §5, task #1002115). |
|
|
460
|
+
| POST | `/api/bongos/projects/invite` | `metic+archon` | `client_id`, `github_login` | own-or-metic in effect: invite a builder into a project (ADR 0141 §5, task #1002115), called by a `project.curate` holder OR the project'… |
|
|
461
461
|
|
|
462
462
|
## `provisioning` (21)
|
|
463
463
|
|
|
@@ -1521,5 +1521,9 @@ is load-bearing: the script throws rather than guess if it is missing, and
|
|
|
1521
1521
|
landed since 1.19.534 with no explicit bump. run 33886686350. (task 1002620)
|
|
1522
1522
|
1.19.536 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
|
|
1523
1523
|
landed since 1.19.535 with no explicit bump. run 33888048777. (task 1002620)
|
|
1524
|
+
1.19.537 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
|
|
1525
|
+
landed since 1.19.536 with no explicit bump. run 33888812605. (task 1002620)
|
|
1526
|
+
1.19.538 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
|
|
1527
|
+
landed since 1.19.537 with no explicit bump. run 33890191596. (task 1002620)
|
|
1524
1528
|
---------------------------------------------------------------------------
|
|
1525
1529
|
```
|
|
@@ -0,0 +1,117 @@
|
|
|
1
|
+
// modules/platform-identity/invite-authz.js — WHO may invite a builder into a project
|
|
2
|
+
// (POST /projects/invite). Task 1003580 GAP 2, goal 1000046 criterion C6, unblocking the
|
|
3
|
+
// wizard's invite step (BV1.R27, task 1002346).
|
|
4
|
+
//
|
|
5
|
+
// TWO DOORS, DELIBERATELY DIFFERENT KINDS — the scouting-authz.js shape (ADR 0210), which is
|
|
6
|
+
// this codebase's design of record for owner-or-rank:
|
|
7
|
+
//
|
|
8
|
+
// RANK — `project.curate`, floor metic (ADR 0157). The hub CURATOR's door, unchanged:
|
|
9
|
+
// the atom, the 403 body, the floors map. Nothing about it moves here.
|
|
10
|
+
// OWNERSHIP — the project's own owner, for their own project. The whole of what this adds.
|
|
11
|
+
//
|
|
12
|
+
// WHY THE RANK DOOR ALONE WAS A DEAD END. The creation wizard's audience is any signed-in
|
|
13
|
+
// GitHub user — typically a `xenos` on the hub — and `requirePermission` is purely
|
|
14
|
+
// grant/rank-based with no own-scope branch. So the person who created a project got 403 on
|
|
15
|
+
// inviting anyone to it, and no floor low enough to admit them excludes anybody at all.
|
|
16
|
+
//
|
|
17
|
+
// WHERE THE OWNERSHIP PROOF COMES FROM, AND WHERE IT MUST NOT. `platform_identity_sso_clients
|
|
18
|
+
// .owner_github_id` and `platform_identity_projects.owner_github_id` are ATTRIBUTION, not
|
|
19
|
+
// authority — their own migration says so and ADR 0238 restates it. The authority is
|
|
20
|
+
// `provisioning_instances.owner_builder_id`, the fact the manage view already trusts and
|
|
21
|
+
// `instanceAccessDenied` already enforces. This module may not import provisioning (ADR 0083's
|
|
22
|
+
// one-way rule), so the fact travels on the kernel port `provisioning.projectOwnedBy` —
|
|
23
|
+
// resolveOptional and NOT declared in `consumes` (the `provisioning.projectPlanets`
|
|
24
|
+
// precedent): provisioning is default-off, and a hub running without it simply has no
|
|
25
|
+
// control-plane project to own.
|
|
26
|
+
//
|
|
27
|
+
// THE REFUSAL IS NOT AN ORACLE, IN BODY OR IN LATENCY. Ownership is asked before the target is
|
|
28
|
+
// resolved and before the body validator, and every path does the same two reads, so a
|
|
29
|
+
// stranger's 403 is identical — and identically slow — for a real project, a stealth one
|
|
30
|
+
// (ADR 0182 D2a), one that does not exist, and a malformed body.
|
|
31
|
+
//
|
|
32
|
+
// THE PORT IS ASKED ABOUT BOTH HALVES OF THE PROJECTION. ADR 0246 puts a control-plane project
|
|
33
|
+
// on the map as `client_id = slug` at `origin = https://<domain>`, so the question is "do you
|
|
34
|
+
// own the instance carrying BOTH", never "do you own the slug". A hand-seeded catalog row's
|
|
35
|
+
// name is squattable in `provisioning_instances` — the catalog's own claim rule already
|
|
36
|
+
// refuses to overwrite such a row, and this arm answers to the same binding rather than
|
|
37
|
+
// handing its owner's name to whoever registers an instance called that.
|
|
38
|
+
//
|
|
39
|
+
// IT GRANTS NOTHING ELSE (ADR 0016). Owning a project buys exactly one act on the hub:
|
|
40
|
+
// pre-seeding a `pending` membership on your own project. It confers no rank, no curation, no
|
|
41
|
+
// read of anyone else's project, and nothing else consults it.
|
|
42
|
+
// Proof: ../../tests/project_invite_ownership.mjs
|
|
43
|
+
'use strict';
|
|
44
|
+
|
|
45
|
+
const api = require('../../src/module-api');
|
|
46
|
+
const pi = require('./platform-identity');
|
|
47
|
+
|
|
48
|
+
// The kernel port the ownership fact travels on. Resolved BY NAME at call time through the
|
|
49
|
+
// doorway, never imported — provisioning is a sibling module (ADR 0083).
|
|
50
|
+
const OWNERSHIP_PORT = 'provisioning.projectOwnedBy';
|
|
51
|
+
|
|
52
|
+
// The host a catalog origin names, which is the `provisioning_instances.domain` the projection
|
|
53
|
+
// was keyed on. An unparseable origin has no host and therefore no owner. PURE.
|
|
54
|
+
function hostOfOrigin(origin) {
|
|
55
|
+
try { return new URL(String(origin)).hostname.toLowerCase(); } catch { return ''; }
|
|
56
|
+
}
|
|
57
|
+
|
|
58
|
+
// callerOwnsProject(req, { pool }) — is this caller the owner of the control-plane project the
|
|
59
|
+
// requested catalog row was projected from? Fail-closed on every unhappy path: a non-string
|
|
60
|
+
// key (only a string names a project — `String(['x'])` must not become a claim), an
|
|
61
|
+
// unauthenticated caller, no provisioning module.
|
|
62
|
+
//
|
|
63
|
+
// SAME WORK ON EVERY PATH, which is the timing half of "the refusal is not an oracle". An
|
|
64
|
+
// unknown client is asked about anyway — `hostOfOrigin(null)` is the empty host, which
|
|
65
|
+
// `projectOwnedBy` still queries and which matches nothing — so a stranger cannot separate
|
|
66
|
+
// "this project exists" from "it does not" by measuring how long the identical 403 took to
|
|
67
|
+
// arrive. A body-identical refusal that is measurably faster is still an oracle.
|
|
68
|
+
//
|
|
69
|
+
// The resolved row rides forward on `req.inviteTargetClient` (the `req.builder` /
|
|
70
|
+
// `req.rawPermissionKeys` precedent) so equalising the lookup does not duplicate it: the
|
|
71
|
+
// handler needs this same row, and re-reading it would be pure waste on every admitted call.
|
|
72
|
+
async function callerOwnsProject(req, { pool }) {
|
|
73
|
+
const clientId = req.body && req.body.client_id;
|
|
74
|
+
if (typeof clientId !== 'string' || clientId === '') return false;
|
|
75
|
+
const builderId = req.builder && req.builder.id;
|
|
76
|
+
if (!builderId) return false;
|
|
77
|
+
const ownedBy = api.resolveOptional(OWNERSHIP_PORT);
|
|
78
|
+
if (typeof ownedBy !== 'function') return false;
|
|
79
|
+
const client = await pi.getClient(clientId, { pool });
|
|
80
|
+
if (client) req.inviteTargetClient = client;
|
|
81
|
+
return (await ownedBy({ slug: clientId, host: hostOfOrigin(client && client.origin), builderId })) === true;
|
|
82
|
+
}
|
|
83
|
+
|
|
84
|
+
// requireProjectInviter({ curateGate, pool, log }) — the OR gate as one middleware, mounted
|
|
85
|
+
// after requireBuilder. `curateGate` is the ALREADY-BUILT `requirePermission('project.curate')`
|
|
86
|
+
// middleware: the atom stays spelled in the route's own middleware list, where
|
|
87
|
+
// route-rank-check.js and gen-api-docs.js can see it, so widening the door cannot make the
|
|
88
|
+
// route's recorded rank read looser than it is.
|
|
89
|
+
//
|
|
90
|
+
// ORDER IS THE DESIGN, and it is what keeps the refusal from becoming an existence oracle.
|
|
91
|
+
// Ownership is asked FIRST; when it answers yes the request proceeds and the permission gate
|
|
92
|
+
// never runs. When it answers no — for ANY reason, including "no such project" — the request
|
|
93
|
+
// falls through to the UNMODIFIED permission gate, so a caller who is neither owner nor
|
|
94
|
+
// curator gets exactly the 403 this route has always produced: same code, same required/held,
|
|
95
|
+
// same floors map. A stranger therefore cannot tell a stealth project (ADR 0182 D2a) from one
|
|
96
|
+
// that does not exist, and cannot tell either from a malformed body — the gate still runs
|
|
97
|
+
// before the body validator, exactly as `requirePermission` always did. The widening can only
|
|
98
|
+
// ever ADMIT; it cannot change, soften, or swallow a refusal.
|
|
99
|
+
//
|
|
100
|
+
// FAIL-CLOSED ON THE OWNERSHIP QUESTION ITSELF. A database blip while asking "is this your
|
|
101
|
+
// project" must not admit, and must not 500 either: it falls to the permission gate, which
|
|
102
|
+
// denies unless the caller holds the atom. The failure mode of the new door is the old door.
|
|
103
|
+
function requireProjectInviter({ curateGate, pool, log }) {
|
|
104
|
+
return async function projectInviterGate(req, res, next) {
|
|
105
|
+
try {
|
|
106
|
+
if (await callerOwnsProject(req, { pool })) return next();
|
|
107
|
+
} catch (err) {
|
|
108
|
+
// Message only — a query error can carry row data (the requirePermission precedent).
|
|
109
|
+
log.error({ err: err && err.message }, 'project invite owner check failed — falling back to the permission gate');
|
|
110
|
+
}
|
|
111
|
+
return curateGate(req, res, next);
|
|
112
|
+
};
|
|
113
|
+
}
|
|
114
|
+
|
|
115
|
+
module.exports = {
|
|
116
|
+
requireProjectInviter,
|
|
117
|
+
};
|
|
@@ -12,6 +12,8 @@
|
|
|
12
12
|
// GET /projects — Archon: full curation list (+ featured flags, the stored
|
|
13
13
|
// join door, and the DERIVED publish verdict — ADR 0182)
|
|
14
14
|
// POST /projects — Archon: create / update a catalog entry
|
|
15
|
+
// POST /projects/invite — a `project.curate` holder OR the project's OWN owner:
|
|
16
|
+
// pre-seed a 'pending' membership (invite-authz.js)
|
|
15
17
|
// PATCH /projects/:id/featured — Archon: the feature / unfeature control
|
|
16
18
|
//
|
|
17
19
|
// Reaches core only through the doorway (ADR 0083). Archon routes declared first so
|
|
@@ -23,6 +25,7 @@ const api = require('../../../src/module-api');
|
|
|
23
25
|
const pi = require('../platform-identity');
|
|
24
26
|
const projectCatalog = require('../project-catalog');
|
|
25
27
|
const projectStats = require('../project-stats');
|
|
28
|
+
const inviteAuthz = require('../invite-authz');
|
|
26
29
|
|
|
27
30
|
const { pool, requireBuilder, requirePermission, validateOrRespond, parseId, corsPublicGet } = api;
|
|
28
31
|
const log = api.logger('platform-identity');
|
|
@@ -105,28 +108,52 @@ module.exports = function projectsRoutes() {
|
|
|
105
108
|
}
|
|
106
109
|
});
|
|
107
110
|
|
|
108
|
-
//
|
|
109
|
-
//
|
|
110
|
-
//
|
|
111
|
-
//
|
|
112
|
-
|
|
113
|
-
|
|
114
|
-
|
|
115
|
-
|
|
116
|
-
|
|
117
|
-
|
|
118
|
-
|
|
119
|
-
|
|
120
|
-
|
|
121
|
-
|
|
122
|
-
|
|
123
|
-
|
|
124
|
-
|
|
125
|
-
|
|
126
|
-
|
|
127
|
-
|
|
128
|
-
|
|
129
|
-
|
|
111
|
+
// The atom is spelled in the middleware list below, not hidden inside
|
|
112
|
+
// requireProjectInviter, so route-rank-check.js and gen-api-docs.js classify this
|
|
113
|
+
// route from its real gate. A helper-hidden gate would record a privileged route
|
|
114
|
+
// as any-builder — wrong in the dangerous direction (the ADR 0210 rule).
|
|
115
|
+
|
|
116
|
+
// rank: metic+archon — own-or-metic in effect: invite a builder into a project
|
|
117
|
+
// (ADR 0141 §5, task #1002115), called by a `project.curate` holder OR the project's OWN
|
|
118
|
+
// OWNER (task 1003580; the ownership proof is `provisioning_instances.owner_builder_id`,
|
|
119
|
+
// reached through a port — see invite-authz.js). The wizard's audience is any signed-in
|
|
120
|
+
// GitHub user, typically a xenos who used to get 403 on their own project. A caller who is
|
|
121
|
+
// neither gets the unchanged permission refusal, identical whether or not the project
|
|
122
|
+
// exists. Pre-seeds a 'pending' membership the invitee accepts from My Projects. V1 invites
|
|
123
|
+
// by github_login and requires the invitee to already have a platform account (they build
|
|
124
|
+
// on some project); inviting someone entirely new to the platform (GitHub-id resolution) is
|
|
125
|
+
// a follow-up.
|
|
126
|
+
router.post(
|
|
127
|
+
'/projects/invite',
|
|
128
|
+
requireBuilder,
|
|
129
|
+
// Ownership is asked FIRST — one client read plus one indexed LIMIT-1 lookup, the SAME two
|
|
130
|
+
// on every path so the refusal is identical in latency as well as in body. Asking the
|
|
131
|
+
// permission gate first is not available: a middleware that has denied has already SENT
|
|
132
|
+
// its response, so there is nothing to fall through from. Paying the round-trip is what
|
|
133
|
+
// keeps the 403 byte-identical to the one this route has always produced (ADR 0210 D2).
|
|
134
|
+
// The gate leaves the resolved client on `req.inviteTargetClient` for the handler below.
|
|
135
|
+
inviteAuthz.requireProjectInviter({ curateGate: api.requirePermission('project.curate'), pool, log }),
|
|
136
|
+
async (req, res) => {
|
|
137
|
+
if (validateOrRespond(req, res, {
|
|
138
|
+
client_id: { required: true, type: 'string', maxLength: 200 },
|
|
139
|
+
github_login: { required: true, type: 'string', maxLength: 200 },
|
|
140
|
+
})) return;
|
|
141
|
+
try {
|
|
142
|
+
// The gate already resolved this exact row (it must, to answer the ownership
|
|
143
|
+
// question); reusing it keeps the equalised lookup from becoming a duplicated one.
|
|
144
|
+
// It is only ever absent when the gate found nothing, so the fallback still reads.
|
|
145
|
+
const client = req.inviteTargetClient || await pi.getClient(req.body.client_id, { pool });
|
|
146
|
+
if (!client || client.status !== 'active') return res.fail('unknown_project', 404);
|
|
147
|
+
const account = await pi.getAccountByLogin(req.body.github_login, { pool });
|
|
148
|
+
if (!account) return res.fail('account_not_found', { status: 404, message: 'That builder has no platform account yet — they must sign in somewhere once before they can be invited.' });
|
|
149
|
+
const out = await pi.inviteToProject({ clientId: req.body.client_id, githubId: account.github_id }, { pool });
|
|
150
|
+
res.status(out.invited ? 201 : 200).json(out);
|
|
151
|
+
} catch (err) {
|
|
152
|
+
console.error('[platform-identity] POST /projects/invite', err);
|
|
153
|
+
res.fail('invite_failed', { status: 500, message: 'internal error' });
|
|
154
|
+
}
|
|
155
|
+
},
|
|
156
|
+
);
|
|
130
157
|
|
|
131
158
|
// rank: archon — the feature / unfeature control (the ADR 0141 §5 curation gate),
|
|
132
159
|
// BOUNDED BY THE PUBLISH GATE (ADR 0182 D3, task 1002335). Featuring ranks among
|
|
@@ -14,6 +14,6 @@
|
|
|
14
14
|
"migrations": true,
|
|
15
15
|
"pollers": ["liveness-sweep"]
|
|
16
16
|
},
|
|
17
|
-
"provides": ["provisioning.instanceState", "provisioning.projectPlanets"],
|
|
17
|
+
"provides": ["provisioning.instanceState", "provisioning.projectPlanets", "provisioning.projectOwnedBy"],
|
|
18
18
|
"consumes": []
|
|
19
19
|
}
|